From nobody Fri May 10 13:01:57 2024 Delivered-To: importer@patchew.org Received-SPF: pass (zohomail.com: domain of _spf.google.com designates 209.85.221.44 as permitted sender) client-ip=209.85.221.44; envelope-from=philippe.mathieu.daude@gmail.com; helo=mail-wr1-f44.google.com; Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of _spf.google.com designates 209.85.221.44 as permitted sender) smtp.mailfrom=philippe.mathieu.daude@gmail.com Received: from mail-wr1-f44.google.com (mail-wr1-f44.google.com [209.85.221.44]) by mx.zohomail.com with SMTPS id 161374583354784.8867941217386; Fri, 19 Feb 2021 06:43:53 -0800 (PST) Received: by mail-wr1-f44.google.com with SMTP id h98so4064394wrh.11 for ; Fri, 19 Feb 2021 06:43:52 -0800 (PST) Return-Path: Return-Path: Received: from localhost.localdomain (68.red-83-57-175.dynamicip.rima-tde.net. [83.57.175.68]) by smtp.gmail.com with ESMTPSA id v11sm14007744wrr.3.2021.02.19.06.43.50 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 19 Feb 2021 06:43:51 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=sender:from:to:cc:subject:date:message-id:mime-version :content-transfer-encoding; bh=aHCgSRZLeBErlxsFQTR8al0Db1JIpta/9oAzTWbZfz0=; b=dME+3uf2unXI3bFqf152S2zkPGamHWDasjHkpnz0XsqQ4lo2GTcJc8VP9yn1eUvGtz QfW+Em4/8EuQySdzLQyMx/SrB9SIpcCxCVZvi+zyn1ZVKqjQxx8sSNkJq7Ctc03uYA+9 Kh+Ir74tVNmEkC2uMj6x1+fbNp9GPkw3yqMCIsiuc0kSa9IxQEfM8/TVPZEkws7Vcg65 L62hgtReQAVK09BPs0LiUjAbeV/azI1pN+MCmxVOsTbREdNRm+Jwj266p4DQWSZM61uB s/zumAH5jCugMO5EF+JmIcwwgowAonDNIlIrm42iawapG6PXVLrQNpeNwg6+5QlHHdNv 7j/g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:sender:from:to:cc:subject:date:message-id :mime-version:content-transfer-encoding; bh=aHCgSRZLeBErlxsFQTR8al0Db1JIpta/9oAzTWbZfz0=; b=F8v09PPFzJYrGk0PihilbOisYAq7ecbtQ7noc7XSu/LWMb7mPDmLkoLPpwNtBlH1cR WhQPRkNh4qeG8U5Uc8JL/k9wTmn73al7L/C7yl1naabQRS5fDKZx2RuqlDkRGawEha/Q CyQdPr8CoUd50UDIZ1GZiUtPJVhPm9IsuZ2IXBI52qD8zy4FenP9kclyCcjV/PWqbRJ3 beGl7Rpp2LFS8hkGwcVwRaKrXfqjfiVQJGLicyhD+qvaQFUkB23O9Yal5IkAnM9nA+na oBC4jVeiLTpbF7ejl2jAA025/NvZTDwFGKVrVdVhhDw9lFdmM9xTCGMhmmJ7WNTgEH1/ R1cA== X-Gm-Message-State: AOAM530v2G0MOYBJKFoEMwv6qYAA1To0D++igIO0mcRxZSzP4cGpO7WG 8f4wSKx5Qmid35HkJrPXBuc= X-Google-Smtp-Source: ABdhPJzmyc+xESg1uMCEnz1jxJM6yoGNe1+rFK+utpWsQdqoUJd5+nk1sC0rnVPYESehCFr/p9Njqg== X-Received: by 2002:adf:ce06:: with SMTP id p6mr7924067wrn.406.1613745831840; Fri, 19 Feb 2021 06:43:51 -0800 (PST) Sender: =?UTF-8?Q?Philippe_Mathieu=2DDaud=C3=A9?= From: =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= To: qemu-devel@nongnu.org Cc: Thomas Huth , Peter Maydell , "Edgar E. Iglesias" , qemu-arm@nongnu.org, Alistair Francis , =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= Subject: [PATCH v2] hw/arm/xlnx-zynqmp: Remove obsolete 'has_rpu' property Date: Fri, 19 Feb 2021 15:43:49 +0100 Message-Id: <20210219144350.1979905-1-f4bug@amsat.org> X-Mailer: git-send-email 2.26.2 MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable X-ZohoMail-DKIM: pass (identity @gmail.com) We hint the 'has_rpu' property is no longer required since commit 6908ec448b4 ("xlnx-zynqmp: Properly support the smp command line option") which was released in QEMU v2.11.0. Beside, this device is marked 'user_creatable =3D false', so the only thing that could be setting the property is the board code that creates the device. Since the property is not user-facing, we can remove it without going through the deprecation process. Reviewed-by: Peter Maydell Signed-off-by: Philippe Mathieu-Daud=C3=A9 --- v2: Reworded per Peter suggestion --- include/hw/arm/xlnx-zynqmp.h | 2 -- hw/arm/xlnx-zynqmp.c | 6 ------ 2 files changed, 8 deletions(-) diff --git a/include/hw/arm/xlnx-zynqmp.h b/include/hw/arm/xlnx-zynqmp.h index 6f45387a173..0678b419a23 100644 --- a/include/hw/arm/xlnx-zynqmp.h +++ b/include/hw/arm/xlnx-zynqmp.h @@ -115,8 +115,6 @@ struct XlnxZynqMPState { bool secure; /* Has the ARM Virtualization extensions? */ bool virt; - /* Has the RPU subsystem? */ - bool has_rpu; =20 /* CAN bus. */ CanBusState *canbus[XLNX_ZYNQMP_NUM_CAN]; diff --git a/hw/arm/xlnx-zynqmp.c b/hw/arm/xlnx-zynqmp.c index 881847255b4..46030c1ef81 100644 --- a/hw/arm/xlnx-zynqmp.c +++ b/hw/arm/xlnx-zynqmp.c @@ -443,11 +443,6 @@ static void xlnx_zynqmp_realize(DeviceState *dev, Erro= r **errp) } } =20 - if (s->has_rpu) { - info_report("The 'has_rpu' property is no longer required, to use = the " - "RPUs just use -smp 6."); - } - xlnx_zynqmp_create_rpu(ms, s, boot_cpu, &err); if (err) { error_propagate(errp, err); @@ -646,7 +641,6 @@ static Property xlnx_zynqmp_props[] =3D { DEFINE_PROP_STRING("boot-cpu", XlnxZynqMPState, boot_cpu), DEFINE_PROP_BOOL("secure", XlnxZynqMPState, secure, false), DEFINE_PROP_BOOL("virtualization", XlnxZynqMPState, virt, false), - DEFINE_PROP_BOOL("has_rpu", XlnxZynqMPState, has_rpu, false), DEFINE_PROP_LINK("ddr-ram", XlnxZynqMPState, ddr_ram, TYPE_MEMORY_REGI= ON, MemoryRegion *), DEFINE_PROP_LINK("canbus0", XlnxZynqMPState, canbus[0], TYPE_CAN_BUS, --=20 2.26.2