From nobody Tue Feb 10 13:16:32 2026 Delivered-To: importer@patchew.org Received-SPF: pass (zohomail.com: domain of _spf.google.com designates 209.85.128.49 as permitted sender) client-ip=209.85.128.49; envelope-from=philippe.mathieu.daude@gmail.com; helo=mail-wm1-f49.google.com; Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of _spf.google.com designates 209.85.128.49 as permitted sender) smtp.mailfrom=philippe.mathieu.daude@gmail.com Received: from mail-wm1-f49.google.com (mail-wm1-f49.google.com [209.85.128.49]) by mx.zohomail.com with SMTPS id 1613659889840544.4532021685825; Thu, 18 Feb 2021 06:51:29 -0800 (PST) Received: by mail-wm1-f49.google.com with SMTP id i7so2872952wmb.0 for ; Thu, 18 Feb 2021 06:51:29 -0800 (PST) Return-Path: Return-Path: Received: from localhost.localdomain (68.red-83-57-175.dynamicip.rima-tde.net. [83.57.175.68]) by smtp.gmail.com with ESMTPSA id i3sm8559259wrr.19.2021.02.18.06.51.27 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 18 Feb 2021 06:51:27 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=sender:from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=Vrr/db47Qzv03uQ5HOCzDgMN9bgsfLjuAFvS1PFLBqU=; b=HwGfHuZKK+JqnORjAiDUI7FprIQVhz+MET9ho9AE9PFTIjATULL9HJgp+jgTy3Q+Cz 9L/WOocKYPcuYv7s25iEpvDBaXQo1waTnIRHWV0XUywqgxZZcAEU9M/40H9qkp1kypEV z13OibB8+HKx3zQsgTV5dA6BkazBjdpvQfxPfhroFuzYey7EI+AUCR/3IGmDfgQ77ZrI 1yFhWQ/JcePLLt/EuWvMiDiAcCxQuC1vBu4MBQFGnIVk8av1mqau4rsBMplci4tMIJGb kwtQdp+Q3LYRa+qXBBnNE++VM7ygclHijOuFGDaunCfrEx7q04K/nlIiAXQON0z9KyU6 7yoQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:sender:from:to:cc:subject:date:message-id :in-reply-to:references:mime-version:content-transfer-encoding; bh=Vrr/db47Qzv03uQ5HOCzDgMN9bgsfLjuAFvS1PFLBqU=; b=pLNMQuRQGyRWNepvxzcRBDYEvcOL7c2brngq7D4W+9kT1pui2u71oeTZPG1Gc0mvjF 04TZ2QaqVLSD6IkOIz/rE7TNEe5QCoX3nluKBSaFPD5ja5D/Veu+PkKWmskPmQomlXD4 B0ETybEz92n9BpzbxQrl0khJc1ctbeiVIElaFslW/g0evNY/9pt02BT0XX2IBJfjxAy2 gTWlj8Mv0doyHd/VHf6sCjViP2lXEPIHkQNxAczPHfEAp0fiqgYBGdyM37Nm5cHYMbWc hIxJ6xf3GwpVoqrZTGIXlJAx38xJxaayUve8fE6JRYOwhfhjtnAippQEINpZzvNg02Ho 3sNg== X-Gm-Message-State: AOAM530UZaIlW+/ytgYDiuAFrXJPrqX5k9Yxqm+AqYPZLPVWfFbizRd1 6r4aivOhjLc/p6oO1dJkjY0= X-Google-Smtp-Source: ABdhPJxWrufPQ3GlgGe9I1zxJzIb1uFEvuyZewJjcRhxQ0M31M4qyq6fooWdBsSpgMYVD2MBwv85Gw== X-Received: by 2002:a1c:1f4d:: with SMTP id f74mr4161072wmf.12.1613659888135; Thu, 18 Feb 2021 06:51:28 -0800 (PST) Sender: =?UTF-8?Q?Philippe_Mathieu=2DDaud=C3=A9?= From: =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= To: qemu-devel@nongnu.org Cc: Richard Henderson , Yoshinori Sato , Joe Komlodi , =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= Subject: [PATCH v2 3/5] target/sh4: Remove unused 'int access_type' argument Date: Thu, 18 Feb 2021 15:51:09 +0100 Message-Id: <20210218145111.1591763-4-f4bug@amsat.org> X-Mailer: git-send-email 2.26.2 In-Reply-To: <20210218145111.1591763-1-f4bug@amsat.org> References: <20210218145111.1591763-1-f4bug@amsat.org> MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable X-ZohoMail-DKIM: pass (identity @gmail.com) get_mmu_address() and get_physical_address() don't use their 'int access_type' argument: remove it along with ACCESS_INT in superh_cpu_tlb_fill(). Suggested-by: Richard Henderson Signed-off-by: Philippe Mathieu-Daud=C3=A9 Reviewed-by: Richard Henderson --- target/sh4/helper.c | 15 +++++++-------- 1 file changed, 7 insertions(+), 8 deletions(-) diff --git a/target/sh4/helper.c b/target/sh4/helper.c index 4303ebf018b..b49efe84916 100644 --- a/target/sh4/helper.c +++ b/target/sh4/helper.c @@ -331,7 +331,7 @@ static int find_utlb_entry(CPUSH4State * env, target_ul= ong address, int use_asid */ static int get_mmu_address(CPUSH4State * env, target_ulong * physical, int *prot, target_ulong address, - int rw, int access_type) + int rw) { int use_asid, n; tlb_t *matching =3D NULL; @@ -398,7 +398,7 @@ static int get_mmu_address(CPUSH4State * env, target_ul= ong * physical, =20 static int get_physical_address(CPUSH4State * env, target_ulong * physical, int *prot, target_ulong address, - int rw, int access_type) + int rw) { /* P1, P2 and P4 areas do not use translation */ if ((address >=3D 0x80000000 && address < 0xc0000000) || address >=3D = 0xe0000000) { @@ -432,7 +432,7 @@ static int get_physical_address(CPUSH4State * env, targ= et_ulong * physical, } =20 /* We need to resort to the MMU */ - return get_mmu_address(env, physical, prot, address, rw, access_type); + return get_mmu_address(env, physical, prot, address, rw); } =20 hwaddr superh_cpu_get_phys_page_debug(CPUState *cs, vaddr addr) @@ -441,7 +441,8 @@ hwaddr superh_cpu_get_phys_page_debug(CPUState *cs, vad= dr addr) target_ulong physical; int prot; =20 - get_physical_address(&cpu->env, &physical, &prot, addr, MMU_DATA_LOAD,= 0); + get_physical_address(&cpu->env, &physical, &prot, addr, MMU_DATA_LOAD); + return physical; } =20 @@ -813,11 +814,9 @@ bool superh_cpu_tlb_fill(CPUState *cs, vaddr address, = int size, MMU_DTLB_VIOLATION_READ); #else target_ulong physical; - int prot, sh_access_type; + int prot; =20 - sh_access_type =3D ACCESS_INT; - ret =3D get_physical_address(env, &physical, &prot, address, - access_type, sh_access_type); + ret =3D get_physical_address(env, &physical, &prot, address, access_ty= pe); =20 if (ret =3D=3D MMU_OK) { address &=3D TARGET_PAGE_MASK; --=20 2.26.2