From nobody Mon Feb 9 02:50:48 2026 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=fail; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=fail(p=none dis=none) header.from=redhat.com ARC-Seal: i=1; a=rsa-sha256; t=1613657348; cv=none; d=zohomail.com; s=zohoarc; b=kKQ9VJnmfd/W8vAXjpVIDsSNTK+0HYYENif7ncGQ/kBBfDKhlIpgtLZ0UDPmvnhC0f5mt9aLawMEIod8oWdDKTER/bD/k08Jv2AzZKN+QeIxD9ysOtruOBaI7ntek1VBPbRcnrM9uMf0XhOlCElktmKeQ369T7n56n8Rf3OwVfI= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1613657348; h=Content-Type:Content-Transfer-Encoding:Cc:Date:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:To; bh=14p+j/CpjB0GM1QQbxolieRgFGzs9w3/Zsqc0TRnMgI=; b=N8l2bQeTdNFUWsojL4hGbQXKwp0TnYNY3uTIi1y0tAYbyu21IVQ6X8S7kb8ANsxDF4TrRZF8FjRQS7bNnoL8QSXWZImMq7mpkqdl/kJg/eCJijgkkwutnTULB/9nDlubVn2EaxSbNvVP95McXUFPYKJN2sdMvRja9IlXJphbaK0= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=fail; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=fail header.from= (p=none dis=none) header.from= Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1613657348036626.847046281943; Thu, 18 Feb 2021 06:09:08 -0800 (PST) Received: from localhost ([::1]:42790 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1lCjzN-00077g-EY for importer@patchew.org; Thu, 18 Feb 2021 09:09:05 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]:52160) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1lCjtE-00019i-0I for qemu-devel@nongnu.org; Thu, 18 Feb 2021 09:02:44 -0500 Received: from us-smtp-delivery-124.mimecast.com ([63.128.21.124]:25918) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA1:256) (Exim 4.90_1) (envelope-from ) id 1lCjtB-0002j1-H8 for qemu-devel@nongnu.org; Thu, 18 Feb 2021 09:02:43 -0500 Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-248-fnfrNYH9NfyFGdYfVw8oLA-1; Thu, 18 Feb 2021 09:02:36 -0500 Received: from smtp.corp.redhat.com (int-mx04.intmail.prod.int.phx2.redhat.com [10.5.11.14]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id B8E16801995; Thu, 18 Feb 2021 14:02:34 +0000 (UTC) Received: from laptop.redhat.com (ovpn-114-34.ams2.redhat.com [10.36.114.34]) by smtp.corp.redhat.com (Postfix) with ESMTP id 002B05D9C6; Thu, 18 Feb 2021 14:02:29 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1613656958; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=14p+j/CpjB0GM1QQbxolieRgFGzs9w3/Zsqc0TRnMgI=; b=Vx09lqDYoawkumYjh3e/oHrIqGRYey8yAi+3hGs2n/jMvNqWQZS3t7iMZs7pCBA1UM5OL4 C/yZnzckY9c7/SLhDCnHehYi9QMhHb71G+Jxrk4UbHlDsynJo5Nx8JUT/rMOy54C5fbkgO lLzPzzFTriwqLk1kuVl2FKXLskHiRZU= X-MC-Unique: fnfrNYH9NfyFGdYfVw8oLA-1 From: Eric Auger To: eric.auger.pro@gmail.com, eric.auger@redhat.com, qemu-devel@nongnu.org, qemu-arm@nongnu.org, peter.maydell@linaro.org Subject: [PATCH 1/3] hw/arm/smmu-common: Fix smmu_iotlb_inv_iova when asid is not set Date: Thu, 18 Feb 2021 15:02:17 +0100 Message-Id: <20210218140219.423983-2-eric.auger@redhat.com> In-Reply-To: <20210218140219.423983-1-eric.auger@redhat.com> References: <20210218140219.423983-1-eric.auger@redhat.com> MIME-Version: 1.0 X-Scanned-By: MIMEDefang 2.79 on 10.5.11.14 Authentication-Results: relay.mimecast.com; auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=eric.auger@redhat.com X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Transfer-Encoding: quoted-printable Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Received-SPF: pass client-ip=63.128.21.124; envelope-from=eric.auger@redhat.com; helo=us-smtp-delivery-124.mimecast.com X-Spam_score_int: -27 X-Spam_score: -2.8 X-Spam_bar: -- X-Spam_report: (-2.8 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.001, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_LOW=-0.7, RCVD_IN_MSPIKE_H4=0.001, RCVD_IN_MSPIKE_WL=0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: jasowang@redhat.com, jiangkunkun@huawei.com, peterx@redhat.com, shameerali.kolothum.thodi@huawei.com Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: "Qemu-devel" X-ZohoMail-DKIM: fail (Header signature does not verify) Content-Type: text/plain; charset="utf-8" If the asid is not set, do not attempt to locate the key directly as all inserted keys have a valid asid. Use g_hash_table_foreach_remove instead. Signed-off-by: Eric Auger --- hw/arm/smmu-common.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/hw/arm/smmu-common.c b/hw/arm/smmu-common.c index 405d5c5325..e9ca3aebb2 100644 --- a/hw/arm/smmu-common.c +++ b/hw/arm/smmu-common.c @@ -151,7 +151,7 @@ inline void smmu_iotlb_inv_iova(SMMUState *s, int asid, dma_addr_t iova, uint8_t tg, uint64_t num_pages, uint8_t ttl) { - if (ttl && (num_pages =3D=3D 1)) { + if (ttl && (num_pages =3D=3D 1) && (asid >=3D 0)) { SMMUIOTLBKey key =3D smmu_get_iotlb_key(asid, iova, tg, ttl); =20 g_hash_table_remove(s->iotlb, &key); --=20 2.26.2