From nobody Tue Nov 18 22:46:00 2025 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass(p=none dis=none) header.from=redhat.com ARC-Seal: i=1; a=rsa-sha256; t=1613487096; cv=none; d=zohomail.com; s=zohoarc; b=RazqwyImsYeBcXIHezpA+5IX7BZJv0nMTbS+UhHesUKNKcohhQ4E0z7I2j/PLvT4nQzqcek+eHF0a/wxAQ1bSbohsAnP18k2G6RGBUVgrL3Vt+wVxob6f8hCrWQPD1Jdg2J8JrtCAMEmK7hNPcH+ApZd5Eu1hR6dPXKQ/6hfFxI= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1613487096; h=Content-Type:Content-Transfer-Encoding:Cc:Date:From:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:Sender:Subject:To; bh=+k9cMnEffIO+mnoD5dw3sBtOdDUmkH9rWIhuIaGyVaE=; b=lLlE7gucBs80UcNNZnpUK8M57ulUZXtxM+U0Bx7dTZdDtSK95ZNf1a6QOpJE6J1UGnRRiUv78gsAZZp5I+1ibdpaWVAs+Ic1yFRjhHcBEWtCnwuSY8zeiDHkBkCzz0Nnri81M2FoBVZRQBdUE/DfvagEakT1kmR68bJ1K6cjMaQ= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass header.from= (p=none dis=none) header.from= Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 16134870964971006.1706200764606; Tue, 16 Feb 2021 06:51:36 -0800 (PST) Received: from localhost ([::1]:38358 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1lC1hP-0006Cc-Ff for importer@patchew.org; Tue, 16 Feb 2021 09:51:35 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]:38658) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1lC1g8-0004kY-F5 for qemu-devel@nongnu.org; Tue, 16 Feb 2021 09:50:18 -0500 Received: from us-smtp-delivery-124.mimecast.com ([216.205.24.124]:38966) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA1:256) (Exim 4.90_1) (envelope-from ) id 1lC1g6-0004cr-8v for qemu-devel@nongnu.org; Tue, 16 Feb 2021 09:50:16 -0500 Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-361--gwIs9_PM8qjE_DLtaQPJw-1; Tue, 16 Feb 2021 09:50:11 -0500 Received: from smtp.corp.redhat.com (int-mx05.intmail.prod.int.phx2.redhat.com [10.5.11.15]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id 9120A100D1D2 for ; Tue, 16 Feb 2021 14:49:44 +0000 (UTC) Received: from sirius.home.kraxel.org (ovpn-114-184.ams2.redhat.com [10.36.114.184]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 3F2DC5D765; Tue, 16 Feb 2021 14:49:41 +0000 (UTC) Received: by sirius.home.kraxel.org (Postfix, from userid 1000) id AA16D180009A; Tue, 16 Feb 2021 15:49:39 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1613487013; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=+k9cMnEffIO+mnoD5dw3sBtOdDUmkH9rWIhuIaGyVaE=; b=Bm9JRrvhJtdcHYSZ641oKvcvxLTfGcsq72Z1IQVKJfX81evSN0BMB7bnG6YrA8hr6Xzl/U DCwXYAthpT7lgq0zWeXpn530xe+IhMFjtZm/v5AJ8CxPIixIz+0XXiJboh9kMwHKUjP3rl +9UrydHSYPnsq3kXxw4wKpOVE9y4cSw= X-MC-Unique: -gwIs9_PM8qjE_DLtaQPJw-1 From: Gerd Hoffmann To: qemu-devel@nongnu.org Subject: [PATCH v2] usb/pcap: set flag_setup Date: Tue, 16 Feb 2021 15:49:39 +0100 Message-Id: <20210216144939.841873-1-kraxel@redhat.com> MIME-Version: 1.0 X-Scanned-By: MIMEDefang 2.79 on 10.5.11.15 Authentication-Results: relay.mimecast.com; auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=kraxel@redhat.com X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Transfer-Encoding: quoted-printable Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Received-SPF: pass client-ip=216.205.24.124; envelope-from=kraxel@redhat.com; helo=us-smtp-delivery-124.mimecast.com X-Spam_score_int: -27 X-Spam_score: -2.8 X-Spam_bar: -- X-Spam_report: (-2.8 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.001, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_LOW=-0.7, RCVD_IN_MSPIKE_H3=0.001, RCVD_IN_MSPIKE_WL=0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Gerd Hoffmann Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: "Qemu-devel" X-ZohoMail-DKIM: pass (identity @redhat.com) Content-Type: text/plain; charset="utf-8" Without that wireshark complains about invalid control setup data for non-control transfers. Signed-off-by: Gerd Hoffmann --- hw/usb/pcap.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/hw/usb/pcap.c b/hw/usb/pcap.c index 4350989d3a71..dbff00be252e 100644 --- a/hw/usb/pcap.c +++ b/hw/usb/pcap.c @@ -127,6 +127,7 @@ static void do_usb_pcap_ctrl(FILE *fp, USBPacket *p, bo= ol setup) .xfer_type =3D usbmon_xfer_type[USB_ENDPOINT_XFER_CONTROL], .epnum =3D in ? 0x80 : 0, .devnum =3D dev->addr, + .flag_setup =3D setup ? 0 : '-', .flag_data =3D '=3D', .length =3D dev->setup_len, }; @@ -169,6 +170,7 @@ static void do_usb_pcap_data(FILE *fp, USBPacket *p, bo= ol setup) .xfer_type =3D usbmon_xfer_type[p->ep->type], .epnum =3D usbmon_epnum(p), .devnum =3D p->ep->dev->addr, + .flag_setup =3D '-', .flag_data =3D '=3D', .length =3D p->iov.size, }; --=20 2.29.2