[PULL 00/19] i386, qgraph patches for 2020-02-15

Paolo Bonzini posted 19 patches 3 years, 1 month ago
Test checkpatch failed
Patches applied successfully (tree, apply log)
git fetch https://github.com/patchew-project/qemu tags/patchew/20210215131626.65640-1-pbonzini@redhat.com
Maintainers: Halil Pasic <pasic@linux.ibm.com>, "Philippe Mathieu-Daudé" <f4bug@amsat.org>, Peter Maydell <peter.maydell@linaro.org>, Eduardo Habkost <ehabkost@redhat.com>, Thomas Huth <thuth@redhat.com>, "Michael S. Tsirkin" <mst@redhat.com>, Greg Kurz <groug@kaod.org>, Marcel Apfelbaum <marcel.apfelbaum@gmail.com>, David Hildenbrand <david@redhat.com>, Cameron Esfahani <dirty@apple.com>, Jiaxun Yang <jiaxun.yang@flygoat.com>, Aleksandar Rikalo <aleksandar.rikalo@syrmia.com>, Roman Bolshakov <r.bolshakov@yadro.com>, Markus Armbruster <armbru@redhat.com>, Richard Henderson <richard.henderson@linaro.org>, Eric Blake <eblake@redhat.com>, Huacai Chen <chenhuacai@kernel.org>, Marcelo Tosatti <mtosatti@redhat.com>, Paolo Bonzini <pbonzini@redhat.com>, Cornelia Huck <cohuck@redhat.com>, Laurent Vivier <lvivier@redhat.com>, Christian Borntraeger <borntraeger@de.ibm.com>, David Gibson <david@gibson.dropbear.id.au>, Aurelien Jarno <aurelien@aurel32.net>
There is a newer version of this series
accel/kvm/kvm-all.c                  |   6 +-
hw/i386/pc_sysfw.c                   | 130 ++++++++++++++++++++++++-
include/hw/i386/pc.h                 |   4 +
include/sysemu/cpus.h                |   2 +
include/sysemu/hw_accel.h            |   5 +
include/sysemu/kvm.h                 |  10 ++
include/sysemu/sev.h                 |   5 +
qapi/misc-target.json                |   2 +-
softmmu/cpus.c                       |   5 +
softmmu/runstate.c                   |   3 +
target/arm/kvm.c                     |   5 +
target/i386/cpu.c                    |   1 +
target/i386/cpu.h                    |   1 +
target/i386/hvf/hvf-i386.h           |  16 ----
target/i386/hvf/hvf.c                | 100 +++++++++++++++++++-
target/i386/hvf/x86_cpuid.c          |  34 ++++---
target/i386/hvf/x86_emu.c            |   5 +
target/i386/kvm/kvm.c                |  10 +-
target/i386/monitor.c                |  23 ++++-
target/i386/sev-stub.c               |  15 +++
target/i386/sev.c                    | 178 ++++++++++++++++++++++++++++++++++-
target/i386/sev_i386.h               |   2 +-
target/mips/kvm.c                    |   5 +
target/ppc/kvm.c                     |   5 +
target/s390x/kvm.c                   |   5 +
tests/qtest/libqos/qgraph.c          |  99 ++++++++++++++++++-
tests/qtest/libqos/qgraph.h          |  36 +++++++
tests/qtest/libqos/qgraph_internal.h |  12 +++
tests/qtest/qos-test.c               |  15 ++-
util/cutils.c                        |   3 +-
30 files changed, 697 insertions(+), 45 deletions(-)
[PULL 00/19] i386, qgraph patches for 2020-02-15
Posted by Paolo Bonzini 3 years, 1 month ago
The following changes since commit 41d306ec7d9885752fec434904df08b9c1aa3add:

  Merge remote-tracking branch 'remotes/bonzini-gitlab/tags/for-upstream' into staging (2021-02-09 10:04:51 +0000)

are available in the Git repository at:

  https://gitlab.com/bonzini/qemu.git tags/for-upstream

for you to fetch changes up to bf98b5857a101f9032377044c250ab728464bcb0:

  hvf: Fetch cr4 before evaluating CPUID(1) (2021-02-09 18:47:45 +0100)

----------------------------------------------------------------
* HVF fixes
* Extra qos-test debugging output (Christian)
* SEV secret address autodetection (James)
* SEV-ES support (Thomas)
* Relocatable paths bugfix (Stefan)

----------------------------------------------------------------
Alexander Graf (2):
      hvf: x86: Remove unused definitions
      hvf: Fetch cr4 before evaluating CPUID(1)

Hill Ma (1):
      hvf: Guard xgetbv call

James Bottomley (2):
      pc: add parser for OVMF reset block
      sev: update sev-inject-launch-secret to make gpa optional

Paolo Bonzini (1):
      sev/i386: Allow AP booting under SEV-ES

Stefan Weil (1):
      util/cutils: Skip "." when looking for next directory component

Tom Lendacky (5):
      sev/i386: Add initial support for SEV-ES
      sev/i386: Require in-kernel irqchip support for SEV-ES guests
      sev/i386: Don't allow a system reset under an SEV-ES guest
      kvm/i386: Use a per-VM check for SMM capability
      sev/i386: Enable an SEV-ES guest based on SEV policy

Vladislav Yaroshchuk (2):
      target/i386/hvf: add vmware-cpuid-freq cpu feature
      target/i386/hvf: add rdmsr 35H MSR_CORE_THREAD_COUNT

qemu_oss--- via (5):
      libqos/qgraph: add qos_node_create_driver_named()
      libqos/qgraph_internal: add qos_printf() and qos_printf_literal()
      tests/qtest/qos-test: dump qos graph if verbose
      tests/qtest/qos-test: dump environment variables if verbose
      tests/qtest/qos-test: dump QEMU command if verbose

 accel/kvm/kvm-all.c                  |   6 +-
 hw/i386/pc_sysfw.c                   | 130 ++++++++++++++++++++++++-
 include/hw/i386/pc.h                 |   4 +
 include/sysemu/cpus.h                |   2 +
 include/sysemu/hw_accel.h            |   5 +
 include/sysemu/kvm.h                 |  10 ++
 include/sysemu/sev.h                 |   5 +
 qapi/misc-target.json                |   2 +-
 softmmu/cpus.c                       |   5 +
 softmmu/runstate.c                   |   3 +
 target/arm/kvm.c                     |   5 +
 target/i386/cpu.c                    |   1 +
 target/i386/cpu.h                    |   1 +
 target/i386/hvf/hvf-i386.h           |  16 ----
 target/i386/hvf/hvf.c                | 100 +++++++++++++++++++-
 target/i386/hvf/x86_cpuid.c          |  34 ++++---
 target/i386/hvf/x86_emu.c            |   5 +
 target/i386/kvm/kvm.c                |  10 +-
 target/i386/monitor.c                |  23 ++++-
 target/i386/sev-stub.c               |  15 +++
 target/i386/sev.c                    | 178 ++++++++++++++++++++++++++++++++++-
 target/i386/sev_i386.h               |   2 +-
 target/mips/kvm.c                    |   5 +
 target/ppc/kvm.c                     |   5 +
 target/s390x/kvm.c                   |   5 +
 tests/qtest/libqos/qgraph.c          |  99 ++++++++++++++++++-
 tests/qtest/libqos/qgraph.h          |  36 +++++++
 tests/qtest/libqos/qgraph_internal.h |  12 +++
 tests/qtest/qos-test.c               |  15 ++-
 util/cutils.c                        |   3 +-
 30 files changed, 697 insertions(+), 45 deletions(-)
-- 
2.29.2


Re: [PULL 00/19] i386, qgraph patches for 2020-02-15
Posted by no-reply@patchew.org 3 years, 1 month ago
Patchew URL: https://patchew.org/QEMU/20210215131626.65640-1-pbonzini@redhat.com/



Hi,

This series seems to have some coding style problems. See output below for
more information:

Type: series
Message-id: 20210215131626.65640-1-pbonzini@redhat.com
Subject: [PULL 00/19] i386, qgraph patches for 2020-02-15

=== TEST SCRIPT BEGIN ===
#!/bin/bash
git rev-parse base > /dev/null || exit 0
git config --local diff.renamelimit 0
git config --local diff.renames True
git config --local diff.algorithm histogram
./scripts/checkpatch.pl --mailback base..
=== TEST SCRIPT END ===

Updating 3c8cf5a9c21ff8782164d1def7f44bd888713384
From https://github.com/patchew-project/qemu
 * [new tag]         patchew/20210215131626.65640-1-pbonzini@redhat.com -> patchew/20210215131626.65640-1-pbonzini@redhat.com
Auto packing the repository for optimum performance. You may also
run "git gc" manually. See "git help gc" for more information.
Switched to a new branch 'test'
6a95f4e hvf: Fetch cr4 before evaluating CPUID(1)
e627631 target/i386/hvf: add rdmsr 35H MSR_CORE_THREAD_COUNT
297058a hvf: x86: Remove unused definitions
3fe8fc7 target/i386/hvf: add vmware-cpuid-freq cpu feature
9a628d7 hvf: Guard xgetbv call
4d154f1 util/cutils: Skip "." when looking for next directory component
2e8947a tests/qtest/qos-test: dump QEMU command if verbose
8cfa8e9 tests/qtest/qos-test: dump environment variables if verbose
f38022d tests/qtest/qos-test: dump qos graph if verbose
2c6b24e libqos/qgraph_internal: add qos_printf() and qos_printf_literal()
d1caf4f libqos/qgraph: add qos_node_create_driver_named()
98ee0b1 sev/i386: Enable an SEV-ES guest based on SEV policy
714d26f kvm/i386: Use a per-VM check for SMM capability
9e2b0e5 sev/i386: Don't allow a system reset under an SEV-ES guest
d3dfd66 sev/i386: Allow AP booting under SEV-ES
e5b43f3 sev/i386: Require in-kernel irqchip support for SEV-ES guests
19f95df sev/i386: Add initial support for SEV-ES
b77496d sev: update sev-inject-launch-secret to make gpa optional
a1303e3 pc: add parser for OVMF reset block

=== OUTPUT BEGIN ===
1/19 Checking commit a1303e3cf233 (pc: add parser for OVMF reset block)
2/19 Checking commit b77496d42f50 (sev: update sev-inject-launch-secret to make gpa optional)
3/19 Checking commit 19f95df3c678 (sev/i386: Add initial support for SEV-ES)
4/19 Checking commit e5b43f3ff216 (sev/i386: Require in-kernel irqchip support for SEV-ES guests)
5/19 Checking commit d3dfd660d251 (sev/i386: Allow AP booting under SEV-ES)
ERROR: line over 90 characters
#214: FILE: target/i386/sev.c:945:
+        error_report("SEV information block/Firmware GUID Table block not found in pflash rom");

total: 1 errors, 0 warnings, 212 lines checked

Patch 5/19 has style problems, please review.  If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.

6/19 Checking commit 9e2b0e529183 (sev/i386: Don't allow a system reset under an SEV-ES guest)
7/19 Checking commit 714d26f0f4ba (kvm/i386: Use a per-VM check for SMM capability)
8/19 Checking commit 98ee0b165085 (sev/i386: Enable an SEV-ES guest based on SEV policy)
9/19 Checking commit d1caf4feaf99 (libqos/qgraph: add qos_node_create_driver_named())
10/19 Checking commit 2c6b24e8e71b (libqos/qgraph_internal: add qos_printf() and qos_printf_literal())
11/19 Checking commit f38022decc22 (tests/qtest/qos-test: dump qos graph if verbose)
12/19 Checking commit 8cfa8e9871c8 (tests/qtest/qos-test: dump environment variables if verbose)
13/19 Checking commit 2e8947a55ded (tests/qtest/qos-test: dump QEMU command if verbose)
14/19 Checking commit 4d154f170675 (util/cutils: Skip "." when looking for next directory component)
15/19 Checking commit 9a628d791ad8 (hvf: Guard xgetbv call)
16/19 Checking commit 3fe8fc76a5f4 (target/i386/hvf: add vmware-cpuid-freq cpu feature)
17/19 Checking commit 297058aca706 (hvf: x86: Remove unused definitions)
18/19 Checking commit e6276312f23f (target/i386/hvf: add rdmsr 35H MSR_CORE_THREAD_COUNT)
19/19 Checking commit 6a95f4ef5423 (hvf: Fetch cr4 before evaluating CPUID(1))
=== OUTPUT END ===

Test command exited with code: 1


The full log is available at
http://patchew.org/logs/20210215131626.65640-1-pbonzini@redhat.com/testing.checkpatch/?type=message.
---
Email generated automatically by Patchew [https://patchew.org/].
Please send your feedback to patchew-devel@redhat.com
Re: [PULL 00/19] i386, qgraph patches for 2020-02-15
Posted by Philippe Mathieu-Daudé 3 years, 1 month ago
On 2/15/21 2:16 PM, Paolo Bonzini wrote:
> The following changes since commit 41d306ec7d9885752fec434904df08b9c1aa3add:
> 
>   Merge remote-tracking branch 'remotes/bonzini-gitlab/tags/for-upstream' into staging (2021-02-09 10:04:51 +0000)
> 
> are available in the Git repository at:
> 
>   https://gitlab.com/bonzini/qemu.git tags/for-upstream
> 
> for you to fetch changes up to bf98b5857a101f9032377044c250ab728464bcb0:
> 
>   hvf: Fetch cr4 before evaluating CPUID(1) (2021-02-09 18:47:45 +0100)
> 
> ----------------------------------------------------------------
> * HVF fixes
> * Extra qos-test debugging output (Christian)
> * SEV secret address autodetection (James)
> * SEV-ES support (Thomas)
> * Relocatable paths bugfix (Stefan)
> 
> ----------------------------------------------------------------
...

> qemu_oss--- via (5):
>       libqos/qgraph: add qos_node_create_driver_named()
>       libqos/qgraph_internal: add qos_printf() and qos_printf_literal()
>       tests/qtest/qos-test: dump qos graph if verbose
>       tests/qtest/qos-test: dump environment variables if verbose
>       tests/qtest/qos-test: dump QEMU command if verbose

For these patches the author is Christian Schoenebeck.


Re: [PULL 00/19] i386, qgraph patches for 2020-02-15
Posted by Thomas Huth 3 years, 1 month ago
On 15/02/2021 14.16, Paolo Bonzini wrote:
> The following changes since commit 41d306ec7d9885752fec434904df08b9c1aa3add:
> 
>    Merge remote-tracking branch 'remotes/bonzini-gitlab/tags/for-upstream' into staging (2021-02-09 10:04:51 +0000)
> 
> are available in the Git repository at:
> 
>    https://gitlab.com/bonzini/qemu.git tags/for-upstream
> 
> for you to fetch changes up to bf98b5857a101f9032377044c250ab728464bcb0:
> 
>    hvf: Fetch cr4 before evaluating CPUID(1) (2021-02-09 18:47:45 +0100)
> 
> ----------------------------------------------------------------
> * HVF fixes
> * Extra qos-test debugging output (Christian)
> * SEV secret address autodetection (James)
> * SEV-ES support (Thomas)
> * Relocatable paths bugfix (Stefan)
> 
> ----------------------------------------------------------------
> Alexander Graf (2):
>        hvf: x86: Remove unused definitions
>        hvf: Fetch cr4 before evaluating CPUID(1)
> 
> Hill Ma (1):
>        hvf: Guard xgetbv call
> 
> James Bottomley (2):
>        pc: add parser for OVMF reset block
>        sev: update sev-inject-launch-secret to make gpa optional
> 
> Paolo Bonzini (1):
>        sev/i386: Allow AP booting under SEV-ES
> 
> Stefan Weil (1):
>        util/cutils: Skip "." when looking for next directory component
> 
> Tom Lendacky (5):
>        sev/i386: Add initial support for SEV-ES
>        sev/i386: Require in-kernel irqchip support for SEV-ES guests
>        sev/i386: Don't allow a system reset under an SEV-ES guest
>        kvm/i386: Use a per-VM check for SMM capability
>        sev/i386: Enable an SEV-ES guest based on SEV policy
> 
> Vladislav Yaroshchuk (2):
>        target/i386/hvf: add vmware-cpuid-freq cpu feature
>        target/i386/hvf: add rdmsr 35H MSR_CORE_THREAD_COUNT
> 
> qemu_oss--- via (5):
>        libqos/qgraph: add qos_node_create_driver_named()
>        libqos/qgraph_internal: add qos_printf() and qos_printf_literal()
>        tests/qtest/qos-test: dump qos graph if verbose
>        tests/qtest/qos-test: dump environment variables if verbose
>        tests/qtest/qos-test: dump QEMU command if verbose

Looks like Christian's "From:" got mangled ...

  Thomas


Re: [PULL 00/19] i386, qgraph patches for 2020-02-15
Posted by Eric Blake 3 years, 1 month ago
On 2/15/21 7:16 AM, Paolo Bonzini wrote:
> The following changes since commit 41d306ec7d9885752fec434904df08b9c1aa3add:
> 
>   Merge remote-tracking branch 'remotes/bonzini-gitlab/tags/for-upstream' into staging (2021-02-09 10:04:51 +0000)
> 
> are available in the Git repository at:
> 
>   https://gitlab.com/bonzini/qemu.git tags/for-upstream
> 
> for you to fetch changes up to bf98b5857a101f9032377044c250ab728464bcb0:
> 
>   hvf: Fetch cr4 before evaluating CPUID(1) (2021-02-09 18:47:45 +0100)
> 

> qemu_oss--- via (5):
>       libqos/qgraph: add qos_node_create_driver_named()
>       libqos/qgraph_internal: add qos_printf() and qos_printf_literal()
>       tests/qtest/qos-test: dump qos graph if verbose
>       tests/qtest/qos-test: dump environment variables if verbose
>       tests/qtest/qos-test: dump QEMU command if verbose

If we take this pull request as-is, we'll need a followup patch to
.mailmap to clean up the mess made by the list software.  If there's
still time, it may be easier for Paolo to spin a v2 pull request with
updated authorship information.

-- 
Eric Blake, Principal Software Engineer
Red Hat, Inc.           +1-919-301-3226
Virtualization:  qemu.org | libvirt.org


Re: [PULL 00/19] i386, qgraph patches for 2020-02-15
Posted by Peter Maydell 3 years, 1 month ago
On Mon, 15 Feb 2021 at 21:37, Eric Blake <eblake@redhat.com> wrote:
>
> On 2/15/21 7:16 AM, Paolo Bonzini wrote:
> > The following changes since commit 41d306ec7d9885752fec434904df08b9c1aa3add:
> >
> >   Merge remote-tracking branch 'remotes/bonzini-gitlab/tags/for-upstream' into staging (2021-02-09 10:04:51 +0000)
> >
> > are available in the Git repository at:
> >
> >   https://gitlab.com/bonzini/qemu.git tags/for-upstream
> >
> > for you to fetch changes up to bf98b5857a101f9032377044c250ab728464bcb0:
> >
> >   hvf: Fetch cr4 before evaluating CPUID(1) (2021-02-09 18:47:45 +0100)
> >
>
> > qemu_oss--- via (5):
> >       libqos/qgraph: add qos_node_create_driver_named()
> >       libqos/qgraph_internal: add qos_printf() and qos_printf_literal()
> >       tests/qtest/qos-test: dump qos graph if verbose
> >       tests/qtest/qos-test: dump environment variables if verbose
> >       tests/qtest/qos-test: dump QEMU command if verbose
>
> If we take this pull request as-is, we'll need a followup patch to
> .mailmap to clean up the mess made by the list software.  If there's
> still time, it may be easier for Paolo to spin a v2 pull request with
> updated authorship information.

I have indeed dropped this from my to-handle queue.

-- PMM