From nobody Wed Nov 19 00:14:30 2025 Delivered-To: importer@patchew.org Received-SPF: pass (zohomail.com: domain of _spf.google.com designates 209.85.221.51 as permitted sender) client-ip=209.85.221.51; envelope-from=philippe.mathieu.daude@gmail.com; helo=mail-wr1-f51.google.com; Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of _spf.google.com designates 209.85.221.51 as permitted sender) smtp.mailfrom=philippe.mathieu.daude@gmail.com ARC-Seal: i=1; a=rsa-sha256; t=1613325591; cv=none; d=zohomail.com; s=zohoarc; b=PbkS+KlmZTFV8Gt9wVtQjBF29LyeHgXIbCoqHmEqMVFMI0Cr8BW/COeu7pt3C0uL5zKXATpVS+1ZoAvbfRkeUGX2aimLiBB1ZwaSPQumHPqrQoY0NqWkGwu4zT/R7bI/a283eEZjVjf5SrqiBTONnKdnAzAkRUdm5sjO7KWx4AI= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1613325591; h=Content-Type:Content-Transfer-Encoding:Cc:Date:From:In-Reply-To:MIME-Version:Message-ID:References:Sender:Subject:To; bh=FVN4+88EUUq6gz1CpRu7+tWI7TBZoJBeRwTCH0aFxfc=; b=Q+Qfi0SBJvEiSTDU7HtOJzMlPpa9kAuPdhIcOErMWdjR3uQ9rEIWaQNnkadBk2lDVVdHAttWB9U7+Oiab045sxzGDsk8QSHE61R3tcFw6YpHyPJH/qSuYCAA+nyQ4fjJebm/S4szvzrq+QI9Z2R04K/QBjnjsozvii7/iXKoxAg= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of _spf.google.com designates 209.85.221.51 as permitted sender) smtp.mailfrom=philippe.mathieu.daude@gmail.com Received: from mail-wr1-f51.google.com (mail-wr1-f51.google.com [209.85.221.51]) by mx.zohomail.com with SMTPS id 161332559167854.57414908934072; Sun, 14 Feb 2021 09:59:51 -0800 (PST) Received: by mail-wr1-f51.google.com with SMTP id v7so6058785wrr.12 for ; Sun, 14 Feb 2021 09:59:51 -0800 (PST) Return-Path: Return-Path: Received: from localhost.localdomain (68.red-83-57-175.dynamicip.rima-tde.net. [83.57.175.68]) by smtp.gmail.com with ESMTPSA id w25sm21512304wmc.42.2021.02.14.09.59.49 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sun, 14 Feb 2021 09:59:49 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=sender:from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=FVN4+88EUUq6gz1CpRu7+tWI7TBZoJBeRwTCH0aFxfc=; b=IV0wOnXbhtXN9wmDQFvxjVGIW+1egUvcoEI0HAfHqgL2nYS7szCXUDbVwgGXW93qGQ qVIweTOZQEKWEqjuqNZuko0cdsqp02gyV+2y38KBDvIkvdNS0gY91bLBlTzSLWSP4ma3 0When7iYLKwO38sBa+pny/hegFWoK4LrkxvxXrVgtm9Zm0RFZ1/9ifyG8WqO0D7Kn7gc Pg8CXEDBq7Rv+45rMw2BcObGHFjNgZ+JhjKP84gXxrqUf6gCHYacG40JTj48o15Pw+0m 2KPwYhmk/DUp9m/a1nYo4nSwrrmbklyT1vjuzPFkB1NLB11fUzadBi2XxL1yEdRkwTnM z8oA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:sender:from:to:cc:subject:date:message-id :in-reply-to:references:mime-version:content-transfer-encoding; bh=FVN4+88EUUq6gz1CpRu7+tWI7TBZoJBeRwTCH0aFxfc=; b=jZuojGKu/h9VIcxiiqBe13jPF/pAGtHQcUXPzyask9Kw0g9Z6MI2cTkXQkOQYxO4AX xdmhTghnGUD/THeTt79C4tcmeP+cvczD70o04PmQP9A7IPEZmejcBgwOIsrGQw2vkM2l c/xIZTMuMJqwQrAHYVphzeJ4KIxOG/vI38MusWr8CWiOU5yKkOmjg/kTn8LI29mKx1OU ZxhlRKuzDtt9YPn7ER660wSJ2Mqy46ldS5ZVlaLze1qAXHRje/Fvnm9CniijxubJzI5X MwBo22dFLPoTJ3nfdr5VXnKZaEU1mIwJJszFLPCp2t37NUBQVZXVhyEtyDNUkGhJAkP0 mvBQ== X-Gm-Message-State: AOAM532r++O1tlRUdzINqqFcH/2hMJxl7TOxKh4ymBAIBMs8F9FUot2z 18BaiQ6lV/rxSgglKdlaPJI= X-Google-Smtp-Source: ABdhPJz+iPc05i5t1XeIgBuCg9r18QCLHyEa4/B8EeLJUtIFR3GbWEPIbAJNxq+c/prFA49XpXRcLQ== X-Received: by 2002:adf:97d3:: with SMTP id t19mr15482042wrb.164.1613325590282; Sun, 14 Feb 2021 09:59:50 -0800 (PST) Sender: =?UTF-8?Q?Philippe_Mathieu=2DDaud=C3=A9?= From: =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= To: qemu-devel@nongnu.org Cc: Fredrik Noring , Laurent Vivier , Jiaxun Yang , =?UTF-8?q?Alex=20Benn=C3=A9e?= , =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= , "Maciej W. Rozycki" , Thomas Huth , Aurelien Jarno , Richard Henderson , Aleksandar Rikalo Subject: [RFC PATCH 07/42] target/mips/translate: Use GPR move functions in gen_HILO1_tx79() Date: Sun, 14 Feb 2021 18:58:37 +0100 Message-Id: <20210214175912.732946-8-f4bug@amsat.org> X-Mailer: git-send-email 2.26.2 In-Reply-To: <20210214175912.732946-1-f4bug@amsat.org> References: <20210214175912.732946-1-f4bug@amsat.org> MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable X-ZohoMail-DKIM: pass (identity @gmail.com) We have handy functions to access GPR. Use gen_store_gpr() for Move From HI/LO Register and gen_load_gpr() for Move To opcodes. Signed-off-by: Philippe Mathieu-Daud=C3=A9 Reviewed-by: Richard Henderson --- target/mips/translate.c | 21 ++++----------------- 1 file changed, 4 insertions(+), 17 deletions(-) diff --git a/target/mips/translate.c b/target/mips/translate.c index 16a731d3f37..a2994eb0aa6 100644 --- a/target/mips/translate.c +++ b/target/mips/translate.c @@ -4126,31 +4126,18 @@ static void gen_shift(DisasContext *ctx, uint32_t o= pc, /* Copy GPR to and from TX79 HI1/LO1 register. */ static void gen_HILO1_tx79(DisasContext *ctx, uint32_t opc, int reg) { - if (reg =3D=3D 0 && (opc =3D=3D MMI_OPC_MFHI1 || opc =3D=3D MMI_OPC_MF= LO1)) { - /* Treat as NOP. */ - return; - } - switch (opc) { case MMI_OPC_MFHI1: - tcg_gen_mov_tl(cpu_gpr[reg], cpu_HI[1]); + gen_store_gpr(cpu_HI[1], reg); break; case MMI_OPC_MFLO1: - tcg_gen_mov_tl(cpu_gpr[reg], cpu_LO[1]); + gen_store_gpr(cpu_LO[1], reg); break; case MMI_OPC_MTHI1: - if (reg !=3D 0) { - tcg_gen_mov_tl(cpu_HI[1], cpu_gpr[reg]); - } else { - tcg_gen_movi_tl(cpu_HI[1], 0); - } + gen_load_gpr(cpu_HI[1], reg); break; case MMI_OPC_MTLO1: - if (reg !=3D 0) { - tcg_gen_mov_tl(cpu_LO[1], cpu_gpr[reg]); - } else { - tcg_gen_movi_tl(cpu_LO[1], 0); - } + gen_load_gpr(cpu_LO[1], reg); break; default: MIPS_INVAL("mfthilo1 TX79"); --=20 2.26.2