From nobody Wed Nov 19 00:14:30 2025 Delivered-To: importer@patchew.org Received-SPF: pass (zohomail.com: domain of _spf.google.com designates 209.85.221.54 as permitted sender) client-ip=209.85.221.54; envelope-from=philippe.mathieu.daude@gmail.com; helo=mail-wr1-f54.google.com; Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of _spf.google.com designates 209.85.221.54 as permitted sender) smtp.mailfrom=philippe.mathieu.daude@gmail.com ARC-Seal: i=1; a=rsa-sha256; t=1613326586; cv=none; d=zohomail.com; s=zohoarc; b=NF9JBO0aExjcMZRe+mBQpnFuQIkmMWaixx5g7xT/ZhX4FuyFMH2oJokhMrRteme3Ww3jUfRzeb6d2emQLLMzdknM2vb59neAnOyMpBV6y1CQulXu5Wd2FDhjqQWhKb0V3AMRpwX9YyM1RlWqRlimKnSn0JewT5Jip74mtq1MZow= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1613326586; h=Content-Type:Content-Transfer-Encoding:Cc:Date:From:In-Reply-To:MIME-Version:Message-ID:References:Sender:Subject:To; bh=B0DaUMvL1uZYp8k8aX0o70HkV8YrP4Nv25QeZd+p2wA=; b=HE3DJz0fkH+CrFzC15fhBPdmNjFXrCMeBQXVwguQyQozUM07+tWNNZ0KvyCXKQKolac0LRvTyHChaaMPJ3Mos6g9TmwyrIti9JX8RQJ5HaRw9v9iT2wtrBNvi5qdV6eQSycthn1ZK+a2HatPgMmd9uSxpYTSOmM0WZZX39yse2o= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of _spf.google.com designates 209.85.221.54 as permitted sender) smtp.mailfrom=philippe.mathieu.daude@gmail.com Received: from mail-wr1-f54.google.com (mail-wr1-f54.google.com [209.85.221.54]) by mx.zohomail.com with SMTPS id 1613326586337229.20667444551168; Sun, 14 Feb 2021 10:16:26 -0800 (PST) Received: by mail-wr1-f54.google.com with SMTP id u14so6179189wri.3 for ; Sun, 14 Feb 2021 10:16:25 -0800 (PST) Return-Path: Return-Path: Received: from localhost.localdomain (68.red-83-57-175.dynamicip.rima-tde.net. [83.57.175.68]) by smtp.gmail.com with ESMTPSA id a84sm22132594wme.12.2021.02.14.10.00.03 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sun, 14 Feb 2021 10:00:04 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=sender:from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=B0DaUMvL1uZYp8k8aX0o70HkV8YrP4Nv25QeZd+p2wA=; b=NMP2fgy1zjpPgtT84U9cilEVBeTtfg4NO5OmhyLEhNtpDGl09f9zzmWgNi0jZYxcme R0ra/+9zGaBwqU4I7AY7KMJ/eJTQZVVigaaZH6N5VrSuHUqHtO2i6k5UdBCmPideHxDq XnS7Lza/hHkESqnbxyJOY4vr/fV3z+xdLHIOceVbVWpnxke9/aQYTH+j8Rn+LmO4I4Fa UH3vRyMmFguiWui+v3+muAX//gWHhL/9fu4enapQmdsWG2Ynowpdj6kh7/BiUP70234O PQ4QpvGT5jyb9Z9ed1zdQsBF9Rze9b//MGhWI4GT6QipyAlsXsZcv3A8ZHEO2V45kBhy MQXg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:sender:from:to:cc:subject:date:message-id :in-reply-to:references:mime-version:content-transfer-encoding; bh=B0DaUMvL1uZYp8k8aX0o70HkV8YrP4Nv25QeZd+p2wA=; b=kR7NWEbbJLvDFYhd3wxHfAvUt5H1zvWdsJwQpJlM0iJdWzcC5DgeY8/0q6vO9XAHq/ LlPKHzOCk9iZRh2lJG5+9AH4rcF9SoYCjGrxghyKmK4UzZmulKjCzG/h5XeBGvwaTXyq SJ3+TQUgUv7MRkG2byVRY/KIHmoT1/5sMe6Rtb6of3bP5UZNF9S4Dr37Q3QLMbwrxrEo eU3+zN1D+6SUHD/ttDLj6GIB684Ou1yijPGjBbNSTcYVL1eYVxKv2DaSDzuwyyslB5ZY xbihxa920z+K60MEkmgPPZng4JPI0US+jetwTvxfWQMll03mOlrBGM7bZm/2WW3OfgCi FQnA== X-Gm-Message-State: AOAM532h3CnXy0H5FJVzy0/ZA4MEWsJMxotW21ypAhdgQA2WGzykvNdr A+eh0GvbeAkkD9pmBisudwgG//f6+O8= X-Google-Smtp-Source: ABdhPJwlYjc3Gc0XII8yBOWF5dRbtptdBthLb3L4LfZNQ8DpeJXFBYBYZAqehyU8eJ2FCsaUTLXPGw== X-Received: by 2002:a5d:6803:: with SMTP id w3mr8952777wru.300.1613325605050; Sun, 14 Feb 2021 10:00:05 -0800 (PST) Sender: =?UTF-8?Q?Philippe_Mathieu=2DDaud=C3=A9?= From: =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= To: qemu-devel@nongnu.org Cc: Fredrik Noring , Laurent Vivier , Jiaxun Yang , =?UTF-8?q?Alex=20Benn=C3=A9e?= , =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= , "Maciej W. Rozycki" , Thomas Huth , Aurelien Jarno , Richard Henderson , Aleksandar Rikalo Subject: [RFC PATCH 10/42] target/mips/translate: Simplify PCPYH using deposit_i64() Date: Sun, 14 Feb 2021 18:58:40 +0100 Message-Id: <20210214175912.732946-11-f4bug@amsat.org> X-Mailer: git-send-email 2.26.2 In-Reply-To: <20210214175912.732946-1-f4bug@amsat.org> References: <20210214175912.732946-1-f4bug@amsat.org> MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable X-ZohoMail-DKIM: pass (identity @gmail.com) Simplify the PCPYH (Parallel Copy Halfword) instruction by using multiple calls to deposit_i64() which can be optimized by some TCG backends. Suggested-by: Richard Henderson Signed-off-by: Philippe Mathieu-Daud=C3=A9 Reviewed-by: Richard Henderson --- v3: Use missing rt, optimize (Richard) --- target/mips/translate.c | 34 ++++------------------------------ 1 file changed, 4 insertions(+), 30 deletions(-) diff --git a/target/mips/translate.c b/target/mips/translate.c index 7bd951d3a06..a13ad4959b4 100644 --- a/target/mips/translate.c +++ b/target/mips/translate.c @@ -24762,36 +24762,10 @@ static void gen_mmi_pcpyh(DisasContext *ctx) tcg_gen_movi_i64(cpu_gpr[rd], 0); tcg_gen_movi_i64(cpu_gpr_hi[rd], 0); } else { - TCGv_i64 t0 =3D tcg_temp_new(); - TCGv_i64 t1 =3D tcg_temp_new(); - uint64_t mask =3D (1ULL << 16) - 1; - - tcg_gen_andi_i64(t0, cpu_gpr[rt], mask); - tcg_gen_movi_i64(t1, 0); - tcg_gen_or_i64(t1, t0, t1); - tcg_gen_shli_i64(t0, t0, 16); - tcg_gen_or_i64(t1, t0, t1); - tcg_gen_shli_i64(t0, t0, 16); - tcg_gen_or_i64(t1, t0, t1); - tcg_gen_shli_i64(t0, t0, 16); - tcg_gen_or_i64(t1, t0, t1); - - tcg_gen_mov_i64(cpu_gpr[rd], t1); - - tcg_gen_andi_i64(t0, cpu_gpr_hi[rt], mask); - tcg_gen_movi_i64(t1, 0); - tcg_gen_or_i64(t1, t0, t1); - tcg_gen_shli_i64(t0, t0, 16); - tcg_gen_or_i64(t1, t0, t1); - tcg_gen_shli_i64(t0, t0, 16); - tcg_gen_or_i64(t1, t0, t1); - tcg_gen_shli_i64(t0, t0, 16); - tcg_gen_or_i64(t1, t0, t1); - - tcg_gen_mov_i64(cpu_gpr_hi[rd], t1); - - tcg_temp_free(t0); - tcg_temp_free(t1); + tcg_gen_deposit_i64(cpu_gpr[rd], cpu_gpr[rt], cpu_gpr[rt], 16, 16); + tcg_gen_deposit_i64(cpu_gpr[rd], cpu_gpr[rd], cpu_gpr[rd], 32, 32); + tcg_gen_deposit_i64(cpu_gpr_hi[rd], cpu_gpr_hi[rt], cpu_gpr_hi[rt]= , 16, 16); + tcg_gen_deposit_i64(cpu_gpr_hi[rd], cpu_gpr_hi[rd], cpu_gpr_hi[rd]= , 32, 32); } } =20 --=20 2.26.2