From nobody Wed Nov 19 00:14:30 2025 Delivered-To: importer@patchew.org Received-SPF: pass (zohomail.com: domain of _spf.google.com designates 209.85.128.46 as permitted sender) client-ip=209.85.128.46; envelope-from=philippe.mathieu.daude@gmail.com; helo=mail-wm1-f46.google.com; Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of _spf.google.com designates 209.85.128.46 as permitted sender) smtp.mailfrom=philippe.mathieu.daude@gmail.com ARC-Seal: i=1; a=rsa-sha256; t=1613325601; cv=none; d=zohomail.com; s=zohoarc; b=PZROsNLE4AMU+T62Mb0COKKOEa3fDqViMCeN7xIF1LGZEzfkjdttgr1PtwXJa4hGNlBJAuj/pRzbJFXUyeqgaiXeTr4DCDWwDmXKLQxHFkyozMRxvw4sUDyFR8mQrWAGbPXFHeSbzdHB0ELy2xGQkZq1yD63CdEVzCCtAqFlRcg= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1613325601; h=Content-Type:Content-Transfer-Encoding:Cc:Date:From:In-Reply-To:MIME-Version:Message-ID:References:Sender:Subject:To; bh=dZm99mVT7JaBB4xmS9yAUoqcDoFfjcDlrtAsNfxgXks=; b=GHGukCdCc1QtBz5GAtttwFsCxjdgUWPYWBjNwCDKUHBfqXEwupZIDq+BT3Fu/QFo+dt5Lfpm7Km3jZEpffZhGuz7eKRB2gwm0dtcNQvsdhqC5oIhkeyfs3XQTK498QfSIIPz6P3QQ2KPAhfOQBzeWB1FOuNR/5WLZMtifxSuWkY= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of _spf.google.com designates 209.85.128.46 as permitted sender) smtp.mailfrom=philippe.mathieu.daude@gmail.com Received: from mail-wm1-f46.google.com (mail-wm1-f46.google.com [209.85.128.46]) by mx.zohomail.com with SMTPS id 16133256017601011.6118299648892; Sun, 14 Feb 2021 10:00:01 -0800 (PST) Received: by mail-wm1-f46.google.com with SMTP id a16so3369877wmm.0 for ; Sun, 14 Feb 2021 10:00:00 -0800 (PST) Return-Path: Return-Path: Received: from localhost.localdomain (68.red-83-57-175.dynamicip.rima-tde.net. [83.57.175.68]) by smtp.gmail.com with ESMTPSA id i10sm26058908wrp.0.2021.02.14.09.59.58 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sun, 14 Feb 2021 09:59:59 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=sender:from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=dZm99mVT7JaBB4xmS9yAUoqcDoFfjcDlrtAsNfxgXks=; b=EOs5gU+venZRDc+Y5Ji64oU/91i+AyfEXfHxzxYRTVkFth6Gb63ulj1+EJzlfRwRew 6vjw/y0Mfv/caXtwnVptU9swDKBcmRkIAQJU+EmBgqqHdAWL7vvpg0ibQFDWr7So/7c8 56Fpu54yepoep54PytggYVx/WW7o7i86yfexetRHuXeMg4BYl1QrEVXdFUTBS3Oq+z2+ yZlG9/FrFZ46Pco+2GztsOMetViBFZsYGZBpVHVWUDsK7qA0736ANENavGKQ+gP2jJjJ +xYmn7YMh5s45DMF+ByzjJExFVus1ECiq1wx8zxsgCu2X+E839yMO6xtq2gEfobJavpT S/YA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:sender:from:to:cc:subject:date:message-id :in-reply-to:references:mime-version:content-transfer-encoding; bh=dZm99mVT7JaBB4xmS9yAUoqcDoFfjcDlrtAsNfxgXks=; b=TLGMLbSLfouPEXHnyNdZGAZoDdmFlFJrazqjVXtgExg6meCz767uSc4CppZ4pyy10/ C/iRmrYpR+yp7LCV/RVOruEOqU8jCwSsrJpZXAgELoBirlzVF6TBOCsLszS0qdBt3I03 CJJxA3pyd/0RG8LucL9eYRIPOBsjyhSHLRwspy0hGF5PwL+cyU6e+9nzUZPxgtN8gfC5 NzG2KNxJ0yOWdBev3h4F1Ztsh5zz3W1TxKv/+cYSP3SMhnS3mUR7ySnwssl3SUV3sM94 ppSeYTQWbPhN9KhU1dCzxh0+JgyiQX00h1bIud6SICuauZuJcyAY8BezrURt3F0qrjd1 6iXQ== X-Gm-Message-State: AOAM530zzKUBjTnr7diwFk4iYENXhYIalMgC8AyFNYjmlAhOXjKvXfHS TdXEwLEfnlLr5qu9QTFqiic= X-Google-Smtp-Source: ABdhPJxmuFHPLGe36k0Juo0vfNG5z5uuyMK+VRxu04t9ay3yeutSCg0/M864BbODVn39s2yMfX4CFg== X-Received: by 2002:a1c:bd84:: with SMTP id n126mr10550692wmf.173.1613325599959; Sun, 14 Feb 2021 09:59:59 -0800 (PST) Sender: =?UTF-8?Q?Philippe_Mathieu=2DDaud=C3=A9?= From: =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= To: qemu-devel@nongnu.org Cc: Fredrik Noring , Laurent Vivier , Jiaxun Yang , =?UTF-8?q?Alex=20Benn=C3=A9e?= , =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= , "Maciej W. Rozycki" , Thomas Huth , Aurelien Jarno , Richard Henderson , Aleksandar Rikalo Subject: [RFC PATCH 09/42] target/mips/tx79: Move MTHI1 / MTLO1 opcodes to decodetree Date: Sun, 14 Feb 2021 18:58:39 +0100 Message-Id: <20210214175912.732946-10-f4bug@amsat.org> X-Mailer: git-send-email 2.26.2 In-Reply-To: <20210214175912.732946-1-f4bug@amsat.org> References: <20210214175912.732946-1-f4bug@amsat.org> MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable X-ZohoMail-DKIM: pass (identity @gmail.com) Signed-off-by: Philippe Mathieu-Daud=C3=A9 Reviewed-by: Richard Henderson --- target/mips/tx79.decode | 3 +++ target/mips/translate.c | 25 ------------------------- target/mips/tx79_translate.c | 14 ++++++++++++++ 3 files changed, 17 insertions(+), 25 deletions(-) diff --git a/target/mips/tx79.decode b/target/mips/tx79.decode index 2e287ebbf36..30737da54e4 100644 --- a/target/mips/tx79.decode +++ b/target/mips/tx79.decode @@ -17,9 +17,12 @@ # Named instruction formats. These are generally used to # reduce the amount of duplication between instruction patterns. =20 +@rs ...... rs:5 ..... .......... ...... &rtype rt=3D0 rd= =3D0 sa=3D0 @rd ...... .......... rd:5 ..... ...... &rtype rs=3D0 rt= =3D0 sa=3D0 =20 ########################################################################### =20 MFHI1 011100 0000000000 ..... 00000 010000 @rd +MTHI1 011100 ..... 0000000000 00000 010001 @rs MFLO1 011100 0000000000 ..... 00000 010010 @rd +MTLO1 011100 ..... 0000000000 00000 010011 @rs diff --git a/target/mips/translate.c b/target/mips/translate.c index de67e534121..7bd951d3a06 100644 --- a/target/mips/translate.c +++ b/target/mips/translate.c @@ -1973,8 +1973,6 @@ enum { MMI_OPC_PLZCW =3D 0x04 | MMI_OPC_CLASS_MMI, MMI_OPC_CLASS_MMI0 =3D 0x08 | MMI_OPC_CLASS_MMI, MMI_OPC_CLASS_MMI2 =3D 0x09 | MMI_OPC_CLASS_MMI, - MMI_OPC_MTHI1 =3D 0x11 | MMI_OPC_CLASS_MMI, /* Same minor as OPC_= MTHI */ - MMI_OPC_MTLO1 =3D 0x13 | MMI_OPC_CLASS_MMI, /* Same minor as OPC_= MTLO */ MMI_OPC_MULT1 =3D 0x18 | MMI_OPC_CLASS_MMI, /* Same minor as OPC_= MULT */ MMI_OPC_MULTU1 =3D 0x19 | MMI_OPC_CLASS_MMI, /* Same min. as OPC_M= ULTU */ MMI_OPC_DIV1 =3D 0x1A | MMI_OPC_CLASS_MMI, /* Same minor as OPC_= DIV */ @@ -4120,25 +4118,6 @@ static void gen_shift(DisasContext *ctx, uint32_t op= c, tcg_temp_free(t1); } =20 -#if defined(TARGET_MIPS64) -/* Copy GPR to and from TX79 HI1/LO1 register. */ -static void gen_HILO1_tx79(DisasContext *ctx, uint32_t opc, int reg) -{ - switch (opc) { - case MMI_OPC_MTHI1: - gen_load_gpr(cpu_HI[1], reg); - break; - case MMI_OPC_MTLO1: - gen_load_gpr(cpu_LO[1], reg); - break; - default: - MIPS_INVAL("mfthilo1 TX79"); - gen_reserved_instruction(ctx); - break; - } -} -#endif - /* Arithmetic on HI/LO registers */ static void gen_HILO(DisasContext *ctx, uint32_t opc, int acc, int reg) { @@ -28015,10 +27994,6 @@ static void decode_mmi(CPUMIPSState *env, DisasCon= text *ctx) case MMI_OPC_DIVU1: gen_div1_tx79(ctx, opc, rs, rt); break; - case MMI_OPC_MTLO1: - case MMI_OPC_MTHI1: - gen_HILO1_tx79(ctx, opc, rs); - break; case MMI_OPC_PLZCW: /* TODO: MMI_OPC_PLZCW */ case MMI_OPC_PMFHL: /* TODO: MMI_OPC_PMFHL */ case MMI_OPC_PMTHL: /* TODO: MMI_OPC_PMTHL */ diff --git a/target/mips/tx79_translate.c b/target/mips/tx79_translate.c index 22bd6033e55..905245cece7 100644 --- a/target/mips/tx79_translate.c +++ b/target/mips/tx79_translate.c @@ -35,3 +35,17 @@ static bool trans_MFLO1(DisasContext *ctx, arg_rtype *a) =20 return true; } + +static bool trans_MTHI1(DisasContext *ctx, arg_rtype *a) +{ + gen_load_gpr(cpu_HI[1], a->rs); + + return true; +} + +static bool trans_MTLO1(DisasContext *ctx, arg_rtype *a) +{ + gen_load_gpr(cpu_LO[1], a->rs); + + return true; +} --=20 2.26.2