From nobody Tue Nov 18 22:50:33 2025 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass(p=quarantine dis=none) header.from=suse.com ARC-Seal: i=1; a=rsa-sha256; t=1613186668; cv=none; d=zohomail.com; s=zohoarc; b=c63ZuWlYkGiUipRtLiHnFX1RA5x4NWxuTXLZ9WziQeaEEkA5xoHfQsIQjdRKzuOL0AXyWE7MD6owqz1A09VVcj5ihPx63atsGFjk+ngW2J654e4oDswWiiz8zlotGVgAOsk5nu9HgZ7T+Gg4U+1RFXXDH3fPzTJqKN1HhrWqTbo= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1613186668; h=Content-Transfer-Encoding:Cc:Date:From:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:Sender:Subject:To; bh=XzTQXI3uMyqf+MRhVeLvY3GXbxJ5ZVObgaXqQQrtSTY=; b=f+uoIulv1HX69ova0Wfw4obMUflzZOBr0BZNKRd8qoP2zjEIbM7B0uAl7SKMsgdba4bS9MOSJsTcQXEwlm+wa9+Ms4y/Nw0ps/dP0NGSAa3KOvjG1S/D4Z5NboUNLYKG4lIvi/duCvdSaDcsUzCQQGrADZrNUy4cnChYRAHXwgo= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass header.from= (p=quarantine dis=none) header.from= Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1613186668413964.3418345895869; Fri, 12 Feb 2021 19:24:28 -0800 (PST) Received: from localhost ([::1]:49322 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1lAlXm-0004Hh-95 for importer@patchew.org; Fri, 12 Feb 2021 22:24:26 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]:50522) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1lAlWv-0003oG-Pn for qemu-devel@nongnu.org; Fri, 12 Feb 2021 22:23:34 -0500 Received: from mx2.suse.de ([195.135.220.15]:39292) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1lAlWs-0004In-9T for qemu-devel@nongnu.org; Fri, 12 Feb 2021 22:23:33 -0500 Received: from relay2.suse.de (unknown [195.135.221.27]) by mx2.suse.de (Postfix) with ESMTP id 6200CADE1; Sat, 13 Feb 2021 03:23:26 +0000 (UTC) X-Virus-Scanned: by amavisd-new at test-mx.suse.de DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=susede1; t=1613186606; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version: content-transfer-encoding:content-transfer-encoding; bh=XzTQXI3uMyqf+MRhVeLvY3GXbxJ5ZVObgaXqQQrtSTY=; b=Ut6Jv4pjaIi/QjpHjn56Rlui6vMarDA0w/xNb9YDz15gmzhYLRMKp2//xy08OLCMPA2SL2 6Exw9bTQ+8Fmkeo7OVoVYfE0ck0zgLQ/NuUCN7aWrOxskKODXfS/1uvp3wgmYSzpJ6uj/w j58OZUY0ptNrDvGkhDcIqmS33alSTNs= From: Bruce Rogers To: qemu-devel@nongnu.org Cc: kraxel@redhat.com, Bruce Rogers Subject: [PATCH] spice-app: avoid crash when core spice module doesn't loaded Date: Fri, 12 Feb 2021 20:23:18 -0700 Message-Id: <20210213032318.346093-1-brogers@suse.com> X-Mailer: git-send-email 2.30.0 MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Received-SPF: pass client-ip=195.135.220.15; envelope-from=brogers@suse.com; helo=mx2.suse.de X-Spam_score_int: -43 X-Spam_score: -4.4 X-Spam_bar: ---- X-Spam_report: (-4.4 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_MED=-2.3, RCVD_IN_MSPIKE_H3=0.001, RCVD_IN_MSPIKE_WL=0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: "Qemu-devel" X-ZohoMail-DKIM: pass (identity @suse.com) Content-Type: text/plain; charset="utf-8" When qemu is built with modules, but a given module doesn't load qemu should handle that gracefully. When ui-spice-core.so isn't able to be loaded and qemu is invoked with -display spice-app or -spice, qemu will dereference a null pointer. With this change we check the pointer before dereferencing and error out in a normal way. Signed-off-by: Bruce Rogers Reviewed-by: Marc-Andr=C3=A9 Lureau Reviewed-by: Philippe Mathieu-Daud=C3=A9 --- ui/spice-app.c | 8 +++++++- 1 file changed, 7 insertions(+), 1 deletion(-) diff --git a/ui/spice-app.c b/ui/spice-app.c index 026124ef56..4325ac2d9c 100644 --- a/ui/spice-app.c +++ b/ui/spice-app.c @@ -129,6 +129,7 @@ static void spice_app_atexit(void) static void spice_app_display_early_init(DisplayOptions *opts) { QemuOpts *qopts; + QemuOptsList *list; GError *err =3D NULL; =20 if (opts->has_full_screen) { @@ -159,11 +160,16 @@ static void spice_app_display_early_init(DisplayOptio= ns *opts) exit(1); } } + list =3D qemu_find_opts("spice"); + if (list =3D=3D NULL) { + error_report("spice-app missing spice support"); + exit(1); + } =20 type_register(&char_vc_type_info); =20 sock_path =3D g_strjoin("", app_dir, "/", "spice.sock", NULL); - qopts =3D qemu_opts_create(qemu_find_opts("spice"), NULL, 0, &error_ab= ort); + qopts =3D qemu_opts_create(list, NULL, 0, &error_abort); qemu_opt_set(qopts, "disable-ticketing", "on", &error_abort); qemu_opt_set(qopts, "unix", "on", &error_abort); qemu_opt_set(qopts, "addr", sock_path, &error_abort); --=20 2.30.0