From nobody Tue Nov 18 22:49:06 2025 Delivered-To: importer@patchew.org Received-SPF: pass (zohomail.com: domain of _spf.google.com designates 209.85.221.54 as permitted sender) client-ip=209.85.221.54; envelope-from=philippe.mathieu.daude@gmail.com; helo=mail-wr1-f54.google.com; Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of _spf.google.com designates 209.85.221.54 as permitted sender) smtp.mailfrom=philippe.mathieu.daude@gmail.com ARC-Seal: i=1; a=rsa-sha256; t=1613176005; cv=none; d=zohomail.com; s=zohoarc; b=B3X2CBnUWUufvB5udkRiDH6/3PIv7Ar3dluErcMQ27aYzzmRE1EkLNH6Ti4seQtWFkeqHPTb3wHgtiLoo9Q8R93G97Tq1oplHQcuIPB32dr0VjWV67DVOc9mD6zzGpytlIr3ykUJslBED+n6gXpinCw8Zwa6bT4T+hjYdPWxQWM= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1613176005; h=Content-Type:Content-Transfer-Encoding:Cc:Date:From:MIME-Version:Message-ID:Sender:Subject:To; bh=t2Bx/4DDKwq+AGPA3ntsbF3z2tZ4YW92IADITCxNa3c=; b=OKjt64Ghd0Z8L6JQOee4I27OWqFj/7IcOwezC35nrtMKwM1px8AjS63JDBeIX4+9c452g0FuG3SSRCDOwy+sXml4pEJhZIJeCqyi2W7OwxUv6RWExk6hmOMh2MgAIGDBeFuKncQZrSToPjsTc90bbCEZ1kJD+1ZR5oVwlUl3Aog= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of _spf.google.com designates 209.85.221.54 as permitted sender) smtp.mailfrom=philippe.mathieu.daude@gmail.com Received: from mail-wr1-f54.google.com (mail-wr1-f54.google.com [209.85.221.54]) by mx.zohomail.com with SMTPS id 16131760052561001.8571383505721; Fri, 12 Feb 2021 16:26:45 -0800 (PST) Received: by mail-wr1-f54.google.com with SMTP id v7so1339505wrr.12 for ; Fri, 12 Feb 2021 16:26:42 -0800 (PST) Return-Path: Return-Path: Received: from localhost.localdomain (68.red-83-57-175.dynamicip.rima-tde.net. [83.57.175.68]) by smtp.gmail.com with ESMTPSA id j23sm13677472wmo.18.2021.02.12.16.26.40 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 12 Feb 2021 16:26:40 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=sender:from:to:cc:subject:date:message-id:mime-version :content-transfer-encoding; bh=t2Bx/4DDKwq+AGPA3ntsbF3z2tZ4YW92IADITCxNa3c=; b=V+LJ/0iXTSEcp7mWw8iyHvIZqrogZeVdVseHH6z7aCwhSX3aELz8EeV+3ZJbCT5GiW j0J4BvHTMrNO2GvaEn0Q2VNl+CvAaOYIL4CcfFGeU8uWqQAOH3Uj6jcAFh39/mRl3CQk pC+cb1pZuyCb1+rJyHQyR3wAvNer07mtY0xMSD392pUoHmr1ekeHG3HG7lJYWyXA2MD8 VSYU30FPcOp240I1/PMlbsY+6g/CKjpp/xFJnzvglLVBt4P3ijF1FxDlfqGzEJd6s4Cz kygJXHDoXB/Pt/X97CBlJAVFPiDrkr9DY4Z2w1nQR/fT7YmryK2oZsOUKINrZUpL2m9m xSJw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:sender:from:to:cc:subject:date:message-id :mime-version:content-transfer-encoding; bh=t2Bx/4DDKwq+AGPA3ntsbF3z2tZ4YW92IADITCxNa3c=; b=Nd+5QzIl+VCUDkboTkDz6WbzYZkUckA/oUSuzUbOwEnnSDHe8ilnNpMxUYJPSpKfdR YEX7h9dui6kAPpn0d5Min//BLvBzMwYyEgvghvDJqsJqT8PyR3PCBndWaXU/tQOJBMjF KNO2WyhxAFhmuHVhTJL7RffzAab7pFxvxiC73h2tBx1Ojo0UMKWqnKgz/0v4pxPp1enB 5N5Ja3wqFct1ENkve3SQ916dURhf89W/3TySYY2yuVSZgBtteaegxoyuL1gl+m0FUz0n VWeSJ6qsGv/2XRbdUabxEc3KVwIuEE54WG5d+57HIXDNif6lJZPJObtvZUrSd59sk+zH fPtQ== X-Gm-Message-State: AOAM532bdtL1YYKRWyqS8XOd4m3vJduiC1BXywZA2yXNoqZrS+siUdFN hEdJrW9dpLRZtmdzDmrEObc= X-Google-Smtp-Source: ABdhPJyXFdbmQH4auQKkMrNWwjBlYLDvbDGSw1lXywVZI3kUrVJb/OXi2AysEEtfvlDgt9Dk5j5/6A== X-Received: by 2002:a05:6000:188c:: with SMTP id a12mr6478445wri.105.1613176001596; Fri, 12 Feb 2021 16:26:41 -0800 (PST) Sender: =?UTF-8?Q?Philippe_Mathieu=2DDaud=C3=A9?= From: =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= To: qemu-devel@nongnu.org Cc: =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= , Richard Henderson , Aleksandar Rikalo , Aurelien Jarno , Jiaxun Yang , Fredrik Noring Subject: [PATCH v2] target/mips/translate: Simplify PCPYH using deposit_i64() Date: Sat, 13 Feb 2021 01:26:39 +0100 Message-Id: <20210213002639.77681-1-f4bug@amsat.org> X-Mailer: git-send-email 2.26.2 MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable X-ZohoMail-DKIM: pass (identity @gmail.com) Simplify the PCPYH (Parallel Copy Halfword) instruction by using multiple calls to deposit_i64() which can be optimized by some TCG backends. Signed-off-by: Philippe Mathieu-Daud=C3=A9 --- v2: Send the Halfword version :) --- target/mips/translate.c | 36 ++++++------------------------------ 1 file changed, 6 insertions(+), 30 deletions(-) diff --git a/target/mips/translate.c b/target/mips/translate.c index a5cf1742a8b..ddae26009dd 100644 --- a/target/mips/translate.c +++ b/target/mips/translate.c @@ -24786,36 +24786,12 @@ static void gen_mmi_pcpyh(DisasContext *ctx) tcg_gen_movi_i64(cpu_gpr[rd], 0); tcg_gen_movi_i64(cpu_mmr[rd], 0); } else { - TCGv_i64 t0 =3D tcg_temp_new(); - TCGv_i64 t1 =3D tcg_temp_new(); - uint64_t mask =3D (1ULL << 16) - 1; - - tcg_gen_andi_i64(t0, cpu_gpr[rt], mask); - tcg_gen_movi_i64(t1, 0); - tcg_gen_or_i64(t1, t0, t1); - tcg_gen_shli_i64(t0, t0, 16); - tcg_gen_or_i64(t1, t0, t1); - tcg_gen_shli_i64(t0, t0, 16); - tcg_gen_or_i64(t1, t0, t1); - tcg_gen_shli_i64(t0, t0, 16); - tcg_gen_or_i64(t1, t0, t1); - - tcg_gen_mov_i64(cpu_gpr[rd], t1); - - tcg_gen_andi_i64(t0, cpu_mmr[rt], mask); - tcg_gen_movi_i64(t1, 0); - tcg_gen_or_i64(t1, t0, t1); - tcg_gen_shli_i64(t0, t0, 16); - tcg_gen_or_i64(t1, t0, t1); - tcg_gen_shli_i64(t0, t0, 16); - tcg_gen_or_i64(t1, t0, t1); - tcg_gen_shli_i64(t0, t0, 16); - tcg_gen_or_i64(t1, t0, t1); - - tcg_gen_mov_i64(cpu_mmr[rd], t1); - - tcg_temp_free(t0); - tcg_temp_free(t1); + for (int i =3D 0; i < 4; i++) { + tcg_gen_deposit_i64(cpu_gpr[rd], + cpu_gpr[rd], cpu_gpr[rd], 16 * i, 16); + tcg_gen_deposit_i64(cpu_mmr[rd], + cpu_mmr[rd], cpu_mmr[rd], 16 * i, 16); + } } } =20 --=20 2.26.2