From nobody Tue Nov 18 22:46:02 2025 Delivered-To: importer@patchew.org Received-SPF: pass (zohomail.com: domain of _spf.google.com designates 209.85.221.50 as permitted sender) client-ip=209.85.221.50; envelope-from=philippe.mathieu.daude@gmail.com; helo=mail-wr1-f50.google.com; Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of _spf.google.com designates 209.85.221.50 as permitted sender) smtp.mailfrom=philippe.mathieu.daude@gmail.com ARC-Seal: i=1; a=rsa-sha256; t=1613175564; cv=none; d=zohomail.com; s=zohoarc; b=dP1YPtSeJ+Xa3hTbFZ8UtTuvGgJyDawNgNJA2dNtmS8GH5Dealgc2eBlGwtZENhRxe6SKd6sJ0p/pgkbKCGTLiQbkAwL0/v4v6wJ8KlXbm5NmmrUdU79xKQPyS0BDVqBDdg46GZIfZWutsrX1h+lEzkKjVFB/rAVdBLkzjZqUik= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1613175564; h=Content-Type:Content-Transfer-Encoding:Cc:Date:From:MIME-Version:Message-ID:Sender:Subject:To; bh=UzlBWdLqrgbIiqWi3YuH/B2jLty0s5g+5TK5PDFgKHA=; b=czFKtP+yThkThBCJE0dsLXlaltXlk0Z/+aHTItCBFsyxOTTYfdyvqyaKR3EERlyTHqjAjbtFyCuB6fQuwAY55Lw84zNjSNlpuMxDrISzSQfYUuWySBT0+C0mrEpP9woJtX9XhQIY1BS2XpmqoJcPzqisx7ORYOtXpswUlVNqiZY= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of _spf.google.com designates 209.85.221.50 as permitted sender) smtp.mailfrom=philippe.mathieu.daude@gmail.com Received: from mail-wr1-f50.google.com (mail-wr1-f50.google.com [209.85.221.50]) by mx.zohomail.com with SMTPS id 1613175564251156.2983145756524; Fri, 12 Feb 2021 16:19:24 -0800 (PST) Received: by mail-wr1-f50.google.com with SMTP id t15so1310378wrx.13 for ; Fri, 12 Feb 2021 16:19:05 -0800 (PST) Return-Path: Return-Path: Received: from localhost.localdomain (68.red-83-57-175.dynamicip.rima-tde.net. [83.57.175.68]) by smtp.gmail.com with ESMTPSA id g1sm15372401wmh.9.2021.02.12.16.19.02 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 12 Feb 2021 16:19:03 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=sender:from:to:cc:subject:date:message-id:mime-version :content-transfer-encoding; bh=UzlBWdLqrgbIiqWi3YuH/B2jLty0s5g+5TK5PDFgKHA=; b=OslLLRTuna/WYc49AwqERpIgVk2KbojvWqjqSOvJwipoECd8tA8nWrdB+5bLfcUASI Yb7bzQgoVth6K1EbNo0skpGWppCbq1+zzmj7Ouu+f3qQy1O4WezOgSQCdOfcDHccRvOj XyIH12HjWYpAf+4SkCknJvDbsddPke7wi+juQQNF0uDAkDFiX771kBdEeUqsH23GfRv9 bOmj/wRx9OsdutzT8xc/qP69Kk+PTEkyU4CuRDyd1FmqqdBipbVIev0FcVXlIyaS2wrV 8eVWvXTwGuAoQKz9bQwf7AQDTv+a6TFGMDpJfjPLng5KPlaIecbNbjVRIPiWPpgMB+1/ f/jg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:sender:from:to:cc:subject:date:message-id :mime-version:content-transfer-encoding; bh=UzlBWdLqrgbIiqWi3YuH/B2jLty0s5g+5TK5PDFgKHA=; b=nNz2429L8GwG7qdpegm/3Iq6e2hBmRnOhTQNdcsluZa+PS6YhVKRAEB+rwuJhu6LpV ROQNpikE0erApikvljPGnknaMnDF+ZGAIUoliIk3unJg4ddtNKfUJDeVHDBW9ht2vrvs bJVZReEqngsUbczfOVB+wiqjAucjvNpe9xEdURxBnGR2gNGrs08oDJ38MYivh6fqeMgc M2joprswXEnU3OZ+tbDwhjlI5TPRetAmHY5dcgrrse8tzBSXI0k5AyF9xo4mU2QY2j9G chrxu/xsPW2+suS3P1Ck1Rwrnj1inNiG4MgM0pdVw9Kxy5qtHDp/+zJwjRshQa54ibfN 5K+Q== X-Gm-Message-State: AOAM532+Q+qXlbtEV20xytYXsuT/twehszGiegEPEDQYDmdhxmJYCKnL CWW1KT0GlX0N04ePYEWKrKU= X-Google-Smtp-Source: ABdhPJxLGmLH85m03MakIH1PQWfmmHGjtpgmua/g4cMKQV51H3twCWaINEmgEok0A1mNkLl0WdvGiw== X-Received: by 2002:adf:f206:: with SMTP id p6mr4756089wro.337.1613175544128; Fri, 12 Feb 2021 16:19:04 -0800 (PST) Sender: =?UTF-8?Q?Philippe_Mathieu=2DDaud=C3=A9?= From: =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= To: qemu-devel@nongnu.org Cc: Richard Henderson , Aleksandar Rikalo , Fredrik Noring , =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= , Aurelien Jarno , Jiaxun Yang Subject: [PATCH] target/mips/translate: Simplify PCPYH using deposit_i64() Date: Sat, 13 Feb 2021 01:19:01 +0100 Message-Id: <20210213001901.75562-1-f4bug@amsat.org> X-Mailer: git-send-email 2.26.2 MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable X-ZohoMail-DKIM: pass (identity @gmail.com) Simplify the PCPYH (Parallel Copy Halfword) instruction by using multiple calls to deposit_i64() which can be optimized by some TCG backends. Signed-off-by: Philippe Mathieu-Daud=C3=A9 --- target/mips/translate.c | 36 ++++++------------------------------ 1 file changed, 6 insertions(+), 30 deletions(-) diff --git a/target/mips/translate.c b/target/mips/translate.c index a5cf1742a8b..5b31aa44f30 100644 --- a/target/mips/translate.c +++ b/target/mips/translate.c @@ -24786,36 +24786,12 @@ static void gen_mmi_pcpyh(DisasContext *ctx) tcg_gen_movi_i64(cpu_gpr[rd], 0); tcg_gen_movi_i64(cpu_mmr[rd], 0); } else { - TCGv_i64 t0 =3D tcg_temp_new(); - TCGv_i64 t1 =3D tcg_temp_new(); - uint64_t mask =3D (1ULL << 16) - 1; - - tcg_gen_andi_i64(t0, cpu_gpr[rt], mask); - tcg_gen_movi_i64(t1, 0); - tcg_gen_or_i64(t1, t0, t1); - tcg_gen_shli_i64(t0, t0, 16); - tcg_gen_or_i64(t1, t0, t1); - tcg_gen_shli_i64(t0, t0, 16); - tcg_gen_or_i64(t1, t0, t1); - tcg_gen_shli_i64(t0, t0, 16); - tcg_gen_or_i64(t1, t0, t1); - - tcg_gen_mov_i64(cpu_gpr[rd], t1); - - tcg_gen_andi_i64(t0, cpu_mmr[rt], mask); - tcg_gen_movi_i64(t1, 0); - tcg_gen_or_i64(t1, t0, t1); - tcg_gen_shli_i64(t0, t0, 16); - tcg_gen_or_i64(t1, t0, t1); - tcg_gen_shli_i64(t0, t0, 16); - tcg_gen_or_i64(t1, t0, t1); - tcg_gen_shli_i64(t0, t0, 16); - tcg_gen_or_i64(t1, t0, t1); - - tcg_gen_mov_i64(cpu_mmr[rd], t1); - - tcg_temp_free(t0); - tcg_temp_free(t1); + for (int i =3D 0; i < 4; i++) { + tcg_gen_deposit_i64(cpu_gpr[rd], + cpu_gpr[rd], cpu_gpr[rd], 8 * i, 8); + tcg_gen_deposit_i64(cpu_mmr[rd], + cpu_mmr[rd], cpu_mmr[rd], 8 * i, 8); + } } } =20 --=20 2.26.2