From nobody Sun Oct 5 19:25:49 2025 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=fail; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=fail(p=none dis=none) header.from=redhat.com ARC-Seal: i=1; a=rsa-sha256; t=1613161143; cv=none; d=zohomail.com; s=zohoarc; b=Qiz3Dz/BG+ud9dNBeERwB2AzdrdnVR5YCwzHAyXcNiV8hfsf9gaYoe9zgnLJes76yXg5DB5xQ8boBV/2y92kurl3l2VF0QH4PRFktYf13Rir/NyYMKmgHxFyg767wl9jI2FLWCECuv94HNaGe4WhhUc4PL4ZhJ6w6mVn5dacbps= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1613161143; h=Content-Type:Content-Transfer-Encoding:Cc:Date:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:To; bh=bIFMhONtHFFJQrXdCykz8Xygs7fyXrTSwinNlTOE1Qo=; b=cozBGgtYCMOsAozibY/9Dv4QvHcRbbyGIYJjqa6qQPLPo+Od5FQg13EM1dc4uUSjBDwYh7hfs3tvlbXzU6EHArDLHj4xG4zv7BglgZV4EfIt2n1FVrR3T9a30H7bbYXyu9GC4A0p+TT23viXHUbDLGEK+WVJysLZUBuCxCKnUYE= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=fail; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=fail header.from= (p=none dis=none) header.from= Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1613161143001370.23984242936103; Fri, 12 Feb 2021 12:19:03 -0800 (PST) Received: from localhost ([::1]:46386 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1lAeu5-0006UA-Qc for importer@patchew.org; Fri, 12 Feb 2021 15:19:01 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]:58012) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1lAerf-00048W-54 for qemu-devel@nongnu.org; Fri, 12 Feb 2021 15:16:35 -0500 Received: from us-smtp-delivery-124.mimecast.com ([170.10.133.124]:49476) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA1:256) (Exim 4.90_1) (envelope-from ) id 1lAerd-0003qB-1V for qemu-devel@nongnu.org; Fri, 12 Feb 2021 15:16:30 -0500 Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-6-C5uQ13jzPqaDrCqjxEyLug-1; Fri, 12 Feb 2021 15:16:25 -0500 Received: from smtp.corp.redhat.com (int-mx03.intmail.prod.int.phx2.redhat.com [10.5.11.13]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id B3131801965; Fri, 12 Feb 2021 20:16:24 +0000 (UTC) Received: from blue.redhat.com (ovpn-114-150.phx2.redhat.com [10.3.114.150]) by smtp.corp.redhat.com (Postfix) with ESMTP id 5208F614EB; Fri, 12 Feb 2021 20:16:24 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1613160987; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=bIFMhONtHFFJQrXdCykz8Xygs7fyXrTSwinNlTOE1Qo=; b=TlYswC5ld4FiatBmxkSBDMMA0Vrh7K9h3C4WS8u4ru4ZYML1TNS9mFZ253XP9/na9WagQG 8mFPgbIIF0JlYFlxpuyvKVm5WGlvGBwy4SDm0XPvxztUf1R3sZ2Ee0D6LL/3UcQQbYQy16 ZQKhmNcXC1Qzg8gee1AG9cQAz285Mmk= X-MC-Unique: C5uQ13jzPqaDrCqjxEyLug-1 From: Eric Blake To: qemu-devel@nongnu.org Subject: [PULL 04/14] io: error_prepend() in qio_channel_readv_full_all() causes segfault Date: Fri, 12 Feb 2021 14:16:09 -0600 Message-Id: <20210212201619.1388255-5-eblake@redhat.com> In-Reply-To: <20210212201619.1388255-1-eblake@redhat.com> References: <20210212201619.1388255-1-eblake@redhat.com> MIME-Version: 1.0 X-Scanned-By: MIMEDefang 2.79 on 10.5.11.13 Authentication-Results: relay.mimecast.com; auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=eblake@redhat.com X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Received-SPF: pass client-ip=170.10.133.124; envelope-from=eblake@redhat.com; helo=us-smtp-delivery-124.mimecast.com X-Spam_score_int: -33 X-Spam_score: -3.4 X-Spam_bar: --- X-Spam_report: (-3.4 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.569, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_LOW=-0.7, RCVD_IN_MSPIKE_H4=0.001, RCVD_IN_MSPIKE_WL=0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: =?UTF-8?q?Daniel=20P=20=2E=20Berrang=C3=A9?= , Jagannathan Raman , Max Reitz Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: "Qemu-devel" X-ZohoMail-DKIM: fail (Header signature does not verify) From: Jagannathan Raman Using error_prepend() in qio_channel_readv_full_all() causes a segfault as errp is not set when ret is 0. This results in the failure of iotest 83. Replacing with error_setg() fixes the problem. Additionally, removes a full stop at the end of error message Reported-by: Max Reitz Signed-off-by: Jagannathan Raman Fixes: bebab91ebdfc591f8793a9a17370df1bfbe8b2ca (io: add qio_channel_readv_full_all_eof & qio_channel_readv_full_all help= ers) Message-Id: Reviewed-by: Daniel P. Berrang=C3=A9 Signed-off-by: Eric Blake --- io/channel.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/io/channel.c b/io/channel.c index 4555021b6246..e8b019dc36e2 100644 --- a/io/channel.c +++ b/io/channel.c @@ -202,8 +202,7 @@ int qio_channel_readv_full_all(QIOChannel *ioc, int ret =3D qio_channel_readv_full_all_eof(ioc, iov, niov, fds, nfds, = errp); if (ret =3D=3D 0) { - error_prepend(errp, - "Unexpected end-of-file before all data were read."); + error_setg(errp, "Unexpected end-of-file before all data were read= "); return -1; } if (ret =3D=3D 1) { --=20 2.30.1