From nobody Sun Oct 5 19:22:57 2025 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=fail; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=fail(p=none dis=none) header.from=redhat.com ARC-Seal: i=1; a=rsa-sha256; t=1613161980; cv=none; d=zohomail.com; s=zohoarc; b=Kgw+SPBKGbvSPT3+HUnh70RxDqiRQXiLu5aF23JZpltp4B5vQwQezmuocLi3KHHogBD6R+2O4UOI200VvxcoNXKPELle4jGBt8pTubw9w5GCv7MDAGbGsQkClIzbAFWWeIgL+36I/HpdZSnst4473P0oxhimx6u87tsHLkQMTjs= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1613161980; h=Content-Type:Content-Transfer-Encoding:Cc:Date:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:To; bh=Nh3v1M6YI7AQnqOodrG3tI7MkQ7UyPMVC1DxfFVpaO0=; b=SRJtaWJLLmkZGSIgOAVwH38YrWjWdVuGCE5yg3Nx0Z4daiWuR262guyqqLPbfhCCGuv5zq7nBI5t8TmXFZM+OAz7WUmlmqAESMrOiH0g8+RkiSOwulLiyTGti304+zaQFwyW9Ob+ub8+qSVHA6/IbblmBQsNRs0L4V+ALehEFxI= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=fail; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=fail header.from= (p=none dis=none) header.from= Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1613161979980632.6604831046626; Fri, 12 Feb 2021 12:32:59 -0800 (PST) Received: from localhost ([::1]:56812 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1lAf7Y-0006Qr-JZ for importer@patchew.org; Fri, 12 Feb 2021 15:32:56 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]:58260) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1lAerq-0004QG-Rz for qemu-devel@nongnu.org; Fri, 12 Feb 2021 15:16:42 -0500 Received: from us-smtp-delivery-124.mimecast.com ([216.205.24.124]:36965) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA1:256) (Exim 4.90_1) (envelope-from ) id 1lAerm-0003vE-SL for qemu-devel@nongnu.org; Fri, 12 Feb 2021 15:16:42 -0500 Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-105-8JvHjRc4MzKoLZQ25PlQfA-1; Fri, 12 Feb 2021 15:16:35 -0500 Received: from smtp.corp.redhat.com (int-mx03.intmail.prod.int.phx2.redhat.com [10.5.11.13]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id 9C213107ACFB; Fri, 12 Feb 2021 20:16:34 +0000 (UTC) Received: from blue.redhat.com (ovpn-114-150.phx2.redhat.com [10.3.114.150]) by smtp.corp.redhat.com (Postfix) with ESMTP id 1F97C6B8E5; Fri, 12 Feb 2021 20:16:34 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1613160998; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=Nh3v1M6YI7AQnqOodrG3tI7MkQ7UyPMVC1DxfFVpaO0=; b=GPP0kTTFRwfLa57LwV8OBniND3bODKf2xPLEwKlgpIbrnsHMiu0yfwFzrXXs62KlSySdNn foy1auIfp7x+AfhhzybXu4Y+ZqlGDaoFTGRIh81p8s8RnBC6pPXieIV/JkhJVJzYP/Ro98 q93KzNS/iOH0cgg93EiITB/VCI+xoWI= X-MC-Unique: 8JvHjRc4MzKoLZQ25PlQfA-1 From: Eric Blake To: qemu-devel@nongnu.org Subject: [PULL 13/14] block/backup: implement .cancel job handler Date: Fri, 12 Feb 2021 14:16:18 -0600 Message-Id: <20210212201619.1388255-14-eblake@redhat.com> In-Reply-To: <20210212201619.1388255-1-eblake@redhat.com> References: <20210212201619.1388255-1-eblake@redhat.com> MIME-Version: 1.0 X-Scanned-By: MIMEDefang 2.79 on 10.5.11.13 Authentication-Results: relay.mimecast.com; auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=eblake@redhat.com X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Transfer-Encoding: quoted-printable Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Received-SPF: pass client-ip=216.205.24.124; envelope-from=eblake@redhat.com; helo=us-smtp-delivery-124.mimecast.com X-Spam_score_int: -33 X-Spam_score: -3.4 X-Spam_bar: --- X-Spam_report: (-3.4 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.569, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_LOW=-0.7, RCVD_IN_MSPIKE_H3=0.001, RCVD_IN_MSPIKE_WL=0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Kevin Wolf , Vladimir Sementsov-Ogievskiy , John Snow , "open list:Block Jobs" , Max Reitz Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: "Qemu-devel" X-ZohoMail-DKIM: fail (Header signature does not verify) Content-Type: text/plain; charset="utf-8" From: Vladimir Sementsov-Ogievskiy Cancel in-flight io on target to not waste the time. Signed-off-by: Vladimir Sementsov-Ogievskiy Reviewed-by: Eric Blake Message-Id: <20210205163720.887197-10-vsementsov@virtuozzo.com> Signed-off-by: Eric Blake --- block/backup.c | 10 ++++++++++ 1 file changed, 10 insertions(+) diff --git a/block/backup.c b/block/backup.c index cc525d55445e..94e6dcd72e33 100644 --- a/block/backup.c +++ b/block/backup.c @@ -35,6 +35,7 @@ typedef struct BackupBlockJob { BlockJob common; BlockDriverState *backup_top; BlockDriverState *source_bs; + BlockDriverState *target_bs; BdrvDirtyBitmap *sync_bitmap; @@ -329,6 +330,13 @@ static void coroutine_fn backup_set_speed(BlockJob *jo= b, int64_t speed) } } +static void backup_cancel(Job *job) +{ + BackupBlockJob *s =3D container_of(job, BackupBlockJob, common.job); + + bdrv_cancel_in_flight(s->target_bs); +} + static const BlockJobDriver backup_job_driver =3D { .job_driver =3D { .instance_size =3D sizeof(BackupBlockJob), @@ -340,6 +348,7 @@ static const BlockJobDriver backup_job_driver =3D { .abort =3D backup_abort, .clean =3D backup_clean, .pause =3D backup_pause, + .cancel =3D backup_cancel, }, .set_speed =3D backup_set_speed, }; @@ -528,6 +537,7 @@ BlockJob *backup_job_create(const char *job_id, BlockDr= iverState *bs, job->backup_top =3D backup_top; job->source_bs =3D bs; + job->target_bs =3D target; job->on_source_error =3D on_source_error; job->on_target_error =3D on_target_error; job->sync_mode =3D sync_mode; --=20 2.30.1