From nobody Wed Nov 19 00:18:02 2025 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=fail; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=fail(p=none dis=none) header.from=redhat.com ARC-Seal: i=1; a=rsa-sha256; t=1613081613; cv=none; d=zohomail.com; s=zohoarc; b=YOYGMlppM43lYzhxh6cNbepWN+GLakoGh1Ym4YyPVB3tRW+zmiihP0PpkNR9/XLAHqNiT7HTFxaQnxAS9causQd3O6wAVtor0pgWLVpTmZ1anjVluPmXmsjfjQcXzmWnFlorV8h7GahHR8k0Q8VOCuYR6Hng04M6NUgEliwPGag= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1613081613; h=Content-Type:Content-Transfer-Encoding:Cc:Date:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:To; bh=yE/LntIwowJP/AvdhZnvELNHjMASPOH1uXK0gHpi4vs=; b=cqZjiVXjIS4Z+dm0zpNNhSMg66SBS33qALXkOyxAGXirnlEDE7N1NU1ZrRZJ86jWChEhBPZvKzwaAlG+NOy6qST5uEWZlySaqs53wvaT/fUJHkdTb1i103J/pPRrBJKYGeOLTrNZ3lnRTgKlsUwTM+FU7rWP23ykd/wmy7a8490= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=fail; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=fail header.from= (p=none dis=none) header.from= Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1613081613357427.2508278996579; Thu, 11 Feb 2021 14:13:33 -0800 (PST) Received: from localhost ([::1]:37644 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1lAKDG-00012l-V4 for importer@patchew.org; Thu, 11 Feb 2021 17:13:27 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]:59386) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1lAK2F-0000JJ-FW for qemu-devel@nongnu.org; Thu, 11 Feb 2021 17:02:03 -0500 Received: from us-smtp-delivery-124.mimecast.com ([216.205.24.124]:29026) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA1:256) (Exim 4.90_1) (envelope-from ) id 1lAK2C-0005rY-74 for qemu-devel@nongnu.org; Thu, 11 Feb 2021 17:02:03 -0500 Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-23-88koqT26MmytA2GfX1UvUw-1; Thu, 11 Feb 2021 17:01:55 -0500 Received: from smtp.corp.redhat.com (int-mx02.intmail.prod.int.phx2.redhat.com [10.5.11.12]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id 8D71C85B664; Thu, 11 Feb 2021 22:01:54 +0000 (UTC) Received: from localhost.localdomain.com (ovpn-116-89.rdu2.redhat.com [10.10.116.89]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 443C860BF1; Thu, 11 Feb 2021 22:01:53 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1613080919; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=yE/LntIwowJP/AvdhZnvELNHjMASPOH1uXK0gHpi4vs=; b=Egr6CgQWRJ/0rE0HQ2Ev9PBYXKuTEFjos7yRWWa7DB2/4TBSPp56/Uzl3S52d6WT4iWl4U cCmkAqnNdBu9L1Vda3Pn04xFDeYZmuMl3Oc58STI3sJ3YXtPZlW143BjoJoAt+PkOTIsAA 3iU1GjuUNKVIakG76LBXEjY3HvAwrbI= X-MC-Unique: 88koqT26MmytA2GfX1UvUw-1 From: Cleber Rosa To: qemu-devel@nongnu.org Subject: [PATCH 1/6] Python: close the log file kept by QEMUMachine before reading it Date: Thu, 11 Feb 2021 17:01:41 -0500 Message-Id: <20210211220146.2525771-2-crosa@redhat.com> In-Reply-To: <20210211220146.2525771-1-crosa@redhat.com> References: <20210211220146.2525771-1-crosa@redhat.com> MIME-Version: 1.0 X-Scanned-By: MIMEDefang 2.79 on 10.5.11.12 Authentication-Results: relay.mimecast.com; auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=crosa@redhat.com X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Transfer-Encoding: quoted-printable Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Received-SPF: pass client-ip=216.205.24.124; envelope-from=crosa@redhat.com; helo=us-smtp-delivery-124.mimecast.com X-Spam_score_int: -33 X-Spam_score: -3.4 X-Spam_bar: --- X-Spam_report: (-3.4 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.569, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_LOW=-0.7, RCVD_IN_MSPIKE_H3=0.001, RCVD_IN_MSPIKE_WL=0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=unavailable autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Kevin Wolf , Thomas Huth , Eduardo Habkost , qemu-block@nongnu.org, =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= , Wainer dos Santos Moschetta , Max Reitz , =?UTF-8?q?Alex=20Benn=C3=A9e?= , Willian Rampazzo , Cleber Rosa , John Snow , Beraldo Leal Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: "Qemu-devel" X-ZohoMail-DKIM: fail (Header signature does not verify) Content-Type: text/plain; charset="utf-8" Closing a file that is open for writing, and then reading from it sounds like a better idea than the opposite, given that the content will be flushed. Reference: https://docs.python.org/3/library/io.html#io.IOBase.close Signed-off-by: Cleber Rosa Acked-by: Wainer dos Santos Moschetta Reviewed-by: John Snow --- python/qemu/machine.py | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/python/qemu/machine.py b/python/qemu/machine.py index 7a40f4604b..6e44bda337 100644 --- a/python/qemu/machine.py +++ b/python/qemu/machine.py @@ -337,12 +337,12 @@ class QEMUMachine: self._qmp.close() self._qmp_connection =3D None =20 - self._load_io_log() - if self._qemu_log_file is not None: self._qemu_log_file.close() self._qemu_log_file =3D None =20 + self._load_io_log() + self._qemu_log_path =3D None =20 if self._temp_dir is not None: --=20 2.25.4