From nobody Wed Apr 16 08:10:00 2025 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass(p=none dis=none) header.from=linaro.org ARC-Seal: i=1; a=rsa-sha256; t=1613049940; cv=none; d=zohomail.com; s=zohoarc; b=ZTtzEpYxMWVsUnc5IFL8d/9YisJmz71TYUANlzX0m4BaaI0DdwQS0uOyyzGhJrH6z+uNkXV4DmjSdtgfId1wYRUnumuDLDoPlU5LHGzx54XzzrgEFBniRs5NhQxB3UkI1c80NausIO8zKDGHNLs24cwDF+dHmmiwdt9hAFOrlGg= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1613049940; h=Content-Transfer-Encoding:Date:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:To; bh=55fSBVW6bM/EwxuFa4hfg9eqTtioyVGk4PvCa+Q/Udk=; b=KmHYYNw2bsLgLj01/XjbHTxa3UlPlNaGdr6ao/VrQGw6DWrfqk3DJL+P5R+5OtZOpRLwpklEXKY9tXw/nZvros2bEjv0nATjt02SHtv7vix1YJsaHRDIqlCZtwL7LCnxI6ontIftCgejSPRmsByBuy3FbyUpJM0RVrZPuLJNRz0= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass header.from= (p=none dis=none) header.from= Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1613049939896952.378495566573; Thu, 11 Feb 2021 05:25:39 -0800 (PST) Received: from localhost ([::1]:57160 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1lABn5-0003IL-Ot for importer@patchew.org; Thu, 11 Feb 2021 08:13:51 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]:33142) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1lABYo-0007lh-8P for qemu-devel@nongnu.org; Thu, 11 Feb 2021 07:59:06 -0500 Received: from mail-wr1-x429.google.com ([2a00:1450:4864:20::429]:45613) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1lABYm-0008Jk-LK for qemu-devel@nongnu.org; Thu, 11 Feb 2021 07:59:05 -0500 Received: by mail-wr1-x429.google.com with SMTP id m13so4038379wro.12 for ; Thu, 11 Feb 2021 04:59:04 -0800 (PST) Received: from orth.archaic.org.uk (orth.archaic.org.uk. [81.2.115.148]) by smtp.gmail.com with ESMTPSA id g15sm4955716wrx.1.2021.02.11.04.59.02 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 11 Feb 2021 04:59:03 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=from:to:subject:date:message-id:in-reply-to:references:mime-version :content-transfer-encoding; bh=55fSBVW6bM/EwxuFa4hfg9eqTtioyVGk4PvCa+Q/Udk=; b=s2njYhYJA/yu5tJ+ZRCikl9HbZLFtQoBYRacBvfGQ430f++X4mtGVbHQUEVywJ0V6c 4INainZfIQ2LsRQp81DbJRYWPMJXlSImAwDAov6bZ50zQ9b1E4W6XxKnT823pfQ4ML8u aKF6dF1auyGQYTAEwzqnHCEqolVT6VxLzPR17LqqijJczYYvEs0LE18JO60oEdpiOUei 2iBgUqNsFFW1TYDIHaSctOjY2xHT1ZUrELqLVfjqOXDo9udEaQZZqpK3Ps7caTTTvf+t 4EblbAJqFO3mWQQ1PPV2S26bFNsVbZoKlAtCfTeSJw28edB9v+qLDhiiJPW9muSYWSKF eXJg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=55fSBVW6bM/EwxuFa4hfg9eqTtioyVGk4PvCa+Q/Udk=; b=aAfNMb46idH5gLmeYznH/OCuy1yurMxjOCf7qkOjaTFIyGrBe6pICAnrmxTKP3mEWt EU5rGaFJi0hRtrPplKJ7nwqkemYe3wOeLQzPLlZiYrIbBeVorPAfpZDk4tfCYbWjXhz/ mUhN+WnQ745s3/HKnQK0Rf2iIb/kG6AwiI0gCzdMK/S8QWAnxMhFyfyOVltgbsxVTXY8 yq9d82Kodx1hc69R+NE1lshqnjgfUk7RbXKFjH/y8VJAP4wPLskYJlfQzm3iWhjgH96o NOirqratctq62PQ/riWfThaEXtV2gpW5QVCPVsAMxKMIRDPucp8336VgIn3NnJyTSRNz ytLw== X-Gm-Message-State: AOAM531PBxM0RHTqwhn3OZMg1Ja8MZD74cpuf+OIfB31rws+aQ0M86VU Fo1ms4u0eZRJc3XLm9K0VVO2/156A3YSDg== X-Google-Smtp-Source: ABdhPJzIkr34Dq5izHwcQwHH4Utl8gzLT5KO2yCDIGLEa2utq7wzMnHj2VF+e124/U/sugoWO0CVaQ== X-Received: by 2002:a5d:56c2:: with SMTP id m2mr689068wrw.325.1613048343414; Thu, 11 Feb 2021 04:59:03 -0800 (PST) From: Peter Maydell To: qemu-devel@nongnu.org Subject: [PULL 01/45] target/arm: Don't migrate CPUARMState.features Date: Thu, 11 Feb 2021 12:58:16 +0000 Message-Id: <20210211125900.22777-2-peter.maydell@linaro.org> X-Mailer: git-send-email 2.20.1 In-Reply-To: <20210211125900.22777-1-peter.maydell@linaro.org> References: <20210211125900.22777-1-peter.maydell@linaro.org> MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Received-SPF: pass client-ip=2a00:1450:4864:20::429; envelope-from=peter.maydell@linaro.org; helo=mail-wr1-x429.google.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: "Qemu-devel" X-ZohoMail-DKIM: pass (identity @linaro.org) Content-Type: text/plain; charset="utf-8" From: Aaron Lindsay As feature flags are added or removed, the meanings of bits in the `features` field can change between QEMU versions, causing migration failures. Additionally, migrating the field is not useful because it is a constant function of the CPU being used. Fixes: LP:1914696 Signed-off-by: Aaron Lindsay Suggested-by: Peter Maydell Reviewed-by: Andrew Jones Tested-by: Andrew Jones Reviewed-by: Peter Maydell Signed-off-by: Peter Maydell --- target/arm/machine.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/target/arm/machine.c b/target/arm/machine.c index 581852bc53b..6ad1d306b12 100644 --- a/target/arm/machine.c +++ b/target/arm/machine.c @@ -810,7 +810,7 @@ const VMStateDescription vmstate_arm_cpu =3D { VMSTATE_UINT64(env.exclusive_addr, ARMCPU), VMSTATE_UINT64(env.exclusive_val, ARMCPU), VMSTATE_UINT64(env.exclusive_high, ARMCPU), - VMSTATE_UINT64(env.features, ARMCPU), + VMSTATE_UNUSED(sizeof(uint64_t)), VMSTATE_UINT32(env.exception.syndrome, ARMCPU), VMSTATE_UINT32(env.exception.fsr, ARMCPU), VMSTATE_UINT64(env.exception.vaddress, ARMCPU), --=20 2.20.1