From nobody Sat May 18 21:26:37 2024 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org ARC-Seal: i=1; a=rsa-sha256; t=1613041190; cv=none; d=zohomail.com; s=zohoarc; b=DwfjIioqvz34c9TFqGLGTrSuAT3jAnVCgPr7Xj672DoeB8uOZfL/0a+q7zz4NCcDb55WRpvnc5VtnFakR7KAComNHo2zmFDZcC4nYd24rwJPTIPMgf1T6SeOb+O969iQgp3VyEfUUcvipPn5Pobj7Rld9x9CSKQsE7UqVxmy/Zo= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1613041190; h=Content-Transfer-Encoding:Cc:Date:From:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:Sender:Subject:To; bh=43eysmtlCd15QjsaRhNmak35DRKx5Oj319gjNHkMrJ0=; b=LT0j7wTvvpfsoo03A2WFxz654jqssTQJ/+ySShCiexbgiLm0tB4SZgof41LURc0T/m7BJg0K7nsl3wpTlDqRJ9mpFT3Ri5ZmHS16mgzypPofiRa13Nh7I/wWnkUAVlfLnrhew9uDG4Q5qiCTLVm3du8RSb7myfZPHae6eIrFEoE= ARC-Authentication-Results: i=1; mx.zohomail.com; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1613041189648109.7086380438908; Thu, 11 Feb 2021 02:59:49 -0800 (PST) Received: from localhost ([::1]:56496 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1lA9hM-0004R0-9J for importer@patchew.org; Thu, 11 Feb 2021 05:59:48 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]:36054) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1lA9cg-0002Px-VY; Thu, 11 Feb 2021 05:54:59 -0500 Received: from out2-smtp.messagingengine.com ([66.111.4.26]:47141) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1lA9ce-0006Mq-Bq; Thu, 11 Feb 2021 05:54:58 -0500 Received: from compute4.internal (compute4.nyi.internal [10.202.2.44]) by mailout.nyi.internal (Postfix) with ESMTP id 06C155C0116; Thu, 11 Feb 2021 05:54:55 -0500 (EST) Received: from mailfrontend2 ([10.202.2.163]) by compute4.internal (MEProxy); Thu, 11 Feb 2021 05:54:55 -0500 Received: from apples.local (80-167-98-190-cable.dk.customer.tdc.net [80.167.98.190]) by mail.messagingengine.com (Postfix) with ESMTPA id BA1641080067; Thu, 11 Feb 2021 05:54:52 -0500 (EST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=irrelevant.dk; h=from:to:cc:subject:date:message-id:mime-version :content-transfer-encoding; s=fm2; bh=43eysmtlCd15QjsaRhNmak35DR Kx5Oj319gjNHkMrJ0=; b=HQXejQM3mYamxn4rgBx8Xn0tZzUvjukoTYSbdh4Gb0 MW9HouinZIZL0D9mX/wel3jzdc8hIpBAvCxqcUFVOzCtRqYol35VL85ypqsWCf8W p9FES7+nt6Nd6OdL1PiT4h1j6tcxIIJUpGALtMnPvci49Tm22cBDqkaU7odvlIDI QAXYy6Z39kEU+wNLHFOjq2PVY2dAeX9pwlHIiCYR+5Q4CHLU5mBECC61z7IQ6RFn 0yzvachyjUH/iRsn0mqOSHDRMNKWWcQQ/DV5xya0NEOuv2JwOFuULvztUATBaLux 6hETc6h7bacwAqxlM1M2DxL/XTRixVXeVuCQliF8g9Pg== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:content-transfer-encoding:date:from :message-id:mime-version:subject:to:x-me-proxy:x-me-proxy :x-me-sender:x-me-sender:x-sasl-enc; s=fm2; bh=43eysmtlCd15QjsaR hNmak35DRKx5Oj319gjNHkMrJ0=; b=NBv9dVHcNtGSM7bkvQKndo3ONhY/Er6uq tS7hEwrXjy+ko7UR8Ry9CFaM+agmzS/OmEcXmHLDW73EnJkwKP5PrfguBmKZs8gG RCXixk1QgcYwfjPPvxEjsGaeWHArtCEL9oydA6fYVxingHB3+y996g6MpDbDC8BH xDYNNEGY9//Jukp9Vt6LQcfB/iQq9PxP8Xkubbv86DCEcqDbM/bgxL1cDawleClE 2VmGPDgdlFOCUMUOeqwUb/l4ICcj3IFrRA5lT/D1zIM0gZpssJ0+E1OJw/41UsJf pwkQqwvt6Q9pTjLEhl9l86wlMg6hrOSn2g2WAEX5dDnT7cMAmUiSw== X-ME-Sender: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgeduledrheelgddukecutefuodetggdotefrodftvf curfhrohhfihhlvgemucfhrghsthforghilhdpqfgfvfdpuffrtefokffrpgfnqfghnecu uegrihhlohhuthemuceftddtnecusecvtfgvtghiphhivghnthhsucdlqddutddtmdenuc fjughrpefhvffufffkofgggfestdekredtredttdenucfhrhhomhepmfhlrghushculfgv nhhsvghnuceoihhtshesihhrrhgvlhgvvhgrnhhtrdgukheqnecuggftrfgrthhtvghrnh epfeevledvieekudeuffetgeegfeehvdffffejueeuleduhedvgeejveejhfdtteehnecu kfhppeektddrudeijedrleekrdduledtnecuvehluhhsthgvrhfuihiivgeptdenucfrrg hrrghmpehmrghilhhfrhhomhepihhtshesihhrrhgvlhgvvhgrnhhtrdgukh X-ME-Proxy: From: Klaus Jensen To: qemu-devel@nongnu.org Subject: [PATCH] hw/block/nvme: fix legacy namespace registration Date: Thu, 11 Feb 2021 11:54:51 +0100 Message-Id: <20210211105451.937713-1-its@irrelevant.dk> X-Mailer: git-send-email 2.30.0 MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Received-SPF: pass client-ip=66.111.4.26; envelope-from=its@irrelevant.dk; helo=out2-smtp.messagingengine.com X-Spam_score_int: -27 X-Spam_score: -2.8 X-Spam_bar: -- X-Spam_report: (-2.8 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_LOW=-0.7, RCVD_IN_MSPIKE_H3=0.001, RCVD_IN_MSPIKE_WL=0.001, SPF_HELO_PASS=-0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Kevin Wolf , qemu-block@nongnu.org, Klaus Jensen , Max Reitz , Keith Busch , Alexander Graf , Minwoo Im , Klaus Jensen Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: "Qemu-devel" Content-Type: text/plain; charset="utf-8" From: Klaus Jensen Moving namespace registration to the nvme-ns realization function had the unintended side-effect of breaking legacy namespace registration. Fix this. Fixes: 15d024d4aa9b ("hw/block/nvme: split setup and register for namespace= ") Reported-by: Alexander Graf Cc: Minwoo Im Signed-off-by: Klaus Jensen Reviewed-by: Minwoo Im Tested-by: Alexander Graf --- hw/block/nvme.c | 6 ++++++ 1 file changed, 6 insertions(+) diff --git a/hw/block/nvme.c b/hw/block/nvme.c index 5ce21b7100b3..d36e14fe13e2 100644 --- a/hw/block/nvme.c +++ b/hw/block/nvme.c @@ -4507,6 +4507,12 @@ static void nvme_realize(PCIDevice *pci_dev, Error *= *errp) if (nvme_ns_setup(ns, errp)) { return; } + + if (nvme_register_namespace(n, ns, errp)) { + error_propagate_prepend(errp, local_err, + "could not register namespace: "); + return; + } } } =20 --=20 2.30.0