From nobody Tue Feb 10 01:32:55 2026 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=fail; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org ARC-Seal: i=1; a=rsa-sha256; t=1612938460; cv=none; d=zohomail.com; s=zohoarc; b=JRdvXGdCqFojFibUQXTvvWxCzjK0Wu4lsG4xCMVOevEVT7vYGT958XzAe70+VTImMSZw92jmvPrz9FHMmACGafxarFIIjcx3yi9JJhgPzw9OG8SWblEwdWW6LIFkVQT1Uv1XjOuLJxUT7ed7eQK8NLVtx4iWhNh47kfkkp3xJBw= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1612938460; h=Content-Type:Content-Transfer-Encoding:Cc:Date:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:To; bh=kBFeiml6MbAVLMt4sKMArBuc8yaFtfnWwZ4xqaKZULE=; b=lA/27CcgAE5G+17P8uifwlF7HZW+rCKWrXlR+z8/ayt1Z1rn5SDhwDp5Se44vA3rTkj5N/21w2s4FmzhuNXprGok5DbPP0uBMf8P0Zj4L45+I+O8ZFgRv9TYwYChvzLUocxWozSCckU5vRJ2bqXR/yI6WrKhMk0GcOJIW4R7rvQ= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=fail; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1612938459773858.6029480503583; Tue, 9 Feb 2021 22:27:39 -0800 (PST) Received: from localhost ([::1]:34412 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1l9iyQ-000461-Jp for importer@patchew.org; Wed, 10 Feb 2021 01:27:38 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]:43466) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1l9ip6-0001d0-Bs; Wed, 10 Feb 2021 01:18:00 -0500 Received: from ozlabs.org ([2401:3900:2:1::2]:35715) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1l9ip3-0000ME-OH; Wed, 10 Feb 2021 01:17:59 -0500 Received: by ozlabs.org (Postfix, from userid 1007) id 4Db8gm5Ttnz9sW5; Wed, 10 Feb 2021 17:17:40 +1100 (AEDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=gibson.dropbear.id.au; s=201602; t=1612937860; bh=kta8DAjjj3gDwVJcwqU1hmnwFBmqS5CY5jA28QoXg04=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=pNHSKYAFR0/tJVb35jThF/LYe6yU1LT2F66c+E2J/I0THGrqR0VycKYdDE5ZyijUt xf23WeONc3epn3TntrjaNPQkZUFdiB1LUbUuexRME8V2fyuHBy1tI2BnucFVrW5/RP /gh/Fc9s6ArtZuC8YS9imfGCCP19js3jNCRDPVJg= From: David Gibson To: peter.maydell@linaro.org, groug@kaod.org Subject: [PULL 10/19] ppc/pnv: Remove default disablement of the PNOR contents Date: Wed, 10 Feb 2021 17:17:26 +1100 Message-Id: <20210210061735.304384-11-david@gibson.dropbear.id.au> X-Mailer: git-send-email 2.29.2 In-Reply-To: <20210210061735.304384-1-david@gibson.dropbear.id.au> References: <20210210061735.304384-1-david@gibson.dropbear.id.au> MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Received-SPF: pass client-ip=2401:3900:2:1::2; envelope-from=dgibson@ozlabs.org; helo=ozlabs.org X-Spam_score_int: -17 X-Spam_score: -1.8 X-Spam_bar: - X-Spam_report: (-1.8 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, HEADER_FROM_DIFFERENT_DOMAINS=0.249, SPF_HELO_PASS=-0.001, SPF_PASS=-0.001 autolearn=no autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Joel Stanley , David Gibson , qemu-ppc@nongnu.org, qemu-devel@nongnu.org, =?UTF-8?q?C=C3=A9dric=20Le=20Goater?= Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: "Qemu-devel" X-ZohoMail-DKIM: fail (Header signature does not verify) From: C=C3=A9dric Le Goater On PowerNV systems, the BMC is in charge of mapping the PNOR contents on the LPC FW address space using the HIOMAP protocol. Under QEMU, we emulate this behavior and we also add an extra control on the flash accesses by letting the HIOMAP command handler decide whether the memory region is accessible or not depending on the firmware requests. However, this behavior is not compatible with hostboot like firmwares which need this mapping to be always available. For this reason, the PNOR memory region is initially disabled for skiboot mode only. This is badly placed under the LPC model and requires the use of the machine. Since it doesn't add much, simply remove the initial setting. The extra control in the HIOMAP command handler will still be performed. Signed-off-by: C=C3=A9dric Le Goater Message-Id: <20210126171059.307867-7-clg@kaod.org> Reviewed-by: Joel Stanley Signed-off-by: David Gibson --- hw/ppc/pnv_lpc.c | 8 -------- 1 file changed, 8 deletions(-) diff --git a/hw/ppc/pnv_lpc.c b/hw/ppc/pnv_lpc.c index 5903590220..11739e397b 100644 --- a/hw/ppc/pnv_lpc.c +++ b/hw/ppc/pnv_lpc.c @@ -825,7 +825,6 @@ ISABus *pnv_lpc_isa_create(PnvLpcController *lpc, bool = use_cpld, Error **errp) qemu_irq *irqs; qemu_irq_handler handler; PnvMachineState *pnv =3D PNV_MACHINE(qdev_get_machine()); - bool hostboot_mode =3D !!pnv->fw_load_addr; =20 /* let isa_bus_new() create its own bridge on SysBus otherwise * devices specified on the command line won't find the bus and @@ -856,13 +855,6 @@ ISABus *pnv_lpc_isa_create(PnvLpcController *lpc, bool= use_cpld, Error **errp) */ memory_region_add_subregion(&lpc->isa_fw, PNOR_SPI_OFFSET, &pnv->pnor->mmio); - /* - * Start disabled. The HIOMAP protocol will activate the mapping - * with HIOMAP_C_CREATE_WRITE_WINDOW - */ - if (!hostboot_mode) { - memory_region_set_enabled(&pnv->pnor->mmio, false); - } =20 return isa_bus; } --=20 2.29.2