From nobody Tue Feb 10 19:17:10 2026 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org ARC-Seal: i=1; a=rsa-sha256; t=1612899861; cv=none; d=zohomail.com; s=zohoarc; b=Ka0ONcnDcC0TRzKRhRU4uKYp2uCoV0hXWtaSII5KP5fQfN+wQDCoD9gy+teGOnwATQocZl0CotD88lLSflXgHHQYzjLiLJQaBoslRemI7zsUBJ8egxpUY3NH8Bi4PTZ/L8wCEkvMB3ROgiTj1RUaIHWclN3AiNRHKTy6Z9rABP8= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1612899861; h=Content-Transfer-Encoding:Date:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:To; bh=e1J3Go0Qt7V6tPRxLSIemUYO9tdXL8NavoNcRUSHcrs=; b=cJo9khzQa4MXoGyCIiaMD3hCe6QjRFq7psEoB6yfFbMsdr0Hwwj8uQ+K0ik9HVqOAk/kI3rwxjXNJ15kPozMKbCz4Iju4ezSdWdm2PlHk8zSODUE8TjwDFC3D7qqR4Wrg/khEjL5UVUnI+N9sIoVc0pSWeXXlGCeZkm0aOlF1y8= ARC-Authentication-Results: i=1; mx.zohomail.com; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1612899861566426.60682348650903; Tue, 9 Feb 2021 11:44:21 -0800 (PST) Received: from localhost ([::1]:54420 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1l9Yvs-0002Hf-Ib for importer@patchew.org; Tue, 09 Feb 2021 14:44:20 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]:57464) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1l9YjT-0004ap-Ek for qemu-devel@nongnu.org; Tue, 09 Feb 2021 14:31:31 -0500 Received: from mail.ilande.co.uk ([2001:41c9:1:41f::167]:56848 helo=mail.default.ilande.uk0.bigv.io) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1l9YjR-0002N6-SY for qemu-devel@nongnu.org; Tue, 09 Feb 2021 14:31:31 -0500 Received: from host109-153-84-1.range109-153.btcentralplus.com ([109.153.84.1] helo=kentang.home) by mail.default.ilande.uk0.bigv.io with esmtpsa (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1l9Yjk-0007pt-O3; Tue, 09 Feb 2021 19:31:53 +0000 From: Mark Cave-Ayland To: qemu-devel@nongnu.org, pbonzini@redhat.com, fam@euphon.net, laurent@vivier.eu Date: Tue, 9 Feb 2021 19:29:48 +0000 Message-Id: <20210209193018.31339-13-mark.cave-ayland@ilande.co.uk> X-Mailer: git-send-email 2.20.1 In-Reply-To: <20210209193018.31339-1-mark.cave-ayland@ilande.co.uk> References: <20210209193018.31339-1-mark.cave-ayland@ilande.co.uk> MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable X-SA-Exim-Connect-IP: 109.153.84.1 X-SA-Exim-Mail-From: mark.cave-ayland@ilande.co.uk Subject: [PATCH v2 12/42] esp: remove dma_counter from ESPState X-SA-Exim-Version: 4.2.1 (built Wed, 08 May 2019 21:11:16 +0000) X-SA-Exim-Scanned: Yes (on mail.default.ilande.uk0.bigv.io) Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Received-SPF: pass client-ip=2001:41c9:1:41f::167; envelope-from=mark.cave-ayland@ilande.co.uk; helo=mail.default.ilande.uk0.bigv.io X-Spam_score_int: -18 X-Spam_score: -1.9 X-Spam_bar: - X-Spam_report: (-1.9 / 5.0 requ) BAYES_00=-1.9, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: "Qemu-devel" Content-Type: text/plain; charset="utf-8" The value of dma_counter is set once at the start of the transfer and remai= ns the same until the transfer is complete. This allows the check in esp_trans= fer_data to be simplified since dma_left will always be non-zero until the transfer = is completed. Signed-off-by: Mark Cave-Ayland Reviewed-by: Laurent Vivier Reviewed-by: Philippe Mathieu-Daud=C3=A9 --- hw/scsi/esp.c | 4 +--- include/hw/scsi/esp.h | 3 --- 2 files changed, 1 insertion(+), 6 deletions(-) diff --git a/hw/scsi/esp.c b/hw/scsi/esp.c index 02b7876394..6c495b29c0 100644 --- a/hw/scsi/esp.c +++ b/hw/scsi/esp.c @@ -229,7 +229,6 @@ static void do_busid_cmd(ESPState *s, uint8_t *buf, uin= t8_t busid) if (datalen !=3D 0) { s->rregs[ESP_RSTAT] =3D STAT_TC; s->dma_left =3D 0; - s->dma_counter =3D 0; if (datalen > 0) { s->rregs[ESP_RSTAT] |=3D STAT_DI; } else { @@ -543,7 +542,7 @@ void esp_transfer_data(SCSIRequest *req, uint32_t len) s->async_buf =3D scsi_req_get_buf(req); if (s->dma_left) { esp_do_dma(s); - } else if (s->dma_counter !=3D 0 && s->ti_size <=3D 0) { + } else if (s->ti_size <=3D 0) { /* * If this was the last part of a DMA transfer then the * completion interrupt is deferred to here. @@ -562,7 +561,6 @@ static void handle_ti(ESPState *s) } =20 dmalen =3D esp_get_tc(s); - s->dma_counter =3D dmalen; =20 if (s->do_cmd) { minlen =3D (dmalen < ESP_CMDBUF_SZ) ? dmalen : ESP_CMDBUF_SZ; diff --git a/include/hw/scsi/esp.h b/include/hw/scsi/esp.h index 7d92471c5b..b313ef27f2 100644 --- a/include/hw/scsi/esp.h +++ b/include/hw/scsi/esp.h @@ -50,9 +50,6 @@ struct ESPState { =20 /* The amount of data left in the current DMA transfer. */ uint32_t dma_left; - /* The size of the current DMA transfer. Zero if no transfer is in - progress. */ - uint32_t dma_counter; int dma_enabled; =20 uint32_t async_len; --=20 2.20.1