From nobody Tue Feb 10 13:36:19 2026 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org ARC-Seal: i=1; a=rsa-sha256; t=1612900128; cv=none; d=zohomail.com; s=zohoarc; b=QMAHlqOwvuOCbZUTzhXAaHmBDmM4oNiUD4mcPo0e5S0nutItWIS8jkCz2CEYm+e3hEk9Ee0BuwYSvwoeLedJDh8VxkutNSPy+WqJLToGrUeOHmB7D6aCIrd+ZYSO3UlEHKabem4WOr33MVrOGGz2LdcLMssonGrp4vnxlw+/pQc= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1612900128; h=Content-Transfer-Encoding:Date:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:To; bh=W4rybRk7blF2d5sxqPy3kC8f3fILFsDaBN3UdftasB0=; b=TeO7IxwUbzw1Cnyd3GWEzo+p88uZUIMQjhK4XfwKGqCm9ERdGticEF7rK36MsV9W0QsntomiCx6oSB/J0WNbQO5i4N5bmi4RLjW83DSDxyS2xpsy5+Vz2EDpQ7S1ZLukJTbZqoTE+JZ4hOW554EZhVSlqSrtwpIWaAhkigp7i20= ARC-Authentication-Results: i=1; mx.zohomail.com; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1612900127722816.1582202821705; Tue, 9 Feb 2021 11:48:47 -0800 (PST) Received: from localhost ([::1]:37368 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1l9Z0A-00078y-HO for importer@patchew.org; Tue, 09 Feb 2021 14:48:46 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]:57422) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1l9YjM-0004SA-Pu for qemu-devel@nongnu.org; Tue, 09 Feb 2021 14:31:24 -0500 Received: from mail.ilande.co.uk ([2001:41c9:1:41f::167]:56826 helo=mail.default.ilande.uk0.bigv.io) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1l9YjI-0002Gq-3B for qemu-devel@nongnu.org; Tue, 09 Feb 2021 14:31:24 -0500 Received: from host109-153-84-1.range109-153.btcentralplus.com ([109.153.84.1] helo=kentang.home) by mail.default.ilande.uk0.bigv.io with esmtpsa (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1l9Yjc-0007pt-Hq; Tue, 09 Feb 2021 19:31:43 +0000 From: Mark Cave-Ayland To: qemu-devel@nongnu.org, pbonzini@redhat.com, fam@euphon.net, laurent@vivier.eu Date: Tue, 9 Feb 2021 19:29:46 +0000 Message-Id: <20210209193018.31339-11-mark.cave-ayland@ilande.co.uk> X-Mailer: git-send-email 2.20.1 In-Reply-To: <20210209193018.31339-1-mark.cave-ayland@ilande.co.uk> References: <20210209193018.31339-1-mark.cave-ayland@ilande.co.uk> MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable X-SA-Exim-Connect-IP: 109.153.84.1 X-SA-Exim-Mail-From: mark.cave-ayland@ilande.co.uk Subject: [PATCH v2 10/42] esp: introduce esp_get_stc() X-SA-Exim-Version: 4.2.1 (built Wed, 08 May 2019 21:11:16 +0000) X-SA-Exim-Scanned: Yes (on mail.default.ilande.uk0.bigv.io) Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Received-SPF: pass client-ip=2001:41c9:1:41f::167; envelope-from=mark.cave-ayland@ilande.co.uk; helo=mail.default.ilande.uk0.bigv.io X-Spam_score_int: -18 X-Spam_score: -1.9 X-Spam_bar: - X-Spam_report: (-1.9 / 5.0 requ) BAYES_00=-1.9, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: "Qemu-devel" Content-Type: text/plain; charset="utf-8" This simplifies reading the STC register value without having to manually s= hift each individual 8-bit value. Signed-off-by: Mark Cave-Ayland Reviewed-by: Laurent Vivier Reviewed-by: Philippe Mathieu-Daud=C3=A9 --- hw/scsi/esp.c | 15 ++++++++++++--- 1 file changed, 12 insertions(+), 3 deletions(-) diff --git a/hw/scsi/esp.c b/hw/scsi/esp.c index 3a39450930..a1acc2c9bd 100644 --- a/hw/scsi/esp.c +++ b/hw/scsi/esp.c @@ -116,6 +116,17 @@ static void esp_set_tc(ESPState *s, uint32_t dmalen) s->rregs[ESP_TCHI] =3D dmalen >> 16; } =20 +static uint32_t esp_get_stc(ESPState *s) +{ + uint32_t dmalen; + + dmalen =3D s->wregs[ESP_TCLO]; + dmalen |=3D s->wregs[ESP_TCMID] << 8; + dmalen |=3D s->wregs[ESP_TCHI] << 16; + + return dmalen; +} + static void set_pdma(ESPState *s, enum pdma_origin_id origin, uint32_t index, uint32_t len) { @@ -688,9 +699,7 @@ void esp_reg_write(ESPState *s, uint32_t saddr, uint64_= t val) if (val & CMD_DMA) { s->dma =3D 1; /* Reload DMA counter. */ - s->rregs[ESP_TCLO] =3D s->wregs[ESP_TCLO]; - s->rregs[ESP_TCMID] =3D s->wregs[ESP_TCMID]; - s->rregs[ESP_TCHI] =3D s->wregs[ESP_TCHI]; + esp_set_tc(s, esp_get_stc(s)); } else { s->dma =3D 0; } --=20 2.20.1