From nobody Sat Feb 7 06:35:11 2026 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=fail; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=fail(p=none dis=none) header.from=gmail.com ARC-Seal: i=1; a=rsa-sha256; t=1612881781; cv=none; d=zohomail.com; s=zohoarc; b=efSL5ap71Bl9+qV3+Cm9oA8gu/2b1xuymuslN3ZSFrYkOiYuWzMiCfs6TePFLjrvYCb/WqkuIyTkygOnG1fUugMtGiE+VCe3AFkEDl0JOZm+M8A3Pp/woCQHe5UHDZxV5nGjHdZpsREc+OjyzW0ooJsLtfHoVuTk35gCaP4M+4U= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1612881781; h=Content-Type:Cc:Date:From:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:Sender:Subject:To; bh=6cTQc80LjvAt6Fqc8Ts3MRryAiukCXey0ZFgR6uIEQI=; b=XZqmelIAgFFSKaL1LcM8TWROFnnamuG+QNNrj/cd6/ebK4AX545C5hQ2UxakWNGgbvBafzXdKKkNsb4t5wDZ6Fdzd7vgion/foj6QiCTgtoXqJgAyeefwFuMlVaQJSOisxDtJqaPxmkK9v7QTO0dXS1HCj+ansJGawZXKdXDxqk= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=fail; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=fail header.from= (p=none dis=none) header.from= Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1612881780937802.1719412329978; Tue, 9 Feb 2021 06:43:00 -0800 (PST) Received: from localhost ([::1]:41576 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1l9UEF-0004Ud-CG for importer@patchew.org; Tue, 09 Feb 2021 09:42:59 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]:36150) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1l9Ove-0006X9-ID; Tue, 09 Feb 2021 04:03:26 -0500 Received: from mail-wm1-x32d.google.com ([2a00:1450:4864:20::32d]:52588) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1l9OvY-0000QP-C3; Tue, 09 Feb 2021 04:03:26 -0500 Received: by mail-wm1-x32d.google.com with SMTP id i5so2325987wmq.2; Tue, 09 Feb 2021 01:03:17 -0800 (PST) Received: from localhost ([37.160.162.192]) by smtp.gmail.com with ESMTPSA id z15sm32572015wrt.8.2021.02.09.01.03.14 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 09 Feb 2021 01:03:15 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=date:from:to:cc:subject:message-id:mime-version:content-disposition; bh=6cTQc80LjvAt6Fqc8Ts3MRryAiukCXey0ZFgR6uIEQI=; b=iEoyJNFGB4hcsXFm58Zye9eOJbwGIll3frK4j2IZ72eytVl/fg7vtu/yiNpvbUnW0Z z3yYpdNrq6fSWuExzGwQKP31fuK6k0afB1EAqZIYaDeod+CzGm3/r+7oM37uipoPRuE8 j0jQ8nmLjjdsFlLwmqMtpDus51vmH1PJ+FV4/aJi/+zxuMs2y1W8QHutZzwc6OMaMJHj ftEsUmBmh1tDoXGV3Ckk5ylPy5RYQcKi6epTbvYRjl/BVQdCGVOL8u6qNLih04ITRrIA cLzdSnZk92feujTJG8pzClhbcPQ+J4sohJZAUWp2AlevsGKLNn72BjMoNKsQSKiuX2Xy 1s/w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:mime-version :content-disposition; bh=6cTQc80LjvAt6Fqc8Ts3MRryAiukCXey0ZFgR6uIEQI=; b=iizAHgpZghuEx1myDbT8Q2EcJ3ELf57gDRQ88fOiR8n1teg3t0hSbOZai8RBokmMDF 4WgI6ce1TbquT6AgSB8U0gRj0lYR91+9hFEXX8opwZOnoxhJO1cdM+7BO9a9nzdMfQB8 ex3XL43ugxSmtTUj0uNf3kr/g94ULQl2yj/YWcYyQmg6E6LCZNuEjX53hke6omvjGQru 8ESxMZ9ed6mreSVci70yPSO1J1BSLM0nnFYuHqc0Hhrop2YTxsKvvM7xtaUnpHnDX578 JL5092fcJ4DleFsfAcbJZZHaiHZTAzIqgA7vB8XOeFwXI4ZKQWC4O8VAM/JIYw1y81FR ewrg== X-Gm-Message-State: AOAM531ZuZ6Eil0Is5nSih3zFXL0hexchFk4FS/QIDdJR25UMp/1RmQ4 ZSCe8dSgSJX8iXyHjq6uCpdHxCNbeETYbQ== X-Google-Smtp-Source: ABdhPJxYG8LLuVhAYiKZOFTBIToQ02TLdLiqUkU2j487Qp10v/6ZygN5zTPvCGKYEzMZ+tPThTN8AA== X-Received: by 2002:a7b:ce93:: with SMTP id q19mr2426168wmj.65.1612861396214; Tue, 09 Feb 2021 01:03:16 -0800 (PST) Date: Tue, 9 Feb 2021 10:03:10 +0100 From: Davide Berardi To: qemu-devel@nongnu.org Subject: [PATCH] Raspberry PI GPIO interrupt support Message-ID: <20210209090310.GA25789@carpenter.lan> MIME-Version: 1.0 Content-Disposition: inline Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Received-SPF: pass client-ip=2a00:1450:4864:20::32d; envelope-from=berardi.dav@gmail.com; helo=mail-wm1-x32d.google.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, FREEMAIL_FROM=0.001, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-Mailman-Approved-At: Tue, 09 Feb 2021 09:41:09 -0500 X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Peter Maydell , qemu-arm@nongnu.org, Philippe =?iso-8859-1?Q?Mathieu-Daud=E9?= , Andrew Baumann Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: "Qemu-devel" X-ZohoMail-DKIM: fail (Header signature does not verify) Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8"; format="flowed" The bcm2835 GPIOs now generate interrupts. This modification enables QTEST clients to trigger interrupt-based interfaces. Signed-off-by: Davide Berardi --- hw/arm/bcm2835_peripherals.c | 2 + hw/gpio/bcm2835_gpio.c | 105 +++++++++++++++++++++++++++++++++ hw/intc/bcm2835_ic.c | 2 - include/hw/gpio/bcm2835_gpio.h | 12 ++++ 4 files changed, 119 insertions(+), 2 deletions(-) diff --git a/hw/arm/bcm2835_peripherals.c b/hw/arm/bcm2835_peripherals.c index dcff13433e..101c3e6fba 100644 --- a/hw/arm/bcm2835_peripherals.c +++ b/hw/arm/bcm2835_peripherals.c @@ -114,6 +114,8 @@ static void bcm2835_peripherals_init(Object *obj) OBJECT(&s->sdhci.sdbus)); object_property_add_const_link(OBJECT(&s->gpio), "sdbus-sdhost", OBJECT(&s->sdhost.sdbus)); + object_property_add_const_link(OBJECT(&s->gpio), "ic", + OBJECT(&s->ic)); =20 /* Mphi */ object_initialize_child(obj, "mphi", &s->mphi, TYPE_BCM2835_MPHI); diff --git a/hw/gpio/bcm2835_gpio.c b/hw/gpio/bcm2835_gpio.c index abdddbc67c..2952ebe1da 100644 --- a/hw/gpio/bcm2835_gpio.c +++ b/hw/gpio/bcm2835_gpio.c @@ -7,6 +7,9 @@ * Clement Deschamps * Luc Michel * + * GPIO Interrupt support + * Davide Berardi + * * This work is licensed under the terms of the GNU GPL, version 2 or lat= er. * See the COPYING file in the top-level directory. */ @@ -20,6 +23,7 @@ #include "migration/vmstate.h" #include "hw/sd/sd.h" #include "hw/gpio/bcm2835_gpio.h" +#include "hw/intc/bcm2835_ic.h" #include "hw/irq.h" =20 #define GPFSEL0 0x00 @@ -110,6 +114,29 @@ static int gpfsel_is_out(BCM2835GpioState *s, int inde= x) return 0; } =20 +static inline int get_bit_2_u32(const uint32_t idx, + const uint32_t v1, const uint32_t v2) +{ + uint64_t v =3D v1 | ((uint64_t)v2) << 32; + return !!(v & (1 << idx)); +} + +static int ren_detect(BCM2835GpioState *s, int index) +{ + if (index >=3D 0 && index < 54) { + return get_bit_2_u32(index, s->ren0, s->ren1); + } + return 0; +} + +static int fen_detect(BCM2835GpioState *s, int index) +{ + if (index >=3D 0 && index < 54) { + return get_bit_2_u32(index, s->fen0, s->fen1); + } + return 0; +} + static void gpset(BCM2835GpioState *s, uint32_t val, uint8_t start, uint8_t count, uint32_t *lev) { @@ -120,6 +147,20 @@ static void gpset(BCM2835GpioState *s, for (i =3D 0; i < count; i++) { if ((changes & cur) && (gpfsel_is_out(s, start + i))) { qemu_set_irq(s->out[start + i], 1); + } else if ((changes & cur) && ren_detect(s, start + i)) { + /* If this is an input and must check rising edge */ + int irqline =3D 0; + if (i > 27) + irqline =3D 1; + if (i > 45) + irqline =3D 2; + + /* Set the bit in the events */ + if (i < 32) + s->eds0 |=3D cur; + else + s->eds1 |=3D cur; + qemu_set_irq(s->irq[irqline], 1); } cur <<=3D 1; } @@ -137,6 +178,15 @@ static void gpclr(BCM2835GpioState *s, for (i =3D 0; i < count; i++) { if ((changes & cur) && (gpfsel_is_out(s, start + i))) { qemu_set_irq(s->out[start + i], 0); + } else if ((changes & cur) && fen_detect(s, start + i)) { + /* If this is an input we must check falling edge */ + int irqline =3D 0; + if (i > 27) + irqline =3D 1; + if (i > 45) + irqline =3D 2; + + qemu_set_irq(s->irq[irqline], 1); } cur <<=3D 1; } @@ -144,6 +194,34 @@ static void gpclr(BCM2835GpioState *s, *lev &=3D ~val; } =20 +static int gpio_from_value(uint64_t value, int bank) +{ + int i; + for (i =3D 0 ; i < 32; ++i) + if (value & (1 << i)) + return i + (32 * bank); + return 0; +} + +static void eds_clear(BCM2835GpioState *s, uint64_t value, int bank) +{ + int gpio =3D 0; + int irqline =3D 0; + if (bank) { + s->eds0 &=3D ~value; + } else { + s->eds1 &=3D (~value & 0x3f); + } + gpio =3D gpio_from_value(value, bank); + + if (gpio > 27) + irqline =3D 1; + if (gpio > 45) + irqline =3D 2; + + qemu_set_irq(s->irq[irqline], 0); +} + static uint64_t bcm2835_gpio_read(void *opaque, hwaddr offset, unsigned size) { @@ -170,11 +248,17 @@ static uint64_t bcm2835_gpio_read(void *opaque, hwadd= r offset, case GPLEV1: return s->lev1; case GPEDS0: + return s->eds0; case GPEDS1: + return s->eds1; case GPREN0: + return s->ren0; case GPREN1: + return s->ren1; case GPFEN0: + return s->fen0; case GPFEN1: + return s->fen1; case GPHEN0: case GPHEN1: case GPLEN0: @@ -228,11 +312,23 @@ static void bcm2835_gpio_write(void *opaque, hwaddr o= ffset, /* Read Only */ break; case GPEDS0: + eds_clear(s, value, 0); + break; case GPEDS1: + eds_clear(s, value, 1); + break; case GPREN0: + s->ren0 =3D value; + break; case GPREN1: + s->ren1 =3D value; + break; case GPFEN0: + s->fen0 =3D value; + break; case GPFEN1: + s->fen1 =3D value; + break; case GPHEN0: case GPHEN1: case GPLEN0: @@ -310,6 +406,7 @@ static void bcm2835_gpio_init(Object *obj) =20 static void bcm2835_gpio_realize(DeviceState *dev, Error **errp) { + int i; BCM2835GpioState *s =3D BCM2835_GPIO(dev); Object *obj; =20 @@ -318,6 +415,14 @@ static void bcm2835_gpio_realize(DeviceState *dev, Err= or **errp) =20 obj =3D object_property_get_link(OBJECT(dev), "sdbus-sdhost", &error_= abort); s->sdbus_sdhost =3D SD_BUS(obj); + + obj =3D object_property_get_link(OBJECT(dev), "ic", &error_abort); + s->ic =3D BCM2835_IC(obj); + + for (i =3D 0 ; i < 3; ++i) { + s->irq[i] =3D qdev_get_gpio_in_named(DEVICE(obj), + BCM2835_IC_GPU_IRQ, i + 49); + } } =20 static void bcm2835_gpio_class_init(ObjectClass *klass, void *data) diff --git a/hw/intc/bcm2835_ic.c b/hw/intc/bcm2835_ic.c index 9000d995e8..b381dc6603 100644 --- a/hw/intc/bcm2835_ic.c +++ b/hw/intc/bcm2835_ic.c @@ -57,7 +57,6 @@ static void bcm2835_ic_update(BCM2835ICState *s) static void bcm2835_ic_set_gpu_irq(void *opaque, int irq, int level) { BCM2835ICState *s =3D opaque; - assert(irq >=3D 0 && irq < 64); trace_bcm2835_ic_set_gpu_irq(irq, level); s->gpu_irq_level =3D deposit64(s->gpu_irq_level, irq, 1, level !=3D 0= ); @@ -67,7 +66,6 @@ static void bcm2835_ic_set_gpu_irq(void *opaque, int irq,= int level) static void bcm2835_ic_set_arm_irq(void *opaque, int irq, int level) { BCM2835ICState *s =3D opaque; - assert(irq >=3D 0 && irq < 8); trace_bcm2835_ic_set_cpu_irq(irq, level); s->arm_irq_level =3D deposit32(s->arm_irq_level, irq, 1, level !=3D 0= ); diff --git a/include/hw/gpio/bcm2835_gpio.h b/include/hw/gpio/bcm2835_gpio.h index 1c53a05090..cad3e987d3 100644 --- a/include/hw/gpio/bcm2835_gpio.h +++ b/include/hw/gpio/bcm2835_gpio.h @@ -7,6 +7,9 @@ * Clement Deschamps * Luc Michel * + * GPIO External support + * Davide Berardi + * * This work is licensed under the terms of the GNU GPL, version 2 or lat= er. * See the COPYING file in the top-level directory. */ @@ -17,6 +20,7 @@ #include "hw/sd/sd.h" #include "hw/sysbus.h" #include "qom/object.h" +#include "hw/intc/bcm2835_ic.h" =20 struct BCM2835GpioState { SysBusDevice parent_obj; @@ -27,11 +31,19 @@ struct BCM2835GpioState { SDBus sdbus; SDBus *sdbus_sdhci; SDBus *sdbus_sdhost; + BCM2835ICState *ic; =20 uint8_t fsel[54]; uint32_t lev0, lev1; + /* Event detection */ + uint32_t eds0, eds1; + /* Edge selector */ + uint32_t ren0, ren1; + uint32_t fen0, fen1; + uint8_t sd_fsel; qemu_irq out[54]; + qemu_irq irq[3]; }; =20 #define TYPE_BCM2835_GPIO "bcm2835_gpio" --=20 2.30.0