From nobody Mon Feb 9 08:57:10 2026 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org ARC-Seal: i=1; a=rsa-sha256; t=1612859818; cv=none; d=zohomail.com; s=zohoarc; b=TO7AccN1LDCHE5vbTx+gnayd9VbCLs0sz9/XH+U9UrbK2TpWeNu14omx+k40BaliZumgaEKtPnpTELVWfVDMhMzfFoG9xqklAKdLvvLJdWwjEc7xKebcqvBMJrjTPA+2eyDAHVbvnWh5AFg/uGo8r9+eUK4/QlsviM02eiBWgpg= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1612859818; h=Content-Transfer-Encoding:Cc:Date:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:To; bh=1VkdxomJdJSKGCyFYeWPb35Qo5v9C6WZSGh8yxACdSg=; b=lNEes2OrV3jTewIdtirb5S97V45DK1WNi2Hswp4QVNFRVHml3P+5hDNouxiT12DZH9uhqY0NHtLkRuaq1NZKq1GIEtm3ZTughiISVNUzWlybrcGdLWji/Lu9ddoRR8mg3vVgGcNNnyCjNVGuCAILmv8d4//yJURd88abag1dvRM= ARC-Authentication-Results: i=1; mx.zohomail.com; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1612859818352467.8133781923458; Tue, 9 Feb 2021 00:36:58 -0800 (PST) Received: from localhost ([::1]:48892 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1l9OW1-0007Le-3q for importer@patchew.org; Tue, 09 Feb 2021 03:36:57 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]:47596) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1l9NW0-0005Vm-8P; Tue, 09 Feb 2021 02:32:52 -0500 Received: from wnew1-smtp.messagingengine.com ([64.147.123.26]:58343) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1l9NVu-0005q6-Sf; Tue, 09 Feb 2021 02:32:52 -0500 Received: from compute4.internal (compute4.nyi.internal [10.202.2.44]) by mailnew.west.internal (Postfix) with ESMTP id 5E108C70; Tue, 9 Feb 2021 02:32:14 -0500 (EST) Received: from mailfrontend2 ([10.202.2.163]) by compute4.internal (MEProxy); Tue, 09 Feb 2021 02:32:15 -0500 Received: from apples.local (80-167-98-190-cable.dk.customer.tdc.net [80.167.98.190]) by mail.messagingengine.com (Postfix) with ESMTPA id 988DF1080057; Tue, 9 Feb 2021 02:32:12 -0500 (EST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=irrelevant.dk; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; s=fm2; bh=1VkdxomJdJSKG CyFYeWPb35Qo5v9C6WZSGh8yxACdSg=; b=MvlDZz1dd85cjAJRS5lKfEv8NyBnY 1AikZfKAZpmlUNGdbGluc3zcGaXEL9B9ulMPEiiZ9uhcuQYTahs2b2yfIF/aa9oT BOKR7Hj4vCCYqTuoSp/ILG0Cd7shnTgjsUfoIWvg0QxHQvGX/wEvT8/CTjki1Jld GXh68G6gNCA4JGGvS3Hs0m5MI5odLklzJXlN5A906ertST2x5jJgY3vKw4WIouCb sNgB7U4l/wwH3xQeram8zIc9eMTF2QsZJ4mAw7THvAhEccAA1XrRWUwL9vgJBTtT t4xhPH+s5bVE1OOgE/sIL4Y5PXNHqIjnOUGW+JPNBu9bxVIj+8xvSx0Xg== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:content-transfer-encoding:date:from :in-reply-to:message-id:mime-version:references:subject:to :x-me-proxy:x-me-proxy:x-me-sender:x-me-sender:x-sasl-enc; s= fm2; bh=1VkdxomJdJSKGCyFYeWPb35Qo5v9C6WZSGh8yxACdSg=; b=CKuvfe+x oBgSvsFc/UASzKJeCVoco/+cLcP1ku20yP9xlRP0ncLoA72Lnq3Zt0TCaN6rsdbB J3zaJh3dI9NIYmDLfG5codbasK+1NLOuZDS9cap/zGq2PkwOLRJNl2WX9sX9CUil 1BfZGzKhBB1HFkdohuTGfGqJUIkD2ltXbqEh+KcPFIQuUDww7GTiEgFQ3aK8nxxG dwA0U8jrVWOQ/UCI++jqRb8JwFNkfXQMQkFSvbZJ7dZ5duHVbokIydMIuatI5ii4 DyJoDmXmsoNO+24T8bUwdEUL5Ymm6nCYFqVwFVWyTq0xDus/V+pOvUPKeu6aq6Gu yWtN9ZxSq+2/4Q== X-ME-Sender: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgeduledrheeggdduuddtucetufdoteggodetrfdotf fvucfrrhhofhhilhgvmecuhfgrshhtofgrihhlpdfqfgfvpdfurfetoffkrfgpnffqhgen uceurghilhhouhhtmecufedttdenucesvcftvggtihhpihgvnhhtshculddquddttddmne cujfgurhephffvufffkffojghfggfgsedtkeertdertddtnecuhfhrohhmpefmlhgruhhs ucflvghnshgvnhcuoehithhssehirhhrvghlvghvrghnthdrughkqeenucggtffrrghtth gvrhhnpeeuleetgeeiuefhgfekfefgveejiefgteekiedtgfdtieefhfdthfefueffvefg keenucfkphepkedtrdduieejrdelkedrudeltdenucevlhhushhtvghrufhiiigvpeeine curfgrrhgrmhepmhgrihhlfhhrohhmpehithhssehirhhrvghlvghvrghnthdrughk X-ME-Proxy: From: Klaus Jensen To: qemu-devel@nongnu.org, Peter Maydell Subject: [PULL 33/56] hw/block/nvme: remove unused argument in nvme_ns_setup Date: Tue, 9 Feb 2021 08:30:38 +0100 Message-Id: <20210209073101.548811-34-its@irrelevant.dk> X-Mailer: git-send-email 2.30.0 In-Reply-To: <20210209073101.548811-1-its@irrelevant.dk> References: <20210209073101.548811-1-its@irrelevant.dk> MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Received-SPF: pass client-ip=64.147.123.26; envelope-from=its@irrelevant.dk; helo=wnew1-smtp.messagingengine.com X-Spam_score_int: -27 X-Spam_score: -2.8 X-Spam_bar: -- X-Spam_report: (-2.8 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_LOW=-0.7, SPF_HELO_PASS=-0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Fam Zheng , Kevin Wolf , qemu-block@nongnu.org, Klaus Jensen , Max Reitz , Klaus Jensen , Minwoo Im , Stefan Hajnoczi , Keith Busch Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: "Qemu-devel" Content-Type: text/plain; charset="utf-8" From: Minwoo Im nvme_ns_setup() finally does not have nothing to do with NvmeCtrl instance. Signed-off-by: Minwoo Im Signed-off-by: Klaus Jensen --- hw/block/nvme-ns.h | 2 +- hw/block/nvme-ns.c | 4 ++-- hw/block/nvme.c | 2 +- 3 files changed, 4 insertions(+), 4 deletions(-) diff --git a/hw/block/nvme-ns.h b/hw/block/nvme-ns.h index a0baa5f6d44c..293ac990e3f6 100644 --- a/hw/block/nvme-ns.h +++ b/hw/block/nvme-ns.h @@ -174,7 +174,7 @@ static inline void nvme_aor_dec_active(NvmeNamespace *n= s) assert(ns->nr_active_zones >=3D 0); } =20 -int nvme_ns_setup(NvmeCtrl *n, NvmeNamespace *ns, Error **errp); +int nvme_ns_setup(NvmeNamespace *ns, Error **errp); void nvme_ns_drain(NvmeNamespace *ns); void nvme_ns_shutdown(NvmeNamespace *ns); void nvme_ns_cleanup(NvmeNamespace *ns); diff --git a/hw/block/nvme-ns.c b/hw/block/nvme-ns.c index ce79ad4a5319..3f52acb89c95 100644 --- a/hw/block/nvme-ns.c +++ b/hw/block/nvme-ns.c @@ -301,7 +301,7 @@ static int nvme_ns_check_constraints(NvmeNamespace *ns,= Error **errp) return 0; } =20 -int nvme_ns_setup(NvmeCtrl *n, NvmeNamespace *ns, Error **errp) +int nvme_ns_setup(NvmeNamespace *ns, Error **errp) { if (nvme_ns_check_constraints(ns, errp)) { return -1; @@ -353,7 +353,7 @@ static void nvme_ns_realize(DeviceState *dev, Error **e= rrp) NvmeCtrl *n =3D NVME(s->parent); Error *local_err =3D NULL; =20 - if (nvme_ns_setup(n, ns, &local_err)) { + if (nvme_ns_setup(ns, &local_err)) { error_propagate_prepend(errp, local_err, "could not setup namespace: "); return; diff --git a/hw/block/nvme.c b/hw/block/nvme.c index 0b002cb2beab..30bd70fd5b07 100644 --- a/hw/block/nvme.c +++ b/hw/block/nvme.c @@ -4377,7 +4377,7 @@ static void nvme_realize(PCIDevice *pci_dev, Error **= errp) ns =3D &n->namespace; ns->params.nsid =3D 1; =20 - if (nvme_ns_setup(n, ns, errp)) { + if (nvme_ns_setup(ns, errp)) { return; } } --=20 2.30.0