From nobody Mon Feb 9 23:40:48 2026 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=fail; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=fail(p=none dis=none) header.from=redhat.com ARC-Seal: i=1; a=rsa-sha256; t=1612825008; cv=none; d=zohomail.com; s=zohoarc; b=Rsbg3XwqBCJbwDNf7XWT9v8/BGyuiO4W5rz+iClCsjY0HXvlK1NLa9mnpuHZihzMkbCEupnYKzu3Ivlp6T9Y/N7MuDSBcXk3J56oh27bhlVWrEMLfUpvZmkhnS5ivuNzvVFgFpsQIy2IKzChEG9U8+lXkKr8lacogjq+vg6AmEk= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1612825008; h=Content-Transfer-Encoding:Cc:Date:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:To; bh=YrjPSlBHnaJRqA8v7XrPCR75uFzsE6U/RqfZMqsmDSE=; b=ejt15lqGHIzHoIIYbGoSqgYAqmPX5PUatqbebX3An6S9BIGkT9Zzvuk74Bt2uQ7tYd75/Vj8C1AnirbuiyN92N0F/XhmiT7ul4UyJnmWmNiwHAwPPso0dyRdOLO2KzVine5KEN/vxX9zJ7FGmWbnfg7OEkawBpXfWRLTAm0hMng= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=fail; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=fail header.from= (p=none dis=none) header.from= Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1612825008022514.8629187126479; Mon, 8 Feb 2021 14:56:48 -0800 (PST) Received: from localhost ([::1]:60532 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1l9FSY-0007eo-QD for importer@patchew.org; Mon, 08 Feb 2021 17:56:46 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]:50920) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1l9BCs-0003jJ-Hl for qemu-devel@nongnu.org; Mon, 08 Feb 2021 13:24:18 -0500 Received: from mail-wm1-x32e.google.com ([2a00:1450:4864:20::32e]:50955) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1l9BCp-0006Nm-Ao for qemu-devel@nongnu.org; Mon, 08 Feb 2021 13:24:17 -0500 Received: by mail-wm1-x32e.google.com with SMTP id 190so64671wmz.0 for ; Mon, 08 Feb 2021 10:24:14 -0800 (PST) Received: from avogadro.redhat.com ([2001:b07:6468:f312:c8dd:75d4:99ab:290a]) by smtp.gmail.com with ESMTPSA id x22sm19670wmc.25.2021.02.08.10.24.12 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 08 Feb 2021 10:24:12 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=sender:from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=YrjPSlBHnaJRqA8v7XrPCR75uFzsE6U/RqfZMqsmDSE=; b=P/rvsv0rE7R5ZgzxoM2z1ouH0HpdHgMGoQzqPlLkmdiJxlVAYSPsPrYKO+o4k1wpaE FXyWmkypKwkbDeWtX2RPDS+ds68kncZeKNTBRP7C9fQgIthOM0E/fxLPrJi152FtguCi mNkqoDZ7UakjXdex4kQ2CkifGApdjyY6QkIxFv9UD3xJPneTVyNWK/YhiCHPbFHDy05R /Em0cmNWCgLjNg52Bn6eR5wNjQ6+mc9QBsYtid2BJgYPfn2YSvLWXQWUdKee4ZimnHGe 54u5fDMVTYHT6wm2hTXqmayUDlRMGBJfQE7ZVmPRIx2JFxu/yDQInA2k6YWGudtWnpp4 HFGw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:sender:from:to:cc:subject:date:message-id :in-reply-to:references:mime-version:content-transfer-encoding; bh=YrjPSlBHnaJRqA8v7XrPCR75uFzsE6U/RqfZMqsmDSE=; b=kbRtqk6WN8onj12KaFcuqoglxI7c97t/I1nay7i9+JUkcNsFmd6q6ZYPpstIwq2iuV 9B/HW0jIgwAH/34Zclcvcka2Bem/kEQqTDMPT5yfHDj2YuPlcSshcm8q5WttjGlxN3ST OrOIouS6/KAaMHVxDjXJLFwSqr4AQnkIvihYibuyfrcOBxfl1Za6LCHdxkRsMnnfD0o+ d9t8WJwjcJGgvMqf00+YPVsMyQ3kA2n6BnackA0kBOJ3sMfnfXW+gIK2ddjqIFPO0y1q rMzF0P1gA6MDfwzG6QBB8Z8UXdGi9StaYbAF4Suej/vbP0kkURglRR/D2DqNS2H2Bb27 TczA== X-Gm-Message-State: AOAM532TAtHHQtYq3uH33SX4EJ0cYycf+J3oH9kp2N0AE3wn4lORrnYw pFY7p3Go9fMjPXMk+Fdi1YOXwlbUi7FrZQ== X-Google-Smtp-Source: ABdhPJwZfjYwMSsG914oP84zj+ueLyHnkmQjeHu/LeW7dVh4CxOplufHqMt7frmU2QzAbc3RE0iY6Q== X-Received: by 2002:a7b:c215:: with SMTP id x21mr59941wmi.61.1612808653337; Mon, 08 Feb 2021 10:24:13 -0800 (PST) From: Paolo Bonzini To: qemu-devel@nongnu.org Subject: [PULL 42/46] spapr_pci: add spapr msi read method Date: Mon, 8 Feb 2021 19:23:27 +0100 Message-Id: <20210208182331.58897-43-pbonzini@redhat.com> X-Mailer: git-send-email 2.29.2 In-Reply-To: <20210208182331.58897-1-pbonzini@redhat.com> References: <20210208182331.58897-1-pbonzini@redhat.com> MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Received-SPF: pass client-ip=2a00:1450:4864:20::32e; envelope-from=paolo.bonzini@gmail.com; helo=mail-wm1-x32e.google.com X-Spam_score_int: -14 X-Spam_score: -1.5 X-Spam_bar: - X-Spam_report: (-1.5 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_EF=-0.1, FREEMAIL_FORGED_FROMDOMAIN=0.248, FREEMAIL_FROM=0.001, HEADER_FROM_DIFFERENT_DOMAINS=0.249, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=no autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Lei Sun , Li Qiang , Prasad J Pandit , David Gibson Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: "Qemu-devel" X-ZohoMail-DKIM: fail (Header signature does not verify) Content-Type: text/plain; charset="utf-8" From: Prasad J Pandit Add spapr msi mmio read method to avoid NULL pointer dereference issue. Reported-by: Lei Sun Acked-by: David Gibson Reviewed-by: Li Qiang Signed-off-by: Prasad J Pandit Message-Id: <20200811114133.672647-7-ppandit@redhat.com> Signed-off-by: Paolo Bonzini --- hw/ppc/spapr_pci.c | 14 ++++++++++++-- 1 file changed, 12 insertions(+), 2 deletions(-) diff --git a/hw/ppc/spapr_pci.c b/hw/ppc/spapr_pci.c index 76d7c91e9c..b89f810034 100644 --- a/hw/ppc/spapr_pci.c +++ b/hw/ppc/spapr_pci.c @@ -53,6 +53,7 @@ #include "sysemu/hostmem.h" #include "sysemu/numa.h" #include "hw/ppc/spapr_numa.h" +#include "qemu/log.h" =20 /* Copied from the kernel arch/powerpc/platforms/pseries/msi.c */ #define RTAS_QUERY_FN 0 @@ -739,6 +740,12 @@ static PCIINTxRoute spapr_route_intx_pin_to_irq(void *= opaque, int pin) return route; } =20 +static uint64_t spapr_msi_read(void *opaque, hwaddr addr, unsigned size) +{ + qemu_log_mask(LOG_GUEST_ERROR, "%s: invalid access\n", __func__); + return 0; +} + /* * MSI/MSIX memory region implementation. * The handler handles both MSI and MSIX. @@ -756,8 +763,11 @@ static void spapr_msi_write(void *opaque, hwaddr addr, } =20 static const MemoryRegionOps spapr_msi_ops =3D { - /* There is no .read as the read result is undefined by PCI spec */ - .read =3D NULL, + /* + * .read result is undefined by PCI spec. + * define .read method to avoid assert failure in memory_region_init_io + */ + .read =3D spapr_msi_read, .write =3D spapr_msi_write, .endianness =3D DEVICE_LITTLE_ENDIAN }; --=20 2.29.2