From nobody Fri May 17 10:13:26 2024 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=fail; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=fail(p=none dis=none) header.from=linaro.org ARC-Seal: i=1; a=rsa-sha256; t=1612808479; cv=none; d=zohomail.com; s=zohoarc; b=YNS1Zgb6sn2SBQeGGCn8nBd5Cf8kuQSryVryx0kfskgvYxj2fumdEDU17XvmGVxyl79DVq4WL2GVUs917EJvaH7RpfmR9ltQwbe14GdoDc2vjgofIVkyZb2achSaPljOaltcjb9/mjg3AV1R9ljoBvxCyW1JHs3hxodWy/KQZn4= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1612808479; h=Content-Transfer-Encoding:Cc:Date:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:To; bh=6otRbMP+RBOCThfyzMD60/aGmiUs/GM+dCCZu0lPioY=; b=hMZzCECZORDbrTPiAOGavQgfVIV5+zNr3YcoWP1NXKQrYtDOXpzBS5g0fOSXOvI+w0YnlEa5NFU9epauqporthJvhFil4ucPMSYBOZTanImdbfzgtAeyWdbMJU7pyhy5c0gAwQJIgGQrUunK7yKodx/s+03V16h2ezCSIMwkLow= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=fail; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=fail header.from= (p=none dis=none) header.from= Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1612808479819116.91162004235707; Mon, 8 Feb 2021 10:21:19 -0800 (PST) Received: from localhost ([::1]:35834 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1l9B9y-0007n2-Py for importer@patchew.org; Mon, 08 Feb 2021 13:21:18 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]:46376) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1l94oY-0003xp-4x for qemu-devel@nongnu.org; Mon, 08 Feb 2021 06:34:53 -0500 Received: from mail-wm1-x335.google.com ([2a00:1450:4864:20::335]:39611) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1l94oM-0003tG-AM for qemu-devel@nongnu.org; Mon, 08 Feb 2021 06:34:45 -0500 Received: by mail-wm1-x335.google.com with SMTP id u14so12884428wmq.4 for ; Mon, 08 Feb 2021 03:34:33 -0800 (PST) Received: from orth.archaic.org.uk (orth.archaic.org.uk. [81.2.115.148]) by smtp.gmail.com with ESMTPSA id a21sm16818134wmb.5.2021.02.08.03.34.31 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 08 Feb 2021 03:34:32 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=6otRbMP+RBOCThfyzMD60/aGmiUs/GM+dCCZu0lPioY=; b=DxAruZKAc37QErLh8Ga7gA8Y0lDDqWlWJr+hDVdejFm5jvpnU7S1oJhycSjkj7fHDx DqwaK5vct8eGEOx3anH+V6yWeBpG7kxKJWtjAWv/uYfNWYE9tf9vz9URre/5KFoSrp/b B0dCW8GZaFCAP/fUy/+q+JJHUy+hIqnouoMIG8V5aGuc3xcH72ZWAOtt/Na1PHOYoRYl 05j3YAn+q7Sdcis+0MNu8hH1sJYUUNHGsWc9uY+//pkXwke1z/ddwNviJ99A1MrZPB/y Wax07zDhKubKPB7UQKiWlYPS//0Rtgdfxjg0tfkuzWW/i4qtzo8MKgG3gVCiOMtQxVVu kLuA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=6otRbMP+RBOCThfyzMD60/aGmiUs/GM+dCCZu0lPioY=; b=R8mCeisLmlXfFsH40zwaI1izLx1iPuS59UDUVY5MbFFEJTQauNGXI5/XDonMJTENga H9ps7riNLCvOuzHRg8lgYxizkYyiqf3EPJCf24kJ/tjql7oUAqhRYLk844g8wKyAwjSU VFKPB29WrboNd9zemRzLTvoDQiZcYmXW2BV3Us13um35ou5uJg/+botSdsa/SoW5j9fh HzVoWYGhODMfalXPR/UL6UIwrygA+V1l172UttUj13TUztG9oII8Cm9q8EBXkMUX5TNF GxwORY9SqnLWqJxGhDpflyLQDp/CcZ6VI4IRXAV7t8InHEanU9tiVOSZDtm22Vu3YHkW R/rQ== X-Gm-Message-State: AOAM532xIsGBTpriiNwMZzDcW0nxFiFFtAuzzLVaOHR0RLIGdpRzbXpx 162NtpKrf/ZfYWNWH1g43auqn7JlwQbgOg== X-Google-Smtp-Source: ABdhPJw54s4ZmyiA0RRCcVoNnZuEcmP0Wt+jluPCrbCyFPWsmSv+rZ8x2raJtTPzLYzoMOHVI9RMrg== X-Received: by 2002:a1c:9e4d:: with SMTP id h74mr14290952wme.103.1612784072674; Mon, 08 Feb 2021 03:34:32 -0800 (PST) From: Peter Maydell To: qemu-devel@nongnu.org Subject: [PATCH 1/5] target/sh4: Drop use of gdb_get_float32() and ldfl_p() Date: Mon, 8 Feb 2021 11:34:24 +0000 Message-Id: <20210208113428.7181-2-peter.maydell@linaro.org> X-Mailer: git-send-email 2.20.1 In-Reply-To: <20210208113428.7181-1-peter.maydell@linaro.org> References: <20210208113428.7181-1-peter.maydell@linaro.org> MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Received-SPF: pass client-ip=2a00:1450:4864:20::335; envelope-from=peter.maydell@linaro.org; helo=mail-wm1-x335.google.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=unavailable autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Yoshinori Sato , =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= , Richard Henderson , Greg Kurz , Laurent Vivier , qemu-ppc@nongnu.org, =?UTF-8?q?Alex=20Benn=C3=A9e?= , David Gibson Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: "Qemu-devel" X-ZohoMail-DKIM: fail (Header signature does not verify) Content-Type: text/plain; charset="utf-8" We used to make a distinction between 'float64'/'float32' types and the 'uint64_t'/'uint32_t' types, requiring special conversion operations to go between them. We've now dropped this distinction as unnecessary, and the 'float*' types remain primarily for documentation purposes when used in places like the function prototypes of TCG helper functions. This means that there's no need for a special gdb_get_float32() function to write a float32 value to the GDB protocol buffer; we can just use gdb_get_reg32(). Similarly, for reading a value out of the GDB buffer into a float32 we can use ldl_p() and need not use ldfl_p(). Signed-off-by: Peter Maydell Reviewed-by: Philippe Mathieu-Daud=C3=A9 --- target/sh4/gdbstub.c | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/target/sh4/gdbstub.c b/target/sh4/gdbstub.c index 34ad3ca0508..3488f68e326 100644 --- a/target/sh4/gdbstub.c +++ b/target/sh4/gdbstub.c @@ -58,9 +58,9 @@ int superh_cpu_gdb_read_register(CPUState *cs, GByteArray= *mem_buf, int n) return gdb_get_regl(mem_buf, env->fpscr); case 25 ... 40: if (env->fpscr & FPSCR_FR) { - return gdb_get_float32(mem_buf, env->fregs[n - 9]); + return gdb_get_reg32(mem_buf, env->fregs[n - 9]); } - return gdb_get_float32(mem_buf, env->fregs[n - 25]); + return gdb_get_reg32(mem_buf, env->fregs[n - 25]); case 41: return gdb_get_regl(mem_buf, env->ssr); case 42: @@ -119,9 +119,9 @@ int superh_cpu_gdb_write_register(CPUState *cs, uint8_t= *mem_buf, int n) break; case 25 ... 40: if (env->fpscr & FPSCR_FR) { - env->fregs[n - 9] =3D ldfl_p(mem_buf); + env->fregs[n - 9] =3D ldl_p(mem_buf); } else { - env->fregs[n - 25] =3D ldfl_p(mem_buf); + env->fregs[n - 25] =3D ldl_p(mem_buf); } break; case 41: --=20 2.20.1 From nobody Fri May 17 10:13:26 2024 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=fail; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=fail(p=none dis=none) header.from=linaro.org ARC-Seal: i=1; a=rsa-sha256; t=1612808308; cv=none; d=zohomail.com; s=zohoarc; b=OhD+t9F3s3pnNugPJo6ERV07VCwj2D/N8QNGBud7WSJzfO19GEF1cNAhf3nr0Nn79aVou5yN5pZlHjXnc47jcv5o2wqPsi90CG6wF6efM7rdd7xUlZg1f2Mfl0oA/xqjdyko+IzWEmCOtUg9OBcjh51WAYC4i7Niuh1KsOTSM/8= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1612808308; h=Content-Transfer-Encoding:Cc:Date:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:To; bh=SuGbvoGfA87QOxhejnfnAT4N6Q/MWEiUccByyN71et0=; b=iwPg4pkHPmzxjpMcbNaMnxQo3wmJOVTG0QI25KFhg35mT4TwrY+82CHq+jlmQDOBn+eENtsbjquzjCv29aNA9nwUzJhC9oDoc0FMs/QRc2wayqtHWDfjbJuOZ+8vjiWDTBRzoUK3AhpcLVyY+Z7s2PdSaVnlma+sOV3w691wqs0= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=fail; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=fail header.from= (p=none dis=none) header.from= Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 161280830843021.847228082071524; Mon, 8 Feb 2021 10:18:28 -0800 (PST) Received: from localhost ([::1]:55426 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1l9B7D-0003x4-6W for importer@patchew.org; Mon, 08 Feb 2021 13:18:27 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]:46342) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1l94oS-0003wn-4C for qemu-devel@nongnu.org; Mon, 08 Feb 2021 06:34:43 -0500 Received: from mail-wm1-x334.google.com ([2a00:1450:4864:20::334]:35482) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1l94oN-0003tQ-1r for qemu-devel@nongnu.org; Mon, 08 Feb 2021 06:34:39 -0500 Received: by mail-wm1-x334.google.com with SMTP id j21so10197577wmj.0 for ; Mon, 08 Feb 2021 03:34:34 -0800 (PST) Received: from orth.archaic.org.uk (orth.archaic.org.uk. [81.2.115.148]) by smtp.gmail.com with ESMTPSA id a21sm16818134wmb.5.2021.02.08.03.34.32 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 08 Feb 2021 03:34:33 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=SuGbvoGfA87QOxhejnfnAT4N6Q/MWEiUccByyN71et0=; b=FaSE7dv4PNMRTubg3zFNttVvqEwLIW2LUO0c10BurHGifmvQuBzKVrQAn+sE3K2cHx 7AQc2VfNhPuekq0qY17N02QZJBEIrePYNa4BesZYnltUKkX5iFb9uSNwgdNa6pJ8yqhk lMZkvZlTTh4v8JCbxWOrU7faC1cVfPOhLLx6BnfrVww68lZbAvK+a3vqhIT+fVTRs5ca FhoOavKnbYGlG7fzUYqC5RPnpVKBehcIeWRDdeMkoLp49rRAqo3EQOZQ0lTM2CKYoCQH LryzVotyeqlwqclBuYlfMiVATPO7fVINKEkvzVGKZ0EuUxgdN/i1BJyZ06661OAFLt1C g2IQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=SuGbvoGfA87QOxhejnfnAT4N6Q/MWEiUccByyN71et0=; b=Nkgexv0OgfQjYetq5wnHStAo8UDKnH3ihVmB2TE8JkB+5GiaNBPxPRlR2K6wqho+jb DzecpBZuDKkrVczi8/osKw0Yrbz1Y1z/n6uAP66Owsq2aDd7GR7qmJUvQBjI1KXnoBMx EStuOtur2GjIvly7YxPiLNgaaMMLkE+RRnQp1gsbxnWFMWOsDj3ucjcXbbaeCknx3vIq V9QAXSHr1cH08m1TwyO393US6uhEdx2SctIVZCP/KaSoU3v0Upw3wxRX9++xJ+8Swrhq FQqD+UmIL72KToY1lqPcja8ZHG+/cVS1S7+y20IJC7jaRAZT1T+SJ07VlP8jmFqNSexH onlg== X-Gm-Message-State: AOAM5334a2yJ2LZnf9/2yfolsvhkSLGyEzvES9bGy37ZPSo3qN3vmtIn aRbvjVJQsJU0Cg/CkSCuwVd8UTKzHjrRvw== X-Google-Smtp-Source: ABdhPJzdNPB8CntcAhYWBohqosUDx/y+MJDBo/pUe3hDy/hId7tNdwT0DqqvU9GGzHw6zbZmztbNZg== X-Received: by 2002:a05:600c:47d7:: with SMTP id l23mr8154597wmo.16.1612784073777; Mon, 08 Feb 2021 03:34:33 -0800 (PST) From: Peter Maydell To: qemu-devel@nongnu.org Subject: [PATCH 2/5] target/m68k: Drop use of gdb_get_float64() and ldfq_p() Date: Mon, 8 Feb 2021 11:34:25 +0000 Message-Id: <20210208113428.7181-3-peter.maydell@linaro.org> X-Mailer: git-send-email 2.20.1 In-Reply-To: <20210208113428.7181-1-peter.maydell@linaro.org> References: <20210208113428.7181-1-peter.maydell@linaro.org> MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Received-SPF: pass client-ip=2a00:1450:4864:20::334; envelope-from=peter.maydell@linaro.org; helo=mail-wm1-x334.google.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=unavailable autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Yoshinori Sato , =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= , Richard Henderson , Greg Kurz , Laurent Vivier , qemu-ppc@nongnu.org, =?UTF-8?q?Alex=20Benn=C3=A9e?= , David Gibson Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: "Qemu-devel" X-ZohoMail-DKIM: fail (Header signature does not verify) Content-Type: text/plain; charset="utf-8" We used to make a distinction between 'float64'/'float32' types and the 'uint64_t'/'uint32_t' types, requiring special conversion operations to go between them. We've now dropped this distinction as unnecessary, and the 'float*' types remain primarily for documentation purposes when used in places like the function prototypes of TCG helper functions. This means that there's no need for a special gdb_get_float64() function to write a float64 value to the GDB protocol buffer; we can just use gdb_get_reg64(). Similarly, for reading a value out of the GDB buffer into a float64 we can use ldq_p() and need not use ldfq_p(). Signed-off-by: Peter Maydell Acked-by: Laurent Vivier Reviewed-by: Philippe Mathieu-Daud=C3=A9 --- target/m68k/helper.c | 5 ++--- 1 file changed, 2 insertions(+), 3 deletions(-) diff --git a/target/m68k/helper.c b/target/m68k/helper.c index 3ff57657958..09f0391d508 100644 --- a/target/m68k/helper.c +++ b/target/m68k/helper.c @@ -72,8 +72,7 @@ static int cf_fpu_gdb_get_reg(CPUM68KState *env, GByteArr= ay *mem_buf, int n) { if (n < 8) { float_status s; - return gdb_get_float64(mem_buf, - floatx80_to_float64(env->fregs[n].d, &s)); + return gdb_get_reg64(mem_buf, floatx80_to_float64(env->fregs[n].d,= &s)); } switch (n) { case 8: /* fpcontrol */ @@ -90,7 +89,7 @@ static int cf_fpu_gdb_set_reg(CPUM68KState *env, uint8_t = *mem_buf, int n) { if (n < 8) { float_status s; - env->fregs[n].d =3D float64_to_floatx80(ldfq_p(mem_buf), &s); + env->fregs[n].d =3D float64_to_floatx80(ldq_p(mem_buf), &s); return 8; } switch (n) { --=20 2.20.1 From nobody Fri May 17 10:13:26 2024 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=fail; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=fail(p=none dis=none) header.from=linaro.org ARC-Seal: i=1; a=rsa-sha256; t=1612807798; cv=none; d=zohomail.com; s=zohoarc; b=ThMG0GwDoovHckwz/gmxdz5NUSbQbikQ+LQjdrY5oLqnetDhlzi4LM1CS53g4ZWCJGD4ah85xs+lfxxuF5XTM8YbNAzFZDLGyFr/brzKZdq9z1nlz6rDuCS6yEQaGAr3xCemNG9/1skfiBRQmrzJUo3A6w5nRTXKDsb5fDQg7hM= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1612807798; h=Content-Transfer-Encoding:Cc:Date:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:To; bh=yCPs8uBbj3EM3WeNeRALMaxaZ1sbESL4fRT0Kc+6RkY=; b=KzEZPLhlDT3ThbK+3o+8hK8gyKkgAIDZCAoWtmasb6/f78a1beXVQx1qpZe/5tGjKCaHNaTKcaoRTb34/4sqpyH+SL5QOgQ0sFJ0FpjGv2wtakJBOgUUgdGGKx6q1rDvBySpoP6i+3VK1PPLZ69yg5SpSdL088w9SUPuqvLDlXQ= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=fail; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=fail header.from= (p=none dis=none) header.from= Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1612807798115274.77001388804763; Mon, 8 Feb 2021 10:09:58 -0800 (PST) Received: from localhost ([::1]:59946 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1l9Ayy-000254-Ue for importer@patchew.org; Mon, 08 Feb 2021 13:09:56 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]:46380) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1l94oY-0003xr-BU for qemu-devel@nongnu.org; Mon, 08 Feb 2021 06:34:53 -0500 Received: from mail-wm1-x335.google.com ([2a00:1450:4864:20::335]:35483) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1l94oO-0003uF-9k for qemu-devel@nongnu.org; Mon, 08 Feb 2021 06:34:46 -0500 Received: by mail-wm1-x335.google.com with SMTP id j21so10197628wmj.0 for ; Mon, 08 Feb 2021 03:34:35 -0800 (PST) Received: from orth.archaic.org.uk (orth.archaic.org.uk. [81.2.115.148]) by smtp.gmail.com with ESMTPSA id a21sm16818134wmb.5.2021.02.08.03.34.33 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 08 Feb 2021 03:34:34 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=yCPs8uBbj3EM3WeNeRALMaxaZ1sbESL4fRT0Kc+6RkY=; b=jJyxm0V0qQiInDv9y92pmEQsyEYSwhilFeaolMc3ri+p4+BxvEvaMqUTlqI7Pfq1hD 2kSBDCnpOD4VSBK9jzq5N2ankMI79TeezXyEqr4RuXxF1XCWy6UNjrtfZJHtSKr5Q72m ZlZ1sHynchg0CdPpQwp41eEO82fhINn7h5Y/YUieVjgX2AwNTF5zDeZQEbe/O3dFdKrL Z/v5j8t4k88UsFI8S4So3XpZltGy6J/6VBP6gHgAurXpUHEqE+2fO+Mo69r2HqMv6nLS LKfcA5RnS8YfNgxAqSGOsSK5RAjKFGhPR0HNVghyp81IuCvBPgLnBmkccX9PhkaungQI gknQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=yCPs8uBbj3EM3WeNeRALMaxaZ1sbESL4fRT0Kc+6RkY=; b=Nx7L6F3ZcdaVZHRSGFRKEP4zLHPkqgG1AeiGBsR2PrCiJ//XCfT0qoaiwnO2ZCR0Q5 QkE6dEcUXNkYwtXzozuEx+BFNDvTspdpFc7X0BrCdCmjXws/Rizck1lB5LalOaV2B2kw su0mPOZaNljbRk9nMIdDamQaR1Q//DjacxNGJOcNAD4AUqp1wBdShDy427mB0B/ov7mY 9Bu36aK1ozXgweBUBrq2gIGwNlhCeHzsWofXsL7Za93mU3XO9kgmwa8udu2fRdZlURad 8q6x19cVzRTRlPUWqwxN0cN5jcuTHVrBwlof+eKXURZGSo+UXfqskl64Uwwfu16HFXSf jr7A== X-Gm-Message-State: AOAM533XUbzrLh+1jZv71tsYMyj4VHsOg/Hk8A6emxY0xBDToq+H9ndg N1fFRr4VNBo11eL3hxUXMCvR8DQfqgmLQw== X-Google-Smtp-Source: ABdhPJzuzeAnwpoy4GwrbxIVLFdpjBltE+104fo2yeHjNQxv8S2pwsi2mj1nhkMW2x4+1hQ84A6vsg== X-Received: by 2002:a1c:4d05:: with SMTP id o5mr14250483wmh.51.1612784075058; Mon, 08 Feb 2021 03:34:35 -0800 (PST) From: Peter Maydell To: qemu-devel@nongnu.org Subject: [PATCH 3/5] target/ppc: Drop use of gdb_get_float64() and ldfq_p() Date: Mon, 8 Feb 2021 11:34:26 +0000 Message-Id: <20210208113428.7181-4-peter.maydell@linaro.org> X-Mailer: git-send-email 2.20.1 In-Reply-To: <20210208113428.7181-1-peter.maydell@linaro.org> References: <20210208113428.7181-1-peter.maydell@linaro.org> MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Received-SPF: pass client-ip=2a00:1450:4864:20::335; envelope-from=peter.maydell@linaro.org; helo=mail-wm1-x335.google.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=unavailable autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Yoshinori Sato , =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= , Richard Henderson , Greg Kurz , Laurent Vivier , qemu-ppc@nongnu.org, =?UTF-8?q?Alex=20Benn=C3=A9e?= , David Gibson Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: "Qemu-devel" X-ZohoMail-DKIM: fail (Header signature does not verify) Content-Type: text/plain; charset="utf-8" We used to make a distinction between 'float64'/'float32' types and the 'uint64_t'/'uint32_t' types, requiring special conversion operations to go between them. We've now dropped this distinction as unnecessary, and the 'float*' types remain primarily for documentation purposes when used in places like the function prototypes of TCG helper functions. This means that there's no need for a special gdb_get_float64() function to write a float64 value to the GDB protocol buffer; we can just use gdb_get_reg64(). Similarly, for reading a value out of the GDB buffer into a float64 we can use ldq_p() and need not use ldfq_p(). Signed-off-by: Peter Maydell Acked-by: David Gibson Reviewed-by: Philippe Mathieu-Daud=C3=A9 --- target/ppc/gdbstub.c | 8 ++++---- target/ppc/translate_init.c.inc | 4 ++-- 2 files changed, 6 insertions(+), 6 deletions(-) diff --git a/target/ppc/gdbstub.c b/target/ppc/gdbstub.c index 01459dd31d2..c28319fb974 100644 --- a/target/ppc/gdbstub.c +++ b/target/ppc/gdbstub.c @@ -130,7 +130,7 @@ int ppc_cpu_gdb_read_register(CPUState *cs, GByteArray = *buf, int n) gdb_get_regl(buf, env->gpr[n]); } else if (n < 64) { /* fprs */ - gdb_get_float64(buf, *cpu_fpr_ptr(env, n - 32)); + gdb_get_reg64(buf, *cpu_fpr_ptr(env, n - 32)); } else { switch (n) { case 64: @@ -184,7 +184,7 @@ int ppc_cpu_gdb_read_register_apple(CPUState *cs, GByte= Array *buf, int n) gdb_get_reg64(buf, env->gpr[n]); } else if (n < 64) { /* fprs */ - gdb_get_float64(buf, *cpu_fpr_ptr(env, n - 32)); + gdb_get_reg64(buf, *cpu_fpr_ptr(env, n - 32)); } else if (n < 96) { /* Altivec */ gdb_get_reg64(buf, n - 64); @@ -241,7 +241,7 @@ int ppc_cpu_gdb_write_register(CPUState *cs, uint8_t *m= em_buf, int n) env->gpr[n] =3D ldtul_p(mem_buf); } else if (n < 64) { /* fprs */ - *cpu_fpr_ptr(env, n - 32) =3D ldfq_p(mem_buf); + *cpu_fpr_ptr(env, n - 32) =3D ldq_p(mem_buf); } else { switch (n) { case 64: @@ -291,7 +291,7 @@ int ppc_cpu_gdb_write_register_apple(CPUState *cs, uint= 8_t *mem_buf, int n) env->gpr[n] =3D ldq_p(mem_buf); } else if (n < 64) { /* fprs */ - *cpu_fpr_ptr(env, n - 32) =3D ldfq_p(mem_buf); + *cpu_fpr_ptr(env, n - 32) =3D ldq_p(mem_buf); } else { switch (n) { case 64 + 32: diff --git a/target/ppc/translate_init.c.inc b/target/ppc/translate_init.c.= inc index 9867d0a6e4a..7bd111d905e 100644 --- a/target/ppc/translate_init.c.inc +++ b/target/ppc/translate_init.c.inc @@ -9907,7 +9907,7 @@ static int gdb_get_float_reg(CPUPPCState *env, GByteA= rray *buf, int n) { uint8_t *mem_buf; if (n < 32) { - gdb_get_float64(buf, *cpu_fpr_ptr(env, n)); + gdb_get_reg64(buf, *cpu_fpr_ptr(env, n)); mem_buf =3D gdb_get_reg_ptr(buf, 8); ppc_maybe_bswap_register(env, mem_buf, 8); return 8; @@ -9925,7 +9925,7 @@ static int gdb_set_float_reg(CPUPPCState *env, uint8_= t *mem_buf, int n) { if (n < 32) { ppc_maybe_bswap_register(env, mem_buf, 8); - *cpu_fpr_ptr(env, n) =3D ldfq_p(mem_buf); + *cpu_fpr_ptr(env, n) =3D ldq_p(mem_buf); return 8; } if (n =3D=3D 32) { --=20 2.20.1 From nobody Fri May 17 10:13:26 2024 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=fail; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=fail(p=none dis=none) header.from=linaro.org ARC-Seal: i=1; a=rsa-sha256; t=1612808855; cv=none; d=zohomail.com; s=zohoarc; b=WMGeTNmnoEgefGq+ZzawGtNq+p+hUJxO7izvLsPM9A6qL+EMx+nJd7k2SiBnojJF5A8xFSzyuKUaYhfrjcdG8k1srOB7HB2eb5HjmdjhbSrEafL1JZrd/xJlS/+AEU5uBWANSI2t2uDSoIZ99FKtQX5f/cg5O2coh8sR2tlxeDQ= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1612808855; h=Content-Transfer-Encoding:Cc:Date:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:To; bh=NRipOYGkJlw71cozvw80LImxtUVgB5q/r0TWkP1rEHo=; b=oC2fG0JZExuVP6rdg7EDtk4yN61TuZJUgIN8y2fgxhbzspJnfEgDtJKDOtjfaiZDZBlwlPcx0QNkn5eBd1eLavUzbh43X0xX4trYHztB+H+eLJdYHXaKogTIJiYi0O6pVtnHXzjLGr2Q3i8LOwzEdDvDGE0bk3Z28YFdc7FrsmU= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=fail; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=fail header.from= (p=none dis=none) header.from= Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1612808855633344.96236514184534; Mon, 8 Feb 2021 10:27:35 -0800 (PST) Received: from localhost ([::1]:50444 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1l9BG2-0005oP-Fl for importer@patchew.org; Mon, 08 Feb 2021 13:27:34 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]:46388) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1l94oY-0003xu-Iw for qemu-devel@nongnu.org; Mon, 08 Feb 2021 06:34:53 -0500 Received: from mail-wm1-x32c.google.com ([2a00:1450:4864:20::32c]:36681) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1l94oP-0003uy-LQ for qemu-devel@nongnu.org; Mon, 08 Feb 2021 06:34:46 -0500 Received: by mail-wm1-x32c.google.com with SMTP id i9so12914820wmq.1 for ; Mon, 08 Feb 2021 03:34:37 -0800 (PST) Received: from orth.archaic.org.uk (orth.archaic.org.uk. [81.2.115.148]) by smtp.gmail.com with ESMTPSA id a21sm16818134wmb.5.2021.02.08.03.34.35 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 08 Feb 2021 03:34:35 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=NRipOYGkJlw71cozvw80LImxtUVgB5q/r0TWkP1rEHo=; b=qOnnBnrNcGeBw7byLNuHyvFjRTwZe0O8F8nM6nv01CdlRtlTim03fdePgWin0EQCG4 JokRH7vxEb1aqJERyo/P7BUHP0IeCg/wa9v8ItZ8Qnx79vCPzcbgAbhr8Jna4Zde8omn XOR9cWkuoi70lNrP5/KKlp+GStb7oQLKM4A7EHomxpXT5xd19zo1R7/1mBc0eeZJ+O3I HOsMhAI04v38c/nCdT17aQzwZVSAErMX2UoTKXbUpV4mh0smAQ829Mtilz83u1tmn4v+ 5vy21pswTw410eMZ5OeqUR/t6wd8c9KjDW3lQY0TXY+H7xdlk6xDLoItkB0H17kFP1pw E9aA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=NRipOYGkJlw71cozvw80LImxtUVgB5q/r0TWkP1rEHo=; b=MuC8gGQFcCvBh6M3lWdvMvPorumrTepvKIuMETn7pnDC5dYFKyxZ1xYjn0r7XDd14g kso6+Rm4r+dvHAXBcxkCU78KTzHk/EVIvsNIPMfqAE1dkhQvyKfxcxyMNQDwHLX9/Hdj DpboVqqAs/6iEQEJfivwADbwS3mHpp1s4FVm7fJKB5dvzQth0kwuaCUSu/o4zK/6zKiU LE4KpXCfszSgxr37jwotDFNQAGQNgaUclCEKh28RJtATeoMKQB2sE1+OfJl8U0wbwT5O ITlN5NSmGD04EMCqOGWM2bI/47kUcnEiG9kIF/JTdHmva8kxK94YQm9gFL64PSZ+J0nr uZ6g== X-Gm-Message-State: AOAM5333FU3rhS5ON75WPnolTjWyXUkk7Gg0MtCz8/VD0+pxhcusL/rp yLMMqR6HhJX1MQ+c8pJIAtPh6F42V0ZELg== X-Google-Smtp-Source: ABdhPJw/sNXRp51imHj58BIrcuT9hhY86sk5wt/ywjWaT1C9YFB0RKvc1YXctX3LFp2Dkt02wW+jlg== X-Received: by 2002:a05:600c:1986:: with SMTP id t6mr14269979wmq.92.1612784076230; Mon, 08 Feb 2021 03:34:36 -0800 (PST) From: Peter Maydell To: qemu-devel@nongnu.org Subject: [PATCH 4/5] gdbstub: Remove unused gdb_get_float32() and gdb_get_float64() Date: Mon, 8 Feb 2021 11:34:27 +0000 Message-Id: <20210208113428.7181-5-peter.maydell@linaro.org> X-Mailer: git-send-email 2.20.1 In-Reply-To: <20210208113428.7181-1-peter.maydell@linaro.org> References: <20210208113428.7181-1-peter.maydell@linaro.org> MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Received-SPF: pass client-ip=2a00:1450:4864:20::32c; envelope-from=peter.maydell@linaro.org; helo=mail-wm1-x32c.google.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=unavailable autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Yoshinori Sato , =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= , Richard Henderson , Greg Kurz , Laurent Vivier , qemu-ppc@nongnu.org, =?UTF-8?q?Alex=20Benn=C3=A9e?= , David Gibson Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: "Qemu-devel" X-ZohoMail-DKIM: fail (Header signature does not verify) Content-Type: text/plain; charset="utf-8" The functions gdb_get_float32() and gdb_get_float64() are now unused; remove them. Signed-off-by: Peter Maydell Reviewed-by: Philippe Mathieu-Daud=C3=A9 --- include/exec/gdbstub.h | 20 -------------------- 1 file changed, 20 deletions(-) diff --git a/include/exec/gdbstub.h b/include/exec/gdbstub.h index ff0b7bc45ec..a024a0350df 100644 --- a/include/exec/gdbstub.h +++ b/include/exec/gdbstub.h @@ -135,26 +135,6 @@ static inline int gdb_get_reg128(GByteArray *buf, uint= 64_t val_hi, return 16; } =20 -static inline int gdb_get_float32(GByteArray *array, float32 val) -{ - uint8_t buf[sizeof(CPU_FloatU)]; - - stfl_p(buf, val); - g_byte_array_append(array, buf, sizeof(buf)); - - return sizeof(buf); -} - -static inline int gdb_get_float64(GByteArray *array, float64 val) -{ - uint8_t buf[sizeof(CPU_DoubleU)]; - - stfq_p(buf, val); - g_byte_array_append(array, buf, sizeof(buf)); - - return sizeof(buf); -} - static inline int gdb_get_zeroes(GByteArray *array, size_t len) { guint oldlen =3D array->len; --=20 2.20.1 From nobody Fri May 17 10:13:26 2024 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=fail; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=fail(p=none dis=none) header.from=linaro.org ARC-Seal: i=1; a=rsa-sha256; t=1612809074; cv=none; d=zohomail.com; s=zohoarc; b=hlHUVGo4GhxwtWP5yUFHBX/zMlaSY5aWEo5SSaYQaKeCF1Nn4kyKGCIE7rnJzpb4LEktPk38+gMQ03eXbmBf8DAMMAoonKJi1WAZQbFs6wNv/kUcD6a+DobvUJbyw7PCsVVFxrSh48PJdoKngoSVt1WN5wMBAneCQsb+x0EX3V4= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1612809074; h=Content-Transfer-Encoding:Cc:Date:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:To; bh=B1h5etOiLMptd0QotFJfPFeVz8tBFIurLvpYgVaGA0I=; b=aISCEEcExdtIijnZPgBVE57UGLAxNqXH/OoEaDTIRQb/sJzM6csC60PUiVF5A39cPM5bW0cJxyoC8XPB8ON6vO6CjkXkwFCCSQ+yH3SZFAK10OSWRc16AqX7/nVtGeGLL+5EJVN2YSUQB6CH8arLOL0+0FUcty/7em93QmEl9TI= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=fail; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=fail header.from= (p=none dis=none) header.from= Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1612809074413908.9085306440313; Mon, 8 Feb 2021 10:31:14 -0800 (PST) Received: from localhost ([::1]:58834 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1l9BJZ-0000yT-7Q for importer@patchew.org; Mon, 08 Feb 2021 13:31:13 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]:46410) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1l94oi-0003ya-8t for qemu-devel@nongnu.org; Mon, 08 Feb 2021 06:34:57 -0500 Received: from mail-wm1-x335.google.com ([2a00:1450:4864:20::335]:37475) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1l94oQ-0003vV-Ta for qemu-devel@nongnu.org; Mon, 08 Feb 2021 06:34:55 -0500 Received: by mail-wm1-x335.google.com with SMTP id m1so12901247wml.2 for ; Mon, 08 Feb 2021 03:34:38 -0800 (PST) Received: from orth.archaic.org.uk (orth.archaic.org.uk. [81.2.115.148]) by smtp.gmail.com with ESMTPSA id a21sm16818134wmb.5.2021.02.08.03.34.36 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 08 Feb 2021 03:34:36 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=B1h5etOiLMptd0QotFJfPFeVz8tBFIurLvpYgVaGA0I=; b=R0z69Li9EdbacZlvdfkGtXv6Mu0PJf6ko9KupVUs/cGNGkzpYnlBFJbnja+83/MN9M AJXl2exJBFPV3gvrZyUlSTx3smpuW9L7QesVd7+Hx9HPM34ry/RFG4d2kwTFOkO8lQi8 YID6BFeP1DRi+c+YkPYB/NVg2aaHtdgBdtfnMWRDnoG0WRU66T1/eh/a4op7y2Bn1cVa paeTolwKDLxlxGvaYJgWba64UDVNfOi67qyiUkGpyJyGs4UflDkephQ8kzFqEsNECpMw qtZUUpboWg1rYqpLwGTMrs+kNvuEbKuGH694Wpen3b9Tu1O6KuKrgnWAfH5X9VJxUZrF OBUw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=B1h5etOiLMptd0QotFJfPFeVz8tBFIurLvpYgVaGA0I=; b=kEVi6IfTkZM+G6mQkGLR/2sBMj8y0QdzKGqjZLtCEZs7U8xFHg+XiCoHiFzqpHqHIJ Jwt4QhESW0fivIhYx9i4V4NmriKzS3HdjPv2r9bhsNQlzz/Ef0pUTxH1DeY9l+Myf1MP esC0DYsISx777Upo2Xw3jA/QoWf2TmO8bOZ8e1qhREUWrVS0NFOzJ3pMMiKQbWj4zLW0 2SiWxgiQRuFNmPHbednkiH4zy3jp98wOewv2YmcPCn/raqs/6uNhRM1GEsM4ugeRnI0o 8hn81vOThEiXZyzP7VfOq/g/dHEtwL+NxlvhO2kqh0KsNvEf6yn5+om4P7/31Z2ofOA+ ltVg== X-Gm-Message-State: AOAM532oI1XyQ90bManmvuIacMD8uHzQL4HchqdAVro8Oe6thv5kamGH QNjSJ3LXcPnbjW7KfhGrEdZQ+lk9MHYCrw== X-Google-Smtp-Source: ABdhPJwKDLIwHto3u4tWbEO1ZrjhFVdXTx+D8soytaQkyfK/y3m1Yzo3aWN3GbHo1GbM04eGVTSZgA== X-Received: by 2002:a05:600c:2210:: with SMTP id z16mr5648130wml.50.1612784077476; Mon, 08 Feb 2021 03:34:37 -0800 (PST) From: Peter Maydell To: qemu-devel@nongnu.org Subject: [PATCH 5/5] bswap.h: Remove unused float-access functions Date: Mon, 8 Feb 2021 11:34:28 +0000 Message-Id: <20210208113428.7181-6-peter.maydell@linaro.org> X-Mailer: git-send-email 2.20.1 In-Reply-To: <20210208113428.7181-1-peter.maydell@linaro.org> References: <20210208113428.7181-1-peter.maydell@linaro.org> MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Received-SPF: pass client-ip=2a00:1450:4864:20::335; envelope-from=peter.maydell@linaro.org; helo=mail-wm1-x335.google.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=unavailable autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Yoshinori Sato , =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= , Richard Henderson , Greg Kurz , Laurent Vivier , qemu-ppc@nongnu.org, =?UTF-8?q?Alex=20Benn=C3=A9e?= , David Gibson Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: "Qemu-devel" X-ZohoMail-DKIM: fail (Header signature does not verify) Content-Type: text/plain; charset="utf-8" The float-access functions stfl_*, stfq*, ldfl* and ldfq* are now unused; remove them. (Accesses to float64 and float32 types can be made with the ldl/stl/ldq/stq functions, as float64 and float32 are guaranteed to be typedefs for normal integer types.) Signed-off-by: Peter Maydell Reviewed-by: Philippe Mathieu-Daud=C3=A9 --- docs/devel/loads-stores.rst | 14 ++++----- include/exec/cpu-all.h | 8 ----- include/qemu/bswap.h | 60 ------------------------------------- 3 files changed, 5 insertions(+), 77 deletions(-) diff --git a/docs/devel/loads-stores.rst b/docs/devel/loads-stores.rst index ee43f5dfee2..568274baec0 100644 --- a/docs/devel/loads-stores.rst +++ b/docs/devel/loads-stores.rst @@ -24,16 +24,12 @@ potentially unaligned pointer values. =20 Function names follow the pattern: =20 -load: ``ld{type}{sign}{size}_{endian}_p(ptr)`` +load: ``ld{sign}{size}_{endian}_p(ptr)`` =20 -store: ``st{type}{size}_{endian}_p(ptr, val)`` - -``type`` - - (empty) : integer access - - ``f`` : float access +store: ``st{size}_{endian}_p(ptr, val)`` =20 ``sign`` - - (empty) : for 32 or 64 bit sizes (including floats and doubles) + - (empty) : for 32 or 64 bit sizes - ``u`` : unsigned - ``s`` : signed =20 @@ -67,8 +63,8 @@ of size ``sz`` bytes. =20 =20 Regexes for git grep - - ``\`` - - ``\`` + - ``\`` + - ``\`` - ``\`` - ``\`` =20 diff --git a/include/exec/cpu-all.h b/include/exec/cpu-all.h index cfb1d793311..babf0a8959f 100644 --- a/include/exec/cpu-all.h +++ b/include/exec/cpu-all.h @@ -125,13 +125,9 @@ static inline void tswap64s(uint64_t *s) #define ldsw_p(p) ldsw_be_p(p) #define ldl_p(p) ldl_be_p(p) #define ldq_p(p) ldq_be_p(p) -#define ldfl_p(p) ldfl_be_p(p) -#define ldfq_p(p) ldfq_be_p(p) #define stw_p(p, v) stw_be_p(p, v) #define stl_p(p, v) stl_be_p(p, v) #define stq_p(p, v) stq_be_p(p, v) -#define stfl_p(p, v) stfl_be_p(p, v) -#define stfq_p(p, v) stfq_be_p(p, v) #define ldn_p(p, sz) ldn_be_p(p, sz) #define stn_p(p, sz, v) stn_be_p(p, sz, v) #else @@ -139,13 +135,9 @@ static inline void tswap64s(uint64_t *s) #define ldsw_p(p) ldsw_le_p(p) #define ldl_p(p) ldl_le_p(p) #define ldq_p(p) ldq_le_p(p) -#define ldfl_p(p) ldfl_le_p(p) -#define ldfq_p(p) ldfq_le_p(p) #define stw_p(p, v) stw_le_p(p, v) #define stl_p(p, v) stl_le_p(p, v) #define stq_p(p, v) stq_le_p(p, v) -#define stfl_p(p, v) stfl_le_p(p, v) -#define stfq_p(p, v) stfq_le_p(p, v) #define ldn_p(p, sz) ldn_le_p(p, sz) #define stn_p(p, sz, v) stn_le_p(p, sz, v) #endif diff --git a/include/qemu/bswap.h b/include/qemu/bswap.h index 8b01c38040c..4aaf992b5d7 100644 --- a/include/qemu/bswap.h +++ b/include/qemu/bswap.h @@ -400,36 +400,6 @@ static inline void stq_le_p(void *ptr, uint64_t v) stq_he_p(ptr, le_bswap(v, 64)); } =20 -/* float access */ - -static inline float32 ldfl_le_p(const void *ptr) -{ - CPU_FloatU u; - u.l =3D ldl_le_p(ptr); - return u.f; -} - -static inline void stfl_le_p(void *ptr, float32 v) -{ - CPU_FloatU u; - u.f =3D v; - stl_le_p(ptr, u.l); -} - -static inline float64 ldfq_le_p(const void *ptr) -{ - CPU_DoubleU u; - u.ll =3D ldq_le_p(ptr); - return u.d; -} - -static inline void stfq_le_p(void *ptr, float64 v) -{ - CPU_DoubleU u; - u.d =3D v; - stq_le_p(ptr, u.ll); -} - static inline int lduw_be_p(const void *ptr) { return (uint16_t)be_bswap(lduw_he_p(ptr), 16); @@ -465,36 +435,6 @@ static inline void stq_be_p(void *ptr, uint64_t v) stq_he_p(ptr, be_bswap(v, 64)); } =20 -/* float access */ - -static inline float32 ldfl_be_p(const void *ptr) -{ - CPU_FloatU u; - u.l =3D ldl_be_p(ptr); - return u.f; -} - -static inline void stfl_be_p(void *ptr, float32 v) -{ - CPU_FloatU u; - u.f =3D v; - stl_be_p(ptr, u.l); -} - -static inline float64 ldfq_be_p(const void *ptr) -{ - CPU_DoubleU u; - u.ll =3D ldq_be_p(ptr); - return u.d; -} - -static inline void stfq_be_p(void *ptr, float64 v) -{ - CPU_DoubleU u; - u.d =3D v; - stq_be_p(ptr, u.ll); -} - static inline unsigned long leul_to_cpu(unsigned long v) { #if HOST_LONG_BITS =3D=3D 32 --=20 2.20.1