From nobody Tue Nov 18 21:15:00 2025 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=fail; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org ARC-Seal: i=1; a=rsa-sha256; t=1612764875; cv=none; d=zohomail.com; s=zohoarc; b=HFN7ufDNBVmazsEIL187ICqQr0kboFn2taDGaV6JH5EJ9hKCTmXO7HEch9b8EuOmSB4iUz23G1KRxPHu0w4SsHeZfw16lnsqVc+06sWi9MrVSl5IITG39pJ/J+7RybL01QiRC0INUybcIjsVY/3fGiA64bdDtJp44efyNKv3+aM= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1612764875; h=Content-Transfer-Encoding:Cc:Date:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:To; bh=7s0UPVxKRUW+xS44z4RTZT1xcuFIsLjqG00W+0gbW1c=; b=XQkdYvh2vy++4oUbT5mlkczrgr5aF3+ifMosPCKqE+EedIqhlHZdSNAZEpZky9j6ArWC9mI8QrDocmxXvBVz7jDQMFV9AHBMCO/SVng2hHPjoEzOaOM+KijuqtU7Okq4dvzcciE4K0xSDhdLODojRgzU8uAuzL8/zFZSb4tMpRE= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=fail; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1612764875566805.0617109409627; Sun, 7 Feb 2021 22:14:35 -0800 (PST) Received: from localhost ([::1]:60746 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1l8zog-0008Qp-DN for importer@patchew.org; Mon, 08 Feb 2021 01:14:34 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]:58680) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1l8zgW-0007tp-51; Mon, 08 Feb 2021 01:06:08 -0500 Received: from bilbo.ozlabs.org ([2401:3900:2:1::2]:46997 helo=ozlabs.org) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1l8zgU-000639-27; Mon, 08 Feb 2021 01:06:07 -0500 Received: by ozlabs.org (Postfix, from userid 1007) id 4DYwVt2mp3z9sWQ; Mon, 8 Feb 2021 17:05:42 +1100 (AEDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=gibson.dropbear.id.au; s=201602; t=1612764342; bh=rGrCUIDaja9zftftkqQIdjL/kYsYIfZR7xVO077v4wc=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=AnWxRqvviaZUD7kIPhNWbtRxAjt3/WWEuf/bycf9gmjR+im/2Q/fmjha6oBz3eFKH jXrnF5HF1pYPnGWacmtFIbn5ZPDs3q+4injHA5V96M6yTeuAg/eDjinTf/43lJ/0RA txThkvKcyUNZjKOkpMptkHlBVCO8QMaGNEiBfiys= From: David Gibson To: pasic@linux.ibm.com, dgilbert@redhat.com, pair@us.ibm.com, qemu-devel@nongnu.org, brijesh.singh@amd.com Subject: [PULL v9 12/13] confidential guest support: Alter virtio default properties for protected guests Date: Mon, 8 Feb 2021 17:05:37 +1100 Message-Id: <20210208060538.39276-13-david@gibson.dropbear.id.au> X-Mailer: git-send-email 2.29.2 In-Reply-To: <20210208060538.39276-1-david@gibson.dropbear.id.au> References: <20210208060538.39276-1-david@gibson.dropbear.id.au> MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Received-SPF: pass client-ip=2401:3900:2:1::2; envelope-from=dgibson@ozlabs.org; helo=ozlabs.org X-Spam_score_int: -17 X-Spam_score: -1.8 X-Spam_bar: - X-Spam_report: (-1.8 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, HEADER_FROM_DIFFERENT_DOMAINS=0.248, SPF_HELO_PASS=-0.001, SPF_PASS=-0.001 autolearn=no autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Thomas Huth , cohuck@redhat.com, =?UTF-8?q?Daniel=20P=2E=20Berrang=C3=A9?= , ehabkost@redhat.com, kvm@vger.kernel.org, mst@redhat.com, mtosatti@redhat.com, Richard Henderson , mdroth@linux.vnet.ibm.com, borntraeger@de.ibm.com, qemu-s390x@nongnu.org, Greg Kurz , qemu-ppc@nongnu.org, pragyansri.pathi@intel.com, jun.nakajima@intel.com, andi.kleen@intel.com, pbonzini@redhat.com, David Hildenbrand , David Gibson , frankja@linux.ibm.com Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: "Qemu-devel" X-ZohoMail-DKIM: fail (Header signature does not verify) Content-Type: text/plain; charset="utf-8" The default behaviour for virtio devices is not to use the platforms normal DMA paths, but instead to use the fact that it's running in a hypervisor to directly access guest memory. That doesn't work if the guest's memory is protected from hypervisor access, such as with AMD's SEV or POWER's PEF. So, if a confidential guest mechanism is enabled, then apply the iommu_platform=3Don option so it will go through normal DMA mechanisms. Those will presumably have some way of marking memory as shared with the hypervisor or hardware so that DMA will work. Signed-off-by: David Gibson Reviewed-by: Dr. David Alan Gilbert Reviewed-by: Cornelia Huck Reviewed-by: Greg Kurz --- hw/core/machine.c | 13 +++++++++++++ 1 file changed, 13 insertions(+) diff --git a/hw/core/machine.c b/hw/core/machine.c index f45a795478..970046f438 100644 --- a/hw/core/machine.c +++ b/hw/core/machine.c @@ -33,6 +33,8 @@ #include "migration/global_state.h" #include "migration/vmstate.h" #include "exec/confidential-guest-support.h" +#include "hw/virtio/virtio.h" +#include "hw/virtio/virtio-pci.h" =20 GlobalProperty hw_compat_5_2[] =3D {}; const size_t hw_compat_5_2_len =3D G_N_ELEMENTS(hw_compat_5_2); @@ -1196,6 +1198,17 @@ void machine_run_board_init(MachineState *machine) * areas. */ machine_set_mem_merge(OBJECT(machine), false, &error_abort); + + /* + * Virtio devices can't count on directly accessing guest + * memory, so they need iommu_platform=3Don to use normal DMA + * mechanisms. That requires also disabling legacy virtio + * support for those virtio pci devices which allow it. + */ + object_register_sugar_prop(TYPE_VIRTIO_PCI, "disable-legacy", + "on", true); + object_register_sugar_prop(TYPE_VIRTIO_DEVICE, "iommu_platform", + "on", false); } =20 machine_class->init(machine); --=20 2.29.2