From nobody Tue Nov 18 21:13:47 2025 Delivered-To: importer@patchew.org Received-SPF: pass (zohomail.com: domain of _spf.google.com designates 209.85.128.42 as permitted sender) client-ip=209.85.128.42; envelope-from=philippe.mathieu.daude@gmail.com; helo=mail-wm1-f42.google.com; Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of _spf.google.com designates 209.85.128.42 as permitted sender) smtp.mailfrom=philippe.mathieu.daude@gmail.com ARC-Seal: i=1; a=rsa-sha256; t=1612740216; cv=none; d=zohomail.com; s=zohoarc; b=REIhZx8lb+ZuWlAAjAPara6IeJM2gUJt+wIFXdVf34q5PFaCy+tIASliaGYhJm89iQdDooYa0mJQwIb86Fi5QFL6VP2r+3FmG0ND+7PMTjf+QGSib9zfFpLj/UQDTUh/zfUdQ7sBn4vo6FrPWJ5ycYPwY1reyEffc1HIbhcWmzo= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1612740216; h=Content-Type:Content-Transfer-Encoding:Cc:Date:From:In-Reply-To:MIME-Version:Message-ID:References:Sender:Subject:To; bh=9gknr3qlLHrPVofS5zv6p1SYehluW78knvLtOubYhBs=; b=Y0IcykiBjIi1ck+6kyoojvV5rLXC5N51IB47mliJJE87kea+cc20nDJOx6CaDfzNtPuaoVPnMs2IPKYyLynvsKSIegXNWlTK/iaNak3QJjZNN4YzrWAJnoJiDlUpwoXEU+gjsBKQ1gEyXKRGNSshwGQyj1FBlMTPHz10aQkiUME= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of _spf.google.com designates 209.85.128.42 as permitted sender) smtp.mailfrom=philippe.mathieu.daude@gmail.com Received: from mail-wm1-f42.google.com (mail-wm1-f42.google.com [209.85.128.42]) by mx.zohomail.com with SMTPS id 1612740216342941.1886930169368; Sun, 7 Feb 2021 15:23:36 -0800 (PST) Received: by mail-wm1-f42.google.com with SMTP id j11so11147841wmi.3 for ; Sun, 07 Feb 2021 15:23:35 -0800 (PST) Return-Path: Return-Path: Received: from localhost.localdomain (68.red-83-57-175.dynamicip.rima-tde.net. [83.57.175.68]) by smtp.gmail.com with ESMTPSA id e10sm24315162wro.65.2021.02.07.15.23.33 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sun, 07 Feb 2021 15:23:33 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=sender:from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=9gknr3qlLHrPVofS5zv6p1SYehluW78knvLtOubYhBs=; b=K1AaafdYfn0sBrm+KdYQJAGu13yoJyk/44KneP29aXMPf/9RL7wbXwv7enDMeXR8tG /XuGjf+uAIKFmqwYv7PpvhzNyH4LmfOlux/5XFu6+tDrz1e7uvByNMY4StPMoRM6yC7+ 0evGxHJPAXFHJdP0jUM3wtH9MvFFUulsPJFi5AsAaUe3q2xEcYVtcqXbU/c/nS/sG3HY x5hGdI4HSEtrBnwHNAvHwVPQAa80SRIKMwLDxuaWfIk/of/Z25GE5ExlWUaf/jGIy89j TE2M2PqdEWRCWK8lqc5fmIWpB/Mcy9MKv1QtHsZlClyoziZspXHVZ5f9QUgCkYrvKJr7 r2Iw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:sender:from:to:cc:subject:date:message-id :in-reply-to:references:mime-version:content-transfer-encoding; bh=9gknr3qlLHrPVofS5zv6p1SYehluW78knvLtOubYhBs=; b=UttPPEKCxdX4ETWxF+iDVW93tDeIMJ0TLRcoQmvQKUuKtExXA1xgtre9n0FUJSe30v cgzbd7gn5Y4ZhFy5C7gD36DOHzQukoNxMf+zmeJwRVg+xvQLFOGUR5WWNdTnku7nwfEt Nnr8LnLE6pxeg9Y4eLE6uePhNy4CNjQNX0m2xySs5uR+MylrChgbUAD+WqNlu78F+4QG 4p0nLAZcXjO2Di6eQ6BaU3t7CHPGj1thfgD1L2l5YUQScwWLVrT8YbkN9bq+tluLLdpv fyIUdX1xSqB0iClOckV0OsIIQkcW19djTMDNkFPDqq3OiqTX1RCJM2l3Iv/r/9wxbr4U W+zw== X-Gm-Message-State: AOAM530VFc1wsHg/j+qV2TVjxGCVTod96qvKC3OxGQ6W55Wguf1Nwz2X uvFrRCXpm5/jM0PmbE4EhxI= X-Google-Smtp-Source: ABdhPJxC60ACe0vE/X8upoWTKt/bY8N5fxgL8wrEih7fHr44FtHzW3qjMJzC63oI76VmJSIKv+s0fQ== X-Received: by 2002:a1c:6308:: with SMTP id x8mr12528249wmb.78.1612740214536; Sun, 07 Feb 2021 15:23:34 -0800 (PST) Sender: =?UTF-8?Q?Philippe_Mathieu=2DDaud=C3=A9?= From: =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= To: qemu-devel@nongnu.org Cc: Bastian Koppelmann , =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= , Yoshinori Sato , Paolo Bonzini , Aurelien Jarno , Sagar Karandikar , Palmer Dabbelt , Laurent Vivier , qemu-arm@nongnu.org, Claudio Fontana , Peter Maydell , Richard Henderson , Alistair Francis , Jiaxun Yang , Aleksandar Rikalo , qemu-riscv@nongnu.org Subject: [PATCH v2 4/6] accel/tcg: Include missing "tcg/tcg.h" header Date: Mon, 8 Feb 2021 00:23:08 +0100 Message-Id: <20210207232310.2505283-5-f4bug@amsat.org> X-Mailer: git-send-email 2.26.2 In-Reply-To: <20210207232310.2505283-1-f4bug@amsat.org> References: <20210207232310.2505283-1-f4bug@amsat.org> MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable X-ZohoMail-DKIM: pass (identity @gmail.com) Commit 3468b59e18b ("tcg: enable multiple TCG contexts in softmmu") introduced use of typedef/prototypes declared in "tcg/tcg.h" without including it. This was not a problem because "tcg/tcg.h" is pulled in by "exec/cpu_ldst.h". To be able to remove this header there, we first need to include it here in op_helper.c, else we get: accel/tcg/tcg-accel-ops-mttcg.c: In function =E2=80=98mttcg_cpu_thread_fn= =E2=80=99: accel/tcg/tcg-accel-ops-mttcg.c:52:5: error: implicit declaration of func= tion =E2=80=98tcg_register_thread=E2=80=99; did you mean =E2=80=98rcu_regis= ter_thread=E2=80=99? [-Werror=3Dimplicit-function-declaration] 52 | tcg_register_thread(); | ^~~~~~~~~~~~~~~~~~~ | rcu_register_thread accel/tcg/tcg-accel-ops-mttcg.c:52:5: error: nested extern declaration of= =E2=80=98tcg_register_thread=E2=80=99 [-Werror=3Dnested-externs] cc1: all warnings being treated as errors accel/tcg/tcg-accel-ops-rr.c: In function =E2=80=98rr_cpu_thread_fn=E2=80= =99: accel/tcg/tcg-accel-ops-rr.c:153:5: error: implicit declaration of functi= on =E2=80=98tcg_register_thread=E2=80=99; did you mean =E2=80=98rcu_registe= r_thread=E2=80=99? [-Werror=3Dimplicit-function-declaration] 153 | tcg_register_thread(); | ^~~~~~~~~~~~~~~~~~~ | rcu_register_thread accel/tcg/tcg-accel-ops-rr.c:153:5: error: nested extern declaration of = =E2=80=98tcg_register_thread=E2=80=99 [-Werror=3Dnested-externs] cc1: all warnings being treated as errors Signed-off-by: Philippe Mathieu-Daud=C3=A9 Reviewed-by: Alex Benn=C3=A9e --- accel/tcg/tcg-accel-ops-mttcg.c | 1 + accel/tcg/tcg-accel-ops-rr.c | 1 + 2 files changed, 2 insertions(+) diff --git a/accel/tcg/tcg-accel-ops-mttcg.c b/accel/tcg/tcg-accel-ops-mttc= g.c index 42973fb062b..ddbca6c5b8c 100644 --- a/accel/tcg/tcg-accel-ops-mttcg.c +++ b/accel/tcg/tcg-accel-ops-mttcg.c @@ -32,6 +32,7 @@ #include "exec/exec-all.h" #include "hw/boards.h" =20 +#include "tcg/tcg.h" #include "tcg-accel-ops.h" #include "tcg-accel-ops-mttcg.h" =20 diff --git a/accel/tcg/tcg-accel-ops-rr.c b/accel/tcg/tcg-accel-ops-rr.c index 4a66055e0d7..1bb1d0f8f1c 100644 --- a/accel/tcg/tcg-accel-ops-rr.c +++ b/accel/tcg/tcg-accel-ops-rr.c @@ -32,6 +32,7 @@ #include "exec/exec-all.h" #include "hw/boards.h" =20 +#include "tcg/tcg.h" #include "tcg-accel-ops.h" #include "tcg-accel-ops-rr.h" #include "tcg-accel-ops-icount.h" --=20 2.26.2