From nobody Tue Nov 18 21:13:47 2025 Delivered-To: importer@patchew.org Received-SPF: pass (zohomail.com: domain of _spf.google.com designates 209.85.221.44 as permitted sender) client-ip=209.85.221.44; envelope-from=philippe.mathieu.daude@gmail.com; helo=mail-wr1-f44.google.com; Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of _spf.google.com designates 209.85.221.44 as permitted sender) smtp.mailfrom=philippe.mathieu.daude@gmail.com; dmarc=fail(p=none dis=none) header.from=amsat.org ARC-Seal: i=1; a=rsa-sha256; t=1612740211; cv=none; d=zohomail.com; s=zohoarc; b=ALFnmmKprI3EUjCkaHu3ZMqLMthUxaf3B/Z5iXeTuiLFPbmhBA+2wnPQRezZ6CRFfGugvIDA/O1ERDipkK3xdZUnDWXuk+Y1IXNwhJz+j5D2Ghp9RUcPBL2aFBO8udnYAQQBPJV2JOld1s+uVaWlmEx/JQ1+xiNtrsmhmoMV5ZQ= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1612740211; h=Content-Type:Content-Transfer-Encoding:Cc:Date:From:In-Reply-To:MIME-Version:Message-ID:References:Sender:Subject:To; bh=NB0PxeiyUnyh7a2jT9hNZ8p231d4tVFomh4sbxGsRA8=; b=HT2e97ZLu+PF7zqPUw5U8S6EwG38xh3VGlVpVfHJ8VaRHCS8UdBORGA19N0igTldXmb+2DNk7DrwYG0J9sMK3JXG2jAu9j5dNR4MbK5Nb0imGRLwmqjsLOiOtN40p/B6gGTRrW9MdVxcM8GVj+SKO+cL2uQbWMvnTC97DoOblY0= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of _spf.google.com designates 209.85.221.44 as permitted sender) smtp.mailfrom=philippe.mathieu.daude@gmail.com; dmarc=fail header.from= (p=none dis=none) header.from= Received: from mail-wr1-f44.google.com (mail-wr1-f44.google.com [209.85.221.44]) by mx.zohomail.com with SMTPS id 1612740211044366.8486783458669; Sun, 7 Feb 2021 15:23:31 -0800 (PST) Received: by mail-wr1-f44.google.com with SMTP id v15so15128991wrx.4 for ; Sun, 07 Feb 2021 15:23:30 -0800 (PST) Return-Path: Return-Path: Received: from localhost.localdomain (68.red-83-57-175.dynamicip.rima-tde.net. [83.57.175.68]) by smtp.gmail.com with ESMTPSA id z15sm23614358wrt.8.2021.02.07.15.23.27 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sun, 07 Feb 2021 15:23:28 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=sender:from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=NB0PxeiyUnyh7a2jT9hNZ8p231d4tVFomh4sbxGsRA8=; b=H6dm/1g2ElXpRCdyGyvOLm4dKRdC6BeKWByg/dXiUz0knV2bgWzJd3p7kpSMk48iUj n0YgH4Mi06hj9k34E/GnUesKNDs2zXLHIY2a403RiqM/29KiHeHOfIrt7Eru9EIavz8F 2vBeGt9jCLeMEBHZtC9XBCbJBitHKeb8N2hdWhxlTB3LdatBjksFWjR3jwVSgVbGyGTc +GUX9kmB+ZzY9XmyyCjpzeQYAtrvw/3diNFHUWKzGwOAlYQ0Pvx80vzkjfMiY0C5FY+2 sBWm1dY2uowJxUj2hcDyp1SbD1RLCBzO+u5ylJ5C8VsTboAptYR0Gq9PQYentVq26HUp vlkQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:sender:from:to:cc:subject:date:message-id :in-reply-to:references:mime-version:content-transfer-encoding; bh=NB0PxeiyUnyh7a2jT9hNZ8p231d4tVFomh4sbxGsRA8=; b=hclzt/p2J5AkQF2VgAq4Hb1Jkb2lTZaJ9LFw73zoCJr9iucyeZZMb7l35j38ScPAwg j0lkfnPm1Rq3EzUg1PguEuZ9yniSBwyUSTTTMVkfQLLpbA+4POvRe2cN5lqTEBeyisSc IVoVbOJt71nSYj5ozUzl1NTBbryMjKFPhH03J3B2/yA1NfmWDPm+l49zU7KtDwTM8k3n eKCZonubkEDQOfiD8uVTCYgcBoSj9RbneiE5XXuN1UOK+0l/Rfu3VlhplXY23O9MNUEz OqEIc7jzNAHdGoNGitu9Dh2OkyR5Go6JYnbvSmoxsX90JzCggs4K09R46J+G8166fVzy ieJQ== X-Gm-Message-State: AOAM530k02YUP2laPTOemrDHgDB1ORtwiqcdDPI5cRBFmAaSAnyG6mqC eZBRrMQL/e/fKOIoxEC6sns= X-Google-Smtp-Source: ABdhPJyQhz82BwQ8fi6Ee/12u4Dqp9KXCyb8ZlEgT+XV6b8wbWh5emTcY+vdGvd0IVs3IxxcaNbqow== X-Received: by 2002:a5d:4292:: with SMTP id k18mr17223984wrq.218.1612740209256; Sun, 07 Feb 2021 15:23:29 -0800 (PST) Sender: =?UTF-8?Q?Philippe_Mathieu=2DDaud=C3=A9?= From: =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= To: qemu-devel@nongnu.org Cc: Bastian Koppelmann , =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= , Yoshinori Sato , Paolo Bonzini , Aurelien Jarno , Sagar Karandikar , Palmer Dabbelt , Laurent Vivier , qemu-arm@nongnu.org, Claudio Fontana , Peter Maydell , Richard Henderson , Alistair Francis , Jiaxun Yang , Aleksandar Rikalo , qemu-riscv@nongnu.org Subject: [PATCH v2 3/6] target/mips: Include missing "tcg/tcg.h" header Date: Mon, 8 Feb 2021 00:23:07 +0100 Message-Id: <20210207232310.2505283-4-f4bug@amsat.org> X-Mailer: git-send-email 2.26.2 In-Reply-To: <20210207232310.2505283-1-f4bug@amsat.org> References: <20210207232310.2505283-1-f4bug@amsat.org> MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable X-ZohoMail-DKIM: pass (identity @gmail.com) Commit 83be6b54123 ("Fix MSA instructions LD. on big endian host") introduced use of typedef/prototypes declared in "tcg/tcg.h" without including it. This was not a problem because "tcg/tcg.h" is pulled in by "exec/cpu_ldst.h". To be able to remove this header there, we first need to include it here in op_helper.c, else we get: [222/337] Compiling C object libqemu-mips-softmmu.fa.p/target_mips_msa_he= lper.c.o target/mips/msa_helper.c: In function =E2=80=98helper_msa_ld_b=E2=80=99: target/mips/msa_helper.c:8214:9: error: unknown type name =E2=80=98TCGMem= OpIdx=E2=80=99 8214 | TCGMemOpIdx oi =3D make_memop_idx(MO_TE | DF | MO_UNALN, = \ | ^~~~~~~~~~~ target/mips/msa_helper.c:8224:5: note: in expansion of macro =E2=80=98MEM= OP_IDX=E2=80=99 8224 | MEMOP_IDX(DF_BYTE) | ^~~~~~~~~ target/mips/msa_helper.c:8214:26: error: implicit declaration of function= =E2=80=98make_memop_idx=E2=80=99 [-Werror=3Dimplicit-function-declaration] 8214 | TCGMemOpIdx oi =3D make_memop_idx(MO_TE | DF | MO_UNALN, = \ | ^~~~~~~~~~~~~~ target/mips/msa_helper.c:8227:18: error: implicit declaration of function= =E2=80=98helper_ret_ldub_mmu=E2=80=99 [-Werror=3Dimplicit-function-declara= tion] 8227 | pwd->b[0] =3D helper_ret_ldub_mmu(env, addr + (0 << DF_BYTE= ), oi, GETPC()); | ^~~~~~~~~~~~~~~~~~~ cc1: all warnings being treated as errors Signed-off-by: Philippe Mathieu-Daud=C3=A9 --- target/mips/msa_helper.c | 1 + 1 file changed, 1 insertion(+) diff --git a/target/mips/msa_helper.c b/target/mips/msa_helper.c index 1298a1917ce..4caefe29ad7 100644 --- a/target/mips/msa_helper.c +++ b/target/mips/msa_helper.c @@ -20,6 +20,7 @@ #include "qemu/osdep.h" #include "cpu.h" #include "internal.h" +#include "tcg/tcg.h" #include "exec/exec-all.h" #include "exec/helper-proto.h" #include "exec/memop.h" --=20 2.26.2