From nobody Tue Nov 18 21:13:47 2025 Delivered-To: importer@patchew.org Received-SPF: pass (zohomail.com: domain of _spf.google.com designates 209.85.221.43 as permitted sender) client-ip=209.85.221.43; envelope-from=philippe.mathieu.daude@gmail.com; helo=mail-wr1-f43.google.com; Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of _spf.google.com designates 209.85.221.43 as permitted sender) smtp.mailfrom=philippe.mathieu.daude@gmail.com ARC-Seal: i=1; a=rsa-sha256; t=1612740205; cv=none; d=zohomail.com; s=zohoarc; b=c1HavxR8NEHWeDgcgHEssx9YHouE81E1sE/auoc0E4Tx7bdHQ0Cq0Gj5LGpmUUlRzsyZwqYfdYrIXEQi/aSvdwuRIe4Du02ssFV/cP/AT/Yn2wIfgmEVen8OQVIxlIJz9FEn6qfcRk7A9b1/+GvAAP2Sn6MtBiM6q2Ur2g5O5mc= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1612740205; h=Content-Type:Content-Transfer-Encoding:Cc:Date:From:In-Reply-To:MIME-Version:Message-ID:References:Sender:Subject:To; bh=H7DdpVZKuaTFU+QINWMbbbomeFKhPW3S4eDxwf+nJCo=; b=kjA+WpoCzpSeLGbn80yhFg1RS8eGj4fYnS5qNAB3gO0FVBdqIyUKUZwAOz4fYaRskZDStBiSytWJXF5HQCK/+uO4TQ4ceXxUxEXcJPLzq85bj5PGIc7r9JBl7x7l7Ka+YtP2lQ1eChWW8sshamB8XOvm8tbMJcCT4fA2FHVnOn0= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of _spf.google.com designates 209.85.221.43 as permitted sender) smtp.mailfrom=philippe.mathieu.daude@gmail.com Received: from mail-wr1-f43.google.com (mail-wr1-f43.google.com [209.85.221.43]) by mx.zohomail.com with SMTPS id 1612740205649627.5984429533822; Sun, 7 Feb 2021 15:23:25 -0800 (PST) Received: by mail-wr1-f43.google.com with SMTP id g10so15171193wrx.1 for ; Sun, 07 Feb 2021 15:23:25 -0800 (PST) Return-Path: Return-Path: Received: from localhost.localdomain (68.red-83-57-175.dynamicip.rima-tde.net. [83.57.175.68]) by smtp.gmail.com with ESMTPSA id l1sm25605825wrp.40.2021.02.07.15.23.22 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sun, 07 Feb 2021 15:23:23 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=sender:from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=H7DdpVZKuaTFU+QINWMbbbomeFKhPW3S4eDxwf+nJCo=; b=Cbe0/5QwUe4ZyDD3MCWKIRYwfN9+3L6rNnWC2TOjH7OXHTThDg2a1ZbJVNQ3Kzf3st En6PUVBxAp4PxuocUpThjh2BUbXwmj4TsUAq7zyP/wF/zcmEyBp7UsQy6xsrBppchqPb xaKn+OA362o9B5Pfn+32MFxsnEaxvQmoexp0yQS5CrniIOSwJ9UVILT4OQ0YV+l4a8zb UIDtHmQtVDPxPhHTOfcOKsjj00ADyCFI+YiUb6EKu47ho7vr5MjQQly8zmSOk2hxHeGo q0CgRJRIbHzG8ADxnWIbKDypHAzL8Wkz7WT/WiLYiSMgUGkKHqucN8bPsg5DIZX6MVT3 KL2w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:sender:from:to:cc:subject:date:message-id :in-reply-to:references:mime-version:content-transfer-encoding; bh=H7DdpVZKuaTFU+QINWMbbbomeFKhPW3S4eDxwf+nJCo=; b=RIgCT7EXbu3/L9GLbdt6S3fUyC/0TFJNe02EajPA2t8rJeECuLwC1RPzkI6629jjMK U1HBOtGXSz3Di6bDYoArlH+o3s7UH4DAEcQM+/QKj8RLlHkrxOKl77KeCf3Vjx4azNF1 7gXPW9iM2iQGWEhfLPZmKmapHom/RbUe+tiEZ/ummMxz8ZonFQMIooR5HqHx2s+X2uXk k2e/gJkMp00tHDBNQnijzdlcyKbOv/RtDTfhcv9lkgY6gU7Z6ToyiDuw3guMTzKQlI1r wcnhKPtQ+Ofsk1/7pu5csZiZne9N3xOuEsfPD/h3AURPuNEnRGup5u7gfeqepHmR4P7t +vgA== X-Gm-Message-State: AOAM530VrD/y8Ds4BmRoHHdmwJd6MGH7B6HwfpFll3rQ7ofVfd/hOta7 Ot4JnIXQD0qpNeyoYNg7Qro= X-Google-Smtp-Source: ABdhPJyWiUk4XoFKg97EVROdcEEDZ3GQAVdpr0UYoBXaLXyG4LroE1FRPhHK/244ObpYQu6Z9zgkqw== X-Received: by 2002:a5d:5283:: with SMTP id c3mr16559778wrv.319.1612740203868; Sun, 07 Feb 2021 15:23:23 -0800 (PST) Sender: =?UTF-8?Q?Philippe_Mathieu=2DDaud=C3=A9?= From: =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= To: qemu-devel@nongnu.org Cc: Bastian Koppelmann , =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= , Yoshinori Sato , Paolo Bonzini , Aurelien Jarno , Sagar Karandikar , Palmer Dabbelt , Laurent Vivier , qemu-arm@nongnu.org, Claudio Fontana , Peter Maydell , Richard Henderson , Alistair Francis , Jiaxun Yang , Aleksandar Rikalo , qemu-riscv@nongnu.org Subject: [PATCH v2 2/6] target/m68k: Include missing "tcg/tcg.h" header Date: Mon, 8 Feb 2021 00:23:06 +0100 Message-Id: <20210207232310.2505283-3-f4bug@amsat.org> X-Mailer: git-send-email 2.26.2 In-Reply-To: <20210207232310.2505283-1-f4bug@amsat.org> References: <20210207232310.2505283-1-f4bug@amsat.org> MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable X-ZohoMail-DKIM: pass (identity @gmail.com) Commit 14f944063af ("target-m68k: add cas/cas2 ops") introduced use of typedef/prototypes declared in "tcg/tcg.h" without including it. This was not a problem because "tcg/tcg.h" is pulled in by "exec/cpu_ldst.h". To be able to remove this header there, we first need to include it here in op_helper.c, else we get: [953/1018] Compiling C object libqemu-m68k-softmmu.fa.p/target_m68k_op_he= lper.c.o target/m68k/op_helper.c: In function =E2=80=98do_cas2l=E2=80=99: target/m68k/op_helper.c:774:5: error: unknown type name =E2=80=98TCGMemOp= Idx=E2=80=99 774 | TCGMemOpIdx oi; | ^~~~~~~~~~~ target/m68k/op_helper.c:787:18: error: implicit declaration of function = =E2=80=98make_memop_idx=E2=80=99 [-Werror=3Dimplicit-function-declaration] 787 | oi =3D make_memop_idx(MO_BEQ, mmu_idx); | ^~~~~~~~~~~~~~ target/m68k/op_helper.c:787:18: error: nested extern declaration of =E2= =80=98make_memop_idx=E2=80=99 [-Werror=3Dnested-externs] target/m68k/op_helper.c:788:17: error: implicit declaration of function = =E2=80=98helper_atomic_cmpxchgq_be_mmu=E2=80=99; did you mean =E2=80=98help= er_atomic_cmpxchgq_be=E2=80=99? [-Werror=3Dimplicit-function-declaration] 788 | l =3D helper_atomic_cmpxchgq_be_mmu(env, a1, c, u, oi= , ra); | ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~ | helper_atomic_cmpxchgq_be target/m68k/op_helper.c:788:17: error: nested extern declaration of =E2= =80=98helper_atomic_cmpxchgq_be_mmu=E2=80=99 [-Werror=3Dnested-externs] cc1: all warnings being treated as errors Signed-off-by: Philippe Mathieu-Daud=C3=A9 --- target/m68k/op_helper.c | 1 + 1 file changed, 1 insertion(+) diff --git a/target/m68k/op_helper.c b/target/m68k/op_helper.c index 202498deb51..36b68fd318f 100644 --- a/target/m68k/op_helper.c +++ b/target/m68k/op_helper.c @@ -18,6 +18,7 @@ */ #include "qemu/osdep.h" #include "cpu.h" +#include "tcg/tcg.h" #include "exec/helper-proto.h" #include "exec/exec-all.h" #include "exec/cpu_ldst.h" --=20 2.26.2