From nobody Tue Nov 18 21:15:25 2025 Delivered-To: importer@patchew.org Received-SPF: pass (zohomail.com: domain of _spf.google.com designates 209.85.221.46 as permitted sender) client-ip=209.85.221.46; envelope-from=philippe.mathieu.daude@gmail.com; helo=mail-wr1-f46.google.com; Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of _spf.google.com designates 209.85.221.46 as permitted sender) smtp.mailfrom=philippe.mathieu.daude@gmail.com ARC-Seal: i=1; a=rsa-sha256; t=1612738684; cv=none; d=zohomail.com; s=zohoarc; b=PwfuliXfBTngyZBgImrJXWzWKxDhfXQ5n3gVvcD03LULjhts9vVxoGCI30VO5M/5dHcZRNAkurzhbaDyxJ+iKhSlrDVHvIFlsQXRQahYOtZWeZpIfwaEvkkhgNS41E3zWOM3dTaM9xZRBjnBxWjQZnBsEdVZEtziC47E1eDTwss= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1612738684; h=Content-Type:Content-Transfer-Encoding:Cc:Date:From:In-Reply-To:MIME-Version:Message-ID:References:Sender:Subject:To; bh=9gknr3qlLHrPVofS5zv6p1SYehluW78knvLtOubYhBs=; b=VvPpDpb1HiSeJj+LpSZYTxncstdsJDQDeocgKR2nZQVdhQpDeulf7ZqHgqGC8TP7R9MCX/1BlU5Pq+Pz2NEK5ZhR/5wfmIbzN1tZRtx3OS/EmdLC3bvjV/D668fieUco63v0BawUcYCXw+zLDdmfGZpfnha0R6i3ilE9TV83/R0= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of _spf.google.com designates 209.85.221.46 as permitted sender) smtp.mailfrom=philippe.mathieu.daude@gmail.com Received: from mail-wr1-f46.google.com (mail-wr1-f46.google.com [209.85.221.46]) by mx.zohomail.com with SMTPS id 1612738684280980.6756838997968; Sun, 7 Feb 2021 14:58:04 -0800 (PST) Received: by mail-wr1-f46.google.com with SMTP id q7so15023184wre.13 for ; Sun, 07 Feb 2021 14:58:03 -0800 (PST) Return-Path: Return-Path: Received: from localhost.localdomain (68.red-83-57-175.dynamicip.rima-tde.net. [83.57.175.68]) by smtp.gmail.com with ESMTPSA id z4sm24488281wrw.38.2021.02.07.14.58.01 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sun, 07 Feb 2021 14:58:01 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=sender:from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=9gknr3qlLHrPVofS5zv6p1SYehluW78knvLtOubYhBs=; b=QPiUsnBXh6zQA8cvIUf9ti97QrSwqi3bDBEnuY07Vz4fILCRyGjOwtnK45kK464dio 5WPadZImBIr6aw0k5vyV2uxqYyLHPOjixZqCz0vPdEbSAlDrWHBk2FbdYxS7MSjbbTtY LbN4tD7GhzEeQKmyOx3+luv7KS33p5yTjoXR2f5V7BC/WPbyi2AlqOJj0mDZVbZxIMYo GzFaodM5Tae7XL4Q2MlxhUh6WLujp9P5Py0gpaRn2H/R+GJQYrRkc6iNooaSges3oLKW jpVdP4BbjkgLrJmJoB1qHno80cPvPoOSb3thRC3FrbOnwGT6+wNG4fll+jgztTGlEdTs 16Vg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:sender:from:to:cc:subject:date:message-id :in-reply-to:references:mime-version:content-transfer-encoding; bh=9gknr3qlLHrPVofS5zv6p1SYehluW78knvLtOubYhBs=; b=Q3nLbcsW1U9u/CSMVg0TJVE9ZnmTVTwQnxxqvp2UiwtwoobUe8ANB5DupuEAD+7X5+ kY/SzEY/5/gkFvE2wP6CsnQtfySYLvDwxyYvTpTUf2KKNtJfUrzOXavGXXrkgjYXzybf FgOPM8kWu64KYX6eXbgg+1sZ51A6tqpEgUI1eM3f3H6uqw5h23BVh90bmCHd2CWgvClh jJmrok6Ay0tUKkcFl2yU3l+a0YE1jvefKTnSmJteBe6N+Vke7aEcFIZ7wpSGj83WOXCW kLzyoa0remig2jOJ3mzMCUHpyAnspylCnYtEu0RNwZjYXHrcAdxFQz/pN+sbeWJkvuXg x2Vw== X-Gm-Message-State: AOAM53282WZCUkWypBbgO2WTu5win/N26EX9eZbh5SHz0rMJTGP3cYN/ V4EXknfh31f9Lxs8DfjZ2+k= X-Google-Smtp-Source: ABdhPJwmtUdPun0LfupoJgX97gEgxC4Lsu0OtQsJR7cY6J+fqgd3HrNrCOxT9sTkn64oSwfDnHymeg== X-Received: by 2002:a5d:6a02:: with SMTP id m2mr17045630wru.364.1612738682431; Sun, 07 Feb 2021 14:58:02 -0800 (PST) Sender: =?UTF-8?Q?Philippe_Mathieu=2DDaud=C3=A9?= From: =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= To: qemu-devel@nongnu.org Cc: Palmer Dabbelt , Bastian Koppelmann , Peter Maydell , Claudio Fontana , Paolo Bonzini , Yoshinori Sato , Aleksandar Rikalo , qemu-arm@nongnu.org, Aurelien Jarno , qemu-riscv@nongnu.org, Laurent Vivier , =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= , Richard Henderson , Alistair Francis , Sagar Karandikar , Jiaxun Yang Subject: [PATCH 4/6] accel/tcg: Include missing "tcg/tcg.h" header Date: Sun, 7 Feb 2021 23:57:36 +0100 Message-Id: <20210207225738.2482987-5-f4bug@amsat.org> X-Mailer: git-send-email 2.26.2 In-Reply-To: <20210207225738.2482987-1-f4bug@amsat.org> References: <20210207225738.2482987-1-f4bug@amsat.org> MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable X-ZohoMail-DKIM: pass (identity @gmail.com) Commit 3468b59e18b ("tcg: enable multiple TCG contexts in softmmu") introduced use of typedef/prototypes declared in "tcg/tcg.h" without including it. This was not a problem because "tcg/tcg.h" is pulled in by "exec/cpu_ldst.h". To be able to remove this header there, we first need to include it here in op_helper.c, else we get: accel/tcg/tcg-accel-ops-mttcg.c: In function =E2=80=98mttcg_cpu_thread_fn= =E2=80=99: accel/tcg/tcg-accel-ops-mttcg.c:52:5: error: implicit declaration of func= tion =E2=80=98tcg_register_thread=E2=80=99; did you mean =E2=80=98rcu_regis= ter_thread=E2=80=99? [-Werror=3Dimplicit-function-declaration] 52 | tcg_register_thread(); | ^~~~~~~~~~~~~~~~~~~ | rcu_register_thread accel/tcg/tcg-accel-ops-mttcg.c:52:5: error: nested extern declaration of= =E2=80=98tcg_register_thread=E2=80=99 [-Werror=3Dnested-externs] cc1: all warnings being treated as errors accel/tcg/tcg-accel-ops-rr.c: In function =E2=80=98rr_cpu_thread_fn=E2=80= =99: accel/tcg/tcg-accel-ops-rr.c:153:5: error: implicit declaration of functi= on =E2=80=98tcg_register_thread=E2=80=99; did you mean =E2=80=98rcu_registe= r_thread=E2=80=99? [-Werror=3Dimplicit-function-declaration] 153 | tcg_register_thread(); | ^~~~~~~~~~~~~~~~~~~ | rcu_register_thread accel/tcg/tcg-accel-ops-rr.c:153:5: error: nested extern declaration of = =E2=80=98tcg_register_thread=E2=80=99 [-Werror=3Dnested-externs] cc1: all warnings being treated as errors Signed-off-by: Philippe Mathieu-Daud=C3=A9 --- accel/tcg/tcg-accel-ops-mttcg.c | 1 + accel/tcg/tcg-accel-ops-rr.c | 1 + 2 files changed, 2 insertions(+) diff --git a/accel/tcg/tcg-accel-ops-mttcg.c b/accel/tcg/tcg-accel-ops-mttc= g.c index 42973fb062b..ddbca6c5b8c 100644 --- a/accel/tcg/tcg-accel-ops-mttcg.c +++ b/accel/tcg/tcg-accel-ops-mttcg.c @@ -32,6 +32,7 @@ #include "exec/exec-all.h" #include "hw/boards.h" =20 +#include "tcg/tcg.h" #include "tcg-accel-ops.h" #include "tcg-accel-ops-mttcg.h" =20 diff --git a/accel/tcg/tcg-accel-ops-rr.c b/accel/tcg/tcg-accel-ops-rr.c index 4a66055e0d7..1bb1d0f8f1c 100644 --- a/accel/tcg/tcg-accel-ops-rr.c +++ b/accel/tcg/tcg-accel-ops-rr.c @@ -32,6 +32,7 @@ #include "exec/exec-all.h" #include "hw/boards.h" =20 +#include "tcg/tcg.h" #include "tcg-accel-ops.h" #include "tcg-accel-ops-rr.h" #include "tcg-accel-ops-icount.h" --=20 2.26.2