From nobody Tue Nov 18 21:15:26 2025 Delivered-To: importer@patchew.org Received-SPF: pass (zohomail.com: domain of _spf.google.com designates 209.85.128.53 as permitted sender) client-ip=209.85.128.53; envelope-from=philippe.mathieu.daude@gmail.com; helo=mail-wm1-f53.google.com; Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of _spf.google.com designates 209.85.128.53 as permitted sender) smtp.mailfrom=philippe.mathieu.daude@gmail.com ARC-Seal: i=1; a=rsa-sha256; t=1612738673; cv=none; d=zohomail.com; s=zohoarc; b=bYfNAfniYn7HjRwzsl1OSiC7+MF20MDUSBnPvTUMFBO2xdFSJJiKeT30vKhE83gdJ78fmX2EhfV/VnbH4u1GglmjooyUh+OHGF3Jml8LQ/jrz6cxm6q3MH4fp98XBhIS00EkkAKqr+abj82wMahRcZMvmh3lAbc0e1DuLlBSmFY= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1612738673; h=Content-Type:Content-Transfer-Encoding:Cc:Date:From:In-Reply-To:MIME-Version:Message-ID:References:Sender:Subject:To; bh=H7DdpVZKuaTFU+QINWMbbbomeFKhPW3S4eDxwf+nJCo=; b=I6jWe9cEQPND1mJFCCUsZuJg7loKiQzQ4byeUqVaPpK2YS+B3DspjhSsyADM5dn0Lrd2OCbJCzdTKxwK3mgDKcLri2uCTmDn2D03x2jSjSR9roqmcT0AVeIywLniWN3pAoWVLd6phFPDCz3U3lVmnOsBT76/T/HIpA1pRyzGVwM= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of _spf.google.com designates 209.85.128.53 as permitted sender) smtp.mailfrom=philippe.mathieu.daude@gmail.com Received: from mail-wm1-f53.google.com (mail-wm1-f53.google.com [209.85.128.53]) by mx.zohomail.com with SMTPS id 1612738673741146.90947645096833; Sun, 7 Feb 2021 14:57:53 -0800 (PST) Received: by mail-wm1-f53.google.com with SMTP id o10so11163435wmc.1 for ; Sun, 07 Feb 2021 14:57:53 -0800 (PST) Return-Path: Return-Path: Received: from localhost.localdomain (68.red-83-57-175.dynamicip.rima-tde.net. [83.57.175.68]) by smtp.gmail.com with ESMTPSA id r11sm18905340wmh.9.2021.02.07.14.57.50 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sun, 07 Feb 2021 14:57:51 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=sender:from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=H7DdpVZKuaTFU+QINWMbbbomeFKhPW3S4eDxwf+nJCo=; b=DuwqKccHtBt4dz86RKdnXAtbY1C6a2HgS+5yvCWHJgZFtaXXGTwchErp5vAQyTjPq6 zpDQmq0x0jdwDD9c+O6S01GcEyxWMNZP55PSPzqFB9FWlSW1Ri8O7Wlshqg+s4xaTeAS hRqp7tWRf4EJVztY/4rSkH7FGLB2XnXK2wacllpoOaBiRbXuEtSXeJWDNGEiGOY1/qyn VMQgLGtoxwmohWvTGx0uBr6Zb9T2McbRsYj8f7FgJ3xX6HoXOVFsGmDjg7YQSTjzv3zE UmdR0rIismdm6Vbdy0zaFmpb2SYcPt95TFl5ioS4vJ5x0rUEcZ5JX2Ayhdik84KTEPjm rcvw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:sender:from:to:cc:subject:date:message-id :in-reply-to:references:mime-version:content-transfer-encoding; bh=H7DdpVZKuaTFU+QINWMbbbomeFKhPW3S4eDxwf+nJCo=; b=YVaJaHVkNGGfGiC3pPt7lpIAaIFF6NQECeTokYBVd53q2d8bH5SyMWAKozPGWWRMai N1BXl/+wiBYPH+iw4q4HY5vcIPh3qdHhBDEPhHGehW8DFAkqeC56CqYM/vQyhgK7x0e4 FHGupZh/5k4GGM8jcei2KB0juiYAwhpfDFKf18MgTV0M/EdAo5calsOkCYvxkgCYHhf0 ydAcbbAR0NhNvFvUxI6is9XSNwy7FExeZjvwXwIuOBqjnY/jVt/A/y1puCE+Vid5cGwW rGFAvD8BQMV1qJeW3fMo4hAb/Dqk53kvf6Pe0yrfBaB01qPSXHfY4/haJTb1elQ5eEYN gNAQ== X-Gm-Message-State: AOAM530vQ4gMwK3Y6NUwjIJ1+6qgFJt3Hh5xKaN98F6SQJPTeqHhTvH/ g+p4xAgnIz9ZlrgfWADH1AY= X-Google-Smtp-Source: ABdhPJwwUp3pd9IOFWEbOPAGSNqjz7Z9MdmROAusVzFJqHVWJmI2Yzh/PuF0aoHSDrcg1CGoH1St0A== X-Received: by 2002:a1c:6802:: with SMTP id d2mr11968962wmc.32.1612738672031; Sun, 07 Feb 2021 14:57:52 -0800 (PST) Sender: =?UTF-8?Q?Philippe_Mathieu=2DDaud=C3=A9?= From: =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= To: qemu-devel@nongnu.org Cc: Palmer Dabbelt , Bastian Koppelmann , Peter Maydell , Claudio Fontana , Paolo Bonzini , Yoshinori Sato , Aleksandar Rikalo , qemu-arm@nongnu.org, Aurelien Jarno , qemu-riscv@nongnu.org, Laurent Vivier , =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= , Richard Henderson , Alistair Francis , Sagar Karandikar , Jiaxun Yang Subject: [PATCH 2/6] target/m68k: Include missing "tcg/tcg.h" header Date: Sun, 7 Feb 2021 23:57:34 +0100 Message-Id: <20210207225738.2482987-3-f4bug@amsat.org> X-Mailer: git-send-email 2.26.2 In-Reply-To: <20210207225738.2482987-1-f4bug@amsat.org> References: <20210207225738.2482987-1-f4bug@amsat.org> MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable X-ZohoMail-DKIM: pass (identity @gmail.com) Commit 14f944063af ("target-m68k: add cas/cas2 ops") introduced use of typedef/prototypes declared in "tcg/tcg.h" without including it. This was not a problem because "tcg/tcg.h" is pulled in by "exec/cpu_ldst.h". To be able to remove this header there, we first need to include it here in op_helper.c, else we get: [953/1018] Compiling C object libqemu-m68k-softmmu.fa.p/target_m68k_op_he= lper.c.o target/m68k/op_helper.c: In function =E2=80=98do_cas2l=E2=80=99: target/m68k/op_helper.c:774:5: error: unknown type name =E2=80=98TCGMemOp= Idx=E2=80=99 774 | TCGMemOpIdx oi; | ^~~~~~~~~~~ target/m68k/op_helper.c:787:18: error: implicit declaration of function = =E2=80=98make_memop_idx=E2=80=99 [-Werror=3Dimplicit-function-declaration] 787 | oi =3D make_memop_idx(MO_BEQ, mmu_idx); | ^~~~~~~~~~~~~~ target/m68k/op_helper.c:787:18: error: nested extern declaration of =E2= =80=98make_memop_idx=E2=80=99 [-Werror=3Dnested-externs] target/m68k/op_helper.c:788:17: error: implicit declaration of function = =E2=80=98helper_atomic_cmpxchgq_be_mmu=E2=80=99; did you mean =E2=80=98help= er_atomic_cmpxchgq_be=E2=80=99? [-Werror=3Dimplicit-function-declaration] 788 | l =3D helper_atomic_cmpxchgq_be_mmu(env, a1, c, u, oi= , ra); | ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~ | helper_atomic_cmpxchgq_be target/m68k/op_helper.c:788:17: error: nested extern declaration of =E2= =80=98helper_atomic_cmpxchgq_be_mmu=E2=80=99 [-Werror=3Dnested-externs] cc1: all warnings being treated as errors Signed-off-by: Philippe Mathieu-Daud=C3=A9 --- target/m68k/op_helper.c | 1 + 1 file changed, 1 insertion(+) diff --git a/target/m68k/op_helper.c b/target/m68k/op_helper.c index 202498deb51..36b68fd318f 100644 --- a/target/m68k/op_helper.c +++ b/target/m68k/op_helper.c @@ -18,6 +18,7 @@ */ #include "qemu/osdep.h" #include "cpu.h" +#include "tcg/tcg.h" #include "exec/helper-proto.h" #include "exec/exec-all.h" #include "exec/cpu_ldst.h" --=20 2.26.2