From nobody Sun Feb 8 09:27:42 2026 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=fail; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=fail(p=none dis=none) header.from=redhat.com ARC-Seal: i=1; a=rsa-sha256; t=1612537591; cv=none; d=zohomail.com; s=zohoarc; b=LCWCfgme1I5rZjfaN4TiGHgLoDBEMkgpr/f+HJrPGjuZBIGfocegQa7FLG+TfnXlO5Tx7K3xW1vyQ0oTswAvHorFY4megwD9b0Km4nT1XP0XeUaXwsKbQgnV8moyOm4wVA+xwQ1Ned6bl2ZoUb9Evh8hepqm0kBP6wgrdv6w8Jw= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1612537591; h=Content-Type:Content-Transfer-Encoding:Cc:Date:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:To; bh=FfnGZFBb0xSQL+nFAuB9rCSg6we82L8TI7vblfp6mQs=; b=Mt+IlZrhU0fhunFttU2eq+Onu394c8AZNqSStOC/UkVwamNd7oDVcnUgDNXCQm4EggbTBexbmAeX8SwKy8hLtIaNpkDDPMceeoO97m3dHsiowBRpenaQYks9XpeizWLLMhcMs3YcS+rlub1mBgBaWZWTR8S2fQ0Fve7vJO+iXD8= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=fail; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=fail header.from= (p=none dis=none) header.from= Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1612537591520440.5375878700594; Fri, 5 Feb 2021 07:06:31 -0800 (PST) Received: from localhost ([::1]:40746 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1l82gm-0005Rz-1k for importer@patchew.org; Fri, 05 Feb 2021 10:06:28 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]:47756) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1l82e8-0003cd-O0 for qemu-devel@nongnu.org; Fri, 05 Feb 2021 10:03:45 -0500 Received: from us-smtp-delivery-124.mimecast.com ([63.128.21.124]:37949) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA1:256) (Exim 4.90_1) (envelope-from ) id 1l82e4-0002sG-63 for qemu-devel@nongnu.org; Fri, 05 Feb 2021 10:03:44 -0500 Received: from mail-ed1-f71.google.com (mail-ed1-f71.google.com [209.85.208.71]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-250-rt_UxAAsMAakbv5MnbkPIg-1; Fri, 05 Feb 2021 10:03:37 -0500 Received: by mail-ed1-f71.google.com with SMTP id i4so7132099edt.11 for ; Fri, 05 Feb 2021 07:03:37 -0800 (PST) Received: from redhat.com (bzq-79-180-2-31.red.bezeqint.net. [79.180.2.31]) by smtp.gmail.com with ESMTPSA id h3sm3288744ejl.111.2021.02.05.07.03.32 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 05 Feb 2021 07:03:33 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1612537419; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=FfnGZFBb0xSQL+nFAuB9rCSg6we82L8TI7vblfp6mQs=; b=GDywUW7FzdEuhyb6nkDYWTStE2bJslE//4struyu5/vuxoorgK05Ck+rlXcrzYVlmLgqIq nylqTlFywyZzM6uHO/6kEw4AMwexDbMLWG4SzLHEnDjHMzW/hzze9Quouv+yZIq4tWvd1T 87z30aV2gdrvYTijq4czjuoZPyo+ocI= X-MC-Unique: rt_UxAAsMAakbv5MnbkPIg-1 X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:content-transfer-encoding :in-reply-to; bh=FfnGZFBb0xSQL+nFAuB9rCSg6we82L8TI7vblfp6mQs=; b=nDJT2vQcKS23hB7HQ2rbTDbRvCA3IJcUAe6piT1RufII0MLyow1emKvyhbJSMX+xaV G5CculSCNWOXqZcnuzN5lJMidAJ2ZJLCNzYDol3CL8zAlzESl78UUyKd99Kb14X3QH8I 8f79Co2+Jeiodc2cszgOfMhMkEnxX9jdB4Zm/jFventpnDzcCywo7bIrpa5kfXUI3QZT hoF5Iq4QZaed1ZAkD9UiUUr8x3BwVd6O/662E7G+VSEKFAY13E7fLYYOfsOCKybk+P9r rSMYhCz5yLPlEplnxvln9igq7KYuciqXOM1F59Ddldv+BwHu7jWSaGPAeYYl88pNspoF w3eA== X-Gm-Message-State: AOAM533m3S+8Uugny+0M3LwkKIj5cjNT+WPA39Gb+iNsQ8jmzA4jW8LU lYTekDuH9K4MQTs1Vx4D+lhMPhnfM9ekC8GFtAiryZodjrzwIidn/QFYW/HiC12GVgW117y6sgJ r+h3NF0DXs2S4hxbUhs0uLZ39OF1SaO0y94COQh12bOeagUyKmokgVQqgasQY X-Received: by 2002:a17:907:35d1:: with SMTP id ap17mr4595668ejc.79.1612537415508; Fri, 05 Feb 2021 07:03:35 -0800 (PST) X-Google-Smtp-Source: ABdhPJw9ahgxlqK9JSEGFDwdUy7pn7FaRJeAzB2PwKX9dkYHG9H0imIJ5Fzqw3bNREQfSli75J57oQ== X-Received: by 2002:a17:907:35d1:: with SMTP id ap17mr4595529ejc.79.1612537414197; Fri, 05 Feb 2021 07:03:34 -0800 (PST) Date: Fri, 5 Feb 2021 10:03:31 -0500 From: "Michael S. Tsirkin" To: qemu-devel@nongnu.org Subject: [PULL v2 01/16] pci: reject too large ROMs Message-ID: <20210205150135.94643-2-mst@redhat.com> References: <20210205150135.94643-1-mst@redhat.com> MIME-Version: 1.0 In-Reply-To: <20210205150135.94643-1-mst@redhat.com> X-Mailer: git-send-email 2.27.0.106.g8ac3dc51b1 X-Mutt-Fcc: =sent Authentication-Results: relay.mimecast.com; auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=mst@redhat.com X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset="utf-8" Content-Disposition: inline Content-Transfer-Encoding: quoted-printable Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Received-SPF: pass client-ip=63.128.21.124; envelope-from=mst@redhat.com; helo=us-smtp-delivery-124.mimecast.com X-Spam_score_int: -30 X-Spam_score: -3.1 X-Spam_bar: --- X-Spam_report: (-3.1 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.352, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_LOW=-0.7, RCVD_IN_MSPIKE_H4=0.001, RCVD_IN_MSPIKE_WL=0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Peter Maydell , Laszlo Ersek , Peter Xu , David Edmondson , Paolo Bonzini , Philippe =?utf-8?Q?Mathieu-Daud=C3=A9?= Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: "Qemu-devel" X-ZohoMail-DKIM: fail (Header signature does not verify) From: Paolo Bonzini get_image_size() returns an int64_t, which pci_add_option_rom() assigns to an "int" without any range checking. A 32-bit BAR could be up to 2 GiB in size, so reject anything above it. In order to accomodate a rounded-up size of 2 GiB, change pci_patch_ids's size argument to unsigned. Reviewed-by: Peter Xu Reviewed-by: Philippe Mathieu-Daud=C3=A9 Reviewed-by: Laszlo Ersek Signed-off-by: Paolo Bonzini Message-Id: <20210203131828.156467-2-pbonzini@redhat.com> Reviewed-by: Michael S. Tsirkin Signed-off-by: Michael S. Tsirkin Reviewed-by: David Edmondson --- hw/pci/pci.c | 10 ++++++++-- 1 file changed, 8 insertions(+), 2 deletions(-) diff --git a/hw/pci/pci.c b/hw/pci/pci.c index 512e9042ff..58560c044d 100644 --- a/hw/pci/pci.c +++ b/hw/pci/pci.c @@ -25,6 +25,7 @@ #include "qemu/osdep.h" #include "qemu-common.h" #include "qemu/datadir.h" +#include "qemu/units.h" #include "hw/irq.h" #include "hw/pci/pci.h" #include "hw/pci/pci_bridge.h" @@ -2234,7 +2235,7 @@ static uint8_t pci_find_capability_at_offset(PCIDevic= e *pdev, uint8_t offset) =20 /* Patch the PCI vendor and device ids in a PCI rom image if necessary. This is needed for an option rom which is used for more than one device= . */ -static void pci_patch_ids(PCIDevice *pdev, uint8_t *ptr, int size) +static void pci_patch_ids(PCIDevice *pdev, uint8_t *ptr, uint32_t size) { uint16_t vendor_id; uint16_t device_id; @@ -2292,7 +2293,7 @@ static void pci_patch_ids(PCIDevice *pdev, uint8_t *p= tr, int size) static void pci_add_option_rom(PCIDevice *pdev, bool is_default_rom, Error **errp) { - int size; + int64_t size; char *path; void *ptr; char name[32]; @@ -2342,6 +2343,11 @@ static void pci_add_option_rom(PCIDevice *pdev, bool= is_default_rom, error_setg(errp, "romfile \"%s\" is empty", pdev->romfile); g_free(path); return; + } else if (size > 2 * GiB) { + error_setg(errp, "romfile \"%s\" too large (size cannot exceed 2 G= iB)", + pdev->romfile); + g_free(path); + return; } size =3D pow2ceil(size); =20 --=20 MST From nobody Sun Feb 8 09:27:42 2026 Delivered-To: importer@patchew.org Received-SPF: pass (zohomail.com: domain of lists.xenproject.org designates 192.237.175.120 as permitted sender) client-ip=192.237.175.120; envelope-from=xen-devel-bounces@lists.xenproject.org; helo=lists.xenproject.org; Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of lists.xenproject.org designates 192.237.175.120 as permitted sender) smtp.mailfrom=xen-devel-bounces@lists.xenproject.org; dmarc=pass(p=none dis=none) header.from=redhat.com ARC-Seal: i=1; a=rsa-sha256; t=1612537473; cv=none; d=zohomail.com; s=zohoarc; b=OK0oaeDw6H6bZGkB87TAh8Po22X+XuYEmAIi4ffnsOzlQ5qPTI7Ji6oi5c8FbMxgmVaLzN/llV+XFSMEAFmo0GJqLCIy/IDMkduJHQYLLbaGSJhI+vPND+ywbgxEu0tmEXqVg8iCLSCfPvyyrFtPbNGY//eYwqXnedEu2vpIm7s= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1612537473; h=Content-Type:Cc:Date:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:To; bh=zwMMO/GhT5P4qg6F1lADPTp5N9LNgrC5HBBNpAooZ60=; b=dfEbFXSBCSpNFzQhFw6c7DGlAnCz9TJG54Or61NVjT6YC/KU2gTtdqC0JXuIkDvHcoqbvjd/MGBeGLBqNte1jzOIbbg1255h5B6dy9hFBwth5QzQN7C0VBQyLqy7vBJvpdyXubuDDbIznTIrJ4VFZfsoy33ZkGbChD9rnN+8qe4= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of lists.xenproject.org designates 192.237.175.120 as permitted sender) smtp.mailfrom=xen-devel-bounces@lists.xenproject.org; dmarc=pass header.from= (p=none dis=none) header.from= Return-Path: Received: from lists.xenproject.org (lists.xenproject.org [192.237.175.120]) by mx.zohomail.com with SMTPS id 1612537473894649.1318581763945; Fri, 5 Feb 2021 07:04:33 -0800 (PST) Received: from list by lists.xenproject.org with outflank-mailman.81768.151187 (Exim 4.92) (envelope-from ) id 1l82eD-0004RG-46; Fri, 05 Feb 2021 15:03:49 +0000 Received: by outflank-mailman (output) from mailman id 81768.151187; Fri, 05 Feb 2021 15:03:49 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1l82eD-0004R9-0e; Fri, 05 Feb 2021 15:03:49 +0000 Received: by outflank-mailman (input) for mailman id 81768; Fri, 05 Feb 2021 15:03:47 +0000 Received: from all-amaz-eas1.inumbo.com ([34.197.232.57] helo=us1-amaz-eas2.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1l82eB-0004R4-Bh for xen-devel@lists.xenproject.org; Fri, 05 Feb 2021 15:03:47 +0000 Received: from us-smtp-delivery-124.mimecast.com (unknown [216.205.24.124]) by us1-amaz-eas2.inumbo.com (Halon) with ESMTP id 13bb7c49-3fa4-4db7-a68f-67fc66518788; Fri, 05 Feb 2021 15:03:45 +0000 (UTC) Received: from mail-ej1-f72.google.com (mail-ej1-f72.google.com [209.85.218.72]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-165-rMDRYlE6M6ineWQIZ6CPWw-1; Fri, 05 Feb 2021 10:03:40 -0500 Received: by mail-ej1-f72.google.com with SMTP id k3so6985835ejr.16 for ; Fri, 05 Feb 2021 07:03:40 -0800 (PST) Received: from redhat.com (bzq-79-180-2-31.red.bezeqint.net. [79.180.2.31]) by smtp.gmail.com with ESMTPSA id d5sm4104521edu.12.2021.02.05.07.03.35 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 05 Feb 2021 07:03:37 -0800 (PST) X-Outflank-Mailman: Message body and most headers restored to incoming version X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 13bb7c49-3fa4-4db7-a68f-67fc66518788 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1612537424; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=zwMMO/GhT5P4qg6F1lADPTp5N9LNgrC5HBBNpAooZ60=; b=JMm3/v6hHQmW9FqmN1XFAIVzCKyoLAt/YOZKbvuW2LAvubDuiZj+hVF7m0i+EGFhKyp7PA UWLH/z1/N49N+R1ZDkR3Jl1ilUEaF0SVr4VthyXIaVI+aYcT6/VHqgawiSr/O6nJD4DEBK Q9XJJwZC1xKgQdYDS2p0VlVDh2ex15Q= X-MC-Unique: rMDRYlE6M6ineWQIZ6CPWw-1 X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=zwMMO/GhT5P4qg6F1lADPTp5N9LNgrC5HBBNpAooZ60=; b=eAnTf+msp/DZijAjpP+UIhMC8YrsyESxsyBDDQPPkOGlzAljmMefaHitsbcVdGzz5i pNau5Zl5OOpKjRifSuEI0x88joGIEgx4k6owasfxtlR+aov+86VICY/PO7aafIxXU1GV AofpHWw0lP4d+6lUIWfSUM4nYviQ3vOGDsym5XrhZAYnvCTAukXq0Jsjp9XXmBDaViUu qZtCMk7q0Ua4qh48b1y69/LO3mUVj1lp4mGts2CA/chTffooFZRvBflx3ldBKCxClDfa QUcV312jNVRtgwHun3e8aU6tHHAqfw06HVDVUtytsYqQ72FOyXGwf/BnYc+1O3a/jeEA 8esg== X-Gm-Message-State: AOAM5325bOKOKEHewiY2cP0pMv3fU2iZ8RzoBykDaD2QV5a0/hnJLF3u RfHyGKKou0GBw/JJGoAzJKmKte3NQUl872vKiEx1kZQdMgBr1kAwnK374MlvMki7leSwH4MXZmU aVHyak1F++beY+u3iMe+hmWUP6OY= X-Received: by 2002:a17:907:98c3:: with SMTP id kd3mr4449968ejc.482.1612537419224; Fri, 05 Feb 2021 07:03:39 -0800 (PST) X-Google-Smtp-Source: ABdhPJyszPIeKkwa+10z8LK7e/ZhS/mQJGnrOXUtz/rjTwb1tdREvjR9aq3yiXVn0vxPl25KHrANHw== X-Received: by 2002:a17:907:98c3:: with SMTP id kd3mr4449818ejc.482.1612537417767; Fri, 05 Feb 2021 07:03:37 -0800 (PST) Date: Fri, 5 Feb 2021 10:03:34 -0500 From: "Michael S. Tsirkin" To: qemu-devel@nongnu.org Cc: Peter Maydell , Paolo Bonzini , "Dr . David Alan Gilbert" , Peter Xu , David Edmondson , Laszlo Ersek , Marcel Apfelbaum , Stefano Stabellini , Anthony Perard , Paul Durrant , xen-devel@lists.xenproject.org Subject: [PULL v2 02/16] pci: add romsize property Message-ID: <20210205150135.94643-3-mst@redhat.com> References: <20210205150135.94643-1-mst@redhat.com> MIME-Version: 1.0 In-Reply-To: <20210205150135.94643-1-mst@redhat.com> X-Mailer: git-send-email 2.27.0.106.g8ac3dc51b1 X-Mutt-Fcc: =sent Authentication-Results: relay.mimecast.com; auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=mst@redhat.com X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Disposition: inline X-ZohoMail-DKIM: pass (identity @redhat.com) Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" From: Paolo Bonzini This property can be useful for distros to set up known-good ROM sizes for migration purposes. The VM will fail to start if the ROM is too large, and migration compatibility will not be broken if the ROM is too small. Note that even though romsize is a uint32_t, it has to be between 1 (because empty ROM files are not accepted, and romsize must be greater than the file) and 2^31 (because values above are not powers of two and are rejected). Signed-off-by: Paolo Bonzini Reviewed-by: Dr. David Alan Gilbert Reviewed-by: Peter Xu Message-Id: <20201218182736.1634344-1-pbonzini@redhat.com> Signed-off-by: Paolo Bonzini Message-Id: <20210203131828.156467-3-pbonzini@redhat.com> Reviewed-by: Michael S. Tsirkin Signed-off-by: Michael S. Tsirkin Reviewed-by: David Edmondson Acked-by: Laszlo Ersek --- include/hw/pci/pci.h | 1 + hw/pci/pci.c | 19 +++++++++++++++++-- hw/xen/xen_pt_load_rom.c | 14 ++++++++++++-- 3 files changed, 30 insertions(+), 4 deletions(-) diff --git a/include/hw/pci/pci.h b/include/hw/pci/pci.h index 66db08462f..1bc231480f 100644 --- a/include/hw/pci/pci.h +++ b/include/hw/pci/pci.h @@ -344,6 +344,7 @@ struct PCIDevice { =20 /* Location of option rom */ char *romfile; + uint32_t romsize; bool has_rom; MemoryRegion rom; uint32_t rom_bar; diff --git a/hw/pci/pci.c b/hw/pci/pci.c index 58560c044d..a9ebef8a35 100644 --- a/hw/pci/pci.c +++ b/hw/pci/pci.c @@ -69,6 +69,7 @@ static void pcibus_reset(BusState *qbus); static Property pci_props[] =3D { DEFINE_PROP_PCI_DEVFN("addr", PCIDevice, devfn, -1), DEFINE_PROP_STRING("romfile", PCIDevice, romfile), + DEFINE_PROP_UINT32("romsize", PCIDevice, romsize, -1), DEFINE_PROP_UINT32("rombar", PCIDevice, rom_bar, 1), DEFINE_PROP_BIT("multifunction", PCIDevice, cap_present, QEMU_PCI_CAP_MULTIFUNCTION_BITNR, false), @@ -2084,6 +2085,11 @@ static void pci_qdev_realize(DeviceState *qdev, Erro= r **errp) bool is_default_rom; uint16_t class_id; =20 + if (pci_dev->romsize !=3D -1 && !is_power_of_2(pci_dev->romsize)) { + error_setg(errp, "ROM size %u is not a power of two", pci_dev->rom= size); + return; + } + /* initialize cap_present for pci_is_express() and pci_config_size(), * Note that hybrid PCIs are not set automatically and need to manage * QEMU_PCI_CAP_EXPRESS manually */ @@ -2349,7 +2355,16 @@ static void pci_add_option_rom(PCIDevice *pdev, bool= is_default_rom, g_free(path); return; } - size =3D pow2ceil(size); + if (pdev->romsize !=3D -1) { + if (size > pdev->romsize) { + error_setg(errp, "romfile \"%s\" (%u bytes) is too large for R= OM size %u", + pdev->romfile, (uint32_t)size, pdev->romsize); + g_free(path); + return; + } + } else { + pdev->romsize =3D pow2ceil(size); + } =20 vmsd =3D qdev_get_vmsd(DEVICE(pdev)); =20 @@ -2359,7 +2374,7 @@ static void pci_add_option_rom(PCIDevice *pdev, bool = is_default_rom, snprintf(name, sizeof(name), "%s.rom", object_get_typename(OBJECT(= pdev))); } pdev->has_rom =3D true; - memory_region_init_rom(&pdev->rom, OBJECT(pdev), name, size, &error_fa= tal); + memory_region_init_rom(&pdev->rom, OBJECT(pdev), name, pdev->romsize, = &error_fatal); ptr =3D memory_region_get_ram_ptr(&pdev->rom); if (load_image_size(path, ptr, size) < 0) { error_setg(errp, "failed to load romfile \"%s\"", pdev->romfile); diff --git a/hw/xen/xen_pt_load_rom.c b/hw/xen/xen_pt_load_rom.c index a50a80837e..03422a8a71 100644 --- a/hw/xen/xen_pt_load_rom.c +++ b/hw/xen/xen_pt_load_rom.c @@ -53,10 +53,20 @@ void *pci_assign_dev_load_option_rom(PCIDevice *dev, } fseek(fp, 0, SEEK_SET); =20 + if (dev->romsize !=3D -1) { + if (st.st_size > dev->romsize) { + error_report("ROM BAR \"%s\" (%ld bytes) is too large for ROM = size %u", + rom_file, (long) st.st_size, dev->romsize); + goto close_rom; + } + } else { + dev->romsize =3D st.st_size; + } + snprintf(name, sizeof(name), "%s.rom", object_get_typename(owner)); - memory_region_init_ram(&dev->rom, owner, name, st.st_size, &error_abor= t); + memory_region_init_ram(&dev->rom, owner, name, dev->romsize, &error_ab= ort); ptr =3D memory_region_get_ram_ptr(&dev->rom); - memset(ptr, 0xff, st.st_size); + memset(ptr, 0xff, dev->romsize); =20 if (!fread(ptr, 1, st.st_size, fp)) { error_report("pci-assign: Cannot read from host %s", rom_file); --=20 MST From nobody Sun Feb 8 09:27:42 2026 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=fail; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=fail(p=none dis=none) header.from=redhat.com ARC-Seal: i=1; a=rsa-sha256; t=1612537591; cv=none; d=zohomail.com; s=zohoarc; b=EOX/kzJBQffrPIumwo2gESmzRlJ9nfy/7ea7x6772V4piwViuwKzfIEcoh5vhALmr+SIEJtsnIwiwdclKaUXVHVI1e+D2ZiDPeUGR8qGOBCoUwuiO0cEb3ADVfXsm1l2R7CMu2zQx7kpFbW5m9XnRxV0tBNOO2Y4VlWPVmxEBuQ= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1612537591; h=Content-Type:Cc:Date:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:To; bh=b12CtRnbl7Nqs3gJjcv4tUQW0ofPPzvIUK5DBHZsRyc=; b=MtGR/22zjTpnli58Ev4moWFqxY660fHTZXLUUBIQKfg8hdkYFG3xuAdFsCS56da0Z30oD22zULFt0/MxcEFR//X1RoFSiFeVWKNNSrzFq5xKZIChJXUwXaDVHMFv6dDBRNE9iFQg4TbssNsXrh41iFMOe1TM01XWsM5wB6KVcig= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=fail; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=fail header.from= (p=none dis=none) header.from= Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1612537591042265.6187047872115; Fri, 5 Feb 2021 07:06:31 -0800 (PST) Received: from localhost ([::1]:40832 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1l82gm-0005YO-9T for importer@patchew.org; Fri, 05 Feb 2021 10:06:28 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]:47778) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1l82eC-0003db-7b for qemu-devel@nongnu.org; Fri, 05 Feb 2021 10:03:48 -0500 Received: from us-smtp-delivery-124.mimecast.com ([216.205.24.124]:29867) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA1:256) (Exim 4.90_1) (envelope-from ) id 1l82e9-0002tC-Id for qemu-devel@nongnu.org; Fri, 05 Feb 2021 10:03:47 -0500 Received: from mail-ed1-f69.google.com (mail-ed1-f69.google.com [209.85.208.69]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-473-PNkEbhexNBiIlQmrRXdLuQ-1; Fri, 05 Feb 2021 10:03:42 -0500 Received: by mail-ed1-f69.google.com with SMTP id bd22so7090684edb.4 for ; Fri, 05 Feb 2021 07:03:42 -0800 (PST) Received: from redhat.com (bzq-79-180-2-31.red.bezeqint.net. [79.180.2.31]) by smtp.gmail.com with ESMTPSA id v20sm4115787edt.3.2021.02.05.07.03.39 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 05 Feb 2021 07:03:40 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1612537424; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=b12CtRnbl7Nqs3gJjcv4tUQW0ofPPzvIUK5DBHZsRyc=; b=Luwo2wU6YugSEDu5VUVxLRJES38giuSlP9T9797WGQITS+RviPjY2cQnEOjSr7Orbk8o8r f7759M+OtnoDFiOSghxUAKEe3y7v+9OBLs4UOcsQyQVAXaUTDXUkPzKOzBIyMI41r4uvl4 fr5BAnBQnp2p5WOWJuFb9poqgqBC7qk= X-MC-Unique: PNkEbhexNBiIlQmrRXdLuQ-1 X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=b12CtRnbl7Nqs3gJjcv4tUQW0ofPPzvIUK5DBHZsRyc=; b=tK90aGtHMYJTHHLprGvOSStAsCXZEuVNgbH3E/fwsUzTYzbL74QtpuiHGJcFzk3sdh lX4NubWS18MtOvYMOFskjW5VT1tbBMNLOkEDsBPAbVguZJbHa5r1NITSo74nqZqWdlSQ 5XefvPgA88kdyElHU1qxcOA3D59nv14GzhJmNw21qyaiyRD64UueGD/7sgRYYbLxQbra pht63v6ZyTJtwi4eJ+jeyBNQAed8R8N0Kb8yIxHY1eTReKXcS+o4MmjZ4V2pgV4xB5AT yFw7L0lOraCSpH9Qw1NWYD7KkVEjhn0MunqzmMwJvhUosUAccZ/xeA6RYQH9PfYhphNV n0zQ== X-Gm-Message-State: AOAM531qej4yHh6fEjapt8qhH+S6Fux4obMhNGpIviBSXyPj+k65Uzqe 0iiB92hV8FeCiAWCjz3CQtQSr9NZqKoK7vxG/T/9kLjz7pZHa0lxKjFgiEKTlyqMMH+AU3bhlf0 51YCXuqAm/pMGqe9cyUOuKIch5Vne6bO0H9/9UDmHDPSJQgHhSYdjop6oqeFD X-Received: by 2002:a50:9310:: with SMTP id m16mr3955883eda.94.1612537421179; Fri, 05 Feb 2021 07:03:41 -0800 (PST) X-Google-Smtp-Source: ABdhPJwnY4WJainvY5Z3F+kZcKRpf2oQgQrkf+/fKQ61K9AHz9lX53ouYWk+PtCIqmKkVI+ykjElzg== X-Received: by 2002:a50:9310:: with SMTP id m16mr3955840eda.94.1612537420784; Fri, 05 Feb 2021 07:03:40 -0800 (PST) Date: Fri, 5 Feb 2021 10:03:38 -0500 From: "Michael S. Tsirkin" To: qemu-devel@nongnu.org Subject: [PULL v2 03/16] virtio: move 'use-disabled-flag' property to hw_compat_4_2 Message-ID: <20210205150135.94643-4-mst@redhat.com> References: <20210205150135.94643-1-mst@redhat.com> MIME-Version: 1.0 In-Reply-To: <20210205150135.94643-1-mst@redhat.com> X-Mailer: git-send-email 2.27.0.106.g8ac3dc51b1 X-Mutt-Fcc: =sent Authentication-Results: relay.mimecast.com; auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=mst@redhat.com X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Disposition: inline Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Received-SPF: pass client-ip=216.205.24.124; envelope-from=mst@redhat.com; helo=us-smtp-delivery-124.mimecast.com X-Spam_score_int: -30 X-Spam_score: -3.1 X-Spam_bar: --- X-Spam_report: (-3.1 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.352, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_LOW=-0.7, RCVD_IN_MSPIKE_H3=0.001, RCVD_IN_MSPIKE_WL=0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Peter Maydell , Eduardo Habkost , qemu-stable@nongnu.org, mdroth@linux.vnet.ibm.com, Jing Zhao , Stefano Garzarella Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: "Qemu-devel" X-ZohoMail-DKIM: fail (Header signature does not verify) Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" From: Stefano Garzarella Commit 9d7bd0826f introduced a new 'use-disabled-flag' property set to true by default. To allow the migration, we set this property to false in the hw_compat, but in the wrong place (hw_compat_4_1). Since commit 9d7bd0826f was released with QEMU 5.0, we move 'use-disabled-flag' property to hw_compat_4_2, so 4.2 machine types will have the pre-patch behavior and the migration can work. The issue was discovered with vhost-vsock device and 4.2 machine type without running any kernel in the VM: $ qemu-4.2 -M pc-q35-4.2,accel=3Dkvm \ -device vhost-vsock-pci,guest-cid=3D4 \ -monitor stdio -incoming tcp:0:3333 $ qemu-5.2 -M pc-q35-4.2,accel=3Dkvm \ -device vhost-vsock-pci,guest-cid=3D3 \ -monitor stdio (qemu) migrate -d tcp:0:3333 # qemu-4.2 output qemu-system-x86_64: Failed to load virtio-vhost_vsock:virtio qemu-system-x86_64: error while loading state for instance 0x0 of devic= e '0000:00:03.0/virtio-vhost_vsock' qemu-system-x86_64: load of migration failed: No such file or directory Reported-by: Jing Zhao Buglink: https://bugzilla.redhat.com/show_bug.cgi?id=3D1907255 Fixes: 9d7bd0826f ("virtio-pci: disable vring processing when bus-mastering= is disabled") Cc: mdroth@linux.vnet.ibm.com CC: qemu-stable@nongnu.org Signed-off-by: Stefano Garzarella Message-Id: <20210108171252.209502-1-sgarzare@redhat.com> Reviewed-by: Michael S. Tsirkin Signed-off-by: Michael S. Tsirkin --- hw/core/machine.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/hw/core/machine.c b/hw/core/machine.c index de3b8f1b31..5d6163ab70 100644 --- a/hw/core/machine.c +++ b/hw/core/machine.c @@ -70,12 +70,12 @@ GlobalProperty hw_compat_4_2[] =3D { { "qxl", "revision", "4" }, { "qxl-vga", "revision", "4" }, { "fw_cfg", "acpi-mr-restore", "false" }, + { "virtio-device", "use-disabled-flag", "false" }, }; const size_t hw_compat_4_2_len =3D G_N_ELEMENTS(hw_compat_4_2); =20 GlobalProperty hw_compat_4_1[] =3D { { "virtio-pci", "x-pcie-flr-init", "off" }, - { "virtio-device", "use-disabled-flag", "false" }, }; const size_t hw_compat_4_1_len =3D G_N_ELEMENTS(hw_compat_4_1); =20 --=20 MST From nobody Sun Feb 8 09:27:42 2026 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=fail; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=fail(p=none dis=none) header.from=redhat.com ARC-Seal: i=1; a=rsa-sha256; t=1612538718; cv=none; d=zohomail.com; s=zohoarc; b=j2So8cP8hKfph/oPRSuk4JEqhXSZaD5YfWiKMpZXlhl1rgYSZnULc/3+boJX9IUt5bZNkegk73ArKriv4s4qXWdc4rf7OcEnAoEqEqnMoJ5d4aiyQiEB6mpxQOKsgKom11tjA5wMMtGbn1ZfUsN3UkxCqtg+QaGlcS06DCm+oJE= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1612538718; h=Content-Type:Cc:Date:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:To; bh=0YVwlnyhma8tw3aikrEQmkUKeFTYcxGuyLeIpvMJSOU=; b=nTl7jTfwnotRpSYJj9ZVwssVXuD9+YL/e0c9BWV61lTXu+2OdPMlTkkoE+a+c4wOP+C9/i2DqCeRjw7pAIIY/hL/uYp3+81W7nuMMb3e28Dy5xOCKltxFQxjVtosKo+dAjDNMeQWpsaSGshWWDf2v7Yeq1nbAx1Eza/DnBPMeic= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=fail; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=fail header.from= (p=none dis=none) header.from= Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 161253871803734.04735341070693; Fri, 5 Feb 2021 07:25:18 -0800 (PST) Received: from localhost ([::1]:52868 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1l82l4-0002GT-8b for importer@patchew.org; Fri, 05 Feb 2021 10:10:54 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]:47806) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1l82eG-0003gr-PB for qemu-devel@nongnu.org; Fri, 05 Feb 2021 10:03:52 -0500 Received: from us-smtp-delivery-124.mimecast.com ([63.128.21.124]:56280) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA1:256) (Exim 4.90_1) (envelope-from ) id 1l82eE-0002wF-74 for qemu-devel@nongnu.org; Fri, 05 Feb 2021 10:03:52 -0500 Received: from mail-ej1-f72.google.com (mail-ej1-f72.google.com [209.85.218.72]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-468-jEhGuVdHMtGuKn6avrIWHA-1; Fri, 05 Feb 2021 10:03:45 -0500 Received: by mail-ej1-f72.google.com with SMTP id yh28so6907615ejb.11 for ; Fri, 05 Feb 2021 07:03:45 -0800 (PST) Received: from redhat.com (bzq-79-180-2-31.red.bezeqint.net. [79.180.2.31]) by smtp.gmail.com with ESMTPSA id l12sm2068012edn.83.2021.02.05.07.03.42 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 05 Feb 2021 07:03:42 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1612537429; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=0YVwlnyhma8tw3aikrEQmkUKeFTYcxGuyLeIpvMJSOU=; b=EqNeaZ+b4qXcXkWmkZjqNT2vAdoGgpXHEnWgmosv5FpwjII95zI/b31M2taVuY5nD5Xrma CFDQI1rZywluuKEaPOiqLe+8pCYfS3gm3NPeWqkDkitH0y06WlFx2+qmzqIChF9VdCJosx LrRgiHK9fD5aFfGicqea/E6mjjx8Htk= X-MC-Unique: jEhGuVdHMtGuKn6avrIWHA-1 X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=0YVwlnyhma8tw3aikrEQmkUKeFTYcxGuyLeIpvMJSOU=; b=ZOk5hsgASvvVNbGsILZgFvRFwKEfUsUZ6J6zPvI+jU9+j2g6YwfizytuxoJc8rBwj7 CNVP1d6nS7cWfslxgahaFcfgwhI7+p3fU3P03QcxaeohhsFhKYu32+qeFCknfmMXTbMf z8kKiWMB9GlY+QC5wOYgzWbLY7diQ3LW3S78JTI/hhyD6tXqEhqZ7EKZGCftXHSb/6Yj AZLzVeqP1TAmHs8YOqbwHsAllzmolJjjh1WfPy94zAx0zhrYHEy/NFG3MlKihJQagE03 1jjwhXPbI7t33K3fJUhmVRWjnw0a5MIh2pjDIzByx66j9m6TIvZfq7BHlQFJdGYIVCPJ xBXQ== X-Gm-Message-State: AOAM532JF5c6kQh9ine3ZZ2sGWwJch+Eusk3NZ50NzoK7DpIDHlYKF57 czD+DduDfMrS1thB+8re24/tPCvMlM/M6S2ac9iXYe7YUuzRKFWPaoSRfrKGffhJW8yeEvydCoY 46PDdcFQBjYzFKPhh1hr7PxTkVEKley+wmdHC451oSRF9JvDUEYdHe2Mw+mqN X-Received: by 2002:a50:bf4a:: with SMTP id g10mr3759973edk.201.1612537423776; Fri, 05 Feb 2021 07:03:43 -0800 (PST) X-Google-Smtp-Source: ABdhPJzBBrxNGYfwiVbSab/8GAANM2FFTaEMhekLRBWouXRJNuNvq5AjR2EVFCMWymsGI+Ho1W4LzA== X-Received: by 2002:a50:bf4a:: with SMTP id g10mr3759944edk.201.1612537423494; Fri, 05 Feb 2021 07:03:43 -0800 (PST) Date: Fri, 5 Feb 2021 10:03:41 -0500 From: "Michael S. Tsirkin" To: qemu-devel@nongnu.org Subject: [PULL v2 04/16] virtio-mmio: fix guest kernel crash with SHM regions Message-ID: <20210205150135.94643-5-mst@redhat.com> References: <20210205150135.94643-1-mst@redhat.com> MIME-Version: 1.0 In-Reply-To: <20210205150135.94643-1-mst@redhat.com> X-Mailer: git-send-email 2.27.0.106.g8ac3dc51b1 X-Mutt-Fcc: =sent Authentication-Results: relay.mimecast.com; auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=mst@redhat.com X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Disposition: inline Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Received-SPF: pass client-ip=63.128.21.124; envelope-from=mst@redhat.com; helo=us-smtp-delivery-124.mimecast.com X-Spam_score_int: -30 X-Spam_score: -3.1 X-Spam_bar: --- X-Spam_report: (-3.1 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.352, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_LOW=-0.7, RCVD_IN_MSPIKE_H4=0.001, RCVD_IN_MSPIKE_WL=0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Peter Maydell , Stefano Garzarella , Laurent Vivier , Gerd Hoffmann Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: "Qemu-devel" X-ZohoMail-DKIM: fail (Header signature does not verify) Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" From: Laurent Vivier In the kernel, virtio_gpu_init() uses virtio_get_shm_region() since commit 6076a9711dc5 ("drm/virtio: implement blob resources: probe for host = visible region") but vm_get_shm_region() unconditionally uses VIRTIO_MMIO_SHM_SEL to get the address and the length of the region. commit 38e895487afc ("virtio: Implement get_shm_region for MMIO transport" As this is not implemented in QEMU, address and length are 0 and passed as is to devm_request_mem_region() that triggers a crash: [drm:virtio_gpu_init] *ERROR* Could not reserve host visible region Unable to handle kernel NULL pointer dereference at virtual address (ptrv= al) According to the comments in the kernel, a non existent shared region has a length of (u64)-1. This is what we return now with this patch to disable the region. Signed-off-by: Laurent Vivier Message-Id: <20201220163539.2255963-1-laurent@vivier.eu> Acked-by: Gerd Hoffmann Reviewed-by: Stefano Garzarella Reviewed-by: Michael S. Tsirkin Signed-off-by: Michael S. Tsirkin --- hw/virtio/virtio-mmio.c | 8 ++++++++ 1 file changed, 8 insertions(+) diff --git a/hw/virtio/virtio-mmio.c b/hw/virtio/virtio-mmio.c index e1b5c3b81e..610661d6a5 100644 --- a/hw/virtio/virtio-mmio.c +++ b/hw/virtio/virtio-mmio.c @@ -191,6 +191,14 @@ static uint64_t virtio_mmio_read(void *opaque, hwaddr = offset, unsigned size) return 0; } return vdev->generation; + case VIRTIO_MMIO_SHM_LEN_LOW: + case VIRTIO_MMIO_SHM_LEN_HIGH: + /* + * VIRTIO_MMIO_SHM_SEL is unimplemented + * according to the linux driver, if region length is -1 + * the shared memory doesn't exist + */ + return -1; case VIRTIO_MMIO_DEVICE_FEATURES_SEL: case VIRTIO_MMIO_DRIVER_FEATURES: case VIRTIO_MMIO_DRIVER_FEATURES_SEL: --=20 MST From nobody Sun Feb 8 09:27:42 2026 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=fail; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=fail(p=none dis=none) header.from=redhat.com ARC-Seal: i=1; a=rsa-sha256; t=1612538690; cv=none; d=zohomail.com; s=zohoarc; b=YwoErcHzqH3fuObCU17eJxxq5DaZi7e69EwmqXff201gqGY3cjt4SwX8NXPG/pefPCnSzYUOF61osa3R2gmwnhgTLOhHDxaljnN85EDlW+B2PpOKmazBOD6dqqGixgkUaFa1BdzK8XdzNVgzoeAYCvmV9BvPygR1dVehTmlX6Hg= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1612538690; h=Content-Type:Content-Transfer-Encoding:Cc:Date:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:To; bh=Ong1GkdT0BdhwEoV9qdLEHGI9i35eWRtkFgpntdqfWY=; b=hn9tR6oGaDJgdAGSZ2/IsoC9zckONgAY2Utpx5+ZoDmvZO/A1mhb2Ncxt4aWM2Sl4aEU+aqeeLTAphL1nXDHp+UIktoz8WITtU6oxK3AecFkMtmWQfQGDpIkEh3WjLrDLwm0AwbztLVvV496EU1XzDWv5kBQS5jPsn+e7z8fywQ= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=fail; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=fail header.from= (p=none dis=none) header.from= Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1612538690599156.96893617172702; Fri, 5 Feb 2021 07:24:50 -0800 (PST) Received: from localhost ([::1]:45778 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1l82iF-0007f8-6v for importer@patchew.org; Fri, 05 Feb 2021 10:07:59 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]:47830) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1l82eJ-0003nD-A1 for qemu-devel@nongnu.org; Fri, 05 Feb 2021 10:03:55 -0500 Received: from us-smtp-delivery-124.mimecast.com ([216.205.24.124]:27767) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA1:256) (Exim 4.90_1) (envelope-from ) id 1l82eG-0002x4-S4 for qemu-devel@nongnu.org; Fri, 05 Feb 2021 10:03:54 -0500 Received: from mail-ed1-f72.google.com (mail-ed1-f72.google.com [209.85.208.72]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-37-CcO889jPOHm6HCsinfbOuA-1; Fri, 05 Feb 2021 10:03:48 -0500 Received: by mail-ed1-f72.google.com with SMTP id u24so4054727eds.13 for ; Fri, 05 Feb 2021 07:03:48 -0800 (PST) Received: from redhat.com (bzq-79-180-2-31.red.bezeqint.net. [79.180.2.31]) by smtp.gmail.com with ESMTPSA id bm2sm3992188ejb.87.2021.02.05.07.03.44 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 05 Feb 2021 07:03:45 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1612537432; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=Ong1GkdT0BdhwEoV9qdLEHGI9i35eWRtkFgpntdqfWY=; b=Gmnr7S6lKVQ96OvrEfuCjtpMEac6c9om2unr4TrUtzouQk6NVYM7KDn9eOgLU8rqJnlMej 7Yl2Iw6vGhjMLlZDpzbJzDWnmfnBLKS1zbrGr4rybgsqwpJdwEcBE68mVjTw4eAPMZRhyC mibWBx4chiMVs5kjBgyQqL6/94G4gmE= X-MC-Unique: CcO889jPOHm6HCsinfbOuA-1 X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:content-transfer-encoding :in-reply-to; bh=Ong1GkdT0BdhwEoV9qdLEHGI9i35eWRtkFgpntdqfWY=; b=nF9Ehevres1H9dcldqzRM1eiHoce3BFlo69gqI2N6BxVxBt4X8YbiWWL/edjbMXlm0 ueO0g5zcc+tSgXHM09NkWPvodouWvOsDdBzExzT3to5Axxamovfz/LT4B7+5FHQaE8+k EAuD6jWHZCo4I/Uisv8XjX28n6pv7SNyrojQCfqLVEhPDfgZBWhWOJrIJVoB5xM2kRR6 3D+Dz1INjsJrlIzCHQStRiFX0XfP5qQCjCDlwM95v4vr+IScXmEaIP85L8J2Tp1iSMo7 iPKnS3zavvLbeiKEuAiMXd9FHQssDvex5dIiIWyqXaBrEBeIhnl/h8q+bot7HcHgTc6w NbbQ== X-Gm-Message-State: AOAM531bs49uH8Fnz+qxQ6To+DHftx/Dte0B02l74wsQIqf7pU45zgXw vANT/lyxXqe/IcugGmU4meQajhU8uTMZbv2rifkDju5PEB4eSBL9qSXXKiB0aOG3zMATGi9AuiY a/+XoO6Top9GQzD8bRZoRv1hx0E1TnY2IIM+ueQUVxRkQJMkKfQ/liSIAm04+ X-Received: by 2002:aa7:d755:: with SMTP id a21mr3810034eds.301.1612537426753; Fri, 05 Feb 2021 07:03:46 -0800 (PST) X-Google-Smtp-Source: ABdhPJzN7scbcxPqpIzJH2isJ0Wa2pxDZ/uBlqyJIFD2KtdaApfbPDhpVWMsbgQNaQln2l05SA4lLQ== X-Received: by 2002:aa7:d755:: with SMTP id a21mr3810012eds.301.1612537426546; Fri, 05 Feb 2021 07:03:46 -0800 (PST) Date: Fri, 5 Feb 2021 10:03:43 -0500 From: "Michael S. Tsirkin" To: qemu-devel@nongnu.org Subject: [PULL v2 05/16] virtio: Add corresponding memory_listener_unregister to unrealize Message-ID: <20210205150135.94643-6-mst@redhat.com> References: <20210205150135.94643-1-mst@redhat.com> MIME-Version: 1.0 In-Reply-To: <20210205150135.94643-1-mst@redhat.com> X-Mailer: git-send-email 2.27.0.106.g8ac3dc51b1 X-Mutt-Fcc: =sent Authentication-Results: relay.mimecast.com; auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=mst@redhat.com X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset="utf-8" Content-Disposition: inline Content-Transfer-Encoding: quoted-printable Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Received-SPF: pass client-ip=216.205.24.124; envelope-from=mst@redhat.com; helo=us-smtp-delivery-124.mimecast.com X-Spam_score_int: -30 X-Spam_score: -3.1 X-Spam_bar: --- X-Spam_report: (-3.1 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.352, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_LOW=-0.7, RCVD_IN_MSPIKE_H3=0.001, RCVD_IN_MSPIKE_WL=0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Peter Maydell , Jason Wang , Stefano Garzarella , Peter Xu , Eugenio =?utf-8?B?UMOpcmV6?= Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: "Qemu-devel" X-ZohoMail-DKIM: fail (Header signature does not verify) From: Eugenio P=C3=A9rez Address space is destroyed without proper removal of its listeners with current code. They are expected to be removed in virtio_device_instance_finalize [1], but qemu calls it through object_deinit, after address_space_destroy call through device_set_realized [2]. Move it to virtio_device_unrealize, called before device_set_realized [3] and making it symmetric with memory_listener_register in virtio_device_realize. v2: Delete no-op call of virtio_device_instance_finalize. Add backtraces. [1] #0 virtio_device_instance_finalize (obj=3D0x555557de5120) at /home/qemu/include/hw/virtio/virtio.h:71 #1 0x0000555555b703c9 in object_deinit (type=3D0x555556639860, obj=3D) at ../qom/object.c:671 #2 object_finalize (data=3D0x555557de5120) at ../qom/object.c:685 #3 object_unref (objptr=3D0x555557de5120) at ../qom/object.c:1184 #4 0x0000555555b4de9d in bus_free_bus_child (kid=3D0x555557df0660) at ../hw/core/qdev.c:55 #5 0x0000555555c65003 in call_rcu_thread (opaque=3Dopaque@entry=3D0x0) at ../util/rcu.c:281 Queued by: #0 bus_remove_child (bus=3D0x555557de5098, child=3Dchild@entry=3D0x555557de5120) at ../hw/core/qdev.c:60 #1 0x0000555555b4ee31 in device_unparent (obj=3D) at ../hw/core/qdev.c:984 #2 0x0000555555b70465 in object_finalize_child_property ( obj=3D, name=3D, opaque=3D0x555557de5120) at ../qom/object.c:1725 #3 0x0000555555b6fa17 in object_property_del_child ( child=3D0x555557de5120, obj=3D0x555557ddcf90) at ../qom/object.c:645 #4 object_unparent (obj=3D0x555557de5120) at ../qom/object.c:664 #5 0x0000555555b4c071 in bus_unparent (obj=3D) at ../hw/core/bus.c:147 #6 0x0000555555b70465 in object_finalize_child_property ( obj=3D, name=3D, opaque=3D0x555557de5098) at ../qom/object.c:1725 #7 0x0000555555b6fa17 in object_property_del_child ( child=3D0x555557de5098, obj=3D0x555557ddcf90) at ../qom/object.c:645 #8 object_unparent (obj=3D0x555557de5098) at ../qom/object.c:664 #9 0x0000555555b4ee19 in device_unparent (obj=3D) at ../hw/core/qdev.c:981 #10 0x0000555555b70465 in object_finalize_child_property ( obj=3D, name=3D, opaque=3D0x555557ddcf90) at ../qom/object.c:1725 #11 0x0000555555b6fa17 in object_property_del_child ( child=3D0x555557ddcf90, obj=3D0x55555685da10) at ../qom/object.c:645 #12 object_unparent (obj=3D0x555557ddcf90) at ../qom/object.c:664 #13 0x00005555558dc331 in pci_for_each_device_under_bus ( opaque=3D, fn=3D, bus=3D) at ../hw/pci/pci.c:1654 [2] Optimizer omits pci_qdev_unrealize, called by device_set_realized, and do_pci_unregister_device, called by pci_qdev_unrealize and caller of address_space_destroy. #0 address_space_destroy (as=3D0x555557ddd1b8) at ../softmmu/memory.c:2840 #1 0x0000555555b4fc53 in device_set_realized (obj=3D0x555557ddcf90, value=3D, errp=3D0x7fffeea8f1e0) at ../hw/core/qdev.c:850 #2 0x0000555555b6eaa6 in property_set_bool (obj=3D0x555557ddcf90, v=3D, name=3D, opaque=3D0x555556650ba0, errp=3D0x7fffeea8f1e0) at ../qom/object.c:2255 #3 0x0000555555b70e07 in object_property_set ( obj=3Dobj@entry=3D0x555557ddcf90, name=3Dname@entry=3D0x555555db99df "realized", v=3Dv@entry=3D0x7fffe46b7500, errp=3Derrp@entry=3D0x5555565bbf38 ) at ../qom/object.c:1400 #4 0x0000555555b73c5f in object_property_set_qobject ( obj=3Dobj@entry=3D0x555557ddcf90, name=3Dname@entry=3D0x555555db99df "realized", value=3Dvalue@entry=3D0x7fffe44f6180, errp=3Derrp@entry=3D0x5555565bbf38 ) at ../qom/qom-qobject.c:28 #5 0x0000555555b71044 in object_property_set_bool ( obj=3D0x555557ddcf90, name=3D0x555555db99df "realized", value=3D, errp=3D0x5555565bbf38 ) at ../qom/object.c:1470 #6 0x0000555555921cb7 in pcie_unplug_device (bus=3D, dev=3D0x555557ddcf90, opaque=3D) at /home/qemu/include/hw/qdev-core.h:17 #7 0x00005555558dc331 in pci_for_each_device_under_bus ( opaque=3D, fn=3D, bus=3D) at ../hw/pci/pci.c:1654 [3] #0 virtio_device_unrealize (dev=3D0x555557de5120) at ../hw/virtio/virtio.c:3680 #1 0x0000555555b4fc63 in device_set_realized (obj=3D0x555557de5120, value=3D, errp=3D0x7fffee28df90) at ../hw/core/qdev.c:850 #2 0x0000555555b6eab6 in property_set_bool (obj=3D0x555557de5120, v=3D, name=3D, opaque=3D0x555556650ba0, errp=3D0x7fffee28df90) at ../qom/object.c:2255 #3 0x0000555555b70e17 in object_property_set ( obj=3Dobj@entry=3D0x555557de5120, name=3Dname@entry=3D0x555555db99ff "realized", v=3Dv@entry=3D0x7ffdd8035040, errp=3Derrp@entry=3D0x5555565bbf38 ) at ../qom/object.c:1400 #4 0x0000555555b73c6f in object_property_set_qobject ( obj=3Dobj@entry=3D0x555557de5120, name=3Dname@entry=3D0x555555db99ff "realized", value=3Dvalue@entry=3D0x7ffdd8035020, errp=3Derrp@entry=3D0x5555565bbf38 ) at ../qom/qom-qobject.c:28 #5 0x0000555555b71054 in object_property_set_bool ( obj=3D0x555557de5120, name=3Dname@entry=3D0x555555db99ff "realized", value=3Dvalue@entry=3Dfalse, errp=3D0x5555565bbf38 ) at ../qom/object.c:1470 #6 0x0000555555b4edc5 in qdev_unrealize (dev=3D) at ../hw/core/qdev.c:403 #7 0x0000555555b4c2a9 in bus_set_realized (obj=3D, value=3D, errp=3D) at ../hw/core/bus.c:204 #8 0x0000555555b6eab6 in property_set_bool (obj=3D0x555557de5098, v=3D, name=3D, opaque=3D0x555557df04c0, errp=3D0x7fffee28e0a0) at ../qom/object.c:2255 #9 0x0000555555b70e17 in object_property_set ( obj=3Dobj@entry=3D0x555557de5098, name=3Dname@entry=3D0x555555db99ff "realized", v=3Dv@entry=3D0x7ffdd8034f50, errp=3Derrp@entry=3D0x5555565bbf38 ) at ../qom/object.c:1400 #10 0x0000555555b73c6f in object_property_set_qobject ( obj=3Dobj@entry=3D0x555557de5098, name=3Dname@entry=3D0x555555db99ff "realized", value=3Dvalue@entry=3D0x7ffdd8020630, errp=3Derrp@entry=3D0x5555565bbf38 ) at ../qom/qom-qobject.c:28 #11 0x0000555555b71054 in object_property_set_bool ( obj=3Dobj@entry=3D0x555557de5098, name=3Dname@entry=3D0x555555db99ff "realized", value=3Dvalue@entry=3Dfalse, errp=3D0x5555565bbf38 ) at ../qom/object.c:1470 #12 0x0000555555b4c725 in qbus_unrealize ( bus=3Dbus@entry=3D0x555557de5098) at ../hw/core/bus.c:178 #13 0x0000555555b4fc00 in device_set_realized (obj=3D0x555557ddcf90, value=3D, errp=3D0x7fffee28e1e0) at ../hw/core/qdev.c:844 #14 0x0000555555b6eab6 in property_set_bool (obj=3D0x555557ddcf90, v=3D, name=3D, opaque=3D0x555556650ba0, errp=3D0x7fffee28e1e0) at ../qom/object.c:2255 #15 0x0000555555b70e17 in object_property_set ( obj=3Dobj@entry=3D0x555557ddcf90, name=3Dname@entry=3D0x555555db99ff "realized", v=3Dv@entry=3D0x7ffdd8020560, errp=3Derrp@entry=3D0x5555565bbf38 ) at ../qom/object.c:1400 #16 0x0000555555b73c6f in object_property_set_qobject ( obj=3Dobj@entry=3D0x555557ddcf90, name=3Dname@entry=3D0x555555db99ff "realized", value=3Dvalue@entry=3D0x7ffdd8020540, errp=3Derrp@entry=3D0x5555565bbf38 ) at ../qom/qom-qobject.c:28 #17 0x0000555555b71054 in object_property_set_bool ( obj=3D0x555557ddcf90, name=3D0x555555db99ff "realized", value=3D, errp=3D0x5555565bbf38 ) at ../qom/object.c:1470 #18 0x0000555555921cb7 in pcie_unplug_device (bus=3D, dev=3D0x555557ddcf90, opaque=3D) at /home/qemu/include/hw/qdev-core.h:17 #19 0x00005555558dc331 in pci_for_each_device_under_bus ( opaque=3D, fn=3D, bus=3D) at ../hw/pci/pci.c:1654 Fixes: c611c76417f ("virtio: add MemoryListener to cache ring translations") Buglink: https://bugs.launchpad.net/qemu/+bug/1912846 Signed-off-by: Eugenio P=C3=A9rez Message-Id: <20210125192505.390554-1-eperezma@redhat.com> Reviewed-by: Peter Xu Acked-by: Jason Wang Reviewed-by: Stefano Garzarella Reviewed-by: Michael S. Tsirkin Signed-off-by: Michael S. Tsirkin --- hw/virtio/virtio.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/hw/virtio/virtio.c b/hw/virtio/virtio.c index b308026596..1fd1917ca0 100644 --- a/hw/virtio/virtio.c +++ b/hw/virtio/virtio.c @@ -3680,6 +3680,7 @@ static void virtio_device_unrealize(DeviceState *dev) VirtIODevice *vdev =3D VIRTIO_DEVICE(dev); VirtioDeviceClass *vdc =3D VIRTIO_DEVICE_GET_CLASS(dev); =20 + memory_listener_unregister(&vdev->listener); virtio_bus_device_unplugged(vdev); =20 if (vdc->unrealize !=3D NULL) { @@ -3710,7 +3711,6 @@ static void virtio_device_instance_finalize(Object *o= bj) { VirtIODevice *vdev =3D VIRTIO_DEVICE(obj); =20 - memory_listener_unregister(&vdev->listener); virtio_device_free_virtqueues(vdev); =20 g_free(vdev->config); --=20 MST From nobody Sun Feb 8 09:27:42 2026 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=fail; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=fail(p=none dis=none) header.from=redhat.com ARC-Seal: i=1; a=rsa-sha256; t=1612540418; cv=none; d=zohomail.com; s=zohoarc; b=jN34V+z2z9jSlVkUCodKOeheRXC1RBM86Amza6y+5veaXcN4mUuJ70leMGYOp5/Jj7FOj7GEOB+sH9Pk5pWNdrmYoR+tcWxV5P/nQofQSOcPYkDtiY0xD3hq1O9YYn+ZMgOsKI9X5ClpmBzDkZ5ri/333PXSniuQMmmPANnUVCM= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1612540418; h=Content-Type:Cc:Date:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:To; bh=Ex128HceN3mgOxe1pMJ75smnNXZzBNmTC/eidh1FHnU=; b=G0dAhcXb3R5nbw4H4C6tFDupavYnuUs6oFOVxavJe/OulfwQs7i8Ndr7SEpd+0hSp2/xfCErOjeARUpLaqp+VolXmQDvvYCGaMMR5tB8wW+W+v9tGAGe3OFOfYlc7juVLKO/sV3H8H8xfXIhQ6RgJTTTVQ0xxUnZITdrClNDa6g= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=fail; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=fail header.from= (p=none dis=none) header.from= Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1612540418863296.0724016651494; Fri, 5 Feb 2021 07:53:38 -0800 (PST) Received: from localhost ([::1]:33134 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1l82nb-0005sp-4K for importer@patchew.org; Fri, 05 Feb 2021 10:13:31 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]:47836) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1l82eJ-0003on-WC for qemu-devel@nongnu.org; Fri, 05 Feb 2021 10:03:56 -0500 Received: from us-smtp-delivery-124.mimecast.com ([63.128.21.124]:60780) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA1:256) (Exim 4.90_1) (envelope-from ) id 1l82eI-0002xl-3T for qemu-devel@nongnu.org; Fri, 05 Feb 2021 10:03:55 -0500 Received: from mail-ej1-f71.google.com (mail-ej1-f71.google.com [209.85.218.71]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-316-ARB0f4D3MzWTUbpOdSUPwA-1; Fri, 05 Feb 2021 10:03:50 -0500 Received: by mail-ej1-f71.google.com with SMTP id q11so6944242ejd.0 for ; Fri, 05 Feb 2021 07:03:50 -0800 (PST) Received: from redhat.com (bzq-79-180-2-31.red.bezeqint.net. [79.180.2.31]) by smtp.gmail.com with ESMTPSA id p12sm4247913edr.82.2021.02.05.07.03.47 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 05 Feb 2021 07:03:48 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1612537433; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=Ex128HceN3mgOxe1pMJ75smnNXZzBNmTC/eidh1FHnU=; b=DZQPfoDgMVDDAtQJDuCmV5VrJOLjehQ+JDkhvky4a/Yp9SEd3XZxQP1gxdcoFjrSHFqZmu bWJlY0tXyB0rAgYyY6Z26wPpZmIieVtr/9F1NqGpSU2UCxdDLfjXHLYU2kL2VblWSQdmib Kh8vr6lTi074J1FJptoL1HeOh6Mdewg= X-MC-Unique: ARB0f4D3MzWTUbpOdSUPwA-1 X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=Ex128HceN3mgOxe1pMJ75smnNXZzBNmTC/eidh1FHnU=; b=BhtmbmunX45HwdVjFobzwQkF/8IosmEb/7fA8Qs7URJ+QKKQCFPeQE9AZqhmvIL7fc +D+17jDt++3FmnTjz8JSBnsIr/PCWS4cyZzjRsbraIu60n6i8qHgeWlsdLs7QKwtvuHP AyNnVKq8ESKCcM2RYXd8D7Wub3pflNp25lPuJH5oljsikJHA8FbhjTvS6uc99PPxRxSF TCVU+aPr2LoGx5rhLZAiHUjpnA+9X4wx7ezNpnd+h27arhNPo6/w4C7/qeOb1mys7luO QLoxxyD7AsgmFFpfLHGt+MoFwI+pIFPTqmrAd9tU3roQBTa5T5gNNWwN9kE9LKg3IT1T xiCg== X-Gm-Message-State: AOAM5327JGrG3LkOJxzwMY9/In3qAIg3AXMV6o3wSCrlibuuLfQHPXNT AjFBB+MJ3k6wy+0ZzwoVjLVWxFheWmbcpMyFT7U/E6hnOvA49IMZpTgAyDhyJaJqYPsKtJQe/Hu 2UWHJr1RmUGDYgk+WUWZu5pHB27faaZHb98v8Urz6S//PIp5b4TnpnB16saU8 X-Received: by 2002:a17:906:a153:: with SMTP id bu19mr4531044ejb.287.1612537429193; Fri, 05 Feb 2021 07:03:49 -0800 (PST) X-Google-Smtp-Source: ABdhPJyw+OKGpSNtQIJPA589Bj9+HbYzp0n/3kkZ2ShNA6atoKLuf2m9nE78gj2TldRVGp1/cnPcJA== X-Received: by 2002:a17:906:a153:: with SMTP id bu19mr4531020ejb.287.1612537429021; Fri, 05 Feb 2021 07:03:49 -0800 (PST) Date: Fri, 5 Feb 2021 10:03:46 -0500 From: "Michael S. Tsirkin" To: qemu-devel@nongnu.org Subject: [PULL v2 06/16] virtio-pmem: add trace events Message-ID: <20210205150135.94643-7-mst@redhat.com> References: <20210205150135.94643-1-mst@redhat.com> MIME-Version: 1.0 In-Reply-To: <20210205150135.94643-1-mst@redhat.com> X-Mailer: git-send-email 2.27.0.106.g8ac3dc51b1 X-Mutt-Fcc: =sent Authentication-Results: relay.mimecast.com; auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=mst@redhat.com X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Disposition: inline Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Received-SPF: pass client-ip=63.128.21.124; envelope-from=mst@redhat.com; helo=us-smtp-delivery-124.mimecast.com X-Spam_score_int: -30 X-Spam_score: -3.1 X-Spam_bar: --- X-Spam_report: (-3.1 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.352, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_LOW=-0.7, RCVD_IN_MSPIKE_H4=0.001, RCVD_IN_MSPIKE_WL=0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Peter Maydell , David Hildenbrand , Pankaj Gupta Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: "Qemu-devel" X-ZohoMail-DKIM: fail (Header signature does not verify) Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" From: Pankaj Gupta This patch adds trace events for virtio-pmem functionality. Adding trace events for virtio pmem request, reponse and host side fsync functionality. Signed-off-by: Pankaj Gupta Message-Id: <20201117115705.32195-1-pankaj.gupta.linux@gmail.com> Reviewed-by: David Hildenbrand Reviewed-by: Michael S. Tsirkin Signed-off-by: Michael S. Tsirkin --- hw/virtio/virtio-pmem.c | 4 ++++ hw/virtio/trace-events | 5 +++++ 2 files changed, 9 insertions(+) diff --git a/hw/virtio/virtio-pmem.c b/hw/virtio/virtio-pmem.c index ddb0125901..d83e973bf2 100644 --- a/hw/virtio/virtio-pmem.c +++ b/hw/virtio/virtio-pmem.c @@ -24,6 +24,7 @@ #include "sysemu/hostmem.h" #include "block/aio.h" #include "block/thread-pool.h" +#include "trace.h" =20 typedef struct VirtIODeviceRequest { VirtQueueElement elem; @@ -41,6 +42,7 @@ static int worker_cb(void *opaque) =20 /* flush raw backing image */ err =3D fsync(req_data->fd); + trace_virtio_pmem_flush_done(err); if (err !=3D 0) { err =3D 1; } @@ -59,6 +61,7 @@ static void done_cb(void *opaque, int ret) /* Callbacks are serialized, so no need to use atomic ops. */ virtqueue_push(req_data->pmem->rq_vq, &req_data->elem, len); virtio_notify((VirtIODevice *)req_data->pmem, req_data->pmem->rq_vq); + trace_virtio_pmem_response(); g_free(req_data); } =20 @@ -69,6 +72,7 @@ static void virtio_pmem_flush(VirtIODevice *vdev, VirtQue= ue *vq) HostMemoryBackend *backend =3D MEMORY_BACKEND(pmem->memdev); ThreadPool *pool =3D aio_get_thread_pool(qemu_get_aio_context()); =20 + trace_virtio_pmem_flush_request(); req_data =3D virtqueue_pop(vq, sizeof(VirtIODeviceRequest)); if (!req_data) { virtio_error(vdev, "virtio-pmem missing request data"); diff --git a/hw/virtio/trace-events b/hw/virtio/trace-events index 2060a144a2..c62727f879 100644 --- a/hw/virtio/trace-events +++ b/hw/virtio/trace-events @@ -122,3 +122,8 @@ virtio_mem_unplug_all_request(void) "" virtio_mem_resized_usable_region(uint64_t old_size, uint64_t new_size) "ol= d_size=3D0x%" PRIx64 "new_size=3D0x%" PRIx64 virtio_mem_state_request(uint64_t addr, uint16_t nb_blocks) "addr=3D0x%" P= RIx64 " nb_blocks=3D%" PRIu16 virtio_mem_state_response(uint16_t state) "state=3D%" PRIu16 + +# virtio-pmem.c +virtio_pmem_flush_request(void) "flush request" +virtio_pmem_response(void) "flush response" +virtio_pmem_flush_done(int type) "fsync return=3D%d" --=20 MST From nobody Sun Feb 8 09:27:42 2026 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=fail; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=fail(p=none dis=none) header.from=redhat.com ARC-Seal: i=1; a=rsa-sha256; t=1612541827; cv=none; d=zohomail.com; s=zohoarc; b=CIScVfVxYvVdc7uo4VuX45VDHOuuIkWiJYlzKnZ/GZBi9QLvC8GQjfivItFB3Q6E5Aifgi+ZqKJTeK41ByjiLa4zTqiuF0ogJeruAvMLhVwvUY0A9Gx2ZFiihrJQ6u63b0gZV+3jnndCrnoH9zZ73uFo14HPlEx11XgJbI+dcTg= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1612541827; h=Content-Type:Cc:Date:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:To; bh=RQw4PPJyzBWUqKR3ig2k+999cJ/UQSQvrggksmcciUE=; b=bYaDMBkEbLXduxu71pSxT4+LLRzD/u8ZzzKwjpmrAPQ4S70Hseqs9Y28RICY6OdHIxMAhP6PdWwo6s+nhfYQaq3vTgkNiJMYtOemQjGLeId+JNPRc62lUYTkg/UE8o98VI+mnKUWEXs4OGIHh7yDpSLM0JlvyM/T3OHl+k58I2I= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=fail; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=fail header.from= (p=none dis=none) header.from= Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1612541827677450.851392780374; Fri, 5 Feb 2021 08:17:07 -0800 (PST) Received: from localhost ([::1]:54238 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1l82ls-0002w5-Gj for importer@patchew.org; Fri, 05 Feb 2021 10:11:44 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]:47856) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1l82eL-0003sj-QT for qemu-devel@nongnu.org; Fri, 05 Feb 2021 10:03:57 -0500 Received: from us-smtp-delivery-124.mimecast.com ([216.205.24.124]:48733) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA1:256) (Exim 4.90_1) (envelope-from ) id 1l82eJ-0002yH-PW for qemu-devel@nongnu.org; Fri, 05 Feb 2021 10:03:57 -0500 Received: from mail-ej1-f71.google.com (mail-ej1-f71.google.com [209.85.218.71]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-551-BZ8RAwWCPoOupa_7JfaU7w-1; Fri, 05 Feb 2021 10:03:53 -0500 Received: by mail-ej1-f71.google.com with SMTP id yh28so6907825ejb.11 for ; Fri, 05 Feb 2021 07:03:53 -0800 (PST) Received: from redhat.com (bzq-79-180-2-31.red.bezeqint.net. [79.180.2.31]) by smtp.gmail.com with ESMTPSA id m22sm4061844edp.63.2021.02.05.07.03.50 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 05 Feb 2021 07:03:51 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1612537435; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=RQw4PPJyzBWUqKR3ig2k+999cJ/UQSQvrggksmcciUE=; b=apagqEsHQiJhQExEgUKNrB9r1mlsiWEzomrX8jyDz7HD+dIMFR87FiqLdcCXApuIRjwMQo 8xWzTaDIQeeRjB/miEmd7HeYxTx7iFjY8h16HUvRUYJP373NPtHJbBQMQurDbetJbSxyD4 f1VSosvqDWKoui3mDmzm4kM+8qNnHdk= X-MC-Unique: BZ8RAwWCPoOupa_7JfaU7w-1 X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=RQw4PPJyzBWUqKR3ig2k+999cJ/UQSQvrggksmcciUE=; b=D+T/I4ebX3R9ZLl2lHf+sYkV+q4t/nQOTJ/VXwM32hHstbsNOfnVaexi4ABImpV0KX nXxCWk3XUYcik5XSspLBI9N/PqRymuKTjbOEGQs6vKIAdvHFBvD6D2qcDs7391BN0Xtn nqa4TPKmBuI4yKqGD1jFmCLvq7v+ni0uhrv3UOX6J97/W3T+0CyGHzlBEmn94+0M7Yvy JFej/RStRuSrfFUshIPmkAZE4F6QwND+tDwtYxEqkiiPqNo6jHpewLv3CRUwFtgrNED6 lUUsvEyAL8KEmSfFGI8myQO9L3ReijkTJ8AUBb/GizRlCf0PPq8EJQUYMuN4otNAbYUH Y0Ng== X-Gm-Message-State: AOAM531teJieCyI1d5W4BbsHG4nv4dId8XsdNv0Kx9tn3ycUhnyS4edD 6gFxKqU6r3ey56A28h/xwb7DOiECN4DTYWWIuyl/B6+uXxxdeXYUzidzfo1Vmw6JYalfSRh6wF7 77nYulPDTf7287Ngqv8AY7LB5NCiho6XnT7/d2G/OjTpXGXWXSv5ANurXiUYx X-Received: by 2002:a17:906:3b04:: with SMTP id g4mr4431688ejf.369.1612537431899; Fri, 05 Feb 2021 07:03:51 -0800 (PST) X-Google-Smtp-Source: ABdhPJzS8oDKSrc+XpyFTOvNYLmAqaUzK15IQfYaXJ0ABli7xM8XeSg5XfRM1mEsZ589t7266zEkSQ== X-Received: by 2002:a17:906:3b04:: with SMTP id g4mr4431662ejf.369.1612537431711; Fri, 05 Feb 2021 07:03:51 -0800 (PST) Date: Fri, 5 Feb 2021 10:03:49 -0500 From: "Michael S. Tsirkin" To: qemu-devel@nongnu.org Subject: [PULL v2 07/16] vhost: Unbreak SMMU and virtio-iommu on dev-iotlb support Message-ID: <20210205150135.94643-8-mst@redhat.com> References: <20210205150135.94643-1-mst@redhat.com> MIME-Version: 1.0 In-Reply-To: <20210205150135.94643-1-mst@redhat.com> X-Mailer: git-send-email 2.27.0.106.g8ac3dc51b1 X-Mutt-Fcc: =sent Authentication-Results: relay.mimecast.com; auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=mst@redhat.com X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Disposition: inline Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Received-SPF: pass client-ip=216.205.24.124; envelope-from=mst@redhat.com; helo=us-smtp-delivery-124.mimecast.com X-Spam_score_int: -30 X-Spam_score: -3.1 X-Spam_bar: --- X-Spam_report: (-3.1 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.352, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_LOW=-0.7, RCVD_IN_MSPIKE_H3=0.001, RCVD_IN_MSPIKE_WL=0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Peter Maydell , qemu-arm@nongnu.org, Peter Xu , Eric Auger Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: "Qemu-devel" X-ZohoMail-DKIM: fail (Header signature does not verify) Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" From: Peter Xu Previous work on dev-iotlb message broke vhost on either SMMU or virtio-iom= mu since dev-iotlb (or PCIe ATS) is not yet supported for those archs. An initial idea is that we can let IOMMU to export this information to vhos= t so that vhost would know whether the vIOMMU would support dev-iotlb, then vhost can conditionally register to dev-iotlb or the old iotlb way. We can work based on some previous patch to introduce PCIIOMMUOps as Yi Liu proposed [1= ]. However it's not as easy as I thought since vhost_iommu_region_add() does n= ot have a PCIDevice context at all since it's completely a backend. It seems non-trivial to pass over a PCI device to the backend during init. E.g. when the IOMMU notifier registered hdev->vdev is still NULL. To make the fix smaller and easier, this patch goes the other way to levera= ge the flag_changed() hook of vIOMMUs so that SMMU and virtio-iommu can trap t= he dev-iotlb registration and fail it. Then vhost could try the fallback solu= tion as using UNMAP invalidation for it's translations. [1] https://lore.kernel.org/qemu-devel/1599735398-6829-4-git-send-email-yi.= l.liu@intel.com/ Reported-by: Eric Auger Fixes: b68ba1ca57677acf870d5ab10579e6105c1f5338 Reviewed-by: Eric Auger Tested-by: Eric Auger Signed-off-by: Peter Xu Message-Id: <20210204191228.187550-1-peterx@redhat.com> Reviewed-by: Michael S. Tsirkin Signed-off-by: Michael S. Tsirkin --- hw/arm/smmuv3.c | 5 +++++ hw/virtio/vhost.c | 13 +++++++++++-- hw/virtio/virtio-iommu.c | 5 +++++ 3 files changed, 21 insertions(+), 2 deletions(-) diff --git a/hw/arm/smmuv3.c b/hw/arm/smmuv3.c index 98b99d4fe8..bd1f97000d 100644 --- a/hw/arm/smmuv3.c +++ b/hw/arm/smmuv3.c @@ -1497,6 +1497,11 @@ static int smmuv3_notify_flag_changed(IOMMUMemoryReg= ion *iommu, SMMUv3State *s3 =3D sdev->smmu; SMMUState *s =3D &(s3->smmu_state); =20 + if (new & IOMMU_NOTIFIER_DEVIOTLB_UNMAP) { + error_setg(errp, "SMMUv3 does not support dev-iotlb yet"); + return -EINVAL; + } + if (new & IOMMU_NOTIFIER_MAP) { error_setg(errp, "device %02x.%02x.%x requires iommu MAP notifier which = is " diff --git a/hw/virtio/vhost.c b/hw/virtio/vhost.c index 28c7d78172..6e17d631f7 100644 --- a/hw/virtio/vhost.c +++ b/hw/virtio/vhost.c @@ -704,6 +704,7 @@ static void vhost_iommu_region_add(MemoryListener *list= ener, Int128 end; int iommu_idx; IOMMUMemoryRegion *iommu_mr; + int ret; =20 if (!memory_region_is_iommu(section->mr)) { return; @@ -726,8 +727,16 @@ static void vhost_iommu_region_add(MemoryListener *lis= tener, iommu->iommu_offset =3D section->offset_within_address_space - section->offset_within_region; iommu->hdev =3D dev; - memory_region_register_iommu_notifier(section->mr, &iommu->n, - &error_fatal); + ret =3D memory_region_register_iommu_notifier(section->mr, &iommu->n, = NULL); + if (ret) { + /* + * Some vIOMMUs do not support dev-iotlb yet. If so, try to use t= he + * UNMAP legacy message + */ + iommu->n.notifier_flags =3D IOMMU_NOTIFIER_UNMAP; + memory_region_register_iommu_notifier(section->mr, &iommu->n, + &error_fatal); + } QLIST_INSERT_HEAD(&dev->iommu_list, iommu, iommu_next); /* TODO: can replay help performance here? */ } diff --git a/hw/virtio/virtio-iommu.c b/hw/virtio/virtio-iommu.c index 6b9ef7f6b2..c2883a2f6c 100644 --- a/hw/virtio/virtio-iommu.c +++ b/hw/virtio/virtio-iommu.c @@ -893,6 +893,11 @@ static int virtio_iommu_notify_flag_changed(IOMMUMemor= yRegion *iommu_mr, IOMMUNotifierFlag new, Error **errp) { + if (new & IOMMU_NOTIFIER_DEVIOTLB_UNMAP) { + error_setg(errp, "Virtio-iommu does not support dev-iotlb yet"); + return -EINVAL; + } + if (old =3D=3D IOMMU_NOTIFIER_NONE) { trace_virtio_iommu_notify_flag_add(iommu_mr->parent_obj.name); } else if (new =3D=3D IOMMU_NOTIFIER_NONE) { --=20 MST From nobody Sun Feb 8 09:27:42 2026 Delivered-To: importer@patchew.org Received-SPF: pass (zohomail.com: domain of redhat.com designates 170.10.133.124 as permitted sender) client-ip=170.10.133.124; envelope-from=libvir-list-bounces@redhat.com; helo=us-smtp-delivery-124.mimecast.com; Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of redhat.com designates 170.10.133.124 as permitted sender) smtp.mailfrom=libvir-list-bounces@redhat.com; dmarc=pass(p=none dis=none) header.from=redhat.com ARC-Seal: i=1; a=rsa-sha256; t=1612537745; cv=none; d=zohomail.com; s=zohoarc; b=ExJgVJI8CFgM5Chj8dv+u644Tp0wlJW41zijs4QcRppjERw1N2a/Ej2y0RqHFDfHruvM7y0a4pq931arkyoVN7YXqEaGoXXo6DHNtRKjjLBOpyF3nzdDto1a5EBKwXmt7XqpJK1WeaKn/BtCGMh1rFYBRdJudc30XSxxyJ38nNk= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1612537745; h=Content-Type:Content-Transfer-Encoding:Cc:Date:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:To; bh=NQXW1/SZyEseosS3Pdw5NegFFGQKTt5n2ODFCN2dPLY=; b=UWWiIdSGPorlKxY280BGyQcaIp/73Nd2kmDfMW2Ocez9G5wxLxe+Tz2/smCSyVaKmzwu2Yyw1es3sS33NWQvgLazBK706Y5fbDpceNpvKh5c6dgPt1fUtu6feTqrszsUpEj5RtINQ+oe9XxVHROzOTab7mOuMrOesyALKPhKdN4= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of redhat.com designates 170.10.133.124 as permitted sender) smtp.mailfrom=libvir-list-bounces@redhat.com; dmarc=pass header.from= (p=none dis=none) header.from= Return-Path: Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by mx.zohomail.com with SMTPS id 1612537745571627.1692925015958; Fri, 5 Feb 2021 07:09:05 -0800 (PST) Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-22-wKEHoKSCMlqxOLNxINS6bg-1; Fri, 05 Feb 2021 10:09:00 -0500 Received: from smtp.corp.redhat.com (int-mx08.intmail.prod.int.phx2.redhat.com [10.5.11.23]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id B0D5380197B; Fri, 5 Feb 2021 15:08:54 +0000 (UTC) Received: from colo-mx.corp.redhat.com (colo-mx01.intmail.prod.int.phx2.redhat.com [10.5.11.20]) by smtp.corp.redhat.com (Postfix) with ESMTPS id E6B9A19712; Fri, 5 Feb 2021 15:08:53 +0000 (UTC) Received: from lists01.pubmisc.prod.ext.phx2.redhat.com (lists01.pubmisc.prod.ext.phx2.redhat.com [10.5.19.33]) by colo-mx.corp.redhat.com (Postfix) with ESMTP id 560E018095CB; Fri, 5 Feb 2021 15:08:53 +0000 (UTC) Received: from smtp.corp.redhat.com (int-mx06.intmail.prod.int.rdu2.redhat.com [10.11.54.6]) by lists01.pubmisc.prod.ext.phx2.redhat.com (8.13.8/8.13.8) with ESMTP id 115F7Bp5017714 for ; Fri, 5 Feb 2021 10:07:12 -0500 Received: by smtp.corp.redhat.com (Postfix) id CD51E2166B39; Fri, 5 Feb 2021 15:07:11 +0000 (UTC) Received: from mimecast-mx02.redhat.com (mimecast05.extmail.prod.ext.rdu2.redhat.com [10.11.55.21]) by smtp.corp.redhat.com (Postfix) with ESMTPS id C3A6A2166B34 for ; Fri, 5 Feb 2021 15:07:06 +0000 (UTC) Received: from us-smtp-1.mimecast.com (us-smtp-delivery-1.mimecast.com [205.139.110.120]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-SHA384 (256/256 bits)) (No client certificate requested) by mimecast-mx02.redhat.com (Postfix) with ESMTPS id 763CC80B926 for ; Fri, 5 Feb 2021 15:07:06 +0000 (UTC) Received: from mail-ed1-f70.google.com (mail-ed1-f70.google.com [209.85.208.70]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-239-FCjXzTO_MTe47PAJrxCYvw-1; Fri, 05 Feb 2021 10:03:56 -0500 Received: by mail-ed1-f70.google.com with SMTP id i4so7132583edt.11 for ; Fri, 05 Feb 2021 07:03:55 -0800 (PST) Received: from redhat.com (bzq-79-180-2-31.red.bezeqint.net. [79.180.2.31]) by smtp.gmail.com with ESMTPSA id ah20sm4000000ejc.99.2021.02.05.07.03.52 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 05 Feb 2021 07:03:54 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1612537744; h=from:from:sender:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:list-id:list-help: list-unsubscribe:list-subscribe:list-post; bh=NQXW1/SZyEseosS3Pdw5NegFFGQKTt5n2ODFCN2dPLY=; b=AwNHpoerQ4bnAD3q2Pp2z3yrfICa8Qr6gkU6UWmJ7WQLa/UlqjZ4uGzkM9ryJye8nygcVl HtcpKzWsw/RxnljFIm2KVo1EidkYWiLXsSjfsSrtWab+dVmMDdpGe64LhYv4gZ62wR/+sB Y1cVVkXRUyKoSf1e1Xt7qWG+0MciGsg= X-MC-Unique: wKEHoKSCMlqxOLNxINS6bg-1 X-MC-Unique: FCjXzTO_MTe47PAJrxCYvw-1 X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:content-transfer-encoding :in-reply-to; bh=NQXW1/SZyEseosS3Pdw5NegFFGQKTt5n2ODFCN2dPLY=; b=HOMRW+LTKwp5JeCq5mLmNOz6ENYW+vjFCfsTnw861sw59lWcVAsGigKtXwP5ewM7Ag a4yKU6qd8QpZvZG5PNtBQuf8/Oc/DblzctxOoDz4Xy1vejJze0whSNVka4yV2fhuMYK7 1ZKV4cw2ymPkv36r/LeCJ63Y15mipeTcHzqwSY5Ednc+yUK1c3y9IU66WQpFcYxazolz CHhCfVifwUbxISw21z0fQL25/vjUX/vpMvPf8uHFhhDqQEjyE49XvB8XFPViTrSpG6Qc F+aXKZyuhuX05IiGezyrllHQEHvKXLZzvOJvBmKEuKWjCUhjK9pgeA0kgbsBYz9VcoLH LmNA== X-Gm-Message-State: AOAM531Czi8tWieAiySjDlrUdl4OOHeuFUb5AoAuWjl6NjLzvrwRNHvR oUSFFMdPBSM7kty2gt+ByGEEsjYWKzr9E5//XF3FvVGBbKlmtPmVe9s4hjPaEsP9Lv0o2PrfHKl Oo8Soj9NbM4fMJ5YG68E= X-Received: by 2002:a17:906:4c4b:: with SMTP id d11mr4426759ejw.387.1612537434877; Fri, 05 Feb 2021 07:03:54 -0800 (PST) X-Google-Smtp-Source: ABdhPJyQ6wGeqSOagw/8jmeSUqXi7g60Csz3C+pzWJ5D17OzyTpAM9E3fBhB026TdXEUPdMqpna/RA== X-Received: by 2002:a17:906:4c4b:: with SMTP id d11mr4426733ejw.387.1612537434710; Fri, 05 Feb 2021 07:03:54 -0800 (PST) Date: Fri, 5 Feb 2021 10:03:51 -0500 From: "Michael S. Tsirkin" To: qemu-devel@nongnu.org Subject: [PULL v2 08/16] hw/i386: Remove the deprecated pc-1.x machine types Message-ID: <20210205150135.94643-9-mst@redhat.com> References: <20210205150135.94643-1-mst@redhat.com> MIME-Version: 1.0 In-Reply-To: <20210205150135.94643-1-mst@redhat.com> X-Mutt-Fcc: =sent X-Scanned-By: MIMEDefang 2.78 on 10.11.54.6 X-loop: libvir-list@redhat.com Cc: Peter Maydell , Thomas Huth , Eduardo Habkost , libvir-list@redhat.com, Richard Henderson , Marcel Apfelbaum , Paolo Bonzini X-BeenThere: libvir-list@redhat.com X-Mailman-Version: 2.1.12 Precedence: junk List-Id: Development discussions about the libvirt library & tools List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: libvir-list-bounces@redhat.com Errors-To: libvir-list-bounces@redhat.com X-Scanned-By: MIMEDefang 2.84 on 10.5.11.23 Authentication-Results: relay.mimecast.com; auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=libvir-list-bounces@redhat.com X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset="utf-8" Content-Disposition: inline Content-Transfer-Encoding: quoted-printable X-ZohoMail-DKIM: pass (identity @redhat.com) From: Thomas Huth They have been deprecated since QEMU v5.0, time to remove them now. Signed-off-by: Thomas Huth Message-Id: <20210203171832.483176-2-thuth@redhat.com> Reviewed-by: Michael S. Tsirkin Signed-off-by: Michael S. Tsirkin Reviewed-by: Daniel P. Berrang=C3=A9 --- hw/i386/pc_piix.c | 94 -------------------------------- docs/system/deprecated.rst | 6 -- docs/system/removed-features.rst | 6 ++ 3 files changed, 6 insertions(+), 100 deletions(-) diff --git a/hw/i386/pc_piix.c b/hw/i386/pc_piix.c index 6188c3e97e..2904b40163 100644 --- a/hw/i386/pc_piix.c +++ b/hw/i386/pc_piix.c @@ -359,18 +359,6 @@ static void pc_compat_1_4_fn(MachineState *machine) pc_compat_1_5_fn(machine); } =20 -static void pc_compat_1_3(MachineState *machine) -{ - pc_compat_1_4_fn(machine); -} - -/* PC compat function for pc-1.0 to pc-1.2 */ -static void pc_compat_1_2(MachineState *machine) -{ - pc_compat_1_3(machine); - x86_cpu_change_kvm_default("kvm-pv-eoi", NULL); -} - static void pc_init_isa(MachineState *machine) { pc_init1(machine, TYPE_I440FX_PCI_HOST_BRIDGE, TYPE_I440FX_PCI_DEVICE); @@ -772,88 +760,6 @@ static void pc_i440fx_1_4_machine_options(MachineClass= *m) DEFINE_I440FX_MACHINE(v1_4, "pc-i440fx-1.4", pc_compat_1_4_fn, pc_i440fx_1_4_machine_options); =20 -static void pc_i440fx_1_3_machine_options(MachineClass *m) -{ - X86MachineClass *x86mc =3D X86_MACHINE_CLASS(m); - static GlobalProperty compat[] =3D { - PC_CPU_MODEL_IDS("1.3.0") - { "usb-tablet", "usb_version", "1" }, - { "virtio-net-pci", "ctrl_mac_addr", "off" }, - { "virtio-net-pci", "mq", "off" }, - { "e1000", "autonegotiation", "off" }, - }; - - pc_i440fx_1_4_machine_options(m); - m->hw_version =3D "1.3.0"; - m->deprecation_reason =3D "use a newer machine type instead"; - x86mc->compat_apic_id_mode =3D true; - compat_props_add(m->compat_props, compat, G_N_ELEMENTS(compat)); -} - -DEFINE_I440FX_MACHINE(v1_3, "pc-1.3", pc_compat_1_3, - pc_i440fx_1_3_machine_options); - - -static void pc_i440fx_1_2_machine_options(MachineClass *m) -{ - static GlobalProperty compat[] =3D { - PC_CPU_MODEL_IDS("1.2.0") - { "nec-usb-xhci", "msi", "off" }, - { "nec-usb-xhci", "msix", "off" }, - { "qxl", "revision", "3" }, - { "qxl-vga", "revision", "3" }, - { "VGA", "mmio", "off" }, - }; - - pc_i440fx_1_3_machine_options(m); - m->hw_version =3D "1.2.0"; - compat_props_add(m->compat_props, compat, G_N_ELEMENTS(compat)); -} - -DEFINE_I440FX_MACHINE(v1_2, "pc-1.2", pc_compat_1_2, - pc_i440fx_1_2_machine_options); - - -static void pc_i440fx_1_1_machine_options(MachineClass *m) -{ - static GlobalProperty compat[] =3D { - PC_CPU_MODEL_IDS("1.1.0") - { "virtio-scsi-pci", "hotplug", "off" }, - { "virtio-scsi-pci", "param_change", "off" }, - { "VGA", "vgamem_mb", "8" }, - { "vmware-svga", "vgamem_mb", "8" }, - { "qxl-vga", "vgamem_mb", "8" }, - { "qxl", "vgamem_mb", "8" }, - { "virtio-blk-pci", "config-wce", "off" }, - }; - - pc_i440fx_1_2_machine_options(m); - m->hw_version =3D "1.1.0"; - compat_props_add(m->compat_props, compat, G_N_ELEMENTS(compat)); -} - -DEFINE_I440FX_MACHINE(v1_1, "pc-1.1", pc_compat_1_2, - pc_i440fx_1_1_machine_options); - -static void pc_i440fx_1_0_machine_options(MachineClass *m) -{ - static GlobalProperty compat[] =3D { - PC_CPU_MODEL_IDS("1.0") - { TYPE_ISA_FDC, "check_media_rate", "off" }, - { "virtio-balloon-pci", "class", stringify(PCI_CLASS_MEMORY_RAM) }, - { "apic-common", "vapic", "off" }, - { TYPE_USB_DEVICE, "full-path", "no" }, - }; - - pc_i440fx_1_1_machine_options(m); - m->hw_version =3D "1.0"; - compat_props_add(m->compat_props, compat, G_N_ELEMENTS(compat)); -} - -DEFINE_I440FX_MACHINE(v1_0, "pc-1.0", pc_compat_1_2, - pc_i440fx_1_0_machine_options); - - typedef struct { uint16_t gpu_device_id; uint16_t pch_device_id; diff --git a/docs/system/deprecated.rst b/docs/system/deprecated.rst index 6ac757ed9f..2fcac7861e 100644 --- a/docs/system/deprecated.rst +++ b/docs/system/deprecated.rst @@ -322,12 +322,6 @@ The 'scsi-disk' device is deprecated. Users should use= 'scsi-hd' or System emulator machines ------------------------ =20 -``pc-1.0``, ``pc-1.1``, ``pc-1.2`` and ``pc-1.3`` (since 5.0) -''''''''''''''''''''''''''''''''''''''''''''''''''''''''''''' - -These machine types are very old and likely can not be used for live migra= tion -from old QEMU versions anymore. A newer machine type should be used instea= d. - Raspberry Pi ``raspi2`` and ``raspi3`` machines (since 5.2) ''''''''''''''''''''''''''''''''''''''''''''''''''''''''''' =20 diff --git a/docs/system/removed-features.rst b/docs/system/removed-feature= s.rst index 88b81a6156..c8481cafbd 100644 --- a/docs/system/removed-features.rst +++ b/docs/system/removed-features.rst @@ -136,6 +136,12 @@ mips ``fulong2e`` machine alias (removed in 6.0) =20 This machine has been renamed ``fuloong2e``. =20 +``pc-1.0``, ``pc-1.1``, ``pc-1.2`` and ``pc-1.3`` (removed in 6.0) +'''''''''''''''''''''''''''''''''''''''''''''''''''''''''''''''''' + +These machine types were very old and likely could not be used for live +migration from old QEMU versions anymore. Use a newer machine type instead. + Related binaries ---------------- =20 --=20 MST From nobody Sun Feb 8 09:27:42 2026 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass(p=none dis=none) header.from=redhat.com ARC-Seal: i=1; a=rsa-sha256; t=1612542412; cv=none; d=zohomail.com; s=zohoarc; b=AQtoKUokrKwmXGXoblfqUgGmugVhKPxIqFAqu4v/EXJmvD39H5rOUltTP0EBrFHjCCJ1DgpqC0lBugGxpI/mWwXJhJ8dUztztN7W5/tyceWzV3HQ1FcvFzCK/6YSPeIdzHgFM9QheqJgByftgb3MJz1g6e1h/wA5MXZ4dQCcTAM= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1612542412; h=Content-Type:Cc:Date:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:To; bh=NM5gGdPhi2A0Xfk2U2Gp/inbSM/ee2Z72/b98qblcAQ=; b=RZOA1uIz8I1B/EV5Dc9liQ3615PCnqKDnS7zZgRiTv8dW4/EOn6wIoHvu58W56BVVHfCvdtqlgRUwEObWcTPr+QjNZyPDAO3DKnnDkEryhaUHckr7KotHZGYFuix02Ye6D/nPKFpeu/JePEJtjJp1PVaCHqZ7hvw/vrPV8jLcNk= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass header.from= (p=none dis=none) header.from= Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1612542412274173.93333608395767; Fri, 5 Feb 2021 08:26:52 -0800 (PST) Received: from localhost ([::1]:54910 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1l82mD-0003Cm-27 for importer@patchew.org; Fri, 05 Feb 2021 10:12:05 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]:48878) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1l82hS-0007HE-RT for qemu-devel@nongnu.org; Fri, 05 Feb 2021 10:07:11 -0500 Received: from us-smtp-delivery-124.mimecast.com ([216.205.24.124]:52545) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA1:256) (Exim 4.90_1) (envelope-from ) id 1l82hN-0004IV-8e for qemu-devel@nongnu.org; Fri, 05 Feb 2021 10:07:10 -0500 Received: from mail-ed1-f69.google.com (mail-ed1-f69.google.com [209.85.208.69]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-73-HESJU1FtN_CsJZN_k0Ewow-1; Fri, 05 Feb 2021 10:03:58 -0500 Received: by mail-ed1-f69.google.com with SMTP id l23so4453238edt.23 for ; Fri, 05 Feb 2021 07:03:58 -0800 (PST) Received: from redhat.com (bzq-79-180-2-31.red.bezeqint.net. [79.180.2.31]) by smtp.gmail.com with ESMTPSA id sb6sm3755295ejb.54.2021.02.05.07.03.55 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 05 Feb 2021 07:03:56 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1612537624; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=NM5gGdPhi2A0Xfk2U2Gp/inbSM/ee2Z72/b98qblcAQ=; b=YhvNGA3I3qTaKMefKJvarZtOtNT3K0aZXQMAbt1kHsXciE43jbcQwUYOYLV9Nf3bDFMFtA LfpwNYj43Mwp0r3vkyeD2BFnrlP5NS4Vg+cinAYhT4izhcafuaCYcTwBSH7ZfjKIzME7aQ /4wTgw1P1l27W7z9rVx1v5HhktmoJyE= X-MC-Unique: HESJU1FtN_CsJZN_k0Ewow-1 X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=NM5gGdPhi2A0Xfk2U2Gp/inbSM/ee2Z72/b98qblcAQ=; b=G2DeVMMAOwWhlHsWsK/S17nhlfINyQX2T9VxsOwv1cKm0pbVxlV2eh126dRUVgWJk2 P6MEbRwo/p21ijYNUz8cVLYSildqxJiRYnB2fPxA1lG50u1HhoYzlTEEa06MZpxcWGQQ Sdf0aemDxEGY0WFGmLkpuFPb69ecVDypswvh5XJGIU90She1WuRAVXi8Pun69Ej37sjg A9eJSTOKj/XwY0mukoB8xbP9prMRsyWVGEdXLkAGVZy7mpE+IMdYj2sfPj+ORkGG7PuH XWVLYTeaJdW6vDdb6xawJex4omlxeft0uFngyTATpqdDei/UeNK1TaQVTZ3niuAlIaI9 Vqrw== X-Gm-Message-State: AOAM531ThkY4AExFECW82gkBfpKwOJWvkq0L5tRSZU9eUKRe8mkEysPh aYMMPekjzIGvXR8yE/JEG/meWlbnrE1AkR/a0ofAPwgFwiNmueu9iaXM7h7Aa+JDqZrPjpVjs4W 6C6yZ/IJHPJuI0y60JPTr1k4D8ipYDQgIv3cGS7BYMK7rRIvunUIcrFOXVVvT X-Received: by 2002:a17:906:d189:: with SMTP id c9mr4533481ejz.36.1612537437445; Fri, 05 Feb 2021 07:03:57 -0800 (PST) X-Google-Smtp-Source: ABdhPJyFkKNbCT01jdx/jX7L40+CRAp4II9nQ02wxf9EHJPpNC5SkmJjQFpmIfk7Y9nOe5ST4JM+qw== X-Received: by 2002:a17:906:d189:: with SMTP id c9mr4533459ejz.36.1612537437238; Fri, 05 Feb 2021 07:03:57 -0800 (PST) Date: Fri, 5 Feb 2021 10:03:54 -0500 From: "Michael S. Tsirkin" To: qemu-devel@nongnu.org Subject: [PULL v2 09/16] hw/virtio/virtio-balloon: Remove the "class" property Message-ID: <20210205150135.94643-10-mst@redhat.com> References: <20210205150135.94643-1-mst@redhat.com> MIME-Version: 1.0 In-Reply-To: <20210205150135.94643-1-mst@redhat.com> X-Mailer: git-send-email 2.27.0.106.g8ac3dc51b1 X-Mutt-Fcc: =sent Authentication-Results: relay.mimecast.com; auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=mst@redhat.com X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Disposition: inline Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Received-SPF: pass client-ip=216.205.24.124; envelope-from=mst@redhat.com; helo=us-smtp-delivery-124.mimecast.com X-Spam_score_int: -30 X-Spam_score: -3.1 X-Spam_bar: --- X-Spam_report: (-3.1 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.352, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_LOW=-0.7, RCVD_IN_MSPIKE_H3=0.001, RCVD_IN_MSPIKE_WL=0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Peter Maydell , Thomas Huth , David Hildenbrand Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: "Qemu-devel" X-ZohoMail-DKIM: pass (identity @redhat.com) Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" From: Thomas Huth This property was only required for compatibility reasons in the pc-1.0 machine type and earlier. Now that these machine types have been removed, the property is not useful anymore. Signed-off-by: Thomas Huth Message-Id: <20210203171832.483176-4-thuth@redhat.com> Reviewed-by: Michael S. Tsirkin Signed-off-by: Michael S. Tsirkin Acked-by: David Hildenbrand --- hw/virtio/virtio-balloon-pci.c | 11 +---------- 1 file changed, 1 insertion(+), 10 deletions(-) diff --git a/hw/virtio/virtio-balloon-pci.c b/hw/virtio/virtio-balloon-pci.c index a2c5cc7207..79a3ba979a 100644 --- a/hw/virtio/virtio-balloon-pci.c +++ b/hw/virtio/virtio-balloon-pci.c @@ -34,21 +34,13 @@ struct VirtIOBalloonPCI { VirtIOPCIProxy parent_obj; VirtIOBalloon vdev; }; -static Property virtio_balloon_pci_properties[] =3D { - DEFINE_PROP_UINT32("class", VirtIOPCIProxy, class_code, 0), - DEFINE_PROP_END_OF_LIST(), -}; =20 static void virtio_balloon_pci_realize(VirtIOPCIProxy *vpci_dev, Error **e= rrp) { VirtIOBalloonPCI *dev =3D VIRTIO_BALLOON_PCI(vpci_dev); DeviceState *vdev =3D DEVICE(&dev->vdev); =20 - if (vpci_dev->class_code !=3D PCI_CLASS_OTHERS && - vpci_dev->class_code !=3D PCI_CLASS_MEMORY_RAM) { /* qemu < 1.1 */ - vpci_dev->class_code =3D PCI_CLASS_OTHERS; - } - + vpci_dev->class_code =3D PCI_CLASS_OTHERS; qdev_realize(vdev, BUS(&vpci_dev->bus), errp); } =20 @@ -59,7 +51,6 @@ static void virtio_balloon_pci_class_init(ObjectClass *kl= ass, void *data) PCIDeviceClass *pcidev_k =3D PCI_DEVICE_CLASS(klass); k->realize =3D virtio_balloon_pci_realize; set_bit(DEVICE_CATEGORY_MISC, dc->categories); - device_class_set_props(dc, virtio_balloon_pci_properties); pcidev_k->vendor_id =3D PCI_VENDOR_ID_REDHAT_QUMRANET; pcidev_k->device_id =3D PCI_DEVICE_ID_VIRTIO_BALLOON; pcidev_k->revision =3D VIRTIO_PCI_ABI_VERSION; --=20 MST From nobody Sun Feb 8 09:27:42 2026 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=fail; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=fail(p=none dis=none) header.from=redhat.com ARC-Seal: i=1; a=rsa-sha256; t=1612539635; cv=none; d=zohomail.com; s=zohoarc; b=M0tokBI30/6J1qlmfimr81iZAWMmD7pZBLgg/8O+RSNdj25S+HYMXOexrL4YkQDiFz6580CTiht8PMteWZwNZGoHFeoGqd6e6mb160lODkYvHZqWj8w+OQJbe7p+u2ts8bhVT0GLvmd7n6175HG9U5qWh3A+1nIMVY93cMwp6P8= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1612539635; h=Content-Type:Content-Transfer-Encoding:Cc:Date:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:To; bh=U4gtmotGyc4DgZ4L1F6rz2/tdPPpbSuNOqH2cuNj5uc=; b=XPpm/Yc2fZ1z32hI+FrhT2JzcC8y9EYAsHY5hhOqqI4hHCXhtwUtvX71XTAakZmzStcJ2nia9k1dBmiEwi5q+IEZi0hCZH7Lq7Xrm39owvqTMmKBp4r+jupqUw3IUT29LHgqya0acydYXphPC7LNuSMvWW2MZ0T+5CnNO6kaaqE= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=fail; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=fail header.from= (p=none dis=none) header.from= Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1612539635279426.70082151859685; Fri, 5 Feb 2021 07:40:35 -0800 (PST) Received: from localhost ([::1]:34492 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1l82nt-0006Sl-Qz for importer@patchew.org; Fri, 05 Feb 2021 10:13:49 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]:47960) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1l82eU-0004Eo-QW for qemu-devel@nongnu.org; Fri, 05 Feb 2021 10:04:06 -0500 Received: from us-smtp-delivery-124.mimecast.com ([216.205.24.124]:55209) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA1:256) (Exim 4.90_1) (envelope-from ) id 1l82eR-000325-Sm for qemu-devel@nongnu.org; Fri, 05 Feb 2021 10:04:06 -0500 Received: from mail-ed1-f71.google.com (mail-ed1-f71.google.com [209.85.208.71]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-503-GE247dIWPeak4cqoJD3ncg-1; Fri, 05 Feb 2021 10:04:01 -0500 Received: by mail-ed1-f71.google.com with SMTP id o8so7137856edh.12 for ; Fri, 05 Feb 2021 07:04:01 -0800 (PST) Received: from redhat.com (bzq-79-180-2-31.red.bezeqint.net. [79.180.2.31]) by smtp.gmail.com with ESMTPSA id e9sm4106962edk.66.2021.02.05.07.03.58 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 05 Feb 2021 07:03:59 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1612537443; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=U4gtmotGyc4DgZ4L1F6rz2/tdPPpbSuNOqH2cuNj5uc=; b=XiEdf8mAVpERjVXiqT1qHIzmlPa/IHk4Vy2FrGWpHnOMk5WCYmDItd3xbNdZoLpzsIZB68 Bc+eESNiBOkdQqLt0D9a31Z7qqRqnSEv/1m3r+3RW0Uv11kC+3HDfHt3khyiuUxiXQ6Nyy rmG1dIuBc6N38yf8yr/3Sou9ijeorAE= X-MC-Unique: GE247dIWPeak4cqoJD3ncg-1 X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:content-transfer-encoding :in-reply-to; bh=U4gtmotGyc4DgZ4L1F6rz2/tdPPpbSuNOqH2cuNj5uc=; b=fBcMVpq8sKAIgJiZwaePKXJKHnz7laMXfcODxW4q6LzAoPBjYSqzAViW1VPMMKf6v0 E1kaa4kSRxFERsDRglZ63De7Eb7LCS63ptCpGjtq0jsQ2y8z1ZyZCh4NWFyjU/KnplwZ yTyYF7DDKY+RQq5z0+NwIVOX+eD0FnzrNRTTn/Ej2bK/4Udjh7yBLDyPFCsXkPLSQVlO I8U9DdZ/6meytHsdbKdRsZW6meKPIlnRjfcwQt8CNHM4Kbhu66fuh/XmUQ1w/8G1N1KK yp5f9tSvMhNAHEhZkz72sj5M1HD9cAMXFh2l0FdMOFf+TQOKw2htgfL2iDCcS+VWDI/l aRiw== X-Gm-Message-State: AOAM530T6v13Hj6LyfOGe/LAuOewBM3PWvHNCGMvdUESxCtBpejHGNDh O/sF966TMcqFvsLkdFJdODQjVg14sRlCgE8eC0Sf2HorgiO7Tw0ymDc5+ivm6GgDPNVIaLP0ztl ccSvScnANjHODDA9Ewed+GBnZ8wPqowgfS5xYxCc4UcZYpXRYNQDL9InTBGxi X-Received: by 2002:a17:906:c08a:: with SMTP id f10mr4467503ejz.52.1612537439918; Fri, 05 Feb 2021 07:03:59 -0800 (PST) X-Google-Smtp-Source: ABdhPJzD9Lf1PfX9ZX11/EFEB23gXZg8a4wMNwaZAzvMM83H995AuYBvSxLWDlAGzHpeGS1XIY8vAg== X-Received: by 2002:a17:906:c08a:: with SMTP id f10mr4467480ejz.52.1612537439752; Fri, 05 Feb 2021 07:03:59 -0800 (PST) Date: Fri, 5 Feb 2021 10:03:57 -0500 From: "Michael S. Tsirkin" To: qemu-devel@nongnu.org Subject: [PULL v2 10/16] vhost: Check for valid vdev in vhost_backend_handle_iotlb_msg Message-ID: <20210205150135.94643-11-mst@redhat.com> References: <20210205150135.94643-1-mst@redhat.com> MIME-Version: 1.0 In-Reply-To: <20210205150135.94643-1-mst@redhat.com> X-Mailer: git-send-email 2.27.0.106.g8ac3dc51b1 X-Mutt-Fcc: =sent Authentication-Results: relay.mimecast.com; auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=mst@redhat.com X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset="utf-8" Content-Disposition: inline Content-Transfer-Encoding: quoted-printable Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Received-SPF: pass client-ip=216.205.24.124; envelope-from=mst@redhat.com; helo=us-smtp-delivery-124.mimecast.com X-Spam_score_int: -30 X-Spam_score: -3.1 X-Spam_bar: --- X-Spam_report: (-3.1 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.352, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_LOW=-0.7, RCVD_IN_MSPIKE_H3=0.001, RCVD_IN_MSPIKE_WL=0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Peter Maydell , Jason Wang , Eugenio =?utf-8?B?UMOpcmV6?= Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: "Qemu-devel" X-ZohoMail-DKIM: fail (Header signature does not verify) From: Eugenio P=C3=A9rez Not checking this can lead to invalid dev->vdev member access in vhost_device_iotlb_miss if backend issue an iotlb message in a bad timing, either maliciously or by a bug. Reproduced rebooting a guest with testpmd in txonly forward mode. #0 0x0000559ffff94394 in vhost_device_iotlb_miss ( dev=3Ddev@entry=3D0x55a0012f6680, iova=3D10245279744, write=3D1) at ../hw/virtio/vhost.c:1013 #1 0x0000559ffff9ac31 in vhost_backend_handle_iotlb_msg ( imsg=3D0x7ffddcfd32c0, dev=3D0x55a0012f6680) at ../hw/virtio/vhost-backend.c:411 #2 vhost_backend_handle_iotlb_msg (dev=3Ddev@entry=3D0x55a0012f6680, imsg=3Dimsg@entry=3D0x7ffddcfd32c0) at ../hw/virtio/vhost-backend.c:404 #3 0x0000559fffeded7b in slave_read (opaque=3D0x55a0012f6680) at ../hw/virtio/vhost-user.c:1464 #4 0x000055a0000c541b in aio_dispatch_handler ( ctx=3Dctx@entry=3D0x55a0010a2120, node=3D0x55a0012d9e00) at ../util/aio-posix.c:329 Fixes: 020e571b8b ("vhost: rework IOTLB messaging") Signed-off-by: Eugenio P=C3=A9rez Message-Id: <20210129090728.831208-1-eperezma@redhat.com> Acked-by: Jason Wang Reviewed-by: Michael S. Tsirkin Signed-off-by: Michael S. Tsirkin --- hw/virtio/vhost-backend.c | 5 +++++ 1 file changed, 5 insertions(+) diff --git a/hw/virtio/vhost-backend.c b/hw/virtio/vhost-backend.c index 222bbcc62d..31b33bde37 100644 --- a/hw/virtio/vhost-backend.c +++ b/hw/virtio/vhost-backend.c @@ -406,6 +406,11 @@ int vhost_backend_handle_iotlb_msg(struct vhost_dev *d= ev, { int ret =3D 0; =20 + if (unlikely(!dev->vdev)) { + error_report("Unexpected IOTLB message when virtio device is stopp= ed"); + return -EINVAL; + } + switch (imsg->type) { case VHOST_IOTLB_MISS: ret =3D vhost_device_iotlb_miss(dev, imsg->iova, --=20 MST From nobody Sun Feb 8 09:27:42 2026 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass(p=none dis=none) header.from=redhat.com ARC-Seal: i=1; a=rsa-sha256; t=1612542118; cv=none; d=zohomail.com; s=zohoarc; b=C2lEoIpnQts5jQPhLQXVNQYET8Y3CDIhlDBwIpXtXCZLN7+UWwrZDMvCRST1rgWHlTxjhnCuOvWqY57PEHEH7rlYzX6LbUIienIB0vxcQJmzs3lpDRaWFr1tVLUAb2YH6shuEp+15OJ1seWerWWq2bhou9dvms4eqErTwTxDGcE= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1612542118; h=Content-Type:Cc:Date:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:To; bh=SSM+mYEGXLsaone1ZdOs9Nhm6Xe5Ed6Gpm/kadhfMks=; b=XNJFornbKw1goB2pJkJl7EvtvQjlDmQPvdBrNV/T2cF9mkSmLknjzhMhELat1gcDKN5hxvLYhH3GJLSzU4ge3XZjfI7RppkUFBosRBlijo/YzZaYyWwOlF5B32/BaWoe+MNmDmGQV6AOIjRszWqgDB36AJaNrARyWXPmRG0ORh4= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass header.from= (p=none dis=none) header.from= Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1612542118233192.6786600763695; Fri, 5 Feb 2021 08:21:58 -0800 (PST) Received: from localhost ([::1]:57474 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1l82mc-0004IQ-14 for importer@patchew.org; Fri, 05 Feb 2021 10:12:30 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]:48002) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1l82eY-0004MX-2e for qemu-devel@nongnu.org; Fri, 05 Feb 2021 10:04:10 -0500 Received: from us-smtp-delivery-124.mimecast.com ([216.205.24.124]:45292) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA1:256) (Exim 4.90_1) (envelope-from ) id 1l82eU-00033b-Tb for qemu-devel@nongnu.org; Fri, 05 Feb 2021 10:04:09 -0500 Received: from mail-ej1-f71.google.com (mail-ej1-f71.google.com [209.85.218.71]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-173-Pqt7n2k9MpauIZ0rdxMQFQ-1; Fri, 05 Feb 2021 10:04:04 -0500 Received: by mail-ej1-f71.google.com with SMTP id hx26so6840195ejc.3 for ; Fri, 05 Feb 2021 07:04:04 -0800 (PST) Received: from redhat.com (bzq-79-180-2-31.red.bezeqint.net. [79.180.2.31]) by smtp.gmail.com with ESMTPSA id dt17sm3981273ejb.70.2021.02.05.07.04.00 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 05 Feb 2021 07:04:02 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1612537446; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=SSM+mYEGXLsaone1ZdOs9Nhm6Xe5Ed6Gpm/kadhfMks=; b=Fs1byG9RPZKUBvlTCl7v9nkjN9+K4vLwdhH5BlEwZrwjnPO+k4jssSz/o7Go25R4k2lhNE R2cG5xjZ84haHokRCgEoIEHJ6vhkk8BGqf3NZ2ikNOcgpTMeFKT29Un4mV/ogsSAYtYerJ t8r9x00uAEA3/CqSvJi4/5T87bErCDw= X-MC-Unique: Pqt7n2k9MpauIZ0rdxMQFQ-1 X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=SSM+mYEGXLsaone1ZdOs9Nhm6Xe5Ed6Gpm/kadhfMks=; b=mfukq7BapPmJCitTEaQpBOg085fYwgcujTYDoho0SFrdvAQnHykJ78Ginizt/0oZLB N0kzX/eIuOkeUJ/crDQEIfhdep3IiuhXlFX17Q9qwyoHDQ5vVz/G8GVptgIgdZfBBq5m lM84X0AP2W5DcI1npT4KqzmdKwbQic9z5kyGIZD/DvTZ8+GE1l3HM9qjOcCbAvQdbLBV SfMLTC9jHARigvXaKSU3vopTzg8oB6kzjpiz0+DitK4b7pPv4aexxF+OUamEJp4v+IEl iQwl1BVqRFl7Kq49iWWyC+L3wbRC5+uK+/xlUTY8i8GO1rk5Hjp5W/sTgLsyX5m68bQE IGaw== X-Gm-Message-State: AOAM531ExbVPeK5H+0rQuiCvd4FREUCJXhKqBD83Z/xPQDsYb2e+4vtw UlIy9AiqL+4blo7xlpZkSMLc5NzaHxh7xHt6GbtHaWXl2Eg8s9drJQypI5XQtdMNc514Fom6h59 TbBITGfKTbAxvk6mdN6nwGGuEebNxEpCQYT4+Vc9pd1FBjoDKMrmsbKqqpaPf X-Received: by 2002:aa7:d901:: with SMTP id a1mr3912666edr.120.1612537442917; Fri, 05 Feb 2021 07:04:02 -0800 (PST) X-Google-Smtp-Source: ABdhPJy50q6rklfuPzhw/oz8kaQiXKwBXtADVmqPGEXwU7Ii/IUe3UW0EnfrLE5BRxLrL8+6F+twYg== X-Received: by 2002:aa7:d901:: with SMTP id a1mr3912647edr.120.1612537442748; Fri, 05 Feb 2021 07:04:02 -0800 (PST) Date: Fri, 5 Feb 2021 10:04:00 -0500 From: "Michael S. Tsirkin" To: qemu-devel@nongnu.org Subject: [PULL v2 11/16] tests/acpi: allow updates for expected data files Message-ID: <20210205150135.94643-12-mst@redhat.com> References: <20210205150135.94643-1-mst@redhat.com> MIME-Version: 1.0 In-Reply-To: <20210205150135.94643-1-mst@redhat.com> X-Mailer: git-send-email 2.27.0.106.g8ac3dc51b1 X-Mutt-Fcc: =sent Authentication-Results: relay.mimecast.com; auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=mst@redhat.com X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Disposition: inline Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Received-SPF: pass client-ip=216.205.24.124; envelope-from=mst@redhat.com; helo=us-smtp-delivery-124.mimecast.com X-Spam_score_int: -30 X-Spam_score: -3.1 X-Spam_bar: --- X-Spam_report: (-3.1 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.352, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_LOW=-0.7, RCVD_IN_MSPIKE_H3=0.001, RCVD_IN_MSPIKE_WL=0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Peter Maydell , Marian Postevca , Igor Mammedov Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: "Qemu-devel" X-ZohoMail-DKIM: pass (identity @redhat.com) Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" From: Marian Postevca Signed-off-by: Marian Postevca Message-Id: <20210119003216.17637-2-posteuca@mutex.one> Reviewed-by: Michael S. Tsirkin Signed-off-by: Michael S. Tsirkin --- tests/qtest/bios-tables-test-allowed-diff.h | 94 +++++++++++++++++++++ 1 file changed, 94 insertions(+) diff --git a/tests/qtest/bios-tables-test-allowed-diff.h b/tests/qtest/bios= -tables-test-allowed-diff.h index dfb8523c8b..b20ae72949 100644 --- a/tests/qtest/bios-tables-test-allowed-diff.h +++ b/tests/qtest/bios-tables-test-allowed-diff.h @@ -1 +1,95 @@ /* List of comma-separated changed AML files to ignore */ +"tests/data/acpi/virt/APIC", +"tests/data/acpi/virt/FACP", +"tests/data/acpi/virt/GTDT", +"tests/data/acpi/virt/MCFG", +"tests/data/acpi/virt/SPCR", +"tests/data/acpi/virt/DSDT", +"tests/data/acpi/virt/APIC.numamem", +"tests/data/acpi/virt/FACP.numamem", +"tests/data/acpi/virt/GTDT.numamem", +"tests/data/acpi/virt/MCFG.numamem", +"tests/data/acpi/virt/SPCR.numamem", +"tests/data/acpi/virt/DSDT.numamem", +"tests/data/acpi/virt/SRAT.numamem", +"tests/data/acpi/virt/DSDT.memhp", +"tests/data/acpi/virt/NFIT.memhp", +"tests/data/acpi/virt/SSDT.memhp", +"tests/data/acpi/virt/SLIT.memhp", +"tests/data/acpi/virt/SRAT.memhp", +"tests/data/acpi/virt/SPCR.memhp", +"tests/data/acpi/virt/MCFG.memhp", +"tests/data/acpi/virt/GTDT.memhp", +"tests/data/acpi/virt/APIC.memhp", +"tests/data/acpi/virt/FACP.memhp", +"tests/data/acpi/virt/DSDT.pxb", + +"tests/data/acpi/pc/SRAT.acpihmat", +"tests/data/acpi/pc/HPET", +"tests/data/acpi/pc/DSDT.hpbrroot", +"tests/data/acpi/pc/SRAT.numamem", +"tests/data/acpi/pc/DSDT.dimmpxm", +"tests/data/acpi/pc/DSDT.acpihmat", +"tests/data/acpi/pc/FACP", +"tests/data/acpi/pc/SRAT.cphp", +"tests/data/acpi/pc/DSDT.numamem", +"tests/data/acpi/pc/DSDT.bridge", +"tests/data/acpi/pc/HMAT.acpihmat", +"tests/data/acpi/pc/DSDT.cphp", +"tests/data/acpi/pc/APIC.dimmpxm", +"tests/data/acpi/pc/SRAT.memhp", +"tests/data/acpi/pc/SLIT.cphp", +"tests/data/acpi/pc/DSDT.hpbridge", +"tests/data/acpi/pc/NFIT.dimmpxm", +"tests/data/acpi/pc/APIC.cphp", +"tests/data/acpi/pc/SSDT.dimmpxm", +"tests/data/acpi/pc/SRAT.dimmpxm", +"tests/data/acpi/pc/APIC.acpihmat", +"tests/data/acpi/pc/DSDT.memhp", +"tests/data/acpi/pc/DSDT.ipmikcs", +"tests/data/acpi/pc/SLIT.memhp", +"tests/data/acpi/pc/WAET", +"tests/data/acpi/pc/DSDT", +"tests/data/acpi/pc/APIC", +"tests/data/acpi/pc/DSDT.roothp", + +"tests/data/acpi/q35/SRAT.acpihmat", +"tests/data/acpi/q35/HPET", +"tests/data/acpi/q35/SRAT.numamem", +"tests/data/acpi/q35/DSDT.dimmpxm", +"tests/data/acpi/q35/DSDT.acpihmat", +"tests/data/acpi/q35/FACP", +"tests/data/acpi/q35/DSDT.mmio64", +"tests/data/acpi/q35/SRAT.cphp", +"tests/data/acpi/q35/DSDT.numamem", +"tests/data/acpi/q35/DSDT.bridge", +"tests/data/acpi/q35/HMAT.acpihmat", +"tests/data/acpi/q35/DSDT.cphp", +"tests/data/acpi/q35/APIC.dimmpxm", +"tests/data/acpi/q35/SRAT.memhp", +"tests/data/acpi/q35/SLIT.cphp", +"tests/data/acpi/q35/NFIT.dimmpxm", +"tests/data/acpi/q35/APIC.cphp", +"tests/data/acpi/q35/SSDT.dimmpxm", +"tests/data/acpi/q35/SRAT.dimmpxm", +"tests/data/acpi/q35/APIC.acpihmat", +"tests/data/acpi/q35/MCFG", +"tests/data/acpi/q35/DSDT.memhp", +"tests/data/acpi/q35/SLIT.memhp", +"tests/data/acpi/q35/WAET", +"tests/data/acpi/q35/DSDT.ipmibt", +"tests/data/acpi/q35/DSDT.tis", +"tests/data/acpi/q35/SRAT.mmio64", +"tests/data/acpi/q35/TPM2.tis", +"tests/data/acpi/q35/DSDT", +"tests/data/acpi/q35/APIC", + +"tests/data/acpi/microvm/APIC.pcie", +"tests/data/acpi/microvm/DSDT.pcie", +"tests/data/acpi/microvm/DSDT.usb", +"tests/data/acpi/microvm/DSDT.rtc", +"tests/data/acpi/microvm/FACP", +"tests/data/acpi/microvm/APIC.ioapic2", +"tests/data/acpi/microvm/DSDT.ioapic2", +"tests/data/acpi/microvm/DSDT", +"tests/data/acpi/microvm/APIC", --=20 MST From nobody Sun Feb 8 09:27:42 2026 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=fail; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=fail(p=none dis=none) header.from=redhat.com ARC-Seal: i=1; a=rsa-sha256; t=1612539542; cv=none; d=zohomail.com; s=zohoarc; b=Q+jAAVhbuQo7lNrrXGFEwF3V7yF7TyJqBhjd80uiEAS4n89EGwX0nQDYFGrECYu5lbiNFkjZExJOjWi0HMlgGBp38/z1Mat4t6UYBwF2Ioer8ElsOgZZaAkM5h61viARoXRdtdC1EJtXgOl5N9Lp1/elzPbr/dnBBJUyk3LCa48= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1612539542; h=Content-Type:Content-Transfer-Encoding:Cc:Date:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:To; bh=Bh4PfepQMwiw/wSFgTOMnBFeLQ5PPQtiiL9L9xscTQA=; b=AGOgvK3laOGiW/Lqi/34HxPkXtSEdZa+x+j5PmnWtbCnlXPSvKCY7n9Xi6JQrcs882ippsy6YsPl9hnBoH76707Wm7Lc5AykvJqQOCEkrqDWH3CcTZALcGDeRkLM9srMb+8ATUfBBR+AfwrezGe3rhpMPhxJUtosNBQPHGUx5hI= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=fail; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=fail header.from= (p=none dis=none) header.from= Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1612539542823236.27835097352283; Fri, 5 Feb 2021 07:39:02 -0800 (PST) Received: from localhost ([::1]:38082 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1l82oZ-0007xx-08 for importer@patchew.org; Fri, 05 Feb 2021 10:14:31 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]:48058) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1l82ee-0004ZE-I0 for qemu-devel@nongnu.org; Fri, 05 Feb 2021 10:04:16 -0500 Received: from us-smtp-delivery-124.mimecast.com ([216.205.24.124]:35275) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA1:256) (Exim 4.90_1) (envelope-from ) id 1l82eZ-00035L-Rd for qemu-devel@nongnu.org; Fri, 05 Feb 2021 10:04:16 -0500 Received: from mail-ed1-f71.google.com (mail-ed1-f71.google.com [209.85.208.71]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-487-Tae30Yz4NkG4BS2fJjA4vA-1; Fri, 05 Feb 2021 10:04:09 -0500 Received: by mail-ed1-f71.google.com with SMTP id b1so7112174edt.22 for ; Fri, 05 Feb 2021 07:04:08 -0800 (PST) Received: from redhat.com (bzq-79-180-2-31.red.bezeqint.net. [79.180.2.31]) by smtp.gmail.com with ESMTPSA id s12sm4117667edu.28.2021.02.05.07.04.03 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 05 Feb 2021 07:04:05 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1612537451; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=Bh4PfepQMwiw/wSFgTOMnBFeLQ5PPQtiiL9L9xscTQA=; b=XMbMmlyFVyI7pnEWN+R5QYdWFl0bd7YH0A/SwWA73fMJuBrr7JGmuCFu1oUaY8+GcPlIhX JNX3scwGafXWWj66N564wjjfcGDn+ZqwOavU9f6C36IetkihhN+Km+EcyJGbpNIVa6R245 hH5kCSOqSdchML4y5PuOxhH350UAdMY= X-MC-Unique: Tae30Yz4NkG4BS2fJjA4vA-1 X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:content-transfer-encoding :in-reply-to; bh=Bh4PfepQMwiw/wSFgTOMnBFeLQ5PPQtiiL9L9xscTQA=; b=huvyDLmK+CFm2cOD6Ryrf0OPneVf+9+yoCms1yGl9HhbCKG++jJdguPCSKnZcBACsO T/fa0pPBUz0s/rxb2ZtY3ZGexEPh/Oa4SMnrKrKXzac9Qzp91SUdQqrfibyUcxtKMmyX u7gaYNiFqFRHVdl6HYGCnvrd6P/5FZ+5+mbYR/msk5OmU2ja66L+KNUam+zVeIozZaFo powwzjwFGzLdBD1VxVWubTArwC347var65+WOOAxOQoH1uKc8dkf8UDHzC4DJEpKAcNQ resPXSv9XWWqHRX05RF7hVFGzYNYjVKkRFQFZqCkhOTNrMEGXTWWjVVSPYj1JNThkYLI Z61g== X-Gm-Message-State: AOAM532HPBZI2AIgFnR9hbrv87hMUJm52+dE/0lgTZYS+1+LBK4GKhLE wCBPxxCyTPmSFfOM4+/wqd+zthNsSKBEQV+OfNgxU8P+kGhcTRsb17r50kyZqIEbYN1tkXj9NUl wE9YnqR4wHTe3jpXAZt6Q4A1W58XkHbcfoybGUZco5v1NCZYvTd8ldBtcsBnO X-Received: by 2002:a17:906:8591:: with SMTP id v17mr4354973ejx.30.1612537446821; Fri, 05 Feb 2021 07:04:06 -0800 (PST) X-Google-Smtp-Source: ABdhPJw7BNLUXQDNKF+xiZn/1dvNnhII+2dUbz9Fug+evKQbuyrS41XTz0psoyTFjudldFm0G4W0Kg== X-Received: by 2002:a17:906:8591:: with SMTP id v17mr4354922ejx.30.1612537446371; Fri, 05 Feb 2021 07:04:06 -0800 (PST) Date: Fri, 5 Feb 2021 10:04:02 -0500 From: "Michael S. Tsirkin" To: qemu-devel@nongnu.org Subject: [PULL v2 12/16] acpi: Permit OEM ID and OEM table ID fields to be changed Message-ID: <20210205150135.94643-13-mst@redhat.com> References: <20210205150135.94643-1-mst@redhat.com> MIME-Version: 1.0 In-Reply-To: <20210205150135.94643-1-mst@redhat.com> X-Mailer: git-send-email 2.27.0.106.g8ac3dc51b1 X-Mutt-Fcc: =sent Authentication-Results: relay.mimecast.com; auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=mst@redhat.com X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset="utf-8" Content-Disposition: inline Content-Transfer-Encoding: quoted-printable Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Received-SPF: pass client-ip=216.205.24.124; envelope-from=mst@redhat.com; helo=us-smtp-delivery-124.mimecast.com X-Spam_score_int: -30 X-Spam_score: -3.1 X-Spam_bar: --- X-Spam_report: (-3.1 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.352, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_LOW=-0.7, RCVD_IN_MSPIKE_H3=0.001, RCVD_IN_MSPIKE_WL=0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=unavailable autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Peter Maydell , Xiao Guangrong , Sergio Lopez , Richard Henderson , Dongjiu Geng , Shannon Zhao , Xiang Zheng , qemu-arm@nongnu.org, Marian Postevca , Paolo Bonzini , Igor Mammedov , Eduardo Habkost Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: "Qemu-devel" X-ZohoMail-DKIM: fail (Header signature does not verify) From: Marian Postevca Qemu's ACPI table generation sets the fields OEM ID and OEM table ID to "BOCHS " and "BXPCxxxx" where "xxxx" is replaced by the ACPI table name. Some games like Red Dead Redemption 2 seem to check the ACPI OEM ID and OEM table ID for the strings "BOCHS" and "BXPC" and if they are found, the game crashes(this may be an intentional detection mechanism to prevent playing the game in a virtualized environment). This patch allows you to override these default values. The feature can be used in this manner: qemu -machine oem-id=3DABCDEF,oem-table-id=3DGHIJKLMN The oem-id string can be up to 6 bytes in size, and the oem-table-id string can be up to 8 bytes in size. If the string are smaller than their respective sizes they will be padded with space. If either of these parameters is not set, the current default values will be used for the one missing. Note that the the OEM Table ID field will not be extended with the name of the table, but will use either the default name or the user provided one. This does not affect the -acpitable option (for user-defined ACPI tables), which has precedence over -machine option. Signed-off-by: Marian Postevca Message-Id: <20210119003216.17637-3-posteuca@mutex.one> Reviewed-by: Michael S. Tsirkin Signed-off-by: Michael S. Tsirkin --- hw/acpi/hmat.h | 3 +- hw/i386/acpi-common.h | 3 +- include/hw/acpi/acpi-defs.h | 2 +- include/hw/acpi/aml-build.h | 8 ++-- include/hw/acpi/ghes.h | 3 +- include/hw/acpi/pci.h | 3 +- include/hw/acpi/vmgenid.h | 2 +- include/hw/arm/virt.h | 2 + include/hw/i386/microvm.h | 4 ++ include/hw/i386/pc.h | 5 ++- include/hw/mem/nvdimm.h | 3 +- hw/acpi/aml-build.c | 29 ++++++------- hw/acpi/ghes.c | 5 ++- hw/acpi/hmat.c | 5 ++- hw/acpi/nvdimm.c | 18 +++++--- hw/acpi/pci.c | 5 ++- hw/acpi/vmgenid.c | 4 +- hw/arm/virt-acpi-build.c | 40 +++++++++++------ hw/arm/virt.c | 63 +++++++++++++++++++++++++++ hw/i386/acpi-build.c | 86 +++++++++++++++++++++++++------------ hw/i386/acpi-common.c | 5 ++- hw/i386/acpi-microvm.c | 13 +++--- hw/i386/microvm.c | 66 ++++++++++++++++++++++++++++ hw/i386/pc.c | 64 +++++++++++++++++++++++++++ 24 files changed, 349 insertions(+), 92 deletions(-) diff --git a/hw/acpi/hmat.h b/hw/acpi/hmat.h index e9031cac01..b57f0e7e80 100644 --- a/hw/acpi/hmat.h +++ b/hw/acpi/hmat.h @@ -37,6 +37,7 @@ */ #define HMAT_PROXIMITY_INITIATOR_VALID 0x1 =20 -void build_hmat(GArray *table_data, BIOSLinker *linker, NumaState *numa_st= ate); +void build_hmat(GArray *table_data, BIOSLinker *linker, NumaState *numa_st= ate, + const char *oem_id, const char *oem_table_id); =20 #endif diff --git a/hw/i386/acpi-common.h b/hw/i386/acpi-common.h index c30e461f18..b12cd73ea5 100644 --- a/hw/i386/acpi-common.h +++ b/hw/i386/acpi-common.h @@ -9,6 +9,7 @@ #define ACPI_BUILD_IOAPIC_ID 0x0 =20 void acpi_build_madt(GArray *table_data, BIOSLinker *linker, - X86MachineState *x86ms, AcpiDeviceIf *adev); + X86MachineState *x86ms, AcpiDeviceIf *adev, + const char *oem_id, const char *oem_table_id); =20 #endif diff --git a/include/hw/acpi/acpi-defs.h b/include/hw/acpi/acpi-defs.h index 38a42f409a..cf9f44299c 100644 --- a/include/hw/acpi/acpi-defs.h +++ b/include/hw/acpi/acpi-defs.h @@ -41,7 +41,7 @@ enum { }; =20 typedef struct AcpiRsdpData { - uint8_t oem_id[6] QEMU_NONSTRING; /* OEM identification */ + char *oem_id; /* OEM identification */ uint8_t revision; /* Must be 0 for 1.0, 2 for 2.0 */ =20 unsigned *rsdt_tbl_offset; diff --git a/include/hw/acpi/aml-build.h b/include/hw/acpi/aml-build.h index 54a5aec4d7..380d3e3924 100644 --- a/include/hw/acpi/aml-build.h +++ b/include/hw/acpi/aml-build.h @@ -8,7 +8,7 @@ #define ACPI_BUILD_TABLE_MAX_SIZE 0x200000 =20 #define ACPI_BUILD_APPNAME6 "BOCHS " -#define ACPI_BUILD_APPNAME4 "BXPC" +#define ACPI_BUILD_APPNAME8 "BXPC " =20 #define ACPI_BUILD_TABLE_FILE "etc/acpi/tables" #define ACPI_BUILD_RSDP_FILE "etc/acpi/rsdp" @@ -459,10 +459,12 @@ Aml *build_crs(PCIHostState *host, CrsRangeSet *range= _set, uint32_t io_offset, void build_srat_memory(AcpiSratMemoryAffinity *numamem, uint64_t base, uint64_t len, int node, MemoryAffinityFlags flags); =20 -void build_slit(GArray *table_data, BIOSLinker *linker, MachineState *ms); +void build_slit(GArray *table_data, BIOSLinker *linker, MachineState *ms, + const char *oem_id, const char *oem_table_id); =20 void build_fadt(GArray *tbl, BIOSLinker *linker, const AcpiFadtData *f, const char *oem_id, const char *oem_table_id); =20 -void build_tpm2(GArray *table_data, BIOSLinker *linker, GArray *tcpalog); +void build_tpm2(GArray *table_data, BIOSLinker *linker, GArray *tcpalog, + const char *oem_id, const char *oem_table_id); #endif diff --git a/include/hw/acpi/ghes.h b/include/hw/acpi/ghes.h index 4ad025e09a..2ae8bc1ded 100644 --- a/include/hw/acpi/ghes.h +++ b/include/hw/acpi/ghes.h @@ -67,7 +67,8 @@ typedef struct AcpiGhesState { } AcpiGhesState; =20 void build_ghes_error_table(GArray *hardware_errors, BIOSLinker *linker); -void acpi_build_hest(GArray *table_data, BIOSLinker *linker); +void acpi_build_hest(GArray *table_data, BIOSLinker *linker, + const char *oem_id, const char *oem_table_id); void acpi_ghes_add_fw_cfg(AcpiGhesState *vms, FWCfgState *s, GArray *hardware_errors); int acpi_ghes_record_errors(uint8_t notify, uint64_t error_physical_addr); diff --git a/include/hw/acpi/pci.h b/include/hw/acpi/pci.h index bf2a3ed0ba..e514f179d8 100644 --- a/include/hw/acpi/pci.h +++ b/include/hw/acpi/pci.h @@ -33,5 +33,6 @@ typedef struct AcpiMcfgInfo { uint32_t size; } AcpiMcfgInfo; =20 -void build_mcfg(GArray *table_data, BIOSLinker *linker, AcpiMcfgInfo *info= ); +void build_mcfg(GArray *table_data, BIOSLinker *linker, AcpiMcfgInfo *info, + const char *oem_id, const char *oem_table_id); #endif diff --git a/include/hw/acpi/vmgenid.h b/include/hw/acpi/vmgenid.h index cb4ad37fc5..dc8bb3433e 100644 --- a/include/hw/acpi/vmgenid.h +++ b/include/hw/acpi/vmgenid.h @@ -31,7 +31,7 @@ static inline Object *find_vmgenid_dev(void) } =20 void vmgenid_build_acpi(VmGenIdState *vms, GArray *table_data, GArray *gui= d, - BIOSLinker *linker); + BIOSLinker *linker, const char *oem_id); void vmgenid_add_fw_cfg(VmGenIdState *vms, FWCfgState *s, GArray *guid); =20 #endif diff --git a/include/hw/arm/virt.h b/include/hw/arm/virt.h index 36fcb29641..ee9a93101e 100644 --- a/include/hw/arm/virt.h +++ b/include/hw/arm/virt.h @@ -165,6 +165,8 @@ struct VirtMachineState { DeviceState *acpi_dev; Notifier powerdown_notifier; PCIBus *bus; + char *oem_id; + char *oem_table_id; }; =20 #define VIRT_ECAM_ID(high) (high ? VIRT_HIGH_PCIE_ECAM : VIRT_PCIE_ECAM) diff --git a/include/hw/i386/microvm.h b/include/hw/i386/microvm.h index f25f837441..372b05774e 100644 --- a/include/hw/i386/microvm.h +++ b/include/hw/i386/microvm.h @@ -76,6 +76,8 @@ #define MICROVM_MACHINE_ISA_SERIAL "isa-serial" #define MICROVM_MACHINE_OPTION_ROMS "x-option-roms" #define MICROVM_MACHINE_AUTO_KERNEL_CMDLINE "auto-kernel-cmdline" +#define MICROVM_MACHINE_OEM_ID "oem-id" +#define MICROVM_MACHINE_OEM_TABLE_ID "oem-table-id" =20 struct MicrovmMachineClass { X86MachineClass parent; @@ -104,6 +106,8 @@ struct MicrovmMachineState { Notifier machine_done; Notifier powerdown_req; struct GPEXConfig gpex; + char *oem_id; + char *oem_table_id; }; =20 #define TYPE_MICROVM_MACHINE MACHINE_TYPE_NAME("microvm") diff --git a/include/hw/i386/pc.h b/include/hw/i386/pc.h index 2aa8797c6e..5f93540a43 100644 --- a/include/hw/i386/pc.h +++ b/include/hw/i386/pc.h @@ -45,6 +45,8 @@ typedef struct PCMachineState { bool pit_enabled; bool hpet_enabled; uint64_t max_fw_size; + char *oem_id; + char *oem_table_id; =20 /* NUMA information: */ uint64_t numa_nodes; @@ -62,7 +64,8 @@ typedef struct PCMachineState { #define PC_MACHINE_SATA "sata" #define PC_MACHINE_PIT "pit" #define PC_MACHINE_MAX_FW_SIZE "max-fw-size" - +#define PC_MACHINE_OEM_ID "oem-id" +#define PC_MACHINE_OEM_TABLE_ID "oem-table-id" /** * PCMachineClass: * diff --git a/include/hw/mem/nvdimm.h b/include/hw/mem/nvdimm.h index c699842dd0..bcf62f825c 100644 --- a/include/hw/mem/nvdimm.h +++ b/include/hw/mem/nvdimm.h @@ -154,7 +154,8 @@ void nvdimm_init_acpi_state(NVDIMMState *state, MemoryR= egion *io, void nvdimm_build_srat(GArray *table_data); void nvdimm_build_acpi(GArray *table_offsets, GArray *table_data, BIOSLinker *linker, NVDIMMState *state, - uint32_t ram_slots); + uint32_t ram_slots, const char *oem_id, + const char *oem_table_id); void nvdimm_plug(NVDIMMState *state); void nvdimm_acpi_plug_cb(HotplugHandler *hotplug_dev, DeviceState *dev); #endif diff --git a/hw/acpi/aml-build.c b/hw/acpi/aml-build.c index 7b6ebb0cc8..a2cd7a5830 100644 --- a/hw/acpi/aml-build.c +++ b/hw/acpi/aml-build.c @@ -30,6 +30,7 @@ #include "hw/pci/pci_host.h" #include "hw/pci/pci_bus.h" #include "hw/pci/pci_bridge.h" +#include "qemu/cutils.h" =20 static GArray *build_alloc_array(void) { @@ -1674,21 +1675,12 @@ build_header(BIOSLinker *linker, GArray *table_data, h->length =3D cpu_to_le32(len); h->revision =3D rev; =20 - if (oem_id) { - strncpy((char *)h->oem_id, oem_id, sizeof h->oem_id); - } else { - memcpy(h->oem_id, ACPI_BUILD_APPNAME6, 6); - } - - if (oem_table_id) { - strncpy((char *)h->oem_table_id, oem_table_id, sizeof(h->oem_table= _id)); - } else { - memcpy(h->oem_table_id, ACPI_BUILD_APPNAME4, 4); - memcpy(h->oem_table_id + 4, sig, 4); - } + strpadcpy((char *)h->oem_id, sizeof h->oem_id, oem_id, ' '); + strpadcpy((char *)h->oem_table_id, sizeof h->oem_table_id, + oem_table_id, ' '); =20 h->oem_revision =3D cpu_to_le32(1); - memcpy(h->asl_compiler_id, ACPI_BUILD_APPNAME4, 4); + memcpy(h->asl_compiler_id, ACPI_BUILD_APPNAME8, 4); h->asl_compiler_revision =3D cpu_to_le32(1); /* Checksum to be filled in by Guest linker */ bios_linker_loader_add_checksum(linker, ACPI_BUILD_TABLE_FILE, @@ -1871,7 +1863,8 @@ void build_srat_memory(AcpiSratMemoryAffinity *numame= m, uint64_t base, * ACPI spec 5.2.17 System Locality Distance Information Table * (Revision 2.0 or later) */ -void build_slit(GArray *table_data, BIOSLinker *linker, MachineState *ms) +void build_slit(GArray *table_data, BIOSLinker *linker, MachineState *ms, + const char *oem_id, const char *oem_table_id) { int slit_start, i, j; slit_start =3D table_data->len; @@ -1892,7 +1885,7 @@ void build_slit(GArray *table_data, BIOSLinker *linke= r, MachineState *ms) build_header(linker, table_data, (void *)(table_data->data + slit_start), "SLIT", - table_data->len - slit_start, 1, NULL, NULL); + table_data->len - slit_start, 1, oem_id, oem_table_id); } =20 /* build rev1/rev3/rev5.1 FADT */ @@ -2024,7 +2017,8 @@ build_hdr: * table 7: TCG Hardware Interface Description Table Format for TPM 2.0 * of TCG ACPI Specification, Family =E2=80=9C1.2=E2=80=9D and =E2=80=9C2.= 0=E2=80=9D, Version 1.2, Rev 8 */ -void build_tpm2(GArray *table_data, BIOSLinker *linker, GArray *tcpalog) +void build_tpm2(GArray *table_data, BIOSLinker *linker, GArray *tcpalog, + const char *oem_id, const char *oem_table_id) { uint8_t start_method_params[12] =3D {}; unsigned log_addr_offset, tpm2_start; @@ -2073,7 +2067,8 @@ void build_tpm2(GArray *table_data, BIOSLinker *linke= r, GArray *tcpalog) log_addr_offset, 8, ACPI_BUILD_TPMLOG_FILE, 0); build_header(linker, table_data, - tpm2_ptr, "TPM2", table_data->len - tpm2_start, 4, NULL, = NULL); + tpm2_ptr, "TPM2", table_data->len - tpm2_start, 4, oem_id, + oem_table_id); } =20 Aml *build_crs(PCIHostState *host, CrsRangeSet *range_set, uint32_t io_off= set, diff --git a/hw/acpi/ghes.c b/hw/acpi/ghes.c index f0ee9f51ca..a4dac6bf15 100644 --- a/hw/acpi/ghes.c +++ b/hw/acpi/ghes.c @@ -359,7 +359,8 @@ static void build_ghes_v2(GArray *table_data, int sourc= e_id, BIOSLinker *linker) } =20 /* Build Hardware Error Source Table */ -void acpi_build_hest(GArray *table_data, BIOSLinker *linker) +void acpi_build_hest(GArray *table_data, BIOSLinker *linker, + const char *oem_id, const char *oem_table_id) { uint64_t hest_start =3D table_data->len; =20 @@ -372,7 +373,7 @@ void acpi_build_hest(GArray *table_data, BIOSLinker *li= nker) build_ghes_v2(table_data, ACPI_HEST_SRC_ID_SEA, linker); =20 build_header(linker, table_data, (void *)(table_data->data + hest_star= t), - "HEST", table_data->len - hest_start, 1, NULL, NULL); + "HEST", table_data->len - hest_start, 1, oem_id, oem_tabl= e_id); } =20 void acpi_ghes_add_fw_cfg(AcpiGhesState *ags, FWCfgState *s, diff --git a/hw/acpi/hmat.c b/hw/acpi/hmat.c index 37806f7a06..edb3fd91b2 100644 --- a/hw/acpi/hmat.c +++ b/hw/acpi/hmat.c @@ -253,7 +253,8 @@ static void hmat_build_table_structs(GArray *table_data= , NumaState *numa_state) } } =20 -void build_hmat(GArray *table_data, BIOSLinker *linker, NumaState *numa_st= ate) +void build_hmat(GArray *table_data, BIOSLinker *linker, NumaState *numa_st= ate, + const char *oem_id, const char *oem_table_id) { int hmat_start =3D table_data->len; =20 @@ -264,5 +265,5 @@ void build_hmat(GArray *table_data, BIOSLinker *linker,= NumaState *numa_state) =20 build_header(linker, table_data, (void *)(table_data->data + hmat_start), - "HMAT", table_data->len - hmat_start, 2, NULL, NULL); + "HMAT", table_data->len - hmat_start, 2, oem_id, oem_tabl= e_id); } diff --git a/hw/acpi/nvdimm.c b/hw/acpi/nvdimm.c index aa95b0cbaf..e3d5fe1939 100644 --- a/hw/acpi/nvdimm.c +++ b/hw/acpi/nvdimm.c @@ -402,7 +402,8 @@ void nvdimm_plug(NVDIMMState *state) } =20 static void nvdimm_build_nfit(NVDIMMState *state, GArray *table_offsets, - GArray *table_data, BIOSLinker *linker) + GArray *table_data, BIOSLinker *linker, + const char *oem_id, const char *oem_table_id) { NvdimmFitBuffer *fit_buf =3D &state->fit_buf; unsigned int header; @@ -417,7 +418,8 @@ static void nvdimm_build_nfit(NVDIMMState *state, GArra= y *table_offsets, =20 build_header(linker, table_data, (void *)(table_data->data + header), "NFIT", - sizeof(NvdimmNfitHeader) + fit_buf->fit->len, 1, NULL, NU= LL); + sizeof(NvdimmNfitHeader) + fit_buf->fit->len, 1, oem_id, + oem_table_id); } =20 #define NVDIMM_DSM_MEMORY_SIZE 4096 @@ -1278,7 +1280,7 @@ static void nvdimm_build_nvdimm_devices(Aml *root_dev= , uint32_t ram_slots) static void nvdimm_build_ssdt(GArray *table_offsets, GArray *table_data, BIOSLinker *linker, NVDIMMState *nvdimm_state, - uint32_t ram_slots) + uint32_t ram_slots, const char *oem_id) { Aml *ssdt, *sb_scope, *dev; int mem_addr_offset, nvdimm_ssdt; @@ -1331,7 +1333,7 @@ static void nvdimm_build_ssdt(GArray *table_offsets, = GArray *table_data, NVDIMM_DSM_MEM_FILE, 0); build_header(linker, table_data, (void *)(table_data->data + nvdimm_ssdt), - "SSDT", table_data->len - nvdimm_ssdt, 1, NULL, "NVDIMM"); + "SSDT", table_data->len - nvdimm_ssdt, 1, oem_id, "NVDIMM= "); free_aml_allocator(); } =20 @@ -1359,7 +1361,8 @@ void nvdimm_build_srat(GArray *table_data) =20 void nvdimm_build_acpi(GArray *table_offsets, GArray *table_data, BIOSLinker *linker, NVDIMMState *state, - uint32_t ram_slots) + uint32_t ram_slots, const char *oem_id, + const char *oem_table_id) { GSList *device_list; =20 @@ -1369,7 +1372,7 @@ void nvdimm_build_acpi(GArray *table_offsets, GArray = *table_data, } =20 nvdimm_build_ssdt(table_offsets, table_data, linker, state, - ram_slots); + ram_slots, oem_id); =20 device_list =3D nvdimm_get_device_list(); /* no NVDIMM device is plugged. */ @@ -1377,6 +1380,7 @@ void nvdimm_build_acpi(GArray *table_offsets, GArray = *table_data, return; } =20 - nvdimm_build_nfit(state, table_offsets, table_data, linker); + nvdimm_build_nfit(state, table_offsets, table_data, linker, + oem_id, oem_table_id); g_slist_free(device_list); } diff --git a/hw/acpi/pci.c b/hw/acpi/pci.c index 9510597a19..ec455c3b25 100644 --- a/hw/acpi/pci.c +++ b/hw/acpi/pci.c @@ -28,7 +28,8 @@ #include "hw/acpi/pci.h" #include "hw/pci/pcie_host.h" =20 -void build_mcfg(GArray *table_data, BIOSLinker *linker, AcpiMcfgInfo *info) +void build_mcfg(GArray *table_data, BIOSLinker *linker, AcpiMcfgInfo *info, + const char *oem_id, const char *oem_table_id) { int mcfg_start =3D table_data->len; =20 @@ -56,6 +57,6 @@ void build_mcfg(GArray *table_data, BIOSLinker *linker, A= cpiMcfgInfo *info) build_append_int_noprefix(table_data, 0, 4); =20 build_header(linker, table_data, (void *)(table_data->data + mcfg_star= t), - "MCFG", table_data->len - mcfg_start, 1, NULL, NULL); + "MCFG", table_data->len - mcfg_start, 1, oem_id, oem_tabl= e_id); } =20 diff --git a/hw/acpi/vmgenid.c b/hw/acpi/vmgenid.c index 6c92fdae49..4f41a13ea0 100644 --- a/hw/acpi/vmgenid.c +++ b/hw/acpi/vmgenid.c @@ -24,7 +24,7 @@ #include "sysemu/reset.h" =20 void vmgenid_build_acpi(VmGenIdState *vms, GArray *table_data, GArray *gui= d, - BIOSLinker *linker) + BIOSLinker *linker, const char *oem_id) { Aml *ssdt, *dev, *scope, *method, *addr, *if_ctx; uint32_t vgia_offset; @@ -118,7 +118,7 @@ void vmgenid_build_acpi(VmGenIdState *vms, GArray *tabl= e_data, GArray *guid, =20 build_header(linker, table_data, (void *)(table_data->data + table_data->len - ssdt->buf->len), - "SSDT", ssdt->buf->len, 1, NULL, "VMGENID"); + "SSDT", ssdt->buf->len, 1, oem_id, "VMGENID"); free_aml_allocator(); } =20 diff --git a/hw/arm/virt-acpi-build.c b/hw/arm/virt-acpi-build.c index 9d9ee24053..f9c9df916c 100644 --- a/hw/arm/virt-acpi-build.c +++ b/hw/arm/virt-acpi-build.c @@ -341,7 +341,8 @@ build_iort(GArray *table_data, BIOSLinker *linker, Virt= MachineState *vms) iort->length =3D cpu_to_le32(iort_length); =20 build_header(linker, table_data, (void *)(table_data->data + iort_star= t), - "IORT", table_data->len - iort_start, 0, NULL, NULL); + "IORT", table_data->len - iort_start, 0, vms->oem_id, + vms->oem_table_id); } =20 static void @@ -375,7 +376,8 @@ build_spcr(GArray *table_data, BIOSLinker *linker, Virt= MachineState *vms) spcr->pci_vendor_id =3D 0xffff; /* PCI Vendor ID: not a PCI device */ =20 build_header(linker, table_data, (void *)(table_data->data + spcr_star= t), - "SPCR", table_data->len - spcr_start, 2, NULL, NULL); + "SPCR", table_data->len - spcr_start, 2, vms->oem_id, + vms->oem_table_id); } =20 static void @@ -427,7 +429,8 @@ build_srat(GArray *table_data, BIOSLinker *linker, Virt= MachineState *vms) } =20 build_header(linker, table_data, (void *)(table_data->data + srat_star= t), - "SRAT", table_data->len - srat_start, 3, NULL, NULL); + "SRAT", table_data->len - srat_start, 3, vms->oem_id, + vms->oem_table_id); } =20 /* GTDT */ @@ -462,7 +465,8 @@ build_gtdt(GArray *table_data, BIOSLinker *linker, Virt= MachineState *vms) =20 build_header(linker, table_data, (void *)(table_data->data + gtdt_start), "GTDT", - table_data->len - gtdt_start, 2, NULL, NULL); + table_data->len - gtdt_start, 2, vms->oem_id, + vms->oem_table_id); } =20 /* MADT */ @@ -551,7 +555,8 @@ build_madt(GArray *table_data, BIOSLinker *linker, Virt= MachineState *vms) =20 build_header(linker, table_data, (void *)(table_data->data + madt_start), "APIC", - table_data->len - madt_start, 3, NULL, NULL); + table_data->len - madt_start, 3, vms->oem_id, + vms->oem_table_id); } =20 /* FADT */ @@ -581,7 +586,7 @@ static void build_fadt_rev5(GArray *table_data, BIOSLin= ker *linker, g_assert_not_reached(); } =20 - build_fadt(table_data, linker, &fadt, NULL, NULL); + build_fadt(table_data, linker, &fadt, vms->oem_id, vms->oem_table_id); } =20 /* DSDT */ @@ -645,7 +650,8 @@ build_dsdt(GArray *table_data, BIOSLinker *linker, Virt= MachineState *vms) g_array_append_vals(table_data, dsdt->buf->data, dsdt->buf->len); build_header(linker, table_data, (void *)(table_data->data + table_data->len - dsdt->buf->len), - "DSDT", dsdt->buf->len, 2, NULL, NULL); + "DSDT", dsdt->buf->len, 2, vms->oem_id, + vms->oem_table_id); free_aml_allocator(); } =20 @@ -704,7 +710,8 @@ void virt_acpi_build(VirtMachineState *vms, AcpiBuildTa= bles *tables) .base =3D vms->memmap[VIRT_ECAM_ID(vms->highmem_ecam)].base, .size =3D vms->memmap[VIRT_ECAM_ID(vms->highmem_ecam)].size, }; - build_mcfg(tables_blob, tables->linker, &mcfg); + build_mcfg(tables_blob, tables->linker, &mcfg, vms->oem_id, + vms->oem_table_id); } =20 acpi_add_table(table_offsets, tables_blob); @@ -713,7 +720,8 @@ void virt_acpi_build(VirtMachineState *vms, AcpiBuildTa= bles *tables) if (vms->ras) { build_ghes_error_table(tables->hardware_errors, tables->linker); acpi_add_table(table_offsets, tables_blob); - acpi_build_hest(tables_blob, tables->linker); + acpi_build_hest(tables_blob, tables->linker, vms->oem_id, + vms->oem_table_id); } =20 if (ms->numa_state->num_nodes > 0) { @@ -721,13 +729,15 @@ void virt_acpi_build(VirtMachineState *vms, AcpiBuild= Tables *tables) build_srat(tables_blob, tables->linker, vms); if (ms->numa_state->have_numa_distance) { acpi_add_table(table_offsets, tables_blob); - build_slit(tables_blob, tables->linker, ms); + build_slit(tables_blob, tables->linker, ms, vms->oem_id, + vms->oem_table_id); } } =20 if (ms->nvdimms_state->is_enabled) { nvdimm_build_acpi(table_offsets, tables_blob, tables->linker, - ms->nvdimms_state, ms->ram_slots); + ms->nvdimms_state, ms->ram_slots, vms->oem_id, + vms->oem_table_id); } =20 if (its_class_name() && !vmc->no_its) { @@ -737,18 +747,20 @@ void virt_acpi_build(VirtMachineState *vms, AcpiBuild= Tables *tables) =20 if (tpm_get_version(tpm_find()) =3D=3D TPM_VERSION_2_0) { acpi_add_table(table_offsets, tables_blob); - build_tpm2(tables_blob, tables->linker, tables->tcpalog); + build_tpm2(tables_blob, tables->linker, tables->tcpalog, vms->oem_= id, + vms->oem_table_id); } =20 /* XSDT is pointed to by RSDP */ xsdt =3D tables_blob->len; - build_xsdt(tables_blob, tables->linker, table_offsets, NULL, NULL); + build_xsdt(tables_blob, tables->linker, table_offsets, vms->oem_id, + vms->oem_table_id); =20 /* RSDP is in FSEG memory, so allocate it separately */ { AcpiRsdpData rsdp_data =3D { .revision =3D 2, - .oem_id =3D ACPI_BUILD_APPNAME6, + .oem_id =3D vms->oem_id, .xsdt_tbl_offset =3D &xsdt, .rsdt_tbl_offset =3D NULL, }; diff --git a/hw/arm/virt.c b/hw/arm/virt.c index 399da73454..0c65fe38a0 100644 --- a/hw/arm/virt.c +++ b/hw/arm/virt.c @@ -2155,6 +2155,49 @@ static void virt_set_its(Object *obj, bool value, Er= ror **errp) vms->its =3D value; } =20 +static char *virt_get_oem_id(Object *obj, Error **errp) +{ + VirtMachineState *vms =3D VIRT_MACHINE(obj); + + return g_strdup(vms->oem_id); +} + +static void virt_set_oem_id(Object *obj, const char *value, Error **errp) +{ + VirtMachineState *vms =3D VIRT_MACHINE(obj); + size_t len =3D strlen(value); + + if (len > 6) { + error_setg(errp, + "User specified oem-id value is bigger than 6 bytes in = size"); + return; + } + + strncpy(vms->oem_id, value, len + 1); +} + +static char *virt_get_oem_table_id(Object *obj, Error **errp) +{ + VirtMachineState *vms =3D VIRT_MACHINE(obj); + + return g_strdup(vms->oem_table_id); +} + +static void virt_set_oem_table_id(Object *obj, const char *value, + Error **errp) +{ + VirtMachineState *vms =3D VIRT_MACHINE(obj); + size_t len =3D strlen(value); + + if (len > 8) { + error_setg(errp, + "User specified oem-table-id value is bigger than 8 byt= es in size"); + return; + } + strncpy(vms->oem_table_id, value, len + 1); +} + + bool virt_is_acpi_enabled(VirtMachineState *vms) { if (vms->acpi =3D=3D ON_OFF_AUTO_OFF) { @@ -2604,6 +2647,23 @@ static void virt_machine_class_init(ObjectClass *oc,= void *data) "Set on/off to enable/disable " "ITS instantiation"); =20 + object_class_property_add_str(oc, "oem-id", + virt_get_oem_id, + virt_set_oem_id); + object_class_property_set_description(oc, "oem-id", + "Override the default value of f= ield OEMID " + "in ACPI table header." + "The string may be up to 6 bytes= in size"); + + + object_class_property_add_str(oc, "oem-table-id", + virt_get_oem_table_id, + virt_set_oem_table_id); + object_class_property_set_description(oc, "oem-table-id", + "Override the default value of f= ield OEM Table ID " + "in ACPI table header." + "The string may be up to 8 bytes= in size"); + } =20 static void virt_instance_init(Object *obj) @@ -2645,6 +2705,9 @@ static void virt_instance_init(Object *obj) vms->irqmap =3D a15irqmap; =20 virt_flash_create(vms); + + vms->oem_id =3D g_strndup(ACPI_BUILD_APPNAME6, 6); + vms->oem_table_id =3D g_strndup(ACPI_BUILD_APPNAME8, 8); } =20 static const TypeInfo virt_machine_info =3D { diff --git a/hw/i386/acpi-build.c b/hw/i386/acpi-build.c index f56d699c7f..b9190b924a 100644 --- a/hw/i386/acpi-build.c +++ b/hw/i386/acpi-build.c @@ -1637,12 +1637,13 @@ build_dsdt(GArray *table_data, BIOSLinker *linker, g_array_append_vals(table_data, dsdt->buf->data, dsdt->buf->len); build_header(linker, table_data, (void *)(table_data->data + table_data->len - dsdt->buf->len), - "DSDT", dsdt->buf->len, 1, NULL, NULL); + "DSDT", dsdt->buf->len, 1, pcms->oem_id, pcms->oem_table_= id); free_aml_allocator(); } =20 static void -build_hpet(GArray *table_data, BIOSLinker *linker) +build_hpet(GArray *table_data, BIOSLinker *linker, const char *oem_id, + const char *oem_table_id) { Acpi20Hpet *hpet; =20 @@ -1653,11 +1654,12 @@ build_hpet(GArray *table_data, BIOSLinker *linker) hpet->timer_block_id =3D cpu_to_le32(0x8086a201); hpet->addr.address =3D cpu_to_le64(HPET_BASE); build_header(linker, table_data, - (void *)hpet, "HPET", sizeof(*hpet), 1, NULL, NULL); + (void *)hpet, "HPET", sizeof(*hpet), 1, oem_id, oem_table= _id); } =20 static void -build_tpm_tcpa(GArray *table_data, BIOSLinker *linker, GArray *tcpalog) +build_tpm_tcpa(GArray *table_data, BIOSLinker *linker, GArray *tcpalog, + const char *oem_id, const char *oem_table_id) { Acpi20Tcpa *tcpa =3D acpi_data_push(table_data, sizeof *tcpa); unsigned log_addr_size =3D sizeof(tcpa->log_area_start_address); @@ -1677,7 +1679,7 @@ build_tpm_tcpa(GArray *table_data, BIOSLinker *linker= , GArray *tcpalog) ACPI_BUILD_TPMLOG_FILE, 0); =20 build_header(linker, table_data, - (void *)tcpa, "TCPA", sizeof(*tcpa), 2, NULL, NULL); + (void *)tcpa, "TCPA", sizeof(*tcpa), 2, oem_id, oem_table= _id); } =20 #define HOLE_640K_START (640 * KiB) @@ -1812,7 +1814,8 @@ build_srat(GArray *table_data, BIOSLinker *linker, Ma= chineState *machine) build_header(linker, table_data, (void *)(table_data->data + srat_start), "SRAT", - table_data->len - srat_start, 1, NULL, NULL); + table_data->len - srat_start, 1, pcms->oem_id, + pcms->oem_table_id); } =20 /* @@ -1820,7 +1823,8 @@ build_srat(GArray *table_data, BIOSLinker *linker, Ma= chineState *machine) * (version Oct. 2014 or later) */ static void -build_dmar_q35(GArray *table_data, BIOSLinker *linker) +build_dmar_q35(GArray *table_data, BIOSLinker *linker, const char *oem_id, + const char *oem_table_id) { int dmar_start =3D table_data->len; =20 @@ -1870,7 +1874,7 @@ build_dmar_q35(GArray *table_data, BIOSLinker *linker) } =20 build_header(linker, table_data, (void *)(table_data->data + dmar_star= t), - "DMAR", table_data->len - dmar_start, 1, NULL, NULL); + "DMAR", table_data->len - dmar_start, 1, oem_id, oem_tabl= e_id); } =20 /* @@ -1881,7 +1885,8 @@ build_dmar_q35(GArray *table_data, BIOSLinker *linker) * Helpful to speedup Windows guests and ignored by others. */ static void -build_waet(GArray *table_data, BIOSLinker *linker) +build_waet(GArray *table_data, BIOSLinker *linker, const char *oem_id, + const char *oem_table_id) { int waet_start =3D table_data->len; =20 @@ -1897,7 +1902,7 @@ build_waet(GArray *table_data, BIOSLinker *linker) build_append_int_noprefix(table_data, 1 << 1 /* ACPI PM timer good */,= 4); =20 build_header(linker, table_data, (void *)(table_data->data + waet_star= t), - "WAET", table_data->len - waet_start, 1, NULL, NULL); + "WAET", table_data->len - waet_start, 1, oem_id, oem_tabl= e_id); } =20 /* @@ -1999,7 +2004,8 @@ ivrs_host_bridges(Object *obj, void *opaque) } =20 static void -build_amd_iommu(GArray *table_data, BIOSLinker *linker) +build_amd_iommu(GArray *table_data, BIOSLinker *linker, const char *oem_id, + const char *oem_table_id) { int ivhd_table_len =3D 24; int iommu_start =3D table_data->len; @@ -2094,7 +2100,8 @@ build_amd_iommu(GArray *table_data, BIOSLinker *linke= r) } =20 build_header(linker, table_data, (void *)(table_data->data + iommu_sta= rt), - "IVRS", table_data->len - iommu_start, 1, NULL, NULL); + "IVRS", table_data->len - iommu_start, 1, oem_id, + oem_table_id); } =20 typedef @@ -2150,12 +2157,26 @@ void acpi_build(AcpiBuildTables *tables, MachineSta= te *machine) GArray *tables_blob =3D tables->table_data; AcpiSlicOem slic_oem =3D { .id =3D NULL, .table_id =3D NULL }; Object *vmgenid_dev; + char *oem_id; + char *oem_table_id; =20 acpi_get_pm_info(machine, &pm); acpi_get_misc_info(&misc); acpi_get_pci_holes(&pci_hole, &pci_hole64); acpi_get_slic_oem(&slic_oem); =20 + if (slic_oem.id) { + oem_id =3D slic_oem.id; + } else { + oem_id =3D pcms->oem_id; + } + + if (slic_oem.table_id) { + oem_table_id =3D slic_oem.table_id; + } else { + oem_table_id =3D pcms->oem_table_id; + } + table_offsets =3D g_array_new(false, true /* clear */, sizeof(uint32_t)); ACPI_BUILD_DPRINTF("init ACPI tables\n"); @@ -2189,32 +2210,35 @@ void acpi_build(AcpiBuildTables *tables, MachineSta= te *machine) pm.fadt.facs_tbl_offset =3D &facs; pm.fadt.dsdt_tbl_offset =3D &dsdt; pm.fadt.xdsdt_tbl_offset =3D &dsdt; - build_fadt(tables_blob, tables->linker, &pm.fadt, - slic_oem.id, slic_oem.table_id); + build_fadt(tables_blob, tables->linker, &pm.fadt, oem_id, oem_table_id= ); aml_len +=3D tables_blob->len - fadt; =20 acpi_add_table(table_offsets, tables_blob); acpi_build_madt(tables_blob, tables->linker, x86ms, - ACPI_DEVICE_IF(x86ms->acpi_dev)); + ACPI_DEVICE_IF(x86ms->acpi_dev), pcms->oem_id, + pcms->oem_table_id); =20 vmgenid_dev =3D find_vmgenid_dev(); if (vmgenid_dev) { acpi_add_table(table_offsets, tables_blob); vmgenid_build_acpi(VMGENID(vmgenid_dev), tables_blob, - tables->vmgenid, tables->linker); + tables->vmgenid, tables->linker, pcms->oem_id); } =20 if (misc.has_hpet) { acpi_add_table(table_offsets, tables_blob); - build_hpet(tables_blob, tables->linker); + build_hpet(tables_blob, tables->linker, pcms->oem_id, + pcms->oem_table_id); } if (misc.tpm_version !=3D TPM_VERSION_UNSPEC) { if (misc.tpm_version =3D=3D TPM_VERSION_1_2) { acpi_add_table(table_offsets, tables_blob); - build_tpm_tcpa(tables_blob, tables->linker, tables->tcpalog); + build_tpm_tcpa(tables_blob, tables->linker, tables->tcpalog, + pcms->oem_id, pcms->oem_table_id); } else { /* TPM_VERSION_2_0 */ acpi_add_table(table_offsets, tables_blob); - build_tpm2(tables_blob, tables->linker, tables->tcpalog); + build_tpm2(tables_blob, tables->linker, tables->tcpalog, + pcms->oem_id, pcms->oem_table_id); } } if (pcms->numa_nodes) { @@ -2222,34 +2246,40 @@ void acpi_build(AcpiBuildTables *tables, MachineSta= te *machine) build_srat(tables_blob, tables->linker, machine); if (machine->numa_state->have_numa_distance) { acpi_add_table(table_offsets, tables_blob); - build_slit(tables_blob, tables->linker, machine); + build_slit(tables_blob, tables->linker, machine, pcms->oem_id, + pcms->oem_table_id); } if (machine->numa_state->hmat_enabled) { acpi_add_table(table_offsets, tables_blob); - build_hmat(tables_blob, tables->linker, machine->numa_state); + build_hmat(tables_blob, tables->linker, machine->numa_state, + pcms->oem_id, pcms->oem_table_id); } } if (acpi_get_mcfg(&mcfg)) { acpi_add_table(table_offsets, tables_blob); - build_mcfg(tables_blob, tables->linker, &mcfg); + build_mcfg(tables_blob, tables->linker, &mcfg, pcms->oem_id, + pcms->oem_table_id); } if (x86_iommu_get_default()) { IommuType IOMMUType =3D x86_iommu_get_type(); if (IOMMUType =3D=3D TYPE_AMD) { acpi_add_table(table_offsets, tables_blob); - build_amd_iommu(tables_blob, tables->linker); + build_amd_iommu(tables_blob, tables->linker, pcms->oem_id, + pcms->oem_table_id); } else if (IOMMUType =3D=3D TYPE_INTEL) { acpi_add_table(table_offsets, tables_blob); - build_dmar_q35(tables_blob, tables->linker); + build_dmar_q35(tables_blob, tables->linker, pcms->oem_id, + pcms->oem_table_id); } } if (machine->nvdimms_state->is_enabled) { nvdimm_build_acpi(table_offsets, tables_blob, tables->linker, - machine->nvdimms_state, machine->ram_slots); + machine->nvdimms_state, machine->ram_slots, + pcms->oem_id, pcms->oem_table_id); } =20 acpi_add_table(table_offsets, tables_blob); - build_waet(tables_blob, tables->linker); + build_waet(tables_blob, tables->linker, pcms->oem_id, pcms->oem_table_= id); =20 /* Add tables supplied by user (if any) */ for (u =3D acpi_table_first(); u; u =3D acpi_table_next(u)) { @@ -2262,13 +2292,13 @@ void acpi_build(AcpiBuildTables *tables, MachineSta= te *machine) /* RSDT is pointed to by RSDP */ rsdt =3D tables_blob->len; build_rsdt(tables_blob, tables->linker, table_offsets, - slic_oem.id, slic_oem.table_id); + oem_id, oem_table_id); =20 /* RSDP is in FSEG memory, so allocate it separately */ { AcpiRsdpData rsdp_data =3D { .revision =3D 0, - .oem_id =3D ACPI_BUILD_APPNAME6, + .oem_id =3D pcms->oem_id, .xsdt_tbl_offset =3D NULL, .rsdt_tbl_offset =3D &rsdt, }; diff --git a/hw/i386/acpi-common.c b/hw/i386/acpi-common.c index a6a30e8363..1f5947fcf9 100644 --- a/hw/i386/acpi-common.c +++ b/hw/i386/acpi-common.c @@ -72,7 +72,8 @@ void pc_madt_cpu_entry(AcpiDeviceIf *adev, int uid, } =20 void acpi_build_madt(GArray *table_data, BIOSLinker *linker, - X86MachineState *x86ms, AcpiDeviceIf *adev) + X86MachineState *x86ms, AcpiDeviceIf *adev, + const char *oem_id, const char *oem_table_id) { MachineClass *mc =3D MACHINE_GET_CLASS(x86ms); const CPUArchIdList *apic_ids =3D mc->possible_cpu_arch_ids(MACHINE(x8= 6ms)); @@ -157,6 +158,6 @@ void acpi_build_madt(GArray *table_data, BIOSLinker *li= nker, =20 build_header(linker, table_data, (void *)(table_data->data + madt_start), "APIC", - table_data->len - madt_start, 1, NULL, NULL); + table_data->len - madt_start, 1, oem_id, oem_table_id); } =20 diff --git a/hw/i386/acpi-microvm.c b/hw/i386/acpi-microvm.c index d34a301b84..54b3af478a 100644 --- a/hw/i386/acpi-microvm.c +++ b/hw/i386/acpi-microvm.c @@ -149,7 +149,7 @@ build_dsdt_microvm(GArray *table_data, BIOSLinker *link= er, g_array_append_vals(table_data, dsdt->buf->data, dsdt->buf->len); build_header(linker, table_data, (void *)(table_data->data + table_data->len - dsdt->buf->len), - "DSDT", dsdt->buf->len, 2, NULL, NULL); + "DSDT", dsdt->buf->len, 2, mms->oem_id, mms->oem_table_id= ); free_aml_allocator(); } =20 @@ -201,21 +201,24 @@ static void acpi_build_microvm(AcpiBuildTables *table= s, pmfadt.dsdt_tbl_offset =3D &dsdt; pmfadt.xdsdt_tbl_offset =3D &dsdt; acpi_add_table(table_offsets, tables_blob); - build_fadt(tables_blob, tables->linker, &pmfadt, NULL, NULL); + build_fadt(tables_blob, tables->linker, &pmfadt, mms->oem_id, + mms->oem_table_id); =20 acpi_add_table(table_offsets, tables_blob); acpi_build_madt(tables_blob, tables->linker, X86_MACHINE(machine), - ACPI_DEVICE_IF(x86ms->acpi_dev)); + ACPI_DEVICE_IF(x86ms->acpi_dev), mms->oem_id, + mms->oem_table_id); =20 xsdt =3D tables_blob->len; - build_xsdt(tables_blob, tables->linker, table_offsets, NULL, NULL); + build_xsdt(tables_blob, tables->linker, table_offsets, mms->oem_id, + mms->oem_table_id); =20 /* RSDP is in FSEG memory, so allocate it separately */ { AcpiRsdpData rsdp_data =3D { /* ACPI 2.0: 5.2.4.3 RSDP Structure */ .revision =3D 2, /* xsdt needs v2 */ - .oem_id =3D ACPI_BUILD_APPNAME6, + .oem_id =3D mms->oem_id, .xsdt_tbl_offset =3D &xsdt, .rsdt_tbl_offset =3D NULL, }; diff --git a/hw/i386/microvm.c b/hw/i386/microvm.c index edf2b0f061..1dc2956e72 100644 --- a/hw/i386/microvm.c +++ b/hw/i386/microvm.c @@ -648,6 +648,51 @@ static void microvm_powerdown_req(Notifier *notifier, = void *data) } } =20 +static char *microvm_machine_get_oem_id(Object *obj, Error **errp) +{ + MicrovmMachineState *mms =3D MICROVM_MACHINE(obj); + + return g_strdup(mms->oem_id); +} + +static void microvm_machine_set_oem_id(Object *obj, const char *value, + Error **errp) +{ + MicrovmMachineState *mms =3D MICROVM_MACHINE(obj); + size_t len =3D strlen(value); + + if (len > 6) { + error_setg(errp, + "User specified "MICROVM_MACHINE_OEM_ID" value is bigger than " + "6 bytes in size"); + return; + } + + strncpy(mms->oem_id, value, len + 1); +} + +static char *microvm_machine_get_oem_table_id(Object *obj, Error **errp) +{ + MicrovmMachineState *mms =3D MICROVM_MACHINE(obj); + + return g_strdup(mms->oem_table_id); +} + +static void microvm_machine_set_oem_table_id(Object *obj, const char *valu= e, + Error **errp) +{ + MicrovmMachineState *mms =3D MICROVM_MACHINE(obj); + size_t len =3D strlen(value); + + if (len > 8) { + error_setg(errp, + "User specified "MICROVM_MACHINE_OEM_TABLE_ID" value is bigger t= han " + "8 bytes in size"); + return; + } + strncpy(mms->oem_table_id, value, len + 1); +} + static void microvm_machine_initfn(Object *obj) { MicrovmMachineState *mms =3D MICROVM_MACHINE(obj); @@ -669,6 +714,9 @@ static void microvm_machine_initfn(Object *obj) qemu_add_machine_init_done_notifier(&mms->machine_done); mms->powerdown_req.notify =3D microvm_powerdown_req; qemu_register_powerdown_notifier(&mms->powerdown_req); + + mms->oem_id =3D g_strndup(ACPI_BUILD_APPNAME6, 6); + mms->oem_table_id =3D g_strndup(ACPI_BUILD_APPNAME8, 8); } =20 static void microvm_class_init(ObjectClass *oc, void *data) @@ -757,6 +805,24 @@ static void microvm_class_init(ObjectClass *oc, void *= data) MICROVM_MACHINE_AUTO_KERNEL_CMDLINE, "Set off to disable adding virtio-mmio devices to the kernel cmdli= ne"); =20 + object_class_property_add_str(oc, MICROVM_MACHINE_OEM_ID, + microvm_machine_get_oem_id, + microvm_machine_set_oem_id); + object_class_property_set_description(oc, MICROVM_MACHINE_OEM_ID, + "Override the default value of f= ield OEMID " + "in ACPI table header." + "The string may be up to 6 bytes= in size"); + + + object_class_property_add_str(oc, MICROVM_MACHINE_OEM_TABLE_ID, + microvm_machine_get_oem_table_id, + microvm_machine_set_oem_table_id); + object_class_property_set_description(oc, MICROVM_MACHINE_OEM_TABLE_ID, + "Override the default value of f= ield OEM Table ID " + "in ACPI table header." + "The string may be up to 8 bytes= in size"); + + machine_class_allow_dynamic_sysbus_dev(mc, TYPE_RAMFB_DEVICE); } =20 diff --git a/hw/i386/pc.c b/hw/i386/pc.c index 5458f61d10..437977c49e 100644 --- a/hw/i386/pc.c +++ b/hw/i386/pc.c @@ -1611,6 +1611,50 @@ static void pc_machine_set_max_fw_size(Object *obj, = Visitor *v, pcms->max_fw_size =3D value; } =20 +static char *pc_machine_get_oem_id(Object *obj, Error **errp) +{ + PCMachineState *pcms =3D PC_MACHINE(obj); + + return g_strdup(pcms->oem_id); +} + +static void pc_machine_set_oem_id(Object *obj, const char *value, Error **= errp) +{ + PCMachineState *pcms =3D PC_MACHINE(obj); + size_t len =3D strlen(value); + + if (len > 6) { + error_setg(errp, + "User specified "PC_MACHINE_OEM_ID" value is bigger than " + "6 bytes in size"); + return; + } + + strncpy(pcms->oem_id, value, len + 1); +} + +static char *pc_machine_get_oem_table_id(Object *obj, Error **errp) +{ + PCMachineState *pcms =3D PC_MACHINE(obj); + + return g_strdup(pcms->oem_table_id); +} + +static void pc_machine_set_oem_table_id(Object *obj, const char *value, + Error **errp) +{ + PCMachineState *pcms =3D PC_MACHINE(obj); + size_t len =3D strlen(value); + + if (len > 8) { + error_setg(errp, + "User specified "PC_MACHINE_OEM_TABLE_ID" value is bigger than " + "8 bytes in size"); + return; + } + strncpy(pcms->oem_table_id, value, len + 1); +} + static void pc_machine_initfn(Object *obj) { PCMachineState *pcms =3D PC_MACHINE(obj); @@ -1623,6 +1667,8 @@ static void pc_machine_initfn(Object *obj) pcms->max_ram_below_4g =3D 0; /* use default */ /* acpi build is enabled by default if machine supports it */ pcms->acpi_build_enabled =3D PC_MACHINE_GET_CLASS(pcms)->has_acpi_buil= d; + pcms->oem_id =3D g_strndup(ACPI_BUILD_APPNAME6, 6); + pcms->oem_table_id =3D g_strndup(ACPI_BUILD_APPNAME8, 8); pcms->smbus_enabled =3D true; pcms->sata_enabled =3D true; pcms->pit_enabled =3D true; @@ -1759,6 +1805,24 @@ static void pc_machine_class_init(ObjectClass *oc, v= oid *data) NULL, NULL); object_class_property_set_description(oc, PC_MACHINE_MAX_FW_SIZE, "Maximum combined firmware size"); + + object_class_property_add_str(oc, PC_MACHINE_OEM_ID, + pc_machine_get_oem_id, + pc_machine_set_oem_id); + object_class_property_set_description(oc, PC_MACHINE_OEM_ID, + "Override the default value of f= ield OEMID " + "in ACPI table header." + "The string may be up to 6 bytes= in size"); + + + object_class_property_add_str(oc, PC_MACHINE_OEM_TABLE_ID, + pc_machine_get_oem_table_id, + pc_machine_set_oem_table_id); + object_class_property_set_description(oc, PC_MACHINE_OEM_TABLE_ID, + "Override the default value of f= ield OEM Table ID " + "in ACPI table header." + "The string may be up to 8 bytes= in size"); + } =20 static const TypeInfo pc_machine_info =3D { --=20 MST From nobody Sun Feb 8 09:27:43 2026 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=fail; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=fail(p=none dis=none) header.from=redhat.com ARC-Seal: i=1; a=rsa-sha256; t=1612542273; cv=none; d=zohomail.com; s=zohoarc; b=lL+EzAWBm/6lRmGtM150p5jTS/vsL9vOsvlYDom1S8mQgoHXGgPo8ZcHnw9crWDjCp20dICEQ8Z1WHdb00LpwhHfFAxiODk4fupD7zu1Pvv7AmMlZNhxY9QqGM+ecYJflrs4HlDADnLUTdIy6lX/YkJm5f6TzfqkUH03Zl74FEo= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1612542273; h=Content-Type:Content-Transfer-Encoding:Cc:Date:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:To; bh=hzZaM6geEFIvP4T3KqYpbT6FM3FQrM9kRnMR3GRsHFU=; b=Z51bvPo0OLG8ff+CqTTMOlXUmP94uT2GUiyHabkJf4KNQ4v9y+H+zA2UKoKG1N072Q3PmzaeZRP6nWD2MZm/TCCsS4cFaue0yd9MPS75h0aBH2R7g/RrfNcCpJBMVaEFMbEhGHD8QC71Gt/GAVqubUuYatnnR+vLvjurxp4MTGQ= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=fail; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=fail header.from= (p=none dis=none) header.from= Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1612542273235588.2108614209001; Fri, 5 Feb 2021 08:24:33 -0800 (PST) Received: from localhost ([::1]:47042 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1l82ry-0003T8-7T for importer@patchew.org; Fri, 05 Feb 2021 10:18:02 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]:48096) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1l82eg-0004bw-Kv for qemu-devel@nongnu.org; Fri, 05 Feb 2021 10:04:18 -0500 Received: from us-smtp-delivery-124.mimecast.com ([63.128.21.124]:22129) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA1:256) (Exim 4.90_1) (envelope-from ) id 1l82ed-000376-GC for qemu-devel@nongnu.org; Fri, 05 Feb 2021 10:04:18 -0500 Received: from mail-ed1-f69.google.com (mail-ed1-f69.google.com [209.85.208.69]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-150-I4iVto4MNQC91PoFGmrcJw-1; Fri, 05 Feb 2021 10:04:11 -0500 Received: by mail-ed1-f69.google.com with SMTP id f4so7021567eds.5 for ; Fri, 05 Feb 2021 07:04:11 -0800 (PST) Received: from redhat.com (bzq-79-180-2-31.red.bezeqint.net. [79.180.2.31]) by smtp.gmail.com with ESMTPSA id bf8sm4209574edb.34.2021.02.05.07.04.07 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 05 Feb 2021 07:04:08 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1612537454; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=hzZaM6geEFIvP4T3KqYpbT6FM3FQrM9kRnMR3GRsHFU=; b=gQ+iiZC9jQOH7NZJ/YwZ86T1f93B8y1ely/yM5/VsTW1R+GGevbTwOLBOoGUPsaXPEzwrH 6e5cGF2Bb+9L/jDVqzvlz8J0MGGL2iZbN4+gXGPIoCIqX9guaTJ8Q+i8hlqGJlf75LbA0i jDmGmuinCQbe6wN6wFyJ7o5oENU0Q60= X-MC-Unique: I4iVto4MNQC91PoFGmrcJw-1 X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:content-transfer-encoding :in-reply-to; bh=hzZaM6geEFIvP4T3KqYpbT6FM3FQrM9kRnMR3GRsHFU=; b=j2zPT7N4mzs9zMaN22PnTehUolqI1cGrD9ZVOQjSA5815QaH16FBCmUdFYlv3oSyFT 5wi9neZ1El0oy6FrXiPLz5/7kg9cf5t49f+IPVLgCW6hZyQyFfWwFUI5yvuK1FA8tmfg lxtwWmlK64XHZE3l5X1LCkb/Uo59yJ04cLwBudPZdwBghCWnINUttloyDwgrhs91++73 1SBFbWRpAYG4h40lP95a2xWhT8cP3lHTKh1zpTb5ZF/I7CTIwPSTrSisUPCFh/77+cFJ 3CArfWqseJpmiPgjhlufXujWKQSSIJCP4rlJfg/iMNaxZp7/RcKKi1IynG+2yHYcA7vZ 26zg== X-Gm-Message-State: AOAM531xDNGB3aH6LybLloNUeWx9NylvHRJePYGS+Vyfk5SSzxiDfPUG gjl1j1piUNHGDU9+6+ZrxeZ+MgcljxwECFQg5qyh3Wb7WdO6Dh9JKI9qAVoNE4atMy2WnGE37tk 0/i3ARkQgTcG28Aey2HC4fpq6puUh9kcnxA++Hw91zLMe1azMsLN3cuzAjXgn X-Received: by 2002:a17:906:33d9:: with SMTP id w25mr4266762eja.489.1612537449626; Fri, 05 Feb 2021 07:04:09 -0800 (PST) X-Google-Smtp-Source: ABdhPJyqHeEYSGmVQojrrBwDv2U3Anrvj9u4F1J+7HbqYsLWNRlrmR2p6mCVkIV7xAVxyDeDlG0oog== X-Received: by 2002:a17:906:33d9:: with SMTP id w25mr4266722eja.489.1612537449393; Fri, 05 Feb 2021 07:04:09 -0800 (PST) Date: Fri, 5 Feb 2021 10:04:06 -0500 From: "Michael S. Tsirkin" To: qemu-devel@nongnu.org Subject: [PULL v2 13/16] acpi: use constants as strncpy limit Message-ID: <20210205150135.94643-14-mst@redhat.com> References: <20210205150135.94643-1-mst@redhat.com> MIME-Version: 1.0 In-Reply-To: <20210205150135.94643-1-mst@redhat.com> X-Mailer: git-send-email 2.27.0.106.g8ac3dc51b1 X-Mutt-Fcc: =sent Authentication-Results: relay.mimecast.com; auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=mst@redhat.com X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset="utf-8" Content-Disposition: inline Content-Transfer-Encoding: quoted-printable Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Received-SPF: pass client-ip=63.128.21.124; envelope-from=mst@redhat.com; helo=us-smtp-delivery-124.mimecast.com X-Spam_score_int: -30 X-Spam_score: -3.1 X-Spam_bar: --- X-Spam_report: (-3.1 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.352, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_LOW=-0.7, RCVD_IN_MSPIKE_H4=0.001, RCVD_IN_MSPIKE_WL=0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=unavailable autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Peter Maydell , Eduardo Habkost , Sergio Lopez , Richard Henderson , qemu-arm@nongnu.org, Paolo Bonzini Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: "Qemu-devel" X-ZohoMail-DKIM: fail (Header signature does not verify) gcc is not smart enough to figure out length was validated before use as strncpy limit, resulting in this warning: inlined from =E2=80=98virt_set_oem_table_id=E2=80=99 at ../../hw/arm/virt.c= :2197:5: /usr/include/aarch64-linux-gnu/bits/string_fortified.h:106:10: error: =E2=80=98__builtin_strncpy=E2=80=99 specified bound depends on the length o= f the source argument [-Werror=3Dstringop-overflow=3D] Simplify things by using a constant limit instead. Fixes: 97fc5d507fca ("acpi: Permit OEM ID and OEM table ID fields to be cha= nged") Signed-off-by: Michael S. Tsirkin --- hw/arm/virt.c | 4 ++-- hw/i386/microvm.c | 4 ++-- hw/i386/pc.c | 4 ++-- 3 files changed, 6 insertions(+), 6 deletions(-) diff --git a/hw/arm/virt.c b/hw/arm/virt.c index 0c65fe38a0..371147f3ae 100644 --- a/hw/arm/virt.c +++ b/hw/arm/virt.c @@ -2173,7 +2173,7 @@ static void virt_set_oem_id(Object *obj, const char *= value, Error **errp) return; } =20 - strncpy(vms->oem_id, value, len + 1); + strncpy(vms->oem_id, value, 6); } =20 static char *virt_get_oem_table_id(Object *obj, Error **errp) @@ -2194,7 +2194,7 @@ static void virt_set_oem_table_id(Object *obj, const = char *value, "User specified oem-table-id value is bigger than 8 byt= es in size"); return; } - strncpy(vms->oem_table_id, value, len + 1); + strncpy(vms->oem_table_id, value, 8); } =20 =20 diff --git a/hw/i386/microvm.c b/hw/i386/microvm.c index 1dc2956e72..4e0cf4c522 100644 --- a/hw/i386/microvm.c +++ b/hw/i386/microvm.c @@ -668,7 +668,7 @@ static void microvm_machine_set_oem_id(Object *obj, con= st char *value, return; } =20 - strncpy(mms->oem_id, value, len + 1); + strncpy(mms->oem_id, value, 6); } =20 static char *microvm_machine_get_oem_table_id(Object *obj, Error **errp) @@ -690,7 +690,7 @@ static void microvm_machine_set_oem_table_id(Object *ob= j, const char *value, "8 bytes in size"); return; } - strncpy(mms->oem_table_id, value, len + 1); + strncpy(mms->oem_table_id, value, 8); } =20 static void microvm_machine_initfn(Object *obj) diff --git a/hw/i386/pc.c b/hw/i386/pc.c index 437977c49e..8aa85dec54 100644 --- a/hw/i386/pc.c +++ b/hw/i386/pc.c @@ -1630,7 +1630,7 @@ static void pc_machine_set_oem_id(Object *obj, const = char *value, Error **errp) return; } =20 - strncpy(pcms->oem_id, value, len + 1); + strncpy(pcms->oem_id, value, 6); } =20 static char *pc_machine_get_oem_table_id(Object *obj, Error **errp) @@ -1652,7 +1652,7 @@ static void pc_machine_set_oem_table_id(Object *obj, = const char *value, "8 bytes in size"); return; } - strncpy(pcms->oem_table_id, value, len + 1); + strncpy(pcms->oem_table_id, value, 8); } =20 static void pc_machine_initfn(Object *obj) --=20 MST From nobody Sun Feb 8 09:27:43 2026 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass(p=none dis=none) header.from=redhat.com ARC-Seal: i=1; a=rsa-sha256; t=1612539738; cv=none; d=zohomail.com; s=zohoarc; b=n5u3zLjiTIKv+eP8jkwKM5+QExX0KjyTMqaN2pjRMLR2m20Pje5DbddPAhZi49BhJLzve+GOS9vP7UsO49+1V0pbG2FbF0OxEf4Vly5bs4kjgfLa+A3lK4U5YTznjQcuU5x9n1LIvX845lsD0+UDsTFT+Ambr/tVTLcKPCBdu6Y= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1612539738; h=Content-Type:Cc:Date:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:To; bh=7kUFX9AmsgkZPsv6dHdddK3V3nr3r0gT8vGMVZWZW88=; b=Z0xuboFpHvZKjmsauFICLoLlfzkXAwK07MdqZBLxT7u7zQN7RkNxNUYJG/vsTdJT4tVXOQQNh2DVwXTmOkADJuSIUI5sDO2WcTT9w70uz3Wtaj8HNWJ/Mi2tX9hDxxAttaThYFTU9YyWAelqC4ZU3Gyd727dNxCbJHifM4Q62Kw= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass header.from= (p=none dis=none) header.from= Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1612539738030925.4961141722447; Fri, 5 Feb 2021 07:42:18 -0800 (PST) Received: from localhost ([::1]:60118 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1l82vW-0000ec-1M for importer@patchew.org; Fri, 05 Feb 2021 10:21:42 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]:48186) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1l82f0-0004jj-0U for qemu-devel@nongnu.org; Fri, 05 Feb 2021 10:04:38 -0500 Received: from us-smtp-delivery-124.mimecast.com ([216.205.24.124]:25841) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA1:256) (Exim 4.90_1) (envelope-from ) id 1l82eq-0003Ah-3x for qemu-devel@nongnu.org; Fri, 05 Feb 2021 10:04:37 -0500 Received: from mail-ej1-f72.google.com (mail-ej1-f72.google.com [209.85.218.72]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-585-T-BbwkBaPQiomDtDCCXoKw-1; Fri, 05 Feb 2021 10:04:21 -0500 Received: by mail-ej1-f72.google.com with SMTP id m4so6803435ejc.14 for ; Fri, 05 Feb 2021 07:04:21 -0800 (PST) Received: from redhat.com (bzq-79-180-2-31.red.bezeqint.net. [79.180.2.31]) by smtp.gmail.com with ESMTPSA id f22sm4029480eje.34.2021.02.05.07.04.10 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 05 Feb 2021 07:04:11 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1612537463; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=7kUFX9AmsgkZPsv6dHdddK3V3nr3r0gT8vGMVZWZW88=; b=MORKwZvpSmyOdszRtJPtFsw06DvEWya4d192CNsGIiNU4WAyFr4Ltynk+L4bnpwDm8sTRV BCUtVKWcDiRb34IVxSpevrdQq7SiW4WixnXStS2hYdkNJJQRh9vBvFVoj+7Tv7s46UxBfM VrbQhEAEG4AX4B22YoB/bKejsT8xeao= X-MC-Unique: T-BbwkBaPQiomDtDCCXoKw-1 X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=7kUFX9AmsgkZPsv6dHdddK3V3nr3r0gT8vGMVZWZW88=; b=VL/7HaXCJ4k4og6rfrbAFOf6EVQI3tF+Yv315PArd+0LhwDHXps9FkP8+KVp4E3rKu yoDQreiLTueQciYBRZGaxoMgdtbxiU5rNOoR4AC/Pog+/NJ8jqUpoJ5I2HvGneCH1AML bTxtJe24dCAkRkrI9Wa77nqp0ZyfeOIw4Hk+x8cySBKhjB2AD2pipYyDzSzLSuali3nG 4YwBmwnhaQDMvNvh2VJpldQT5bu8C1Jz927IEHAfnIp7OmUdLrNee4mMVrjhBK7OF9dB H9MOHSYQnzaW1YOm1DYzYYoVFLOQneHmsDi59GMqOoebFJhk1Br0SQggxc3FzeKL0Ow3 GomQ== X-Gm-Message-State: AOAM533jan1gZXrLxgwgRFcR05NVZdlx5SVOMSlP9jP+gI7NmewGfoYt v3kZ0kKALItKrEX5gGN5LS0yX12RpeoDbP+OBGPKqh6zv4x/v/9MI12x9ug1VRwsgmh5pZ9bREa SFIxIJWvmbtn5O5C60T2s4NGDI0fueU/ZDRqqPPYme1Vx6AHkgk22e7Be6pmG X-Received: by 2002:a17:907:3f29:: with SMTP id hq41mr4429896ejc.227.1612537457258; Fri, 05 Feb 2021 07:04:17 -0800 (PST) X-Google-Smtp-Source: ABdhPJwEX0a9g5Bj8Y2CkVzdy3Zbt264KigQkbUzCABPQwsNUf12C1yjWyPVG5UnqGNEIqroR0BZ5Q== X-Received: by 2002:a17:907:3f29:: with SMTP id hq41mr4429458ejc.227.1612537452460; Fri, 05 Feb 2021 07:04:12 -0800 (PST) Date: Fri, 5 Feb 2021 10:04:09 -0500 From: "Michael S. Tsirkin" To: qemu-devel@nongnu.org Subject: [PULL v2 14/16] tests/acpi: add OEM ID and OEM TABLE ID test Message-ID: <20210205150135.94643-15-mst@redhat.com> References: <20210205150135.94643-1-mst@redhat.com> MIME-Version: 1.0 In-Reply-To: <20210205150135.94643-1-mst@redhat.com> X-Mailer: git-send-email 2.27.0.106.g8ac3dc51b1 X-Mutt-Fcc: =sent Authentication-Results: relay.mimecast.com; auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=mst@redhat.com X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Disposition: inline Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Received-SPF: pass client-ip=216.205.24.124; envelope-from=mst@redhat.com; helo=us-smtp-delivery-124.mimecast.com X-Spam_score_int: -30 X-Spam_score: -3.1 X-Spam_bar: --- X-Spam_report: (-3.1 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.352, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_LOW=-0.7, RCVD_IN_MSPIKE_H3=0.001, RCVD_IN_MSPIKE_WL=0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Peter Maydell , Marian Postevca , Igor Mammedov Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: "Qemu-devel" X-ZohoMail-DKIM: pass (identity @redhat.com) Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" From: Marian Postevca Add support for testing the fields OEM ID and OEM TABLE ID in all ACPI tables for PC,Q35,MICROVM,AARCH64 Full diff of changed files disassembly: Table tests/data/acpi/virt/FACP diff: @@ -3,7 +3,7 @@ * AML/ASL+ Disassembler version 20200326 (64-bit version) * Copyright (c) 2000 - 2020 Intel Corporation * - * Disassembly of tests/data/acpi/virt/FACP, Mon Jan 18 23:55:00 2021 + * Disassembly of /tmp/aml-VQIIX0, Mon Jan 18 23:55:00 2021 * * ACPI Data Table [FACP] * @@ -13,9 +13,9 @@ [000h 0000 4] Signature : "FACP" [Fixed ACPI Descr= iption Table (FADT)] [004h 0004 4] Table Length : 0000010C [008h 0008 1] Revision : 05 -[009h 0009 1] Checksum : BB +[009h 0009 1] Checksum : 55 [00Ah 0010 6] Oem ID : "BOCHS " -[010h 0016 8] Oem Table ID : "BXPCFACP" +[010h 0016 8] Oem Table ID : "BXPC " [018h 0024 4] Oem Revision : 00000001 [01Ch 0028 4] Asl Compiler ID : "BXPC" [020h 0032 4] Asl Compiler Revision : 00000001 Table tests/data/acpi/virt/APIC diff: @@ -3,7 +3,7 @@ * AML/ASL+ Disassembler version 20200326 (64-bit version) * Copyright (c) 2000 - 2020 Intel Corporation * - * Disassembly of tests/data/acpi/virt/APIC, Mon Jan 18 23:55:00 2021 + * Disassembly of /tmp/aml-BQIIX0, Mon Jan 18 23:55:00 2021 * * ACPI Data Table [APIC] * @@ -13,9 +13,9 @@ [000h 0000 4] Signature : "APIC" [Multiple APIC De= scription Table (MADT)] [004h 0004 4] Table Length : 000000A8 [008h 0008 1] Revision : 03 -[009h 0009 1] Checksum : B3 +[009h 0009 1] Checksum : 50 [00Ah 0010 6] Oem ID : "BOCHS " -[010h 0016 8] Oem Table ID : "BXPCAPIC" +[010h 0016 8] Oem Table ID : "BXPC " [018h 0024 4] Oem Revision : 00000001 [01Ch 0028 4] Asl Compiler ID : "BXPC" [020h 0032 4] Asl Compiler Revision : 00000001 Table tests/data/acpi/virt/GTDT diff: @@ -3,7 +3,7 @@ * AML/ASL+ Disassembler version 20200326 (64-bit version) * Copyright (c) 2000 - 2020 Intel Corporation * - * Disassembly of tests/data/acpi/virt/GTDT, Mon Jan 18 23:55:00 2021 + * Disassembly of /tmp/aml-QQIIX0, Mon Jan 18 23:55:00 2021 * * ACPI Data Table [GTDT] * @@ -13,9 +13,9 @@ [000h 0000 4] Signature : "GTDT" [Generic Timer De= scription Table] [004h 0004 4] Table Length : 00000060 [008h 0008 1] Revision : 02 -[009h 0009 1] Checksum : D9 +[009h 0009 1] Checksum : 8C [00Ah 0010 6] Oem ID : "BOCHS " -[010h 0016 8] Oem Table ID : "BXPCGTDT" +[010h 0016 8] Oem Table ID : "BXPC " [018h 0024 4] Oem Revision : 00000001 [01Ch 0028 4] Asl Compiler ID : "BXPC" [020h 0032 4] Asl Compiler Revision : 00000001 Table tests/data/acpi/virt/MCFG diff: @@ -3,7 +3,7 @@ * AML/ASL+ Disassembler version 20200326 (64-bit version) * Copyright (c) 2000 - 2020 Intel Corporation * - * Disassembly of tests/data/acpi/virt/MCFG, Mon Jan 18 23:55:00 2021 + * Disassembly of /tmp/aml-OQIIX0, Mon Jan 18 23:55:00 2021 * * ACPI Data Table [MCFG] * @@ -13,9 +13,9 @@ [000h 0000 4] Signature : "MCFG" [Memory Mapped Co= nfiguration table] [004h 0004 4] Table Length : 0000003C [008h 0008 1] Revision : 01 -[009h 0009 1] Checksum : 4F +[009h 0009 1] Checksum : EC [00Ah 0010 6] Oem ID : "BOCHS " -[010h 0016 8] Oem Table ID : "BXPCMCFG" +[010h 0016 8] Oem Table ID : "BXPC " [018h 0024 4] Oem Revision : 00000001 [01Ch 0028 4] Asl Compiler ID : "BXPC" [020h 0032 4] Asl Compiler Revision : 00000001 Table tests/data/acpi/virt/SPCR diff: @@ -3,7 +3,7 @@ * AML/ASL+ Disassembler version 20200326 (64-bit version) * Copyright (c) 2000 - 2020 Intel Corporation * - * Disassembly of tests/data/acpi/virt/SPCR, Mon Jan 18 23:55:00 2021 + * Disassembly of /tmp/aml-EMIIX0, Mon Jan 18 23:55:00 2021 * * ACPI Data Table [SPCR] * @@ -13,9 +13,9 @@ [000h 0000 4] Signature : "SPCR" [Serial Port Cons= ole Redirection table] [004h 0004 4] Table Length : 00000050 [008h 0008 1] Revision : 02 -[009h 0009 1] Checksum : 13 +[009h 0009 1] Checksum : CB [00Ah 0010 6] Oem ID : "BOCHS " -[010h 0016 8] Oem Table ID : "BXPCSPCR" +[010h 0016 8] Oem Table ID : "BXPC " [018h 0024 4] Oem Revision : 00000001 [01Ch 0028 4] Asl Compiler ID : "BXPC" [020h 0032 4] Asl Compiler Revision : 00000001 Table tests/data/acpi/virt/DSDT diff: @@ -5,20 +5,20 @@ * * Disassembling to symbolic ASL+ operators * - * Disassembly of tests/data/acpi/virt/DSDT, Mon Jan 18 23:55:00 2021 + * Disassembly of /tmp/aml-RMIIX0, Mon Jan 18 23:55:00 2021 * * Original Table Header: * Signature "DSDT" * Length 0x00001454 (5204) * Revision 0x02 - * Checksum 0x60 + * Checksum 0x0F * OEM ID "BOCHS " - * OEM Table ID "BXPCDSDT" + * OEM Table ID "BXPC " * OEM Revision 0x00000001 (1) * Compiler ID "BXPC" * Compiler Version 0x00000001 (1) */ -DefinitionBlock ("", "DSDT", 2, "BOCHS ", "BXPCDSDT", 0x00000001) +DefinitionBlock ("", "DSDT", 2, "BOCHS ", "BXPC ", 0x00000001) { Scope (\_SB) { Table tests/data/acpi/virt/FACP.numamem diff: @@ -3,7 +3,7 @@ * AML/ASL+ Disassembler version 20200326 (64-bit version) * Copyright (c) 2000 - 2020 Intel Corporation * - * Disassembly of tests/data/acpi/virt/FACP.numamem, Mon Jan 18 23:55:27 2= 021 + * Disassembly of /tmp/aml-JROMX0, Mon Jan 18 23:55:27 2021 * * ACPI Data Table [FACP] * @@ -13,9 +13,9 @@ [000h 0000 4] Signature : "FACP" [Fixed ACPI Descr= iption Table (FADT)] [004h 0004 4] Table Length : 0000010C [008h 0008 1] Revision : 05 -[009h 0009 1] Checksum : BB +[009h 0009 1] Checksum : 55 [00Ah 0010 6] Oem ID : "BOCHS " -[010h 0016 8] Oem Table ID : "BXPCFACP" +[010h 0016 8] Oem Table ID : "BXPC " [018h 0024 4] Oem Revision : 00000001 [01Ch 0028 4] Asl Compiler ID : "BXPC" [020h 0032 4] Asl Compiler Revision : 00000001 Table tests/data/acpi/virt/APIC.numamem diff: @@ -3,7 +3,7 @@ * AML/ASL+ Disassembler version 20200326 (64-bit version) * Copyright (c) 2000 - 2020 Intel Corporation * - * Disassembly of tests/data/acpi/virt/APIC.numamem, Mon Jan 18 23:55:27 2= 021 + * Disassembly of /tmp/aml-2ROMX0, Mon Jan 18 23:55:27 2021 * * ACPI Data Table [APIC] * @@ -13,9 +13,9 @@ [000h 0000 4] Signature : "APIC" [Multiple APIC De= scription Table (MADT)] [004h 0004 4] Table Length : 000000A8 [008h 0008 1] Revision : 03 -[009h 0009 1] Checksum : B3 +[009h 0009 1] Checksum : 50 [00Ah 0010 6] Oem ID : "BOCHS " -[010h 0016 8] Oem Table ID : "BXPCAPIC" +[010h 0016 8] Oem Table ID : "BXPC " [018h 0024 4] Oem Revision : 00000001 [01Ch 0028 4] Asl Compiler ID : "BXPC" [020h 0032 4] Asl Compiler Revision : 00000001 Table tests/data/acpi/virt/GTDT.numamem diff: @@ -3,7 +3,7 @@ * AML/ASL+ Disassembler version 20200326 (64-bit version) * Copyright (c) 2000 - 2020 Intel Corporation * - * Disassembly of tests/data/acpi/virt/GTDT.numamem, Mon Jan 18 23:55:27 2= 021 + * Disassembly of /tmp/aml-WROMX0, Mon Jan 18 23:55:27 2021 * * ACPI Data Table [GTDT] * @@ -13,9 +13,9 @@ [000h 0000 4] Signature : "GTDT" [Generic Timer De= scription Table] [004h 0004 4] Table Length : 00000060 [008h 0008 1] Revision : 02 -[009h 0009 1] Checksum : D9 +[009h 0009 1] Checksum : 8C [00Ah 0010 6] Oem ID : "BOCHS " -[010h 0016 8] Oem Table ID : "BXPCGTDT" +[010h 0016 8] Oem Table ID : "BXPC " [018h 0024 4] Oem Revision : 00000001 [01Ch 0028 4] Asl Compiler ID : "BXPC" [020h 0032 4] Asl Compiler Revision : 00000001 Table tests/data/acpi/virt/MCFG.numamem diff: @@ -3,7 +3,7 @@ * AML/ASL+ Disassembler version 20200326 (64-bit version) * Copyright (c) 2000 - 2020 Intel Corporation * - * Disassembly of tests/data/acpi/virt/MCFG.numamem, Mon Jan 18 23:55:27 2= 021 + * Disassembly of /tmp/aml-YOOMX0, Mon Jan 18 23:55:27 2021 * * ACPI Data Table [MCFG] * @@ -13,9 +13,9 @@ [000h 0000 4] Signature : "MCFG" [Memory Mapped Co= nfiguration table] [004h 0004 4] Table Length : 0000003C [008h 0008 1] Revision : 01 -[009h 0009 1] Checksum : 4F +[009h 0009 1] Checksum : EC [00Ah 0010 6] Oem ID : "BOCHS " -[010h 0016 8] Oem Table ID : "BXPCMCFG" +[010h 0016 8] Oem Table ID : "BXPC " [018h 0024 4] Oem Revision : 00000001 [01Ch 0028 4] Asl Compiler ID : "BXPC" [020h 0032 4] Asl Compiler Revision : 00000001 Table tests/data/acpi/virt/SPCR.numamem diff: @@ -3,7 +3,7 @@ * AML/ASL+ Disassembler version 20200326 (64-bit version) * Copyright (c) 2000 - 2020 Intel Corporation * - * Disassembly of tests/data/acpi/virt/SPCR.numamem, Mon Jan 18 23:55:27 2= 021 + * Disassembly of /tmp/aml-TOOMX0, Mon Jan 18 23:55:27 2021 * * ACPI Data Table [SPCR] * @@ -13,9 +13,9 @@ [000h 0000 4] Signature : "SPCR" [Serial Port Cons= ole Redirection table] [004h 0004 4] Table Length : 00000050 [008h 0008 1] Revision : 02 -[009h 0009 1] Checksum : 13 +[009h 0009 1] Checksum : CB [00Ah 0010 6] Oem ID : "BOCHS " -[010h 0016 8] Oem Table ID : "BXPCSPCR" +[010h 0016 8] Oem Table ID : "BXPC " [018h 0024 4] Oem Revision : 00000001 [01Ch 0028 4] Asl Compiler ID : "BXPC" [020h 0032 4] Asl Compiler Revision : 00000001 Table tests/data/acpi/virt/SRAT.numamem diff: @@ -3,7 +3,7 @@ * AML/ASL+ Disassembler version 20200326 (64-bit version) * Copyright (c) 2000 - 2020 Intel Corporation * - * Disassembly of tests/data/acpi/virt/SRAT.numamem, Mon Jan 18 23:55:27 2= 021 + * Disassembly of /tmp/aml-LPOMX0, Mon Jan 18 23:55:27 2021 * * ACPI Data Table [SRAT] * @@ -13,9 +13,9 @@ [000h 0000 4] Signature : "SRAT" [System Resource = Affinity Table] [004h 0004 4] Table Length : 0000006A [008h 0008 1] Revision : 03 -[009h 0009 1] Checksum : AB +[009h 0009 1] Checksum : 65 [00Ah 0010 6] Oem ID : "BOCHS " -[010h 0016 8] Oem Table ID : "BXPCSRAT" +[010h 0016 8] Oem Table ID : "BXPC " [018h 0024 4] Oem Revision : 00000001 [01Ch 0028 4] Asl Compiler ID : "BXPC" [020h 0032 4] Asl Compiler Revision : 00000001 Table tests/data/acpi/virt/DSDT.numamem diff: @@ -5,20 +5,20 @@ * * Disassembling to symbolic ASL+ operators * - * Disassembly of tests/data/acpi/virt/DSDT.numamem, Mon Jan 18 23:55:27 2= 021 + * Disassembly of /tmp/aml-HPOMX0, Mon Jan 18 23:55:27 2021 * * Original Table Header: * Signature "DSDT" * Length 0x00001454 (5204) * Revision 0x02 - * Checksum 0x60 + * Checksum 0x0F * OEM ID "BOCHS " - * OEM Table ID "BXPCDSDT" + * OEM Table ID "BXPC " * OEM Revision 0x00000001 (1) * Compiler ID "BXPC" * Compiler Version 0x00000001 (1) */ -DefinitionBlock ("", "DSDT", 2, "BOCHS ", "BXPCDSDT", 0x00000001) +DefinitionBlock ("", "DSDT", 2, "BOCHS ", "BXPC ", 0x00000001) { Scope (\_SB) { Table tests/data/acpi/virt/FACP.memhp diff: @@ -3,7 +3,7 @@ * AML/ASL+ Disassembler version 20200326 (64-bit version) * Copyright (c) 2000 - 2020 Intel Corporation * - * Disassembly of tests/data/acpi/virt/FACP.memhp, Mon Jan 18 23:55:41 2021 + * Disassembly of /tmp/aml-OERTX0, Mon Jan 18 23:55:41 2021 * * ACPI Data Table [FACP] * @@ -13,9 +13,9 @@ [000h 0000 4] Signature : "FACP" [Fixed ACPI Descr= iption Table (FADT)] [004h 0004 4] Table Length : 0000010C [008h 0008 1] Revision : 05 -[009h 0009 1] Checksum : BB +[009h 0009 1] Checksum : 55 [00Ah 0010 6] Oem ID : "BOCHS " -[010h 0016 8] Oem Table ID : "BXPCFACP" +[010h 0016 8] Oem Table ID : "BXPC " [018h 0024 4] Oem Revision : 00000001 [01Ch 0028 4] Asl Compiler ID : "BXPC" [020h 0032 4] Asl Compiler Revision : 00000001 Table tests/data/acpi/virt/APIC.memhp diff: @@ -3,7 +3,7 @@ * AML/ASL+ Disassembler version 20200326 (64-bit version) * Copyright (c) 2000 - 2020 Intel Corporation * - * Disassembly of tests/data/acpi/virt/APIC.memhp, Mon Jan 18 23:55:41 2021 + * Disassembly of /tmp/aml-FERTX0, Mon Jan 18 23:55:41 2021 * * ACPI Data Table [APIC] * @@ -13,9 +13,9 @@ [000h 0000 4] Signature : "APIC" [Multiple APIC De= scription Table (MADT)] [004h 0004 4] Table Length : 000000A8 [008h 0008 1] Revision : 03 -[009h 0009 1] Checksum : B3 +[009h 0009 1] Checksum : 50 [00Ah 0010 6] Oem ID : "BOCHS " -[010h 0016 8] Oem Table ID : "BXPCAPIC" +[010h 0016 8] Oem Table ID : "BXPC " [018h 0024 4] Oem Revision : 00000001 [01Ch 0028 4] Asl Compiler ID : "BXPC" [020h 0032 4] Asl Compiler Revision : 00000001 Table tests/data/acpi/virt/GTDT.memhp diff: @@ -3,7 +3,7 @@ * AML/ASL+ Disassembler version 20200326 (64-bit version) * Copyright (c) 2000 - 2020 Intel Corporation * - * Disassembly of tests/data/acpi/virt/GTDT.memhp, Mon Jan 18 23:55:41 2021 + * Disassembly of /tmp/aml-BERTX0, Mon Jan 18 23:55:41 2021 * * ACPI Data Table [GTDT] * @@ -13,9 +13,9 @@ [000h 0000 4] Signature : "GTDT" [Generic Timer De= scription Table] [004h 0004 4] Table Length : 00000060 [008h 0008 1] Revision : 02 -[009h 0009 1] Checksum : D9 +[009h 0009 1] Checksum : 8C [00Ah 0010 6] Oem ID : "BOCHS " -[010h 0016 8] Oem Table ID : "BXPCGTDT" +[010h 0016 8] Oem Table ID : "BXPC " [018h 0024 4] Oem Revision : 00000001 [01Ch 0028 4] Asl Compiler ID : "BXPC" [020h 0032 4] Asl Compiler Revision : 00000001 Table tests/data/acpi/virt/MCFG.memhp diff: @@ -3,7 +3,7 @@ * AML/ASL+ Disassembler version 20200326 (64-bit version) * Copyright (c) 2000 - 2020 Intel Corporation * - * Disassembly of tests/data/acpi/virt/MCFG.memhp, Mon Jan 18 23:55:41 2021 + * Disassembly of /tmp/aml-8DRTX0, Mon Jan 18 23:55:41 2021 * * ACPI Data Table [MCFG] * @@ -13,9 +13,9 @@ [000h 0000 4] Signature : "MCFG" [Memory Mapped Co= nfiguration table] [004h 0004 4] Table Length : 0000003C [008h 0008 1] Revision : 01 -[009h 0009 1] Checksum : 4F +[009h 0009 1] Checksum : EC [00Ah 0010 6] Oem ID : "BOCHS " -[010h 0016 8] Oem Table ID : "BXPCMCFG" +[010h 0016 8] Oem Table ID : "BXPC " [018h 0024 4] Oem Revision : 00000001 [01Ch 0028 4] Asl Compiler ID : "BXPC" [020h 0032 4] Asl Compiler Revision : 00000001 Table tests/data/acpi/virt/SPCR.memhp diff: @@ -3,7 +3,7 @@ * AML/ASL+ Disassembler version 20200326 (64-bit version) * Copyright (c) 2000 - 2020 Intel Corporation * - * Disassembly of tests/data/acpi/virt/SPCR.memhp, Mon Jan 18 23:55:41 2021 + * Disassembly of /tmp/aml-IN6NX0, Mon Jan 18 23:55:41 2021 * * ACPI Data Table [SPCR] * @@ -13,9 +13,9 @@ [000h 0000 4] Signature : "SPCR" [Serial Port Cons= ole Redirection table] [004h 0004 4] Table Length : 00000050 [008h 0008 1] Revision : 02 -[009h 0009 1] Checksum : 13 +[009h 0009 1] Checksum : CB [00Ah 0010 6] Oem ID : "BOCHS " -[010h 0016 8] Oem Table ID : "BXPCSPCR" +[010h 0016 8] Oem Table ID : "BXPC " [018h 0024 4] Oem Revision : 00000001 [01Ch 0028 4] Asl Compiler ID : "BXPC" [020h 0032 4] Asl Compiler Revision : 00000001 Table tests/data/acpi/virt/SRAT.memhp diff: @@ -3,7 +3,7 @@ * AML/ASL+ Disassembler version 20200326 (64-bit version) * Copyright (c) 2000 - 2020 Intel Corporation * - * Disassembly of tests/data/acpi/virt/SRAT.memhp, Mon Jan 18 23:55:41 2021 + * Disassembly of /tmp/aml-FN6NX0, Mon Jan 18 23:55:41 2021 * * ACPI Data Table [SRAT] * @@ -13,9 +13,9 @@ [000h 0000 4] Signature : "SRAT" [System Resource = Affinity Table] [004h 0004 4] Table Length : 000000E2 [008h 0008 1] Revision : 03 -[009h 0009 1] Checksum : 5C +[009h 0009 1] Checksum : 16 [00Ah 0010 6] Oem ID : "BOCHS " -[010h 0016 8] Oem Table ID : "BXPCSRAT" +[010h 0016 8] Oem Table ID : "BXPC " [018h 0024 4] Oem Revision : 00000001 [01Ch 0028 4] Asl Compiler ID : "BXPC" [020h 0032 4] Asl Compiler Revision : 00000001 Table tests/data/acpi/virt/SLIT.memhp diff: @@ -3,7 +3,7 @@ * AML/ASL+ Disassembler version 20200326 (64-bit version) * Copyright (c) 2000 - 2020 Intel Corporation * - * Disassembly of tests/data/acpi/virt/SLIT.memhp, Mon Jan 18 23:55:41 2021 + * Disassembly of /tmp/aml-CN6NX0, Mon Jan 18 23:55:41 2021 * * ACPI Data Table [SLIT] * @@ -13,9 +13,9 @@ [000h 0000 4] Signature : "SLIT" [System Locality = Information Table] [004h 0004 4] Table Length : 00000030 [008h 0008 1] Revision : 01 -[009h 0009 1] Checksum : 2C +[009h 0009 1] Checksum : E8 [00Ah 0010 6] Oem ID : "BOCHS " -[010h 0016 8] Oem Table ID : "BXPCSLIT" +[010h 0016 8] Oem Table ID : "BXPC " [018h 0024 4] Oem Revision : 00000001 [01Ch 0028 4] Asl Compiler ID : "BXPC" [020h 0032 4] Asl Compiler Revision : 00000001 Table tests/data/acpi/virt/SSDT.memhp diff: @@ -5,20 +5,20 @@ * * Disassembling to symbolic ASL+ operators * - * Disassembly of tests/data/acpi/virt/SSDT.memhp, Mon Jan 18 23:55:41 2021 + * Disassembly of /tmp/aml-9M6NX0, Mon Jan 18 23:55:41 2021 * * Original Table Header: * Signature "SSDT" * Length 0x000002E0 (736) * Revision 0x01 - * Checksum 0x3F + * Checksum 0xFF * OEM ID "BOCHS " - * OEM Table ID "NVDIMM" + * OEM Table ID "NVDIMM " * OEM Revision 0x00000001 (1) * Compiler ID "BXPC" * Compiler Version 0x00000001 (1) */ -DefinitionBlock ("", "SSDT", 1, "BOCHS ", "NVDIMM", 0x00000001) +DefinitionBlock ("", "SSDT", 1, "BOCHS ", "NVDIMM ", 0x00000001) { Scope (\_SB) { Table tests/data/acpi/virt/NFIT.memhp diff: @@ -3,7 +3,7 @@ * AML/ASL+ Disassembler version 20200326 (64-bit version) * Copyright (c) 2000 - 2020 Intel Corporation * - * Disassembly of tests/data/acpi/virt/NFIT.memhp, Mon Jan 18 23:55:41 2021 + * Disassembly of /tmp/aml-6M6NX0, Mon Jan 18 23:55:41 2021 * * ACPI Data Table [NFIT] * @@ -13,9 +13,9 @@ [000h 0000 4] Signature : "NFIT" [NVDIMM Firmware = Interface Table] [004h 0004 4] Table Length : 000000E0 [008h 0008 1] Revision : 01 -[009h 0009 1] Checksum : D1 +[009h 0009 1] Checksum : 82 [00Ah 0010 6] Oem ID : "BOCHS " -[010h 0016 8] Oem Table ID : "BXPCNFIT" +[010h 0016 8] Oem Table ID : "BXPC " [018h 0024 4] Oem Revision : 00000001 [01Ch 0028 4] Asl Compiler ID : "BXPC" [020h 0032 4] Asl Compiler Revision : 00000001 Table tests/data/acpi/virt/DSDT.memhp diff: @@ -5,20 +5,20 @@ * * Disassembling to symbolic ASL+ operators * - * Disassembly of tests/data/acpi/virt/DSDT.memhp, Mon Jan 18 23:55:41 2021 + * Disassembly of /tmp/aml-3M6NX0, Mon Jan 18 23:55:41 2021 * * Original Table Header: * Signature "DSDT" * Length 0x000019A5 (6565) * Revision 0x02 - * Checksum 0x90 + * Checksum 0x3F * OEM ID "BOCHS " - * OEM Table ID "BXPCDSDT" + * OEM Table ID "BXPC " * OEM Revision 0x00000001 (1) * Compiler ID "BXPC" * Compiler Version 0x00000001 (1) */ -DefinitionBlock ("", "DSDT", 2, "BOCHS ", "BXPCDSDT", 0x00000001) +DefinitionBlock ("", "DSDT", 2, "BOCHS ", "BXPC ", 0x00000001) { External (_SB_.NVDR, UnknownObj) Table tests/data/acpi/virt/FACP.pxb diff: @@ -3,7 +3,7 @@ * AML/ASL+ Disassembler version 20200326 (64-bit version) * Copyright (c) 2000 - 2020 Intel Corporation * - * Disassembly of tests/data/acpi/virt/FACP, Mon Jan 18 23:55:52 2021 + * Disassembly of /tmp/aml-206LX0, Mon Jan 18 23:55:52 2021 * * ACPI Data Table [FACP] * @@ -13,9 +13,9 @@ [000h 0000 4] Signature : "FACP" [Fixed ACPI Descr= iption Table (FADT)] [004h 0004 4] Table Length : 0000010C [008h 0008 1] Revision : 05 -[009h 0009 1] Checksum : BB +[009h 0009 1] Checksum : 55 [00Ah 0010 6] Oem ID : "BOCHS " -[010h 0016 8] Oem Table ID : "BXPCFACP" +[010h 0016 8] Oem Table ID : "BXPC " [018h 0024 4] Oem Revision : 00000001 [01Ch 0028 4] Asl Compiler ID : "BXPC" [020h 0032 4] Asl Compiler Revision : 00000001 Table tests/data/acpi/virt/APIC.pxb diff: @@ -3,7 +3,7 @@ * AML/ASL+ Disassembler version 20200326 (64-bit version) * Copyright (c) 2000 - 2020 Intel Corporation * - * Disassembly of tests/data/acpi/virt/APIC, Mon Jan 18 23:55:52 2021 + * Disassembly of /tmp/aml-E16LX0, Mon Jan 18 23:55:52 2021 * * ACPI Data Table [APIC] * @@ -13,9 +13,9 @@ [000h 0000 4] Signature : "APIC" [Multiple APIC De= scription Table (MADT)] [004h 0004 4] Table Length : 000000A8 [008h 0008 1] Revision : 03 -[009h 0009 1] Checksum : B3 +[009h 0009 1] Checksum : 50 [00Ah 0010 6] Oem ID : "BOCHS " -[010h 0016 8] Oem Table ID : "BXPCAPIC" +[010h 0016 8] Oem Table ID : "BXPC " [018h 0024 4] Oem Revision : 00000001 [01Ch 0028 4] Asl Compiler ID : "BXPC" [020h 0032 4] Asl Compiler Revision : 00000001 Table tests/data/acpi/virt/GTDT.pxb diff: @@ -3,7 +3,7 @@ * AML/ASL+ Disassembler version 20200326 (64-bit version) * Copyright (c) 2000 - 2020 Intel Corporation * - * Disassembly of tests/data/acpi/virt/GTDT, Mon Jan 18 23:55:52 2021 + * Disassembly of /tmp/aml-J16LX0, Mon Jan 18 23:55:52 2021 * * ACPI Data Table [GTDT] * @@ -13,9 +13,9 @@ [000h 0000 4] Signature : "GTDT" [Generic Timer De= scription Table] [004h 0004 4] Table Length : 00000060 [008h 0008 1] Revision : 02 -[009h 0009 1] Checksum : D9 +[009h 0009 1] Checksum : 8C [00Ah 0010 6] Oem ID : "BOCHS " -[010h 0016 8] Oem Table ID : "BXPCGTDT" +[010h 0016 8] Oem Table ID : "BXPC " [018h 0024 4] Oem Revision : 00000001 [01Ch 0028 4] Asl Compiler ID : "BXPC" [020h 0032 4] Asl Compiler Revision : 00000001 Table tests/data/acpi/virt/MCFG.pxb diff: @@ -3,7 +3,7 @@ * AML/ASL+ Disassembler version 20200326 (64-bit version) * Copyright (c) 2000 - 2020 Intel Corporation * - * Disassembly of tests/data/acpi/virt/MCFG, Mon Jan 18 23:55:52 2021 + * Disassembly of /tmp/aml-N16LX0, Mon Jan 18 23:55:52 2021 * * ACPI Data Table [MCFG] * @@ -13,9 +13,9 @@ [000h 0000 4] Signature : "MCFG" [Memory Mapped Co= nfiguration table] [004h 0004 4] Table Length : 0000003C [008h 0008 1] Revision : 01 -[009h 0009 1] Checksum : 4F +[009h 0009 1] Checksum : EC [00Ah 0010 6] Oem ID : "BOCHS " -[010h 0016 8] Oem Table ID : "BXPCMCFG" +[010h 0016 8] Oem Table ID : "BXPC " [018h 0024 4] Oem Revision : 00000001 [01Ch 0028 4] Asl Compiler ID : "BXPC" [020h 0032 4] Asl Compiler Revision : 00000001 Table tests/data/acpi/virt/SPCR.pxb diff: @@ -3,7 +3,7 @@ * AML/ASL+ Disassembler version 20200326 (64-bit version) * Copyright (c) 2000 - 2020 Intel Corporation * - * Disassembly of tests/data/acpi/virt/SPCR, Mon Jan 18 23:55:52 2021 + * Disassembly of /tmp/aml-B16LX0, Mon Jan 18 23:55:52 2021 * * ACPI Data Table [SPCR] * @@ -13,9 +13,9 @@ [000h 0000 4] Signature : "SPCR" [Serial Port Cons= ole Redirection table] [004h 0004 4] Table Length : 00000050 [008h 0008 1] Revision : 02 -[009h 0009 1] Checksum : 13 +[009h 0009 1] Checksum : CB [00Ah 0010 6] Oem ID : "BOCHS " -[010h 0016 8] Oem Table ID : "BXPCSPCR" +[010h 0016 8] Oem Table ID : "BXPC " [018h 0024 4] Oem Revision : 00000001 [01Ch 0028 4] Asl Compiler ID : "BXPC" [020h 0032 4] Asl Compiler Revision : 00000001 Table tests/data/acpi/virt/DSDT.pxb diff: @@ -5,20 +5,20 @@ * * Disassembling to symbolic ASL+ operators * - * Disassembly of tests/data/acpi/virt/DSDT.pxb, Mon Jan 18 23:55:52 2021 + * Disassembly of /tmp/aml-G16LX0, Mon Jan 18 23:55:52 2021 * * Original Table Header: * Signature "DSDT" * Length 0x00001E09 (7689) * Revision 0x02 - * Checksum 0x30 + * Checksum 0xDF * OEM ID "BOCHS " - * OEM Table ID "BXPCDSDT" + * OEM Table ID "BXPC " * OEM Revision 0x00000001 (1) * Compiler ID "BXPC" * Compiler Version 0x00000001 (1) */ -DefinitionBlock ("", "DSDT", 2, "BOCHS ", "BXPCDSDT", 0x00000001) +DefinitionBlock ("", "DSDT", 2, "BOCHS ", "BXPC ", 0x00000001) { Scope (\_SB) { Table tests/data/acpi/pc/HPET diff: @@ -3,7 +3,7 @@ * AML/ASL+ Disassembler version 20200326 (64-bit version) * Copyright (c) 2000 - 2020 Intel Corporation * - * Disassembly of tests/data/acpi/pc/HPET, Mon Jan 18 23:58:53 2021 + * Disassembly of /tmp/aml-QNVAX0, Mon Jan 18 23:58:53 2021 * * ACPI Data Table [HPET] * @@ -13,9 +13,9 @@ [000h 0000 4] Signature : "HPET" [High Precision E= vent Timer table] [004h 0004 4] Table Length : 00000038 [008h 0008 1] Revision : 01 -[009h 0009 1] Checksum : 03 +[009h 0009 1] Checksum : B4 [00Ah 0010 6] Oem ID : "BOCHS " -[010h 0016 8] Oem Table ID : "BXPCHPET" +[010h 0016 8] Oem Table ID : "BXPC " [018h 0024 4] Oem Revision : 00000001 [01Ch 0028 4] Asl Compiler ID : "BXPC" [020h 0032 4] Asl Compiler Revision : 00000001 Table tests/data/acpi/pc/WAET diff: @@ -3,7 +3,7 @@ * AML/ASL+ Disassembler version 20200326 (64-bit version) * Copyright (c) 2000 - 2020 Intel Corporation * - * Disassembly of tests/data/acpi/pc/WAET, Mon Jan 18 23:58:53 2021 + * Disassembly of /tmp/aml-NNVAX0, Mon Jan 18 23:58:53 2021 * * ACPI Data Table [WAET] * @@ -13,9 +13,9 @@ [000h 0000 4] Signature : "WAET" [Windows ACPI Emu= lated Devices Table] [004h 0004 4] Table Length : 00000028 [008h 0008 1] Revision : 01 -[009h 0009 1] Checksum : 88 +[009h 0009 1] Checksum : 39 [00Ah 0010 6] Oem ID : "BOCHS " -[010h 0016 8] Oem Table ID : "BXPCWAET" +[010h 0016 8] Oem Table ID : "BXPC " [018h 0024 4] Oem Revision : 00000001 [01Ch 0028 4] Asl Compiler ID : "BXPC" [020h 0032 4] Asl Compiler Revision : 00000001 Table tests/data/acpi/q35/FACP.tis diff: @@ -3,7 +3,7 @@ * AML/ASL+ Disassembler version 20200326 (64-bit version) * Copyright (c) 2000 - 2020 Intel Corporation * - * Disassembly of tests/data/acpi/q35/FACP, Mon Jan 18 23:58:55 2021 + * Disassembly of /tmp/aml-MB7EX0, Mon Jan 18 23:58:55 2021 * * ACPI Data Table [FACP] * @@ -13,9 +13,9 @@ [000h 0000 4] Signature : "FACP" [Fixed ACPI Descr= iption Table (FADT)] [004h 0004 4] Table Length : 000000F4 [008h 0008 1] Revision : 03 -[009h 0009 1] Checksum : 1F +[009h 0009 1] Checksum : B9 [00Ah 0010 6] Oem ID : "BOCHS " -[010h 0016 8] Oem Table ID : "BXPCFACP" +[010h 0016 8] Oem Table ID : "BXPC " [018h 0024 4] Oem Revision : 00000001 [01Ch 0028 4] Asl Compiler ID : "BXPC" [020h 0032 4] Asl Compiler Revision : 00000001 Table tests/data/acpi/q35/APIC.tis diff: @@ -3,7 +3,7 @@ * AML/ASL+ Disassembler version 20200326 (64-bit version) * Copyright (c) 2000 - 2020 Intel Corporation * - * Disassembly of tests/data/acpi/q35/APIC, Mon Jan 18 23:58:55 2021 + * Disassembly of /tmp/aml-3C7EX0, Mon Jan 18 23:58:55 2021 * * ACPI Data Table [APIC] * @@ -13,9 +13,9 @@ [000h 0000 4] Signature : "APIC" [Multiple APIC De= scription Table (MADT)] [004h 0004 4] Table Length : 00000078 [008h 0008 1] Revision : 01 -[009h 0009 1] Checksum : ED +[009h 0009 1] Checksum : 8A [00Ah 0010 6] Oem ID : "BOCHS " -[010h 0016 8] Oem Table ID : "BXPCAPIC" +[010h 0016 8] Oem Table ID : "BXPC " [018h 0024 4] Oem Revision : 00000001 [01Ch 0028 4] Asl Compiler ID : "BXPC" [020h 0032 4] Asl Compiler Revision : 00000001 Table tests/data/acpi/q35/HPET.tis diff: @@ -3,7 +3,7 @@ * AML/ASL+ Disassembler version 20200326 (64-bit version) * Copyright (c) 2000 - 2020 Intel Corporation * - * Disassembly of tests/data/acpi/q35/HPET, Mon Jan 18 23:58:55 2021 + * Disassembly of /tmp/aml-0C7EX0, Mon Jan 18 23:58:55 2021 * * ACPI Data Table [HPET] * @@ -13,9 +13,9 @@ [000h 0000 4] Signature : "HPET" [High Precision E= vent Timer table] [004h 0004 4] Table Length : 00000038 [008h 0008 1] Revision : 01 -[009h 0009 1] Checksum : 03 +[009h 0009 1] Checksum : B4 [00Ah 0010 6] Oem ID : "BOCHS " -[010h 0016 8] Oem Table ID : "BXPCHPET" +[010h 0016 8] Oem Table ID : "BXPC " [018h 0024 4] Oem Revision : 00000001 [01Ch 0028 4] Asl Compiler ID : "BXPC" [020h 0032 4] Asl Compiler Revision : 00000001 Table tests/data/acpi/q35/TPM2.tis diff: @@ -3,7 +3,7 @@ * AML/ASL+ Disassembler version 20200326 (64-bit version) * Copyright (c) 2000 - 2020 Intel Corporation * - * Disassembly of tests/data/acpi/q35/TPM2.tis, Mon Jan 18 23:58:55 2021 + * Disassembly of /tmp/aml-ZC7EX0, Mon Jan 18 23:58:55 2021 * * ACPI Data Table [TPM2] * @@ -13,9 +13,9 @@ [000h 0000 4] Signature : "TPM2" [Trusted Platform= Module hardware interface table] [004h 0004 4] Table Length : 0000004C [008h 0008 1] Revision : 04 -[009h 0009 1] Checksum : 72 +[009h 0009 1] Checksum : 15 [00Ah 0010 6] Oem ID : "BOCHS " -[010h 0016 8] Oem Table ID : "BXPCTPM2" +[010h 0016 8] Oem Table ID : "BXPC " [018h 0024 4] Oem Revision : 00000001 [01Ch 0028 4] Asl Compiler ID : "BXPC" [020h 0032 4] Asl Compiler Revision : 00000001 Table tests/data/acpi/q35/MCFG.tis diff: @@ -3,7 +3,7 @@ * AML/ASL+ Disassembler version 20200326 (64-bit version) * Copyright (c) 2000 - 2020 Intel Corporation * - * Disassembly of tests/data/acpi/q35/MCFG, Mon Jan 18 23:58:55 2021 + * Disassembly of /tmp/aml-XC7EX0, Mon Jan 18 23:58:55 2021 * * ACPI Data Table [MCFG] * @@ -13,9 +13,9 @@ [000h 0000 4] Signature : "MCFG" [Memory Mapped Co= nfiguration table] [004h 0004 4] Table Length : 0000003C [008h 0008 1] Revision : 01 -[009h 0009 1] Checksum : EF +[009h 0009 1] Checksum : 8C [00Ah 0010 6] Oem ID : "BOCHS " -[010h 0016 8] Oem Table ID : "BXPCMCFG" +[010h 0016 8] Oem Table ID : "BXPC " [018h 0024 4] Oem Revision : 00000001 [01Ch 0028 4] Asl Compiler ID : "BXPC" [020h 0032 4] Asl Compiler Revision : 00000001 Table tests/data/acpi/q35/WAET.tis diff: @@ -3,7 +3,7 @@ * AML/ASL+ Disassembler version 20200326 (64-bit version) * Copyright (c) 2000 - 2020 Intel Corporation * - * Disassembly of tests/data/acpi/q35/WAET, Mon Jan 18 23:58:55 2021 + * Disassembly of /tmp/aml-VC7EX0, Mon Jan 18 23:58:55 2021 * * ACPI Data Table [WAET] * @@ -13,9 +13,9 @@ [000h 0000 4] Signature : "WAET" [Windows ACPI Emu= lated Devices Table] [004h 0004 4] Table Length : 00000028 [008h 0008 1] Revision : 01 -[009h 0009 1] Checksum : 88 +[009h 0009 1] Checksum : 39 [00Ah 0010 6] Oem ID : "BOCHS " -[010h 0016 8] Oem Table ID : "BXPCWAET" +[010h 0016 8] Oem Table ID : "BXPC " [018h 0024 4] Oem Revision : 00000001 [01Ch 0028 4] Asl Compiler ID : "BXPC" [020h 0032 4] Asl Compiler Revision : 00000001 Table tests/data/acpi/q35/DSDT.tis diff: @@ -5,20 +5,20 @@ * * Disassembling to symbolic ASL+ operators * - * Disassembly of tests/data/acpi/q35/DSDT.tis, Mon Jan 18 23:58:55 2021 + * Disassembly of /tmp/aml-RC7EX0, Mon Jan 18 23:58:55 2021 * * Original Table Header: * Signature "DSDT" * Length 0x000020D7 (8407) * Revision 0x01 **** 32-bit table (V1), no 64-bit math support - * Checksum 0xC8 + * Checksum 0x77 * OEM ID "BOCHS " - * OEM Table ID "BXPCDSDT" + * OEM Table ID "BXPC " * OEM Revision 0x00000001 (1) * Compiler ID "BXPC" * Compiler Version 0x00000001 (1) */ -DefinitionBlock ("", "DSDT", 1, "BOCHS ", "BXPCDSDT", 0x00000001) +DefinitionBlock ("", "DSDT", 1, "BOCHS ", "BXPC ", 0x00000001) { Scope (\) { Table tests/data/acpi/q35/FACP.bridge diff: @@ -3,7 +3,7 @@ * AML/ASL+ Disassembler version 20200326 (64-bit version) * Copyright (c) 2000 - 2020 Intel Corporation * - * Disassembly of tests/data/acpi/q35/FACP, Mon Jan 18 23:58:55 2021 + * Disassembly of /tmp/aml-3N7NX0, Mon Jan 18 23:58:55 2021 * * ACPI Data Table [FACP] * @@ -13,9 +13,9 @@ [000h 0000 4] Signature : "FACP" [Fixed ACPI Descr= iption Table (FADT)] [004h 0004 4] Table Length : 000000F4 [008h 0008 1] Revision : 03 -[009h 0009 1] Checksum : 1F +[009h 0009 1] Checksum : B9 [00Ah 0010 6] Oem ID : "BOCHS " -[010h 0016 8] Oem Table ID : "BXPCFACP" +[010h 0016 8] Oem Table ID : "BXPC " [018h 0024 4] Oem Revision : 00000001 [01Ch 0028 4] Asl Compiler ID : "BXPC" [020h 0032 4] Asl Compiler Revision : 00000001 Table tests/data/acpi/q35/APIC.bridge diff: @@ -3,7 +3,7 @@ * AML/ASL+ Disassembler version 20200326 (64-bit version) * Copyright (c) 2000 - 2020 Intel Corporation * - * Disassembly of tests/data/acpi/q35/APIC, Mon Jan 18 23:58:55 2021 + * Disassembly of /tmp/aml-WN7NX0, Mon Jan 18 23:58:55 2021 * * ACPI Data Table [APIC] * @@ -13,9 +13,9 @@ [000h 0000 4] Signature : "APIC" [Multiple APIC De= scription Table (MADT)] [004h 0004 4] Table Length : 00000078 [008h 0008 1] Revision : 01 -[009h 0009 1] Checksum : ED +[009h 0009 1] Checksum : 8A [00Ah 0010 6] Oem ID : "BOCHS " -[010h 0016 8] Oem Table ID : "BXPCAPIC" +[010h 0016 8] Oem Table ID : "BXPC " [018h 0024 4] Oem Revision : 00000001 [01Ch 0028 4] Asl Compiler ID : "BXPC" [020h 0032 4] Asl Compiler Revision : 00000001 Table tests/data/acpi/q35/HPET.bridge diff: @@ -3,7 +3,7 @@ * AML/ASL+ Disassembler version 20200326 (64-bit version) * Copyright (c) 2000 - 2020 Intel Corporation * - * Disassembly of tests/data/acpi/q35/HPET, Mon Jan 18 23:58:55 2021 + * Disassembly of /tmp/aml-DI7NX0, Mon Jan 18 23:58:55 2021 * * ACPI Data Table [HPET] * @@ -13,9 +13,9 @@ [000h 0000 4] Signature : "HPET" [High Precision E= vent Timer table] [004h 0004 4] Table Length : 00000038 [008h 0008 1] Revision : 01 -[009h 0009 1] Checksum : 03 +[009h 0009 1] Checksum : B4 [00Ah 0010 6] Oem ID : "BOCHS " -[010h 0016 8] Oem Table ID : "BXPCHPET" +[010h 0016 8] Oem Table ID : "BXPC " [018h 0024 4] Oem Revision : 00000001 [01Ch 0028 4] Asl Compiler ID : "BXPC" [020h 0032 4] Asl Compiler Revision : 00000001 Table tests/data/acpi/q35/MCFG.bridge diff: @@ -3,7 +3,7 @@ * AML/ASL+ Disassembler version 20200326 (64-bit version) * Copyright (c) 2000 - 2020 Intel Corporation * - * Disassembly of tests/data/acpi/q35/MCFG, Mon Jan 18 23:58:55 2021 + * Disassembly of /tmp/aml-BI7NX0, Mon Jan 18 23:58:55 2021 * * ACPI Data Table [MCFG] * @@ -13,9 +13,9 @@ [000h 0000 4] Signature : "MCFG" [Memory Mapped Co= nfiguration table] [004h 0004 4] Table Length : 0000003C [008h 0008 1] Revision : 01 -[009h 0009 1] Checksum : EF +[009h 0009 1] Checksum : 8C [00Ah 0010 6] Oem ID : "BOCHS " -[010h 0016 8] Oem Table ID : "BXPCMCFG" +[010h 0016 8] Oem Table ID : "BXPC " [018h 0024 4] Oem Revision : 00000001 [01Ch 0028 4] Asl Compiler ID : "BXPC" [020h 0032 4] Asl Compiler Revision : 00000001 Table tests/data/acpi/q35/WAET.bridge diff: @@ -3,7 +3,7 @@ * AML/ASL+ Disassembler version 20200326 (64-bit version) * Copyright (c) 2000 - 2020 Intel Corporation * - * Disassembly of tests/data/acpi/q35/WAET, Mon Jan 18 23:58:55 2021 + * Disassembly of /tmp/aml-9H7NX0, Mon Jan 18 23:58:55 2021 * * ACPI Data Table [WAET] * @@ -13,9 +13,9 @@ [000h 0000 4] Signature : "WAET" [Windows ACPI Emu= lated Devices Table] [004h 0004 4] Table Length : 00000028 [008h 0008 1] Revision : 01 -[009h 0009 1] Checksum : 88 +[009h 0009 1] Checksum : 39 [00Ah 0010 6] Oem ID : "BOCHS " -[010h 0016 8] Oem Table ID : "BXPCWAET" +[010h 0016 8] Oem Table ID : "BXPC " [018h 0024 4] Oem Revision : 00000001 [01Ch 0028 4] Asl Compiler ID : "BXPC" [020h 0032 4] Asl Compiler Revision : 00000001 Table tests/data/acpi/q35/DSDT.bridge diff: @@ -5,20 +5,20 @@ * * Disassembling to symbolic ASL+ operators * - * Disassembly of tests/data/acpi/q35/DSDT.bridge, Mon Jan 18 23:58:55 2021 + * Disassembly of /tmp/aml-6H7NX0, Mon Jan 18 23:58:55 2021 * * Original Table Header: * Signature "DSDT" * Length 0x00001E8B (7819) * Revision 0x01 **** 32-bit table (V1), no 64-bit math support - * Checksum 0x8F + * Checksum 0x3E * OEM ID "BOCHS " - * OEM Table ID "BXPCDSDT" + * OEM Table ID "BXPC " * OEM Revision 0x00000001 (1) * Compiler ID "BXPC" * Compiler Version 0x00000001 (1) */ -DefinitionBlock ("", "DSDT", 1, "BOCHS ", "BXPCDSDT", 0x00000001) +DefinitionBlock ("", "DSDT", 1, "BOCHS ", "BXPC ", 0x00000001) { Scope (\) { Table tests/data/acpi/q35/FACP.mmio64 diff: @@ -3,7 +3,7 @@ * AML/ASL+ Disassembler version 20200326 (64-bit version) * Copyright (c) 2000 - 2020 Intel Corporation * - * Disassembly of tests/data/acpi/q35/FACP, Mon Jan 18 23:58:56 2021 + * Disassembly of /tmp/aml-KW0GX0, Mon Jan 18 23:58:56 2021 * * ACPI Data Table [FACP] * @@ -13,9 +13,9 @@ [000h 0000 4] Signature : "FACP" [Fixed ACPI Descr= iption Table (FADT)] [004h 0004 4] Table Length : 000000F4 [008h 0008 1] Revision : 03 -[009h 0009 1] Checksum : 1F +[009h 0009 1] Checksum : B9 [00Ah 0010 6] Oem ID : "BOCHS " -[010h 0016 8] Oem Table ID : "BXPCFACP" +[010h 0016 8] Oem Table ID : "BXPC " [018h 0024 4] Oem Revision : 00000001 [01Ch 0028 4] Asl Compiler ID : "BXPC" [020h 0032 4] Asl Compiler Revision : 00000001 Table tests/data/acpi/q35/APIC.mmio64 diff: @@ -3,7 +3,7 @@ * AML/ASL+ Disassembler version 20200326 (64-bit version) * Copyright (c) 2000 - 2020 Intel Corporation * - * Disassembly of tests/data/acpi/q35/APIC, Mon Jan 18 23:58:56 2021 + * Disassembly of /tmp/aml-HR0GX0, Mon Jan 18 23:58:56 2021 * * ACPI Data Table [APIC] * @@ -13,9 +13,9 @@ [000h 0000 4] Signature : "APIC" [Multiple APIC De= scription Table (MADT)] [004h 0004 4] Table Length : 00000078 [008h 0008 1] Revision : 01 -[009h 0009 1] Checksum : ED +[009h 0009 1] Checksum : 8A [00Ah 0010 6] Oem ID : "BOCHS " -[010h 0016 8] Oem Table ID : "BXPCAPIC" +[010h 0016 8] Oem Table ID : "BXPC " [018h 0024 4] Oem Revision : 00000001 [01Ch 0028 4] Asl Compiler ID : "BXPC" [020h 0032 4] Asl Compiler Revision : 00000001 Table tests/data/acpi/q35/HPET.mmio64 diff: @@ -3,7 +3,7 @@ * AML/ASL+ Disassembler version 20200326 (64-bit version) * Copyright (c) 2000 - 2020 Intel Corporation * - * Disassembly of tests/data/acpi/q35/HPET, Mon Jan 18 23:58:56 2021 + * Disassembly of /tmp/aml-LR0GX0, Mon Jan 18 23:58:56 2021 * * ACPI Data Table [HPET] * @@ -13,9 +13,9 @@ [000h 0000 4] Signature : "HPET" [High Precision E= vent Timer table] [004h 0004 4] Table Length : 00000038 [008h 0008 1] Revision : 01 -[009h 0009 1] Checksum : 03 +[009h 0009 1] Checksum : B4 [00Ah 0010 6] Oem ID : "BOCHS " -[010h 0016 8] Oem Table ID : "BXPCHPET" +[010h 0016 8] Oem Table ID : "BXPC " [018h 0024 4] Oem Revision : 00000001 [01Ch 0028 4] Asl Compiler ID : "BXPC" [020h 0032 4] Asl Compiler Revision : 00000001 Table tests/data/acpi/q35/SRAT.mmio64 diff: @@ -3,7 +3,7 @@ * AML/ASL+ Disassembler version 20200326 (64-bit version) * Copyright (c) 2000 - 2020 Intel Corporation * - * Disassembly of tests/data/acpi/q35/SRAT.mmio64, Mon Jan 18 23:58:56 2021 + * Disassembly of /tmp/aml-OR0GX0, Mon Jan 18 23:58:56 2021 * * ACPI Data Table [SRAT] * @@ -13,9 +13,9 @@ [000h 0000 4] Signature : "SRAT" [System Resource = Affinity Table] [004h 0004 4] Table Length : 000000E0 [008h 0008 1] Revision : 01 -[009h 0009 1] Checksum : 3B +[009h 0009 1] Checksum : F5 [00Ah 0010 6] Oem ID : "BOCHS " -[010h 0016 8] Oem Table ID : "BXPCSRAT" +[010h 0016 8] Oem Table ID : "BXPC " [018h 0024 4] Oem Revision : 00000001 [01Ch 0028 4] Asl Compiler ID : "BXPC" [020h 0032 4] Asl Compiler Revision : 00000001 Table tests/data/acpi/q35/MCFG.mmio64 diff: @@ -3,7 +3,7 @@ * AML/ASL+ Disassembler version 20200326 (64-bit version) * Copyright (c) 2000 - 2020 Intel Corporation * - * Disassembly of tests/data/acpi/q35/MCFG, Mon Jan 18 23:58:56 2021 + * Disassembly of /tmp/aml-TR0GX0, Mon Jan 18 23:58:56 2021 * * ACPI Data Table [MCFG] * @@ -13,9 +13,9 @@ [000h 0000 4] Signature : "MCFG" [Memory Mapped Co= nfiguration table] [004h 0004 4] Table Length : 0000003C [008h 0008 1] Revision : 01 -[009h 0009 1] Checksum : EF +[009h 0009 1] Checksum : 8C [00Ah 0010 6] Oem ID : "BOCHS " -[010h 0016 8] Oem Table ID : "BXPCMCFG" +[010h 0016 8] Oem Table ID : "BXPC " [018h 0024 4] Oem Revision : 00000001 [01Ch 0028 4] Asl Compiler ID : "BXPC" [020h 0032 4] Asl Compiler Revision : 00000001 Table tests/data/acpi/q35/WAET.mmio64 diff: @@ -3,7 +3,7 @@ * AML/ASL+ Disassembler version 20200326 (64-bit version) * Copyright (c) 2000 - 2020 Intel Corporation * - * Disassembly of tests/data/acpi/q35/WAET, Mon Jan 18 23:58:56 2021 + * Disassembly of /tmp/aml-ZR0GX0, Mon Jan 18 23:58:56 2021 * * ACPI Data Table [WAET] * @@ -13,9 +13,9 @@ [000h 0000 4] Signature : "WAET" [Windows ACPI Emu= lated Devices Table] [004h 0004 4] Table Length : 00000028 [008h 0008 1] Revision : 01 -[009h 0009 1] Checksum : 88 +[009h 0009 1] Checksum : 39 [00Ah 0010 6] Oem ID : "BOCHS " -[010h 0016 8] Oem Table ID : "BXPCWAET" +[010h 0016 8] Oem Table ID : "BXPC " [018h 0024 4] Oem Revision : 00000001 [01Ch 0028 4] Asl Compiler ID : "BXPC" [020h 0032 4] Asl Compiler Revision : 00000001 Table tests/data/acpi/q35/DSDT.mmio64 diff: @@ -5,20 +5,20 @@ * * Disassembling to symbolic ASL+ operators * - * Disassembly of tests/data/acpi/q35/DSDT.mmio64, Mon Jan 18 23:58:56 2021 + * Disassembly of /tmp/aml-7R0GX0, Mon Jan 18 23:58:56 2021 * * Original Table Header: * Signature "DSDT" * Length 0x000022E4 (8932) * Revision 0x01 **** 32-bit table (V1), no 64-bit math support - * Checksum 0x9D + * Checksum 0x4C * OEM ID "BOCHS " - * OEM Table ID "BXPCDSDT" + * OEM Table ID "BXPC " * OEM Revision 0x00000001 (1) * Compiler ID "BXPC" * Compiler Version 0x00000001 (1) */ -DefinitionBlock ("", "DSDT", 1, "BOCHS ", "BXPCDSDT", 0x00000001) +DefinitionBlock ("", "DSDT", 1, "BOCHS ", "BXPC ", 0x00000001) { Scope (\) { Table tests/data/acpi/q35/FACP.ipmibt diff: @@ -3,7 +3,7 @@ * AML/ASL+ Disassembler version 20200326 (64-bit version) * Copyright (c) 2000 - 2020 Intel Corporation * - * Disassembly of tests/data/acpi/q35/FACP, Mon Jan 18 23:58:56 2021 + * Disassembly of /tmp/aml-VVX8W0, Mon Jan 18 23:58:56 2021 * * ACPI Data Table [FACP] * @@ -13,9 +13,9 @@ [000h 0000 4] Signature : "FACP" [Fixed ACPI Descr= iption Table (FADT)] [004h 0004 4] Table Length : 000000F4 [008h 0008 1] Revision : 03 -[009h 0009 1] Checksum : 1F +[009h 0009 1] Checksum : B9 [00Ah 0010 6] Oem ID : "BOCHS " -[010h 0016 8] Oem Table ID : "BXPCFACP" +[010h 0016 8] Oem Table ID : "BXPC " [018h 0024 4] Oem Revision : 00000001 [01Ch 0028 4] Asl Compiler ID : "BXPC" [020h 0032 4] Asl Compiler Revision : 00000001 Table tests/data/acpi/q35/APIC.ipmibt diff: @@ -3,7 +3,7 @@ * AML/ASL+ Disassembler version 20200326 (64-bit version) * Copyright (c) 2000 - 2020 Intel Corporation * - * Disassembly of tests/data/acpi/q35/APIC, Mon Jan 18 23:58:56 2021 + * Disassembly of /tmp/aml-GUX8W0, Mon Jan 18 23:58:56 2021 * * ACPI Data Table [APIC] * @@ -13,9 +13,9 @@ [000h 0000 4] Signature : "APIC" [Multiple APIC De= scription Table (MADT)] [004h 0004 4] Table Length : 00000078 [008h 0008 1] Revision : 01 -[009h 0009 1] Checksum : ED +[009h 0009 1] Checksum : 8A [00Ah 0010 6] Oem ID : "BOCHS " -[010h 0016 8] Oem Table ID : "BXPCAPIC" +[010h 0016 8] Oem Table ID : "BXPC " [018h 0024 4] Oem Revision : 00000001 [01Ch 0028 4] Asl Compiler ID : "BXPC" [020h 0032 4] Asl Compiler Revision : 00000001 Table tests/data/acpi/q35/HPET.ipmibt diff: @@ -3,7 +3,7 @@ * AML/ASL+ Disassembler version 20200326 (64-bit version) * Copyright (c) 2000 - 2020 Intel Corporation * - * Disassembly of tests/data/acpi/q35/HPET, Mon Jan 18 23:58:56 2021 + * Disassembly of /tmp/aml-LUX8W0, Mon Jan 18 23:58:56 2021 * * ACPI Data Table [HPET] * @@ -13,9 +13,9 @@ [000h 0000 4] Signature : "HPET" [High Precision E= vent Timer table] [004h 0004 4] Table Length : 00000038 [008h 0008 1] Revision : 01 -[009h 0009 1] Checksum : 03 +[009h 0009 1] Checksum : B4 [00Ah 0010 6] Oem ID : "BOCHS " -[010h 0016 8] Oem Table ID : "BXPCHPET" +[010h 0016 8] Oem Table ID : "BXPC " [018h 0024 4] Oem Revision : 00000001 [01Ch 0028 4] Asl Compiler ID : "BXPC" [020h 0032 4] Asl Compiler Revision : 00000001 Table tests/data/acpi/q35/MCFG.ipmibt diff: @@ -3,7 +3,7 @@ * AML/ASL+ Disassembler version 20200326 (64-bit version) * Copyright (c) 2000 - 2020 Intel Corporation * - * Disassembly of tests/data/acpi/q35/MCFG, Mon Jan 18 23:58:56 2021 + * Disassembly of /tmp/aml-QUX8W0, Mon Jan 18 23:58:56 2021 * * ACPI Data Table [MCFG] * @@ -13,9 +13,9 @@ [000h 0000 4] Signature : "MCFG" [Memory Mapped Co= nfiguration table] [004h 0004 4] Table Length : 0000003C [008h 0008 1] Revision : 01 -[009h 0009 1] Checksum : EF +[009h 0009 1] Checksum : 8C [00Ah 0010 6] Oem ID : "BOCHS " -[010h 0016 8] Oem Table ID : "BXPCMCFG" +[010h 0016 8] Oem Table ID : "BXPC " [018h 0024 4] Oem Revision : 00000001 [01Ch 0028 4] Asl Compiler ID : "BXPC" [020h 0032 4] Asl Compiler Revision : 00000001 Table tests/data/acpi/q35/WAET.ipmibt diff: @@ -3,7 +3,7 @@ * AML/ASL+ Disassembler version 20200326 (64-bit version) * Copyright (c) 2000 - 2020 Intel Corporation * - * Disassembly of tests/data/acpi/q35/WAET, Mon Jan 18 23:58:56 2021 + * Disassembly of /tmp/aml-VUX8W0, Mon Jan 18 23:58:56 2021 * * ACPI Data Table [WAET] * @@ -13,9 +13,9 @@ [000h 0000 4] Signature : "WAET" [Windows ACPI Emu= lated Devices Table] [004h 0004 4] Table Length : 00000028 [008h 0008 1] Revision : 01 -[009h 0009 1] Checksum : 88 +[009h 0009 1] Checksum : 39 [00Ah 0010 6] Oem ID : "BOCHS " -[010h 0016 8] Oem Table ID : "BXPCWAET" +[010h 0016 8] Oem Table ID : "BXPC " [018h 0024 4] Oem Revision : 00000001 [01Ch 0028 4] Asl Compiler ID : "BXPC" [020h 0032 4] Asl Compiler Revision : 00000001 Table tests/data/acpi/q35/DSDT.ipmibt diff: @@ -5,20 +5,20 @@ * * Disassembling to symbolic ASL+ operators * - * Disassembly of tests/data/acpi/q35/DSDT.ipmibt, Mon Jan 18 23:58:56 2021 + * Disassembly of /tmp/aml-3UX8W0, Mon Jan 18 23:58:56 2021 * * Original Table Header: * Signature "DSDT" * Length 0x00001EC4 (7876) * Revision 0x01 **** 32-bit table (V1), no 64-bit math support - * Checksum 0x2A + * Checksum 0xD9 * OEM ID "BOCHS " - * OEM Table ID "BXPCDSDT" + * OEM Table ID "BXPC " * OEM Revision 0x00000001 (1) * Compiler ID "BXPC" * Compiler Version 0x00000001 (1) */ -DefinitionBlock ("", "DSDT", 1, "BOCHS ", "BXPCDSDT", 0x00000001) +DefinitionBlock ("", "DSDT", 1, "BOCHS ", "BXPC ", 0x00000001) { Scope (\) { Table tests/data/acpi/q35/FACP.cphp diff: @@ -3,7 +3,7 @@ * AML/ASL+ Disassembler version 20200326 (64-bit version) * Copyright (c) 2000 - 2020 Intel Corporation * - * Disassembly of tests/data/acpi/q35/FACP, Mon Jan 18 23:58:56 2021 + * Disassembly of /tmp/aml-2HJNX0, Mon Jan 18 23:58:56 2021 * * ACPI Data Table [FACP] * @@ -13,9 +13,9 @@ [000h 0000 4] Signature : "FACP" [Fixed ACPI Descr= iption Table (FADT)] [004h 0004 4] Table Length : 000000F4 [008h 0008 1] Revision : 03 -[009h 0009 1] Checksum : 1F +[009h 0009 1] Checksum : B9 [00Ah 0010 6] Oem ID : "BOCHS " -[010h 0016 8] Oem Table ID : "BXPCFACP" +[010h 0016 8] Oem Table ID : "BXPC " [018h 0024 4] Oem Revision : 00000001 [01Ch 0028 4] Asl Compiler ID : "BXPC" [020h 0032 4] Asl Compiler Revision : 00000001 Table tests/data/acpi/q35/APIC.cphp diff: @@ -3,7 +3,7 @@ * AML/ASL+ Disassembler version 20200326 (64-bit version) * Copyright (c) 2000 - 2020 Intel Corporation * - * Disassembly of tests/data/acpi/q35/APIC.cphp, Mon Jan 18 23:58:56 2021 + * Disassembly of /tmp/aml-ARJNX0, Mon Jan 18 23:58:56 2021 * * ACPI Data Table [APIC] * @@ -13,9 +13,9 @@ [000h 0000 4] Signature : "APIC" [Multiple APIC De= scription Table (MADT)] [004h 0004 4] Table Length : 000000A0 [008h 0008 1] Revision : 01 -[009h 0009 1] Checksum : 7B +[009h 0009 1] Checksum : 18 [00Ah 0010 6] Oem ID : "BOCHS " -[010h 0016 8] Oem Table ID : "BXPCAPIC" +[010h 0016 8] Oem Table ID : "BXPC " [018h 0024 4] Oem Revision : 00000001 [01Ch 0028 4] Asl Compiler ID : "BXPC" [020h 0032 4] Asl Compiler Revision : 00000001 Table tests/data/acpi/q35/HPET.cphp diff: @@ -3,7 +3,7 @@ * AML/ASL+ Disassembler version 20200326 (64-bit version) * Copyright (c) 2000 - 2020 Intel Corporation * - * Disassembly of tests/data/acpi/q35/HPET, Mon Jan 18 23:58:56 2021 + * Disassembly of /tmp/aml-ERJNX0, Mon Jan 18 23:58:56 2021 * * ACPI Data Table [HPET] * @@ -13,9 +13,9 @@ [000h 0000 4] Signature : "HPET" [High Precision E= vent Timer table] [004h 0004 4] Table Length : 00000038 [008h 0008 1] Revision : 01 -[009h 0009 1] Checksum : 03 +[009h 0009 1] Checksum : B4 [00Ah 0010 6] Oem ID : "BOCHS " -[010h 0016 8] Oem Table ID : "BXPCHPET" +[010h 0016 8] Oem Table ID : "BXPC " [018h 0024 4] Oem Revision : 00000001 [01Ch 0028 4] Asl Compiler ID : "BXPC" [020h 0032 4] Asl Compiler Revision : 00000001 Table tests/data/acpi/q35/SRAT.cphp diff: @@ -3,7 +3,7 @@ * AML/ASL+ Disassembler version 20200326 (64-bit version) * Copyright (c) 2000 - 2020 Intel Corporation * - * Disassembly of tests/data/acpi/q35/SRAT.cphp, Mon Jan 18 23:58:56 2021 + * Disassembly of /tmp/aml-IRJNX0, Mon Jan 18 23:58:56 2021 * * ACPI Data Table [SRAT] * @@ -13,9 +13,9 @@ [000h 0000 4] Signature : "SRAT" [System Resource = Affinity Table] [004h 0004 4] Table Length : 00000130 [008h 0008 1] Revision : 01 -[009h 0009 1] Checksum : 36 +[009h 0009 1] Checksum : F0 [00Ah 0010 6] Oem ID : "BOCHS " -[010h 0016 8] Oem Table ID : "BXPCSRAT" +[010h 0016 8] Oem Table ID : "BXPC " [018h 0024 4] Oem Revision : 00000001 [01Ch 0028 4] Asl Compiler ID : "BXPC" [020h 0032 4] Asl Compiler Revision : 00000001 Table tests/data/acpi/q35/SLIT.cphp diff: @@ -3,7 +3,7 @@ * AML/ASL+ Disassembler version 20200326 (64-bit version) * Copyright (c) 2000 - 2020 Intel Corporation * - * Disassembly of tests/data/acpi/q35/SLIT.cphp, Mon Jan 18 23:58:56 2021 + * Disassembly of /tmp/aml-MRJNX0, Mon Jan 18 23:58:56 2021 * * ACPI Data Table [SLIT] * @@ -13,9 +13,9 @@ [000h 0000 4] Signature : "SLIT" [System Locality = Information Table] [004h 0004 4] Table Length : 00000030 [008h 0008 1] Revision : 01 -[009h 0009 1] Checksum : 2C +[009h 0009 1] Checksum : E8 [00Ah 0010 6] Oem ID : "BOCHS " -[010h 0016 8] Oem Table ID : "BXPCSLIT" +[010h 0016 8] Oem Table ID : "BXPC " [018h 0024 4] Oem Revision : 00000001 [01Ch 0028 4] Asl Compiler ID : "BXPC" [020h 0032 4] Asl Compiler Revision : 00000001 Table tests/data/acpi/q35/MCFG.cphp diff: @@ -3,7 +3,7 @@ * AML/ASL+ Disassembler version 20200326 (64-bit version) * Copyright (c) 2000 - 2020 Intel Corporation * - * Disassembly of tests/data/acpi/q35/MCFG, Mon Jan 18 23:58:56 2021 + * Disassembly of /tmp/aml-PRJNX0, Mon Jan 18 23:58:56 2021 * * ACPI Data Table [MCFG] * @@ -13,9 +13,9 @@ [000h 0000 4] Signature : "MCFG" [Memory Mapped Co= nfiguration table] [004h 0004 4] Table Length : 0000003C [008h 0008 1] Revision : 01 -[009h 0009 1] Checksum : EF +[009h 0009 1] Checksum : 8C [00Ah 0010 6] Oem ID : "BOCHS " -[010h 0016 8] Oem Table ID : "BXPCMCFG" +[010h 0016 8] Oem Table ID : "BXPC " [018h 0024 4] Oem Revision : 00000001 [01Ch 0028 4] Asl Compiler ID : "BXPC" [020h 0032 4] Asl Compiler Revision : 00000001 Table tests/data/acpi/q35/WAET.cphp diff: @@ -3,7 +3,7 @@ * AML/ASL+ Disassembler version 20200326 (64-bit version) * Copyright (c) 2000 - 2020 Intel Corporation * - * Disassembly of tests/data/acpi/q35/WAET, Mon Jan 18 23:58:57 2021 + * Disassembly of /tmp/aml-TRJNX0, Mon Jan 18 23:58:57 2021 * * ACPI Data Table [WAET] * @@ -13,9 +13,9 @@ [000h 0000 4] Signature : "WAET" [Windows ACPI Emu= lated Devices Table] [004h 0004 4] Table Length : 00000028 [008h 0008 1] Revision : 01 -[009h 0009 1] Checksum : 88 +[009h 0009 1] Checksum : 39 [00Ah 0010 6] Oem ID : "BOCHS " -[010h 0016 8] Oem Table ID : "BXPCWAET" +[010h 0016 8] Oem Table ID : "BXPC " [018h 0024 4] Oem Revision : 00000001 [01Ch 0028 4] Asl Compiler ID : "BXPC" [020h 0032 4] Asl Compiler Revision : 00000001 Table tests/data/acpi/q35/DSDT.cphp diff: @@ -5,20 +5,20 @@ * * Disassembling to symbolic ASL+ operators * - * Disassembly of tests/data/acpi/q35/DSDT.cphp, Mon Jan 18 23:58:57 2021 + * Disassembly of /tmp/aml-2RJNX0, Mon Jan 18 23:58:57 2021 * * Original Table Header: * Signature "DSDT" * Length 0x00002049 (8265) * Revision 0x01 **** 32-bit table (V1), no 64-bit math support - * Checksum 0x5A + * Checksum 0x09 * OEM ID "BOCHS " - * OEM Table ID "BXPCDSDT" + * OEM Table ID "BXPC " * OEM Revision 0x00000001 (1) * Compiler ID "BXPC" * Compiler Version 0x00000001 (1) */ -DefinitionBlock ("", "DSDT", 1, "BOCHS ", "BXPCDSDT", 0x00000001) +DefinitionBlock ("", "DSDT", 1, "BOCHS ", "BXPC ", 0x00000001) { Scope (\) { Table tests/data/acpi/q35/HPET.memhp diff: @@ -3,7 +3,7 @@ * AML/ASL+ Disassembler version 20200326 (64-bit version) * Copyright (c) 2000 - 2020 Intel Corporation * - * Disassembly of tests/data/acpi/q35/HPET, Mon Jan 18 23:58:57 2021 + * Disassembly of /tmp/aml-V1NBX0, Mon Jan 18 23:58:57 2021 * * ACPI Data Table [HPET] * @@ -13,9 +13,9 @@ [000h 0000 4] Signature : "HPET" [High Precision E= vent Timer table] [004h 0004 4] Table Length : 00000038 [008h 0008 1] Revision : 01 -[009h 0009 1] Checksum : 03 +[009h 0009 1] Checksum : B4 [00Ah 0010 6] Oem ID : "BOCHS " -[010h 0016 8] Oem Table ID : "BXPCHPET" +[010h 0016 8] Oem Table ID : "BXPC " [018h 0024 4] Oem Revision : 00000001 [01Ch 0028 4] Asl Compiler ID : "BXPC" [020h 0032 4] Asl Compiler Revision : 00000001 Table tests/data/acpi/q35/WAET.memhp diff: @@ -3,7 +3,7 @@ * AML/ASL+ Disassembler version 20200326 (64-bit version) * Copyright (c) 2000 - 2020 Intel Corporation * - * Disassembly of tests/data/acpi/q35/WAET, Mon Jan 18 23:58:57 2021 + * Disassembly of /tmp/aml-B2NBX0, Mon Jan 18 23:58:57 2021 * * ACPI Data Table [WAET] * @@ -13,9 +13,9 @@ [000h 0000 4] Signature : "WAET" [Windows ACPI Emu= lated Devices Table] [004h 0004 4] Table Length : 00000028 [008h 0008 1] Revision : 01 -[009h 0009 1] Checksum : 88 +[009h 0009 1] Checksum : 39 [00Ah 0010 6] Oem ID : "BOCHS " -[010h 0016 8] Oem Table ID : "BXPCWAET" +[010h 0016 8] Oem Table ID : "BXPC " [018h 0024 4] Oem Revision : 00000001 [01Ch 0028 4] Asl Compiler ID : "BXPC" [020h 0032 4] Asl Compiler Revision : 00000001 Table tests/data/acpi/q35/HPET.numamem diff: @@ -3,7 +3,7 @@ * AML/ASL+ Disassembler version 20200326 (64-bit version) * Copyright (c) 2000 - 2020 Intel Corporation * - * Disassembly of tests/data/acpi/q35/HPET, Mon Jan 18 23:58:57 2021 + * Disassembly of /tmp/aml-BJ6PX0, Mon Jan 18 23:58:57 2021 * * ACPI Data Table [HPET] * @@ -13,9 +13,9 @@ [000h 0000 4] Signature : "HPET" [High Precision E= vent Timer table] [004h 0004 4] Table Length : 00000038 [008h 0008 1] Revision : 01 -[009h 0009 1] Checksum : 03 +[009h 0009 1] Checksum : B4 [00Ah 0010 6] Oem ID : "BOCHS " -[010h 0016 8] Oem Table ID : "BXPCHPET" +[010h 0016 8] Oem Table ID : "BXPC " [018h 0024 4] Oem Revision : 00000001 [01Ch 0028 4] Asl Compiler ID : "BXPC" [020h 0032 4] Asl Compiler Revision : 00000001 Table tests/data/acpi/q35/WAET.numamem diff: @@ -3,7 +3,7 @@ * AML/ASL+ Disassembler version 20200326 (64-bit version) * Copyright (c) 2000 - 2020 Intel Corporation * - * Disassembly of tests/data/acpi/q35/WAET, Mon Jan 18 23:58:57 2021 + * Disassembly of /tmp/aml-UH6PX0, Mon Jan 18 23:58:57 2021 * * ACPI Data Table [WAET] * @@ -13,9 +13,9 @@ [000h 0000 4] Signature : "WAET" [Windows ACPI Emu= lated Devices Table] [004h 0004 4] Table Length : 00000028 [008h 0008 1] Revision : 01 -[009h 0009 1] Checksum : 88 +[009h 0009 1] Checksum : 39 [00Ah 0010 6] Oem ID : "BOCHS " -[010h 0016 8] Oem Table ID : "BXPCWAET" +[010h 0016 8] Oem Table ID : "BXPC " [018h 0024 4] Oem Revision : 00000001 [01Ch 0028 4] Asl Compiler ID : "BXPC" [020h 0032 4] Asl Compiler Revision : 00000001 Table tests/data/acpi/q35/FACP.dimmpxm diff: @@ -3,7 +3,7 @@ * AML/ASL+ Disassembler version 20200326 (64-bit version) * Copyright (c) 2000 - 2020 Intel Corporation * - * Disassembly of tests/data/acpi/q35/FACP, Mon Jan 18 23:58:58 2021 + * Disassembly of /tmp/aml-ITDEX0, Mon Jan 18 23:58:58 2021 * * ACPI Data Table [FACP] * @@ -13,9 +13,9 @@ [000h 0000 4] Signature : "FACP" [Fixed ACPI Descr= iption Table (FADT)] [004h 0004 4] Table Length : 000000F4 [008h 0008 1] Revision : 03 -[009h 0009 1] Checksum : 1F +[009h 0009 1] Checksum : B9 [00Ah 0010 6] Oem ID : "BOCHS " -[010h 0016 8] Oem Table ID : "BXPCFACP" +[010h 0016 8] Oem Table ID : "BXPC " [018h 0024 4] Oem Revision : 00000001 [01Ch 0028 4] Asl Compiler ID : "BXPC" [020h 0032 4] Asl Compiler Revision : 00000001 Table tests/data/acpi/q35/APIC.dimmpxm diff: @@ -3,7 +3,7 @@ * AML/ASL+ Disassembler version 20200326 (64-bit version) * Copyright (c) 2000 - 2020 Intel Corporation * - * Disassembly of tests/data/acpi/q35/APIC.dimmpxm, Mon Jan 18 23:58:58 20= 21 + * Disassembly of /tmp/aml-STDEX0, Mon Jan 18 23:58:58 2021 * * ACPI Data Table [APIC] * @@ -13,9 +13,9 @@ [000h 0000 4] Signature : "APIC" [Multiple APIC De= scription Table (MADT)] [004h 0004 4] Table Length : 00000090 [008h 0008 1] Revision : 01 -[009h 0009 1] Checksum : AE +[009h 0009 1] Checksum : 4B [00Ah 0010 6] Oem ID : "BOCHS " -[010h 0016 8] Oem Table ID : "BXPCAPIC" +[010h 0016 8] Oem Table ID : "BXPC " [018h 0024 4] Oem Revision : 00000001 [01Ch 0028 4] Asl Compiler ID : "BXPC" [020h 0032 4] Asl Compiler Revision : 00000001 Table tests/data/acpi/q35/HPET.dimmpxm diff: @@ -3,7 +3,7 @@ * AML/ASL+ Disassembler version 20200326 (64-bit version) * Copyright (c) 2000 - 2020 Intel Corporation * - * Disassembly of tests/data/acpi/q35/HPET, Mon Jan 18 23:58:58 2021 + * Disassembly of /tmp/aml-WTDEX0, Mon Jan 18 23:58:58 2021 * * ACPI Data Table [HPET] * @@ -13,9 +13,9 @@ [000h 0000 4] Signature : "HPET" [High Precision E= vent Timer table] [004h 0004 4] Table Length : 00000038 [008h 0008 1] Revision : 01 -[009h 0009 1] Checksum : 03 +[009h 0009 1] Checksum : B4 [00Ah 0010 6] Oem ID : "BOCHS " -[010h 0016 8] Oem Table ID : "BXPCHPET" +[010h 0016 8] Oem Table ID : "BXPC " [018h 0024 4] Oem Revision : 00000001 [01Ch 0028 4] Asl Compiler ID : "BXPC" [020h 0032 4] Asl Compiler Revision : 00000001 Table tests/data/acpi/q35/SRAT.dimmpxm diff: @@ -3,7 +3,7 @@ * AML/ASL+ Disassembler version 20200326 (64-bit version) * Copyright (c) 2000 - 2020 Intel Corporation * - * Disassembly of tests/data/acpi/q35/SRAT.dimmpxm, Mon Jan 18 23:58:58 20= 21 + * Disassembly of /tmp/aml-XTJEX0, Mon Jan 18 23:58:58 2021 * * ACPI Data Table [SRAT] * @@ -13,9 +13,9 @@ [000h 0000 4] Signature : "SRAT" [System Resource = Affinity Table] [004h 0004 4] Table Length : 00000188 [008h 0008 1] Revision : 01 -[009h 0009 1] Checksum : 68 +[009h 0009 1] Checksum : 22 [00Ah 0010 6] Oem ID : "BOCHS " -[010h 0016 8] Oem Table ID : "BXPCSRAT" +[010h 0016 8] Oem Table ID : "BXPC " [018h 0024 4] Oem Revision : 00000001 [01Ch 0028 4] Asl Compiler ID : "BXPC" [020h 0032 4] Asl Compiler Revision : 00000001 Table tests/data/acpi/q35/MCFG.dimmpxm diff: @@ -3,7 +3,7 @@ * AML/ASL+ Disassembler version 20200326 (64-bit version) * Copyright (c) 2000 - 2020 Intel Corporation * - * Disassembly of tests/data/acpi/q35/MCFG, Mon Jan 18 23:58:58 2021 + * Disassembly of /tmp/aml-0TDEX0, Mon Jan 18 23:58:58 2021 * * ACPI Data Table [MCFG] * @@ -13,9 +13,9 @@ [000h 0000 4] Signature : "MCFG" [Memory Mapped Co= nfiguration table] [004h 0004 4] Table Length : 0000003C [008h 0008 1] Revision : 01 -[009h 0009 1] Checksum : EF +[009h 0009 1] Checksum : 8C [00Ah 0010 6] Oem ID : "BOCHS " -[010h 0016 8] Oem Table ID : "BXPCMCFG" +[010h 0016 8] Oem Table ID : "BXPC " [018h 0024 4] Oem Revision : 00000001 [01Ch 0028 4] Asl Compiler ID : "BXPC" [020h 0032 4] Asl Compiler Revision : 00000001 Table tests/data/acpi/q35/SSDT.dimmpxm diff: @@ -5,20 +5,20 @@ * * Disassembling to symbolic ASL+ operators * - * Disassembly of tests/data/acpi/q35/SSDT.dimmpxm, Mon Jan 18 23:58:58 20= 21 + * Disassembly of /tmp/aml-8TDEX0, Mon Jan 18 23:58:58 2021 * * Original Table Header: * Signature "SSDT" * Length 0x000002DE (734) * Revision 0x01 - * Checksum 0x46 + * Checksum 0x06 * OEM ID "BOCHS " - * OEM Table ID "NVDIMM" + * OEM Table ID "NVDIMM " * OEM Revision 0x00000001 (1) * Compiler ID "BXPC" * Compiler Version 0x00000001 (1) */ -DefinitionBlock ("", "SSDT", 1, "BOCHS ", "NVDIMM", 0x00000001) +DefinitionBlock ("", "SSDT", 1, "BOCHS ", "NVDIMM ", 0x00000001) { Scope (\_SB) { Table tests/data/acpi/q35/NFIT.dimmpxm diff: @@ -3,7 +3,7 @@ * AML/ASL+ Disassembler version 20200326 (64-bit version) * Copyright (c) 2000 - 2020 Intel Corporation * - * Disassembly of tests/data/acpi/q35/NFIT.dimmpxm, Mon Jan 18 23:58:58 20= 21 + * Disassembly of /tmp/aml-9VDEX0, Mon Jan 18 23:58:58 2021 * * ACPI Data Table [NFIT] * @@ -13,9 +13,9 @@ [000h 0000 4] Signature : "NFIT" [NVDIMM Firmware = Interface Table] [004h 0004 4] Table Length : 000000F0 [008h 0008 1] Revision : 01 -[009h 0009 1] Checksum : 24 +[009h 0009 1] Checksum : D5 [00Ah 0010 6] Oem ID : "BOCHS " -[010h 0016 8] Oem Table ID : "BXPCNFIT" +[010h 0016 8] Oem Table ID : "BXPC " [018h 0024 4] Oem Revision : 00000001 [01Ch 0028 4] Asl Compiler ID : "BXPC" [020h 0032 4] Asl Compiler Revision : 00000001 Table tests/data/acpi/q35/WAET.dimmpxm diff: @@ -3,7 +3,7 @@ * AML/ASL+ Disassembler version 20200326 (64-bit version) * Copyright (c) 2000 - 2020 Intel Corporation * - * Disassembly of tests/data/acpi/q35/WAET, Mon Jan 18 23:58:58 2021 + * Disassembly of /tmp/aml-DWDEX0, Mon Jan 18 23:58:58 2021 * * ACPI Data Table [WAET] * @@ -13,9 +13,9 @@ [000h 0000 4] Signature : "WAET" [Windows ACPI Emu= lated Devices Table] [004h 0004 4] Table Length : 00000028 [008h 0008 1] Revision : 01 -[009h 0009 1] Checksum : 88 +[009h 0009 1] Checksum : 39 [00Ah 0010 6] Oem ID : "BOCHS " -[010h 0016 8] Oem Table ID : "BXPCWAET" +[010h 0016 8] Oem Table ID : "BXPC " [018h 0024 4] Oem Revision : 00000001 [01Ch 0028 4] Asl Compiler ID : "BXPC" [020h 0032 4] Asl Compiler Revision : 00000001 Table tests/data/acpi/q35/DSDT.dimmpxm diff: @@ -5,20 +5,20 @@ * * Disassembling to symbolic ASL+ operators * - * Disassembly of tests/data/acpi/q35/DSDT.dimmpxm, Mon Jan 18 23:58:58 20= 21 + * Disassembly of /tmp/aml-IWDEX0, Mon Jan 18 23:58:58 2021 * * Original Table Header: * Signature "DSDT" * Length 0x000024EF (9455) * Revision 0x01 **** 32-bit table (V1), no 64-bit math support - * Checksum 0x26 + * Checksum 0xD5 * OEM ID "BOCHS " - * OEM Table ID "BXPCDSDT" + * OEM Table ID "BXPC " * OEM Revision 0x00000001 (1) * Compiler ID "BXPC" * Compiler Version 0x00000001 (1) */ -DefinitionBlock ("", "DSDT", 1, "BOCHS ", "BXPCDSDT", 0x00000001) +DefinitionBlock ("", "DSDT", 1, "BOCHS ", "BXPC ", 0x00000001) { External (_SB_.NVDR, UnknownObj) Table tests/data/acpi/q35/FACP.acpihmat diff: @@ -3,7 +3,7 @@ * AML/ASL+ Disassembler version 20200326 (64-bit version) * Copyright (c) 2000 - 2020 Intel Corporation * - * Disassembly of tests/data/acpi/q35/FACP, Mon Jan 18 23:58:58 2021 + * Disassembly of /tmp/aml-OKSOX0, Mon Jan 18 23:58:58 2021 * * ACPI Data Table [FACP] * @@ -13,9 +13,9 @@ [000h 0000 4] Signature : "FACP" [Fixed ACPI Descr= iption Table (FADT)] [004h 0004 4] Table Length : 000000F4 [008h 0008 1] Revision : 03 -[009h 0009 1] Checksum : 1F +[009h 0009 1] Checksum : B9 [00Ah 0010 6] Oem ID : "BOCHS " -[010h 0016 8] Oem Table ID : "BXPCFACP" +[010h 0016 8] Oem Table ID : "BXPC " [018h 0024 4] Oem Revision : 00000001 [01Ch 0028 4] Asl Compiler ID : "BXPC" [020h 0032 4] Asl Compiler Revision : 00000001 Table tests/data/acpi/q35/APIC.acpihmat diff: @@ -3,7 +3,7 @@ * AML/ASL+ Disassembler version 20200326 (64-bit version) * Copyright (c) 2000 - 2020 Intel Corporation * - * Disassembly of tests/data/acpi/q35/APIC.acpihmat, Mon Jan 18 23:58:58 2= 021 + * Disassembly of /tmp/aml-0KSOX0, Mon Jan 18 23:58:58 2021 * * ACPI Data Table [APIC] * @@ -13,9 +13,9 @@ [000h 0000 4] Signature : "APIC" [Multiple APIC De= scription Table (MADT)] [004h 0004 4] Table Length : 00000080 [008h 0008 1] Revision : 01 -[009h 0009 1] Checksum : DA +[009h 0009 1] Checksum : 77 [00Ah 0010 6] Oem ID : "BOCHS " -[010h 0016 8] Oem Table ID : "BXPCAPIC" +[010h 0016 8] Oem Table ID : "BXPC " [018h 0024 4] Oem Revision : 00000001 [01Ch 0028 4] Asl Compiler ID : "BXPC" [020h 0032 4] Asl Compiler Revision : 00000001 Table tests/data/acpi/q35/HPET.acpihmat diff: @@ -3,7 +3,7 @@ * AML/ASL+ Disassembler version 20200326 (64-bit version) * Copyright (c) 2000 - 2020 Intel Corporation * - * Disassembly of tests/data/acpi/q35/HPET, Mon Jan 18 23:58:58 2021 + * Disassembly of /tmp/aml-5KSOX0, Mon Jan 18 23:58:58 2021 * * ACPI Data Table [HPET] * @@ -13,9 +13,9 @@ [000h 0000 4] Signature : "HPET" [High Precision E= vent Timer table] [004h 0004 4] Table Length : 00000038 [008h 0008 1] Revision : 01 -[009h 0009 1] Checksum : 03 +[009h 0009 1] Checksum : B4 [00Ah 0010 6] Oem ID : "BOCHS " -[010h 0016 8] Oem Table ID : "BXPCHPET" +[010h 0016 8] Oem Table ID : "BXPC " [018h 0024 4] Oem Revision : 00000001 [01Ch 0028 4] Asl Compiler ID : "BXPC" [020h 0032 4] Asl Compiler Revision : 00000001 Table tests/data/acpi/q35/SRAT.acpihmat diff: @@ -3,7 +3,7 @@ * AML/ASL+ Disassembler version 20200326 (64-bit version) * Copyright (c) 2000 - 2020 Intel Corporation * - * Disassembly of tests/data/acpi/q35/SRAT.acpihmat, Mon Jan 18 23:58:58 2= 021 + * Disassembly of /tmp/aml-9KSOX0, Mon Jan 18 23:58:58 2021 * * ACPI Data Table [SRAT] * @@ -13,9 +13,9 @@ [000h 0000 4] Signature : "SRAT" [System Resource = Affinity Table] [004h 0004 4] Table Length : 00000118 [008h 0008 1] Revision : 01 -[009h 0009 1] Checksum : C0 +[009h 0009 1] Checksum : 7A [00Ah 0010 6] Oem ID : "BOCHS " -[010h 0016 8] Oem Table ID : "BXPCSRAT" +[010h 0016 8] Oem Table ID : "BXPC " [018h 0024 4] Oem Revision : 00000001 [01Ch 0028 4] Asl Compiler ID : "BXPC" [020h 0032 4] Asl Compiler Revision : 00000001 Table tests/data/acpi/q35/HMAT.acpihmat diff: @@ -3,7 +3,7 @@ * AML/ASL+ Disassembler version 20200326 (64-bit version) * Copyright (c) 2000 - 2020 Intel Corporation * - * Disassembly of tests/data/acpi/q35/HMAT.acpihmat, Mon Jan 18 23:58:58 2= 021 + * Disassembly of /tmp/aml-ALYOX0, Mon Jan 18 23:58:58 2021 * * ACPI Data Table [HMAT] * @@ -13,9 +13,9 @@ [000h 0000 4] Signature : "HMAT" [Heterogeneous Me= mory Attributes Table] [004h 0004 4] Table Length : 00000118 [008h 0008 1] Revision : 02 -[009h 0009 1] Checksum : 98 +[009h 0009 1] Checksum : 42 [00Ah 0010 6] Oem ID : "BOCHS " -[010h 0016 8] Oem Table ID : "BXPCHMAT" +[010h 0016 8] Oem Table ID : "BXPC " [018h 0024 4] Oem Revision : 00000001 [01Ch 0028 4] Asl Compiler ID : "BXPC" [020h 0032 4] Asl Compiler Revision : 00000001 Table tests/data/acpi/q35/MCFG.acpihmat diff: @@ -3,7 +3,7 @@ * AML/ASL+ Disassembler version 20200326 (64-bit version) * Copyright (c) 2000 - 2020 Intel Corporation * - * Disassembly of tests/data/acpi/q35/MCFG, Mon Jan 18 23:58:58 2021 + * Disassembly of /tmp/aml-ELSOX0, Mon Jan 18 23:58:58 2021 * * ACPI Data Table [MCFG] * @@ -13,9 +13,9 @@ [000h 0000 4] Signature : "MCFG" [Memory Mapped Co= nfiguration table] [004h 0004 4] Table Length : 0000003C [008h 0008 1] Revision : 01 -[009h 0009 1] Checksum : EF +[009h 0009 1] Checksum : 8C [00Ah 0010 6] Oem ID : "BOCHS " -[010h 0016 8] Oem Table ID : "BXPCMCFG" +[010h 0016 8] Oem Table ID : "BXPC " [018h 0024 4] Oem Revision : 00000001 [01Ch 0028 4] Asl Compiler ID : "BXPC" [020h 0032 4] Asl Compiler Revision : 00000001 Table tests/data/acpi/q35/WAET.acpihmat diff: @@ -3,7 +3,7 @@ * AML/ASL+ Disassembler version 20200326 (64-bit version) * Copyright (c) 2000 - 2020 Intel Corporation * - * Disassembly of tests/data/acpi/q35/WAET, Mon Jan 18 23:58:58 2021 + * Disassembly of /tmp/aml-ILSOX0, Mon Jan 18 23:58:58 2021 * * ACPI Data Table [WAET] * @@ -13,9 +13,9 @@ [000h 0000 4] Signature : "WAET" [Windows ACPI Emu= lated Devices Table] [004h 0004 4] Table Length : 00000028 [008h 0008 1] Revision : 01 -[009h 0009 1] Checksum : 88 +[009h 0009 1] Checksum : 39 [00Ah 0010 6] Oem ID : "BOCHS " -[010h 0016 8] Oem Table ID : "BXPCWAET" +[010h 0016 8] Oem Table ID : "BXPC " [018h 0024 4] Oem Revision : 00000001 [01Ch 0028 4] Asl Compiler ID : "BXPC" [020h 0032 4] Asl Compiler Revision : 00000001 Table tests/data/acpi/q35/DSDT.acpihmat diff: @@ -5,20 +5,20 @@ * * Disassembling to symbolic ASL+ operators * - * Disassembly of tests/data/acpi/q35/DSDT.acpihmat, Mon Jan 18 23:58:58 2= 021 + * Disassembly of /tmp/aml-2JSOX0, Mon Jan 18 23:58:58 2021 * * Original Table Header: * Signature "DSDT" * Length 0x000023A6 (9126) * Revision 0x01 **** 32-bit table (V1), no 64-bit math support - * Checksum 0xB3 + * Checksum 0x62 * OEM ID "BOCHS " - * OEM Table ID "BXPCDSDT" + * OEM Table ID "BXPC " * OEM Revision 0x00000001 (1) * Compiler ID "BXPC" * Compiler Version 0x00000001 (1) */ -DefinitionBlock ("", "DSDT", 1, "BOCHS ", "BXPCDSDT", 0x00000001) +DefinitionBlock ("", "DSDT", 1, "BOCHS ", "BXPC ", 0x00000001) { Scope (\) { Table tests/data/acpi/pc/FACP.ipmikcs diff: @@ -3,7 +3,7 @@ * AML/ASL+ Disassembler version 20200326 (64-bit version) * Copyright (c) 2000 - 2020 Intel Corporation * - * Disassembly of tests/data/acpi/pc/FACP, Mon Jan 18 23:58:59 2021 + * Disassembly of /tmp/aml-1HH9W0, Mon Jan 18 23:58:59 2021 * * ACPI Data Table [FACP] * @@ -13,9 +13,9 @@ [000h 0000 4] Signature : "FACP" [Fixed ACPI Descr= iption Table (FADT)] [004h 0004 4] Table Length : 00000074 [008h 0008 1] Revision : 01 -[009h 0009 1] Checksum : A1 +[009h 0009 1] Checksum : 3B [00Ah 0010 6] Oem ID : "BOCHS " -[010h 0016 8] Oem Table ID : "BXPCFACP" +[010h 0016 8] Oem Table ID : "BXPC " [018h 0024 4] Oem Revision : 00000001 [01Ch 0028 4] Asl Compiler ID : "BXPC" [020h 0032 4] Asl Compiler Revision : 00000001 Table tests/data/acpi/pc/APIC.ipmikcs diff: @@ -3,7 +3,7 @@ * AML/ASL+ Disassembler version 20200326 (64-bit version) * Copyright (c) 2000 - 2020 Intel Corporation * - * Disassembly of tests/data/acpi/pc/APIC, Mon Jan 18 23:58:59 2021 + * Disassembly of /tmp/aml-GIH9W0, Mon Jan 18 23:58:59 2021 * * ACPI Data Table [APIC] * @@ -13,9 +13,9 @@ [000h 0000 4] Signature : "APIC" [Multiple APIC De= scription Table (MADT)] [004h 0004 4] Table Length : 00000078 [008h 0008 1] Revision : 01 -[009h 0009 1] Checksum : ED +[009h 0009 1] Checksum : 8A [00Ah 0010 6] Oem ID : "BOCHS " -[010h 0016 8] Oem Table ID : "BXPCAPIC" +[010h 0016 8] Oem Table ID : "BXPC " [018h 0024 4] Oem Revision : 00000001 [01Ch 0028 4] Asl Compiler ID : "BXPC" [020h 0032 4] Asl Compiler Revision : 00000001 Table tests/data/acpi/pc/HPET.ipmikcs diff: @@ -3,7 +3,7 @@ * AML/ASL+ Disassembler version 20200326 (64-bit version) * Copyright (c) 2000 - 2020 Intel Corporation * - * Disassembly of tests/data/acpi/pc/HPET, Mon Jan 18 23:58:59 2021 + * Disassembly of /tmp/aml-PIH9W0, Mon Jan 18 23:58:59 2021 * * ACPI Data Table [HPET] * @@ -13,9 +13,9 @@ [000h 0000 4] Signature : "HPET" [High Precision E= vent Timer table] [004h 0004 4] Table Length : 00000038 [008h 0008 1] Revision : 01 -[009h 0009 1] Checksum : 03 +[009h 0009 1] Checksum : B4 [00Ah 0010 6] Oem ID : "BOCHS " -[010h 0016 8] Oem Table ID : "BXPCHPET" +[010h 0016 8] Oem Table ID : "BXPC " [018h 0024 4] Oem Revision : 00000001 [01Ch 0028 4] Asl Compiler ID : "BXPC" [020h 0032 4] Asl Compiler Revision : 00000001 Table tests/data/acpi/pc/WAET.ipmikcs diff: @@ -3,7 +3,7 @@ * AML/ASL+ Disassembler version 20200326 (64-bit version) * Copyright (c) 2000 - 2020 Intel Corporation * - * Disassembly of tests/data/acpi/pc/WAET, Mon Jan 18 23:58:59 2021 + * Disassembly of /tmp/aml-OIH9W0, Mon Jan 18 23:58:59 2021 * * ACPI Data Table [WAET] * @@ -13,9 +13,9 @@ [000h 0000 4] Signature : "WAET" [Windows ACPI Emu= lated Devices Table] [004h 0004 4] Table Length : 00000028 [008h 0008 1] Revision : 01 -[009h 0009 1] Checksum : 88 +[009h 0009 1] Checksum : 39 [00Ah 0010 6] Oem ID : "BOCHS " -[010h 0016 8] Oem Table ID : "BXPCWAET" +[010h 0016 8] Oem Table ID : "BXPC " [018h 0024 4] Oem Revision : 00000001 [01Ch 0028 4] Asl Compiler ID : "BXPC" [020h 0032 4] Asl Compiler Revision : 00000001 Table tests/data/acpi/pc/DSDT.ipmikcs diff: @@ -5,20 +5,20 @@ * * Disassembling to symbolic ASL+ operators * - * Disassembly of tests/data/acpi/pc/DSDT.ipmikcs, Mon Jan 18 23:58:59 2021 + * Disassembly of /tmp/aml-9GH9W0, Mon Jan 18 23:58:59 2021 * * Original Table Header: * Signature "DSDT" * Length 0x00001411 (5137) * Revision 0x01 **** 32-bit table (V1), no 64-bit math support - * Checksum 0x33 + * Checksum 0xE2 * OEM ID "BOCHS " - * OEM Table ID "BXPCDSDT" + * OEM Table ID "BXPC " * OEM Revision 0x00000001 (1) * Compiler ID "BXPC" * Compiler Version 0x00000001 (1) */ -DefinitionBlock ("", "DSDT", 1, "BOCHS ", "BXPCDSDT", 0x00000001) +DefinitionBlock ("", "DSDT", 1, "BOCHS ", "BXPC ", 0x00000001) { Scope (\) { Table tests/data/acpi/pc/FACP.roothp diff: @@ -3,7 +3,7 @@ * AML/ASL+ Disassembler version 20200326 (64-bit version) * Copyright (c) 2000 - 2020 Intel Corporation * - * Disassembly of tests/data/acpi/pc/FACP, Mon Jan 18 23:59:01 2021 + * Disassembly of /tmp/aml-84PIX0, Mon Jan 18 23:59:01 2021 * * ACPI Data Table [FACP] * @@ -13,9 +13,9 @@ [000h 0000 4] Signature : "FACP" [Fixed ACPI Descr= iption Table (FADT)] [004h 0004 4] Table Length : 00000074 [008h 0008 1] Revision : 01 -[009h 0009 1] Checksum : A1 +[009h 0009 1] Checksum : 3B [00Ah 0010 6] Oem ID : "BOCHS " -[010h 0016 8] Oem Table ID : "BXPCFACP" +[010h 0016 8] Oem Table ID : "BXPC " [018h 0024 4] Oem Revision : 00000001 [01Ch 0028 4] Asl Compiler ID : "BXPC" [020h 0032 4] Asl Compiler Revision : 00000001 Table tests/data/acpi/pc/APIC.roothp diff: @@ -3,7 +3,7 @@ * AML/ASL+ Disassembler version 20200326 (64-bit version) * Copyright (c) 2000 - 2020 Intel Corporation * - * Disassembly of tests/data/acpi/pc/APIC, Mon Jan 18 23:59:01 2021 + * Disassembly of /tmp/aml-D5PIX0, Mon Jan 18 23:59:01 2021 * * ACPI Data Table [APIC] * @@ -13,9 +13,9 @@ [000h 0000 4] Signature : "APIC" [Multiple APIC De= scription Table (MADT)] [004h 0004 4] Table Length : 00000078 [008h 0008 1] Revision : 01 -[009h 0009 1] Checksum : ED +[009h 0009 1] Checksum : 8A [00Ah 0010 6] Oem ID : "BOCHS " -[010h 0016 8] Oem Table ID : "BXPCAPIC" +[010h 0016 8] Oem Table ID : "BXPC " [018h 0024 4] Oem Revision : 00000001 [01Ch 0028 4] Asl Compiler ID : "BXPC" [020h 0032 4] Asl Compiler Revision : 00000001 Table tests/data/acpi/pc/HPET.roothp diff: @@ -3,7 +3,7 @@ * AML/ASL+ Disassembler version 20200326 (64-bit version) * Copyright (c) 2000 - 2020 Intel Corporation * - * Disassembly of tests/data/acpi/pc/HPET, Mon Jan 18 23:59:01 2021 + * Disassembly of /tmp/aml-P5PIX0, Mon Jan 18 23:59:01 2021 * * ACPI Data Table [HPET] * @@ -13,9 +13,9 @@ [000h 0000 4] Signature : "HPET" [High Precision E= vent Timer table] [004h 0004 4] Table Length : 00000038 [008h 0008 1] Revision : 01 -[009h 0009 1] Checksum : 03 +[009h 0009 1] Checksum : B4 [00Ah 0010 6] Oem ID : "BOCHS " -[010h 0016 8] Oem Table ID : "BXPCHPET" +[010h 0016 8] Oem Table ID : "BXPC " [018h 0024 4] Oem Revision : 00000001 [01Ch 0028 4] Asl Compiler ID : "BXPC" [020h 0032 4] Asl Compiler Revision : 00000001 Table tests/data/acpi/pc/WAET.roothp diff: @@ -3,7 +3,7 @@ * AML/ASL+ Disassembler version 20200326 (64-bit version) * Copyright (c) 2000 - 2020 Intel Corporation * - * Disassembly of tests/data/acpi/pc/WAET, Mon Jan 18 23:59:01 2021 + * Disassembly of /tmp/aml-N5PIX0, Mon Jan 18 23:59:01 2021 * * ACPI Data Table [WAET] * @@ -13,9 +13,9 @@ [000h 0000 4] Signature : "WAET" [Windows ACPI Emu= lated Devices Table] [004h 0004 4] Table Length : 00000028 [008h 0008 1] Revision : 01 -[009h 0009 1] Checksum : 88 +[009h 0009 1] Checksum : 39 [00Ah 0010 6] Oem ID : "BOCHS " -[010h 0016 8] Oem Table ID : "BXPCWAET" +[010h 0016 8] Oem Table ID : "BXPC " [018h 0024 4] Oem Revision : 00000001 [01Ch 0028 4] Asl Compiler ID : "BXPC" [020h 0032 4] Asl Compiler Revision : 00000001 Table tests/data/acpi/pc/DSDT.roothp diff: @@ -5,20 +5,20 @@ * * Disassembling to symbolic ASL+ operators * - * Disassembly of tests/data/acpi/pc/DSDT.roothp, Mon Jan 18 23:59:02 2021 + * Disassembly of /tmp/aml-83PIX0, Mon Jan 18 23:59:02 2021 * * Original Table Header: * Signature "DSDT" * Length 0x0000148D (5261) * Revision 0x01 **** 32-bit table (V1), no 64-bit math support - * Checksum 0xC6 + * Checksum 0x75 * OEM ID "BOCHS " - * OEM Table ID "BXPCDSDT" + * OEM Table ID "BXPC " * OEM Revision 0x00000001 (1) * Compiler ID "BXPC" * Compiler Version 0x00000001 (1) */ -DefinitionBlock ("", "DSDT", 1, "BOCHS ", "BXPCDSDT", 0x00000001) +DefinitionBlock ("", "DSDT", 1, "BOCHS ", "BXPC ", 0x00000001) { Scope (\) { Table tests/data/acpi/pc/FACP.hpbridge diff: @@ -3,7 +3,7 @@ * AML/ASL+ Disassembler version 20200326 (64-bit version) * Copyright (c) 2000 - 2020 Intel Corporation * - * Disassembly of tests/data/acpi/pc/FACP, Mon Jan 18 23:59:02 2021 + * Disassembly of /tmp/aml-2ZSAX0, Mon Jan 18 23:59:02 2021 * * ACPI Data Table [FACP] * @@ -13,9 +13,9 @@ [000h 0000 4] Signature : "FACP" [Fixed ACPI Descr= iption Table (FADT)] [004h 0004 4] Table Length : 00000074 [008h 0008 1] Revision : 01 -[009h 0009 1] Checksum : A1 +[009h 0009 1] Checksum : 3B [00Ah 0010 6] Oem ID : "BOCHS " -[010h 0016 8] Oem Table ID : "BXPCFACP" +[010h 0016 8] Oem Table ID : "BXPC " [018h 0024 4] Oem Revision : 00000001 [01Ch 0028 4] Asl Compiler ID : "BXPC" [020h 0032 4] Asl Compiler Revision : 00000001 Table tests/data/acpi/pc/APIC.hpbridge diff: @@ -3,7 +3,7 @@ * AML/ASL+ Disassembler version 20200326 (64-bit version) * Copyright (c) 2000 - 2020 Intel Corporation * - * Disassembly of tests/data/acpi/pc/APIC, Mon Jan 18 23:59:02 2021 + * Disassembly of /tmp/aml-B0SAX0, Mon Jan 18 23:59:02 2021 * * ACPI Data Table [APIC] * @@ -13,9 +13,9 @@ [000h 0000 4] Signature : "APIC" [Multiple APIC De= scription Table (MADT)] [004h 0004 4] Table Length : 00000078 [008h 0008 1] Revision : 01 -[009h 0009 1] Checksum : ED +[009h 0009 1] Checksum : 8A [00Ah 0010 6] Oem ID : "BOCHS " -[010h 0016 8] Oem Table ID : "BXPCAPIC" +[010h 0016 8] Oem Table ID : "BXPC " [018h 0024 4] Oem Revision : 00000001 [01Ch 0028 4] Asl Compiler ID : "BXPC" [020h 0032 4] Asl Compiler Revision : 00000001 Table tests/data/acpi/pc/HPET.hpbridge diff: @@ -3,7 +3,7 @@ * AML/ASL+ Disassembler version 20200326 (64-bit version) * Copyright (c) 2000 - 2020 Intel Corporation * - * Disassembly of tests/data/acpi/pc/HPET, Mon Jan 18 23:59:02 2021 + * Disassembly of /tmp/aml-G2SAX0, Mon Jan 18 23:59:02 2021 * * ACPI Data Table [HPET] * @@ -13,9 +13,9 @@ [000h 0000 4] Signature : "HPET" [High Precision E= vent Timer table] [004h 0004 4] Table Length : 00000038 [008h 0008 1] Revision : 01 -[009h 0009 1] Checksum : 03 +[009h 0009 1] Checksum : B4 [00Ah 0010 6] Oem ID : "BOCHS " -[010h 0016 8] Oem Table ID : "BXPCHPET" +[010h 0016 8] Oem Table ID : "BXPC " [018h 0024 4] Oem Revision : 00000001 [01Ch 0028 4] Asl Compiler ID : "BXPC" [020h 0032 4] Asl Compiler Revision : 00000001 Table tests/data/acpi/pc/WAET.hpbridge diff: @@ -3,7 +3,7 @@ * AML/ASL+ Disassembler version 20200326 (64-bit version) * Copyright (c) 2000 - 2020 Intel Corporation * - * Disassembly of tests/data/acpi/pc/WAET, Mon Jan 18 23:59:02 2021 + * Disassembly of /tmp/aml-F2SAX0, Mon Jan 18 23:59:02 2021 * * ACPI Data Table [WAET] * @@ -13,9 +13,9 @@ [000h 0000 4] Signature : "WAET" [Windows ACPI Emu= lated Devices Table] [004h 0004 4] Table Length : 00000028 [008h 0008 1] Revision : 01 -[009h 0009 1] Checksum : 88 +[009h 0009 1] Checksum : 39 [00Ah 0010 6] Oem ID : "BOCHS " -[010h 0016 8] Oem Table ID : "BXPCWAET" +[010h 0016 8] Oem Table ID : "BXPC " [018h 0024 4] Oem Revision : 00000001 [01Ch 0028 4] Asl Compiler ID : "BXPC" [020h 0032 4] Asl Compiler Revision : 00000001 Table tests/data/acpi/pc/DSDT.hpbridge diff: @@ -5,20 +5,20 @@ * * Disassembling to symbolic ASL+ operators * - * Disassembly of tests/data/acpi/pc/DSDT.hpbridge, Mon Jan 18 23:59:02 20= 21 + * Disassembly of /tmp/aml-R2SAX0, Mon Jan 18 23:59:02 2021 * * Original Table Header: * Signature "DSDT" * Length 0x000013A2 (5026) * Revision 0x01 **** 32-bit table (V1), no 64-bit math support - * Checksum 0xD9 + * Checksum 0x88 * OEM ID "BOCHS " - * OEM Table ID "BXPCDSDT" + * OEM Table ID "BXPC " * OEM Revision 0x00000001 (1) * Compiler ID "BXPC" * Compiler Version 0x00000001 (1) */ -DefinitionBlock ("", "DSDT", 1, "BOCHS ", "BXPCDSDT", 0x00000001) +DefinitionBlock ("", "DSDT", 1, "BOCHS ", "BXPC ", 0x00000001) { Scope (\) { Table tests/data/acpi/pc/FACP.hpbrroot diff: @@ -3,7 +3,7 @@ * AML/ASL+ Disassembler version 20200326 (64-bit version) * Copyright (c) 2000 - 2020 Intel Corporation * - * Disassembly of tests/data/acpi/pc/FACP, Mon Jan 18 23:59:02 2021 + * Disassembly of /tmp/aml-D9COX0, Mon Jan 18 23:59:02 2021 * * ACPI Data Table [FACP] * @@ -13,9 +13,9 @@ [000h 0000 4] Signature : "FACP" [Fixed ACPI Descr= iption Table (FADT)] [004h 0004 4] Table Length : 00000074 [008h 0008 1] Revision : 01 -[009h 0009 1] Checksum : A1 +[009h 0009 1] Checksum : 3B [00Ah 0010 6] Oem ID : "BOCHS " -[010h 0016 8] Oem Table ID : "BXPCFACP" +[010h 0016 8] Oem Table ID : "BXPC " [018h 0024 4] Oem Revision : 00000001 [01Ch 0028 4] Asl Compiler ID : "BXPC" [020h 0032 4] Asl Compiler Revision : 00000001 Table tests/data/acpi/pc/APIC.hpbrroot diff: @@ -3,7 +3,7 @@ * AML/ASL+ Disassembler version 20200326 (64-bit version) * Copyright (c) 2000 - 2020 Intel Corporation * - * Disassembly of tests/data/acpi/pc/APIC, Mon Jan 18 23:59:02 2021 + * Disassembly of /tmp/aml-K9COX0, Mon Jan 18 23:59:02 2021 * * ACPI Data Table [APIC] * @@ -13,9 +13,9 @@ [000h 0000 4] Signature : "APIC" [Multiple APIC De= scription Table (MADT)] [004h 0004 4] Table Length : 00000078 [008h 0008 1] Revision : 01 -[009h 0009 1] Checksum : ED +[009h 0009 1] Checksum : 8A [00Ah 0010 6] Oem ID : "BOCHS " -[010h 0016 8] Oem Table ID : "BXPCAPIC" +[010h 0016 8] Oem Table ID : "BXPC " [018h 0024 4] Oem Revision : 00000001 [01Ch 0028 4] Asl Compiler ID : "BXPC" [020h 0032 4] Asl Compiler Revision : 00000001 Table tests/data/acpi/pc/HPET.hpbrroot diff: @@ -3,7 +3,7 @@ * AML/ASL+ Disassembler version 20200326 (64-bit version) * Copyright (c) 2000 - 2020 Intel Corporation * - * Disassembly of tests/data/acpi/pc/HPET, Mon Jan 18 23:59:02 2021 + * Disassembly of /tmp/aml-L4COX0, Mon Jan 18 23:59:02 2021 * * ACPI Data Table [HPET] * @@ -13,9 +13,9 @@ [000h 0000 4] Signature : "HPET" [High Precision E= vent Timer table] [004h 0004 4] Table Length : 00000038 [008h 0008 1] Revision : 01 -[009h 0009 1] Checksum : 03 +[009h 0009 1] Checksum : B4 [00Ah 0010 6] Oem ID : "BOCHS " -[010h 0016 8] Oem Table ID : "BXPCHPET" +[010h 0016 8] Oem Table ID : "BXPC " [018h 0024 4] Oem Revision : 00000001 [01Ch 0028 4] Asl Compiler ID : "BXPC" [020h 0032 4] Asl Compiler Revision : 00000001 Table tests/data/acpi/pc/WAET.hpbrroot diff: @@ -3,7 +3,7 @@ * AML/ASL+ Disassembler version 20200326 (64-bit version) * Copyright (c) 2000 - 2020 Intel Corporation * - * Disassembly of tests/data/acpi/pc/WAET, Mon Jan 18 23:59:02 2021 + * Disassembly of /tmp/aml-W4COX0, Mon Jan 18 23:59:02 2021 * * ACPI Data Table [WAET] * @@ -13,9 +13,9 @@ [000h 0000 4] Signature : "WAET" [Windows ACPI Emu= lated Devices Table] [004h 0004 4] Table Length : 00000028 [008h 0008 1] Revision : 01 -[009h 0009 1] Checksum : 88 +[009h 0009 1] Checksum : 39 [00Ah 0010 6] Oem ID : "BOCHS " -[010h 0016 8] Oem Table ID : "BXPCWAET" +[010h 0016 8] Oem Table ID : "BXPC " [018h 0024 4] Oem Revision : 00000001 [01Ch 0028 4] Asl Compiler ID : "BXPC" [020h 0032 4] Asl Compiler Revision : 00000001 Table tests/data/acpi/pc/DSDT.hpbrroot diff: @@ -5,20 +5,20 @@ * * Disassembling to symbolic ASL+ operators * - * Disassembly of tests/data/acpi/pc/DSDT.hpbrroot, Mon Jan 18 23:59:02 20= 21 + * Disassembly of /tmp/aml-S4COX0, Mon Jan 18 23:59:02 2021 * * Original Table Header: * Signature "DSDT" * Length 0x00000C0C (3084) * Revision 0x01 **** 32-bit table (V1), no 64-bit math support - * Checksum 0x81 + * Checksum 0x30 * OEM ID "BOCHS " - * OEM Table ID "BXPCDSDT" + * OEM Table ID "BXPC " * OEM Revision 0x00000001 (1) * Compiler ID "BXPC" * Compiler Version 0x00000001 (1) */ -DefinitionBlock ("", "DSDT", 1, "BOCHS ", "BXPCDSDT", 0x00000001) +DefinitionBlock ("", "DSDT", 1, "BOCHS ", "BXPC ", 0x00000001) { Scope (\) { Table tests/data/acpi/microvm/FACP.usb diff: @@ -3,7 +3,7 @@ * AML/ASL+ Disassembler version 20200326 (64-bit version) * Copyright (c) 2000 - 2020 Intel Corporation * - * Disassembly of tests/data/acpi/microvm/FACP, Mon Jan 18 23:59:03 2021 + * Disassembly of /tmp/aml-PZ3FX0, Mon Jan 18 23:59:03 2021 * * ACPI Data Table [FACP] * @@ -13,9 +13,9 @@ [000h 0000 4] Signature : "FACP" [Fixed ACPI Descr= iption Table (FADT)] [004h 0004 4] Table Length : 0000010C [008h 0008 1] Revision : 05 -[009h 0009 1] Checksum : 7E +[009h 0009 1] Checksum : 18 [00Ah 0010 6] Oem ID : "BOCHS " -[010h 0016 8] Oem Table ID : "BXPCFACP" +[010h 0016 8] Oem Table ID : "BXPC " [018h 0024 4] Oem Revision : 00000001 [01Ch 0028 4] Asl Compiler ID : "BXPC" [020h 0032 4] Asl Compiler Revision : 00000001 Table tests/data/acpi/microvm/APIC.usb diff: @@ -3,7 +3,7 @@ * AML/ASL+ Disassembler version 20200326 (64-bit version) * Copyright (c) 2000 - 2020 Intel Corporation * - * Disassembly of tests/data/acpi/microvm/APIC, Mon Jan 18 23:59:03 2021 + * Disassembly of /tmp/aml-ZZ3FX0, Mon Jan 18 23:59:03 2021 * * ACPI Data Table [APIC] * @@ -13,9 +13,9 @@ [000h 0000 4] Signature : "APIC" [Multiple APIC De= scription Table (MADT)] [004h 0004 4] Table Length : 00000046 [008h 0008 1] Revision : 01 -[009h 0009 1] Checksum : D7 +[009h 0009 1] Checksum : 74 [00Ah 0010 6] Oem ID : "BOCHS " -[010h 0016 8] Oem Table ID : "BXPCAPIC" +[010h 0016 8] Oem Table ID : "BXPC " [018h 0024 4] Oem Revision : 00000001 [01Ch 0028 4] Asl Compiler ID : "BXPC" [020h 0032 4] Asl Compiler Revision : 00000001 Table tests/data/acpi/microvm/DSDT.usb diff: @@ -5,20 +5,20 @@ * * Disassembling to symbolic ASL+ operators * - * Disassembly of tests/data/acpi/microvm/DSDT.usb, Mon Jan 18 23:59:03 20= 21 + * Disassembly of /tmp/aml-XZ3FX0, Mon Jan 18 23:59:03 2021 * * Original Table Header: * Signature "DSDT" * Length 0x0000019E (414) * Revision 0x02 - * Checksum 0x72 + * Checksum 0x21 * OEM ID "BOCHS " - * OEM Table ID "BXPCDSDT" + * OEM Table ID "BXPC " * OEM Revision 0x00000001 (1) * Compiler ID "BXPC" * Compiler Version 0x00000001 (1) */ -DefinitionBlock ("", "DSDT", 2, "BOCHS ", "BXPCDSDT", 0x00000001) +DefinitionBlock ("", "DSDT", 2, "BOCHS ", "BXPC ", 0x00000001) { Scope (_SB) { Table tests/data/acpi/microvm/FACP.rtc diff: @@ -3,7 +3,7 @@ * AML/ASL+ Disassembler version 20200326 (64-bit version) * Copyright (c) 2000 - 2020 Intel Corporation * - * Disassembly of tests/data/acpi/microvm/FACP, Mon Jan 18 23:59:03 2021 + * Disassembly of /tmp/aml-TX8BX0, Mon Jan 18 23:59:03 2021 * * ACPI Data Table [FACP] * @@ -13,9 +13,9 @@ [000h 0000 4] Signature : "FACP" [Fixed ACPI Descr= iption Table (FADT)] [004h 0004 4] Table Length : 0000010C [008h 0008 1] Revision : 05 -[009h 0009 1] Checksum : 7E +[009h 0009 1] Checksum : 18 [00Ah 0010 6] Oem ID : "BOCHS " -[010h 0016 8] Oem Table ID : "BXPCFACP" +[010h 0016 8] Oem Table ID : "BXPC " [018h 0024 4] Oem Revision : 00000001 [01Ch 0028 4] Asl Compiler ID : "BXPC" [020h 0032 4] Asl Compiler Revision : 00000001 Table tests/data/acpi/microvm/APIC.rtc diff: @@ -3,7 +3,7 @@ * AML/ASL+ Disassembler version 20200326 (64-bit version) * Copyright (c) 2000 - 2020 Intel Corporation * - * Disassembly of tests/data/acpi/microvm/APIC, Mon Jan 18 23:59:03 2021 + * Disassembly of /tmp/aml-QS8BX0, Mon Jan 18 23:59:03 2021 * * ACPI Data Table [APIC] * @@ -13,9 +13,9 @@ [000h 0000 4] Signature : "APIC" [Multiple APIC De= scription Table (MADT)] [004h 0004 4] Table Length : 00000046 [008h 0008 1] Revision : 01 -[009h 0009 1] Checksum : D7 +[009h 0009 1] Checksum : 74 [00Ah 0010 6] Oem ID : "BOCHS " -[010h 0016 8] Oem Table ID : "BXPCAPIC" +[010h 0016 8] Oem Table ID : "BXPC " [018h 0024 4] Oem Revision : 00000001 [01Ch 0028 4] Asl Compiler ID : "BXPC" [020h 0032 4] Asl Compiler Revision : 00000001 Table tests/data/acpi/microvm/DSDT.rtc diff: @@ -5,20 +5,20 @@ * * Disassembling to symbolic ASL+ operators * - * Disassembly of tests/data/acpi/microvm/DSDT.rtc, Mon Jan 18 23:59:03 20= 21 + * Disassembly of /tmp/aml-4S8BX0, Mon Jan 18 23:59:03 2021 * * Original Table Header: * Signature "DSDT" * Length 0x00000194 (404) * Revision 0x02 - * Checksum 0x30 + * Checksum 0xDF * OEM ID "BOCHS " - * OEM Table ID "BXPCDSDT" + * OEM Table ID "BXPC " * OEM Revision 0x00000001 (1) * Compiler ID "BXPC" * Compiler Version 0x00000001 (1) */ -DefinitionBlock ("", "DSDT", 2, "BOCHS ", "BXPCDSDT", 0x00000001) +DefinitionBlock ("", "DSDT", 2, "BOCHS ", "BXPC ", 0x00000001) { Scope (_SB) { Table tests/data/acpi/microvm/FACP.ioapic2 diff: @@ -3,7 +3,7 @@ * AML/ASL+ Disassembler version 20200326 (64-bit version) * Copyright (c) 2000 - 2020 Intel Corporation * - * Disassembly of tests/data/acpi/microvm/FACP, Mon Jan 18 23:59:03 2021 + * Disassembly of /tmp/aml-ZRMOX0, Mon Jan 18 23:59:03 2021 * * ACPI Data Table [FACP] * @@ -13,9 +13,9 @@ [000h 0000 4] Signature : "FACP" [Fixed ACPI Descr= iption Table (FADT)] [004h 0004 4] Table Length : 0000010C [008h 0008 1] Revision : 05 -[009h 0009 1] Checksum : 7E +[009h 0009 1] Checksum : 18 [00Ah 0010 6] Oem ID : "BOCHS " -[010h 0016 8] Oem Table ID : "BXPCFACP" +[010h 0016 8] Oem Table ID : "BXPC " [018h 0024 4] Oem Revision : 00000001 [01Ch 0028 4] Asl Compiler ID : "BXPC" [020h 0032 4] Asl Compiler Revision : 00000001 Table tests/data/acpi/microvm/APIC.ioapic2 diff: @@ -3,7 +3,7 @@ * AML/ASL+ Disassembler version 20200326 (64-bit version) * Copyright (c) 2000 - 2020 Intel Corporation * - * Disassembly of tests/data/acpi/microvm/APIC.ioapic2, Mon Jan 18 23:59:0= 3 2021 + * Disassembly of /tmp/aml-VMMOX0, Mon Jan 18 23:59:03 2021 * * ACPI Data Table [APIC] * @@ -13,9 +13,9 @@ [000h 0000 4] Signature : "APIC" [Multiple APIC De= scription Table (MADT)] [004h 0004 4] Table Length : 00000052 [008h 0008 1] Revision : 01 -[009h 0009 1] Checksum : E6 +[009h 0009 1] Checksum : 83 [00Ah 0010 6] Oem ID : "BOCHS " -[010h 0016 8] Oem Table ID : "BXPCAPIC" +[010h 0016 8] Oem Table ID : "BXPC " [018h 0024 4] Oem Revision : 00000001 [01Ch 0028 4] Asl Compiler ID : "BXPC" [020h 0032 4] Asl Compiler Revision : 00000001 Table tests/data/acpi/microvm/DSDT.ioapic2 diff: @@ -5,20 +5,20 @@ * * Disassembling to symbolic ASL+ operators * - * Disassembly of tests/data/acpi/microvm/DSDT.ioapic2, Mon Jan 18 23:59:0= 3 2021 + * Disassembly of /tmp/aml-TMMOX0, Mon Jan 18 23:59:03 2021 * * Original Table Header: * Signature "DSDT" * Length 0x0000016D (365) * Revision 0x02 - * Checksum 0x1C + * Checksum 0xCB * OEM ID "BOCHS " - * OEM Table ID "BXPCDSDT" + * OEM Table ID "BXPC " * OEM Revision 0x00000001 (1) * Compiler ID "BXPC" * Compiler Version 0x00000001 (1) */ -DefinitionBlock ("", "DSDT", 2, "BOCHS ", "BXPCDSDT", 0x00000001) +DefinitionBlock ("", "DSDT", 2, "BOCHS ", "BXPC ", 0x00000001) { Scope (_SB) { Table tests/data/acpi/microvm/FACP.pcie diff: @@ -3,7 +3,7 @@ * AML/ASL+ Disassembler version 20200326 (64-bit version) * Copyright (c) 2000 - 2020 Intel Corporation * - * Disassembly of tests/data/acpi/microvm/FACP, Tue Jan 19 00:03:13 2021 + * Disassembly of /tmp/aml-M6CGX0, Tue Jan 19 00:03:13 2021 * * ACPI Data Table [FACP] * @@ -13,9 +13,9 @@ [000h 0000 4] Signature : "FACP" [Fixed ACPI Descr= iption Table (FADT)] [004h 0004 4] Table Length : 0000010C [008h 0008 1] Revision : 05 -[009h 0009 1] Checksum : 7E +[009h 0009 1] Checksum : 18 [00Ah 0010 6] Oem ID : "BOCHS " -[010h 0016 8] Oem Table ID : "BXPCFACP" +[010h 0016 8] Oem Table ID : "BXPC " [018h 0024 4] Oem Revision : 00000001 [01Ch 0028 4] Asl Compiler ID : "BXPC" [020h 0032 4] Asl Compiler Revision : 00000001 Table tests/data/acpi/microvm/APIC.pcie diff: @@ -3,7 +3,7 @@ * AML/ASL+ Disassembler version 20200326 (64-bit version) * Copyright (c) 2000 - 2020 Intel Corporation * - * Disassembly of tests/data/acpi/microvm/APIC.pcie, Tue Jan 19 00:03:13 2= 021 + * Disassembly of /tmp/aml-V6CGX0, Tue Jan 19 00:03:13 2021 * * ACPI Data Table [APIC] * @@ -13,9 +13,9 @@ [000h 0000 4] Signature : "APIC" [Multiple APIC De= scription Table (MADT)] [004h 0004 4] Table Length : 0000006E [008h 0008 1] Revision : 01 -[009h 0009 1] Checksum : DF +[009h 0009 1] Checksum : 7C [00Ah 0010 6] Oem ID : "BOCHS " -[010h 0016 8] Oem Table ID : "BXPCAPIC" +[010h 0016 8] Oem Table ID : "BXPC " [018h 0024 4] Oem Revision : 00000001 [01Ch 0028 4] Asl Compiler ID : "BXPC" [020h 0032 4] Asl Compiler Revision : 00000001 Table tests/data/acpi/microvm/DSDT.pcie diff: @@ -5,20 +5,20 @@ * * Disassembling to symbolic ASL+ operators * - * Disassembly of tests/data/acpi/microvm/DSDT.pcie, Tue Jan 19 00:03:13 2= 021 + * Disassembly of /tmp/aml-16CGX0, Tue Jan 19 00:03:13 2021 * * Original Table Header: * Signature "DSDT" * Length 0x00000BD7 (3031) * Revision 0x02 - * Checksum 0x99 + * Checksum 0x48 * OEM ID "BOCHS " - * OEM Table ID "BXPCDSDT" + * OEM Table ID "BXPC " * OEM Revision 0x00000001 (1) * Compiler ID "BXPC" * Compiler Version 0x00000001 (1) */ -DefinitionBlock ("", "DSDT", 2, "BOCHS ", "BXPCDSDT", 0x00000001) +DefinitionBlock ("", "DSDT", 2, "BOCHS ", "BXPC ", 0x00000001) { Scope (_SB) { Signed-off-by: Marian Postevca Message-Id: <20210119003216.17637-4-posteuca@mutex.one> Reviewed-by: Michael S. Tsirkin Signed-off-by: Michael S. Tsirkin --- tests/qtest/bios-tables-test.c | 170 ++++++++++++++++++++++++++++----- 1 file changed, 146 insertions(+), 24 deletions(-) diff --git a/tests/qtest/bios-tables-test.c b/tests/qtest/bios-tables-test.c index 669202fc95..77053975aa 100644 --- a/tests/qtest/bios-tables-test.c +++ b/tests/qtest/bios-tables-test.c @@ -64,13 +64,17 @@ #include "boot-sector.h" #include "tpm-emu.h" #include "hw/acpi/tpm.h" - +#include "qemu/cutils.h" =20 #define MACHINE_PC "pc" #define MACHINE_Q35 "q35" =20 #define ACPI_REBUILD_EXPECTED_AML "TEST_ACPI_REBUILD_AML" =20 +#define OEM_ID "TEST" +#define OEM_TABLE_ID "OEM" +#define OEM_TEST_ARGS "-machine oem-id=3D"OEM_ID",oem-table-id=3D"OEM= _TABLE_ID + typedef struct { bool tcg_only; const char *machine; @@ -654,17 +658,28 @@ static void test_smbios_structs(test_data *data) } } =20 -static void test_acpi_one(const char *params, test_data *data) +static void test_acpi_load_tables(test_data *data, bool use_uefi) +{ + if (use_uefi) { + g_assert(data->scan_len); + data->rsdp_addr =3D acpi_find_rsdp_address_uefi(data->qts, + data->ram_start, data->scan_len); + } else { + boot_sector_test(data->qts); + data->rsdp_addr =3D acpi_find_rsdp_address(data->qts); + g_assert_cmphex(data->rsdp_addr, <, 0x100000); + } + + data->tables =3D g_array_new(false, true, sizeof(AcpiSdtTable)); + test_acpi_rsdp_table(data); + test_acpi_rxsdt_table(data); + test_acpi_fadt_table(data); +} + +static char *test_acpi_create_args(test_data *data, const char *params, + bool use_uefi) { char *args; - bool use_uefi =3D data->uefi_fl1 && data->uefi_fl2; - -#ifndef CONFIG_TCG - if (data->tcg_only) { - g_test_skip("TCG disabled, skipping ACPI tcg_only test"); - return; - } -#endif /* CONFIG_TCG */ =20 if (use_uefi) { /* @@ -695,23 +710,24 @@ static void test_acpi_one(const char *params, test_da= ta *data) params ? params : "", disk, data->blkdev ?: "ide-hd"); } + return args; +} =20 - data->qts =3D qtest_init(args); +static void test_acpi_one(const char *params, test_data *data) +{ + char *args; + bool use_uefi =3D data->uefi_fl1 && data->uefi_fl2; =20 - if (use_uefi) { - g_assert(data->scan_len); - data->rsdp_addr =3D acpi_find_rsdp_address_uefi(data->qts, - data->ram_start, data->scan_len); - } else { - boot_sector_test(data->qts); - data->rsdp_addr =3D acpi_find_rsdp_address(data->qts); - g_assert_cmphex(data->rsdp_addr, <, 0x100000); +#ifndef CONFIG_TCG + if (data->tcg_only) { + g_test_skip("TCG disabled, skipping ACPI tcg_only test"); + return; } +#endif /* CONFIG_TCG */ =20 - data->tables =3D g_array_new(false, true, sizeof(AcpiSdtTable)); - test_acpi_rsdp_table(data); - test_acpi_rxsdt_table(data); - test_acpi_fadt_table(data); + args =3D test_acpi_create_args(data, params, use_uefi); + data->qts =3D qtest_init(args); + test_acpi_load_tables(data, use_uefi); =20 if (getenv(ACPI_REBUILD_EXPECTED_AML)) { dump_aml_files(data, true); @@ -1292,6 +1308,109 @@ static void test_acpi_virt_tcg(void) free_test_data(&data); } =20 +static void test_oem_fields(test_data *data) +{ + int i; + char oem_id[6]; + char oem_table_id[8]; + + strpadcpy(oem_id, sizeof oem_id, OEM_ID, ' '); + strpadcpy(oem_table_id, sizeof oem_table_id, OEM_TABLE_ID, ' '); + for (i =3D 0; i < data->tables->len; ++i) { + AcpiSdtTable *sdt; + + sdt =3D &g_array_index(data->tables, AcpiSdtTable, i); + /* FACS doesn't have OEMID and OEMTABLEID fields */ + if (compare_signature(sdt, "FACS")) { + continue; + } + + g_assert(memcmp(sdt->aml + 10, oem_id, 6) =3D=3D 0); + g_assert(memcmp(sdt->aml + 16, oem_table_id, 8) =3D=3D 0); + } +} + +static void test_acpi_oem_fields_pc(void) +{ + test_data data; + char *args; + + memset(&data, 0, sizeof(data)); + data.machine =3D MACHINE_PC; + data.required_struct_types =3D base_required_struct_types; + data.required_struct_types_len =3D ARRAY_SIZE(base_required_struct_typ= es); + + args =3D test_acpi_create_args(&data, + OEM_TEST_ARGS, false); + data.qts =3D qtest_init(args); + test_acpi_load_tables(&data, false); + test_oem_fields(&data); + qtest_quit(data.qts); + free_test_data(&data); + g_free(args); +} + +static void test_acpi_oem_fields_q35(void) +{ + test_data data; + char *args; + + memset(&data, 0, sizeof(data)); + data.machine =3D MACHINE_Q35; + data.required_struct_types =3D base_required_struct_types; + data.required_struct_types_len =3D ARRAY_SIZE(base_required_struct_typ= es); + + args =3D test_acpi_create_args(&data, + OEM_TEST_ARGS, false); + data.qts =3D qtest_init(args); + test_acpi_load_tables(&data, false); + test_oem_fields(&data); + qtest_quit(data.qts); + free_test_data(&data); + g_free(args); +} + +static void test_acpi_oem_fields_microvm(void) +{ + test_data data; + char *args; + + test_acpi_microvm_prepare(&data); + + args =3D test_acpi_create_args(&data, + OEM_TEST_ARGS",acpi=3Don", false); + data.qts =3D qtest_init(args); + test_acpi_load_tables(&data, false); + test_oem_fields(&data); + qtest_quit(data.qts); + free_test_data(&data); + g_free(args); +} + +static void test_acpi_oem_fields_virt(void) +{ + test_data data =3D { + .machine =3D "virt", + .tcg_only =3D true, + .uefi_fl1 =3D "pc-bios/edk2-aarch64-code.fd", + .uefi_fl2 =3D "pc-bios/edk2-arm-vars.fd", + .cd =3D "tests/data/uefi-boot-images/bios-tables-test.aarch64.iso.= qcow2", + .ram_start =3D 0x40000000ULL, + .scan_len =3D 128ULL * 1024 * 1024, + }; + char *args; + + args =3D test_acpi_create_args(&data, + "-cpu cortex-a57 "OEM_TEST_ARGS, true); + data.qts =3D qtest_init(args); + test_acpi_load_tables(&data, true); + test_oem_fields(&data); + qtest_quit(data.qts); + free_test_data(&data); + g_free(args); +} + + int main(int argc, char *argv[]) { const char *arch =3D qtest_get_arch(); @@ -1304,9 +1423,10 @@ int main(int argc, char *argv[]) if (ret) { return ret; } - + qtest_add_func("acpi/q35/oem-fields", test_acpi_oem_fields_q35); qtest_add_func("acpi/q35/tpm-tis", test_acpi_q35_tcg_tpm_tis); qtest_add_func("acpi/piix4", test_acpi_piix4_tcg); + qtest_add_func("acpi/oem-fields", test_acpi_oem_fields_pc); qtest_add_func("acpi/piix4/bridge", test_acpi_piix4_tcg_bridge); qtest_add_func("acpi/piix4/pci-hotplug/no_root_hotplug", test_acpi_piix4_no_root_hotplug); @@ -1333,6 +1453,7 @@ int main(int argc, char *argv[]) qtest_add_func("acpi/microvm/usb", test_acpi_microvm_usb_tcg); qtest_add_func("acpi/microvm/rtc", test_acpi_microvm_rtc_tcg); qtest_add_func("acpi/microvm/ioapic2", test_acpi_microvm_ioapic2_t= cg); + qtest_add_func("acpi/microvm/oem-fields", test_acpi_oem_fields_mic= rovm); if (strcmp(arch, "x86_64") =3D=3D 0) { qtest_add_func("acpi/microvm/pcie", test_acpi_microvm_pcie_tcg= ); } @@ -1341,6 +1462,7 @@ int main(int argc, char *argv[]) qtest_add_func("acpi/virt/numamem", test_acpi_virt_tcg_numamem); qtest_add_func("acpi/virt/memhp", test_acpi_virt_tcg_memhp); qtest_add_func("acpi/virt/pxb", test_acpi_virt_tcg_pxb); + qtest_add_func("acpi/virt/oem-fields", test_acpi_oem_fields_virt); } ret =3D g_test_run(); boot_sector_cleanup(disk); --=20 MST From nobody Sun Feb 8 09:27:43 2026 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass(p=none dis=none) header.from=redhat.com ARC-Seal: i=1; a=rsa-sha256; t=1612539277; cv=none; d=zohomail.com; s=zohoarc; b=iLs3AycwDdZPyo88IYQ3NsZ/Chzd5JAcRe/gvdRRy/po+vuBWp8sur816Nd6ANzwLOe0u0y3KfAX/0QUSAjTzjfmMBDH0n8utG50iubXTFTmYQyguNcba05QPK995hLgukBkUg2Zts7Ove8RSoemUupsjPAu3cHYHBFHZl2qYAY= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1612539277; h=Content-Type:Cc:Date:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:To; bh=qB+vY2n1Jsacjv2d9REmyBdUtAmDy1Mx14TEPXAHQaA=; b=kmn8G+iG1t+rHxhrfXAEd5Vzleu+JXoYRYcdMuxAhYIyJTGzBzFguoh3uevq4Aqb0eOe7YL7Dz7q9HksCfC6c8SLapUC6ubGFmt7YPHb3HC4DR4NWy/VZRXCljX3lPe28ytVm9ZNCBqY9pPv58O1yxNNbXM3j3nu9DaxaFMKKko= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass header.from= (p=none dis=none) header.from= Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1612539277881241.8552612037721; Fri, 5 Feb 2021 07:34:37 -0800 (PST) Received: from localhost ([::1]:43078 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1l82qV-0001pN-Rd for importer@patchew.org; Fri, 05 Feb 2021 10:16:31 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]:48144) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1l82eu-0004eM-4f for qemu-devel@nongnu.org; Fri, 05 Feb 2021 10:04:33 -0500 Received: from us-smtp-delivery-124.mimecast.com ([63.128.21.124]:36105) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA1:256) (Exim 4.90_1) (envelope-from ) id 1l82el-00039t-1k for qemu-devel@nongnu.org; Fri, 05 Feb 2021 10:04:31 -0500 Received: from mail-ej1-f70.google.com (mail-ej1-f70.google.com [209.85.218.70]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-184-3Sg5lQL4MuGDRATQQojrjw-1; Fri, 05 Feb 2021 10:04:19 -0500 Received: by mail-ej1-f70.google.com with SMTP id by20so6843539ejc.1 for ; Fri, 05 Feb 2021 07:04:19 -0800 (PST) Received: from redhat.com (bzq-79-180-2-31.red.bezeqint.net. [79.180.2.31]) by smtp.gmail.com with ESMTPSA id o11sm4070446edt.96.2021.02.05.07.04.14 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 05 Feb 2021 07:04:15 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1612537461; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=qB+vY2n1Jsacjv2d9REmyBdUtAmDy1Mx14TEPXAHQaA=; b=ducp6R5ffmdnESUlNB53ayCvTCbjSWAgYZ0mwn731dhB6byCOg5zYEJHXQGUg75so/XOb0 0pwT7F+ovOLnrKxdjmzBjEMPAgMuW6gpMLYiK+Mb8ByC7HmcPI2TEMN/DlgDJSr8WDbyRi UkOjnRd2pIKoMyGAugWjAg/1LUWHah4= X-MC-Unique: 3Sg5lQL4MuGDRATQQojrjw-1 X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=qB+vY2n1Jsacjv2d9REmyBdUtAmDy1Mx14TEPXAHQaA=; b=qwg5sr3SNO6aCUZbT8pgblcqm5kFA4SomUrTpq5bmKMZPUUbxeGYzz041RUA0uiFPK TGyiZhepVAQrrzU2xih2qbCWtQqc7LC/oPC/fwyVXeeNVOEzgztK1CstXJgruElkAI+y zcApmMmtYwOhGTHLwQhqZMGeYGxxOU7H/Mk8SC53gRutz1JZWDT0iGz+zoFDKu/b4kPS UGFC7C13TqT3ZjHgQZNK/8xtnYdhtx+Fyjg60RWIYP+apL8bZhHGKRGYuTEDjV8ikzQ6 Cw0CZKiNaL7edSSPVRAw0Anrw22oco8QXBGVuUVDwS1kvjJcZ2Qq66mcB2k/esyVGwZD OBZg== X-Gm-Message-State: AOAM530T0n6TxrsiHDzmUL7qxA+jLoEOWRB6caZspsFVKsU8y6/DJZYh 8tiO+Ui9Xi5NCM3aEy44Vg7yuUi4dsY4eeKXkwpZ3G4Efx5wyAyc0zI92vx97hgeWQwf/F0bMjj SNdtUxXj7gjQbxrz1jf8Apc7/W5rhssabutRSJ3VZ1Qp+4qGNN8Aeq5x2wh2r X-Received: by 2002:a05:6402:1291:: with SMTP id w17mr3944757edv.112.1612537456994; Fri, 05 Feb 2021 07:04:16 -0800 (PST) X-Google-Smtp-Source: ABdhPJys6Tg5zr34YHnhu0LdDSG4QK4E9zz8oQzdmCHZhLAkS9dQn4CWoCf3CybNEgygxXCW2F0NWw== X-Received: by 2002:a05:6402:1291:: with SMTP id w17mr3944717edv.112.1612537456616; Fri, 05 Feb 2021 07:04:16 -0800 (PST) Date: Fri, 5 Feb 2021 10:04:13 -0500 From: "Michael S. Tsirkin" To: qemu-devel@nongnu.org Subject: [PULL v2 15/16] tests/acpi: update expected data files Message-ID: <20210205150135.94643-16-mst@redhat.com> References: <20210205150135.94643-1-mst@redhat.com> MIME-Version: 1.0 In-Reply-To: <20210205150135.94643-1-mst@redhat.com> X-Mailer: git-send-email 2.27.0.106.g8ac3dc51b1 X-Mutt-Fcc: =sent Authentication-Results: relay.mimecast.com; auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=mst@redhat.com X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Disposition: inline Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Received-SPF: pass client-ip=63.128.21.124; envelope-from=mst@redhat.com; helo=us-smtp-delivery-124.mimecast.com X-Spam_score_int: -30 X-Spam_score: -3.1 X-Spam_bar: --- X-Spam_report: (-3.1 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.352, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_LOW=-0.7, RCVD_IN_MSPIKE_H4=0.001, RCVD_IN_MSPIKE_WL=0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Peter Maydell , Marian Postevca Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: "Qemu-devel" X-ZohoMail-DKIM: pass (identity @redhat.com) Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" From: Marian Postevca Signed-off-by: Marian Postevca Message-Id: <20210119003216.17637-5-posteuca@mutex.one> Reviewed-by: Michael S. Tsirkin Signed-off-by: Michael S. Tsirkin --- tests/data/acpi/microvm/APIC | Bin 70 -> 70 bytes tests/data/acpi/microvm/APIC.ioapic2 | Bin 82 -> 82 bytes tests/data/acpi/microvm/APIC.pcie | Bin 110 -> 110 bytes tests/data/acpi/microvm/DSDT | Bin 365 -> 365 bytes tests/data/acpi/microvm/DSDT.ioapic2 | Bin 365 -> 365 bytes tests/data/acpi/microvm/DSDT.pcie | Bin 3031 -> 3031 bytes tests/data/acpi/microvm/DSDT.rtc | Bin 404 -> 404 bytes tests/data/acpi/microvm/DSDT.usb | Bin 414 -> 414 bytes tests/data/acpi/microvm/FACP | Bin 268 -> 268 bytes tests/data/acpi/pc/APIC | Bin 120 -> 120 bytes tests/data/acpi/pc/APIC.acpihmat | Bin 128 -> 128 bytes tests/data/acpi/pc/APIC.cphp | Bin 160 -> 160 bytes tests/data/acpi/pc/APIC.dimmpxm | Bin 144 -> 144 bytes tests/data/acpi/pc/DSDT | Bin 5065 -> 5065 bytes tests/data/acpi/pc/DSDT.acpihmat | Bin 6390 -> 6390 bytes tests/data/acpi/pc/DSDT.bridge | Bin 6924 -> 6924 bytes tests/data/acpi/pc/DSDT.cphp | Bin 5529 -> 5529 bytes tests/data/acpi/pc/DSDT.dimmpxm | Bin 6719 -> 6719 bytes tests/data/acpi/pc/DSDT.hpbridge | Bin 5026 -> 5026 bytes tests/data/acpi/pc/DSDT.hpbrroot | Bin 3084 -> 3084 bytes tests/data/acpi/pc/DSDT.ipmikcs | Bin 5137 -> 5137 bytes tests/data/acpi/pc/DSDT.memhp | Bin 6424 -> 6424 bytes tests/data/acpi/pc/DSDT.numamem | Bin 5071 -> 5071 bytes tests/data/acpi/pc/DSDT.roothp | Bin 5261 -> 5261 bytes tests/data/acpi/pc/FACP | Bin 116 -> 116 bytes tests/data/acpi/pc/HMAT.acpihmat | Bin 280 -> 280 bytes tests/data/acpi/pc/HPET | Bin 56 -> 56 bytes tests/data/acpi/pc/NFIT.dimmpxm | Bin 240 -> 240 bytes tests/data/acpi/pc/SLIT.cphp | Bin 48 -> 48 bytes tests/data/acpi/pc/SLIT.memhp | Bin 48 -> 48 bytes tests/data/acpi/pc/SRAT.acpihmat | Bin 280 -> 280 bytes tests/data/acpi/pc/SRAT.cphp | Bin 304 -> 304 bytes tests/data/acpi/pc/SRAT.dimmpxm | Bin 392 -> 392 bytes tests/data/acpi/pc/SRAT.memhp | Bin 264 -> 264 bytes tests/data/acpi/pc/SRAT.numamem | Bin 224 -> 224 bytes tests/data/acpi/pc/SSDT.dimmpxm | Bin 734 -> 734 bytes tests/data/acpi/pc/WAET | Bin 40 -> 40 bytes tests/data/acpi/q35/APIC | Bin 120 -> 120 bytes tests/data/acpi/q35/APIC.acpihmat | Bin 128 -> 128 bytes tests/data/acpi/q35/APIC.cphp | Bin 160 -> 160 bytes tests/data/acpi/q35/APIC.dimmpxm | Bin 144 -> 144 bytes tests/data/acpi/q35/DSDT | Bin 7801 -> 7801 bytes tests/data/acpi/q35/DSDT.acpihmat | Bin 9126 -> 9126 bytes tests/data/acpi/q35/DSDT.bridge | Bin 7819 -> 7819 bytes tests/data/acpi/q35/DSDT.cphp | Bin 8265 -> 8265 bytes tests/data/acpi/q35/DSDT.dimmpxm | Bin 9455 -> 9455 bytes tests/data/acpi/q35/DSDT.ipmibt | Bin 7876 -> 7876 bytes tests/data/acpi/q35/DSDT.memhp | Bin 9160 -> 9160 bytes tests/data/acpi/q35/DSDT.mmio64 | Bin 8932 -> 8932 bytes tests/data/acpi/q35/DSDT.numamem | Bin 7807 -> 7807 bytes tests/data/acpi/q35/DSDT.tis | Bin 8407 -> 8407 bytes tests/data/acpi/q35/FACP | Bin 244 -> 244 bytes tests/data/acpi/q35/HMAT.acpihmat | Bin 280 -> 280 bytes tests/data/acpi/q35/HPET | Bin 56 -> 56 bytes tests/data/acpi/q35/MCFG | Bin 60 -> 60 bytes tests/data/acpi/q35/NFIT.dimmpxm | Bin 240 -> 240 bytes tests/data/acpi/q35/SLIT.cphp | Bin 48 -> 48 bytes tests/data/acpi/q35/SLIT.memhp | Bin 48 -> 48 bytes tests/data/acpi/q35/SRAT.acpihmat | Bin 280 -> 280 bytes tests/data/acpi/q35/SRAT.cphp | Bin 304 -> 304 bytes tests/data/acpi/q35/SRAT.dimmpxm | Bin 392 -> 392 bytes tests/data/acpi/q35/SRAT.memhp | Bin 264 -> 264 bytes tests/data/acpi/q35/SRAT.mmio64 | Bin 224 -> 224 bytes tests/data/acpi/q35/SRAT.numamem | Bin 224 -> 224 bytes tests/data/acpi/q35/SSDT.dimmpxm | Bin 734 -> 734 bytes tests/data/acpi/q35/TPM2.tis | Bin 76 -> 76 bytes tests/data/acpi/q35/WAET | Bin 40 -> 40 bytes tests/data/acpi/virt/APIC | Bin 168 -> 168 bytes tests/data/acpi/virt/APIC.memhp | Bin 168 -> 168 bytes tests/data/acpi/virt/APIC.numamem | Bin 168 -> 168 bytes tests/data/acpi/virt/DSDT | Bin 5204 -> 5204 bytes tests/data/acpi/virt/DSDT.memhp | Bin 6565 -> 6565 bytes tests/data/acpi/virt/DSDT.numamem | Bin 5204 -> 5204 bytes tests/data/acpi/virt/DSDT.pxb | Bin 7689 -> 7689 bytes tests/data/acpi/virt/FACP | Bin 268 -> 268 bytes tests/data/acpi/virt/FACP.memhp | Bin 268 -> 268 bytes tests/data/acpi/virt/FACP.numamem | Bin 268 -> 268 bytes tests/data/acpi/virt/GTDT | Bin 96 -> 96 bytes tests/data/acpi/virt/GTDT.memhp | Bin 96 -> 96 bytes tests/data/acpi/virt/GTDT.numamem | Bin 96 -> 96 bytes tests/data/acpi/virt/MCFG | Bin 60 -> 60 bytes tests/data/acpi/virt/MCFG.memhp | Bin 60 -> 60 bytes tests/data/acpi/virt/MCFG.numamem | Bin 60 -> 60 bytes tests/data/acpi/virt/NFIT.memhp | Bin 224 -> 224 bytes tests/data/acpi/virt/SLIT.memhp | Bin 48 -> 48 bytes tests/data/acpi/virt/SPCR | Bin 80 -> 80 bytes tests/data/acpi/virt/SPCR.memhp | Bin 80 -> 80 bytes tests/data/acpi/virt/SPCR.numamem | Bin 80 -> 80 bytes tests/data/acpi/virt/SRAT.memhp | Bin 226 -> 226 bytes tests/data/acpi/virt/SRAT.numamem | Bin 106 -> 106 bytes tests/data/acpi/virt/SSDT.memhp | Bin 736 -> 736 bytes 91 files changed, 0 insertions(+), 0 deletions(-) diff --git a/tests/data/acpi/microvm/APIC b/tests/data/acpi/microvm/APIC index 7472c7e830b6c7139720e93dd544d4441556661d..68dbd44a7e35a356083f086df60= f70e424c4249f 100644 GIT binary patch delta 30 jcmZ>BlW+|1barE4U|=3Dk9@^|(KR&a_4a8>|BlW+|1barE4U|_uN||9mu-vq!LkQ$&EX0uXGJ2xSBSqcI4) delta 33 mcmaFM^p;7&CDNNl4-4I=3D=3DG1qf~c diff --git a/tests/data/acpi/microvm/DSDT.usb b/tests/data/acpi/microvm/DSD= T.usb index 14423381ea235ed42f6f0f7d98e793c271a4e7c1..d63fd84620a2689120b32262f96= 4e6a098d71632 100644 GIT binary patch delta 33 ncmbQoJdatzCDNNl4-8zTUcZwS}` diff --git a/tests/data/acpi/microvm/FACP b/tests/data/acpi/microvm/FACP index 0ba5795d622349e1521138e4123544637b4ab9af..f12cef5cb6461118d4f6c847bad= 5c173613443c6 100644 GIT binary patch delta 32 lcmeBS>S2;_b94^iVPs%nm2mQR_6SyRiU@F40D_4UUjS?i2T}k4 delta 32 lcmeBS>S2;_b94^iVPs%nt#k5s_6SyRiU@E9iA|LF0swY)2vPt5 diff --git a/tests/data/acpi/pc/APIC b/tests/data/acpi/pc/APIC index 84509e0ae4cabeb5ead3e42a4edfa50abddbc17d..208331db53b7dd5c6205cce0e95= 427636b86dd64 100644 GIT binary patch delta 30 jcmb=3DZkZ=3Ds}bgp1vU|{TW@^|(KR&a_4a8>|=3DCTs6cOMI5}PQI0RV%>2z>wm diff --git a/tests/data/acpi/pc/APIC.cphp b/tests/data/acpi/pc/APIC.cphp index 1bf8a0a63bc1c9b716d937b96eb34b05016b9366..65cc4f4a9aa2676140a6525cdac= 1e838274b1e07 100644 GIT binary patch delta 32 mcmZ3$xPVc@F~HM#0RsaAqlA;cvq!LkQ$&EX0uW4;=3Dl}qHf(M=3De delta 32 lcmZ3$xPVc@F~HM#0RsaAW3`jNvq!LkQ$&C>NNl1+2LOlI2%Z1{ diff --git a/tests/data/acpi/pc/APIC.dimmpxm b/tests/data/acpi/pc/APIC.dimm= pxm index 427bb08248e6a029c1c988f74f5e48f93ee4ebe0..d904d4a70ddecbb79a83a267af8= e26f925e9f4c6 100644 GIT binary patch delta 32 mcmbQhIDt{ZF~HM#0s{jBqqmd4vq!LkQ$&EX0uW4;r~m+axCfB{ delta 32 lcmbQhIDt{ZF~HM#0s{jB<2omQXOCb7r-%S&kk~|t3IK)<2$28) diff --git a/tests/data/acpi/pc/DSDT b/tests/data/acpi/pc/DSDT index f6173df1d598767a79aa34ad7585ad7d45c5d4f3..11ef89bd322271ee30f3971b880= dadfda565d413 100644 GIT binary patch delta 33 ncmX@9eo|e+CDmqra2Cvq!LkQ$&EX0uXGJ*eDDDq~{48 delta 33 mcmX@9eo|e+CDm;{qptXOCb7r-%S&kl03vjlux0O9~wT diff --git a/tests/data/acpi/pc/DSDT.acpihmat b/tests/data/acpi/pc/DSDT.acp= ihmat index 67f3f7249eaaa9404ebf0f2d0a324b8c8e3bd445..c561e91be79f80dbea1cf4eb0f8= 658541a3aab2f 100644 GIT binary patch delta 33 ncmexn_{~tlCDNNl6TJqZB42nwtK diff --git a/tests/data/acpi/pc/DSDT.bridge b/tests/data/acpi/pc/DSDT.bridge index 643390f4c4138b37fc481656d3f555d0eeedcb02..a234075518fa8e187349d64c313= 779cc25db8299 100644 GIT binary patch delta 33 ncmeA%>oJpX33dtLk!E0EobKfB>=3DCTs6cOO800bK)zDNN8jxGqE delta 33 mcmeA%>oJpX33dtLk!E0EeBtEp>=3DCTs6cOMI65A;8MG63zk_nyw diff --git a/tests/data/acpi/pc/DSDT.cphp b/tests/data/acpi/pc/DSDT.cphp index 1ddcf7d8812f5d8d4d38fe7e7b35fd5885806046..6ac47a7d1001c711b957f8e28ca= b1a143d2cf65f 100644 GIT binary patch delta 33 ncmbQKJyTo4CDNNl4-qbLBA{|LNNl5ox)cDYObKcL diff --git a/tests/data/acpi/pc/DSDT.hpbridge b/tests/data/acpi/pc/DSDT.hpb= ridge index 4ecf1eb13bf49499f729b53a6d0114672a76e28d..9dfac45eab12b680bc963d05285= 53a7149a378cc 100644 GIT binary patch delta 33 ncmZ3azDQldCD_6SyRiU@E9iEWhl!VLh3K?vOd diff --git a/tests/data/acpi/pc/DSDT.ipmikcs b/tests/data/acpi/pc/DSDT.ipmi= kcs index f1638c5d079a9442c09390426a913010df6efd8d..1814f291b704d737d3578b83fbc= c6e090384943a 100644 GIT binary patch delta 33 ncmbQJF;PRpCD3CD3CDNNk~mBmj!52wVUF diff --git a/tests/data/acpi/pc/DSDT.numamem b/tests/data/acpi/pc/DSDT.numa= mem index 40cfd933259af05ac2aee07fca32f22122255211..195f8da900c5fc56c504adfef75= 6af8f74f5823d 100644 GIT binary patch delta 33 ncmX@FeqLR|CDNNl6Tc3}Xk1qt5( diff --git a/tests/data/acpi/pc/DSDT.roothp b/tests/data/acpi/pc/DSDT.roothp index 078fc8031b479cc77b6527a2b7b4bd576b6e6028..1d0a2c2f3cc4bfac75948d2ed6a= 69403cd18379b 100644 GIT binary patch delta 33 mcmeCx?A4TT33dtT6=3D7gtEOqjC_6SyRiU@F40D_GYr6K^6H3(S% delta 33 mcmeCx?A4TT33dtT6=3D7gtJm%!@>=3DCTs6cOMI65A+IDgpqVnF(0{ diff --git a/tests/data/acpi/pc/FACP b/tests/data/acpi/pc/FACP index 261ebdc5d1c3bdf18fb7935314a04fd7f6f92a7a..5fe21a5967aaaa2e72bf213d91f= 57a573cd4d38f 100644 GIT binary patch delta 30 jcmXRZk#KW#4k%$@U|_U%@^|(KR&a_4a8>|NNk}5BLICu2g(2d diff --git a/tests/data/acpi/pc/HPET b/tests/data/acpi/pc/HPET index df689b8f99c1c43cfd7d63bdede3bcdfd23b7de1..19f704abdd3909a0983232ee7b9= 3318811f71b19 100644 GIT binary patch literal 56 xcmeYWa1F6wU|?X};^gn_5v<@85#X!<1dKp25F11@E^2E4Qb2IwAB1LL002JR3IPBB literal 56 xcmeYWa1F6wU|?WmcJg=3Dj2v%^42ypfQiZKGkKx`1rxTviGNCClxe-N610RT2D3IPBB diff --git a/tests/data/acpi/pc/NFIT.dimmpxm b/tests/data/acpi/pc/NFIT.dimm= pxm index 598d331b751cd3cb2137d431c1f34bb8957a0d31..02d23385bcb767c5c060061caaf= ea7fdb4dc31fb 100644 GIT binary patch delta 32 mcmeys_<>Qv&&@OB0|NsC<5eerXOCb7r-%S&1t6FxaRUISp9!x3 delta 32 lcmeys_<>Qv&&@OB0|NsCql%Nivq!LkQ$&C>NNl3S4FI0-39kSE diff --git a/tests/data/acpi/pc/SLIT.cphp b/tests/data/acpi/pc/SLIT.cphp index 74ec3b4b461ffecca36d8537975c202a5f011185..67f00813af7b2356fe74eed943a= b8dcf2291578b 100644 GIT binary patch literal 48 scmWIc@eDCwU|?W;;pFe^5v<@85#X!<1dKp25F11@0Wk=3D0iHdRo0OYg>0RR91 literal 48 scmWIc@eDCwU|?X>aq@Te2v%^42yhMtiZKGkKx`1r1jHb~B`V4V0NaKK0RR91 diff --git a/tests/data/acpi/pc/SLIT.memhp b/tests/data/acpi/pc/SLIT.memhp index 74ec3b4b461ffecca36d8537975c202a5f011185..67f00813af7b2356fe74eed943a= b8dcf2291578b 100644 GIT binary patch literal 48 scmWIc@eDCwU|?W;;pFe^5v<@85#X!<1dKp25F11@0Wk=3D0iHdRo0OYg>0RR91 literal 48 scmWIc@eDCwU|?X>aq@Te2v%^42yhMtiZKGkKx`1r1jHb~B`V4V0NaKK0RR91 diff --git a/tests/data/acpi/pc/SRAT.acpihmat b/tests/data/acpi/pc/SRAT.acp= ihmat index 1dcae90aec688e88f9d212e632faaaaf2e0dc7bc..e0b36e97f69f9726ae03182bdbb= cf06d654f43a8 100644 GIT binary patch delta 32 mcmbQiG=3DoVZILI+Xf{}rNvC7Hc*&|rNDI&mG0SFdKFaiL1BL@)x delta 32 lcmbQiG=3DoVZILI+Xf{}rN@qm-Rvq!LkQ$&C>NNk}5BLIRG2oV4P diff --git a/tests/data/acpi/pc/SRAT.cphp b/tests/data/acpi/pc/SRAT.cphp index ff2137642f488ec70b85207ed6c20e7351d61e98..d8ce4f5a9c3ea4cb8e74abc6ea9= b8078e6291c2e 100644 GIT binary patch delta 33 ncmdnMw1G(?ILI-?fRTZL@q?4Uvq!LkQ$&EX0uXGJkYEG=3Dk);Rs delta 33 mcmdnMw1G(?ILI-?fRTZL(ag!;*&|rNDI&lbB(_mPf)N0Smk0L% diff --git a/tests/data/acpi/pc/SRAT.dimmpxm b/tests/data/acpi/pc/SRAT.dimm= pxm index 5a13c61b9041c6045c29643bf93a111fb1c0c76a..7eed48cf2dd1f562e163e1982ce= ad651ee208dfb 100644 GIT binary patch delta 33 mcmeBR?qHS(4ss0XU}RumRC4ln_6SyRiU@F40D_GY1&jcJi3f`S delta 33 mcmeBR?qHS(4ss0XU}Rum%y9B|_6SyRiU@E9iEWf9U<3e*dkBjF diff --git a/tests/data/acpi/pc/SRAT.memhp b/tests/data/acpi/pc/SRAT.memhp index e508b4ae3cd9e3000209a4f9597913faa4206ec1..a5b5f9adef5bfb4c461ef69d47a= 14f77bba12fe7 100644 GIT binary patch delta 32 lcmeBR>R^%x4ss0PU}RumjB)aJ_6SyRiU@F40D_4U9{_T82ciG~ delta 32 lcmeBR>R^%x4ss0PU}RumT;$~M>=3DCTs6cOMI5}PRT0RVew2%-Q0 diff --git a/tests/data/acpi/pc/SRAT.numamem b/tests/data/acpi/pc/SRAT.numa= mem index 119922f4973f621602047d1dc160519f810922a3..56da58e2699cb13fcd41b5e1667= ceeddbdd443b5 100644 GIT binary patch delta 32 mcmaFB_<&I&ILI;N0RsaA<9a85XOCb7r-%S&1t6FxaRLCKiV0Ex delta 32 lcmaFB_<&I&ILI;N0RsaA<5wqtXOCb7r-%S&kk~|t69B1v3Q_<7 diff --git a/tests/data/acpi/pc/SSDT.dimmpxm b/tests/data/acpi/pc/SSDT.dimm= pxm index ac55387d57e48adb99eb738a102308688a262fb8..a50a961fa1d9b0dd8ea4096d652= c83bcf04db20b 100644 GIT binary patch delta 33 ocmcb|dXH5iIM^lR9uortqnMMwvq!LkUzm%hudjl_Mu}rg0HV1GKL7v# delta 33 ocmcb|dXH5iIM^lR9uortW0;e_vq!LkUzm%huP+0`Mu}rg0HzrUKL7v# diff --git a/tests/data/acpi/pc/WAET b/tests/data/acpi/pc/WAET index c2240f58dff6b2f765386b5a2e506fda4800be3e..ac0db59183096ea1d93832a4210= 15385ba93aba0 100644 GIT binary patch literal 40 mcmWG{bPds9U|?Xhbn|=3DCTs6cOMI5}PQI0RV%>2z>wm diff --git a/tests/data/acpi/q35/APIC.cphp b/tests/data/acpi/q35/APIC.cphp index 1bf8a0a63bc1c9b716d937b96eb34b05016b9366..65cc4f4a9aa2676140a6525cdac= 1e838274b1e07 100644 GIT binary patch delta 32 mcmZ3$xPVc@F~HM#0RsaAqlA;cvq!LkQ$&EX0uW4;=3Dl}qHf(M=3De delta 32 lcmZ3$xPVc@F~HM#0RsaAW3`jNvq!LkQ$&C>NNl1+2LOlI2%Z1{ diff --git a/tests/data/acpi/q35/APIC.dimmpxm b/tests/data/acpi/q35/APIC.di= mmpxm index 427bb08248e6a029c1c988f74f5e48f93ee4ebe0..d904d4a70ddecbb79a83a267af8= e26f925e9f4c6 100644 GIT binary patch delta 32 mcmbQhIDt{ZF~HM#0s{jBqqmd4vq!LkQ$&EX0uW4;r~m+axCfB{ delta 32 lcmbQhIDt{ZF~HM#0s{jB<2omQXOCb7r-%S&kk~|t3IK)<2$28) diff --git a/tests/data/acpi/q35/DSDT b/tests/data/acpi/q35/DSDT index d25cd7072932886d6967f4023faac1e1fa6e836c..008a3d7d0fd64224b0880412c00= 77e28e930fa5a 100644 GIT binary patch delta 33 ncmexq^V3GcCDNNl4-q8tFfs|s@f diff --git a/tests/data/acpi/q35/DSDT.acpihmat b/tests/data/acpi/q35/DSDT.a= cpihmat index 722e06af83abcde203a2b96a8ec81fd3bab9fc98..2723b690089c9e75869708cb92d= 3081b6bb5ec65 100644 GIT binary patch delta 33 ncmZ4HzRX?1CDUkM`s diff --git a/tests/data/acpi/q35/DSDT.dimmpxm b/tests/data/acpi/q35/DSDT.di= mmpxm index bd8f8305b028ef20f9b6d1a0c69ac428d027e3d1..7c3526d9670305e41020e5d95a3= d0e9897b1e6d3 100644 GIT binary patch delta 33 ncmaFw`QB5)CDNNl6Tbrk@;Z3>|P diff --git a/tests/data/acpi/q35/DSDT.ipmibt b/tests/data/acpi/q35/DSDT.ipm= ibt index a8f868e23c25688ab1c0371016c071f23e9d732f..8d3ccc3e75164c2884fbe216591= 00e12fc70ae38 100644 GIT binary patch delta 33 ncmX?Nd&E}4CDNNl6T8aV)~BMH?2 diff --git a/tests/data/acpi/q35/DSDT.memhp b/tests/data/acpi/q35/DSDT.memhp index 9a802e4c67022386442976d5cb997ea3fc57b58f..f1c545d94b856fa8d19b8433233= d80397cb05714 100644 GIT binary patch delta 33 ncmX@%e!^YCCDlD+ delta 33 mcmexw^WR3oCDNNl4-x*PzzWePO_ diff --git a/tests/data/acpi/q35/DSDT.tis b/tests/data/acpi/q35/DSDT.tis index 30da3ec27958881801dacc954a343321ba26a2ae..b8e380340209a38163ef6ca2f6f= 9dfaf458ab08d 100644 GIT binary patch delta 33 ncmccac->LLCDLLCDNNl3S9RQs`361~& diff --git a/tests/data/acpi/q35/HMAT.acpihmat b/tests/data/acpi/q35/HMAT.a= cpihmat index c00f7ba6cd0acecbc4b158f430d29b2f32988522..a9d8e5cd47d7c0eb8c88c26f26f= e52a493188ea9 100644 GIT binary patch delta 32 mcmbQiG=3DoXP!`CrHf{}rN$;rvz*&|rNDI&mG0SFdKFaiK`n+D1N delta 32 lcmbQiG=3DoXP!`CrHf{}rNX@--(vq!LkQ$&C>NNk}5BLICu2g(2d diff --git a/tests/data/acpi/q35/HPET b/tests/data/acpi/q35/HPET index df689b8f99c1c43cfd7d63bdede3bcdfd23b7de1..19f704abdd3909a0983232ee7b9= 3318811f71b19 100644 GIT binary patch literal 56 xcmeYWa1F6wU|?X};^gn_5v<@85#X!<1dKp25F11@E^2E4Qb2IwAB1LL002JR3IPBB literal 56 xcmeYWa1F6wU|?WmcJg=3Dj2v%^42ypfQiZKGkKx`1rxTviGNCClxe-N610RT2D3IPBB diff --git a/tests/data/acpi/q35/MCFG b/tests/data/acpi/q35/MCFG index 79ceb27a038c6e29d098b98dda2e229495f96b7c..696bc969f2cd51f2e243090c9af= f8619651b2dc1 100644 GIT binary patch literal 60 rcmeZuc5}C3U|?YEaq@Te2v%^42yj*a0!E-1hz+8Vzy>J$KZphZEJX+b literal 60 rcmeZuc5}C3U|?W;@8s|75v<@85#a0#6k`O6f!H7#32cC}|AS}%SE304 diff --git a/tests/data/acpi/q35/NFIT.dimmpxm b/tests/data/acpi/q35/NFIT.di= mmpxm index 598d331b751cd3cb2137d431c1f34bb8957a0d31..02d23385bcb767c5c060061caaf= ea7fdb4dc31fb 100644 GIT binary patch delta 32 mcmeys_<>Qv&&@OB0|NsC<5eerXOCb7r-%S&1t6FxaRUISp9!x3 delta 32 lcmeys_<>Qv&&@OB0|NsCql%Nivq!LkQ$&C>NNl3S4FI0-39kSE diff --git a/tests/data/acpi/q35/SLIT.cphp b/tests/data/acpi/q35/SLIT.cphp index 74ec3b4b461ffecca36d8537975c202a5f011185..67f00813af7b2356fe74eed943a= b8dcf2291578b 100644 GIT binary patch literal 48 scmWIc@eDCwU|?W;;pFe^5v<@85#X!<1dKp25F11@0Wk=3D0iHdRo0OYg>0RR91 literal 48 scmWIc@eDCwU|?X>aq@Te2v%^42yhMtiZKGkKx`1r1jHb~B`V4V0NaKK0RR91 diff --git a/tests/data/acpi/q35/SLIT.memhp b/tests/data/acpi/q35/SLIT.memhp index 74ec3b4b461ffecca36d8537975c202a5f011185..67f00813af7b2356fe74eed943a= b8dcf2291578b 100644 GIT binary patch literal 48 scmWIc@eDCwU|?W;;pFe^5v<@85#X!<1dKp25F11@0Wk=3D0iHdRo0OYg>0RR91 literal 48 scmWIc@eDCwU|?X>aq@Te2v%^42yhMtiZKGkKx`1r1jHb~B`V4V0NaKK0RR91 diff --git a/tests/data/acpi/q35/SRAT.acpihmat b/tests/data/acpi/q35/SRAT.a= cpihmat index 1dcae90aec688e88f9d212e632faaaaf2e0dc7bc..e0b36e97f69f9726ae03182bdbb= cf06d654f43a8 100644 GIT binary patch delta 32 mcmbQiG=3DoVZILI+Xf{}rNvC7Hc*&|rNDI&mG0SFdKFaiL1BL@)x delta 32 lcmbQiG=3DoVZILI+Xf{}rN@qm-Rvq!LkQ$&C>NNk}5BLIRG2oV4P diff --git a/tests/data/acpi/q35/SRAT.cphp b/tests/data/acpi/q35/SRAT.cphp index ff2137642f488ec70b85207ed6c20e7351d61e98..d8ce4f5a9c3ea4cb8e74abc6ea9= b8078e6291c2e 100644 GIT binary patch delta 33 ncmdnMw1G(?ILI-?fRTZL@q?4Uvq!LkQ$&EX0uXGJkYEG=3Dk);Rs delta 33 mcmdnMw1G(?ILI-?fRTZL(ag!;*&|rNDI&lbB(_mPf)N0Smk0L% diff --git a/tests/data/acpi/q35/SRAT.dimmpxm b/tests/data/acpi/q35/SRAT.di= mmpxm index 5a13c61b9041c6045c29643bf93a111fb1c0c76a..7eed48cf2dd1f562e163e1982ce= ad651ee208dfb 100644 GIT binary patch delta 33 mcmeBR?qHS(4ss0XU}RumRC4ln_6SyRiU@F40D_GY1&jcJi3f`S delta 33 mcmeBR?qHS(4ss0XU}Rum%y9B|_6SyRiU@E9iEWf9U<3e*dkBjF diff --git a/tests/data/acpi/q35/SRAT.memhp b/tests/data/acpi/q35/SRAT.memhp index e508b4ae3cd9e3000209a4f9597913faa4206ec1..a5b5f9adef5bfb4c461ef69d47a= 14f77bba12fe7 100644 GIT binary patch delta 32 lcmeBR>R^%x4ss0PU}RumjB)aJ_6SyRiU@F40D_4U9{_T82ciG~ delta 32 lcmeBR>R^%x4ss0PU}RumT;$~M>=3DCTs6cOMI5}PRT0RVew2%-Q0 diff --git a/tests/data/acpi/q35/SRAT.mmio64 b/tests/data/acpi/q35/SRAT.mmi= o64 index ac35f3dac4f47b86e41c7f35ee40bac14174b37e..f5e1e3932a8e2e61c6cd691e7d0= 7ed72046e7ce8 100644 GIT binary patch delta 32 mcmaFB_<&I&ILI;N0RsaA<5wqtXOCb7r-%S&1t6FxaRLCPb_tjO delta 32 lcmaFB_<&I&ILI;N0RsaAqqUR2vq!LkQ$&C>NNl3S2>_gE377x? diff --git a/tests/data/acpi/q35/SRAT.numamem b/tests/data/acpi/q35/SRAT.nu= mamem index 119922f4973f621602047d1dc160519f810922a3..56da58e2699cb13fcd41b5e1667= ceeddbdd443b5 100644 GIT binary patch delta 32 mcmaFB_<&I&ILI;N0RsaA<9a85XOCb7r-%S&1t6FxaRLCKiV0Ex delta 32 lcmaFB_<&I&ILI;N0RsaA<5wqtXOCb7r-%S&kk~|t69B1v3Q_<7 diff --git a/tests/data/acpi/q35/SSDT.dimmpxm b/tests/data/acpi/q35/SSDT.di= mmpxm index 98e6f0e3f3bb02dd419e36bdd1db9b94c728c406..617a1c911c7d6753bcedc8ecc52= e3027a5259ad6 100644 GIT binary patch delta 33 ocmcb|dXH5iIM^lR9uortBb$@Ivq!LkUzm%hudjl_Mu}rg0HKKqF8}}l delta 33 ocmcb|dXH5iIM^lR9uortqnnezvq!LkUzm%huP+0`Mu}rg0Ho;&F8}}l diff --git a/tests/data/acpi/q35/TPM2.tis b/tests/data/acpi/q35/TPM2.tis index 7878a6e79a6a406d99ca1f5e9a528eb392b8d793..fe0f05987be40f1c1742ae189df= 7821adc522fc0 100644 GIT binary patch literal 76 wcmWFu@HO&bU|?Vob@F%i2v%^42yj*a0!E-1hz+8V0UI(0%m%6W&kkY&0CHRh0RR91 literal 76 wcmWFu@HO&bU|?V=3Da`Jcf2v%^42yhMoiZKGkKx`0=3D4A_u4U^Ym_e|8WP0Iiz{0RR91 diff --git a/tests/data/acpi/q35/WAET b/tests/data/acpi/q35/WAET index c2240f58dff6b2f765386b5a2e506fda4800be3e..ac0db59183096ea1d93832a4210= 15385ba93aba0 100644 GIT binary patch literal 40 mcmWG{bPds9U|?Xhbn_0s2>1X1 diff --git a/tests/data/acpi/virt/APIC.memhp b/tests/data/acpi/virt/APIC.me= mhp index 797dfde2841c51b7e72065602e99ce1714347f0d..023f15f12e74fb9a3a6d3d9dc99= 4541016947d6a 100644 GIT binary patch delta 32 mcmZ3%xPno_F~HM#1p@;EbAXe-vq!LkQ$&EX0uW4;m;eBTNC)@; delta 32 lcmZ3%xPno_F~HM#1p@;E^JXW1XOCb7r-%S&kk~|t2>_0s2>1X1 diff --git a/tests/data/acpi/virt/APIC.numamem b/tests/data/acpi/virt/APIC.= numamem index 797dfde2841c51b7e72065602e99ce1714347f0d..023f15f12e74fb9a3a6d3d9dc99= 4541016947d6a 100644 GIT binary patch delta 32 mcmZ3%xPno_F~HM#1p@;EbAXe-vq!LkQ$&EX0uW4;m;eBTNC)@; delta 32 lcmZ3%xPno_F~HM#1p@;E^JXW1XOCb7r-%S&kk~|t2>_0s2>1X1 diff --git a/tests/data/acpi/virt/DSDT b/tests/data/acpi/virt/DSDT index ea8a0869af1637ab75fe335e100256a2acf85e16..134d8ae5b602e0aaade6756b99c= 9abca45279284 100644 GIT binary patch delta 33 ncmcbjaYaMICDNjnwtos delta 33 mcmZ2#ywq62CD9mn>33dtLlw)9Ey6@!g>=3DCTs6cOO800bK)KFR_Blt>8e delta 33 mcmeCQ>9mn>33dtLlw)9EGH~*D_6SyRiU@E9iEWhlC<_3KtO)G@ diff --git a/tests/data/acpi/virt/FACP b/tests/data/acpi/virt/FACP index 27de99f51bfe846b1f8796ace49d83f5b33a1aed..1f764220f8533c427168e80ccf2= 98604826a00b4 100644 GIT binary patch literal 268 ycmZ>BbPnKQWME(ob@F%i2v%^42yj*a0-z8Bhz+8t3j|P&V`iYf6{t24%>w}Cy9NOO literal 268 ycmZ>BbPnKQWME+3?d0$55v<@85#a0w6axw|fY>0KxBbPnKQWME(ob@F%i2v%^42yj*a0-z8Bhz+8t3j|P&V`iYf6{t24%>w}Cy9NOO literal 268 ycmZ>BbPnKQWME+3?d0$55v<@85#a0w6axw|fY>0KxBbPnKQWME(ob@F%i2v%^42yj*a0-z8Bhz+8t3j|P&V`iYf6{t24%>w}Cy9NOO literal 268 ycmZ>BbPnKQWME+3?d0$55v<@85#a0w6axw|fY>0Kx|||U3LF3c diff --git a/tests/data/acpi/virt/SLIT.memhp b/tests/data/acpi/virt/SLIT.me= mhp index 74ec3b4b461ffecca36d8537975c202a5f011185..67f00813af7b2356fe74eed943a= b8dcf2291578b 100644 GIT binary patch literal 48 scmWIc@eDCwU|?W;;pFe^5v<@85#X!<1dKp25F11@0Wk=3D0iHdRo0OYg>0RR91 literal 48 scmWIc@eDCwU|?X>aq@Te2v%^42yhMtiZKGkKx`1r1jHb~B`V4V0NaKK0RR91 diff --git a/tests/data/acpi/virt/SPCR b/tests/data/acpi/virt/SPCR index 377271a0e7817cc21a28c02123a89facad63604f..24e0a579e7d73f432a614380e29= aa95113344186 100644 GIT binary patch delta 30 jcmWFtkO&TN4hmpkU|>4!4!4!NNl3SDFC003Bv#Y diff --git a/tests/data/acpi/virt/SRAT.numamem b/tests/data/acpi/virt/SRAT.= numamem index 9526e5a28eb2a315d3bc9d9b11852319d5a8898e..d45f40338ce4c06ba68163214f1= 49b2414c5f18b 100644 GIT binary patch delta 30 jcmd1Gk_ZlR49Q|(U|>#l@^|(KR&a_4a8>|Avq!LkUzm%huP+0`Mu`(l0HqiSFaQ7m --=20 MST From nobody Sun Feb 8 09:27:43 2026 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass(p=none dis=none) header.from=redhat.com ARC-Seal: i=1; a=rsa-sha256; t=1612540680; cv=none; d=zohomail.com; s=zohoarc; b=FCuddwswXMj0/mvfgheQ8EwLirgZO4eS0RD8qDr3luzBMSrNOmQVpFlgd+XlYd2efF+fi/r7cNFBbK1jp3kN28wwYqFiJ13zpEq7k68Tx07uAbGE1jSrh3ZYVJujDm6ob4h4zWZuaCLsuV5lyanVTUf4p+rGbo9IRnqWbY7ROUE= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1612540680; h=Content-Type:Cc:Date:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:To; bh=yxyfuz8MMuiJh5ZIA7haUGEMaSl9L5MbUaR0JCcPbko=; b=lNpsg3GaPAeyEtkNPmt7jpRyhYu4vDcKm/Q15xxNN0y7VznuMFvTQpwfddpwi4PBixDDhHyA68i6YzWb9qxakBKPXkGXFnYyYTb4SK3RVP3FQBEMHUgr58J0VMDHGbKSdCCMmjckfl2FL250l6EZCo1ZY4zPQF1sBtfTS3vaU9U= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass header.from= (p=none dis=none) header.from= Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1612540680105700.1952309562025; Fri, 5 Feb 2021 07:58:00 -0800 (PST) Received: from localhost ([::1]:51074 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1l82tG-0005DG-7z for importer@patchew.org; Fri, 05 Feb 2021 10:19:22 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]:48182) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1l82ex-0004eg-VY for qemu-devel@nongnu.org; Fri, 05 Feb 2021 10:04:36 -0500 Received: from us-smtp-delivery-124.mimecast.com ([216.205.24.124]:42371) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA1:256) (Exim 4.90_1) (envelope-from ) id 1l82en-0003Ae-4R for qemu-devel@nongnu.org; Fri, 05 Feb 2021 10:04:35 -0500 Received: from mail-ej1-f71.google.com (mail-ej1-f71.google.com [209.85.218.71]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-209-xC8FVqlQN8enGb1p_F8bIg-1; Fri, 05 Feb 2021 10:04:22 -0500 Received: by mail-ej1-f71.google.com with SMTP id le12so6840615ejb.13 for ; Fri, 05 Feb 2021 07:04:21 -0800 (PST) Received: from redhat.com (bzq-79-180-2-31.red.bezeqint.net. [79.180.2.31]) by smtp.gmail.com with ESMTPSA id s10sm4055997eja.26.2021.02.05.07.04.17 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 05 Feb 2021 07:04:18 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1612537463; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=yxyfuz8MMuiJh5ZIA7haUGEMaSl9L5MbUaR0JCcPbko=; b=G9rguER00tXPmvaHRw30b1M77v2l9RB3R5inWdrH0DolxYVRrvT9RKK64cj9acriSs8Fz9 SIbt55BR+zbKm83fFjMf2rsrGtBq7psJl+xhCh52OdaQgPuBig6/p4erIarZg37esY3Q/o A6YShhyht+uJb/sRBuuPYZ4sXFks7zQ= X-MC-Unique: xC8FVqlQN8enGb1p_F8bIg-1 X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=yxyfuz8MMuiJh5ZIA7haUGEMaSl9L5MbUaR0JCcPbko=; b=kJiTZb5tb3b2P9rPDF0hbK7p8adXLvq7APTaaLt2KpQAeK6N5Tf4VUp0hPSeaDSFHC rIYmplCX5sH4qfJX5EDhvBr+SQEo7iI6g4jCZzfypv28rsZJi3wcRSOt1+pxwkNXqE6/ yZW5XgVjJQT7Ho1+F5s3FFO1z3Y+uJtytJ8G6xGdkncndcaPcyiFMPgOjjS5JmsP3n77 yi+WBRBPuomea4cXhED+i1P8C1sBkQ8mLugXt/Avy3wLw6NrkjEk815VCMZn9Ajbb1G0 3lYqqtQJEqiudNI+Wl7oHF+4O8ngHl1VwgMDGJGodoHNk9XJkBsJwbu/5LoouGiqU6w5 VKkg== X-Gm-Message-State: AOAM531vuIMD14aCgIVoKBpHjDXbG0N1F8LbwoZrHVisCCyzxrIRIM+I SShJeGex+hNOJej2f3wdLURb+NmiVHRFgIV47XEPYCA6O0gQfHyOm8d57QLbHYol4i2SVPB4ZZM FQP+Cdubl6bMJkqamlSOg/IR9XW49wUd6NGJnOlbRHDjhtW4J8TsorfYkhPOq X-Received: by 2002:a17:906:c1d8:: with SMTP id bw24mr284228ejb.232.1612537460267; Fri, 05 Feb 2021 07:04:20 -0800 (PST) X-Google-Smtp-Source: ABdhPJxPvrG2BGpZKb5TZI/t1+2tlqgbxXD7jFGwMBXlBfyysP34ZPWySoF5O/+PHAJyij+tic8cxg== X-Received: by 2002:a17:906:c1d8:: with SMTP id bw24mr284181ejb.232.1612537459872; Fri, 05 Feb 2021 07:04:19 -0800 (PST) Date: Fri, 5 Feb 2021 10:04:16 -0500 From: "Michael S. Tsirkin" To: qemu-devel@nongnu.org Subject: [PULL v2 16/16] tests/acpi: disallow updates for expected data files Message-ID: <20210205150135.94643-17-mst@redhat.com> References: <20210205150135.94643-1-mst@redhat.com> MIME-Version: 1.0 In-Reply-To: <20210205150135.94643-1-mst@redhat.com> X-Mailer: git-send-email 2.27.0.106.g8ac3dc51b1 X-Mutt-Fcc: =sent Authentication-Results: relay.mimecast.com; auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=mst@redhat.com X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Disposition: inline Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Received-SPF: pass client-ip=216.205.24.124; envelope-from=mst@redhat.com; helo=us-smtp-delivery-124.mimecast.com X-Spam_score_int: -30 X-Spam_score: -3.1 X-Spam_bar: --- X-Spam_report: (-3.1 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.352, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_LOW=-0.7, RCVD_IN_MSPIKE_H3=0.001, RCVD_IN_MSPIKE_WL=0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Peter Maydell , Marian Postevca , Igor Mammedov Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: "Qemu-devel" X-ZohoMail-DKIM: pass (identity @redhat.com) Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" From: Marian Postevca Signed-off-by: Marian Postevca Message-Id: <20210119003216.17637-6-posteuca@mutex.one> Reviewed-by: Michael S. Tsirkin Signed-off-by: Michael S. Tsirkin --- tests/qtest/bios-tables-test-allowed-diff.h | 94 --------------------- 1 file changed, 94 deletions(-) diff --git a/tests/qtest/bios-tables-test-allowed-diff.h b/tests/qtest/bios= -tables-test-allowed-diff.h index b20ae72949..dfb8523c8b 100644 --- a/tests/qtest/bios-tables-test-allowed-diff.h +++ b/tests/qtest/bios-tables-test-allowed-diff.h @@ -1,95 +1 @@ /* List of comma-separated changed AML files to ignore */ -"tests/data/acpi/virt/APIC", -"tests/data/acpi/virt/FACP", -"tests/data/acpi/virt/GTDT", -"tests/data/acpi/virt/MCFG", -"tests/data/acpi/virt/SPCR", -"tests/data/acpi/virt/DSDT", -"tests/data/acpi/virt/APIC.numamem", -"tests/data/acpi/virt/FACP.numamem", -"tests/data/acpi/virt/GTDT.numamem", -"tests/data/acpi/virt/MCFG.numamem", -"tests/data/acpi/virt/SPCR.numamem", -"tests/data/acpi/virt/DSDT.numamem", -"tests/data/acpi/virt/SRAT.numamem", -"tests/data/acpi/virt/DSDT.memhp", -"tests/data/acpi/virt/NFIT.memhp", -"tests/data/acpi/virt/SSDT.memhp", -"tests/data/acpi/virt/SLIT.memhp", -"tests/data/acpi/virt/SRAT.memhp", -"tests/data/acpi/virt/SPCR.memhp", -"tests/data/acpi/virt/MCFG.memhp", -"tests/data/acpi/virt/GTDT.memhp", -"tests/data/acpi/virt/APIC.memhp", -"tests/data/acpi/virt/FACP.memhp", -"tests/data/acpi/virt/DSDT.pxb", - -"tests/data/acpi/pc/SRAT.acpihmat", -"tests/data/acpi/pc/HPET", -"tests/data/acpi/pc/DSDT.hpbrroot", -"tests/data/acpi/pc/SRAT.numamem", -"tests/data/acpi/pc/DSDT.dimmpxm", -"tests/data/acpi/pc/DSDT.acpihmat", -"tests/data/acpi/pc/FACP", -"tests/data/acpi/pc/SRAT.cphp", -"tests/data/acpi/pc/DSDT.numamem", -"tests/data/acpi/pc/DSDT.bridge", -"tests/data/acpi/pc/HMAT.acpihmat", -"tests/data/acpi/pc/DSDT.cphp", -"tests/data/acpi/pc/APIC.dimmpxm", -"tests/data/acpi/pc/SRAT.memhp", -"tests/data/acpi/pc/SLIT.cphp", -"tests/data/acpi/pc/DSDT.hpbridge", -"tests/data/acpi/pc/NFIT.dimmpxm", -"tests/data/acpi/pc/APIC.cphp", -"tests/data/acpi/pc/SSDT.dimmpxm", -"tests/data/acpi/pc/SRAT.dimmpxm", -"tests/data/acpi/pc/APIC.acpihmat", -"tests/data/acpi/pc/DSDT.memhp", -"tests/data/acpi/pc/DSDT.ipmikcs", -"tests/data/acpi/pc/SLIT.memhp", -"tests/data/acpi/pc/WAET", -"tests/data/acpi/pc/DSDT", -"tests/data/acpi/pc/APIC", -"tests/data/acpi/pc/DSDT.roothp", - -"tests/data/acpi/q35/SRAT.acpihmat", -"tests/data/acpi/q35/HPET", -"tests/data/acpi/q35/SRAT.numamem", -"tests/data/acpi/q35/DSDT.dimmpxm", -"tests/data/acpi/q35/DSDT.acpihmat", -"tests/data/acpi/q35/FACP", -"tests/data/acpi/q35/DSDT.mmio64", -"tests/data/acpi/q35/SRAT.cphp", -"tests/data/acpi/q35/DSDT.numamem", -"tests/data/acpi/q35/DSDT.bridge", -"tests/data/acpi/q35/HMAT.acpihmat", -"tests/data/acpi/q35/DSDT.cphp", -"tests/data/acpi/q35/APIC.dimmpxm", -"tests/data/acpi/q35/SRAT.memhp", -"tests/data/acpi/q35/SLIT.cphp", -"tests/data/acpi/q35/NFIT.dimmpxm", -"tests/data/acpi/q35/APIC.cphp", -"tests/data/acpi/q35/SSDT.dimmpxm", -"tests/data/acpi/q35/SRAT.dimmpxm", -"tests/data/acpi/q35/APIC.acpihmat", -"tests/data/acpi/q35/MCFG", -"tests/data/acpi/q35/DSDT.memhp", -"tests/data/acpi/q35/SLIT.memhp", -"tests/data/acpi/q35/WAET", -"tests/data/acpi/q35/DSDT.ipmibt", -"tests/data/acpi/q35/DSDT.tis", -"tests/data/acpi/q35/SRAT.mmio64", -"tests/data/acpi/q35/TPM2.tis", -"tests/data/acpi/q35/DSDT", -"tests/data/acpi/q35/APIC", - -"tests/data/acpi/microvm/APIC.pcie", -"tests/data/acpi/microvm/DSDT.pcie", -"tests/data/acpi/microvm/DSDT.usb", -"tests/data/acpi/microvm/DSDT.rtc", -"tests/data/acpi/microvm/FACP", -"tests/data/acpi/microvm/APIC.ioapic2", -"tests/data/acpi/microvm/DSDT.ioapic2", -"tests/data/acpi/microvm/DSDT", -"tests/data/acpi/microvm/APIC", --=20 MST