From nobody Tue Feb 10 11:12:40 2026 Delivered-To: importer@patchew.org Received-SPF: pass (zohomail.com: domain of _spf.google.com designates 209.85.218.43 as permitted sender) client-ip=209.85.218.43; envelope-from=philippe.mathieu.daude@gmail.com; helo=mail-ej1-f43.google.com; Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of _spf.google.com designates 209.85.218.43 as permitted sender) smtp.mailfrom=philippe.mathieu.daude@gmail.com ARC-Seal: i=1; a=rsa-sha256; t=1612536263; cv=none; d=zohomail.com; s=zohoarc; b=UBbCk9LlUSyP8AvjZDUVHODM6MHQ3PmjYCQHCDxPyPyzAUHa7OyO1WtuE/yerUALwJi2pGY0RwhjxwotZClajvW6Z4hdSdMYZf+Zcsh+3Mt4Z1R/yxioaJeH1QpNwAkAx1IRsV3IQGuVK2UeknnSC14IhO8skxFRl/1HlYEUcPg= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1612536263; h=Content-Type:Content-Transfer-Encoding:Cc:Date:From:In-Reply-To:MIME-Version:Message-ID:References:Sender:Subject:To; bh=VTiobrg06Kw2JYFRS+iUWcDIkvLt8aRr1C2BOmn2HFs=; b=gx0ClSE2E4bL1FA6bIZCYKg6I3qDYonXX5UCyidd0WLW2ovgCVVrO/gywtqyHvkSqHfB/162feIJeE1hUMKvXtOpf5UKDRB0HEEQ59Kxlctll1wR6zv6ZLx9LRTNQQXrGsapYaQsii8Nnq0PlUeJb2RP3mXZ+Sg2NlQku5eJBYA= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of _spf.google.com designates 209.85.218.43 as permitted sender) smtp.mailfrom=philippe.mathieu.daude@gmail.com Received: from mail-ej1-f43.google.com (mail-ej1-f43.google.com [209.85.218.43]) by mx.zohomail.com with SMTPS id 1612536263728957.1830030980304; Fri, 5 Feb 2021 06:44:23 -0800 (PST) Received: by mail-ej1-f43.google.com with SMTP id lg21so12340188ejb.3 for ; Fri, 05 Feb 2021 06:44:23 -0800 (PST) Return-Path: Return-Path: Received: from x1w.redhat.com (68.red-83-57-175.dynamicip.rima-tde.net. [83.57.175.68]) by smtp.gmail.com with ESMTPSA id x21sm3963731eje.118.2021.02.05.06.44.20 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 05 Feb 2021 06:44:21 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=sender:from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=VTiobrg06Kw2JYFRS+iUWcDIkvLt8aRr1C2BOmn2HFs=; b=LZS7OU9PLEL3wnLwvFERNy6JvAKSIiCAdy+xNn+oF4+zVnf+xyjHltt8vFbke76Bd7 Hh2wGfPBvfMLbRZoPyYG87PSF4n69n8IiAws794SslNKP11Kf8+rJHniSyPk3W5vIAXf n0O9Qmm+iS594IcAe7pDzP9i1Yjl99VFiPFRJVypPPl6tVhWMpWokoYvV7K6h9Iaq0KX iRrEqDnc+lQFW27DItlBjk7BalObRKTV+6BLL/IOdHd5OX+nx8rNkKRH2bAXZJ5bA3RS dQ/elnXFBOFnc5TIg2eT2oTHI8iEUh+bZnyYL/4N3XFYfDcacnP3YUShwnUfXxY8GjeA 2EIw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:sender:from:to:cc:subject:date:message-id :in-reply-to:references:mime-version:content-transfer-encoding; bh=VTiobrg06Kw2JYFRS+iUWcDIkvLt8aRr1C2BOmn2HFs=; b=koxAYntkS8uw+EhZ2BA6Ofg+af0I2+/xaHo7qcXxwsuFtbuozDNuEY9YK2jSz9tAlP /l+TAyKZCNg+3OWcQxW2Z/l3QqT97997burxyFnWBGhzRgNRhupS0K5GJlcecSNcIYBj X0jyVrYNogfgkfKXdZsISRKePw23ES+RTuBY0p3315wpPVkVpfRlRepThq+8rNAO+8oL c4j0Gd3guNhNjZeqFdVTZ+dsH6x2sWcerS1YyD4CuUpVskYQau5cvyycusH/A7fDb9gF J0g2EOuU6RNKGTAYxIOJrgY/8zsFKDbs4VBOkpkY3tPA/03jrIzK7mV/GZ9hqGhEwji5 twPw== X-Gm-Message-State: AOAM533ML7eP0w1aFGk/E0ZlcV5s0o0W/UZAjsFO7Oj8EohKkvP8FT1v Kv2xeZLIjJqvOW2YDwpiMRE= X-Google-Smtp-Source: ABdhPJzn7J0hDyTG5vX14Z/KHbNZg/Y+xN5SlwHgCMQaOTWc9v4REwqZidp/bCdhLwHqEP3drffJMw== X-Received: by 2002:a17:906:46ce:: with SMTP id k14mr4448504ejs.480.1612536262018; Fri, 05 Feb 2021 06:44:22 -0800 (PST) Sender: =?UTF-8?Q?Philippe_Mathieu=2DDaud=C3=A9?= From: =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= To: qemu-devel@nongnu.org Cc: Paolo Bonzini , qemu-arm@nongnu.org, Peter Maydell , Thomas Huth , Andrew Jones , qemu-block@nongnu.org, Laurent Vivier , John Snow , =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= Subject: [PATCH 6/9] hw/arm/virt: Display list of valid CPUs for the Virt machine Date: Fri, 5 Feb 2021 15:43:42 +0100 Message-Id: <20210205144345.2068758-7-f4bug@amsat.org> X-Mailer: git-send-email 2.26.2 In-Reply-To: <20210205144345.2068758-1-f4bug@amsat.org> References: <20210205144345.2068758-1-f4bug@amsat.org> MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable X-ZohoMail-DKIM: pass (identity @gmail.com) The Virt machine is restricted to a subset of the CPU provided by QEMU. Instead of having the user run '--cpu help' and try each CPUs until finding a match, display the list from start: $ qemu-system-aarch64 -M virt -cpu cortex-a8 qemu-system-aarch64: mach-virt: CPU type cortex-a8 not supported qemu-system-aarch64: mach-virt: Please select one of the following CPU ty= pes: cortex-a7, cortex-a15, cortex-a53, cortex-a57, cortex-a72, host, max Signed-off-by: Philippe Mathieu-Daud=C3=A9 --- hw/arm/virt.c | 11 +++++++++++ 1 file changed, 11 insertions(+) diff --git a/hw/arm/virt.c b/hw/arm/virt.c index 7802d3a66e8..6ffe091804f 100644 --- a/hw/arm/virt.c +++ b/hw/arm/virt.c @@ -1830,9 +1830,20 @@ static void machvirt_init(MachineState *machine) =20 if (!cpu_type_valid(machine->cpu_type)) { int len =3D strlen(machine->cpu_type) - strlen(ARM_CPU_TYPE_SUFFIX= ); + g_autoptr(GString) s =3D g_string_new(NULL); =20 error_report("mach-virt: CPU type %.*s not supported", len, machine->cpu_type); + + for (n =3D 0; n < ARRAY_SIZE(valid_cpus); n++) { + len =3D strlen(valid_cpus[n]) - strlen(ARM_CPU_TYPE_SUFFIX); + g_string_append_printf(s, " %.*s", len, valid_cpus[n]); + if (n + 1 < ARRAY_SIZE(valid_cpus)) { + g_string_append_c(s, ','); + } + } + error_report("mach-virt: Please select one of the following CPU ty= pes: %s", + g_string_free(s, FALSE)); exit(1); } =20 --=20 2.26.2