From nobody Tue Feb 10 06:26:04 2026 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org ARC-Seal: i=1; a=rsa-sha256; t=1612520162; cv=none; d=zohomail.com; s=zohoarc; b=QB00Oe7vgVCF9CMEXoNSVmc9B3ARzNI2WXd/DHuWyZc2i+ygNwAVv5w61EuO0Eo4ACqw2WQO1jqICOfGavfuqExrjXhSGCGM9TWr3qzWrziSFuMROdknR7llIVKn4DqbNnNXscd62eE3LVXFVr6lqYE7jfnQbcLyPr++PXaFXS4= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1612520162; h=Content-Type:Content-Transfer-Encoding:Cc:Date:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:To; bh=Kuc0QvOo8nKmVsHrysnxnFPhbTDLvW3lEHZXhP4VQ6E=; b=ItORxeRjekP7SsItyWmCXkEOSxGjtYP+3cjfzccRggvUP6bRxqDgcFKIjfdSdprHHsKtC+ijqsUPRiytO3p2hSWiJ0YEmpXMFgAb86wTIEScoOItpwAqt9EHGtqbN+a3JBP8q8TwlAoxxzEMn2q+Bj9GSgmzGidXBTShvCglyC4= ARC-Authentication-Results: i=1; mx.zohomail.com; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1612520162243248.25518950159847; Fri, 5 Feb 2021 02:16:02 -0800 (PST) Received: from localhost ([::1]:45344 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1l7y9g-00056r-2s for importer@patchew.org; Fri, 05 Feb 2021 05:16:00 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]:45710) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1l7y7b-00030R-D9; Fri, 05 Feb 2021 05:13:51 -0500 Received: from szxga06-in.huawei.com ([45.249.212.32]:3043) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1l7y7Y-000769-BC; Fri, 05 Feb 2021 05:13:51 -0500 Received: from DGGEMS403-HUB.china.huawei.com (unknown [172.30.72.60]) by szxga06-in.huawei.com (SkyGuard) with ESMTP id 4DXB751bPqzjGSt; Fri, 5 Feb 2021 18:12:33 +0800 (CST) Received: from localhost (10.174.184.155) by DGGEMS403-HUB.china.huawei.com (10.3.19.203) with Microsoft SMTP Server id 14.3.498.0; Fri, 5 Feb 2021 18:13:30 +0800 From: Jiahui Cen To: Subject: [PATCH v5 4/9] block-backend: Enable retry action on errors Date: Fri, 5 Feb 2021 18:13:10 +0800 Message-ID: <20210205101315.13042-5-cenjiahui@huawei.com> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20210205101315.13042-1-cenjiahui@huawei.com> References: <20210205101315.13042-1-cenjiahui@huawei.com> MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable X-Originating-IP: [10.174.184.155] X-CFilter-Loop: Reflected Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Received-SPF: pass client-ip=45.249.212.32; envelope-from=cenjiahui@huawei.com; helo=szxga06-in.huawei.com X-Spam_score_int: -41 X-Spam_score: -4.2 X-Spam_bar: ---- X-Spam_report: (-4.2 / 5.0 requ) BAYES_00=-1.9, RCVD_IN_DNSWL_MED=-2.3, RCVD_IN_MSPIKE_H4=0.001, RCVD_IN_MSPIKE_WL=0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Kevin Wolf , cenjiahui@huawei.com, zhang.zhanghailiang@huawei.com, qemu-block@nongnu.org, "Michael S. Tsirkin" , Markus Armbruster , Max Reitz , Stefan Hajnoczi , fangying1@huawei.com, John Snow Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: "Qemu-devel" Content-Type: text/plain; charset="utf-8" Enable retry action when backend's retry timer is available. It would trigger the timer to do device specific retry action. Signed-off-by: Jiahui Cen Signed-off-by: Ying Fang --- block/block-backend.c | 9 +++++++++ 1 file changed, 9 insertions(+) diff --git a/block/block-backend.c b/block/block-backend.c index a8bfaf6e4a..ab75cb1971 100644 --- a/block/block-backend.c +++ b/block/block-backend.c @@ -1803,6 +1803,9 @@ BlockErrorAction blk_get_error_action(BlockBackend *b= lk, bool is_read, return BLOCK_ERROR_ACTION_REPORT; case BLOCKDEV_ON_ERROR_IGNORE: return BLOCK_ERROR_ACTION_IGNORE; + case BLOCKDEV_ON_ERROR_RETRY: + return (blk->retry_timer) ? + BLOCK_ERROR_ACTION_RETRY : BLOCK_ERROR_ACTION_REPORT; case BLOCKDEV_ON_ERROR_AUTO: default: abort(); @@ -1850,6 +1853,12 @@ void blk_error_action(BlockBackend *blk, BlockErrorA= ction action, qemu_system_vmstop_request_prepare(); send_qmp_error_event(blk, action, is_read, error); qemu_system_vmstop_request(RUN_STATE_IO_ERROR); + } else if (action =3D=3D BLOCK_ERROR_ACTION_RETRY) { + if (!blk->quiesce_counter) { + timer_mod(blk->retry_timer, qemu_clock_get_ms(QEMU_CLOCK_REALT= IME) + + blk->retry_interval); + send_qmp_error_event(blk, action, is_read, error); + } } else { send_qmp_error_event(blk, action, is_read, error); } --=20 2.29.2