From nobody Sat Feb 7 04:47:07 2026 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=fail; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=fail(p=none dis=none) header.from=redhat.com ARC-Seal: i=1; a=rsa-sha256; t=1612509423; cv=none; d=zohomail.com; s=zohoarc; b=m9911q6WFrfnbFfdQYtGW0NRExoPoJDIqM6tpQ8w46Ka41JzmQt7+WgYcK841DoySGsuozka4U7jlRbJjzXqwdA0cdvnBfo0iZYkpX2r6LQbyWaC6FAuQmE86rZQK1dGEJRZ9+YVRP65t8J71myWMwOMJO4r9zPb94iLUn+h0qY= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1612509423; h=Content-Type:Content-Transfer-Encoding:Cc:Date:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:To; bh=Wb6aGabv3PX5EzjJmYdUPHkoV1EnNOL4o2shw1dCEPg=; b=XKZvQeuOmgXurOHGhbP5SwxLlJ7wKXP1/6XotQt48WjEp2Rxu6cYZVtetY7BOa8WQSe6xVI6LzdG0ZhfRLbXKB1PKp8NGFn+Rmsui9uv3EmC5qfsww43yPebGRQ7RfvgLfhKMNhH29DqLALeGyIPkU5MJVUkCO5CiXMB6K9zRVE= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=fail; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=fail header.from= (p=none dis=none) header.from= Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 161250942355795.40194384451945; Thu, 4 Feb 2021 23:17:03 -0800 (PST) Received: from localhost ([::1]:33720 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1l7vMU-0007wE-Fs for importer@patchew.org; Fri, 05 Feb 2021 02:17:02 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]:35656) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1l7v38-0001Qq-7T for qemu-devel@nongnu.org; Fri, 05 Feb 2021 01:57:02 -0500 Received: from us-smtp-delivery-124.mimecast.com ([63.128.21.124]:41445) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA1:256) (Exim 4.90_1) (envelope-from ) id 1l7v36-0001Ed-Hc for qemu-devel@nongnu.org; Fri, 05 Feb 2021 01:57:01 -0500 Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-56-d5yN4DZPOk-ZC60CXu4aJA-1; Fri, 05 Feb 2021 01:56:58 -0500 Received: from smtp.corp.redhat.com (int-mx03.intmail.prod.int.phx2.redhat.com [10.5.11.13]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id 5B4D21005501 for ; Fri, 5 Feb 2021 06:56:57 +0000 (UTC) Received: from sirius.home.kraxel.org (ovpn-113-108.ams2.redhat.com [10.36.113.108]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 2C34D60C9B; Fri, 5 Feb 2021 06:56:45 +0000 (UTC) Received: by sirius.home.kraxel.org (Postfix, from userid 1000) id 86D4A1800864; Fri, 5 Feb 2021 07:56:21 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1612508219; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=Wb6aGabv3PX5EzjJmYdUPHkoV1EnNOL4o2shw1dCEPg=; b=ioKGbdYk2qaU0qg3/o+B9xMlqNN49kRlfk+boAEjX3LMTm/bz2grjrhscRfwAxytRtyc/p OeJnSPeQEFj9fFbTpbXb9/80uMsB4T10FBKrrP90Xf1+07zOOKzKLRP6VLjzuEjptZ8yTG BRK2hNb0GPcUXRLPmustAmqZHCO2W/k= X-MC-Unique: d5yN4DZPOk-ZC60CXu4aJA-1 From: Gerd Hoffmann To: qemu-devel@nongnu.org Subject: [PULL 21/24] virtio-gpu: avoid re-entering cmdq processing Date: Fri, 5 Feb 2021 07:56:17 +0100 Message-Id: <20210205065620.1726554-22-kraxel@redhat.com> In-Reply-To: <20210205065620.1726554-1-kraxel@redhat.com> References: <20210205065620.1726554-1-kraxel@redhat.com> MIME-Version: 1.0 X-Scanned-By: MIMEDefang 2.79 on 10.5.11.13 Authentication-Results: relay.mimecast.com; auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=kraxel@redhat.com X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Received-SPF: pass client-ip=63.128.21.124; envelope-from=kraxel@redhat.com; helo=us-smtp-delivery-124.mimecast.com X-Spam_score_int: -30 X-Spam_score: -3.1 X-Spam_bar: --- X-Spam_report: (-3.1 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.351, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_LOW=-0.7, RCVD_IN_MSPIKE_H4=0.001, RCVD_IN_MSPIKE_WL=0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: "Michael S. Tsirkin" , Cleber Rosa , Wainer dos Santos Moschetta , Alex Williamson , Gerd Hoffmann , =?UTF-8?q?Marc-Andr=C3=A9=20Lureau?= , Paolo Bonzini , =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: "Qemu-devel" X-ZohoMail-DKIM: fail (Header signature does not verify) From: Marc-Andr=C3=A9 Lureau The next patch will notify the GL context got flush, which will resume the queue processing. However, if this happens within the caller context, it will end up with a stack overflow flush/update loop. Signed-off-by: Marc-Andr=C3=A9 Lureau Message-Id: <20210204105232.834642-18-marcandre.lureau@redhat.com> Signed-off-by: Gerd Hoffmann --- include/hw/virtio/virtio-gpu.h | 1 + hw/display/virtio-gpu.c | 5 +++++ 2 files changed, 6 insertions(+) diff --git a/include/hw/virtio/virtio-gpu.h b/include/hw/virtio/virtio-gpu.h index 4f3dbf79f9bc..0043268e9021 100644 --- a/include/hw/virtio/virtio-gpu.h +++ b/include/hw/virtio/virtio-gpu.h @@ -148,6 +148,7 @@ struct VirtIOGPU { =20 uint64_t hostmem; =20 + bool processing_cmdq; bool renderer_inited; bool renderer_reset; QEMUTimer *fence_poll; diff --git a/hw/display/virtio-gpu.c b/hw/display/virtio-gpu.c index 0e833a462bae..7eb4265a6da7 100644 --- a/hw/display/virtio-gpu.c +++ b/hw/display/virtio-gpu.c @@ -814,6 +814,10 @@ void virtio_gpu_process_cmdq(VirtIOGPU *g) { struct virtio_gpu_ctrl_command *cmd; =20 + if (g->processing_cmdq) { + return; + } + g->processing_cmdq =3D true; while (!QTAILQ_EMPTY(&g->cmdq)) { cmd =3D QTAILQ_FIRST(&g->cmdq); =20 @@ -843,6 +847,7 @@ void virtio_gpu_process_cmdq(VirtIOGPU *g) g_free(cmd); } } + g->processing_cmdq =3D false; } =20 static void virtio_gpu_gl_unblock(VirtIOGPUBase *b) --=20 2.29.2