From nobody Sat Feb 7 04:47:03 2026 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=fail; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=fail(p=none dis=none) header.from=redhat.com ARC-Seal: i=1; a=rsa-sha256; t=1612508439; cv=none; d=zohomail.com; s=zohoarc; b=k+6aet3+74I4hvnc7DNXx/ckTWqW8isfPTe/aGTpLzB1XZPBM3fODKhdexNgtitZNIbXrlwV377xKqpJurrjs1qZHPy+bbwqBcdrk/jVNTRFa+gZhCzu3I6LxcJU/gjFM1vMO2z0C9tOFV6iwa2sIS8QmaRmsYQlzvg43OSJRrA= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1612508439; h=Content-Type:Content-Transfer-Encoding:Cc:Date:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:To; bh=djGm7em1BgCb/gG6DOeg/pYmAOYFfMXv/CtPlD5mons=; b=blL9Er6B/W1hFjvpETVvh/HG3Bq+9uGnMKKqA2TSy3pAWczA0J53X81TytbSQrmqwo99JGzjS9mggV336ZAa9kQF2P5iPAJX7FnV9F6/nnNitLDJRzVNk56nLJ7zWjQVrq87hP7DcFjejlht9B3ViXeVmURaM6Sz+Lr1dqHZFC0= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=fail; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=fail header.from= (p=none dis=none) header.from= Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1612508439480802.5820470885513; Thu, 4 Feb 2021 23:00:39 -0800 (PST) Received: from localhost ([::1]:46752 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1l7v6c-0006B9-Cw for importer@patchew.org; Fri, 05 Feb 2021 02:00:38 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]:35490) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1l7v2r-00012h-N5 for qemu-devel@nongnu.org; Fri, 05 Feb 2021 01:56:45 -0500 Received: from us-smtp-delivery-124.mimecast.com ([63.128.21.124]:51569) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA1:256) (Exim 4.90_1) (envelope-from ) id 1l7v2q-00016Y-6T for qemu-devel@nongnu.org; Fri, 05 Feb 2021 01:56:45 -0500 Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-532-yVJwYwoTOASxMRonGvf5Lg-1; Fri, 05 Feb 2021 01:56:41 -0500 Received: from smtp.corp.redhat.com (int-mx08.intmail.prod.int.phx2.redhat.com [10.5.11.23]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id C725A835E20 for ; Fri, 5 Feb 2021 06:56:40 +0000 (UTC) Received: from sirius.home.kraxel.org (ovpn-113-108.ams2.redhat.com [10.36.113.108]) by smtp.corp.redhat.com (Postfix) with ESMTPS id A207D1A26A; Fri, 5 Feb 2021 06:56:39 +0000 (UTC) Received: by sirius.home.kraxel.org (Postfix, from userid 1000) id 1F8BC18003B9; Fri, 5 Feb 2021 07:56:21 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1612508203; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=djGm7em1BgCb/gG6DOeg/pYmAOYFfMXv/CtPlD5mons=; b=AkuZdkULCVn7mkHE4WzCNjxBKTFmDHrGr7f0T3tHf4nGsIjAjwSH1sSjcRx3wdXYkvCpn5 h1FDl51R8Isj3j0X4i4FWFiPPuU9+QwyxnSEjC4jE5Mu+ytVl7dhEZk2K3U2y7Mjgn29Sn ErbNmxvnKCAJKCDu/FrYZ2PhQEA0rFY= X-MC-Unique: yVJwYwoTOASxMRonGvf5Lg-1 From: Gerd Hoffmann To: qemu-devel@nongnu.org Subject: [PULL 13/24] ui: remove console_has_gl_dmabuf() Date: Fri, 5 Feb 2021 07:56:09 +0100 Message-Id: <20210205065620.1726554-14-kraxel@redhat.com> In-Reply-To: <20210205065620.1726554-1-kraxel@redhat.com> References: <20210205065620.1726554-1-kraxel@redhat.com> MIME-Version: 1.0 X-Scanned-By: MIMEDefang 2.84 on 10.5.11.23 Authentication-Results: relay.mimecast.com; auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=kraxel@redhat.com X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Received-SPF: pass client-ip=63.128.21.124; envelope-from=kraxel@redhat.com; helo=us-smtp-delivery-124.mimecast.com X-Spam_score_int: -30 X-Spam_score: -3.1 X-Spam_bar: --- X-Spam_report: (-3.1 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.351, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_LOW=-0.7, RCVD_IN_MSPIKE_H4=0.001, RCVD_IN_MSPIKE_WL=0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: "Michael S. Tsirkin" , Cleber Rosa , Wainer dos Santos Moschetta , Alex Williamson , Gerd Hoffmann , =?UTF-8?q?Marc-Andr=C3=A9=20Lureau?= , Paolo Bonzini , =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: "Qemu-devel" X-ZohoMail-DKIM: fail (Header signature does not verify) From: Marc-Andr=C3=A9 Lureau This check is currently limited. It only is used by vhost-user-gpu (not by vfio-display), and will print an error repeatedly during run-time. We are going to dissociate the GL context from the DisplayChangeListener, and listeners may come and go. The following patches will address this differently. Signed-off-by: Marc-Andr=C3=A9 Lureau Message-Id: <20210204105232.834642-10-marcandre.lureau@redhat.com> Signed-off-by: Gerd Hoffmann --- include/ui/console.h | 1 - hw/display/vhost-user-gpu.c | 5 ----- ui/console.c | 5 ----- 3 files changed, 11 deletions(-) diff --git a/include/ui/console.h b/include/ui/console.h index bea2b6329a92..ac989fdf7016 100644 --- a/include/ui/console.h +++ b/include/ui/console.h @@ -323,7 +323,6 @@ void dpy_gl_ctx_destroy(QemuConsole *con, QEMUGLContext= ctx); int dpy_gl_ctx_make_current(QemuConsole *con, QEMUGLContext ctx); =20 bool console_has_gl(QemuConsole *con); -bool console_has_gl_dmabuf(QemuConsole *con); =20 static inline int surface_stride(DisplaySurface *s) { diff --git a/hw/display/vhost-user-gpu.c b/hw/display/vhost-user-gpu.c index 55b0ed15f250..dd587436ff34 100644 --- a/hw/display/vhost-user-gpu.c +++ b/hw/display/vhost-user-gpu.c @@ -224,11 +224,6 @@ vhost_user_gpu_handle_display(VhostUserGPU *g, VhostUs= erGpuMsg *msg) close(dmabuf->fd); dmabuf->fd =3D -1; } - if (!console_has_gl_dmabuf(con)) { - /* it would be nice to report that error earlier */ - error_report("console doesn't support dmabuf!"); - break; - } dpy_gl_release_dmabuf(con, dmabuf); if (fd =3D=3D -1) { dpy_gl_scanout_disable(con); diff --git a/ui/console.c b/ui/console.c index ab9224429e29..b5bc3f7699a1 100644 --- a/ui/console.c +++ b/ui/console.c @@ -1463,11 +1463,6 @@ bool console_has_gl(QemuConsole *con) return con->gl !=3D NULL; } =20 -bool console_has_gl_dmabuf(QemuConsole *con) -{ - return con->gl !=3D NULL && con->gl->ops->dpy_gl_scanout_dmabuf !=3D N= ULL; -} - void register_displaychangelistener(DisplayChangeListener *dcl) { static const char nodev[] =3D --=20 2.29.2