From nobody Mon Feb 9 04:45:07 2026 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass(p=none dis=none) header.from=redhat.com ARC-Seal: i=1; a=rsa-sha256; t=1612458889; cv=none; d=zohomail.com; s=zohoarc; b=Q5NVOGFlnN+KZlwruxngxudvEMrUh+AZL9V/UICZm6Fm6bx1Gsgj7+yQTzNdAOlrw5XW0KNc0cRK7yAg9wIog1Pl932zTbM07Ak53V4CqykemaxEfelkpkKUPsF+Nzol0CrywEi+JXtrxPKCjjrZTAaPY43MR8PoFxWdjv3UCLg= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1612458889; h=Content-Type:Content-Transfer-Encoding:Date:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:To; bh=qq8PHy6Wlmp7l579fTWql1UlYrUS7y4sJ0f4EoZn+jg=; b=BI84WURINNhIriMXleSjfsoNysMPgAHvFvpYKwsFXPVStwOj6RoYfXvcz/bI1GfqF11Vt8ynPSaokNOfvCNtOU2TWJ+avAoTE55VQn9ONh9Krem+IlJSahz2Rio/wSWM+jGQTxbb2xCPdSS2rhSHHuXpROugPfVT3I3xRPg2wFY= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass header.from= (p=none dis=none) header.from= Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1612458889303572.2522988651755; Thu, 4 Feb 2021 09:14:49 -0800 (PST) Received: from localhost ([::1]:37610 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1l7iDQ-0000eK-0e for importer@patchew.org; Thu, 04 Feb 2021 12:14:48 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]:40814) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1l7hg4-0000oN-Tk for qemu-devel@nongnu.org; Thu, 04 Feb 2021 11:40:21 -0500 Received: from us-smtp-delivery-124.mimecast.com ([63.128.21.124]:57875) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA1:256) (Exim 4.90_1) (envelope-from ) id 1l7hg2-0004hW-MN for qemu-devel@nongnu.org; Thu, 04 Feb 2021 11:40:20 -0500 Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-314-uQztrlNdPg6EyOfirTKSvQ-1; Thu, 04 Feb 2021 11:40:15 -0500 Received: from smtp.corp.redhat.com (int-mx08.intmail.prod.int.phx2.redhat.com [10.5.11.23]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id C0B1B80197E; Thu, 4 Feb 2021 16:40:13 +0000 (UTC) Received: from dgilbert-t580.localhost (ovpn-114-21.ams2.redhat.com [10.36.114.21]) by smtp.corp.redhat.com (Postfix) with ESMTP id 57F7E1A26A; Thu, 4 Feb 2021 16:40:11 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1612456818; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=qq8PHy6Wlmp7l579fTWql1UlYrUS7y4sJ0f4EoZn+jg=; b=LeG53sjOGHxnOt8iKpph+Q/PwSGzftE/IRrekkfbGH0SGrSh9n/8ALpe/fCle1vrug654l F5YWOX+SOShPjS01CHoUDSCkAr91dqse6hzulImsFlVw1dF4ca0Oombxcfip9MRQmCzMBc rohqLOZL6iGJgabxze0pjLdwYH536T0= X-MC-Unique: uQztrlNdPg6EyOfirTKSvQ-1 From: "Dr. David Alan Gilbert (git)" To: qemu-devel@nongnu.org, andrey.gruzdev@virtuozzo.com, berrange@redhat.com, gaojinhao@huawei.com, armbru@redhat.com, mst@redhat.com, philmd@redhat.com, wainersm@redhat.com Subject: [PULL 03/27] vmstate: Fix memory leak in vmstate_handle_alloc() Date: Thu, 4 Feb 2021 16:39:35 +0000 Message-Id: <20210204163959.377618-4-dgilbert@redhat.com> In-Reply-To: <20210204163959.377618-1-dgilbert@redhat.com> References: <20210204163959.377618-1-dgilbert@redhat.com> MIME-Version: 1.0 X-Scanned-By: MIMEDefang 2.84 on 10.5.11.23 Authentication-Results: relay.mimecast.com; auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=dgilbert@redhat.com X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Transfer-Encoding: quoted-printable Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Received-SPF: pass client-ip=63.128.21.124; envelope-from=dgilbert@redhat.com; helo=us-smtp-delivery-124.mimecast.com X-Spam_score_int: -30 X-Spam_score: -3.1 X-Spam_bar: --- X-Spam_report: (-3.1 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.351, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_LOW=-0.7, RCVD_IN_MSPIKE_H4=0.001, RCVD_IN_MSPIKE_WL=0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: "Qemu-devel" X-ZohoMail-DKIM: pass (identity @redhat.com) Content-Type: text/plain; charset="utf-8" From: Jinhao Gao Some memory allocated for fields having a flag of VMS_ALLOC in SaveState may not free before VM load vmsd in migration. So we pre-free memory before allocation in vmstate_handle_alloc() to avoid memleaks. Reported-by: Euler Robot Signed-off-by: Jinhao Gao Signed-off-by: Michael S. Tsirkin Message-Id: <20201231061020.828-4-gaojinhao@huawei.com> Reviewed-by: Dr. David Alan Gilbert Signed-off-by: Dr. David Alan Gilbert --- migration/vmstate.c | 1 + 1 file changed, 1 insertion(+) diff --git a/migration/vmstate.c b/migration/vmstate.c index 05f87cdddc..cc3dfcbae8 100644 --- a/migration/vmstate.c +++ b/migration/vmstate.c @@ -70,6 +70,7 @@ static void vmstate_handle_alloc(void *ptr, const VMState= Field *field, gsize size =3D vmstate_size(opaque, field); size *=3D vmstate_n_elems(opaque, field); if (size) { + g_free(*(void **)ptr); *(void **)ptr =3D g_malloc(size); } } --=20 2.29.2