From nobody Tue Feb 10 11:24:01 2026 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=fail; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=fail(p=none dis=none) header.from=redhat.com ARC-Seal: i=1; a=rsa-sha256; t=1612452531; cv=none; d=zohomail.com; s=zohoarc; b=G0/XIpSi3iF4b4G+JNe0KPoFMt1V19FBI9WsH4nIUq6iV01q79XP/ZJ6s9bnfyDnsp5XxsroaFz2ACdWYife0jnwT5Fjpwu7M/0poG6/eYynpsNURqx5MLMOd6F6WPckdMRVcKNCfg5KHZzPNRQo35d7LVXKdUVMBHcbg3K/Flk= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1612452531; h=Content-Type:Content-Transfer-Encoding:Cc:Date:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:To; bh=dUguKk7pEcNYDonCk/K2qnrIwMEERiH0yxbvA57CzCA=; b=QS3MN2lDA9+TObi3fmc/8Eg0I89gRqrMiK0fELvDFq5F7ur/a6OM/kjc4ER17YqxPRmY8H7iZZnzNntdwjuZqgeVNGWDLPA6gYLdvBI3lXRg7GV6x/VLL2iCN6nBgT477y2eSIMxEsgKRzMft42XvkNWy1WTMGZs3UloPsUBXFU= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=fail; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=fail header.from= (p=none dis=none) header.from= Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1612452531255934.0549321409636; Thu, 4 Feb 2021 07:28:51 -0800 (PST) Received: from localhost ([::1]:60610 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1l7gDj-0007OW-Eq for importer@patchew.org; Thu, 04 Feb 2021 10:06:59 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]:40536) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1l7g9V-000308-Q9 for qemu-devel@nongnu.org; Thu, 04 Feb 2021 10:02:38 -0500 Received: from us-smtp-delivery-124.mimecast.com ([63.128.21.124]:50567) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA1:256) (Exim 4.90_1) (envelope-from ) id 1l7g9T-0002XV-Ug for qemu-devel@nongnu.org; Thu, 04 Feb 2021 10:02:37 -0500 Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-394-lo0YQtksOKmX4yrWH2z8Aw-1; Thu, 04 Feb 2021 10:02:33 -0500 Received: from smtp.corp.redhat.com (int-mx04.intmail.prod.int.phx2.redhat.com [10.5.11.14]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id 7D1FA1936B61; Thu, 4 Feb 2021 15:02:32 +0000 (UTC) Received: from localhost (ovpn-115-89.ams2.redhat.com [10.36.115.89]) by smtp.corp.redhat.com (Postfix) with ESMTP id 8D3B55DA2D; Thu, 4 Feb 2021 15:02:21 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1612450955; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=dUguKk7pEcNYDonCk/K2qnrIwMEERiH0yxbvA57CzCA=; b=IUKCiqUTpoiEGzmhxTd4ZxTbrb/qE2euCbDUbjeMaBobkZ1aCWmk/Fq6p23U2ToA9ZTnHu ym2kNXaXb9qjDtPeKjJOBAbUZwFgqb2B/0vwQR8gE4ajmYgyfnOJ5ZsDJfzsAPDvUceb4E aSczUb9XllpcqskNo8wlyyIjMF+0bto= X-MC-Unique: lo0YQtksOKmX4yrWH2z8Aw-1 From: Stefan Hajnoczi To: qemu-devel@nongnu.org Subject: [PATCH v5 1/3] virtiofsd: extract lo_do_open() from lo_open() Date: Thu, 4 Feb 2021 15:02:06 +0000 Message-Id: <20210204150208.367837-2-stefanha@redhat.com> In-Reply-To: <20210204150208.367837-1-stefanha@redhat.com> References: <20210204150208.367837-1-stefanha@redhat.com> MIME-Version: 1.0 X-Scanned-By: MIMEDefang 2.79 on 10.5.11.14 Authentication-Results: relay.mimecast.com; auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=stefanha@redhat.com X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Transfer-Encoding: quoted-printable Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Received-SPF: pass client-ip=63.128.21.124; envelope-from=stefanha@redhat.com; helo=us-smtp-delivery-124.mimecast.com X-Spam_score_int: -13 X-Spam_score: -1.4 X-Spam_bar: - X-Spam_report: (-1.4 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.351, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, MIME_BASE64_TEXT=1.741, RCVD_IN_DNSWL_LOW=-0.7, RCVD_IN_MSPIKE_H4=0.001, RCVD_IN_MSPIKE_WL=0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: mszeredi@redhat.com, Daniel Berrange , slp@redhat.com, Greg Kurz , P J P , virtio-fs@redhat.com, vgoyal@redhat.com, Stefan Hajnoczi , Laszlo Ersek , "Dr. David Alan Gilbert" Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: "Qemu-devel" X-ZohoMail-DKIM: fail (Header signature does not verify) Content-Type: text/plain; charset="utf-8" Both lo_open() and lo_create() have similar code to open a file. Extract a common lo_do_open() function from lo_open() that will be used by lo_create() in a later commit. Since lo_do_open() does not otherwise need fuse_req_t req, convert lo_add_fd_mapping() to use struct lo_data *lo instead. Signed-off-by: Stefan Hajnoczi Reviewed-by: Greg Kurz --- v4: * Return positive errno if openat(2) fails in lo_do_open() [Greg] --- tools/virtiofsd/passthrough_ll.c | 73 ++++++++++++++++++++------------ 1 file changed, 46 insertions(+), 27 deletions(-) diff --git a/tools/virtiofsd/passthrough_ll.c b/tools/virtiofsd/passthrough= _ll.c index 5fb36d9407..f14fa5124d 100644 --- a/tools/virtiofsd/passthrough_ll.c +++ b/tools/virtiofsd/passthrough_ll.c @@ -459,17 +459,17 @@ static void lo_map_remove(struct lo_map *map, size_t = key) } =20 /* Assumes lo->mutex is held */ -static ssize_t lo_add_fd_mapping(fuse_req_t req, int fd) +static ssize_t lo_add_fd_mapping(struct lo_data *lo, int fd) { struct lo_map_elem *elem; =20 - elem =3D lo_map_alloc_elem(&lo_data(req)->fd_map); + elem =3D lo_map_alloc_elem(&lo->fd_map); if (!elem) { return -1; } =20 elem->fd =3D fd; - return elem - lo_data(req)->fd_map.elems; + return elem - lo->fd_map.elems; } =20 /* Assumes lo->mutex is held */ @@ -1651,6 +1651,38 @@ static void update_open_flags(int writeback, int all= ow_direct_io, } } =20 +static int lo_do_open(struct lo_data *lo, struct lo_inode *inode, + struct fuse_file_info *fi) +{ + char buf[64]; + ssize_t fh; + int fd; + + update_open_flags(lo->writeback, lo->allow_direct_io, fi); + + sprintf(buf, "%i", inode->fd); + fd =3D openat(lo->proc_self_fd, buf, fi->flags & ~O_NOFOLLOW); + if (fd =3D=3D -1) { + return errno; + } + + pthread_mutex_lock(&lo->mutex); + fh =3D lo_add_fd_mapping(lo, fd); + pthread_mutex_unlock(&lo->mutex); + if (fh =3D=3D -1) { + close(fd); + return ENOMEM; + } + + fi->fh =3D fh; + if (lo->cache =3D=3D CACHE_NONE) { + fi->direct_io =3D 1; + } else if (lo->cache =3D=3D CACHE_ALWAYS) { + fi->keep_cache =3D 1; + } + return 0; +} + static void lo_create(fuse_req_t req, fuse_ino_t parent, const char *name, mode_t mode, struct fuse_file_info *fi) { @@ -1691,7 +1723,7 @@ static void lo_create(fuse_req_t req, fuse_ino_t pare= nt, const char *name, ssize_t fh; =20 pthread_mutex_lock(&lo->mutex); - fh =3D lo_add_fd_mapping(req, fd); + fh =3D lo_add_fd_mapping(lo, fd); pthread_mutex_unlock(&lo->mutex); if (fh =3D=3D -1) { close(fd); @@ -1892,38 +1924,25 @@ static void lo_fsyncdir(fuse_req_t req, fuse_ino_t = ino, int datasync, =20 static void lo_open(fuse_req_t req, fuse_ino_t ino, struct fuse_file_info = *fi) { - int fd; - ssize_t fh; - char buf[64]; struct lo_data *lo =3D lo_data(req); + struct lo_inode *inode =3D lo_inode(req, ino); + int err; =20 fuse_log(FUSE_LOG_DEBUG, "lo_open(ino=3D%" PRIu64 ", flags=3D%d)\n", i= no, fi->flags); =20 - update_open_flags(lo->writeback, lo->allow_direct_io, fi); - - sprintf(buf, "%i", lo_fd(req, ino)); - fd =3D openat(lo->proc_self_fd, buf, fi->flags & ~O_NOFOLLOW); - if (fd =3D=3D -1) { - return (void)fuse_reply_err(req, errno); - } - - pthread_mutex_lock(&lo->mutex); - fh =3D lo_add_fd_mapping(req, fd); - pthread_mutex_unlock(&lo->mutex); - if (fh =3D=3D -1) { - close(fd); - fuse_reply_err(req, ENOMEM); + if (!inode) { + fuse_reply_err(req, EBADF); return; } =20 - fi->fh =3D fh; - if (lo->cache =3D=3D CACHE_NONE) { - fi->direct_io =3D 1; - } else if (lo->cache =3D=3D CACHE_ALWAYS) { - fi->keep_cache =3D 1; + err =3D lo_do_open(lo, inode, fi); + lo_inode_put(lo, &inode); + if (err) { + fuse_reply_err(req, err); + } else { + fuse_reply_open(req, fi); } - fuse_reply_open(req, fi); } =20 static void lo_release(fuse_req_t req, fuse_ino_t ino, --=20 2.29.2