From nobody Mon Feb 9 11:28:43 2026 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=fail; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass(p=none dis=none) header.from=nongnu.org ARC-Seal: i=1; a=rsa-sha256; t=1612388474; cv=none; d=zohomail.com; s=zohoarc; b=e4DEZ0juddgj6Cyd4jSq5chQ+B6vaPklYWRzTJy9dh2pObiN4KIVPq2c+BoH0IBx3mkcwA3EXAMmvfv0RtFmnvazRHmax/odOyHgADm0R/s9hKxw3S5zvrQyrIWAehoMiJ/ACadNg5O8gdaUZyyiYssrHiRfcSuSmKiyaNgwcT0= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1612388474; h=Content-Type:Cc:Date:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:Reply-To:References:Sender:Subject:To; bh=BhbO3SvLCkriwBiHJc9Cks1uZmwz8cYND/xQeX1C+kQ=; b=OPik6kj50PlYYgEcnrY0ClWr/32Wsj8hMGolTDAZE5kq/aE8e/6hl4y0c0tXPaCUBJzm5WBmh0zOUA7yIFXGyVgA46q6BD3HrXlNqhUhr9J5UI4DURbP+ot5lcxk5Y8lJfn+8piciKTWAPBPFtDrqkbLNtOcCDWhH+CKTda+mHs= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=fail; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass header.from= (p=none dis=none) header.from= Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1612388474710690.1302457412085; Wed, 3 Feb 2021 13:41:14 -0800 (PST) Received: from localhost ([::1]:50424 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1l7Pth-0007YX-KG for importer@patchew.org; Wed, 03 Feb 2021 16:41:13 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]:47732) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from <3oRcbYAMKCkQjpkmuumrk.iuswks0-jk1krtutmt0.uxm@flex--dje.bounces.google.com>) id 1l7PqK-0005B4-2u for qemu-devel@nongnu.org; Wed, 03 Feb 2021 16:37:44 -0500 Received: from mail-ua1-x949.google.com ([2607:f8b0:4864:20::949]:50444) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from <3oRcbYAMKCkQjpkmuumrk.iuswks0-jk1krtutmt0.uxm@flex--dje.bounces.google.com>) id 1l7PqI-0000k6-4L for qemu-devel@nongnu.org; Wed, 03 Feb 2021 16:37:43 -0500 Received: by mail-ua1-x949.google.com with SMTP id 9so336673uas.17 for ; Wed, 03 Feb 2021 13:37:38 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20161025; h=sender:date:in-reply-to:message-id:mime-version:references:subject :from:to:cc; bh=BhbO3SvLCkriwBiHJc9Cks1uZmwz8cYND/xQeX1C+kQ=; b=ls0587oRfQ2IKl7p5Nc6dtCOgoWUVtkbWRAD1mP+NbP/tPfj2CdID6VkV0ZjuD2pRv X9dtcjK4MLfG2pKU0s+104YkaRT1POwzS+e+EEPX0VnHkYM827y7PblSGUvsdjwOgnY7 74cZXsyr0b2H/iz1V7sOIjAozAfa5e3n2tAVHde8J92XNBY/dp2v/A4V2JGOIklrANGw WqDhTDPtysxHIE9r7F2t8Fvn/QjTadcCiCV34yKmWDKeT0noF9x0ZbSuwlGooRnROpKV gjN8Eptg/Q4Q1IkLe/ut9B0+chA/b9fQUyz3xflTrKVJYBZeBsze4Ib+2bhlGtqMTzu3 +r1Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:sender:date:in-reply-to:message-id:mime-version :references:subject:from:to:cc; bh=BhbO3SvLCkriwBiHJc9Cks1uZmwz8cYND/xQeX1C+kQ=; b=KH2qfJtJifWYgGNyyft2ZrqR4roODHFAXwtlwZHc0/F4yR+l/mFzxJD3yu7ID9aMlg TKR8Oe8cP1MBKmAfV/Kvew+Vw5IZ39NBoag+mee7D87yxmPZy1O9yRKA9xedALlqvZwA wF0rhzCPk3ec5L+oFT4cWEAJmkgd87HBRseIVSct2SVK1iEyHv3YEW6cFze1Px0bOmBt BRLT9j4p+33sig0dWMvezDuDh0lSznc59OB23Zx3FIrGclQIyo9cAcQAYRJg6BHHdn11 viBDgtAgK2coAmkM3Y109KJ1DlPrZ6IPG7L1Rn6mIgV+uksqGtFGBZ3oqH/yaghO0OYO VQYQ== X-Gm-Message-State: AOAM531MafghhIhIagvOAmI+XFv/kdwyr+pabevdk+v78sYstu5rS9sS /xm0BaJlNGZyZPNa8nwgN6eLIsjKw0Ib8bPxcljqy3tr05riqczeBy3PIhkmfG8waKUJpKDGCtQ d2qhv91WxwJ3tS5DL4VtydS+RGVFQvJ2JaBV08ASUG36E4B/Q4V8N X-Google-Smtp-Source: ABdhPJyBdleMJprC7owuIC2EP9jPrhs601sBSkweZR48PnwUw+F0g7TaffJEfJFVdIafqDtrACY4vYk= X-Received: from ruffy.mtv.corp.google.com ([2620:0:1000:1412:25d4:96ad:ca30:7913]) (user=dje job=sendgmr) by 2002:a1f:1489:: with SMTP id 131mr3347055vku.25.1612388257422; Wed, 03 Feb 2021 13:37:37 -0800 (PST) Date: Wed, 3 Feb 2021 13:37:28 -0800 In-Reply-To: <20210203213729.1940893-1-dje@google.com> Message-Id: <20210203213729.1940893-2-dje@google.com> Mime-Version: 1.0 References: <20210203213729.1940893-1-dje@google.com> X-Mailer: git-send-email 2.30.0.365.g02bc693789-goog Subject: [PATCH v2 1/2] net/slirp.c: Refactor address parsing To: qemu-devel@nongnu.org Cc: Samuel Thibault , Doug Evans Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Received-SPF: pass client-ip=2607:f8b0:4864:20::949; envelope-from=3oRcbYAMKCkQjpkmuumrk.iuswks0-jk1krtutmt0.uxm@flex--dje.bounces.google.com; helo=mail-ua1-x949.google.com X-Spam_score_int: -95 X-Spam_score: -9.6 X-Spam_bar: --------- X-Spam_report: (-9.6 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_MED=-0.001, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001, USER_IN_DEF_DKIM_WL=-7.5 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: "Qemu-devel" Reply-to: Doug Evans From: dje--- via X-ZohoMail-DKIM: fail (Header signature does not verify) Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" ... in preparation for adding ipv6 host forwarding support. Reviewed-by: Samuel Thibault --- net/slirp.c | 200 +++++++++++++++++++++++++++++++++------------------- slirp | 2 +- 2 files changed, 130 insertions(+), 72 deletions(-) diff --git a/net/slirp.c b/net/slirp.c index be914c0be0..a21a313302 100644 --- a/net/slirp.c +++ b/net/slirp.c @@ -631,15 +631,83 @@ static SlirpState *slirp_lookup(Monitor *mon, const c= har *id) } } =20 -void hmp_hostfwd_remove(Monitor *mon, const QDict *qdict) +/* + * Parse a protocol name of the form "name". + * Valid protocols are "tcp" and "udp". An empty string means "tcp". + * Returns a pointer to the end of the parsed string on success, and stores + * the result in *is_udp. + * Otherwise returns NULL and stores the error message in *errmsg, which m= ust + * be freed by the caller. + */ +static const char *parse_protocol(const char *str, int sep, int *is_udp, + char **errmsg) +{ + char buf[10]; + const char *p =3D str; + + if (get_str_sep(buf, sizeof(buf), &p, sep) < 0) { + *errmsg =3D g_strdup("Missing protcol name separator"); + return NULL; + } + + if (!strcmp(buf, "tcp") || buf[0] =3D=3D '\0') { + *is_udp =3D 0; + } else if (!strcmp(buf, "udp")) { + *is_udp =3D 1; + } else { + *errmsg =3D g_strdup("Bad protcol name"); + return NULL; + } + + return p; +} + +/* + * Parse an ipv4 address/port of the form "addrport". + * "kind" is either "host" or "guest" and is included in error messages. + * An empty address means INADDR_ANY. + * Returns a pointer to the end of the parsed string on success, and stores + * the results in *addr, *port. + * Otherwise returns NULL and stores the error message in *errmsg, which m= ust + * be freed by the caller. + */ +static const char *parse_in4_addr_port(const char *str, const char *kind, + int addr_sep, int port_sep, + struct in_addr *addr, int *port, + char **errmsg) { - struct in_addr host_addr =3D { .s_addr =3D INADDR_ANY }; - int host_port; char buf[256]; - const char *src_str, *p; + const char *p =3D str; + + if (get_str_sep(buf, sizeof(buf), &p, addr_sep) < 0) { + *errmsg =3D g_strdup_printf("Missing %s address separator", kind); + return NULL; + } + if (buf[0] =3D=3D '\0') { + addr->s_addr =3D INADDR_ANY; + } else if (!inet_aton(buf, addr)) { + *errmsg =3D g_strdup_printf("Bad %s address", kind); + return NULL; + } + + if (get_str_sep(buf, sizeof(buf), &p, port_sep) < 0) { + *errmsg =3D g_strdup_printf("Missing %s port separator", kind); + return NULL; + } + if (qemu_strtoi(buf, NULL, 10, port) < 0 || + *port < 0 || *port > 65535) { + *errmsg =3D g_strdup_printf("Bad %s port", kind); + return NULL; + } + + return p; +} + +static void hmp_hostfwd_remove_worker(Monitor *mon, const QDict *qdict, + int family) +{ + const char *src_str; SlirpState *s; - int is_udp =3D 0; - int err; const char *arg1 =3D qdict_get_str(qdict, "arg1"); const char *arg2 =3D qdict_get_try_str(qdict, "arg2"); =20 @@ -654,38 +722,42 @@ void hmp_hostfwd_remove(Monitor *mon, const QDict *qd= ict) return; } =20 - p =3D src_str; - if (!p || get_str_sep(buf, sizeof(buf), &p, ':') < 0) { - goto fail_syntax; - } + int host_port; + int is_udp; + char *errmsg =3D NULL; + int err; =20 - if (!strcmp(buf, "tcp") || buf[0] =3D=3D '\0') { - is_udp =3D 0; - } else if (!strcmp(buf, "udp")) { - is_udp =3D 1; - } else { - goto fail_syntax; - } + g_assert(src_str !=3D NULL); + const char *p =3D src_str; =20 - if (get_str_sep(buf, sizeof(buf), &p, ':') < 0) { - goto fail_syntax; - } - if (buf[0] !=3D '\0' && !inet_aton(buf, &host_addr)) { + p =3D parse_protocol(p, ':', &is_udp, &errmsg); + if (p =3D=3D NULL) { goto fail_syntax; } =20 - if (qemu_strtoi(p, NULL, 10, &host_port)) { - goto fail_syntax; + if (family =3D=3D AF_INET) { + struct in_addr host_addr; + if (parse_in4_addr_port(p, "host", ':', '\0', &host_addr, &host_po= rt, + &errmsg) =3D=3D NULL) { + goto fail_syntax; + } + err =3D slirp_remove_hostfwd(s->slirp, is_udp, host_addr, host_por= t); + } else { + g_assert_not_reached(); } =20 - err =3D slirp_remove_hostfwd(s->slirp, is_udp, host_addr, host_port); - monitor_printf(mon, "host forwarding rule for %s %s\n", src_str, err ? "not found" : "removed"); return; =20 fail_syntax: - monitor_printf(mon, "invalid format\n"); + monitor_printf(mon, "Invalid format: %s\n", errmsg); + g_free(errmsg); +} + +void hmp_hostfwd_remove(Monitor *mon, const QDict *qdict) +{ + hmp_hostfwd_remove_worker(mon, qdict, AF_INET); } =20 static int slirp_hostfwd(SlirpState *s, const char *redir_str, Error **err= p) @@ -694,56 +766,29 @@ static int slirp_hostfwd(SlirpState *s, const char *r= edir_str, Error **errp) struct in_addr guest_addr =3D { .s_addr =3D 0 }; int host_port, guest_port; const char *p; - char buf[256]; int is_udp; - char *end; - const char *fail_reason =3D "Unknown reason"; + char *errmsg =3D NULL; =20 + g_assert(redir_str !=3D NULL); p =3D redir_str; - if (!p || get_str_sep(buf, sizeof(buf), &p, ':') < 0) { - fail_reason =3D "No : separators"; - goto fail_syntax; - } - if (!strcmp(buf, "tcp") || buf[0] =3D=3D '\0') { - is_udp =3D 0; - } else if (!strcmp(buf, "udp")) { - is_udp =3D 1; - } else { - fail_reason =3D "Bad protocol name"; - goto fail_syntax; - } =20 - if (get_str_sep(buf, sizeof(buf), &p, ':') < 0) { - fail_reason =3D "Missing : separator"; - goto fail_syntax; - } - if (buf[0] !=3D '\0' && !inet_aton(buf, &host_addr)) { - fail_reason =3D "Bad host address"; + p =3D parse_protocol(p, ':', &is_udp, &errmsg); + if (p =3D=3D NULL) { goto fail_syntax; } =20 - if (get_str_sep(buf, sizeof(buf), &p, '-') < 0) { - fail_reason =3D "Bad host port separator"; - goto fail_syntax; - } - host_port =3D strtol(buf, &end, 0); - if (*end !=3D '\0' || host_port < 0 || host_port > 65535) { - fail_reason =3D "Bad host port"; + p =3D parse_in4_addr_port(p, "host", ':', '-', &host_addr, &host_port, + &errmsg); + if (p =3D=3D NULL) { goto fail_syntax; } =20 - if (get_str_sep(buf, sizeof(buf), &p, ':') < 0) { - fail_reason =3D "Missing guest address"; + if (parse_in4_addr_port(p, "guest", ':', '\0', &guest_addr, &guest_por= t, + &errmsg) =3D=3D NULL) { goto fail_syntax; } - if (buf[0] !=3D '\0' && !inet_aton(buf, &guest_addr)) { - fail_reason =3D "Bad guest address"; - goto fail_syntax; - } - - guest_port =3D strtol(p, &end, 0); - if (*end !=3D '\0' || guest_port < 1 || guest_port > 65535) { - fail_reason =3D "Bad guest port"; + if (guest_port =3D=3D 0) { + errmsg =3D g_strdup("Bad guest port"); goto fail_syntax; } =20 @@ -757,11 +802,12 @@ static int slirp_hostfwd(SlirpState *s, const char *r= edir_str, Error **errp) =20 fail_syntax: error_setg(errp, "Invalid host forwarding rule '%s' (%s)", redir_str, - fail_reason); + errmsg); + g_free(errmsg); return -1; } =20 -void hmp_hostfwd_add(Monitor *mon, const QDict *qdict) +static void hmp_hostfwd_add_worker(Monitor *mon, const QDict *qdict, int f= amily) { const char *redir_str; SlirpState *s; @@ -775,13 +821,25 @@ void hmp_hostfwd_add(Monitor *mon, const QDict *qdict) s =3D slirp_lookup(mon, NULL); redir_str =3D arg1; } - if (s) { - Error *err =3D NULL; - if (slirp_hostfwd(s, redir_str, &err) < 0) { - error_report_err(err); - } + if (!s) { + return; } =20 + Error *err =3D NULL; + int rc; + if (family =3D=3D AF_INET) { + rc =3D slirp_hostfwd(s, redir_str, &err); + } else { + g_assert_not_reached(); + } + if (rc < 0) { + error_report_err(err); + } +} + +void hmp_hostfwd_add(Monitor *mon, const QDict *qdict) +{ + hmp_hostfwd_add_worker(mon, qdict, AF_INET); } =20 #ifndef _WIN32 diff --git a/slirp b/slirp index 8f43a99191..358c0827d4 160000 --- a/slirp +++ b/slirp @@ -1 +1 @@ -Subproject commit 8f43a99191afb47ca3f3c6972f6306209f367ece +Subproject commit 358c0827d49778f016312bfb4167fe639900681f --=20 2.30.0.365.g02bc693789-goog