From nobody Wed Feb 11 01:00:10 2026 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=fail; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=fail(p=none dis=none) header.from=linaro.org ARC-Seal: i=1; a=rsa-sha256; t=1612381601; cv=none; d=zohomail.com; s=zohoarc; b=BTeHNI+kYO1yaiCcpHAGJ378780+1EtyG9EULJ9u5XZh3TjCL+zv0T7Wm/89oevNZuqbZx3jSCn7uYqDtLM6jZ7dJVkyKe+ByaQ4Sjo+CuyerjLWEj+J0VMFxZMRT+b1YbiqzxQ2coCOO3B/ie47bSBmXQRXGRV1OUVUaI1uYdk= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1612381601; h=Content-Transfer-Encoding:Cc:Date:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:To; bh=+5hZcB3mFjnWG5tCYVBAVH8vDfhhkDYHCqbXJC4msCo=; b=AOqontxxhmczqlBbTAHMfemDHcMtVexx9Y9FdF9wlpLpjsSr2NozDypQcrKq5Df4+sFNj7mqH+BoPFjeTUdCKBy1Z0bUAFpaaEQdRgLO+j5PByoRof79ezkKVFPo/hhATVfRaNK0/bTRFvsPFVGuXCA7e+MqTVybhceDswPrVjc= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=fail; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=fail header.from= (p=none dis=none) header.from= Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1612381601810651.1663751206479; Wed, 3 Feb 2021 11:46:41 -0800 (PST) Received: from localhost ([::1]:38510 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1l7O6q-0006LZ-K5 for importer@patchew.org; Wed, 03 Feb 2021 14:46:40 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]:38332) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1l7NP1-0007eu-Gc for qemu-devel@nongnu.org; Wed, 03 Feb 2021 14:01:23 -0500 Received: from mail-pg1-x52c.google.com ([2607:f8b0:4864:20::52c]:44202) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1l7NOr-0001pL-KZ for qemu-devel@nongnu.org; Wed, 03 Feb 2021 14:01:23 -0500 Received: by mail-pg1-x52c.google.com with SMTP id s23so363068pgh.11 for ; Wed, 03 Feb 2021 11:01:07 -0800 (PST) Received: from localhost.localdomain (cpe-66-27-222-29.hawaii.res.rr.com. [66.27.222.29]) by smtp.gmail.com with ESMTPSA id l2sm2906666pju.25.2021.02.03.11.01.04 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 03 Feb 2021 11:01:05 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=+5hZcB3mFjnWG5tCYVBAVH8vDfhhkDYHCqbXJC4msCo=; b=rSaXeYK0CKweyFIt9SP5Ilx9VcuVeuXC8BLQn7U8cKlqX2+lEPemW/mSSdmHE0ELoK HRcmf/rGfGxzVUXn96kBrALc5zC22mhZyyW3aR+JSu1YLZ2nr23ChK/9ZboDZSa9yxil AaBY/b5xu6FSw2Sx1+utRo4NZBdUYEpx+YZhyVYkn6ICrw6wHPcmelJ49jSn/QdDbamo r8ojg7u8pM6C7NVZiCSZkN/BzIf8iPm7LcBftHt1cK7L/pRKdSowrBBdP9YL97ZZTasH OhsXOTApsAcV+tlOr8bW/1Oj0xolRQEa1H/WuK5QC3kHg/oYhSvMpuPxlB4aCkEXhPYl pAhw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=+5hZcB3mFjnWG5tCYVBAVH8vDfhhkDYHCqbXJC4msCo=; b=MfKSkUH1e3gSWP1KfNbet1vIU1kGx3ChUhn5wqW9sMK6EKY5bLEhNtV1ae4KeRVPDU +An57cHYrR59XavWJg33zzKpaLicVd3MDvtmP7+sLmkAb7wOzTB9c4MtpCRW18lLXQJb YQJGhhVPYnxs/rKTrNOReXaXnXO35LJhDcoYuQKB2l5CWmflVfasa9Uf2Wug0npoNWTR hfgXNDoQdvQr848ZtWhfnQYd9h2TSwQ/S9Owy2oocxYhUPNm23vLVkaIoH45QTRAzCLU Z4vSXLmqOgK96uYWt2uObi+BsaLIOmyEDH0CFZenXYOk5SxDgc2Wwd+DnwmD/M2dwQsq leSQ== X-Gm-Message-State: AOAM530/DtzPHKRDE/T9gyqJ/g5ED1YGs1QJIrrI4LKCwX9J4nYOYEel 8TrejIv6BladFbtzYHWy6OvePmHqCutNw1Nv X-Google-Smtp-Source: ABdhPJwhliakfQZXE6troJ99/tjRyqkhHrZ3fvjJIs76mhmP8sFfpWlCPzHNLht+flKlP831n4izFg== X-Received: by 2002:a63:b55:: with SMTP id a21mr5134010pgl.409.1612378866677; Wed, 03 Feb 2021 11:01:06 -0800 (PST) From: Richard Henderson To: qemu-devel@nongnu.org Subject: [PATCH v5 26/31] linux-user/aarch64: Pass syndrome to EXC_*_ABORT Date: Wed, 3 Feb 2021 09:00:05 -1000 Message-Id: <20210203190010.759771-27-richard.henderson@linaro.org> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20210203190010.759771-1-richard.henderson@linaro.org> References: <20210203190010.759771-1-richard.henderson@linaro.org> MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Received-SPF: pass client-ip=2607:f8b0:4864:20::52c; envelope-from=richard.henderson@linaro.org; helo=mail-pg1-x52c.google.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=unavailable autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: peter.maydell@linaro.org, qemu-arm@nongnu.org Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: "Qemu-devel" X-ZohoMail-DKIM: fail (Header signature does not verify) Content-Type: text/plain; charset="utf-8" A proper syndrome is required to fill in the proper si_code. Use page_get_flags to determine permission vs translation for user-only. Reviewed-by: Peter Maydell Signed-off-by: Richard Henderson --- linux-user/aarch64/cpu_loop.c | 24 +++++++++++++++++++++--- target/arm/tlb_helper.c | 15 +++++++++------ 2 files changed, 30 insertions(+), 9 deletions(-) diff --git a/linux-user/aarch64/cpu_loop.c b/linux-user/aarch64/cpu_loop.c index 42b9c15f53..4e43906e66 100644 --- a/linux-user/aarch64/cpu_loop.c +++ b/linux-user/aarch64/cpu_loop.c @@ -23,6 +23,7 @@ #include "cpu_loop-common.h" #include "qemu/guest-random.h" #include "hw/semihosting/common-semi.h" +#include "target/arm/syndrome.h" =20 #define get_user_code_u32(x, gaddr, env) \ ({ abi_long __r =3D get_user_u32((x), (gaddr)); \ @@ -76,7 +77,7 @@ void cpu_loop(CPUARMState *env) { CPUState *cs =3D env_cpu(env); - int trapnr; + int trapnr, ec, fsc; abi_long ret; target_siginfo_t info; =20 @@ -117,9 +118,26 @@ void cpu_loop(CPUARMState *env) case EXCP_DATA_ABORT: info.si_signo =3D TARGET_SIGSEGV; info.si_errno =3D 0; - /* XXX: check env->error_code */ - info.si_code =3D TARGET_SEGV_MAPERR; info._sifields._sigfault._addr =3D env->exception.vaddress; + + /* We should only arrive here with EC in {DATAABORT, INSNABORT= }. */ + ec =3D syn_get_ec(env->exception.syndrome); + assert(ec =3D=3D EC_DATAABORT || ec =3D=3D EC_INSNABORT); + + /* Both EC have the same format for FSC, or close enough. */ + fsc =3D extract32(env->exception.syndrome, 0, 6); + switch (fsc) { + case 0x04 ... 0x07: /* Translation fault, level {0-3} */ + info.si_code =3D TARGET_SEGV_MAPERR; + break; + case 0x09 ... 0x0b: /* Access flag fault, level {1-3} */ + case 0x0d ... 0x0f: /* Permission fault, level {1-3} */ + info.si_code =3D TARGET_SEGV_ACCERR; + break; + default: + g_assert_not_reached(); + } + queue_signal(env, info.si_signo, QEMU_SI_FAULT, &info); break; case EXCP_DEBUG: diff --git a/target/arm/tlb_helper.c b/target/arm/tlb_helper.c index df85079d9f..9609333cbd 100644 --- a/target/arm/tlb_helper.c +++ b/target/arm/tlb_helper.c @@ -154,21 +154,24 @@ bool arm_cpu_tlb_fill(CPUState *cs, vaddr address, in= t size, bool probe, uintptr_t retaddr) { ARMCPU *cpu =3D ARM_CPU(cs); + ARMMMUFaultInfo fi =3D {}; =20 #ifdef CONFIG_USER_ONLY - cpu->env.exception.vaddress =3D address; - if (access_type =3D=3D MMU_INST_FETCH) { - cs->exception_index =3D EXCP_PREFETCH_ABORT; + int flags =3D page_get_flags(useronly_clean_ptr(address)); + if (flags & PAGE_VALID) { + fi.type =3D ARMFault_Permission; } else { - cs->exception_index =3D EXCP_DATA_ABORT; + fi.type =3D ARMFault_Translation; } - cpu_loop_exit_restore(cs, retaddr); + + /* now we have a real cpu fault */ + cpu_restore_state(cs, retaddr, true); + arm_deliver_fault(cpu, address, access_type, mmu_idx, &fi); #else hwaddr phys_addr; target_ulong page_size; int prot, ret; MemTxAttrs attrs =3D {}; - ARMMMUFaultInfo fi =3D {}; ARMCacheAttrs cacheattrs =3D {}; =20 /* --=20 2.25.1