From nobody Sat May 18 16:46:56 2024 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=fail; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=fail(p=none dis=none) header.from=redhat.com ARC-Seal: i=1; a=rsa-sha256; t=1612352124; cv=none; d=zohomail.com; s=zohoarc; b=LdmGCzYPAxawUk5b/gPuuH5109AVBS+96CaLvgMd4B8zkxTkFlTfClBfpl2PsreuSrqxq+TOXRz5LmoccM9oR2TH4k/I4LieW5f4M82Xsg0cIc3HPoxBi8iyP6b+3gOcG6OtuwRXLnkyGSSWbtUHYxTIocxF1+zQk2KtWj9Mw/c= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1612352124; h=Content-Type:Content-Transfer-Encoding:Cc:Date:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:To; bh=D2VDvEnS2xCKN4NUJ24syzLKV9BPevgS0WWAz02x9zg=; b=FZeurQCAJFYK8scnBRhk6YaWKOEdvr96Inj+TM40X24CTc1bf6PndQPvEIcWST5hFogg84mJlfcJ8r07N9T8ofnXku3bJv26kpKimo80zg+vWA8BcSdVjaBvvetdEB1vDm4qen/eDJb9hBe16tIut5lCjDipVM9/g3ooVfDzfAU= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=fail; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=fail header.from= (p=none dis=none) header.from= Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1612352123994237.34218190598847; Wed, 3 Feb 2021 03:35:23 -0800 (PST) Received: from localhost ([::1]:39138 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1l7GRO-0003rM-Qg for importer@patchew.org; Wed, 03 Feb 2021 06:35:22 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]:55928) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1l7GP5-00022W-1s for qemu-devel@nongnu.org; Wed, 03 Feb 2021 06:32:59 -0500 Received: from us-smtp-delivery-124.mimecast.com ([216.205.24.124]:56828) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA1:256) (Exim 4.90_1) (envelope-from ) id 1l7GP1-0004uV-TA for qemu-devel@nongnu.org; Wed, 03 Feb 2021 06:32:58 -0500 Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-579-_WtZujvLOoyxJBLqlnLXjQ-1; Wed, 03 Feb 2021 06:32:53 -0500 Received: from smtp.corp.redhat.com (int-mx02.intmail.prod.int.phx2.redhat.com [10.5.11.12]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id 0B8808030B4; Wed, 3 Feb 2021 11:32:52 +0000 (UTC) Received: from thuth.com (ovpn-112-165.ams2.redhat.com [10.36.112.165]) by smtp.corp.redhat.com (Postfix) with ESMTP id 8E8FA60C66; Wed, 3 Feb 2021 11:32:50 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1612351975; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=D2VDvEnS2xCKN4NUJ24syzLKV9BPevgS0WWAz02x9zg=; b=PKPCDrmARsEbJJBd0ZASjcAzSZINYvpvOPVnLXLi484fSdJ4yTPcnXrr9Onk7/K6uK3DPg xcgqycG239jITLerszGs6hiwkvQo23ZRp0HFPAJu6E+2qmLqn2XuKBDiLb/oHiSXRDJk7r RQQkpGvWEamxsSqbZHrxp5DqKsC36xY= X-MC-Unique: _WtZujvLOoyxJBLqlnLXjQ-1 From: Thomas Huth To: qemu-devel@nongnu.org, =?UTF-8?q?Alex=20Benn=C3=A9e?= Subject: [PATCH 1/6] travis.yml: Move gprof/gcov test across to gitlab Date: Wed, 3 Feb 2021 12:32:38 +0100 Message-Id: <20210203113243.280883-2-thuth@redhat.com> In-Reply-To: <20210203113243.280883-1-thuth@redhat.com> References: <20210203113243.280883-1-thuth@redhat.com> MIME-Version: 1.0 X-Scanned-By: MIMEDefang 2.79 on 10.5.11.12 Authentication-Results: relay.mimecast.com; auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=thuth@redhat.com X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Received-SPF: pass client-ip=216.205.24.124; envelope-from=thuth@redhat.com; helo=us-smtp-delivery-124.mimecast.com X-Spam_score_int: -32 X-Spam_score: -3.3 X-Spam_bar: --- X-Spam_report: (-3.3 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.539, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_LOW=-0.7, RCVD_IN_MSPIKE_H3=0.001, RCVD_IN_MSPIKE_WL=0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= , Willian Rampazzo , Wainer dos Santos Moschetta Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: "Qemu-devel" X-ZohoMail-DKIM: fail (Header signature does not verify) From: Philippe Mathieu-Daud=C3=A9 Similarly to commit 8cdb2cef3f1, move the gprof/gcov test to GitLab. The coverage-summary.sh script is not Travis-CI specific, make it generic. Signed-off-by: Philippe Mathieu-Daud=C3=A9 Message-Id: <20201108204535.2319870-10-philmd@redhat.com> [thuth: Add gcovr and bsdmainutils which are required for the overage-summary.sh script to the ubuntu docker file] Signed-off-by: Thomas Huth --- .gitlab-ci.yml | 12 ++++++++++++ .travis.yml | 14 -------------- MAINTAINERS | 2 +- scripts/{travis =3D> ci}/coverage-summary.sh | 2 +- tests/docker/dockerfiles/ubuntu2004.docker | 2 ++ 5 files changed, 16 insertions(+), 16 deletions(-) rename scripts/{travis =3D> ci}/coverage-summary.sh (92%) diff --git a/.gitlab-ci.yml b/.gitlab-ci.yml index 7c0db64710..8b97b512bb 100644 --- a/.gitlab-ci.yml +++ b/.gitlab-ci.yml @@ -468,6 +468,18 @@ check-deprecated: MAKE_CHECK_ARGS: check-tcg allow_failure: true =20 +# gprof/gcov are GCC features +build-gprof-gcov: + <<: *native_build_job_definition + variables: + IMAGE: ubuntu2004 + CONFIGURE_ARGS: --enable-gprof --enable-gcov + MAKE_CHECK_ARGS: build-tcg + TARGETS: aarch64-softmmu mips64-softmmu ppc64-softmmu + riscv64-softmmu s390x-softmmu x86_64-softmmu + after_script: + - ${CI_PROJECT_DIR}/scripts/ci/coverage-summary.sh + build-oss-fuzz: <<: *native_build_job_definition variables: diff --git a/.travis.yml b/.travis.yml index 5f1dea873e..76b69f6de1 100644 --- a/.travis.yml +++ b/.travis.yml @@ -166,20 +166,6 @@ jobs: compiler: clang =20 =20 - # gprof/gcov are GCC features - - name: "GCC gprof/gcov" - dist: bionic - addons: - apt: - packages: - - ninja-build - env: - - CONFIG=3D"--enable-gprof --enable-gcov --disable-libssh - --target-list=3D${MAIN_SOFTMMU_TARGETS}" - after_success: - - ${SRC_DIR}/scripts/travis/coverage-summary.sh - - # Using newer GCC with sanitizers - name: "GCC9 with sanitizers (softmmu)" dist: bionic diff --git a/MAINTAINERS b/MAINTAINERS index bcd88668bc..f14a2e6eb5 100644 --- a/MAINTAINERS +++ b/MAINTAINERS @@ -3193,7 +3193,7 @@ R: Philippe Mathieu-Daud=C3=A9 S: Maintained F: .github/lockdown.yml F: .travis.yml -F: scripts/travis/ +F: scripts/ci/ F: .shippable.yml F: tests/docker/ F: tests/vm/ diff --git a/scripts/travis/coverage-summary.sh b/scripts/ci/coverage-summa= ry.sh similarity index 92% rename from scripts/travis/coverage-summary.sh rename to scripts/ci/coverage-summary.sh index d7086cf9ca..8d9fb4de40 100755 --- a/scripts/travis/coverage-summary.sh +++ b/scripts/ci/coverage-summary.sh @@ -3,7 +3,7 @@ # Author: Alex Benn=C3=A9e # # Summerise the state of code coverage with gcovr and tweak the output -# to be more sane on Travis hosts. As we expect to be executed on a +# to be more sane on CI runner. As we expect to be executed on a # throw away CI instance we do spam temp files all over the shop. You # most likely don't want to execute this script but just call gcovr # directly. See also "make coverage-report" diff --git a/tests/docker/dockerfiles/ubuntu2004.docker b/tests/docker/dock= erfiles/ubuntu2004.docker index 8519584d2b..9750016e51 100644 --- a/tests/docker/dockerfiles/ubuntu2004.docker +++ b/tests/docker/dockerfiles/ubuntu2004.docker @@ -1,8 +1,10 @@ FROM ubuntu:20.04 ENV PACKAGES flex bison \ + bsdmainutils \ ccache \ clang-10\ gcc \ + gcovr \ genisoimage \ gettext \ git \ --=20 2.27.0 From nobody Sat May 18 16:46:56 2024 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=fail; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=fail(p=none dis=none) header.from=redhat.com ARC-Seal: i=1; a=rsa-sha256; t=1612352328; cv=none; d=zohomail.com; s=zohoarc; b=RmGeYz1T6/K0gQi0/lzn5L3ZQbTMYhAmybm4mg1guyl7aqCmqlV+14+eqan8jvRs0TSRwbgxrrKvqDFoLPv9eWsyGtMdK8KQTfNeY+m+ykCMNtdKGKLepS1Uy2TNzK/jmYhbbXOM3ER+uRh4bgmOTUA3xu1VoTOZpooX8FNM19w= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1612352328; h=Content-Type:Content-Transfer-Encoding:Cc:Date:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:To; bh=7mce3RsmzlQLob1lb4XH87x4LTgKZJZSJVhQCefRp0M=; b=J06B/dsQr5d46EYt+jB6DFRfD1ly62spcFGW37mB03Wk8RRHoZ+nNLOnGcWhT1lcahzv0pSUlJMBTEfWBLWs8UDlAweN7FIkQKUzTruxjN8gR+CHR8wMo/4BrWi4ULjr/2t2WnEJ0ezNRO9b9Btn8deJreYhoHHS1uybOEh6Luk= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=fail; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=fail header.from= (p=none dis=none) header.from= Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 161235232836645.1257689966792; Wed, 3 Feb 2021 03:38:48 -0800 (PST) Received: from localhost ([::1]:47024 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1l7GUh-0007Hp-2g for importer@patchew.org; Wed, 03 Feb 2021 06:38:47 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]:55988) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1l7GPE-00029s-Tm for qemu-devel@nongnu.org; Wed, 03 Feb 2021 06:33:12 -0500 Received: from us-smtp-delivery-124.mimecast.com ([216.205.24.124]:39401) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA1:256) (Exim 4.90_1) (envelope-from ) id 1l7GP7-0004x9-BF for qemu-devel@nongnu.org; Wed, 03 Feb 2021 06:33:07 -0500 Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-229-_eqqbsJRO_K7O4opYBntug-1; Wed, 03 Feb 2021 06:32:57 -0500 Received: from smtp.corp.redhat.com (int-mx02.intmail.prod.int.phx2.redhat.com [10.5.11.12]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id 4D33619611A0; Wed, 3 Feb 2021 11:32:56 +0000 (UTC) Received: from thuth.com (ovpn-112-165.ams2.redhat.com [10.36.112.165]) by smtp.corp.redhat.com (Postfix) with ESMTP id 68B5460C66; Wed, 3 Feb 2021 11:32:52 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1612351980; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=7mce3RsmzlQLob1lb4XH87x4LTgKZJZSJVhQCefRp0M=; b=ICWtFeyJQrxn2z0eBttyUQfm6J/4HsyAA43J1JW5uZrfsWACFkxxEwbfH1PXLVZqEFfxQn 0IWZ+p5kPu15N1zgDMrczwn9dR9E0pbu2K5g5XzoRHhjGWxIEYxYhmlmjsy1GHAEDxnefk Q98ydtlV4q7mVRkk0nYaY+LLxrq7txE= X-MC-Unique: _eqqbsJRO_K7O4opYBntug-1 From: Thomas Huth To: qemu-devel@nongnu.org, =?UTF-8?q?Alex=20Benn=C3=A9e?= Subject: [PATCH 2/6] travis.yml: Move the -fsanitize=undefined test to the gitlab-CI Date: Wed, 3 Feb 2021 12:32:39 +0100 Message-Id: <20210203113243.280883-3-thuth@redhat.com> In-Reply-To: <20210203113243.280883-1-thuth@redhat.com> References: <20210203113243.280883-1-thuth@redhat.com> MIME-Version: 1.0 X-Scanned-By: MIMEDefang 2.79 on 10.5.11.12 Authentication-Results: relay.mimecast.com; auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=thuth@redhat.com X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Transfer-Encoding: quoted-printable Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Received-SPF: pass client-ip=216.205.24.124; envelope-from=thuth@redhat.com; helo=us-smtp-delivery-124.mimecast.com X-Spam_score_int: -32 X-Spam_score: -3.3 X-Spam_bar: --- X-Spam_report: (-3.3 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.539, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_LOW=-0.7, RCVD_IN_MSPIKE_H3=0.001, RCVD_IN_MSPIKE_WL=0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= , Willian Rampazzo , Wainer dos Santos Moschetta Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: "Qemu-devel" X-ZohoMail-DKIM: fail (Header signature does not verify) Content-Type: text/plain; charset="utf-8" Add it to the existing Clang job and also add a job that covers the linux-user code with this compiler flag. To make sure that the detected problems are not simply ignored, let's also use "-fno-sanitize-recover=3D..= ." now instead. Signed-off-by: Thomas Huth --- .gitlab-ci.yml | 13 +++++++++++-- .travis.yml | 27 --------------------------- 2 files changed, 11 insertions(+), 29 deletions(-) diff --git a/.gitlab-ci.yml b/.gitlab-ci.yml index 8b97b512bb..41e11b41e4 100644 --- a/.gitlab-ci.yml +++ b/.gitlab-ci.yml @@ -433,13 +433,22 @@ build-some-softmmu-plugins: TARGETS: xtensa-softmmu arm-softmmu aarch64-softmmu alpha-softmmu MAKE_CHECK_ARGS: check-tcg =20 -build-clang: +clang-system: <<: *native_build_job_definition variables: IMAGE: fedora CONFIGURE_ARGS: --cc=3Dclang --cxx=3Dclang++ + --extra-cflags=3D-fno-sanitize-recover=3Dundefined TARGETS: alpha-softmmu arm-softmmu m68k-softmmu mips64-softmmu - ppc-softmmu s390x-softmmu arm-linux-user + ppc-softmmu s390x-softmmu + MAKE_CHECK_ARGS: check-qtest check-block check-tcg + +clang-user: + <<: *native_build_job_definition + variables: + IMAGE: fedora + CONFIGURE_ARGS: --cc=3Dclang --cxx=3Dclang++ --disable-system + --extra-cflags=3D-fno-sanitize-recover=3Dundefined MAKE_CHECK_ARGS: check =20 # These targets are on the way out diff --git a/.travis.yml b/.travis.yml index 76b69f6de1..d1e9016da5 100644 --- a/.travis.yml +++ b/.travis.yml @@ -139,33 +139,6 @@ jobs: - CACHE_NAME=3D"${TRAVIS_BRANCH}-linux-gcc-default" =20 =20 - # Test with Clang for compile portability (Travis uses clang-5.0) - - name: "Clang (user)" - env: - - CONFIG=3D"--disable-system --host-cc=3Dclang --cxx=3Dclang++" - - CACHE_NAME=3D"${TRAVIS_BRANCH}-linux-clang-default" - compiler: clang - - - - name: "Clang (main-softmmu)" - env: - - CONFIG=3D"--target-list=3D${MAIN_SOFTMMU_TARGETS} - --host-cc=3Dclang --cxx=3Dclang++" - - CACHE_NAME=3D"${TRAVIS_BRANCH}-linux-clang-sanitize" - compiler: clang - before_script: - - mkdir -p ${BUILD_DIR} && cd ${BUILD_DIR} - - ${SRC_DIR}/configure ${CONFIG} --extra-cflags=3D"-fsanitize=3Dun= defined -Werror" || { cat config.log meson-logs/meson-log.txt && exit 1; } - - - - name: "Clang (other-softmmu)" - env: - - CONFIG=3D"--disable-user --target-list-exclude=3D${MAIN_SOFTMMU_= TARGETS} - --host-cc=3Dclang --cxx=3Dclang++" - - CACHE_NAME=3D"${TRAVIS_BRANCH}-linux-clang-default" - compiler: clang - - # Using newer GCC with sanitizers - name: "GCC9 with sanitizers (softmmu)" dist: bionic --=20 2.27.0 From nobody Sat May 18 16:46:56 2024 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=fail; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=fail(p=none dis=none) header.from=redhat.com ARC-Seal: i=1; a=rsa-sha256; t=1612352142; cv=none; d=zohomail.com; s=zohoarc; b=Ya+S3j+QYw7hjny1ZOiiAieILyWIV+p0jLFdEKBme46P1z/9gkYJ1tVZSt/Z6tZXJTn+J3jqe3lr0TZ3igzHR5vFJohhhi968OuvKFUY9iaRxO7e9/hZtROP3K8njLvH2aT15RymTuwDW8APaWb67SKeuHmDuqEA7zWaw+iYhdg= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1612352142; h=Content-Type:Content-Transfer-Encoding:Cc:Date:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:To; bh=5PqkrUYgWCNpCUhNyeniJvYeG5+YBw0RxAOY6uRLjQo=; b=OyvrVM8TpRhHa0bOErpliIe1V24qu0Soi7K8JRDnudX2LtvxKmsRe47jaGnh1QfhnFmUL4qjOBmdfmDtG7gOFV5gAUueigsnF10HtPYpZJcubaFZ0lTwH6CsWC5vjo5fqoxDD8dc/ia9guYrBo0U4cR2/QBKhBDINzW0RNoHT9U= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=fail; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=fail header.from= (p=none dis=none) header.from= Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1612352142079868.7763176669448; Wed, 3 Feb 2021 03:35:42 -0800 (PST) Received: from localhost ([::1]:39284 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1l7GRg-0003v7-IW for importer@patchew.org; Wed, 03 Feb 2021 06:35:40 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]:55954) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1l7GP8-00028i-Qo for qemu-devel@nongnu.org; Wed, 03 Feb 2021 06:33:02 -0500 Received: from us-smtp-delivery-124.mimecast.com ([63.128.21.124]:32519) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA1:256) (Exim 4.90_1) (envelope-from ) id 1l7GP7-0004x7-9K for qemu-devel@nongnu.org; Wed, 03 Feb 2021 06:33:02 -0500 Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-264-80hp57PHMVmplmOiRMPo3Q-1; Wed, 03 Feb 2021 06:32:59 -0500 Received: from smtp.corp.redhat.com (int-mx02.intmail.prod.int.phx2.redhat.com [10.5.11.12]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id 15CDF107ACE6; Wed, 3 Feb 2021 11:32:58 +0000 (UTC) Received: from thuth.com (ovpn-112-165.ams2.redhat.com [10.36.112.165]) by smtp.corp.redhat.com (Postfix) with ESMTP id 9951460C66; Wed, 3 Feb 2021 11:32:56 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1612351980; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=5PqkrUYgWCNpCUhNyeniJvYeG5+YBw0RxAOY6uRLjQo=; b=fAJSuHhpEzroDDXS5YG9Hr9FI1UKOksfwtKDEkfVTRJU3UFCDvdYavLfq26/QkunOVlt6+ KdHx6vea2UI5Qh9Or/PGfUb+36i/NFmjQWuFqdKpHYZ6XBo5cvpAosAR5BCSgelVlZD7Ob cflZTEJDp/MUfPe9JXg+Pxm/RtzOYr0= X-MC-Unique: 80hp57PHMVmplmOiRMPo3Q-1 From: Thomas Huth To: qemu-devel@nongnu.org, =?UTF-8?q?Alex=20Benn=C3=A9e?= Subject: [PATCH 3/6] travis.yml: Move the --enable-modules test to the gitlab-CI Date: Wed, 3 Feb 2021 12:32:40 +0100 Message-Id: <20210203113243.280883-4-thuth@redhat.com> In-Reply-To: <20210203113243.280883-1-thuth@redhat.com> References: <20210203113243.280883-1-thuth@redhat.com> MIME-Version: 1.0 X-Scanned-By: MIMEDefang 2.79 on 10.5.11.12 Authentication-Results: relay.mimecast.com; auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=thuth@redhat.com X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Transfer-Encoding: quoted-printable Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Received-SPF: pass client-ip=63.128.21.124; envelope-from=thuth@redhat.com; helo=us-smtp-delivery-124.mimecast.com X-Spam_score_int: -32 X-Spam_score: -3.3 X-Spam_bar: --- X-Spam_report: (-3.3 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.539, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_LOW=-0.7, RCVD_IN_MSPIKE_H4=0.001, RCVD_IN_MSPIKE_WL=0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= , Willian Rampazzo , Wainer dos Santos Moschetta Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: "Qemu-devel" X-ZohoMail-DKIM: fail (Header signature does not verify) Content-Type: text/plain; charset="utf-8" Simply add the flag to an existing job, no need for yet another job here. Signed-off-by: Thomas Huth Reviewed-by: Wainer dos Santos Moschetta --- .gitlab-ci.yml | 1 + .travis.yml | 6 ------ 2 files changed, 1 insertion(+), 6 deletions(-) diff --git a/.gitlab-ci.yml b/.gitlab-ci.yml index 41e11b41e4..4654798523 100644 --- a/.gitlab-ci.yml +++ b/.gitlab-ci.yml @@ -223,6 +223,7 @@ build-system-centos: variables: IMAGE: centos8 CONFIGURE_ARGS: --disable-nettle --enable-gcrypt --enable-fdt=3Dsystem + --enable-modules TARGETS: ppc64-softmmu or1k-softmmu s390x-softmmu x86_64-softmmu rx-softmmu sh4-softmmu nios2-softmmu MAKE_CHECK_ARGS: check-build diff --git a/.travis.yml b/.travis.yml index d1e9016da5..45dd017420 100644 --- a/.travis.yml +++ b/.travis.yml @@ -132,12 +132,6 @@ jobs: - CONFIG=3D"--enable-debug-tcg --disable-system" - CACHE_NAME=3D"${TRAVIS_BRANCH}-linux-gcc-debug-tcg" =20 - # Module builds are mostly of interest to major distros - - name: "GCC modules (main-softmmu)" - env: - - CONFIG=3D"--enable-modules --target-list=3D${MAIN_SOFTMMU_TARGET= S}" - - CACHE_NAME=3D"${TRAVIS_BRANCH}-linux-gcc-default" - =20 # Using newer GCC with sanitizers - name: "GCC9 with sanitizers (softmmu)" --=20 2.27.0 From nobody Sat May 18 16:46:56 2024 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=fail; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=fail(p=none dis=none) header.from=redhat.com ARC-Seal: i=1; a=rsa-sha256; t=1612352332; cv=none; d=zohomail.com; s=zohoarc; b=MCk6eYmZYQtSKYXU2Xuv0RbMTHLPnNKeSbaWu+qMRj3N+Bp27A3jbi39E+Tnbm5hBM4GAT43eShYUQ+7v75i9qNTD8QixBOX/VkWnaTAFas1rFiho1Ols2B9rlPr5ZdPjrlQOaB4yw8If5PxpnWjha/mtbs2KiQX4mASZs41YRA= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1612352332; h=Content-Type:Content-Transfer-Encoding:Cc:Date:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:To; bh=pLdaRt8mrH9RpzaX7ahiAaTtfEwMY8jf0H4kriCFESU=; b=HmQ2BKfRZv/v4BR14gEQs0Be3uXirkaNSSbMdjCRUWytWOVf9TG+jZyRyMl5bBKUSeYP1zo69vBsqLSpPbyWhhmczJsWWDYsDe0APYtWXTlP7e1COs3+HScS5jRs+tEUC5+iuvDA66ET/jGzqiBFqdeH2Nus26/T4gegWYc4vmM= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=fail; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=fail header.from= (p=none dis=none) header.from= Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1612352332908407.4134340365789; Wed, 3 Feb 2021 03:38:52 -0800 (PST) Received: from localhost ([::1]:47502 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1l7GUl-0007Uh-QK for importer@patchew.org; Wed, 03 Feb 2021 06:38:51 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]:56014) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1l7GPG-0002A2-MD for qemu-devel@nongnu.org; Wed, 03 Feb 2021 06:33:12 -0500 Received: from us-smtp-delivery-124.mimecast.com ([63.128.21.124]:37803) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA1:256) (Exim 4.90_1) (envelope-from ) id 1l7GPD-0004yb-IN for qemu-devel@nongnu.org; Wed, 03 Feb 2021 06:33:10 -0500 Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-354-1SyRhlD0OY-QZgXgcDsQuA-1; Wed, 03 Feb 2021 06:33:00 -0500 Received: from smtp.corp.redhat.com (int-mx02.intmail.prod.int.phx2.redhat.com [10.5.11.12]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id F3988100C660; Wed, 3 Feb 2021 11:32:59 +0000 (UTC) Received: from thuth.com (ovpn-112-165.ams2.redhat.com [10.36.112.165]) by smtp.corp.redhat.com (Postfix) with ESMTP id 72BED60C66; Wed, 3 Feb 2021 11:32:58 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1612351985; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=pLdaRt8mrH9RpzaX7ahiAaTtfEwMY8jf0H4kriCFESU=; b=PjdTKHgliyM/cwLH8ED3hfK25+9eKHC6DdiCTPE1YD6QQJKZyGzyFJYwxJeSeT8cte+e5S zvK2NzjWbE02ylqkwj1gd0ChqQUbiAipu1B7Jg5JIvt3ZeW1X3zznWNVh8SIzd9VzUCbgy s+bgbFlerrwPBbySIKMRqKipdbLxBfk= X-MC-Unique: 1SyRhlD0OY-QZgXgcDsQuA-1 From: Thomas Huth To: qemu-devel@nongnu.org, =?UTF-8?q?Alex=20Benn=C3=A9e?= Subject: [PATCH 4/6] travis.yml: Remove the --enable-debug jobs Date: Wed, 3 Feb 2021 12:32:41 +0100 Message-Id: <20210203113243.280883-5-thuth@redhat.com> In-Reply-To: <20210203113243.280883-1-thuth@redhat.com> References: <20210203113243.280883-1-thuth@redhat.com> MIME-Version: 1.0 X-Scanned-By: MIMEDefang 2.79 on 10.5.11.12 Authentication-Results: relay.mimecast.com; auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=thuth@redhat.com X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Transfer-Encoding: quoted-printable Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Received-SPF: pass client-ip=63.128.21.124; envelope-from=thuth@redhat.com; helo=us-smtp-delivery-124.mimecast.com X-Spam_score_int: -32 X-Spam_score: -3.3 X-Spam_bar: --- X-Spam_report: (-3.3 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.539, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_LOW=-0.7, RCVD_IN_MSPIKE_H4=0.001, RCVD_IN_MSPIKE_WL=0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= , Willian Rampazzo , Wainer dos Santos Moschetta Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: "Qemu-devel" X-ZohoMail-DKIM: fail (Header signature does not verify) Content-Type: text/plain; charset="utf-8" We already have such jobs in the gitlab-CI ("build-some-softmmu" and "build-user-plugins"), so we can simply drop these from the Travis-CI. Signed-off-by: Thomas Huth --- .travis.yml | 12 ------------ 1 file changed, 12 deletions(-) diff --git a/.travis.yml b/.travis.yml index 45dd017420..b3fc72f561 100644 --- a/.travis.yml +++ b/.travis.yml @@ -119,18 +119,6 @@ after_script: =20 jobs: include: - # --enable-debug implies --enable-debug-tcg, also runs quite a bit slo= wer - - name: "GCC debug (main-softmmu)" - env: - - CONFIG=3D"--enable-debug --target-list=3D${MAIN_SOFTMMU_TARGETS}" - - CACHE_NAME=3D"${TRAVIS_BRANCH}-linux-gcc-debug" - - - # TCG debug can be run just on its own and is mostly agnostic to user/= softmmu distinctions - - name: "GCC debug (user)" - env: - - CONFIG=3D"--enable-debug-tcg --disable-system" - - CACHE_NAME=3D"${TRAVIS_BRANCH}-linux-gcc-debug-tcg" =20 =20 # Using newer GCC with sanitizers --=20 2.27.0 From nobody Sat May 18 16:46:56 2024 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=fail; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=fail(p=none dis=none) header.from=redhat.com ARC-Seal: i=1; a=rsa-sha256; t=1612352264; cv=none; d=zohomail.com; s=zohoarc; b=G+EnsoWEL+itkRPsoSGgjEvtqzwjuE77qWv5MC7eFxrMd9nNVtBaiTffEPUGxYNrfAgqch+mZqAuMvFJs+L4Ry0zMRZWj7nLIY3CNB3t7rfPa8ktaBUDmpqrpN2TqHRL5uwgMt8CVdxkCJ+jPWMOUFUJINAsa/P/NYkLMsfl/uY= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1612352264; h=Content-Type:Content-Transfer-Encoding:Cc:Date:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:To; bh=C4hQUb8LRr5GzXRAxouelpRpskguvPexMwb34kItEM8=; b=iC5a4nfiFCAlvWYq1bbG5Ur9GfphIoxA/Ys7hMFF2KNE+mKdmJt4ao5iucVbDs3aIceLnrqnN/NNhUsri9FFUZTz3foNXrIaUn9pl5TWnQrusUc/MycoicNXfbUBQ6IbaJcIlTp9b9G/lguH6GLrSVpOWjTGB8zjwRMbMH5NU70= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=fail; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=fail header.from= (p=none dis=none) header.from= Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1612352264164593.2779524327048; Wed, 3 Feb 2021 03:37:44 -0800 (PST) Received: from localhost ([::1]:43592 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1l7GTf-0005pf-2P for importer@patchew.org; Wed, 03 Feb 2021 06:37:43 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]:56050) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1l7GPR-0002Df-VM for qemu-devel@nongnu.org; Wed, 03 Feb 2021 06:33:22 -0500 Received: from us-smtp-delivery-124.mimecast.com ([63.128.21.124]:40244) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA1:256) (Exim 4.90_1) (envelope-from ) id 1l7GPI-00050i-I6 for qemu-devel@nongnu.org; Wed, 03 Feb 2021 06:33:15 -0500 Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-458-5G0n5M4uP7O-3wQ3r1u__A-1; Wed, 03 Feb 2021 06:33:03 -0500 Received: from smtp.corp.redhat.com (int-mx02.intmail.prod.int.phx2.redhat.com [10.5.11.12]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id D5B7B107ACE4; Wed, 3 Feb 2021 11:33:01 +0000 (UTC) Received: from thuth.com (ovpn-112-165.ams2.redhat.com [10.36.112.165]) by smtp.corp.redhat.com (Postfix) with ESMTP id 65D2C60C66; Wed, 3 Feb 2021 11:33:00 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1612351991; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=C4hQUb8LRr5GzXRAxouelpRpskguvPexMwb34kItEM8=; b=ZgydrFin+2j9nITCC6aRkqOGuaxMGFD/tswDt6e2sqfq/l5b0Ik8tGpv9zMR/aowBHdUpo uadC5wnZ+eZcnbc7VDE7V8tvxZoRAEE5YJ9gjsW7NMH7KAYJsASu9jwcjWZmP79n+ZmO2W ybFlKT5KCNg/OErVOq3lzDY6OTLqB+8= X-MC-Unique: 5G0n5M4uP7O-3wQ3r1u__A-1 From: Thomas Huth To: qemu-devel@nongnu.org, =?UTF-8?q?Alex=20Benn=C3=A9e?= Subject: [PATCH 5/6] target/s390x/arch_dump: Fixes for the name field in the PT_NOTE section Date: Wed, 3 Feb 2021 12:32:42 +0100 Message-Id: <20210203113243.280883-6-thuth@redhat.com> In-Reply-To: <20210203113243.280883-1-thuth@redhat.com> References: <20210203113243.280883-1-thuth@redhat.com> MIME-Version: 1.0 X-Scanned-By: MIMEDefang 2.79 on 10.5.11.12 Authentication-Results: relay.mimecast.com; auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=thuth@redhat.com X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Received-SPF: pass client-ip=63.128.21.124; envelope-from=thuth@redhat.com; helo=us-smtp-delivery-124.mimecast.com X-Spam_score_int: -32 X-Spam_score: -3.3 X-Spam_bar: --- X-Spam_report: (-3.3 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.539, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_LOW=-0.7, RCVD_IN_MSPIKE_H4=0.001, RCVD_IN_MSPIKE_WL=0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= , Willian Rampazzo , Wainer dos Santos Moschetta Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: "Qemu-devel" X-ZohoMail-DKIM: fail (Header signature does not verify) According to the "ELF-64 Object File Format" specification: "The first word in the entry, namesz, identifies the length, in bytes, of a name identifying the entry=E2=80=99s owner or originator. The = name field contains a null-terminated string, with padding as necessary to ensure 8- byte alignment for the descriptor field. The length does not include the terminating null or the padding." So we should not include the terminating NUL in the length field here. Also there is a compiler warning with GCC 9.3 when compiling with the -fsanitize=3Dthread compiler flag: In function 'strncpy', inlined from 's390x_write_elf64_notes' at ../target/s390x/arch_dump.c:2= 19:9: /usr/include/x86_64-linux-gnu/bits/string_fortified.h:106:10: error: '__builtin_strncpy' specified bound 8 equals destination size [-Werror=3Dstringop-truncation] Since the name should always be NUL-terminated, we can simply decrease the size of the strncpy by one here to silence this warning. And while we're at it, also add an assert() to make sure that the provided names always fit the size field (which is fine for the current callers, the function is called once with "CORE" and once with "LINUX" as a name). Signed-off-by: Thomas Huth --- target/s390x/arch_dump.c | 6 ++++-- 1 file changed, 4 insertions(+), 2 deletions(-) diff --git a/target/s390x/arch_dump.c b/target/s390x/arch_dump.c index 50fa0ae4b6..20c3a09707 100644 --- a/target/s390x/arch_dump.c +++ b/target/s390x/arch_dump.c @@ -212,11 +212,13 @@ static int s390x_write_elf64_notes(const char *note_n= ame, int note_size; int ret =3D -1; =20 + assert(strlen(note_name) < sizeof(note.name)); + for (nf =3D funcs; nf->note_contents_func; nf++) { memset(¬e, 0, sizeof(note)); - note.hdr.n_namesz =3D cpu_to_be32(strlen(note_name) + 1); + note.hdr.n_namesz =3D cpu_to_be32(strlen(note_name)); note.hdr.n_descsz =3D cpu_to_be32(nf->contents_size); - strncpy(note.name, note_name, sizeof(note.name)); + strncpy(note.name, note_name, sizeof(note.name) - 1); (*nf->note_contents_func)(¬e, cpu, id); =20 note_size =3D sizeof(note) - sizeof(note.contents) + nf->contents_= size; --=20 2.27.0 From nobody Sat May 18 16:46:56 2024 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=fail; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=fail(p=none dis=none) header.from=redhat.com ARC-Seal: i=1; a=rsa-sha256; t=1612352453; cv=none; d=zohomail.com; s=zohoarc; b=YgMBae8Fen+ejsuIPK4p9LBeGJDkSOuoJWHKNMVQjvxd8fVgKQmQ8CKDO5ePJGhmsGXozq7f4tR75+4rM6VmZcdvEBB5379v6L6T5R4nz9EVyy9IaNesaA+1Ag4WbLwo5jjz/YTsHGGwtZmBLDAzOVbKQVt5A1vZnyIgPGQZciA= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1612352453; h=Content-Type:Content-Transfer-Encoding:Cc:Date:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:To; bh=/ambayBEhm9Y1rpHdfh39O4J+a1kFG8HGBWxjWfL80I=; b=idw3t3zkhHss3J+m5YPqeUGEOcpZQDAdB744kLZFSgyDtvB92Heme1G2sP7aQHQT1YQftSQOzpGv796UOi/Aiu9gP7WNi6Mmr71PwHTiQhXIkMs96JjUq0ZWMhElOHHC63gsIArycwMgKrtQhbRJ5ju3sNXpzVuBIPQNTWGjjso= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=fail; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=fail header.from= (p=none dis=none) header.from= Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1612352453449856.9849765916964; Wed, 3 Feb 2021 03:40:53 -0800 (PST) Received: from localhost ([::1]:55162 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1l7GWi-0002AK-CE for importer@patchew.org; Wed, 03 Feb 2021 06:40:52 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]:56016) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1l7GPG-0002A4-Vb for qemu-devel@nongnu.org; Wed, 03 Feb 2021 06:33:12 -0500 Received: from us-smtp-delivery-124.mimecast.com ([216.205.24.124]:41697) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA1:256) (Exim 4.90_1) (envelope-from ) id 1l7GPD-0004ym-Iy for qemu-devel@nongnu.org; Wed, 03 Feb 2021 06:33:10 -0500 Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-453-COIMXomPNHa1J7AUwL5eQA-1; Wed, 03 Feb 2021 06:33:04 -0500 Received: from smtp.corp.redhat.com (int-mx02.intmail.prod.int.phx2.redhat.com [10.5.11.12]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id AA25C809DCC; Wed, 3 Feb 2021 11:33:03 +0000 (UTC) Received: from thuth.com (ovpn-112-165.ams2.redhat.com [10.36.112.165]) by smtp.corp.redhat.com (Postfix) with ESMTP id 3F40960C66; Wed, 3 Feb 2021 11:33:02 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1612351986; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=/ambayBEhm9Y1rpHdfh39O4J+a1kFG8HGBWxjWfL80I=; b=UiUIhaZbEMzO3BWZzxGwst8X8H3LhxIruMhVVTrWKFbuoobi+lG3huJfcE6npQ1K/AUPF9 zh8nKl1PDwpDJvWEcxLQfLQnLGPoScGP/krMld4HzVdIYdgwN/h5wgj9wbveqscugm5u4k fFWYoZdH0epEnSsLQJa9GnKb7TX+YkA= X-MC-Unique: COIMXomPNHa1J7AUwL5eQA-1 From: Thomas Huth To: qemu-devel@nongnu.org, =?UTF-8?q?Alex=20Benn=C3=A9e?= Subject: [PATCH 6/6] travis.yml: Move the -fsanitize=thread compile-testing to the gitlab-CI Date: Wed, 3 Feb 2021 12:32:43 +0100 Message-Id: <20210203113243.280883-7-thuth@redhat.com> In-Reply-To: <20210203113243.280883-1-thuth@redhat.com> References: <20210203113243.280883-1-thuth@redhat.com> MIME-Version: 1.0 X-Scanned-By: MIMEDefang 2.79 on 10.5.11.12 Authentication-Results: relay.mimecast.com; auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=thuth@redhat.com X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Transfer-Encoding: quoted-printable Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Received-SPF: pass client-ip=216.205.24.124; envelope-from=thuth@redhat.com; helo=us-smtp-delivery-124.mimecast.com X-Spam_score_int: -32 X-Spam_score: -3.3 X-Spam_bar: --- X-Spam_report: (-3.3 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.539, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_LOW=-0.7, RCVD_IN_MSPIKE_H3=0.001, RCVD_IN_MSPIKE_WL=0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= , Willian Rampazzo , Wainer dos Santos Moschetta Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: "Qemu-devel" X-ZohoMail-DKIM: fail (Header signature does not verify) Content-Type: text/plain; charset="utf-8" It's only about compile-testing (there is too much noise when running the tests), so let's simply add the -fsanitize=3Dthread flag to a job that only compiles the sources. The "build-gprof-gcov" seems to be a good candidate. Signed-off-by: Thomas Huth Reviewed-by: Wainer dos Santos Moschetta --- .gitlab-ci.yml | 1 + .travis.yml | 51 -------------------------------------------------- 2 files changed, 1 insertion(+), 51 deletions(-) diff --git a/.gitlab-ci.yml b/.gitlab-ci.yml index 4654798523..e5c86e38c4 100644 --- a/.gitlab-ci.yml +++ b/.gitlab-ci.yml @@ -484,6 +484,7 @@ build-gprof-gcov: variables: IMAGE: ubuntu2004 CONFIGURE_ARGS: --enable-gprof --enable-gcov + --extra-cflags=3D-fsanitize=3Dthread MAKE_CHECK_ARGS: build-tcg TARGETS: aarch64-softmmu mips64-softmmu ppc64-softmmu riscv64-softmmu s390x-softmmu x86_64-softmmu diff --git a/.travis.yml b/.travis.yml index b3fc72f561..18e62f282f 100644 --- a/.travis.yml +++ b/.travis.yml @@ -120,57 +120,6 @@ after_script: jobs: include: =20 - - # Using newer GCC with sanitizers - - name: "GCC9 with sanitizers (softmmu)" - dist: bionic - addons: - apt: - update: true - sources: - # PPAs for newer toolchains - - ubuntu-toolchain-r-test - packages: - # Extra toolchains - - gcc-9 - - g++-9 - # Build dependencies - - libaio-dev - - libattr1-dev - - libbrlapi-dev - - libcap-ng-dev - - libgnutls28-dev - - libgtk-3-dev - - libiscsi-dev - - liblttng-ust-dev - - libnfs-dev - - libncurses5-dev - - libnss3-dev - - libpixman-1-dev - - libpng-dev - - librados-dev - - libsdl2-dev - - libsdl2-image-dev - - libseccomp-dev - - libspice-protocol-dev - - libspice-server-dev - - liburcu-dev - - libusb-1.0-0-dev - - libvte-2.91-dev - - ninja-build - - sparse - - uuid-dev - language: generic - compiler: none - env: - - COMPILER_NAME=3Dgcc CXX=3Dg++-9 CC=3Dgcc-9 - - CONFIG=3D"--cc=3Dgcc-9 --cxx=3Dg++-9 --disable-linux-user" - - TEST_CMD=3D"" - before_script: - - mkdir -p ${BUILD_DIR} && cd ${BUILD_DIR} - - ${SRC_DIR}/configure ${CONFIG} --extra-cflags=3D"-g3 -O0 -fsanit= ize=3Dthread" || { cat config.log meson-logs/meson-log.txt && exit 1; } - - - name: "[aarch64] GCC check-tcg" arch: arm64 dist: focal --=20 2.27.0