From nobody Tue Apr 15 09:07:49 2025 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass(p=none dis=none) header.from=redhat.com ARC-Seal: i=1; a=rsa-sha256; t=1612285865; cv=none; d=zohomail.com; s=zohoarc; b=GBB8fVHoWydESrBiwmjCMiHobGQL7oP0PcblM6QSw2AgHprICWH7V+ZAfCa+D7I2O78R6SC3Vy0JFPV0+khn5FaupkIqt62ooQjMLLI4RMNfuLtUbVdt460DcxAQ937KHa9HKPkGYHT3ZIGkoYXx6Q1yEkPMFJCbaLSC/Cpa+J0= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1612285865; h=Content-Type:Content-Transfer-Encoding:Cc:Date:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:To; bh=M/bBH8B3CNQFmyPeGz7p1yGlkAwZeNlSvc8DtMTEvA4=; b=hAbaBzQBcvaO3Ak8cADjVMDP4KY6iByfStt8UuyZc0sGE6qlBv0YSarl5/Fs4dE2eqhmc3ZleLwSvqPk+a7ezoboAUxeHewbBuRvcjSj9FPYKyQ0FvNwr/yJYeDNYVoLi3CaQTsHcdDdCZZrZ59S43o6S63ZRzjVIGEGRRb187w= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass header.from= (p=none dis=none) header.from= Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1612285865751462.72073714131056; Tue, 2 Feb 2021 09:11:05 -0800 (PST) Received: from localhost ([::1]:58282 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1l6zCi-000775-De for importer@patchew.org; Tue, 02 Feb 2021 12:11:04 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]:52602) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1l6yYQ-0005cX-5D for qemu-devel@nongnu.org; Tue, 02 Feb 2021 11:29:26 -0500 Received: from us-smtp-delivery-124.mimecast.com ([216.205.24.124]:60087) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA1:256) (Exim 4.90_1) (envelope-from ) id 1l6yYO-0000LR-BX for qemu-devel@nongnu.org; Tue, 02 Feb 2021 11:29:25 -0500 Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-243-QFydhp6TOqSn2NArN5XyxQ-1; Tue, 02 Feb 2021 11:29:14 -0500 Received: from smtp.corp.redhat.com (int-mx05.intmail.prod.int.phx2.redhat.com [10.5.11.15]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id AB53D1083E9C; Tue, 2 Feb 2021 16:29:13 +0000 (UTC) Received: from merkur.fritz.box (ovpn-112-19.ams2.redhat.com [10.36.112.19]) by smtp.corp.redhat.com (Postfix) with ESMTP id 1F4065D749; Tue, 2 Feb 2021 16:29:10 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1612283363; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=M/bBH8B3CNQFmyPeGz7p1yGlkAwZeNlSvc8DtMTEvA4=; b=W5JO+dxoKQqEk56p+iYSPg7vA7efGUgFz9syMDo/9ZqHy/O6GoBZ2jLdoUVgpkhzV4Qfve 82PYu/iyGfHVRixHfVaJnuqhMstHnT/gBi2vFISSei5Cn3SoESUHHMYJNebnpX0Gk+sarc 13vMe5sDvqugLiSwbkV5td+y93b9G9w= X-MC-Unique: QFydhp6TOqSn2NArN5XyxQ-1 From: Kevin Wolf To: qemu-block@nongnu.org Subject: [PULL v2 08/10] block/nvme: Properly display doorbell stride length in trace event Date: Tue, 2 Feb 2021 17:28:32 +0100 Message-Id: <20210202162834.269789-9-kwolf@redhat.com> In-Reply-To: <20210202162834.269789-1-kwolf@redhat.com> References: <20210202162834.269789-1-kwolf@redhat.com> MIME-Version: 1.0 X-Scanned-By: MIMEDefang 2.79 on 10.5.11.15 Authentication-Results: relay.mimecast.com; auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=kwolf@redhat.com X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Received-SPF: pass client-ip=216.205.24.124; envelope-from=kwolf@redhat.com; helo=us-smtp-delivery-124.mimecast.com X-Spam_score_int: -31 X-Spam_score: -3.2 X-Spam_bar: --- X-Spam_report: (-3.2 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.386, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_LOW=-0.7, RCVD_IN_MSPIKE_H3=0.001, RCVD_IN_MSPIKE_WL=0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: kwolf@redhat.com, peter.maydell@linaro.org, qemu-devel@nongnu.org Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: "Qemu-devel" X-ZohoMail-DKIM: pass (identity @redhat.com) From: Philippe Mathieu-Daud=C3=A9 Commit 15b2260bef3 ("block/nvme: Trace controller capabilities") misunderstood the doorbell stride value from the datasheet, use the correct one. The 'doorbell_scale' variable used few lines later is correct. Signed-off-by: Philippe Mathieu-Daud=C3=A9 Message-Id: <20210127212137.3482291-2-philmd@redhat.com> Reviewed-by: Klaus Jensen Signed-off-by: Kevin Wolf --- block/nvme.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/block/nvme.c b/block/nvme.c index 5a6fbacf4a..80c4318d8f 100644 --- a/block/nvme.c +++ b/block/nvme.c @@ -745,7 +745,7 @@ static int nvme_init(BlockDriverState *bs, const char *= device, int namespace, trace_nvme_controller_capability("Contiguous Queues Required", NVME_CAP_CQR(cap)); trace_nvme_controller_capability("Doorbell Stride", - 2 << (2 + NVME_CAP_DSTRD(cap))); + 1 << (2 + NVME_CAP_DSTRD(cap))); trace_nvme_controller_capability("Subsystem Reset Supported", NVME_CAP_NSSRS(cap)); trace_nvme_controller_capability("Memory Page Size Minimum", --=20 2.29.2