From nobody Mon Feb 9 09:28:42 2026 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=fail(p=none dis=none) header.from=intel.com ARC-Seal: i=1; a=rsa-sha256; t=1612229365; cv=none; d=zohomail.com; s=zohoarc; b=QDX6zVInQGUF7VMbKcH51YFAQAwP3iwPX78oZCN4FpLbzZM1M+Ui6sZWnipALDkJqA0qtHI5NIRo595lFfGz2Bl4M0z1y0fTb5N3n01s50CE4SQ4a00rD9WNmRYsQyMTaNZvq8ORjI1BRVnLCY2dWJqhQ/pZTs2EBQiYGeIKyLg= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1612229365; h=Content-Transfer-Encoding:Cc:Date:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:To; bh=2lW/RN6cOu4FhOnmlT3xAcjW0Hy/O1rq9EGyntr7Fmg=; b=k7SXbKRLo2FGd8aB2zZ7HqlHBBYxa/OAzkqKYVzMitaR7ugpAWj4mGLxVKRkj6YxC6HQtbELqSmDum04Pt7OFpeNIguxhg1LEva7wmR8T5fcoO2nPX2BgcFCpHuj5O0RUhVZMb/uNUIRcBicylv4UJbBr1dBCFHhpamnEiDNWUs= ARC-Authentication-Results: i=1; mx.zohomail.com; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=fail header.from= (p=none dis=none) header.from= Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1612229364976562.4943851919782; Mon, 1 Feb 2021 17:29:24 -0800 (PST) Received: from localhost ([::1]:47248 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1l6kVP-0003jy-SG for importer@patchew.org; Mon, 01 Feb 2021 20:29:23 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]:47542) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1l6k4b-0001Cl-V1 for qemu-devel@nongnu.org; Mon, 01 Feb 2021 20:01:41 -0500 Received: from mga18.intel.com ([134.134.136.126]:33363) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1l6k4Y-0001oo-MA for qemu-devel@nongnu.org; Mon, 01 Feb 2021 20:01:41 -0500 Received: from fmsmga005.fm.intel.com ([10.253.24.32]) by orsmga106.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 01 Feb 2021 17:00:21 -0800 Received: from jambrizm-mobl1.amr.corp.intel.com (HELO bwidawsk-mobl5.local) ([10.252.133.15]) by fmsmga005-auth.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 01 Feb 2021 17:00:20 -0800 IronPort-SDR: 3TsdDgCIPMB778c1+pO7bXZm9acEOZzYOzUXhgWmrQ+7LFPU36FwLi/V3Q21cgbFC5QHhIU36d U6XV0cKuN8zQ== X-IronPort-AV: E=McAfee;i="6000,8403,9882"; a="168457142" X-IronPort-AV: E=Sophos;i="5.79,393,1602572400"; d="scan'208";a="168457142" IronPort-SDR: o8unHbL+Q7kfvn/BzE0nugN5IyABc3t75wJiLb2iU2DkxyzQ0LnwUzjx0UOP8+XpHs3E6r/8pq h8tnnGZoP38Q== X-IronPort-AV: E=Sophos;i="5.79,393,1602572400"; d="scan'208";a="581764272" From: Ben Widawsky To: qemu-devel@nongnu.org Subject: [RFC PATCH v3 27/31] hw/cxl/device: Add some trivial commands Date: Mon, 1 Feb 2021 16:59:44 -0800 Message-Id: <20210202005948.241655-28-ben.widawsky@intel.com> X-Mailer: git-send-email 2.30.0 In-Reply-To: <20210202005948.241655-1-ben.widawsky@intel.com> References: <20210202005948.241655-1-ben.widawsky@intel.com> MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Received-SPF: pass client-ip=134.134.136.126; envelope-from=ben.widawsky@intel.com; helo=mga18.intel.com X-Spam_score_int: -41 X-Spam_score: -4.2 X-Spam_bar: ---- X-Spam_report: (-4.2 / 5.0 requ) BAYES_00=-1.9, RCVD_IN_DNSWL_MED=-2.3, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Ben Widawsky , David Hildenbrand , Vishal Verma , "John Groves \(jgroves\)" , Chris Browy , Markus Armbruster , linux-cxl@vger.kernel.org, =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= , "Michael S. Tsirkin" , Jonathan Cameron , Igor Mammedov , Dan Williams , Ira Weiny Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: "Qemu-devel" Content-Type: text/plain; charset="utf-8" GET_FW_INFO and GET_PARTITION_INFO, for this emulation, is equivalent to info already returned in the IDENTIFY command. To have a more robust implementation, add those. Signed-off-by: Ben Widawsky --- hw/cxl/cxl-mailbox-utils.c | 65 ++++++++++++++++++++++++++++++++++++++ 1 file changed, 65 insertions(+) diff --git a/hw/cxl/cxl-mailbox-utils.c b/hw/cxl/cxl-mailbox-utils.c index f92dfad882..dc8e0eb08e 100644 --- a/hw/cxl/cxl-mailbox-utils.c +++ b/hw/cxl/cxl-mailbox-utils.c @@ -43,6 +43,8 @@ enum { #define CLEAR_RECORDS 0x1 #define GET_INTERRUPT_POLICY 0x2 #define SET_INTERRUPT_POLICY 0x3 + FIRMWARE_UPDATE =3D 0x02, + #define GET_INFO 0x0 TIMESTAMP =3D 0x03, #define GET 0x0 #define SET 0x1 @@ -51,6 +53,8 @@ enum { #define GET_LOG 0x1 IDENTIFY =3D 0x40, #define MEMORY_DEVICE 0x0 + CCLS =3D 0x41, + #define GET_PARTITION_INFO 0x0 }; =20 /* 8.2.8.4.5.1 Command Return Codes */ @@ -125,11 +129,13 @@ define_mailbox_handler_zeroed(EVENTS_GET_RECORDS, 0x2= 0); define_mailbox_handler_nop(EVENTS_CLEAR_RECORDS); define_mailbox_handler_zeroed(EVENTS_GET_INTERRUPT_POLICY, 4); define_mailbox_handler_nop(EVENTS_SET_INTERRUPT_POLICY); +declare_mailbox_handler(FIRMWARE_UPDATE_GET_INFO); declare_mailbox_handler(TIMESTAMP_GET); declare_mailbox_handler(TIMESTAMP_SET); declare_mailbox_handler(LOGS_GET_SUPPORTED); declare_mailbox_handler(LOGS_GET_LOG); declare_mailbox_handler(IDENTIFY_MEMORY_DEVICE); +declare_mailbox_handler(CCLS_GET_PARTITION_INFO); =20 #define IMMEDIATE_CONFIG_CHANGE (1 << 1) #define IMMEDIATE_POLICY_CHANGE (1 << 3) @@ -143,15 +149,50 @@ static struct cxl_cmd cxl_cmd_set[256][256] =3D { CXL_CMD(EVENTS, CLEAR_RECORDS, ~0, IMMEDIATE_LOG_CHANGE), CXL_CMD(EVENTS, GET_INTERRUPT_POLICY, 0, 0), CXL_CMD(EVENTS, SET_INTERRUPT_POLICY, 4, IMMEDIATE_CONFIG_CHANGE), + CXL_CMD(FIRMWARE_UPDATE, GET_INFO, 0, 0), CXL_CMD(TIMESTAMP, GET, 0, 0), CXL_CMD(TIMESTAMP, SET, 8, IMMEDIATE_POLICY_CHANGE), CXL_CMD(LOGS, GET_SUPPORTED, 0, 0), CXL_CMD(LOGS, GET_LOG, 0x18, 0), CXL_CMD(IDENTIFY, MEMORY_DEVICE, 0, 0), + CXL_CMD(CCLS, GET_PARTITION_INFO, 0, 0), }; =20 #undef CXL_CMD =20 +/* + * 8.2.9.2.1 + */ +define_mailbox_handler(FIRMWARE_UPDATE_GET_INFO) +{ + struct { + uint8_t slots_supported; + uint8_t slot_info; + uint8_t caps; + uint8_t rsvd[0xd]; + char fw_rev1[0x10]; + char fw_rev2[0x10]; + char fw_rev3[0x10]; + char fw_rev4[0x10]; + } __attribute__((packed)) *fw_info; + _Static_assert(sizeof(*fw_info) =3D=3D 0x50, "Bad firmware info size"); + + if (memory_region_size(cxl_dstate->pmem) < (256 << 20)) { + return CXL_MBOX_INTERNAL_ERROR; + } + + fw_info =3D (void *)cmd->payload; + memset(fw_info, 0, sizeof(*fw_info)); + + fw_info->slots_supported =3D 2; + fw_info->slot_info =3D BIT(0) | BIT(3); + fw_info->caps =3D 0; + snprintf(fw_info->fw_rev1, 0x10, "BWFW VERSION %02d", 0); + + *len =3D sizeof(*fw_info); + return CXL_MBOX_SUCCESS; +} + /* * 8.2.9.3.1 */ @@ -296,6 +337,30 @@ define_mailbox_handler(IDENTIFY_MEMORY_DEVICE) return CXL_MBOX_SUCCESS; } =20 +define_mailbox_handler(CCLS_GET_PARTITION_INFO) +{ + struct { + uint64_t active_vmem; + uint64_t active_pmem; + uint64_t next_vmem; + uint64_t next_pmem; + } __attribute__((packed)) *part_info =3D (void *)cmd->payload; + _Static_assert(sizeof(*part_info) =3D=3D 0x20, "Bad get partition info= size"); + + if (memory_region_size(cxl_dstate->pmem) < (256 << 20)) { + return CXL_MBOX_INTERNAL_ERROR; + } + + /* PMEM only */ + part_info->active_vmem =3D 0; + part_info->next_vmem =3D 0; + part_info->active_pmem =3D memory_region_size(cxl_dstate->pmem); + part_info->next_pmem =3D part_info->active_pmem; + + *len =3D sizeof(*part_info); + return CXL_MBOX_SUCCESS; +} + void cxl_process_mailbox(CXLDeviceState *cxl_dstate) { uint16_t ret =3D CXL_MBOX_SUCCESS; --=20 2.30.0