From nobody Mon May 20 22:42:42 2024 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=fail; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=fail(p=none dis=none) header.from=redhat.com ARC-Seal: i=1; a=rsa-sha256; t=1612210662; cv=none; d=zohomail.com; s=zohoarc; b=CIweDjDao3HT4iDcY2Ehq8uIl67i0EswlSPeCKagYuusyKzRO/P+mVUOjOdspFcoZPa2142tmffXZfcgV28OhbpeHguHVDjxDiR4X0IXCKBcBqPH2nMpnUdbmSRgffUoLgthlotXun4AMkbufn9UYBnO0zW9r5fRQKfZpaEIcqQ= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1612210662; h=Content-Type:Content-Transfer-Encoding:Cc:Date:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:To; bh=5tNDGb/HqWNFFO/Rt/GjJRHIGW1O/79FBPzb4IMZSUI=; b=hP58FYULzlyq0VwjbwkRh/mNrPcH2wRDFd7sXHmVe/Jw6f56KXr65Ub5l1zIJbsDw6LW1h9jCuolaWqaQbRbwQtAvZ0l+zTVmicX03CzrzyAOaVokyQ46WCatFtzppBd1e1G7BA7A7pdblclOFdyICCYJOZ81x7HXClgn0FQJDk= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=fail; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=fail header.from= (p=none dis=none) header.from= Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1612210662068807.1095644074466; Mon, 1 Feb 2021 12:17:42 -0800 (PST) Received: from localhost ([::1]:50208 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1l6fdk-0005TE-TH for importer@patchew.org; Mon, 01 Feb 2021 15:17:40 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]:57298) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1l6fb0-0003fa-0w for qemu-devel@nongnu.org; Mon, 01 Feb 2021 15:14:50 -0500 Received: from us-smtp-delivery-124.mimecast.com ([63.128.21.124]:26545) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA1:256) (Exim 4.90_1) (envelope-from ) id 1l6fax-0005Aa-UV for qemu-devel@nongnu.org; Mon, 01 Feb 2021 15:14:49 -0500 Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-438-WfbhwxqgMCCkitOIoJ-8Aw-1; Mon, 01 Feb 2021 15:14:45 -0500 Received: from smtp.corp.redhat.com (int-mx05.intmail.prod.int.phx2.redhat.com [10.5.11.15]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id 9B6A2800D55 for ; Mon, 1 Feb 2021 20:14:44 +0000 (UTC) Received: from localhost (unknown [10.36.110.27]) by smtp.corp.redhat.com (Postfix) with ESMTP id F26CD62460; Mon, 1 Feb 2021 20:14:37 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1612210487; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=5tNDGb/HqWNFFO/Rt/GjJRHIGW1O/79FBPzb4IMZSUI=; b=HsKt5JNtjzchQqvGBwJeOcl/Oo/HlZUEakLEb6N8HGoVFHeOBMKpjC8JbRcx05sWH1JrX4 gx9zCSrGYIlNV+tdaAPVk2laEea/wDaWRv1qyAoYczC60iwQaMJyqlfPZXzyiow6GnK3Pq 7laYtdY0+9I3fbsRZlLy112Vm7i0i8M= X-MC-Unique: WfbhwxqgMCCkitOIoJ-8Aw-1 From: marcandre.lureau@redhat.com To: qemu-devel@nongnu.org Subject: [PATCH 1/2] qxl: set qxl.ssd.dcl.con on secondary devices Date: Tue, 2 Feb 2021 00:14:21 +0400 Message-Id: <20210201201422.446552-2-marcandre.lureau@redhat.com> In-Reply-To: <20210201201422.446552-1-marcandre.lureau@redhat.com> References: <20210201201422.446552-1-marcandre.lureau@redhat.com> MIME-Version: 1.0 X-Scanned-By: MIMEDefang 2.79 on 10.5.11.15 Authentication-Results: relay.mimecast.com; auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=marcandre.lureau@redhat.com X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Received-SPF: pass client-ip=63.128.21.124; envelope-from=marcandre.lureau@redhat.com; helo=us-smtp-delivery-124.mimecast.com X-Spam_score_int: -30 X-Spam_score: -3.1 X-Spam_bar: --- X-Spam_report: (-3.1 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.351, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_LOW=-0.7, RCVD_IN_MSPIKE_H4=0.001, RCVD_IN_MSPIKE_WL=0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: =?UTF-8?q?Marc-Andr=C3=A9=20Lureau?= , Gerd Hoffmann Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: "Qemu-devel" X-ZohoMail-DKIM: fail (Header signature does not verify) From: Marc-Andr=C3=A9 Lureau On secondary QXL devices, the console is only set on qxl.vga.con. But graphic_hw_update_done() is called with qxl.ssd.dcl.con. Like for primary QXL devices, set qxl.sdd.dcl.con =3D qxl.vga.con. Signed-off-by: Marc-Andr=C3=A9 Lureau --- hw/display/qxl.c | 1 + 1 file changed, 1 insertion(+) diff --git a/hw/display/qxl.c b/hw/display/qxl.c index 431c107096..50f4756b6a 100644 --- a/hw/display/qxl.c +++ b/hw/display/qxl.c @@ -2266,6 +2266,7 @@ static void qxl_realize_secondary(PCIDevice *dev, Err= or **errp) qxl->vga.vram_size, &error_fatal); qxl->vga.vram_ptr =3D memory_region_get_ram_ptr(&qxl->vga.vram); qxl->vga.con =3D graphic_console_init(DEVICE(dev), 0, &qxl_ops, qxl); + qxl->ssd.dcl.con =3D qxl->vga.con; qxl->id =3D qemu_console_get_index(qxl->vga.con); /* =3D=3D channel_id= */ =20 qxl_realize_common(qxl, errp); --=20 2.29.0 From nobody Mon May 20 22:42:42 2024 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=fail; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=fail(p=none dis=none) header.from=redhat.com ARC-Seal: i=1; a=rsa-sha256; t=1612210733; cv=none; d=zohomail.com; s=zohoarc; b=ljnFKImYI64kRbl/lApMIejuvDGI9l4H4MsTI4Sr35Ge9ZbeaBEL/il3uo9dCyvcXnBiz3eDpKhbrz2+FYE8AIcHpHunUejuKXYCTMiKfFYxhzp/dzSutNzdUyWDy22sLChO0hsPxrfhxRHNHmkeBBEAII4E38dJxvO6dv25YH0= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1612210733; h=Content-Type:Content-Transfer-Encoding:Cc:Date:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:To; bh=anVCmEkZuqPEuOFOmVTZSm0mWzJ+vgZcmWCPZiBxC9k=; b=heYfPJq262Jqj6lLxKrDXq1kevCVWSDOWEuL+t/yPdHg+XXOCicYcgdKKRyYCkvIKfqORovEl2/6l/gmz13tsD6zST/ePft36n/hEri6YYDsi29H5oqwSQU/6elQhgPzOXdOgXQ/w5HKEed22+4mn6Ng5fhjCYCYXM2OJ3wBzyE= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=fail; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=fail header.from= (p=none dis=none) header.from= Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1612210733906458.0584064282806; Mon, 1 Feb 2021 12:18:53 -0800 (PST) Received: from localhost ([::1]:52542 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1l6feu-0006Th-PN for importer@patchew.org; Mon, 01 Feb 2021 15:18:52 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]:57344) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1l6fb6-0003md-V3 for qemu-devel@nongnu.org; Mon, 01 Feb 2021 15:14:56 -0500 Received: from us-smtp-delivery-124.mimecast.com ([63.128.21.124]:30424) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA1:256) (Exim 4.90_1) (envelope-from ) id 1l6fb5-0005Dz-FP for qemu-devel@nongnu.org; Mon, 01 Feb 2021 15:14:56 -0500 Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-310-lsCtQ0IhNb6WcC1wIR4LTw-1; Mon, 01 Feb 2021 15:14:52 -0500 Received: from smtp.corp.redhat.com (int-mx05.intmail.prod.int.phx2.redhat.com [10.5.11.15]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id C1CBD802B44 for ; Mon, 1 Feb 2021 20:14:51 +0000 (UTC) Received: from localhost (unknown [10.36.110.27]) by smtp.corp.redhat.com (Postfix) with ESMTP id DBA335D749; Mon, 1 Feb 2021 20:14:48 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1612210494; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=anVCmEkZuqPEuOFOmVTZSm0mWzJ+vgZcmWCPZiBxC9k=; b=WhdA8jnNJ1T2LHanmVKh2eo207lpXzPffToUha4z+U7tdzF53KjQCylL+Irc+6v1VA2F8m sKcxKGwFheqfs4sBHoaJBUR0IEZn9BR3miEAoP+qQIABnZa6rwKqpG5Jlp+MtxdCqcsZVM JudDv5v2V9WhD5DWIxLhfoaAbdQ2n+M= X-MC-Unique: lsCtQ0IhNb6WcC1wIR4LTw-1 From: marcandre.lureau@redhat.com To: qemu-devel@nongnu.org Subject: [PATCH 2/2] qxl: also notify the rendering is done when skipping it Date: Tue, 2 Feb 2021 00:14:22 +0400 Message-Id: <20210201201422.446552-3-marcandre.lureau@redhat.com> In-Reply-To: <20210201201422.446552-1-marcandre.lureau@redhat.com> References: <20210201201422.446552-1-marcandre.lureau@redhat.com> MIME-Version: 1.0 X-Scanned-By: MIMEDefang 2.79 on 10.5.11.15 Authentication-Results: relay.mimecast.com; auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=marcandre.lureau@redhat.com X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Received-SPF: pass client-ip=63.128.21.124; envelope-from=marcandre.lureau@redhat.com; helo=us-smtp-delivery-124.mimecast.com X-Spam_score_int: -30 X-Spam_score: -3.1 X-Spam_bar: --- X-Spam_report: (-3.1 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.351, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_LOW=-0.7, RCVD_IN_MSPIKE_H4=0.001, RCVD_IN_MSPIKE_WL=0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: =?UTF-8?q?Marc-Andr=C3=A9=20Lureau?= , Gerd Hoffmann Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: "Qemu-devel" X-ZohoMail-DKIM: fail (Header signature does not verify) From: Marc-Andr=C3=A9 Lureau Asynchronous handlers may be waiting for the graphic_hw_update_done() to be called in this case too. Fixes: 4d6316218 ("console: add graphic_hw_update_done()") Signed-off-by: Marc-Andr=C3=A9 Lureau --- hw/display/qxl-render.c | 1 + 1 file changed, 1 insertion(+) diff --git a/hw/display/qxl-render.c b/hw/display/qxl-render.c index 3ce2e57b8f..d28849b121 100644 --- a/hw/display/qxl-render.c +++ b/hw/display/qxl-render.c @@ -181,6 +181,7 @@ void qxl_render_update(PCIQXLDevice *qxl) qxl->mode =3D=3D QXL_MODE_UNDEFINED) { qxl_render_update_area_unlocked(qxl); qemu_mutex_unlock(&qxl->ssd.lock); + graphic_hw_update_done(qxl->ssd.dcl.con); return; } =20 --=20 2.29.0