From nobody Tue May 21 21:08:13 2024 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org ARC-Seal: i=1; a=rsa-sha256; t=1612114566; cv=none; d=zohomail.com; s=zohoarc; b=GLFqUmkZhPj5D92tDpeXF86DAZzh6PdvpbyYgAAp9j09T07RHylpbZ7JRuw6onw6STikHO6MvInR4F9V+9npUX54BtWmeqPanBYLf3k3oRqwjcDIe+H+BT43ri37BGLtNfg/sm1ITWU4Z0bMBo9rntqLDvSLvgudHaXcYY7F1OA= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1612114566; h=Content-Type:Content-Transfer-Encoding:Cc:Date:From:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:Sender:Subject:To; bh=c4crtgiwXactKrKEsOlP1IrXPGXH/5OSYijTiEzR8hk=; b=Taj1iXGTQPAeHuwLX0ldq86f+cNanRSMO54mNcqYzIDb7Obvj81YJwOwV7Td/DIoONKzo3YFIxvYlpV4ZLWdG/vDQePxPhhU+pYB/+3GG2X+N5S2+I8/HG1IoKxNWaIVlAKRV95Wf/LTQ+PU2kH6n+NaLbfGi6z2XRpSjiZMERw= ARC-Authentication-Results: i=1; mx.zohomail.com; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1612114566755668.0645115586784; Sun, 31 Jan 2021 09:36:06 -0800 (PST) Received: from localhost ([::1]:39250 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1l6Gdp-0007rs-Jq for importer@patchew.org; Sun, 31 Jan 2021 12:36:05 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]:45908) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1l6Gc9-00071H-J2 for qemu-devel@nongnu.org; Sun, 31 Jan 2021 12:34:21 -0500 Received: from mailout02.t-online.de ([194.25.134.17]:36940) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1l6Gc7-00031z-Ou for qemu-devel@nongnu.org; Sun, 31 Jan 2021 12:34:21 -0500 Received: from fwd41.aul.t-online.de (fwd41.aul.t-online.de [172.20.27.139]) by mailout02.t-online.de (Postfix) with SMTP id 7EA23419B17F; Sun, 31 Jan 2021 18:34:16 +0100 (CET) Received: from linpower.localnet (S+XiwZZ-8h8EL9GrRH7o5UwPlyH1tpIpp1rqsvl0C1r03B95ejssbHJ7D1yqUkQgGA@[93.236.159.226]) by fwd41.t-online.de with (TLSv1.2:ECDHE-RSA-AES256-GCM-SHA384 encrypted) esmtp id 1l6Gc4-3r1LiS0; Sun, 31 Jan 2021 18:34:16 +0100 Received: by linpower.localnet (Postfix, from userid 1000) id C7958200612; Sun, 31 Jan 2021 18:34:15 +0100 (CET) From: =?UTF-8?q?Volker=20R=C3=BCmelin?= To: Stefan Hajnoczi Subject: [PATCH] simpletrace: build() missing 2 required positional arguments Date: Sun, 31 Jan 2021 18:34:15 +0100 Message-Id: <20210131173415.3392-1-vr_qemu@t-online.de> X-Mailer: git-send-email 2.26.2 MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable X-ID: S+XiwZZ-8h8EL9GrRH7o5UwPlyH1tpIpp1rqsvl0C1r03B95ejssbHJ7D1yqUkQgGA X-TOI-EXPURGATEID: 150726::1612114456-00000C4D-4A31962E/0/0 CLEAN NORMAL X-TOI-MSGID: d97cfeb3-27b2-4c66-b820-b3418322b0e3 Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Received-SPF: none client-ip=194.25.134.17; envelope-from=volker.ruemelin@t-online.de; helo=mailout02.t-online.de X-Spam_score_int: -18 X-Spam_score: -1.9 X-Spam_bar: - X-Spam_report: (-1.9 / 5.0 requ) BAYES_00=-1.9, FREEMAIL_FROM=0.001, RCVD_IN_DNSWL_NONE=-0.0001, RCVD_IN_MSPIKE_H3=-0.01, RCVD_IN_MSPIKE_WL=-0.01, SPF_HELO_NONE=0.001, SPF_NONE=0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Cleber Rosa , QEMU , Eduardo Habkost Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: "Qemu-devel" Commit 4e66c9ef64 "tracetool: add input filename and line number to Event" forgot to add a line number and a filename argument at one build method call site. Traceback (most recent call last): File "./scripts/simpletrace.py", line 261, in run(Formatter()) File "./scripts/simpletrace.py", line 236, in run process(events, sys.argv[2], analyzer, read_header=3Dread_header) File "./scripts/simpletrace.py", line 177, in process dropped_event =3D Event.build("Dropped_Event(uint64_t num_events_dropped)") TypeError: build() missing 2 required positional arguments: 'lineno' and 'filename' Add the missing arguments. Signed-off-by: Volker R=C3=BCmelin Reviewed-by: Philippe Mathieu-Daud=C3=A9 --- scripts/simpletrace.py | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/scripts/simpletrace.py b/scripts/simpletrace.py index 20f0026066..d61fb0bd87 100755 --- a/scripts/simpletrace.py +++ b/scripts/simpletrace.py @@ -174,7 +174,9 @@ def process(events, log, analyzer, read_header=3DTrue): if read_header: read_trace_header(log) =20 - dropped_event =3D Event.build("Dropped_Event(uint64_t num_events_dropp= ed)") + frameinfo =3D inspect.getframeinfo(inspect.currentframe()) + dropped_event =3D Event.build("Dropped_Event(uint64_t num_events_dropp= ed)", + frameinfo.lineno + 1, frameinfo.filename) edict =3D {"dropped": dropped_event} idtoname =3D {dropped_event_id: "dropped"} =20 --=20 2.26.2