From nobody Wed May 22 01:27:13 2024 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org ARC-Seal: i=1; a=rsa-sha256; t=1611854633; cv=none; d=zohomail.com; s=zohoarc; b=Ct8KkwQbDt2+U0X0VxQVevhf2ATU3atUTXFfSJw2nS+ELBk1HPj/T+Eq7ZjMBinsjPRgjYTbvdGicJw1EAsyPPJkDXgYTA/GrjJOaZKLvB6c4X9DcrLgw0DouLTEmMzLrSOOeJsomgd8uBEoEe70z0A17X9hsibzFSAAa6atvr4= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1611854633; h=Content-Transfer-Encoding:Cc:Date:From:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:Sender:Subject:To; bh=+SFupzVgZWUTH1X8X7Nut3uwH3+kkj71fBFzzW30JB4=; b=ESo4gsxnCBCBR6XQeaXyPMFz5gUMorGwXWl9GeRDJJNrTVrCP1mhQ7mcZ12MfpJv+SAEsSa7CO53Wmxs6fDifymfgVUvH4cgzpA5vvsSQcS9CmFrZtrIaZHBL1vopHOISxg4X/3uoGM8x8dcVAZA0o+F5IuMs7P/laMuoBh9RWY= ARC-Authentication-Results: i=1; mx.zohomail.com; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1611854633676995.2254753553075; Thu, 28 Jan 2021 09:23:53 -0800 (PST) Received: from localhost ([::1]:49530 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1l5B1M-0007pA-60 for importer@patchew.org; Thu, 28 Jan 2021 12:23:52 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]:52774) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1l5Az6-0006LK-47 for qemu-devel@nongnu.org; Thu, 28 Jan 2021 12:21:32 -0500 Received: from p5b1511bf.dip0.t-ipconnect.de ([91.21.17.191]:51065 helo=mini.fritz.box) by eggs.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1l5Az4-0000Yz-BD for qemu-devel@nongnu.org; Thu, 28 Jan 2021 12:21:31 -0500 Received: by mini.fritz.box (Postfix, from userid 502) id 5682692C9A9; Thu, 28 Jan 2021 18:11:30 +0100 (CET) From: Stefan Weil To: =?UTF-8?q?Daniel=20P=20=2E=20Berrang=C3=A9?= Subject: [PATCH] tests: Fix runtime error in test-authz-pam Date: Thu, 28 Jan 2021 18:11:27 +0100 Message-Id: <20210128171127.45808-1-sw@weilnetz.de> X-Mailer: git-send-email 2.24.3 (Apple Git-128) MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Received-SPF: none client-ip=91.21.17.191; envelope-from=stefan@mini.fritz.box; helo=mini.fritz.box X-Spam_score_int: 21 X-Spam_score: 2.1 X-Spam_bar: ++ X-Spam_report: (2.1 / 5.0 requ) BAYES_00=-1.9, HEADER_FROM_DIFFERENT_DOMAINS=0.25, KHOP_HELO_FCRDNS=0.399, NO_DNS_FOR_FROM=0.001, RCVD_IN_PBL=3.335, RCVD_IN_SORBS_DUL=0.001, SPF_HELO_NONE=0.001, SPF_NONE=0.001 autolearn=no autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Stefan Weil , qemu-devel@nongnu.org Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: "Qemu-devel" Content-Type: text/plain; charset="utf-8" A test with sanitizers on macOS shows this error: authz/pamacct.c:50:25: runtime error: null pointer passed as argument 1= , which is declared to never be null /Applications/Xcode.app/Contents/Developer/Platforms/MacOSX.platform/De= veloper/SDKs/MacOSX.sdk/usr/include/security/pam_appl.h:56:2: note: nonnull= attribute specified here Signed-off-by: Stefan Weil Reviewed-by: Daniel P. Berrang=C3=A9 --- tests/test-authz-pam.c | 10 +++++++++- 1 file changed, 9 insertions(+), 1 deletion(-) diff --git a/tests/test-authz-pam.c b/tests/test-authz-pam.c index 1baeadee03..4fe1ef2603 100644 --- a/tests/test-authz-pam.c +++ b/tests/test-authz-pam.c @@ -28,7 +28,7 @@ static bool failauth; =20 /* - * These two functions are exported by libpam.so. + * These three functions are exported by libpam.so. * * By defining them again here, our impls are resolved * by the linker instead of those in libpam.so @@ -50,6 +50,7 @@ pam_start(const char *service_name, const char *user, failauth =3D false; } =20 + *pamh =3D (pam_handle_t *)0xbadeaffe; return PAM_SUCCESS; } =20 @@ -65,6 +66,13 @@ pam_acct_mgmt(pam_handle_t *pamh, int flags) } =20 =20 +int +pam_end(pam_handle_t *pamh, int status) +{ + return PAM_SUCCESS; +} + + static void test_authz_unknown_service(void) { Error *local_err =3D NULL; --=20 2.24.3 (Apple Git-128)