From nobody Tue May 21 08:12:34 2024 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=fail; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=fail(p=none dis=none) header.from=redhat.com ARC-Seal: i=1; a=rsa-sha256; t=1611839244; cv=none; d=zohomail.com; s=zohoarc; b=FJkMow4GRBWGA7pcA1jW9oYd9nLy/dujl+esGXr7q8h3O3qh0pWoEqljsxbpOcrBRVLmz4Q3KcF5c7evNBfkbuVLcXrBuhnjZFDKtgHqQl/arqJdOIhpwO2+ArJIiC1S38Yn6gwMlP2HKSgLmB5qdf0LDXm81DN9CFLn0U6wog0= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1611839244; h=Content-Type:Content-Transfer-Encoding:Cc:Date:From:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:Sender:Subject:To; bh=hSecMHZ53CtJAhaMvbaRwUuTLiEKnbpxQwnOUxylzI0=; b=Q88o9tXr/8YYqiwyL9QeV9imZjZJa1lPpWC83LtdJa61KUxF+xznOgHzVen8EZH50ly2hlo6xEn5RZZwKpkh8603BFJ/RdHmkbnUDE4ZJyNd626xe83EgwnxGDX+0l6t2uNCspaGpRg/OKg1MirETRS+jW+gQc2BbCm1ja6pMKY= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=fail; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=fail header.from= (p=none dis=none) header.from= Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1611839244691811.8478114886408; Thu, 28 Jan 2021 05:07:24 -0800 (PST) Received: from localhost ([::1]:57632 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1l5719-0001RV-Eg for importer@patchew.org; Thu, 28 Jan 2021 08:07:23 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]:49022) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1l570T-000117-7y for qemu-devel@nongnu.org; Thu, 28 Jan 2021 08:06:41 -0500 Received: from us-smtp-delivery-124.mimecast.com ([216.205.24.124]:49108) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA1:256) (Exim 4.90_1) (envelope-from ) id 1l570R-0000OG-Kf for qemu-devel@nongnu.org; Thu, 28 Jan 2021 08:06:41 -0500 Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-133-rKLQMXvSMRaJ8ybMGrfUbw-1; Thu, 28 Jan 2021 08:06:36 -0500 Received: from smtp.corp.redhat.com (int-mx08.intmail.prod.int.phx2.redhat.com [10.5.11.23]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id C44691075645 for ; Thu, 28 Jan 2021 13:06:35 +0000 (UTC) Received: from wainer-laptop.localdomain.com (ovpn-116-207.gru2.redhat.com [10.97.116.207]) by smtp.corp.redhat.com (Postfix) with ESMTP id 3FDD91F463; Thu, 28 Jan 2021 13:06:29 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1611839198; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=hSecMHZ53CtJAhaMvbaRwUuTLiEKnbpxQwnOUxylzI0=; b=XXttjURknF6sXPQVkF9Gf3Wo3nvNVfmo+CEztAk018NgfE9ZDBESoXK28RFhlgFTmKw7Y/ Ya0hxMz7yn7Khe+VsqOO7vb4a3mtsz/XUKMQb8OxLN/Ag8+ivfwYEE2nYtVbz2QUoCQzRR QR4CJLHgzgZQHcv4p7NVmvomMRI+kOg= X-MC-Unique: rKLQMXvSMRaJ8ybMGrfUbw-1 From: Wainer dos Santos Moschetta To: qemu-devel@nongnu.org Subject: [PATCH] migration/qemu-file: Fix maybe uninitialized on qemu_get_buffer_in_place() Date: Thu, 28 Jan 2021 10:06:25 -0300 Message-Id: <20210128130625.569900-1-wainersm@redhat.com> MIME-Version: 1.0 X-Scanned-By: MIMEDefang 2.84 on 10.5.11.23 Authentication-Results: relay.mimecast.com; auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=wainersm@redhat.com X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Transfer-Encoding: quoted-printable Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Received-SPF: pass client-ip=216.205.24.124; envelope-from=wainersm@redhat.com; helo=us-smtp-delivery-124.mimecast.com X-Spam_score_int: -29 X-Spam_score: -3.0 X-Spam_bar: --- X-Spam_report: (-3.0 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.252, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_LOW=-0.7, RCVD_IN_MSPIKE_H3=0.001, RCVD_IN_MSPIKE_WL=0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: dgilbert@redhat.com, quintela@redhat.com Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: "Qemu-devel" X-ZohoMail-DKIM: fail (Header signature does not verify) Content-Type: text/plain; charset="utf-8" Fixed error when compiling migration/qemu-file.c with -Werror=3Dmaybe-unini= tialized as shown here: ../migration/qemu-file.c: In function 'qemu_get_buffer_in_place': ../migration/qemu-file.c:604:18: error: 'src' may be used uninitialized in = this function [-Werror=3Dmaybe-uninitialized] 604 | *buf =3D src; | ~~~~~^~~~~ cc1: all warnings being treated as errors Signed-off-by: Wainer dos Santos Moschetta Reviewed-by: Dr. David Alan Gilbert --- Passed on CI: https://gitlab.com/wainersm/qemu/-/pipelines/247801576 migration/qemu-file.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/migration/qemu-file.c b/migration/qemu-file.c index be21518c57..d6e03dbc0e 100644 --- a/migration/qemu-file.c +++ b/migration/qemu-file.c @@ -595,7 +595,7 @@ size_t qemu_get_buffer_in_place(QEMUFile *f, uint8_t **= buf, size_t size) { if (size < IO_BUF_SIZE) { size_t res; - uint8_t *src; + uint8_t *src =3D NULL; =20 res =3D qemu_peek_buffer(f, &src, size, 0); =20 --=20 2.28.0