From nobody Fri Dec 19 04:32:23 2025 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass(p=none dis=none) header.from=redhat.com ARC-Seal: i=1; a=rsa-sha256; t=1611777568; cv=none; d=zohomail.com; s=zohoarc; b=MdM4RmGCWgUEWQkGmB2Wq9merzvrzXuLzl8MFen33YJMU3wsOMZxoTDNE00L1/vn4bG15vgmHeAkYxcxYMwb5YbXhJEAdPtAQIsO4pcaB0mg7mdzBRVT+1D9SRCpCcxLXfpOyF8vOo+ftfUK+BhuvLtvfo17Pnrdk3cRHtBpQhI= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1611777568; h=Content-Type:Content-Transfer-Encoding:Cc:Date:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:To; bh=PFfilSB76boeR/DJWsK1QUzerrVquPfXk1UmvqMyV64=; b=MelWj3gIS+O9gAWj2UAOXfFv7j99E0c8mwnOaXrYpwdjl1ucF2Z3fYmRg5N7bSXn1zPy8NNCVym987P6V8D6SuHDsde8TodO6U8jzu4HzASDb9PBZXCtvYy7KuxHOowG0N/tY4DMeStTd2eL+MFEvPTSSwn8Ka4h5DAiTm8xArs= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass header.from= (p=none dis=none) header.from= Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1611777568570270.1048265209208; Wed, 27 Jan 2021 11:59:28 -0800 (PST) Received: from localhost ([::1]:58990 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1l4qyM-0004sb-9z for importer@patchew.org; Wed, 27 Jan 2021 14:59:26 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]:55628) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1l4qx9-000309-IA for qemu-devel@nongnu.org; Wed, 27 Jan 2021 14:58:11 -0500 Received: from us-smtp-delivery-124.mimecast.com ([216.205.24.124]:46533) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA1:256) (Exim 4.90_1) (envelope-from ) id 1l4qx6-0007ZG-2O for qemu-devel@nongnu.org; Wed, 27 Jan 2021 14:58:11 -0500 Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-273-V02R1o0dMt2Wp6BTil2NDQ-1; Wed, 27 Jan 2021 14:58:04 -0500 Received: from smtp.corp.redhat.com (int-mx07.intmail.prod.int.phx2.redhat.com [10.5.11.22]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id EDAD71005513; Wed, 27 Jan 2021 19:58:02 +0000 (UTC) Received: from merkur.fritz.box (ovpn-115-94.ams2.redhat.com [10.36.115.94]) by smtp.corp.redhat.com (Postfix) with ESMTP id 005D010023B3; Wed, 27 Jan 2021 19:58:01 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1611777487; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=PFfilSB76boeR/DJWsK1QUzerrVquPfXk1UmvqMyV64=; b=JyWThmNJ9z6uxrQPXQzIfUfTB77GQUCc0ifSsnY2pcmAfNNcuPnC68Evbi249gEDiTCjCW pl/nwfF5/QsSm8iBwGZb/09UGv+PvPvL4KLMMR5xfG9rUp7A/WkOJlPogDCgJB9bzaomBA C4Dqt8SS77Zy2en3UUP7G3euyFxhRLk= X-MC-Unique: V02R1o0dMt2Wp6BTil2NDQ-1 From: Kevin Wolf To: qemu-block@nongnu.org Subject: [PULL 2/8] virtio-scsi-test: Test writing to scsi-cd device Date: Wed, 27 Jan 2021 20:57:47 +0100 Message-Id: <20210127195753.59773-3-kwolf@redhat.com> In-Reply-To: <20210127195753.59773-1-kwolf@redhat.com> References: <20210127195753.59773-1-kwolf@redhat.com> MIME-Version: 1.0 X-Scanned-By: MIMEDefang 2.84 on 10.5.11.22 Authentication-Results: relay.mimecast.com; auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=kwolf@redhat.com X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Received-SPF: pass client-ip=216.205.24.124; envelope-from=kwolf@redhat.com; helo=us-smtp-delivery-124.mimecast.com X-Spam_score_int: -30 X-Spam_score: -3.1 X-Spam_bar: --- X-Spam_report: (-3.1 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.308, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_LOW=-0.7, RCVD_IN_MSPIKE_H3=0.001, RCVD_IN_MSPIKE_WL=0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: kwolf@redhat.com, peter.maydell@linaro.org, qemu-devel@nongnu.org Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: "Qemu-devel" X-ZohoMail-DKIM: pass (identity @redhat.com) This tests that trying to write to a (read-only) scsi-cd device backed by a read-write image file doesn't crash and results in the correct error. This is a regression test for https://bugs.launchpad.net/bugs/1906693. Signed-off-by: Kevin Wolf Message-Id: <20210118123448.307825-3-kwolf@redhat.com> Reviewed-by: Philippe Mathieu-Daud=C3=A9 Reviewed-by: Max Reitz Signed-off-by: Kevin Wolf --- tests/qtest/virtio-scsi-test.c | 39 ++++++++++++++++++++++++++++++++++ 1 file changed, 39 insertions(+) diff --git a/tests/qtest/virtio-scsi-test.c b/tests/qtest/virtio-scsi-test.c index 0415e75876..1b7ecc1c8f 100644 --- a/tests/qtest/virtio-scsi-test.c +++ b/tests/qtest/virtio-scsi-test.c @@ -200,6 +200,32 @@ static void test_unaligned_write_same(void *obj, void = *data, qvirtio_scsi_pci_free(vs); } =20 +static void test_write_to_cdrom(void *obj, void *data, + QGuestAllocator *t_alloc) +{ + QVirtioSCSI *scsi =3D obj; + QVirtioSCSIQueues *vs; + uint8_t buf[2048] =3D { 0 }; + const uint8_t write_cdb[VIRTIO_SCSI_CDB_SIZE] =3D { + /* WRITE(10) to LBA 0, transfer length 1 */ + 0x2a, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x01, 0x00 + }; + struct virtio_scsi_cmd_resp resp; + + alloc =3D t_alloc; + vs =3D qvirtio_scsi_init(scsi->vdev); + + virtio_scsi_do_command(vs, write_cdb, NULL, 0, buf, 2048, &resp); + g_assert_cmphex(resp.response, =3D=3D, 0); + g_assert_cmphex(resp.status, =3D=3D, CHECK_CONDITION); + g_assert_cmphex(resp.sense[0], =3D=3D, 0x70); + g_assert_cmphex(resp.sense[2], =3D=3D, DATA_PROTECT); + g_assert_cmphex(resp.sense[12], =3D=3D, 0x27); /* WRITE PROTECTED */ + g_assert_cmphex(resp.sense[13], =3D=3D, 0x00); /* WRITE PROTECTED */ + + qvirtio_scsi_pci_free(vs); +} + static void test_iothread_attach_node(void *obj, void *data, QGuestAllocator *t_alloc) { @@ -267,6 +293,16 @@ static void *virtio_scsi_setup(GString *cmd_line, void= *arg) return arg; } =20 +static void *virtio_scsi_setup_cd(GString *cmd_line, void *arg) +{ + g_string_append(cmd_line, + " -drive file=3Dnull-co://," + "file.read-zeroes=3Don," + "if=3Dnone,id=3Ddr1,format=3Draw " + "-device scsi-cd,drive=3Ddr1,lun=3D0,scsi-id=3D1"); + return arg; +} + static void *virtio_scsi_setup_iothread(GString *cmd_line, void *arg) { g_string_append(cmd_line, @@ -287,6 +323,9 @@ static void register_virtio_scsi_test(void) qos_add_test("unaligned-write-same", "virtio-scsi", test_unaligned_write_same, &opts); =20 + opts.before =3D virtio_scsi_setup_cd; + qos_add_test("write-to-cdrom", "virtio-scsi", test_write_to_cdrom, &op= ts); + opts.before =3D virtio_scsi_setup_iothread; opts.edge =3D (QOSGraphEdgeOptions) { .extra_device_opts =3D "iothread=3Dthread0", --=20 2.29.2