From nobody Thu Dec 18 17:52:37 2025 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=fail; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=fail(p=none dis=none) header.from=redhat.com ARC-Seal: i=1; a=rsa-sha256; t=1611671689; cv=none; d=zohomail.com; s=zohoarc; b=YnXBZAkDE9op76a0bSDKLYkocCgfIQJlCxbmOul88wL2EIvWG7qv6pN5wGB9wmsWkZuXB/E6PcO/3z8m1kzA0JRElAjqpvrXCHMgxMoSMYFNZgp9iAxVPvK+knqwV+/UL2NARwZtH0XFKE+CoCe7iC4Lwm7ex3adAno3z1BQWLQ= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1611671689; h=Content-Type:Content-Transfer-Encoding:Cc:Date:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:To; bh=e2+2Y/wPhYxiFmvcTE0ZS2OuI+GYL0o292q/ywUGpo4=; b=KVSWtIojVuJ/CNjAWLNG0trPUeb+6snQSt5J3Rt5Op/aOLMobt5fuGWEFdvIUexRtTqXHDHYNGSN9wmPtkwBaTU24bXA6RUAH8bx89EHrsW4STfo0tIwX1HXDtglslbV5CGUG+YKEK8jYxABqLtjQjx5c1AuZAVTutHuCg+EM08= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=fail; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=fail header.from= (p=none dis=none) header.from= Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1611671689136319.98579596019715; Tue, 26 Jan 2021 06:34:49 -0800 (PST) Received: from localhost ([::1]:43600 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1l4PQe-0008I8-0n for importer@patchew.org; Tue, 26 Jan 2021 09:34:48 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]:46660) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1l4PDd-0000Gq-LG for qemu-devel@nongnu.org; Tue, 26 Jan 2021 09:21:21 -0500 Received: from us-smtp-delivery-124.mimecast.com ([63.128.21.124]:41789) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA1:256) (Exim 4.90_1) (envelope-from ) id 1l4PDV-00069W-Go for qemu-devel@nongnu.org; Tue, 26 Jan 2021 09:21:21 -0500 Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-36-HM_zyfHAOKKzzR1S_cMNHA-1; Tue, 26 Jan 2021 09:21:10 -0500 Received: from smtp.corp.redhat.com (int-mx07.intmail.prod.int.phx2.redhat.com [10.5.11.22]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id E249680BCBE; Tue, 26 Jan 2021 14:21:08 +0000 (UTC) Received: from localhost (ovpn-114-175.ams2.redhat.com [10.36.114.175]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 826F110023B2; Tue, 26 Jan 2021 14:21:08 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1611670872; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=e2+2Y/wPhYxiFmvcTE0ZS2OuI+GYL0o292q/ywUGpo4=; b=ZLjWy1kH9sN7MGvOCOrRDJ85wO1nRNasfSV6orjDZ3w7ZH+aHqalJURPk8eGZ80eiNNghG apSIWZhUYtSZgrn/aMRzZQMhJQCrGCxeTPvBWV4adEumbAaKuWcjlHKnTDzFn4lIaYEN53 hVzpz4d5SaNIHiX3kUIYSci3ZIPndUc= X-MC-Unique: HM_zyfHAOKKzzR1S_cMNHA-1 From: Max Reitz To: qemu-block@nongnu.org Subject: [PULL 22/53] iotests/129: Limit mirror job's buffer size Date: Tue, 26 Jan 2021 15:19:45 +0100 Message-Id: <20210126142016.806073-23-mreitz@redhat.com> In-Reply-To: <20210126142016.806073-1-mreitz@redhat.com> References: <20210126142016.806073-1-mreitz@redhat.com> MIME-Version: 1.0 X-Scanned-By: MIMEDefang 2.84 on 10.5.11.22 Authentication-Results: relay.mimecast.com; auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=mreitz@redhat.com X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Transfer-Encoding: quoted-printable Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Received-SPF: pass client-ip=63.128.21.124; envelope-from=mreitz@redhat.com; helo=us-smtp-delivery-124.mimecast.com X-Spam_score_int: -30 X-Spam_score: -3.1 X-Spam_bar: --- X-Spam_report: (-3.1 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.255, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_LOW=-0.7, RCVD_IN_MSPIKE_H4=0.001, RCVD_IN_MSPIKE_WL=0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Kevin Wolf , Peter Maydell , qemu-devel@nongnu.org, Max Reitz Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: "Qemu-devel" X-ZohoMail-DKIM: fail (Header signature does not verify) Content-Type: text/plain; charset="utf-8" Issuing 'stop' on the VM drains all nodes. If the mirror job has many large requests in flight, this may lead to significant I/O that looks a bit like 'stop' would make the job try to complete (which is what 129 should verify not to happen). We can limit the I/O in flight by limiting the buffer size, so mirror will make very little progress during the 'stop' drain. (We do not need to do anything about commit, which has a buffer size of 512 kB by default; or backup, which goes cluster by cluster. Once we have asynchronous requests for backup, that will change, but then we can fine-tune the backup job to only perform a single request on a very small chunk, too.) Signed-off-by: Max Reitz Reviewed-by: Eric Blake Reviewed-by: Vladimir Sementsov-Ogievskiy Reviewed-by: Willian Rampazzo Message-Id: <20210118105720.14824-9-mreitz@redhat.com> --- tests/qemu-iotests/129 | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/tests/qemu-iotests/129 b/tests/qemu-iotests/129 index f4b447b04a..03843fc255 100755 --- a/tests/qemu-iotests/129 +++ b/tests/qemu-iotests/129 @@ -68,7 +68,7 @@ class TestStopWithBlockJob(iotests.QMPTestCase): def test_drive_mirror(self): self.do_test_stop("drive-mirror", device=3D"drive0", target=3Dself.target_img, format=3Diotests.imgfm= t, - sync=3D"full") + sync=3D"full", buf_size=3D65536) =20 def test_drive_backup(self): self.do_test_stop("drive-backup", device=3D"drive0", --=20 2.29.2