From nobody Sun Feb 8 15:37:34 2026 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=fail; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=fail(p=none dis=none) header.from=redhat.com ARC-Seal: i=1; a=rsa-sha256; t=1611602903; cv=none; d=zohomail.com; s=zohoarc; b=LMb7jHKapKAY/8hz51u503CvVzXhBarBdRcgOLBO6HPI2P8SS7V3991csiy/pd6ORbTS4y1dgCTdeHoIK+ti2YZxVpQUxK6I1a84dxDvVmQApjcAFSR/1afwP5g5/UiQ6kcw0SxYrewJZKpH3dfkL7szeFu9Ma8qFEQOKRkEjF4= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1611602903; h=Content-Type:Content-Transfer-Encoding:Cc:Date:From:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:Sender:Subject:To; bh=npFNg3We8RmZoWPAl+lFXedY4757HvLmt+DYZGl1cJU=; b=MhgV2sp3jstlEcCQtdBmsqDlbYClGtjLXUHeKR9zazz68Z8H51KjQhfsAbx/gNWrADdD76VHKKw7TG+avNZVdOv4/xC6oeHpe/jPYtgUL40Fn/V28o7XScChEY2pVJHZUvQ6flmQNV9BFlxi7yPLmiRW5hEV+reZFTULjcpZxO4= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=fail; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=fail header.from= (p=none dis=none) header.from= Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1611602903960312.6551496647743; Mon, 25 Jan 2021 11:28:23 -0800 (PST) Received: from localhost ([::1]:48852 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1l47XC-0007pv-SY for importer@patchew.org; Mon, 25 Jan 2021 14:28:22 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]:42314) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1l47UI-0005Z8-0j for qemu-devel@nongnu.org; Mon, 25 Jan 2021 14:25:22 -0500 Received: from us-smtp-delivery-124.mimecast.com ([63.128.21.124]:41635) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA1:256) (Exim 4.90_1) (envelope-from ) id 1l47UF-0001g7-UA for qemu-devel@nongnu.org; Mon, 25 Jan 2021 14:25:21 -0500 Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-450-e29x4Z3pN9uP1aZz-koITw-1; Mon, 25 Jan 2021 14:25:15 -0500 Received: from smtp.corp.redhat.com (int-mx06.intmail.prod.int.phx2.redhat.com [10.5.11.16]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id 9881B1934102 for ; Mon, 25 Jan 2021 19:25:14 +0000 (UTC) Received: from eperezma.remote.csb (ovpn-112-128.ams2.redhat.com [10.36.112.128]) by smtp.corp.redhat.com (Postfix) with ESMTP id D85625C737; Mon, 25 Jan 2021 19:25:07 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1611602718; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=npFNg3We8RmZoWPAl+lFXedY4757HvLmt+DYZGl1cJU=; b=H4ruK1ljhtXjvZCLVsxILxdO4/tK+qZc/PG4Mjx0UHVrwgs/xmzEklGtfrBKN/I5d1vJE+ p6yqd0+73I0r4NyX8DKu0+q7qIix5ErFPI9TTy2viPBVhZIkTSxJP5gg5VhRyURk1UA5Ai ykclg3z9ADuvR8xPZmdXHDnvYCsNHzw= X-MC-Unique: e29x4Z3pN9uP1aZz-koITw-1 From: =?UTF-8?q?Eugenio=20P=C3=A9rez?= To: qemu-devel@nongnu.org Subject: [PATCH v2] virtio: Add corresponding memory_listener_unregister to unrealize Date: Mon, 25 Jan 2021 20:25:05 +0100 Message-Id: <20210125192505.390554-1-eperezma@redhat.com> MIME-Version: 1.0 X-Scanned-By: MIMEDefang 2.79 on 10.5.11.16 Authentication-Results: relay.mimecast.com; auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=eperezma@redhat.com X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Received-SPF: pass client-ip=63.128.21.124; envelope-from=eperezma@redhat.com; helo=us-smtp-delivery-124.mimecast.com X-Spam_score_int: -30 X-Spam_score: -3.1 X-Spam_bar: --- X-Spam_report: (-3.1 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.255, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_LOW=-0.7, RCVD_IN_MSPIKE_H4=0.001, RCVD_IN_MSPIKE_WL=0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Jason Wang , Peter Xu , "Michael S. Tsirkin" Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: "Qemu-devel" X-ZohoMail-DKIM: fail (Header signature does not verify) Address space is destroyed without proper removal of its listeners with current code. They are expected to be removed in virtio_device_instance_finalize [1], but qemu calls it through object_deinit, after address_space_destroy call through device_set_realized [2]. Move it to virtio_device_unrealize, called before device_set_realized [3] and making it symmetric with memory_listener_register in virtio_device_realize. v2: Delete no-op call of virtio_device_instance_finalize. Add backtraces. [1] #0 virtio_device_instance_finalize (obj=3D0x555557de5120) at /home/qemu/include/hw/virtio/virtio.h:71 #1 0x0000555555b703c9 in object_deinit (type=3D0x555556639860, obj=3D) at ../qom/object.c:671 #2 object_finalize (data=3D0x555557de5120) at ../qom/object.c:685 #3 object_unref (objptr=3D0x555557de5120) at ../qom/object.c:1184 #4 0x0000555555b4de9d in bus_free_bus_child (kid=3D0x555557df0660) at ../hw/core/qdev.c:55 #5 0x0000555555c65003 in call_rcu_thread (opaque=3Dopaque@entry=3D0x0) at ../util/rcu.c:281 Queued by: #0 bus_remove_child (bus=3D0x555557de5098, child=3Dchild@entry=3D0x555557de5120) at ../hw/core/qdev.c:60 #1 0x0000555555b4ee31 in device_unparent (obj=3D) at ../hw/core/qdev.c:984 #2 0x0000555555b70465 in object_finalize_child_property ( obj=3D, name=3D, opaque=3D0x555557de5120) at ../qom/object.c:1725 #3 0x0000555555b6fa17 in object_property_del_child ( child=3D0x555557de5120, obj=3D0x555557ddcf90) at ../qom/object.c:645 #4 object_unparent (obj=3D0x555557de5120) at ../qom/object.c:664 #5 0x0000555555b4c071 in bus_unparent (obj=3D) at ../hw/core/bus.c:147 #6 0x0000555555b70465 in object_finalize_child_property ( obj=3D, name=3D, opaque=3D0x555557de5098) at ../qom/object.c:1725 #7 0x0000555555b6fa17 in object_property_del_child ( child=3D0x555557de5098, obj=3D0x555557ddcf90) at ../qom/object.c:645 #8 object_unparent (obj=3D0x555557de5098) at ../qom/object.c:664 #9 0x0000555555b4ee19 in device_unparent (obj=3D) at ../hw/core/qdev.c:981 #10 0x0000555555b70465 in object_finalize_child_property ( obj=3D, name=3D, opaque=3D0x555557ddcf90) at ../qom/object.c:1725 #11 0x0000555555b6fa17 in object_property_del_child ( child=3D0x555557ddcf90, obj=3D0x55555685da10) at ../qom/object.c:645 #12 object_unparent (obj=3D0x555557ddcf90) at ../qom/object.c:664 #13 0x00005555558dc331 in pci_for_each_device_under_bus ( opaque=3D, fn=3D, bus=3D) at ../hw/pci/pci.c:1654 [2] Optimizer omits pci_qdev_unrealize, called by device_set_realized, and do_pci_unregister_device, called by pci_qdev_unrealize and caller of address_space_destroy. #0 address_space_destroy (as=3D0x555557ddd1b8) at ../softmmu/memory.c:2840 #1 0x0000555555b4fc53 in device_set_realized (obj=3D0x555557ddcf90, value=3D, errp=3D0x7fffeea8f1e0) at ../hw/core/qdev.c:850 #2 0x0000555555b6eaa6 in property_set_bool (obj=3D0x555557ddcf90, v=3D, name=3D, opaque=3D0x555556650ba0, errp=3D0x7fffeea8f1e0) at ../qom/object.c:2255 #3 0x0000555555b70e07 in object_property_set ( obj=3Dobj@entry=3D0x555557ddcf90, name=3Dname@entry=3D0x555555db99df "realized", v=3Dv@entry=3D0x7fffe46b7500, errp=3Derrp@entry=3D0x5555565bbf38 ) at ../qom/object.c:1400 #4 0x0000555555b73c5f in object_property_set_qobject ( obj=3Dobj@entry=3D0x555557ddcf90, name=3Dname@entry=3D0x555555db99df "realized", value=3Dvalue@entry=3D0x7fffe44f6180, errp=3Derrp@entry=3D0x5555565bbf38 ) at ../qom/qom-qobject.c:28 #5 0x0000555555b71044 in object_property_set_bool ( obj=3D0x555557ddcf90, name=3D0x555555db99df "realized", value=3D, errp=3D0x5555565bbf38 ) at ../qom/object.c:1470 #6 0x0000555555921cb7 in pcie_unplug_device (bus=3D, dev=3D0x555557ddcf90, opaque=3D) at /home/qemu/include/hw/qdev-core.h:17 #7 0x00005555558dc331 in pci_for_each_device_under_bus ( opaque=3D, fn=3D, bus=3D) at ../hw/pci/pci.c:1654 [3] #0 virtio_device_unrealize (dev=3D0x555557de5120) at ../hw/virtio/virtio.c:3680 #1 0x0000555555b4fc63 in device_set_realized (obj=3D0x555557de5120, value=3D, errp=3D0x7fffee28df90) at ../hw/core/qdev.c:850 #2 0x0000555555b6eab6 in property_set_bool (obj=3D0x555557de5120, v=3D, name=3D, opaque=3D0x555556650ba0, errp=3D0x7fffee28df90) at ../qom/object.c:2255 #3 0x0000555555b70e17 in object_property_set ( obj=3Dobj@entry=3D0x555557de5120, name=3Dname@entry=3D0x555555db99ff "realized", v=3Dv@entry=3D0x7ffdd8035040, errp=3Derrp@entry=3D0x5555565bbf38 ) at ../qom/object.c:1400 #4 0x0000555555b73c6f in object_property_set_qobject ( obj=3Dobj@entry=3D0x555557de5120, name=3Dname@entry=3D0x555555db99ff "realized", value=3Dvalue@entry=3D0x7ffdd8035020, errp=3Derrp@entry=3D0x5555565bbf38 ) at ../qom/qom-qobject.c:28 #5 0x0000555555b71054 in object_property_set_bool ( obj=3D0x555557de5120, name=3Dname@entry=3D0x555555db99ff "realized", value=3Dvalue@entry=3Dfalse, errp=3D0x5555565bbf38 ) at ../qom/object.c:1470 #6 0x0000555555b4edc5 in qdev_unrealize (dev=3D) at ../hw/core/qdev.c:403 #7 0x0000555555b4c2a9 in bus_set_realized (obj=3D, value=3D, errp=3D) at ../hw/core/bus.c:204 #8 0x0000555555b6eab6 in property_set_bool (obj=3D0x555557de5098, v=3D, name=3D, opaque=3D0x555557df04c0, errp=3D0x7fffee28e0a0) at ../qom/object.c:2255 #9 0x0000555555b70e17 in object_property_set ( obj=3Dobj@entry=3D0x555557de5098, name=3Dname@entry=3D0x555555db99ff "realized", v=3Dv@entry=3D0x7ffdd8034f50, errp=3Derrp@entry=3D0x5555565bbf38 ) at ../qom/object.c:1400 #10 0x0000555555b73c6f in object_property_set_qobject ( obj=3Dobj@entry=3D0x555557de5098, name=3Dname@entry=3D0x555555db99ff "realized", value=3Dvalue@entry=3D0x7ffdd8020630, errp=3Derrp@entry=3D0x5555565bbf38 ) at ../qom/qom-qobject.c:28 #11 0x0000555555b71054 in object_property_set_bool ( obj=3Dobj@entry=3D0x555557de5098, name=3Dname@entry=3D0x555555db99ff "realized", value=3Dvalue@entry=3Dfalse, errp=3D0x5555565bbf38 ) at ../qom/object.c:1470 #12 0x0000555555b4c725 in qbus_unrealize ( bus=3Dbus@entry=3D0x555557de5098) at ../hw/core/bus.c:178 #13 0x0000555555b4fc00 in device_set_realized (obj=3D0x555557ddcf90, value=3D, errp=3D0x7fffee28e1e0) at ../hw/core/qdev.c:844 #14 0x0000555555b6eab6 in property_set_bool (obj=3D0x555557ddcf90, v=3D, name=3D, opaque=3D0x555556650ba0, errp=3D0x7fffee28e1e0) at ../qom/object.c:2255 #15 0x0000555555b70e17 in object_property_set ( obj=3Dobj@entry=3D0x555557ddcf90, name=3Dname@entry=3D0x555555db99ff "realized", v=3Dv@entry=3D0x7ffdd8020560, errp=3Derrp@entry=3D0x5555565bbf38 ) at ../qom/object.c:1400 #16 0x0000555555b73c6f in object_property_set_qobject ( obj=3Dobj@entry=3D0x555557ddcf90, name=3Dname@entry=3D0x555555db99ff "realized", value=3Dvalue@entry=3D0x7ffdd8020540, errp=3Derrp@entry=3D0x5555565bbf38 ) at ../qom/qom-qobject.c:28 #17 0x0000555555b71054 in object_property_set_bool ( obj=3D0x555557ddcf90, name=3D0x555555db99ff "realized", value=3D, errp=3D0x5555565bbf38 ) at ../qom/object.c:1470 #18 0x0000555555921cb7 in pcie_unplug_device (bus=3D, dev=3D0x555557ddcf90, opaque=3D) at /home/qemu/include/hw/qdev-core.h:17 #19 0x00005555558dc331 in pci_for_each_device_under_bus ( opaque=3D, fn=3D, bus=3D) at ../hw/pci/pci.c:1654 Fixes: c611c76417f ("virtio: add MemoryListener to cache ring translations") Buglink: https://bugs.launchpad.net/qemu/+bug/1912846 Signed-off-by: Eugenio P=C3=A9rez Acked-by: Jason Wang Reviewed-by: Peter Xu Reviewed-by: Stefano Garzarella --- hw/virtio/virtio.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/hw/virtio/virtio.c b/hw/virtio/virtio.c index b308026596..1fd1917ca0 100644 --- a/hw/virtio/virtio.c +++ b/hw/virtio/virtio.c @@ -3680,6 +3680,7 @@ static void virtio_device_unrealize(DeviceState *dev) VirtIODevice *vdev =3D VIRTIO_DEVICE(dev); VirtioDeviceClass *vdc =3D VIRTIO_DEVICE_GET_CLASS(dev); =20 + memory_listener_unregister(&vdev->listener); virtio_bus_device_unplugged(vdev); =20 if (vdc->unrealize !=3D NULL) { @@ -3710,7 +3711,6 @@ static void virtio_device_instance_finalize(Object *o= bj) { VirtIODevice *vdev =3D VIRTIO_DEVICE(obj); =20 - memory_listener_unregister(&vdev->listener); virtio_device_free_virtqueues(vdev); =20 g_free(vdev->config); --=20 2.27.0