From nobody Tue Feb 10 04:07:56 2026 Delivered-To: importer@patchew.org Received-SPF: pass (zohomail.com: domain of _spf.google.com designates 209.85.221.49 as permitted sender) client-ip=209.85.221.49; envelope-from=philippe.mathieu.daude@gmail.com; helo=mail-wr1-f49.google.com; Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of _spf.google.com designates 209.85.221.49 as permitted sender) smtp.mailfrom=philippe.mathieu.daude@gmail.com ARC-Seal: i=1; a=rsa-sha256; t=1611519075; cv=none; d=zohomail.com; s=zohoarc; b=SPZxDw0cFLGPuE8N1cJAW9VrXS23O8QM6okks/+8csRog1d7XJ5hjIBW73Q8NVXNAm2mHF8ZPbOVbLl8Yehv1M+E4gvaQkfsMopeZt5i8A2oYgUO4uIJUQ+gPY/R86hi7zLn2lpIt4Nm82u9lAfiCe6h5iGDSCzlnpgtt3pgRl0= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1611519075; h=Content-Type:Content-Transfer-Encoding:Cc:Date:From:In-Reply-To:MIME-Version:Message-ID:References:Sender:Subject:To; bh=nIGaYtMUtzLf5rdS8bkm2HkUPDJfWchz2YtNrxVRdq4=; b=YVSyxmtR+t+4kCulhS8atvWy5sS6e2HDA4DoWaDl2eSBNNlutTyam7CIYnK4CUNgThDm272pCC+oNghD7tA84k5KPdLPJ/ihpf89gWgiMSXSKgcX2iEmrzxETVCzDPIsLblk6Do002iWnr6mo54ZmwogTEldarS4tDPwLvHnPI8= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of _spf.google.com designates 209.85.221.49 as permitted sender) smtp.mailfrom=philippe.mathieu.daude@gmail.com Received: from mail-wr1-f49.google.com (mail-wr1-f49.google.com [209.85.221.49]) by mx.zohomail.com with SMTPS id 1611519075472430.2243588280909; Sun, 24 Jan 2021 12:11:15 -0800 (PST) Received: by mail-wr1-f49.google.com with SMTP id 7so10232818wrz.0 for ; Sun, 24 Jan 2021 12:11:14 -0800 (PST) Return-Path: Return-Path: Received: from localhost.localdomain (13.red-83-57-169.dynamicip.rima-tde.net. [83.57.169.13]) by smtp.gmail.com with ESMTPSA id s4sm18856925wme.38.2021.01.24.12.11.12 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sun, 24 Jan 2021 12:11:13 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=sender:from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=nIGaYtMUtzLf5rdS8bkm2HkUPDJfWchz2YtNrxVRdq4=; b=HtUkrZQQUwxE9iQHgWW0HYZYroH1MLW8/th3GSat2+2/k054Q5Fb1CyFLMXm74B6MV r/U0NPRT5pOkZ5+0lGAuDZZfsjcY1E4HirC8YU0jQLeQxaZSVGBTMU9W5SmQL2L5jU5f jt+9NsQ39BC2P64qClQPyklThDiyydrRbjkBuU5c5C7Uj4HzN1qaFSOaYinnWYY/ZKZL gIYyafz0XDbnFBtYRkeE1O5pbzpTf1sPdJx+hLwWx/f//4TxyEppwVUcWboXCPkdophn +qPcqBZUqm6RQTw42TZlHr85FazQ2w0RuZSgfnDQ8mHr34VFuzXfoeTOyLmCnpjF1RHv P0aA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:sender:from:to:cc:subject:date:message-id :in-reply-to:references:mime-version:content-transfer-encoding; bh=nIGaYtMUtzLf5rdS8bkm2HkUPDJfWchz2YtNrxVRdq4=; b=fSbB8OrS6L75m/wwaWO+Uq/U7MoqUEYFmP+yrs1eOzhAonD3LIi+2dRR7nB2nihCzD KRt9KkcSwTKJZkmN4EpBsvfXXookhYMuZZxQ6Qel1sWECh0X86AzBH0PSmdBiwLeB1tS kpV5O/w6SI5nltH0DYlXkq3lcCGJF++F39ZyZ1MbQ3oiQu55N4lsCgDDUcqsVhwhxNFT 5C7r2XtOllnAnRmUFSSMG7ve63DlW30n+RHrFTgirFfVXNAOUKjR9Efmm9Jl+tZPHug0 QcPDnRnikgl2ubzi5rSFAeZZvP69YY+YJEAFGQdKUBQStKa9mJ5XRBi+fNaxUJ86kTBC BVyA== X-Gm-Message-State: AOAM531EBg2N5hkXILUwT4FJ9wp+kt0LLoyGazQjVJULMmIp5fXHwYQe vDYq7YUkGR73IdhXtls2Dbs= X-Google-Smtp-Source: ABdhPJzHEH0yvr/0cmF8efU0W1TCo1/rSo1EEU1O86a2Chmh5HaDfTYjATLzEAsR7Hbc94KqQJPhEw== X-Received: by 2002:a05:6000:188c:: with SMTP id a12mr14375845wri.105.1611519073814; Sun, 24 Jan 2021 12:11:13 -0800 (PST) Sender: =?UTF-8?Q?Philippe_Mathieu=2DDaud=C3=A9?= From: =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= To: qemu-devel@nongnu.org Cc: =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= , qemu-block@nongnu.org, Bin Meng , Pragnesh Patel Subject: [PULL 1/9] hw/sd: ssi-sd: Fix incorrect card response sequence Date: Sun, 24 Jan 2021 21:10:58 +0100 Message-Id: <20210124201106.2602238-2-f4bug@amsat.org> X-Mailer: git-send-email 2.26.2 In-Reply-To: <20210124201106.2602238-1-f4bug@amsat.org> References: <20210124201106.2602238-1-f4bug@amsat.org> MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable X-ZohoMail-DKIM: pass (identity @gmail.com) From: Bin Meng Per the "Physical Layer Specification Version 8.00" chapter 7.5.1, "Command/Response", there is a minimum 8 clock cycles (Ncr) before the card response shows up on the data out line. However current implementation jumps directly to the sending response state after all 6 bytes command is received, which is a spec violation. Add a new state PREP_RESP in the ssi-sd state machine to handle it. Fixes: 775616c3ae8c ("Partial SD card SPI mode support") Signed-off-by: Bin Meng Tested-by: Pragnesh Patel Reviewed-by: Pragnesh Patel Reviewed-by: Philippe Mathieu-Daud=C3=A9 Message-Id: <20210123104016.17485-4-bmeng.cn@gmail.com> [PMD: Change VMState version id 2 -> 3] Signed-off-by: Philippe Mathieu-Daud=C3=A9 --- hw/sd/ssi-sd.c | 11 ++++++++--- 1 file changed, 8 insertions(+), 3 deletions(-) diff --git a/hw/sd/ssi-sd.c b/hw/sd/ssi-sd.c index 9a75e0095cf..d97646795a2 100644 --- a/hw/sd/ssi-sd.c +++ b/hw/sd/ssi-sd.c @@ -36,6 +36,7 @@ do { fprintf(stderr, "ssi_sd: error: " fmt , ## __VA_ARGS= __);} while (0) typedef enum { SSI_SD_CMD =3D 0, SSI_SD_CMDARG, + SSI_SD_PREP_RESP, SSI_SD_RESPONSE, SSI_SD_DATA_START, SSI_SD_DATA_READ, @@ -163,12 +164,16 @@ static uint32_t ssi_sd_transfer(SSIPeripheral *dev, u= int32_t val) s->response[1] =3D status; DPRINTF("Card status 0x%02x\n", status); } - s->mode =3D SSI_SD_RESPONSE; + s->mode =3D SSI_SD_PREP_RESP; s->response_pos =3D 0; } else { s->cmdarg[s->arglen++] =3D val; } return 0xff; + case SSI_SD_PREP_RESP: + DPRINTF("Prepare card response (Ncr)\n"); + s->mode =3D SSI_SD_RESPONSE; + return 0xff; case SSI_SD_RESPONSE: if (s->stopping) { s->stopping =3D 0; @@ -224,8 +229,8 @@ static int ssi_sd_post_load(void *opaque, int version_i= d) =20 static const VMStateDescription vmstate_ssi_sd =3D { .name =3D "ssi_sd", - .version_id =3D 2, - .minimum_version_id =3D 2, + .version_id =3D 3, + .minimum_version_id =3D 3, .post_load =3D ssi_sd_post_load, .fields =3D (VMStateField []) { VMSTATE_UINT32(mode, ssi_sd_state), --=20 2.26.2