From nobody Mon Feb 9 09:52:01 2026 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass(p=none dis=none) header.from=gmail.com ARC-Seal: i=1; a=rsa-sha256; t=1611398675; cv=none; d=zohomail.com; s=zohoarc; b=mDDUQq3SMT2y7e6ke7eAuan4WImtADbFxYPKPHKtQ0fl9Dny7vey2rxaMAAZtQDbWbu12r3qWQXaR9AiCW4fp6IdyZ178vGv9xTxJLB3YfxDLW6MuWKiUAakz0k/lrdHdZp88OeUPZ/j499wWWZX3FnQVOhrZXIOaGw8dByAjZ4= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1611398675; h=Content-Transfer-Encoding:Cc:Date:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:To; bh=l6w90ZfsMt4jWRp3kwdSmprnCxB/Wq/3rVtoRL2E9es=; b=Huv7IG83eNRd+m82SbMdbMgrFu+EDWYP4ILAixi9st7KCiRRt5ULm1HRYHZYUYp+yIwjQHnVd8j/L2IocNoN+UQb4S/36qMi4Cf3F9TufN1DssPMD62/PqaGR/R/TKSYHOSVTc264A+/j1lTzqiwWA/MPZYztttbkByj/+1It3M= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass header.from= (p=none dis=none) header.from= Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1611398675458797.5749648078618; Sat, 23 Jan 2021 02:44:35 -0800 (PST) Received: from localhost ([::1]:54232 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1l3GPC-0005L0-6W for importer@patchew.org; Sat, 23 Jan 2021 05:44:34 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]:51010) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1l3GLT-00032f-J2; Sat, 23 Jan 2021 05:40:45 -0500 Received: from mail-pg1-x52e.google.com ([2607:f8b0:4864:20::52e]:39075) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1l3GLM-0002wP-4C; Sat, 23 Jan 2021 05:40:43 -0500 Received: by mail-pg1-x52e.google.com with SMTP id 30so5595825pgr.6; Sat, 23 Jan 2021 02:40:33 -0800 (PST) Received: from i9-aorus-gtx1080.localdomain (144.168.56.201.16clouds.com. [144.168.56.201]) by smtp.gmail.com with ESMTPSA id a5sm10575463pgl.41.2021.01.23.02.40.30 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sat, 23 Jan 2021 02:40:32 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=l6w90ZfsMt4jWRp3kwdSmprnCxB/Wq/3rVtoRL2E9es=; b=kDqUTyeND1B/c0uEFLg94OdJlqjE0M5qP6AbQ3LXjv8fIbftzVbwKgwnNFNSm5xM4p +jSmvhfzNsKMjXaftpLBriWIMoJhUru4f9tQn/F3PYzXlzPuTexmatMd8GtkaON2PQqs Z2u8DLXMybwjRUzq3nbv3ruOsCOiVBHGUQTiFQ4peJVkN9eqWIWaWBokw3Axtl8LoaGp QJe4LKL1vg0OS5PFcJFs0k+1S/WUeNooEImw0gNIA9CuBJ7fO2clA3Gz9YN6+JpptI4w HdGhN7qUiUrkUvvaxChFewBxDVeQfyZvvMcvNW/z5SgrpeVgbe2f9MTiHOlyrWNjYM1j roEA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=l6w90ZfsMt4jWRp3kwdSmprnCxB/Wq/3rVtoRL2E9es=; b=Gn+D4ca6iDEaZP22teUcc9JXAZ67DriP8sYhjD4jefpuSq6fZasfUmzzGnTGjImwWM oFKuf19eZ/zKFuvuSPtc90tWTviBRETdxRB9MtgWifgrX7jpdNNqXvdnAf+AJ3YBxxwI oMP7JgeVJonLh2wi7ywVi0endDwYFO9wdQX1fQHkGGIZ5wgy5pY7I5Vhrz8RAoxlkr1o iFGCJX+jpG4wEfhg6sPtIXkWyx8BnvOD2sUbHwxTyNEj61SHD6uME68L8IKgreswipaq PkS0ys8IUG1jYpufvg1mbhmGsS2K+IFdFnbnGHRjm9TfmAhyAjSkP+C9Rh44S9i76efr RDhg== X-Gm-Message-State: AOAM530CbQMFzQzUCEBgwBiex8nu+TGVg2CCn/F8KgDw90Cj4fJ+JcOa +RPM7I6c9WmCtP/xBfMsO2E= X-Google-Smtp-Source: ABdhPJyJKZpokHs/r76KJqGkLKROGbrV9Kq9bRKENrsF2rDCH+U+Zcp09wRXU0k/vO4AMNDag7QHlg== X-Received: by 2002:a63:50a:: with SMTP id 10mr2144683pgf.273.1611398432792; Sat, 23 Jan 2021 02:40:32 -0800 (PST) From: Bin Meng To: =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= , Alistair Francis , qemu-block@nongnu.org, qemu-riscv@nongnu.org, qemu-devel@nongnu.org Subject: [PATCH v2 03/25] hw/sd: ssi-sd: Fix incorrect card response sequence Date: Sat, 23 Jan 2021 18:39:54 +0800 Message-Id: <20210123104016.17485-4-bmeng.cn@gmail.com> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20210123104016.17485-1-bmeng.cn@gmail.com> References: <20210123104016.17485-1-bmeng.cn@gmail.com> MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Received-SPF: pass client-ip=2607:f8b0:4864:20::52e; envelope-from=bmeng.cn@gmail.com; helo=mail-pg1-x52e.google.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, FREEMAIL_FROM=0.001, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Bin Meng , Pragnesh Patel Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: "Qemu-devel" X-ZohoMail-DKIM: pass (identity @gmail.com) Content-Type: text/plain; charset="utf-8" From: Bin Meng Per the "Physical Layer Specification Version 8.00" chapter 7.5.1, "Command/Response", there is a minimum 8 clock cycles (Ncr) before the card response shows up on the data out line. However current implementation jumps directly to the sending response state after all 6 bytes command is received, which is a spec violation. Add a new state PREP_RESP in the ssi-sd state machine to handle it. Fixes: 775616c3ae8c ("Partial SD card SPI mode support") Signed-off-by: Bin Meng Reviewed-by: Pragnesh Patel Tested-by: Pragnesh Patel Reviewed-by: Philippe Mathieu-Daud=C3=A9 --- Changes in v2: - Add a debug printf in the state handling codes hw/sd/ssi-sd.c | 7 ++++++- 1 file changed, 6 insertions(+), 1 deletion(-) diff --git a/hw/sd/ssi-sd.c b/hw/sd/ssi-sd.c index 9a75e0095c..043e270066 100644 --- a/hw/sd/ssi-sd.c +++ b/hw/sd/ssi-sd.c @@ -36,6 +36,7 @@ do { fprintf(stderr, "ssi_sd: error: " fmt , ## __VA_ARGS= __);} while (0) typedef enum { SSI_SD_CMD =3D 0, SSI_SD_CMDARG, + SSI_SD_PREP_RESP, SSI_SD_RESPONSE, SSI_SD_DATA_START, SSI_SD_DATA_READ, @@ -163,12 +164,16 @@ static uint32_t ssi_sd_transfer(SSIPeripheral *dev, u= int32_t val) s->response[1] =3D status; DPRINTF("Card status 0x%02x\n", status); } - s->mode =3D SSI_SD_RESPONSE; + s->mode =3D SSI_SD_PREP_RESP; s->response_pos =3D 0; } else { s->cmdarg[s->arglen++] =3D val; } return 0xff; + case SSI_SD_PREP_RESP: + DPRINTF("Prepare card response (Ncr)\n"); + s->mode =3D SSI_SD_RESPONSE; + return 0xff; case SSI_SD_RESPONSE: if (s->stopping) { s->stopping =3D 0; --=20 2.25.1